[INFO] cloning repository https://github.com/Lilseec/textedit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Lilseec/textedit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLilseec%2Ftextedit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLilseec%2Ftextedit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 25fd1c504cd199ea5a5cfcc61069a41c7a11c2e1 [INFO] linting Lilseec/textedit against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLilseec%2Ftextedit" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Lilseec/textedit [INFO] finished tweaking git repo https://github.com/Lilseec/textedit [INFO] tweaked toml for git repo https://github.com/Lilseec/textedit written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Lilseec/textedit on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Lilseec/textedit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1064b0579fb545bd24c7852bbad94ba6fe477b3b6c2df0d52efe1525cf7775e8 [INFO] running `Command { std: "docker" "start" "-a" "1064b0579fb545bd24c7852bbad94ba6fe477b3b6c2df0d52efe1525cf7775e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1064b0579fb545bd24c7852bbad94ba6fe477b3b6c2df0d52efe1525cf7775e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1064b0579fb545bd24c7852bbad94ba6fe477b3b6c2df0d52efe1525cf7775e8", kill_on_drop: false }` [INFO] [stdout] 1064b0579fb545bd24c7852bbad94ba6fe477b3b6c2df0d52efe1525cf7775e8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 096b93948f0d03ccdee4cfb4db801d0043d48bf642c5d80a0af803e47d306dbb [INFO] running `Command { std: "docker" "start" "-a" "096b93948f0d03ccdee4cfb4db801d0043d48bf642c5d80a0af803e47d306dbb", kill_on_drop: false }` [INFO] [stderr] Checking textedit v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `rows` and `cols` are never read [INFO] [stdout] --> src/term.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct TermSize { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 29 | pub rows: u16, [INFO] [stdout] | ^^^^ [INFO] [stdout] 30 | pub cols: u16, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `move_teminal_cursor_up` is never used [INFO] [stdout] --> src/term.rs:130:8 [INFO] [stdout] | [INFO] [stdout] 130 | pub fn move_teminal_cursor_up() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `move_teminal_cursor_down` is never used [INFO] [stdout] --> src/term.rs:134:8 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn move_teminal_cursor_down() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `term_size` is never read [INFO] [stdout] --> src/editor/mod.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub (crate) struct Editor { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 11 | term_size: TermSize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `rows` and `cols` are never read [INFO] [stdout] --> src/term.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct TermSize { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 29 | pub rows: u16, [INFO] [stdout] | ^^^^ [INFO] [stdout] 30 | pub cols: u16, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `move_up` and `move_down` are never used [INFO] [stdout] --> src/editor/cursor/mod.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl Cursor { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 29 | pub fn move_up(&mut self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | pub fn move_down(&mut self) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `move_teminal_cursor_up` is never used [INFO] [stdout] --> src/term.rs:130:8 [INFO] [stdout] | [INFO] [stdout] 130 | pub fn move_teminal_cursor_up() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `move_teminal_cursor_down` is never used [INFO] [stdout] --> src/term.rs:134:8 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn move_teminal_cursor_down() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `term_size` is never read [INFO] [stdout] --> src/editor/mod.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub (crate) struct Editor { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 11 | term_size: TermSize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `move_up` and `move_down` are never used [INFO] [stdout] --> src/editor/cursor/mod.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl Cursor { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 29 | pub fn move_up(&mut self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | pub fn move_down(&mut self) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/editor/commands.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | / match command.as_str() { [INFO] [stdout] 15 | | "q" => self.quit(), [INFO] [stdout] 16 | | _ => (), [INFO] [stdout] 17 | | } [INFO] [stdout] | |_________^ help: try: `if command.as_str() == "q" { self.quit() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/editor/commands.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | / match command.as_str() { [INFO] [stdout] 15 | | "q" => self.quit(), [INFO] [stdout] 16 | | _ => (), [INFO] [stdout] 17 | | } [INFO] [stdout] | |_________^ help: try: `if command.as_str() == "q" { self.quit() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/editor/cursor/mod.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 18 | if !(self.col == old_col) { move_teminal_cursor_right() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.col != old_col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/editor/cursor/mod.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | self.col = self.col+1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.col += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/editor/cursor/mod.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if !(self.col == old_col) { move_teminal_cursor_left() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.col != old_col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/editor/cursor/mod.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | self.col = self.col - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.col -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/editor/cursor/mod.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 18 | if !(self.col == old_col) { move_teminal_cursor_right() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.col != old_col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/editor/cursor/mod.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | self.col = self.col+1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.col += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/editor/cursor/mod.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if !(self.col == old_col) { move_teminal_cursor_left() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.col != old_col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/editor/cursor/mod.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | self.col = self.col - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.col -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.12s [INFO] running `Command { std: "docker" "inspect" "096b93948f0d03ccdee4cfb4db801d0043d48bf642c5d80a0af803e47d306dbb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "096b93948f0d03ccdee4cfb4db801d0043d48bf642c5d80a0af803e47d306dbb", kill_on_drop: false }` [INFO] [stdout] 096b93948f0d03ccdee4cfb4db801d0043d48bf642c5d80a0af803e47d306dbb