[INFO] cloning repository https://github.com/LiRenTech/gen-sokoban [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LiRenTech/gen-sokoban" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLiRenTech%2Fgen-sokoban", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLiRenTech%2Fgen-sokoban'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 61e05b69d2b7d8ac9f0199a85aedacccbe1f7d54 [INFO] linting LiRenTech/gen-sokoban against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLiRenTech%2Fgen-sokoban" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/LiRenTech/gen-sokoban [INFO] finished tweaking git repo https://github.com/LiRenTech/gen-sokoban [INFO] tweaked toml for git repo https://github.com/LiRenTech/gen-sokoban written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/LiRenTech/gen-sokoban on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/LiRenTech/gen-sokoban already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1fa88b13d23b55bb3d0be9e6afe89861e62b57f562e9964586bf3b5e5abe289d [INFO] running `Command { std: "docker" "start" "-a" "1fa88b13d23b55bb3d0be9e6afe89861e62b57f562e9964586bf3b5e5abe289d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1fa88b13d23b55bb3d0be9e6afe89861e62b57f562e9964586bf3b5e5abe289d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1fa88b13d23b55bb3d0be9e6afe89861e62b57f562e9964586bf3b5e5abe289d", kill_on_drop: false }` [INFO] [stdout] 1fa88b13d23b55bb3d0be9e6afe89861e62b57f562e9964586bf3b5e5abe289d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3f80a4a8d3ff46f8fb5aaf08c4d1b39da50a84204bdcfe28e2677ec7e7946301 [INFO] running `Command { std: "docker" "start" "-a" "3f80a4a8d3ff46f8fb5aaf08c4d1b39da50a84204bdcfe28e2677ec7e7946301", kill_on_drop: false }` [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking rust-gen-sokoban v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `level_index` is never read [INFO] [stdout] --> src/game.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub struct Game { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 33 | pub level_index: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/game.rs:89:37 [INFO] [stdout] | [INFO] [stdout] 89 | let file = File::open(path).expect(&format!("无法打开关卡文件: {}", level_path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("无法打开关卡文件: {}", level_path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:190:27 [INFO] [stdout] | [INFO] [stdout] 190 | Tile::Wall => return false, // 撞墙 [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 190 - Tile::Wall => return false, // 撞墙 [INFO] [stdout] 190 + Tile::Wall => false, // 撞墙 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:202:17 [INFO] [stdout] | [INFO] [stdout] 202 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 - return true; [INFO] [stdout] 202 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:218:67 [INFO] [stdout] | [INFO] [stdout] 218 | Tile::Wall | Tile::Box | Tile::BoxOnTarget => return false, // 箱子后面有障碍 [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 218 - Tile::Wall | Tile::Box | Tile::BoxOnTarget => return false, // 箱子后面有障碍 [INFO] [stdout] 218 + Tile::Wall | Tile::Box | Tile::BoxOnTarget => false, // 箱子后面有障碍 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:241:25 [INFO] [stdout] | [INFO] [stdout] 241 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 241 - return true; [INFO] [stdout] 241 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:243:26 [INFO] [stdout] | [INFO] [stdout] 243 | _ => return false, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 243 - _ => return false, [INFO] [stdout] 243 + _ => false, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:246:18 [INFO] [stdout] | [INFO] [stdout] 246 | _ => return false, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 246 - _ => return false, [INFO] [stdout] 246 + _ => false, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/solver.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | let mut queue: VecDeque<((usize, usize), Vec<(usize, usize)>, u32)> = VecDeque::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/solver.rs:158:5 [INFO] [stdout] | [INFO] [stdout] 158 | / (up_wall && left_wall) || (up_wall && right_wall) || [INFO] [stdout] 159 | | (down_wall && left_wall) || (down_wall && right_wall) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 158 - (up_wall && left_wall) || (up_wall && right_wall) || [INFO] [stdout] 159 - (down_wall && left_wall) || (down_wall && right_wall) [INFO] [stdout] 158 + !(!left_wall && !right_wall || !up_wall && !down_wall) [INFO] [stdout] | [INFO] [stdout] 158 - (up_wall && left_wall) || (up_wall && right_wall) || [INFO] [stdout] 159 - (down_wall && left_wall) || (down_wall && right_wall) [INFO] [stdout] 158 + (down_wall || up_wall) && (right_wall || left_wall) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/solver.rs:158:5 [INFO] [stdout] | [INFO] [stdout] 158 | (up_wall && left_wall) || (up_wall && right_wall) || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 158 - (up_wall && left_wall) || (up_wall && right_wall) || [INFO] [stdout] 158 + !(!up_wall || !left_wall && !right_wall) || [INFO] [stdout] | [INFO] [stdout] 158 - (up_wall && left_wall) || (up_wall && right_wall) || [INFO] [stdout] 158 + (right_wall || left_wall) && up_wall || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/main.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | / if let KeyCode::Char('q') = code { [INFO] [stdout] 71 | | disable_raw_mode().unwrap(); [INFO] [stdout] 72 | | println!("\r\n游戏退出!"); [INFO] [stdout] 73 | | process::exit(0); [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:69:37 [INFO] [stdout] | [INFO] [stdout] 69 | if let Ok(Event::Key(KeyEvent { code, .. })) = event::read() { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 70 | if let KeyCode::Char('q') = code { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ with this pattern, prefixed by `code: ` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/main.rs:120:29 [INFO] [stdout] | [INFO] [stdout] 120 | / ... if let KeyCode::Char('q') = code { [INFO] [stdout] 121 | | ... disable_raw_mode().unwrap(); [INFO] [stdout] 122 | | ... println!("\r\n游戏退出!"); [INFO] [stdout] 123 | | ... process::exit(0); [INFO] [stdout] 124 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:119:57 [INFO] [stdout] | [INFO] [stdout] 119 | if let Ok(Event::Key(KeyEvent { code, kind: KeyEventKind::Press, .. })) = event::read() { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 120 | if let KeyCode::Char('q') = code { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ with this pattern, prefixed by `code: ` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `level_index` is never read [INFO] [stdout] --> src/game.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub struct Game { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 33 | pub level_index: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/game.rs:89:37 [INFO] [stdout] | [INFO] [stdout] 89 | let file = File::open(path).expect(&format!("无法打开关卡文件: {}", level_path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("无法打开关卡文件: {}", level_path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:190:27 [INFO] [stdout] | [INFO] [stdout] 190 | Tile::Wall => return false, // 撞墙 [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 190 - Tile::Wall => return false, // 撞墙 [INFO] [stdout] 190 + Tile::Wall => false, // 撞墙 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:202:17 [INFO] [stdout] | [INFO] [stdout] 202 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 - return true; [INFO] [stdout] 202 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:218:67 [INFO] [stdout] | [INFO] [stdout] 218 | Tile::Wall | Tile::Box | Tile::BoxOnTarget => return false, // 箱子后面有障碍 [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 218 - Tile::Wall | Tile::Box | Tile::BoxOnTarget => return false, // 箱子后面有障碍 [INFO] [stdout] 218 + Tile::Wall | Tile::Box | Tile::BoxOnTarget => false, // 箱子后面有障碍 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:241:25 [INFO] [stdout] | [INFO] [stdout] 241 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 241 - return true; [INFO] [stdout] 241 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:243:26 [INFO] [stdout] | [INFO] [stdout] 243 | _ => return false, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 243 - _ => return false, [INFO] [stdout] 243 + _ => false, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:246:18 [INFO] [stdout] | [INFO] [stdout] 246 | _ => return false, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 246 - _ => return false, [INFO] [stdout] 246 + _ => false, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/solver.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | let mut queue: VecDeque<((usize, usize), Vec<(usize, usize)>, u32)> = VecDeque::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/solver.rs:158:5 [INFO] [stdout] | [INFO] [stdout] 158 | / (up_wall && left_wall) || (up_wall && right_wall) || [INFO] [stdout] 159 | | (down_wall && left_wall) || (down_wall && right_wall) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 158 - (up_wall && left_wall) || (up_wall && right_wall) || [INFO] [stdout] 159 - (down_wall && left_wall) || (down_wall && right_wall) [INFO] [stdout] 158 + !(!left_wall && !right_wall || !up_wall && !down_wall) [INFO] [stdout] | [INFO] [stdout] 158 - (up_wall && left_wall) || (up_wall && right_wall) || [INFO] [stdout] 159 - (down_wall && left_wall) || (down_wall && right_wall) [INFO] [stdout] 158 + (down_wall || up_wall) && (right_wall || left_wall) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/solver.rs:158:5 [INFO] [stdout] | [INFO] [stdout] 158 | (up_wall && left_wall) || (up_wall && right_wall) || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 158 - (up_wall && left_wall) || (up_wall && right_wall) || [INFO] [stdout] 158 + !(!up_wall || !left_wall && !right_wall) || [INFO] [stdout] | [INFO] [stdout] 158 - (up_wall && left_wall) || (up_wall && right_wall) || [INFO] [stdout] 158 + (right_wall || left_wall) && up_wall || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/main.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | / if let KeyCode::Char('q') = code { [INFO] [stdout] 71 | | disable_raw_mode().unwrap(); [INFO] [stdout] 72 | | println!("\r\n游戏退出!"); [INFO] [stdout] 73 | | process::exit(0); [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:69:37 [INFO] [stdout] | [INFO] [stdout] 69 | if let Ok(Event::Key(KeyEvent { code, .. })) = event::read() { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 70 | if let KeyCode::Char('q') = code { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ with this pattern, prefixed by `code: ` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/main.rs:120:29 [INFO] [stdout] | [INFO] [stdout] 120 | / ... if let KeyCode::Char('q') = code { [INFO] [stdout] 121 | | ... disable_raw_mode().unwrap(); [INFO] [stdout] 122 | | ... println!("\r\n游戏退出!"); [INFO] [stdout] 123 | | ... process::exit(0); [INFO] [stdout] 124 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:119:57 [INFO] [stdout] | [INFO] [stdout] 119 | if let Ok(Event::Key(KeyEvent { code, kind: KeyEventKind::Press, .. })) = event::read() { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 120 | if let KeyCode::Char('q') = code { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ with this pattern, prefixed by `code: ` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.68s [INFO] running `Command { std: "docker" "inspect" "3f80a4a8d3ff46f8fb5aaf08c4d1b39da50a84204bdcfe28e2677ec7e7946301", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3f80a4a8d3ff46f8fb5aaf08c4d1b39da50a84204bdcfe28e2677ec7e7946301", kill_on_drop: false }` [INFO] [stdout] 3f80a4a8d3ff46f8fb5aaf08c4d1b39da50a84204bdcfe28e2677ec7e7946301