[INFO] cloning repository https://github.com/Let-Me-Use-A-Username/rust_server [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Let-Me-Use-A-Username/rust_server" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLet-Me-Use-A-Username%2Frust_server", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLet-Me-Use-A-Username%2Frust_server'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 273187a5e816ca8327c231c9f847186209784985 [INFO] linting Let-Me-Use-A-Username/rust_server against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLet-Me-Use-A-Username%2Frust_server" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Let-Me-Use-A-Username/rust_server [INFO] finished tweaking git repo https://github.com/Let-Me-Use-A-Username/rust_server [INFO] tweaked toml for git repo https://github.com/Let-Me-Use-A-Username/rust_server written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Let-Me-Use-A-Username/rust_server on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Let-Me-Use-A-Username/rust_server already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cron v0.8.0 [INFO] [stderr] Downloaded mirai-annotations v1.12.0 [INFO] [stderr] Downloaded tokio-cron-scheduler v0.5.0 [INFO] [stderr] Downloaded serde v1.0.206 [INFO] [stderr] Downloaded actix-session v0.10.0 [INFO] [stderr] Downloaded actix-tls v3.4.0 [INFO] [stderr] Downloaded indexmap v2.3.0 [INFO] [stderr] Downloaded cc v1.1.10 [INFO] [stderr] Downloaded serde_json v1.0.122 [INFO] [stderr] Downloaded nom v4.1.1 [INFO] [stderr] Downloaded serde_derive v1.0.206 [INFO] [stderr] Downloaded mio v1.0.1 [INFO] [stderr] Downloaded aws-lc-rs v1.8.1 [INFO] [stderr] Downloaded tokio v1.39.2 [INFO] [stderr] Downloaded aws-lc-sys v0.20.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cb35d20840ee11962639e5706c385534ec7c787cda6607224eeaae00111bea02 [INFO] running `Command { std: "docker" "start" "-a" "cb35d20840ee11962639e5706c385534ec7c787cda6607224eeaae00111bea02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cb35d20840ee11962639e5706c385534ec7c787cda6607224eeaae00111bea02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb35d20840ee11962639e5706c385534ec7c787cda6607224eeaae00111bea02", kill_on_drop: false }` [INFO] [stdout] cb35d20840ee11962639e5706c385534ec7c787cda6607224eeaae00111bea02 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4901d3e3bdb20b320acbafd1c3f1cde81c134eb6a0ce10bbb83236ef7d65f29d [INFO] running `Command { std: "docker" "start" "-a" "4901d3e3bdb20b320acbafd1c3f1cde81c134eb6a0ce10bbb83236ef7d65f29d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling syn v2.0.73 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking local-waker v0.1.4 [INFO] [stderr] Compiling serde v1.0.206 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking rustls-webpki v0.102.6 [INFO] [stderr] Checking actix-service v2.0.2 [INFO] [stderr] Compiling cc v1.1.10 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling tracing-core v0.1.32 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling bytestring v1.3.1 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Compiling cookie v0.16.2 [INFO] [stderr] Compiling regex-lite v0.1.6 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking impl-more v0.1.6 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking flate2 v1.0.31 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Checking base64 v0.20.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.206 [INFO] [stderr] Compiling actix-router v0.5.3 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking cron v0.8.0 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking actix-rt v2.10.0 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking tokio-cron-scheduler v0.5.0 [INFO] [stderr] Checking actix-server v2.5.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking actix-tls v3.4.0 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking actix-http v3.9.0 [INFO] [stderr] Checking rusqlite v0.32.1 [INFO] [stderr] Checking actix-web v4.9.0 [INFO] [stderr] Checking actix-session v0.10.0 [INFO] [stderr] Checking rust_server v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/database/handler.rs:9:24 [INFO] [stdout] | [INFO] [stdout] 9 | static DATABASE_PATH: &'static str = "./user_database.db3"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/models/database_models.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | id: id, [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/models/database_models.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | username: username, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/models/database_models.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | password: password, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `password` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/models/database_models.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | active_sessions: active_sessions, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `active_sessions` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/models/database_models.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | salt: salt [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `salt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/models/database_models.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | user_id: user_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/database/handler.rs:9:24 [INFO] [stdout] | [INFO] [stdout] 9 | static DATABASE_PATH: &'static str = "./user_database.db3"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/models/database_models.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | id: id, [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/models/database_models.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | username: username, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/models/database_models.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | password: password, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `password` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/models/database_models.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | active_sessions: active_sessions, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `active_sessions` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/models/database_models.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | salt: salt [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `salt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/models/database_models.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | user_id: user_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `handler` [INFO] [stdout] --> src/maintenance/maintainer.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | let handler = handler_op.lock().unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_handler` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `handler` [INFO] [stdout] --> src/maintenance/maintainer.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | let handler = handler_op.lock().unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_handler` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `query_db` is never used [INFO] [stdout] --> src/database/handler.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 15 | impl DatabaseHandler{ [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 72 | pub fn query_db(&self) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `connection` after checking its variant with `is_ok` [INFO] [stdout] --> src/database/handler.rs:22:29 [INFO] [stdout] | [INFO] [stdout] 20 | if connection.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = connection` [INFO] [stdout] 21 | return Ok(DatabaseHandler { [INFO] [stdout] 22 | connection: connection.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/database/handler.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return Err(connection.err().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Err(connection.err().unwrap()); [INFO] [stdout] 25 + Err(connection.err().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/database/handler.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return Ok(user.unwrap() + session.unwrap() + guest.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return Ok(user.unwrap() + session.unwrap() + guest.unwrap()) [INFO] [stdout] 68 + Ok(user.unwrap() + session.unwrap() + guest.unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/database/handler.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / if user.is_err(){ [INFO] [stdout] 42 | | return user [INFO] [stdout] 43 | | } [INFO] [stdout] | |_________^ help: replace it with: `user.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/database/handler.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | / if session.is_err(){ [INFO] [stdout] 54 | | return session [INFO] [stdout] 55 | | } [INFO] [stdout] | |_________^ help: replace it with: `session.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/database/handler.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / if guest.is_err(){ [INFO] [stdout] 65 | | return guest [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________^ help: replace it with: `guest.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/database/handler.rs:128:17 [INFO] [stdout] | [INFO] [stdout] 128 | return Err(error) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 - return Err(error) [INFO] [stdout] 128 + Err(error) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/database/handler.rs:162:17 [INFO] [stdout] | [INFO] [stdout] 162 | return Err(error) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - return Err(error) [INFO] [stdout] 162 + Err(error) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/database/handler.rs:136:49 [INFO] [stdout] | [INFO] [stdout] 136 | let statement = self.connection.prepare(&query.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `query.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/database/handler.rs:218:17 [INFO] [stdout] | [INFO] [stdout] 218 | return Err(error) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 218 - return Err(error) [INFO] [stdout] 218 + Err(error) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/database/handler.rs:208:32 [INFO] [stdout] | [INFO] [stdout] 208 | ... if sessions.len() == 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `sessions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `query_db` is never used [INFO] [stdout] --> src/database/handler.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 15 | impl DatabaseHandler{ [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 72 | pub fn query_db(&self) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `connection` after checking its variant with `is_ok` [INFO] [stdout] --> src/database/handler.rs:22:29 [INFO] [stdout] | [INFO] [stdout] 20 | if connection.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = connection` [INFO] [stdout] 21 | return Ok(DatabaseHandler { [INFO] [stdout] 22 | connection: connection.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/database/handler.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return Err(connection.err().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Err(connection.err().unwrap()); [INFO] [stdout] 25 + Err(connection.err().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/database/handler.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return Ok(user.unwrap() + session.unwrap() + guest.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return Ok(user.unwrap() + session.unwrap() + guest.unwrap()) [INFO] [stdout] 68 + Ok(user.unwrap() + session.unwrap() + guest.unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/database/handler.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / if user.is_err(){ [INFO] [stdout] 42 | | return user [INFO] [stdout] 43 | | } [INFO] [stdout] | |_________^ help: replace it with: `user.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/database/handler.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | / if session.is_err(){ [INFO] [stdout] 54 | | return session [INFO] [stdout] 55 | | } [INFO] [stdout] | |_________^ help: replace it with: `session.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/database/handler.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / if guest.is_err(){ [INFO] [stdout] 65 | | return guest [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________^ help: replace it with: `guest.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/database/handler.rs:128:17 [INFO] [stdout] | [INFO] [stdout] 128 | return Err(error) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 - return Err(error) [INFO] [stdout] 128 + Err(error) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/database_models.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return &self.id [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return &self.id [INFO] [stdout] 26 + &self.id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/database_models.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | return &self.username [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return &self.username [INFO] [stdout] 30 + &self.username [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/database_models.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return &self.password [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return &self.password [INFO] [stdout] 34 + &self.password [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/database/handler.rs:162:17 [INFO] [stdout] | [INFO] [stdout] 162 | return Err(error) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - return Err(error) [INFO] [stdout] 162 + Err(error) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/database_models.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return &self.active_sessions [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return &self.active_sessions [INFO] [stdout] 38 + &self.active_sessions [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/database_models.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return self.salt.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return self.salt.clone() [INFO] [stdout] 42 + self.salt.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/database_models.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | return &self.id [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return &self.id [INFO] [stdout] 62 + &self.id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/database_models.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | return &self.user_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - return &self.user_id [INFO] [stdout] 66 + &self.user_id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth/credentials.rs:84:40 [INFO] [stdout] | [INFO] [stdout] 84 | ... if !name_ins_status.is_ok() && !val_ins_status.is_ok(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `name_ins_status.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth/credentials.rs:84:68 [INFO] [stdout] | [INFO] [stdout] 84 | ... if !name_ins_status.is_ok() && !val_ins_status.is_ok(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `val_ins_status.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/database/handler.rs:136:49 [INFO] [stdout] | [INFO] [stdout] 136 | let statement = self.connection.prepare(&query.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `query.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/database/handler.rs:218:17 [INFO] [stdout] | [INFO] [stdout] 218 | return Err(error) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 218 - return Err(error) [INFO] [stdout] 218 + Err(error) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/credentials.rs:125:21 [INFO] [stdout] | [INFO] [stdout] 125 | return response [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return response [INFO] [stdout] 125 + response [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/credentials.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 129 | / return HttpResponse::InternalServerError() [INFO] [stdout] 130 | | .status(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stdout] 131 | | .json("Status : Database error.") [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 ~ HttpResponse::InternalServerError() [INFO] [stdout] 130 + .status(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stdout] 131 + .json("Status : Database error.") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/credentials.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | / return HttpResponse::InternalServerError() [INFO] [stdout] 140 | | .status(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stdout] 141 | | .json("Status : Database error. Initialization failed.") [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 ~ HttpResponse::InternalServerError() [INFO] [stdout] 140 + .status(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stdout] 141 + .json("Status : Database error. Initialization failed.") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/database/handler.rs:208:32 [INFO] [stdout] | [INFO] [stdout] 208 | ... if sessions.len() == 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `sessions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/auth/credentials.rs:20:56 [INFO] [stdout] | [INFO] [stdout] 20 | let hashed_username = hasher.hash_username(&username); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `username` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/auth/credentials.rs:96:97 [INFO] [stdout] | [INFO] [stdout] 96 | ... if database_handler.id_exists(&String::from("session"), &created_session.get_id()).is_ok_and(|x| x == false){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `created_session.get_id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/auth/credentials.rs:96:138 [INFO] [stdout] | [INFO] [stdout] 96 | ... if database_handler.id_exists(&String::from("session"), &created_session.get_id()).is_ok_and(|x| x == false){ [INFO] [stdout] | ^^^^^^^^^^ help: try: `!x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/credentials.rs:208:5 [INFO] [stdout] | [INFO] [stdout] 208 | / return HttpResponse::BadRequest() [INFO] [stdout] 209 | | .status(StatusCode::BAD_REQUEST) [INFO] [stdout] 210 | | .json("Status : Invalid password.") [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 ~ HttpResponse::BadRequest() [INFO] [stdout] 209 + .status(StatusCode::BAD_REQUEST) [INFO] [stdout] 210 + .json("Status : Invalid password.") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/auth/credentials.rs:157:60 [INFO] [stdout] | [INFO] [stdout] 157 | let hashed_username = hasher.hash_username(&username); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `username` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/auth/credentials.rs:168:106 [INFO] [stdout] | [INFO] [stdout] 168 | ... if database_handler.id_exists(&String::from("user"), &user_id).is_ok_and(|x| x == false){ [INFO] [stdout] | ^^^^^^^^^^ help: try: `!x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/credentials.rs:263:13 [INFO] [stdout] | [INFO] [stdout] 263 | / return HttpResponse::InternalServerError() [INFO] [stdout] 264 | | .status(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stdout] 265 | | .json("Status : Database error. Connection dropped.") [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 ~ HttpResponse::InternalServerError() [INFO] [stdout] 264 + .status(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stdout] 265 + .json("Status : Database error. Connection dropped.") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/credentials.rs:297:5 [INFO] [stdout] | [INFO] [stdout] 297 | return has_length && has_digit && has_letter && has_special_char [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 297 - return has_length && has_digit && has_letter && has_special_char [INFO] [stdout] 297 + has_length && has_digit && has_letter && has_special_char [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/auth/credentials.rs:273:27 [INFO] [stdout] | [INFO] [stdout] 273 | pub fn sanitize(password: &String) -> bool{ [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 273 - pub fn sanitize(password: &String) -> bool{ [INFO] [stdout] 273 + pub fn sanitize(password: &str) -> bool{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/hasher.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 22 | return result [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return result [INFO] [stdout] 22 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/database_models.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return &self.id [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return &self.id [INFO] [stdout] 26 + &self.id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/database_models.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | return &self.username [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return &self.username [INFO] [stdout] 30 + &self.username [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/database_models.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return &self.password [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return &self.password [INFO] [stdout] 34 + &self.password [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/database_models.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return &self.active_sessions [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return &self.active_sessions [INFO] [stdout] 38 + &self.active_sessions [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/database_models.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return self.salt.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return self.salt.clone() [INFO] [stdout] 42 + self.salt.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/database_models.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | return &self.id [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return &self.id [INFO] [stdout] 62 + &self.id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/hasher.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 29 | return SaltString::encode_b64(new_credentials.as_bytes()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return SaltString::encode_b64(new_credentials.as_bytes()).unwrap() [INFO] [stdout] 29 + SaltString::encode_b64(new_credentials.as_bytes()).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/hasher.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return hash [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return hash [INFO] [stdout] 40 + hash [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/database_models.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | return &self.user_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - return &self.user_id [INFO] [stdout] 66 + &self.user_id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/hasher.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 48 | Ok(hash) => return Ok(hash.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - Ok(hash) => return Ok(hash.to_string()), [INFO] [stdout] 48 + Ok(hash) => Ok(hash.to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/hasher.rs:49:27 [INFO] [stdout] | [INFO] [stdout] 49 | Err(error) => return Err(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - Err(error) => return Err(error), [INFO] [stdout] 49 + Err(error) => Err(error), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth/credentials.rs:84:40 [INFO] [stdout] | [INFO] [stdout] 84 | ... if !name_ins_status.is_ok() && !val_ins_status.is_ok(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `name_ins_status.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth/credentials.rs:84:68 [INFO] [stdout] | [INFO] [stdout] 84 | ... if !name_ins_status.is_ok() && !val_ins_status.is_ok(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `val_ins_status.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/sessions.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | return Session::new(session_id, *user_id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return Session::new(session_id, *user_id) [INFO] [stdout] 18 + Session::new(session_id, *user_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/credentials.rs:125:21 [INFO] [stdout] | [INFO] [stdout] 125 | return response [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return response [INFO] [stdout] 125 + response [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/sessions.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return Session::new(session_id, user_id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return Session::new(session_id, user_id) [INFO] [stdout] 26 + Session::new(session_id, user_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/credentials.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 129 | / return HttpResponse::InternalServerError() [INFO] [stdout] 130 | | .status(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stdout] 131 | | .json("Status : Database error.") [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 ~ HttpResponse::InternalServerError() [INFO] [stdout] 130 + .status(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stdout] 131 + .json("Status : Database error.") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/credentials.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | / return HttpResponse::InternalServerError() [INFO] [stdout] 140 | | .status(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stdout] 141 | | .json("Status : Database error. Initialization failed.") [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 ~ HttpResponse::InternalServerError() [INFO] [stdout] 140 + .status(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stdout] 141 + .json("Status : Database error. Initialization failed.") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/auth/credentials.rs:20:56 [INFO] [stdout] | [INFO] [stdout] 20 | let hashed_username = hasher.hash_username(&username); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `username` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/maintenance/maintainer.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | return scheduler.add(job); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return scheduler.add(job); [INFO] [stdout] 35 + scheduler.add(job) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/maintenance/maintainer.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | return "".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return "".to_string() [INFO] [stdout] 51 + "".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/auth/credentials.rs:96:97 [INFO] [stdout] | [INFO] [stdout] 96 | ... if database_handler.id_exists(&String::from("session"), &created_session.get_id()).is_ok_and(|x| x == false){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `created_session.get_id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/auth/credentials.rs:96:138 [INFO] [stdout] | [INFO] [stdout] 96 | ... if database_handler.id_exists(&String::from("session"), &created_session.get_id()).is_ok_and(|x| x == false){ [INFO] [stdout] | ^^^^^^^^^^ help: try: `!x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/credentials.rs:208:5 [INFO] [stdout] | [INFO] [stdout] 208 | / return HttpResponse::BadRequest() [INFO] [stdout] 209 | | .status(StatusCode::BAD_REQUEST) [INFO] [stdout] 210 | | .json("Status : Invalid password.") [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 ~ HttpResponse::BadRequest() [INFO] [stdout] 209 + .status(StatusCode::BAD_REQUEST) [INFO] [stdout] 210 + .json("Status : Invalid password.") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/auth/credentials.rs:157:60 [INFO] [stdout] | [INFO] [stdout] 157 | let hashed_username = hasher.hash_username(&username); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `username` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/auth/credentials.rs:168:106 [INFO] [stdout] | [INFO] [stdout] 168 | ... if database_handler.id_exists(&String::from("user"), &user_id).is_ok_and(|x| x == false){ [INFO] [stdout] | ^^^^^^^^^^ help: try: `!x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/credentials.rs:263:13 [INFO] [stdout] | [INFO] [stdout] 263 | / return HttpResponse::InternalServerError() [INFO] [stdout] 264 | | .status(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stdout] 265 | | .json("Status : Database error. Connection dropped.") [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 ~ HttpResponse::InternalServerError() [INFO] [stdout] 264 + .status(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stdout] 265 + .json("Status : Database error. Connection dropped.") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/credentials.rs:297:5 [INFO] [stdout] | [INFO] [stdout] 297 | return has_length && has_digit && has_letter && has_special_char [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 297 - return has_length && has_digit && has_letter && has_special_char [INFO] [stdout] 297 + has_length && has_digit && has_letter && has_special_char [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/auth/credentials.rs:273:27 [INFO] [stdout] | [INFO] [stdout] 273 | pub fn sanitize(password: &String) -> bool{ [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 273 - pub fn sanitize(password: &String) -> bool{ [INFO] [stdout] 273 + pub fn sanitize(password: &str) -> bool{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/hasher.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 22 | return result [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return result [INFO] [stdout] 22 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/hasher.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 29 | return SaltString::encode_b64(new_credentials.as_bytes()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return SaltString::encode_b64(new_credentials.as_bytes()).unwrap() [INFO] [stdout] 29 + SaltString::encode_b64(new_credentials.as_bytes()).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/hasher.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return hash [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return hash [INFO] [stdout] 40 + hash [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/hasher.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 48 | Ok(hash) => return Ok(hash.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - Ok(hash) => return Ok(hash.to_string()), [INFO] [stdout] 48 + Ok(hash) => Ok(hash.to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/hasher.rs:49:27 [INFO] [stdout] | [INFO] [stdout] 49 | Err(error) => return Err(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - Err(error) => return Err(error), [INFO] [stdout] 49 + Err(error) => Err(error), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/sessions.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | return Session::new(session_id, *user_id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return Session::new(session_id, *user_id) [INFO] [stdout] 18 + Session::new(session_id, *user_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth/sessions.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return Session::new(session_id, user_id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return Session::new(session_id, user_id) [INFO] [stdout] 26 + Session::new(session_id, user_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/maintenance/maintainer.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | return scheduler.add(job); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return scheduler.add(job); [INFO] [stdout] 35 + scheduler.add(job) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/maintenance/maintainer.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | return "".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return "".to_string() [INFO] [stdout] 51 + "".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 38s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v4.1.1 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "4901d3e3bdb20b320acbafd1c3f1cde81c134eb6a0ce10bbb83236ef7d65f29d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4901d3e3bdb20b320acbafd1c3f1cde81c134eb6a0ce10bbb83236ef7d65f29d", kill_on_drop: false }` [INFO] [stdout] 4901d3e3bdb20b320acbafd1c3f1cde81c134eb6a0ce10bbb83236ef7d65f29d