[INFO] cloning repository https://github.com/Leon-Degel-Koehn/chesslib [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Leon-Degel-Koehn/chesslib" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeon-Degel-Koehn%2Fchesslib", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeon-Degel-Koehn%2Fchesslib'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bddbe5e8d8de3bfd740e87baf96315ee16e9d413 [INFO] linting Leon-Degel-Koehn/chesslib against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeon-Degel-Koehn%2Fchesslib" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Leon-Degel-Koehn/chesslib [INFO] finished tweaking git repo https://github.com/Leon-Degel-Koehn/chesslib [INFO] tweaked toml for git repo https://github.com/Leon-Degel-Koehn/chesslib written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Leon-Degel-Koehn/chesslib on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Leon-Degel-Koehn/chesslib already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 301b01c1c084a01e06cb6fda53d8255525b20424e186afdaac0f8eee44452d51 [INFO] running `Command { std: "docker" "start" "-a" "301b01c1c084a01e06cb6fda53d8255525b20424e186afdaac0f8eee44452d51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "301b01c1c084a01e06cb6fda53d8255525b20424e186afdaac0f8eee44452d51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "301b01c1c084a01e06cb6fda53d8255525b20424e186afdaac0f8eee44452d51", kill_on_drop: false }` [INFO] [stdout] 301b01c1c084a01e06cb6fda53d8255525b20424e186afdaac0f8eee44452d51 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2cf00c454284974c1431ed1f703cf399924c7fe66901842a2208e2f45b1bf169 [INFO] running `Command { std: "docker" "start" "-a" "2cf00c454284974c1431ed1f703cf399924c7fe66901842a2208e2f45b1bf169", kill_on_drop: false }` [INFO] [stderr] Checking fen v0.1.0 [INFO] [stderr] Checking chesslib v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/end_state.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | return simulation_board.player_in_check(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return simulation_board.player_in_check(); [INFO] [stdout] 19 + simulation_board.player_in_check() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/end_state.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | return self.board.legal_moves().len() == 0 && self.current_player_in_check(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return self.board.legal_moves().len() == 0 && self.current_player_in_check(); [INFO] [stdout] 22 + self.board.legal_moves().len() == 0 && self.current_player_in_check() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/end_state.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 22 | return self.board.legal_moves().len() == 0 && self.current_player_in_check(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.board.legal_moves().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/end_state.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return self.board.legal_moves().len() == 0 && !self.current_player_in_check(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return self.board.legal_moves().len() == 0 && !self.current_player_in_check(); [INFO] [stdout] 25 + self.board.legal_moves().len() == 0 && !self.current_player_in_check() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/end_state.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 25 | return self.board.legal_moves().len() == 0 && !self.current_player_in_check(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.board.legal_moves().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/end_state.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return true; [INFO] [stdout] 33 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/end_state.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | return simulation_board.player_in_check(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return simulation_board.player_in_check(); [INFO] [stdout] 19 + simulation_board.player_in_check() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/end_state.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return Some(Color::inverse_color(&self.board.side_to_play)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return Some(Color::inverse_color(&self.board.side_to_play)); [INFO] [stdout] 39 + Some(Color::inverse_color(&self.board.side_to_play)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/end_state.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | return self.board.legal_moves().len() == 0 && self.current_player_in_check(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return self.board.legal_moves().len() == 0 && self.current_player_in_check(); [INFO] [stdout] 22 + self.board.legal_moves().len() == 0 && self.current_player_in_check() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/end_state.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 22 | return self.board.legal_moves().len() == 0 && self.current_player_in_check(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.board.legal_moves().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/end_state.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / return self.board.fullmove_number >= 100 [INFO] [stdout] 43 | | || self.insufficient_material() [INFO] [stdout] 44 | | || self.current_player_is_stalemate() [INFO] [stdout] 45 | | || self.draw_by_repetition; [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 ~ self.board.fullmove_number >= 100 [INFO] [stdout] 43 + || self.insufficient_material() [INFO] [stdout] 44 + || self.current_player_is_stalemate() [INFO] [stdout] 45 ~ || self.draw_by_repetition [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/end_state.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return self.board.legal_moves().len() == 0 && !self.current_player_in_check(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return self.board.legal_moves().len() == 0 && !self.current_player_in_check(); [INFO] [stdout] 25 + self.board.legal_moves().len() == 0 && !self.current_player_in_check() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/end_state.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 25 | return self.board.legal_moves().len() == 0 && !self.current_player_in_check(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.board.legal_moves().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/end_state.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return true; [INFO] [stdout] 33 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/end_state.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return Some(Color::inverse_color(&self.board.side_to_play)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return Some(Color::inverse_color(&self.board.side_to_play)); [INFO] [stdout] 39 + Some(Color::inverse_color(&self.board.side_to_play)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/end_state.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / return self.board.fullmove_number >= 100 [INFO] [stdout] 43 | | || self.insufficient_material() [INFO] [stdout] 44 | | || self.current_player_is_stalemate() [INFO] [stdout] 45 | | || self.draw_by_repetition; [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 ~ self.board.fullmove_number >= 100 [INFO] [stdout] 43 + || self.insufficient_material() [INFO] [stdout] 44 + || self.current_player_is_stalemate() [INFO] [stdout] 45 ~ || self.draw_by_repetition [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/move_generation.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 75 | if !king_square.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `king_square.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | / return opponent_moves [INFO] [stdout] 84 | | .iter() [INFO] [stdout] 85 | | .any(|mov| mov.end_square as usize == king_square); [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 ~ opponent_moves [INFO] [stdout] 84 + .iter() [INFO] [stdout] 85 ~ .any(|mov| mov.end_square as usize == king_square) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/move_generation.rs:85:24 [INFO] [stdout] | [INFO] [stdout] 85 | .any(|mov| mov.end_square as usize == king_square); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `mov.end_square` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | return simulation_board.player_in_check(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return simulation_board.player_in_check(); [INFO] [stdout] 90 + simulation_board.player_in_check() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return moves; [INFO] [stdout] 95 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/move_generation.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 75 | if !king_square.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `king_square.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | / return opponent_moves [INFO] [stdout] 84 | | .iter() [INFO] [stdout] 85 | | .any(|mov| mov.end_square as usize == king_square); [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 ~ opponent_moves [INFO] [stdout] 84 + .iter() [INFO] [stdout] 85 ~ .any(|mov| mov.end_square as usize == king_square) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return moves; [INFO] [stdout] 147 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/move_generation.rs:85:24 [INFO] [stdout] | [INFO] [stdout] 85 | .any(|mov| mov.end_square as usize == king_square); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `mov.end_square` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | return simulation_board.player_in_check(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return simulation_board.player_in_check(); [INFO] [stdout] 90 + simulation_board.player_in_check() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return moves; [INFO] [stdout] 95 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 201 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 - return moves; [INFO] [stdout] 201 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return moves; [INFO] [stdout] 147 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/move_generation.rs:176:42 [INFO] [stdout] | [INFO] [stdout] 176 | let target_square = add_rank(square as usize, move_dir * move_dist) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `square` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 201 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 - return moves; [INFO] [stdout] 201 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:238:9 [INFO] [stdout] | [INFO] [stdout] 238 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 238 - return moves; [INFO] [stdout] 238 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/move_generation.rs:176:42 [INFO] [stdout] | [INFO] [stdout] 176 | let target_square = add_rank(square as usize, move_dir * move_dist) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `square` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | return self.straight_line_moves(square, move_dirs, true, None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 243 - return self.straight_line_moves(square, move_dirs, true, None); [INFO] [stdout] 243 + self.straight_line_moves(square, move_dirs, true, None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:248:9 [INFO] [stdout] | [INFO] [stdout] 248 | return self.straight_line_moves(square, move_dirs, true, None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 248 - return self.straight_line_moves(square, move_dirs, true, None); [INFO] [stdout] 248 + self.straight_line_moves(square, move_dirs, true, None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:254:9 [INFO] [stdout] | [INFO] [stdout] 254 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - return moves; [INFO] [stdout] 254 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:258:9 [INFO] [stdout] | [INFO] [stdout] 258 | return self.generate_directed_castle(square, 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 258 - return self.generate_directed_castle(square, 1); [INFO] [stdout] 258 + self.generate_directed_castle(square, 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | return self.generate_directed_castle(square, -1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 262 - return self.generate_directed_castle(square, -1); [INFO] [stdout] 262 + self.generate_directed_castle(square, -1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:299:9 [INFO] [stdout] | [INFO] [stdout] 299 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 299 - return moves; [INFO] [stdout] 299 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:238:9 [INFO] [stdout] | [INFO] [stdout] 238 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 238 - return moves; [INFO] [stdout] 238 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | return self.straight_line_moves(square, move_dirs, true, None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 243 - return self.straight_line_moves(square, move_dirs, true, None); [INFO] [stdout] 243 + self.straight_line_moves(square, move_dirs, true, None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:248:9 [INFO] [stdout] | [INFO] [stdout] 248 | return self.straight_line_moves(square, move_dirs, true, None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 248 - return self.straight_line_moves(square, move_dirs, true, None); [INFO] [stdout] 248 + self.straight_line_moves(square, move_dirs, true, None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:254:9 [INFO] [stdout] | [INFO] [stdout] 254 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - return moves; [INFO] [stdout] 254 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:258:9 [INFO] [stdout] | [INFO] [stdout] 258 | return self.generate_directed_castle(square, 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 258 - return self.generate_directed_castle(square, 1); [INFO] [stdout] 258 + self.generate_directed_castle(square, 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | return self.generate_directed_castle(square, -1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 262 - return self.generate_directed_castle(square, -1); [INFO] [stdout] 262 + self.generate_directed_castle(square, -1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:299:9 [INFO] [stdout] | [INFO] [stdout] 299 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 299 - return moves; [INFO] [stdout] 299 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:306:9 [INFO] [stdout] | [INFO] [stdout] 306 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 306 - return moves; [INFO] [stdout] 306 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 324 - return moves; [INFO] [stdout] 324 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:306:9 [INFO] [stdout] | [INFO] [stdout] 306 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 306 - return moves; [INFO] [stdout] 306 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 324 - return moves; [INFO] [stdout] 324 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:354:9 [INFO] [stdout] | [INFO] [stdout] 354 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 354 - return moves; [INFO] [stdout] 354 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:354:9 [INFO] [stdout] | [INFO] [stdout] 354 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 354 - return moves; [INFO] [stdout] 354 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:379:9 [INFO] [stdout] | [INFO] [stdout] 379 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 379 - return moves; [INFO] [stdout] 379 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_generation.rs:379:9 [INFO] [stdout] | [INFO] [stdout] 379 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 379 - return moves; [INFO] [stdout] 379 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_utils.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / return Self { [INFO] [stdout] 60 | | start_square, [INFO] [stdout] 61 | | end_square, [INFO] [stdout] 62 | | promotion: None, [INFO] [stdout] 63 | | is_en_passant: false, [INFO] [stdout] 64 | | castles: false, [INFO] [stdout] 65 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 ~ Self { [INFO] [stdout] 60 + start_square, [INFO] [stdout] 61 + end_square, [INFO] [stdout] 62 + promotion: None, [INFO] [stdout] 63 + is_en_passant: false, [INFO] [stdout] 64 + castles: false, [INFO] [stdout] 65 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_utils.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / return Self { [INFO] [stdout] 60 | | start_square, [INFO] [stdout] 61 | | end_square, [INFO] [stdout] 62 | | promotion: None, [INFO] [stdout] 63 | | is_en_passant: false, [INFO] [stdout] 64 | | castles: false, [INFO] [stdout] 65 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 ~ Self { [INFO] [stdout] 60 + start_square, [INFO] [stdout] 61 + end_square, [INFO] [stdout] 62 + promotion: None, [INFO] [stdout] 63 + is_en_passant: false, [INFO] [stdout] 64 + castles: false, [INFO] [stdout] 65 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_utils.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | / return Move { [INFO] [stdout] 93 | | start_square, [INFO] [stdout] 94 | | end_square, [INFO] [stdout] 95 | | promotion, [INFO] [stdout] 96 | | is_en_passant, [INFO] [stdout] 97 | | castles, [INFO] [stdout] 98 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 ~ Move { [INFO] [stdout] 93 + start_square, [INFO] [stdout] 94 + end_square, [INFO] [stdout] 95 + promotion, [INFO] [stdout] 96 + is_en_passant, [INFO] [stdout] 97 + castles, [INFO] [stdout] 98 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_utils.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | / return Move { [INFO] [stdout] 93 | | start_square, [INFO] [stdout] 94 | | end_square, [INFO] [stdout] 95 | | promotion, [INFO] [stdout] 96 | | is_en_passant, [INFO] [stdout] 97 | | castles, [INFO] [stdout] 98 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 ~ Move { [INFO] [stdout] 93 + start_square, [INFO] [stdout] 94 + end_square, [INFO] [stdout] 95 + promotion, [INFO] [stdout] 96 + is_en_passant, [INFO] [stdout] 97 + castles, [INFO] [stdout] 98 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_utils.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | / return format!( [INFO] [stdout] 113 | | "{}{}{}", [INFO] [stdout] 114 | | square_to_string(self.start_square), [INFO] [stdout] 115 | | square_to_string(self.end_square), [INFO] [stdout] 116 | | promotion, [INFO] [stdout] 117 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 ~ format!( [INFO] [stdout] 113 + "{}{}{}", [INFO] [stdout] 114 + square_to_string(self.start_square), [INFO] [stdout] 115 + square_to_string(self.end_square), [INFO] [stdout] 116 + promotion, [INFO] [stdout] 117 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_utils.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | / return format!( [INFO] [stdout] 113 | | "{}{}{}", [INFO] [stdout] 114 | | square_to_string(self.start_square), [INFO] [stdout] 115 | | square_to_string(self.end_square), [INFO] [stdout] 116 | | promotion, [INFO] [stdout] 117 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 ~ format!( [INFO] [stdout] 113 + "{}{}{}", [INFO] [stdout] 114 + square_to_string(self.start_square), [INFO] [stdout] 115 + square_to_string(self.end_square), [INFO] [stdout] 116 + promotion, [INFO] [stdout] 117 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_utils.rs:197:21 [INFO] [stdout] | [INFO] [stdout] 197 | None => return, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 197 - None => return, [INFO] [stdout] 197 + None => (), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_utils.rs:197:21 [INFO] [stdout] | [INFO] [stdout] 197 | None => return, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 197 - None => return, [INFO] [stdout] 197 + None => (), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_utils.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | return board.pieces[self.end_square].is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 - return board.pieces[self.end_square].is_some(); [INFO] [stdout] 202 + board.pieces[self.end_square].is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_utils.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | return board.pieces[self.end_square].is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 - return board.pieces[self.end_square].is_some(); [INFO] [stdout] 202 + board.pieces[self.end_square].is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_utils.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | return board.player_in_check(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - return board.player_in_check(); [INFO] [stdout] 208 + board.player_in_check() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/move_utils.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | return board.player_in_check(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - return board.player_in_check(); [INFO] [stdout] 208 + board.player_in_check() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | return square as i32 + increment * 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 3 - return square as i32 + increment * 8; [INFO] [stdout] 3 + square as i32 + increment * 8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | return square as i32 + increment * 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 3 - return square as i32 + increment * 8; [INFO] [stdout] 3 + square as i32 + increment * 8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | return square as i32 + increment; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 - return square as i32 + increment; [INFO] [stdout] 7 + square as i32 + increment [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | return square as i32 + increment; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 - return square as i32 + increment; [INFO] [stdout] 7 + square as i32 + increment [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return square / 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return square / 8; [INFO] [stdout] 11 + square / 8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return square / 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return square / 8; [INFO] [stdout] 11 + square / 8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | return square % 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return square % 8; [INFO] [stdout] 15 + square % 8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | return square % 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return square % 8; [INFO] [stdout] 15 + square % 8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return (b'1' as u8 + rank(square) as u8) as char; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return (b'1' as u8 + rank(square) as u8) as char; [INFO] [stdout] 19 + (b'1' as u8 + rank(square) as u8) as char [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return (b'1' as u8 + rank(square) as u8) as char; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return (b'1' as u8 + rank(square) as u8) as char; [INFO] [stdout] 19 + (b'1' as u8 + rank(square) as u8) as char [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/square_utils.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | return (b'1' as u8 + rank(square) as u8) as char; [INFO] [stdout] | ^^^^^^^^^^ help: try: `b'1'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/square_utils.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | return (b'1' as u8 + rank(square) as u8) as char; [INFO] [stdout] | ^^^^^^^^^^ help: try: `b'1'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return (b'a' as u8 + file(square) as u8) as char; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return (b'a' as u8 + file(square) as u8) as char; [INFO] [stdout] 23 + (b'a' as u8 + file(square) as u8) as char [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return (b'a' as u8 + file(square) as u8) as char; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return (b'a' as u8 + file(square) as u8) as char; [INFO] [stdout] 23 + (b'a' as u8 + file(square) as u8) as char [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/square_utils.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | return (b'a' as u8 + file(square) as u8) as char; [INFO] [stdout] | ^^^^^^^^^^ help: try: `b'a'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/square_utils.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | return (b'a' as u8 + file(square) as u8) as char; [INFO] [stdout] | ^^^^^^^^^^ help: try: `b'a'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return rank_on_board && file_on_board; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return rank_on_board && file_on_board; [INFO] [stdout] 29 + rank_on_board && file_on_board [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return rank_on_board && file_on_board; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return rank_on_board && file_on_board; [INFO] [stdout] 29 + rank_on_board && file_on_board [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/square_utils.rs:27:25 [INFO] [stdout] | [INFO] [stdout] 27 | let rank_on_board = 0 <= rank && rank < 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..8).contains(&rank)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/square_utils.rs:27:25 [INFO] [stdout] | [INFO] [stdout] 27 | let rank_on_board = 0 <= rank && rank < 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..8).contains(&rank)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/square_utils.rs:28:25 [INFO] [stdout] | [INFO] [stdout] 28 | let file_on_board = 0 <= file && file < 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..8).contains(&file)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/square_utils.rs:28:25 [INFO] [stdout] | [INFO] [stdout] 28 | let file_on_board = 0 <= file && file < 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..8).contains(&file)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return square as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return square as usize; [INFO] [stdout] 36 + square as usize [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return square as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return square as usize; [INFO] [stdout] 36 + square as usize [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return str; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return str; [INFO] [stdout] 43 + str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/square_utils.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return str; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return str; [INFO] [stdout] 43 + str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Game` [INFO] [stdout] --> src/lib.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / pub fn new() -> Self { [INFO] [stdout] 19 | | Self::start_from_fen("rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1") [INFO] [stdout] 20 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 16 + impl Default for Game { [INFO] [stdout] 17 + fn default() -> Self { [INFO] [stdout] 18 + Self::new() [INFO] [stdout] 19 + } [INFO] [stdout] 20 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Game` [INFO] [stdout] --> src/lib.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / pub fn new() -> Self { [INFO] [stdout] 19 | | Self::start_from_fen("rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1") [INFO] [stdout] 20 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 16 + impl Default for Game { [INFO] [stdout] 17 + fn default() -> Self { [INFO] [stdout] 18 + Self::new() [INFO] [stdout] 19 + } [INFO] [stdout] 20 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/move_generation.rs:111:28 [INFO] [stdout] | [INFO] [stdout] 111 | for capture_dir in vec![1, -1] { [INFO] [stdout] | ^^^^^^^^^^^ help: you can use an array directly: `[1, -1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/move_generation.rs:111:28 [INFO] [stdout] | [INFO] [stdout] 111 | for capture_dir in vec![1, -1] { [INFO] [stdout] | ^^^^^^^^^^^ help: you can use an array directly: `[1, -1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return success; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return success; [INFO] [stdout] 12 + success [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:5:33 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn contains_moves(superset: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn contains_moves(superset: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 5 + pub fn contains_moves(superset: &[Move], moves: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/utils.rs:8:31 [INFO] [stdout] | [INFO] [stdout] 8 | if !superset.contains(&mov) { [INFO] [stdout] | ^^^^ help: change this to: `mov` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return contains_moves(expected, moves) && contains_moves(moves, expected); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return contains_moves(expected, moves) && contains_moves(moves, expected); [INFO] [stdout] 18 + contains_moves(expected, moves) && contains_moves(moves, expected) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return !moves.iter().any(|m| m.start_square == square); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return !moves.iter().any(|m| m.start_square == square); [INFO] [stdout] 24 + !moves.iter().any(|m| m.start_square == square) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:23:50 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn no_move_starting_at(square: usize, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - pub fn no_move_starting_at(square: usize, moves: &Vec) -> bool { [INFO] [stdout] 23 + pub fn no_move_starting_at(square: usize, moves: &[Move]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / return moves [INFO] [stdout] 31 | | .iter() [INFO] [stdout] 32 | | .all(|m| m.start_square != square || expected.contains(m)); [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 ~ moves [INFO] [stdout] 31 + .iter() [INFO] [stdout] 32 ~ .all(|m| m.start_square != square || expected.contains(m)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:29:53 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 29 + pub fn moves_starting_from(square: usize, expected: &[Move], moves: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:29:72 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 29 + pub fn moves_starting_from(square: usize, expected: &Vec, moves: &[Move]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return success; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return success; [INFO] [stdout] 12 + success [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:5:33 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn contains_moves(superset: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn contains_moves(superset: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 5 + pub fn contains_moves(superset: &[Move], moves: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return success; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return success; [INFO] [stdout] 12 + success [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return success; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return success; [INFO] [stdout] 12 + success [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:5:33 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn contains_moves(superset: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn contains_moves(superset: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 5 + pub fn contains_moves(superset: &[Move], moves: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/utils.rs:8:31 [INFO] [stdout] | [INFO] [stdout] 8 | if !superset.contains(&mov) { [INFO] [stdout] | ^^^^ help: change this to: `mov` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return contains_moves(expected, moves) && contains_moves(moves, expected); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return contains_moves(expected, moves) && contains_moves(moves, expected); [INFO] [stdout] 18 + contains_moves(expected, moves) && contains_moves(moves, expected) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return !moves.iter().any(|m| m.start_square == square); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return !moves.iter().any(|m| m.start_square == square); [INFO] [stdout] 24 + !moves.iter().any(|m| m.start_square == square) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/utils.rs:8:31 [INFO] [stdout] | [INFO] [stdout] 8 | if !superset.contains(&mov) { [INFO] [stdout] | ^^^^ help: change this to: `mov` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:23:50 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn no_move_starting_at(square: usize, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - pub fn no_move_starting_at(square: usize, moves: &Vec) -> bool { [INFO] [stdout] 23 + pub fn no_move_starting_at(square: usize, moves: &[Move]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return contains_moves(expected, moves) && contains_moves(moves, expected); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return contains_moves(expected, moves) && contains_moves(moves, expected); [INFO] [stdout] 18 + contains_moves(expected, moves) && contains_moves(moves, expected) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return !moves.iter().any(|m| m.start_square == square); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return !moves.iter().any(|m| m.start_square == square); [INFO] [stdout] 24 + !moves.iter().any(|m| m.start_square == square) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:23:50 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn no_move_starting_at(square: usize, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - pub fn no_move_starting_at(square: usize, moves: &Vec) -> bool { [INFO] [stdout] 23 + pub fn no_move_starting_at(square: usize, moves: &[Move]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / return moves [INFO] [stdout] 31 | | .iter() [INFO] [stdout] 32 | | .all(|m| m.start_square != square || expected.contains(m)); [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 ~ moves [INFO] [stdout] 31 + .iter() [INFO] [stdout] 32 ~ .all(|m| m.start_square != square || expected.contains(m)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:29:53 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 29 + pub fn moves_starting_from(square: usize, expected: &[Move], moves: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:29:72 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 29 + pub fn moves_starting_from(square: usize, expected: &Vec, moves: &[Move]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / return moves [INFO] [stdout] 31 | | .iter() [INFO] [stdout] 32 | | .all(|m| m.start_square != square || expected.contains(m)); [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 ~ moves [INFO] [stdout] 31 + .iter() [INFO] [stdout] 32 ~ .all(|m| m.start_square != square || expected.contains(m)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:29:53 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 29 + pub fn moves_starting_from(square: usize, expected: &[Move], moves: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:29:72 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 29 + pub fn moves_starting_from(square: usize, expected: &Vec, moves: &[Move]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:5:33 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn contains_moves(superset: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn contains_moves(superset: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 5 + pub fn contains_moves(superset: &[Move], moves: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/utils.rs:8:31 [INFO] [stdout] | [INFO] [stdout] 8 | if !superset.contains(&mov) { [INFO] [stdout] | ^^^^ help: change this to: `mov` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return contains_moves(expected, moves) && contains_moves(moves, expected); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return contains_moves(expected, moves) && contains_moves(moves, expected); [INFO] [stdout] 18 + contains_moves(expected, moves) && contains_moves(moves, expected) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return !moves.iter().any(|m| m.start_square == square); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return !moves.iter().any(|m| m.start_square == square); [INFO] [stdout] 24 + !moves.iter().any(|m| m.start_square == square) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:23:50 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn no_move_starting_at(square: usize, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - pub fn no_move_starting_at(square: usize, moves: &Vec) -> bool { [INFO] [stdout] 23 + pub fn no_move_starting_at(square: usize, moves: &[Move]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / return moves [INFO] [stdout] 31 | | .iter() [INFO] [stdout] 32 | | .all(|m| m.start_square != square || expected.contains(m)); [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 ~ moves [INFO] [stdout] 31 + .iter() [INFO] [stdout] 32 ~ .all(|m| m.start_square != square || expected.contains(m)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:29:53 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 29 + pub fn moves_starting_from(square: usize, expected: &[Move], moves: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:29:72 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 29 + pub fn moves_starting_from(square: usize, expected: &Vec, moves: &[Move]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return success; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return success; [INFO] [stdout] 12 + success [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return success; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return success; [INFO] [stdout] 12 + success [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:5:33 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn contains_moves(superset: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn contains_moves(superset: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 5 + pub fn contains_moves(superset: &[Move], moves: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:5:33 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn contains_moves(superset: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn contains_moves(superset: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 5 + pub fn contains_moves(superset: &[Move], moves: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/utils.rs:8:31 [INFO] [stdout] | [INFO] [stdout] 8 | if !superset.contains(&mov) { [INFO] [stdout] | ^^^^ help: change this to: `mov` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/utils.rs:8:31 [INFO] [stdout] | [INFO] [stdout] 8 | if !superset.contains(&mov) { [INFO] [stdout] | ^^^^ help: change this to: `mov` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return contains_moves(expected, moves) && contains_moves(moves, expected); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return contains_moves(expected, moves) && contains_moves(moves, expected); [INFO] [stdout] 18 + contains_moves(expected, moves) && contains_moves(moves, expected) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return !moves.iter().any(|m| m.start_square == square); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return !moves.iter().any(|m| m.start_square == square); [INFO] [stdout] 24 + !moves.iter().any(|m| m.start_square == square) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:23:50 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn no_move_starting_at(square: usize, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - pub fn no_move_starting_at(square: usize, moves: &Vec) -> bool { [INFO] [stdout] 23 + pub fn no_move_starting_at(square: usize, moves: &[Move]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / return moves [INFO] [stdout] 31 | | .iter() [INFO] [stdout] 32 | | .all(|m| m.start_square != square || expected.contains(m)); [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 ~ moves [INFO] [stdout] 31 + .iter() [INFO] [stdout] 32 ~ .all(|m| m.start_square != square || expected.contains(m)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:29:53 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 29 + pub fn moves_starting_from(square: usize, expected: &[Move], moves: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:29:72 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 29 + pub fn moves_starting_from(square: usize, expected: &Vec, moves: &[Move]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return contains_moves(expected, moves) && contains_moves(moves, expected); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return contains_moves(expected, moves) && contains_moves(moves, expected); [INFO] [stdout] 18 + contains_moves(expected, moves) && contains_moves(moves, expected) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return !moves.iter().any(|m| m.start_square == square); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return !moves.iter().any(|m| m.start_square == square); [INFO] [stdout] 24 + !moves.iter().any(|m| m.start_square == square) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:23:50 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn no_move_starting_at(square: usize, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - pub fn no_move_starting_at(square: usize, moves: &Vec) -> bool { [INFO] [stdout] 23 + pub fn no_move_starting_at(square: usize, moves: &[Move]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / return moves [INFO] [stdout] 31 | | .iter() [INFO] [stdout] 32 | | .all(|m| m.start_square != square || expected.contains(m)); [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 ~ moves [INFO] [stdout] 31 + .iter() [INFO] [stdout] 32 ~ .all(|m| m.start_square != square || expected.contains(m)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:29:53 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 29 + pub fn moves_starting_from(square: usize, expected: &[Move], moves: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:29:72 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 29 + pub fn moves_starting_from(square: usize, expected: &Vec, moves: &[Move]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return success; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return success; [INFO] [stdout] 12 + success [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:5:33 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn contains_moves(superset: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn contains_moves(superset: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 5 + pub fn contains_moves(superset: &[Move], moves: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/utils.rs:8:31 [INFO] [stdout] | [INFO] [stdout] 8 | if !superset.contains(&mov) { [INFO] [stdout] | ^^^^ help: change this to: `mov` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return contains_moves(expected, moves) && contains_moves(moves, expected); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return contains_moves(expected, moves) && contains_moves(moves, expected); [INFO] [stdout] 18 + contains_moves(expected, moves) && contains_moves(moves, expected) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return !moves.iter().any(|m| m.start_square == square); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return !moves.iter().any(|m| m.start_square == square); [INFO] [stdout] 24 + !moves.iter().any(|m| m.start_square == square) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:23:50 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn no_move_starting_at(square: usize, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - pub fn no_move_starting_at(square: usize, moves: &Vec) -> bool { [INFO] [stdout] 23 + pub fn no_move_starting_at(square: usize, moves: &[Move]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / return moves [INFO] [stdout] 31 | | .iter() [INFO] [stdout] 32 | | .all(|m| m.start_square != square || expected.contains(m)); [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 ~ moves [INFO] [stdout] 31 + .iter() [INFO] [stdout] 32 ~ .all(|m| m.start_square != square || expected.contains(m)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:29:53 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 29 + pub fn moves_starting_from(square: usize, expected: &[Move], moves: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:29:72 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 29 + pub fn moves_starting_from(square: usize, expected: &Vec, moves: &[Move]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return success; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return success; [INFO] [stdout] 12 + success [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:5:33 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn contains_moves(superset: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn contains_moves(superset: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 5 + pub fn contains_moves(superset: &[Move], moves: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/utils.rs:8:31 [INFO] [stdout] | [INFO] [stdout] 8 | if !superset.contains(&mov) { [INFO] [stdout] | ^^^^ help: change this to: `mov` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return contains_moves(expected, moves) && contains_moves(moves, expected); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return contains_moves(expected, moves) && contains_moves(moves, expected); [INFO] [stdout] 18 + contains_moves(expected, moves) && contains_moves(moves, expected) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return !moves.iter().any(|m| m.start_square == square); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return !moves.iter().any(|m| m.start_square == square); [INFO] [stdout] 24 + !moves.iter().any(|m| m.start_square == square) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:23:50 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn no_move_starting_at(square: usize, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - pub fn no_move_starting_at(square: usize, moves: &Vec) -> bool { [INFO] [stdout] 23 + pub fn no_move_starting_at(square: usize, moves: &[Move]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / return moves [INFO] [stdout] 31 | | .iter() [INFO] [stdout] 32 | | .all(|m| m.start_square != square || expected.contains(m)); [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 ~ moves [INFO] [stdout] 31 + .iter() [INFO] [stdout] 32 ~ .all(|m| m.start_square != square || expected.contains(m)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:29:53 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 29 + pub fn moves_starting_from(square: usize, expected: &[Move], moves: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> tests/utils.rs:29:72 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - pub fn moves_starting_from(square: usize, expected: &Vec, moves: &Vec) -> bool { [INFO] [stdout] 29 + pub fn moves_starting_from(square: usize, expected: &Vec, moves: &[Move]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.69s [INFO] running `Command { std: "docker" "inspect" "2cf00c454284974c1431ed1f703cf399924c7fe66901842a2208e2f45b1bf169", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cf00c454284974c1431ed1f703cf399924c7fe66901842a2208e2f45b1bf169", kill_on_drop: false }` [INFO] [stdout] 2cf00c454284974c1431ed1f703cf399924c7fe66901842a2208e2f45b1bf169