[INFO] cloning repository https://github.com/LeoYZhang/snake.rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LeoYZhang/snake.rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeoYZhang%2Fsnake.rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeoYZhang%2Fsnake.rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1e2db5782c4228d9c9a9f9dac9096eaf1c8ee342 [INFO] linting LeoYZhang/snake.rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeoYZhang%2Fsnake.rs" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/LeoYZhang/snake.rs [INFO] finished tweaking git repo https://github.com/LeoYZhang/snake.rs [INFO] tweaked toml for git repo https://github.com/LeoYZhang/snake.rs written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/LeoYZhang/snake.rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/LeoYZhang/snake.rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded typetag-impl v0.2.20 [INFO] [stderr] Downloaded typetag v0.2.20 [INFO] [stderr] Downloaded syn v2.0.102 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3b090074d3cf1d46726b6de5762a37777eb11800a556b79482fa71fa8c6f5417 [INFO] running `Command { std: "docker" "start" "-a" "3b090074d3cf1d46726b6de5762a37777eb11800a556b79482fa71fa8c6f5417", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3b090074d3cf1d46726b6de5762a37777eb11800a556b79482fa71fa8c6f5417", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b090074d3cf1d46726b6de5762a37777eb11800a556b79482fa71fa8c6f5417", kill_on_drop: false }` [INFO] [stdout] 3b090074d3cf1d46726b6de5762a37777eb11800a556b79482fa71fa8c6f5417 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b08e7f85c2bd2be4cabe5691b88708b8621d7655ba725a912122033f8807f5c7 [INFO] running `Command { std: "docker" "start" "-a" "b08e7f85c2bd2be4cabe5691b88708b8621d7655ba725a912122033f8807f5c7", kill_on_drop: false }` [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling miniquad v0.4.8 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Checking ttf-parser v0.21.1 [INFO] [stderr] Compiling syn v2.0.102 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Compiling macroquad_macro v0.1.8 [INFO] [stderr] Checking inventory v0.3.20 [INFO] [stderr] Checking glam v0.27.0 [INFO] [stderr] Checking quad-rand v0.2.3 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking csv-core v0.1.12 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.1 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking fontdue v0.9.3 [INFO] [stderr] Checking rand_distr v0.5.1 [INFO] [stderr] Checking macroquad v0.4.14 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling typetag-impl v0.2.20 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking erased-serde v0.4.6 [INFO] [stderr] Checking csv v1.3.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking typetag v0.2.20 [INFO] [stderr] Checking snakers v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/sequential/tensor.rs:199:28 [INFO] [stdout] | [INFO] [stdout] 199 | fn calc_strides(shape: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 199 - fn calc_strides(shape: &Vec) -> Vec { [INFO] [stdout] 199 + fn calc_strides(shape: &[usize]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ReLU` [INFO] [stdout] --> src/sequential/layer.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | / pub fn new() -> Self { [INFO] [stdout] 104 | | Self { [INFO] [stdout] 105 | | cached_input: None [INFO] [stdout] 106 | | } [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 102 + impl Default for ReLU { [INFO] [stdout] 103 + fn default() -> Self { [INFO] [stdout] 104 + Self::new() [INFO] [stdout] 105 + } [INFO] [stdout] 106 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Softmax` [INFO] [stdout] --> src/sequential/layer.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | / pub fn new() -> Self { [INFO] [stdout] 154 | | Self { [INFO] [stdout] 155 | | cached_output: None [INFO] [stdout] 156 | | } [INFO] [stdout] 157 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 152 + impl Default for Softmax { [INFO] [stdout] 153 + fn default() -> Self { [INFO] [stdout] 154 + Self::new() [INFO] [stdout] 155 + } [INFO] [stdout] 156 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CategoricalCrossEntropy` [INFO] [stdout] --> src/sequential/loss.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new() -> Self { [INFO] [stdout] 20 | | Self [INFO] [stdout] 21 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 18 + impl Default for CategoricalCrossEntropy { [INFO] [stdout] 19 + fn default() -> Self { [INFO] [stdout] 20 + Self::new() [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sequential/optimizer.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | / if let Some(dense_layer) = layer.as_any_mut().downcast_mut::() { [INFO] [stdout] 31 | | if let (Some(d_weights), Some(d_biases)) = (&dense_layer.d_weights, &dense_layer.d_biases) { [INFO] [stdout] 32 | | let new_weights = dense_layer.weights.map2(d_weights, |w, dw| { [INFO] [stdout] 33 | | w - self.learning_rate * dw [INFO] [stdout] ... | [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 30 ~ if let Some(dense_layer) = layer.as_any_mut().downcast_mut::() [INFO] [stdout] 31 ~ && let (Some(d_weights), Some(d_biases)) = (&dense_layer.d_weights, &dense_layer.d_biases) { [INFO] [stdout] 32 | let new_weights = dense_layer.weights.map2(d_weights, |w, dw| { [INFO] [stdout] ... [INFO] [stdout] 41 | dense_layer.biases = new_biases; [INFO] [stdout] 42 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ReplayBuffer` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/agent/replaybuffer.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/agent.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 126 | if self.target_update_counter % self.target_update_frequency == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.target_update_counter.is_multiple_of(self.target_update_frequency)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.attempted_direction` after checking its variant with `is_some` [INFO] [stdout] --> src/game.rs:56:16 [INFO] [stdout] | [INFO] [stdout] 54 | ... if self.attempted_direction.is_some() { [INFO] [stdout] | ------------------------------------- help: try: `if let Some() = self.attempted_direction` [INFO] [stdout] 55 | ... // dot product to check for valid direction change [INFO] [stdout] 56 | ... if self.attempted_direction.unwrap().0*self.move_direction.0 + self.attempted_direction.unwrap().1*self.move_direction.1 =... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.attempted_direction` after checking its variant with `is_some` [INFO] [stdout] --> src/game.rs:56:76 [INFO] [stdout] | [INFO] [stdout] 54 | ... if self.attempted_direction.is_some() { [INFO] [stdout] | ------------------------------------- help: try: `if let Some() = self.attempted_direction` [INFO] [stdout] 55 | ... // dot product to check for valid direction change [INFO] [stdout] 56 | ... if self.attempted_direction.unwrap().0*self.move_direction.0 + self.attempted_direction.unwrap().1*self.move_direction.1 =... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.attempted_direction` after checking its variant with `is_some` [INFO] [stdout] --> src/game.rs:57:39 [INFO] [stdout] | [INFO] [stdout] 54 | if self.attempted_direction.is_some() { [INFO] [stdout] | ------------------------------------- help: try: `if let Some() = self.attempted_direction` [INFO] [stdout] ... [INFO] [stdout] 57 | self.move_direction = self.attempted_direction.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.target` after checking its variant with `is_some` [INFO] [stdout] --> src/game.rs:221:42 [INFO] [stdout] | [INFO] [stdout] 220 | if self.target.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = self.target` [INFO] [stdout] 221 | let target_x = game_area.x + self.target.unwrap().0 as f32 * cell_width; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.target` after checking its variant with `is_some` [INFO] [stdout] --> src/game.rs:222:42 [INFO] [stdout] | [INFO] [stdout] 220 | if self.target.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = self.target` [INFO] [stdout] 221 | let target_x = game_area.x + self.target.unwrap().0 as f32 * cell_width; [INFO] [stdout] 222 | let target_y = game_area.y + self.target.unwrap().1 as f32 * cell_height; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/game.rs:175:13 [INFO] [stdout] | [INFO] [stdout] 175 | score_text_size as f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `score_text_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:283:26 [INFO] [stdout] | [INFO] [stdout] 283 | let food_eaten = !(self.score == score_before_move); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.score != score_before_move)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `hash` and `root_ui` [INFO] [stdout] --> src/bin/main.rs:2:21 [INFO] [stdout] | [INFO] [stdout] 2 | use macroquad::ui::{hash, root_ui}; [INFO] [stdout] | ^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `game_ticks` is assigned to, but never used [INFO] [stdout] --> src/bin/main.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | let mut game_ticks: i32 = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_game_ticks` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `game_ticks` is never read [INFO] [stdout] --> src/bin/main.rs:71:21 [INFO] [stdout] | [INFO] [stdout] 71 | game_ticks += 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `game_ticks` is never read [INFO] [stdout] --> src/bin/main.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 51 | game_ticks += 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/bin/mnist.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use csv; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/bin/mnist.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use csv; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `hash` and `root_ui` [INFO] [stdout] --> src/bin/main.rs:2:21 [INFO] [stdout] | [INFO] [stdout] 2 | use macroquad::ui::{hash, root_ui}; [INFO] [stdout] | ^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `game_ticks` is assigned to, but never used [INFO] [stdout] --> src/bin/main.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | let mut game_ticks: i32 = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_game_ticks` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `game_ticks` is never read [INFO] [stdout] --> src/bin/main.rs:71:21 [INFO] [stdout] | [INFO] [stdout] 71 | game_ticks += 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `game_ticks` is never read [INFO] [stdout] --> src/bin/main.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 51 | game_ticks += 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/sequential/tensor.rs:199:28 [INFO] [stdout] | [INFO] [stdout] 199 | fn calc_strides(shape: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 199 - fn calc_strides(shape: &Vec) -> Vec { [INFO] [stdout] 199 + fn calc_strides(shape: &[usize]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ReLU` [INFO] [stdout] --> src/sequential/layer.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | / pub fn new() -> Self { [INFO] [stdout] 104 | | Self { [INFO] [stdout] 105 | | cached_input: None [INFO] [stdout] 106 | | } [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 102 + impl Default for ReLU { [INFO] [stdout] 103 + fn default() -> Self { [INFO] [stdout] 104 + Self::new() [INFO] [stdout] 105 + } [INFO] [stdout] 106 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Softmax` [INFO] [stdout] --> src/sequential/layer.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | / pub fn new() -> Self { [INFO] [stdout] 154 | | Self { [INFO] [stdout] 155 | | cached_output: None [INFO] [stdout] 156 | | } [INFO] [stdout] 157 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 152 + impl Default for Softmax { [INFO] [stdout] 153 + fn default() -> Self { [INFO] [stdout] 154 + Self::new() [INFO] [stdout] 155 + } [INFO] [stdout] 156 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/sequential/layer.rs:294:21 [INFO] [stdout] | [INFO] [stdout] 294 | assert!(val >= 0.0 && val <= 1.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=1.0).contains(&val)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CategoricalCrossEntropy` [INFO] [stdout] --> src/sequential/loss.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new() -> Self { [INFO] [stdout] 20 | | Self [INFO] [stdout] 21 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 18 + impl Default for CategoricalCrossEntropy { [INFO] [stdout] 19 + fn default() -> Self { [INFO] [stdout] 20 + Self::new() [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sequential/optimizer.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | / if let Some(dense_layer) = layer.as_any_mut().downcast_mut::() { [INFO] [stdout] 31 | | if let (Some(d_weights), Some(d_biases)) = (&dense_layer.d_weights, &dense_layer.d_biases) { [INFO] [stdout] 32 | | let new_weights = dense_layer.weights.map2(d_weights, |w, dw| { [INFO] [stdout] 33 | | w - self.learning_rate * dw [INFO] [stdout] ... | [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 30 ~ if let Some(dense_layer) = layer.as_any_mut().downcast_mut::() [INFO] [stdout] 31 ~ && let (Some(d_weights), Some(d_biases)) = (&dense_layer.d_weights, &dense_layer.d_biases) { [INFO] [stdout] 32 | let new_weights = dense_layer.weights.map2(d_weights, |w, dw| { [INFO] [stdout] ... [INFO] [stdout] 41 | dense_layer.biases = new_biases; [INFO] [stdout] 42 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ReplayBuffer` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/agent/replaybuffer.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/agent.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 126 | if self.target_update_counter % self.target_update_frequency == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.target_update_counter.is_multiple_of(self.target_update_frequency)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.attempted_direction` after checking its variant with `is_some` [INFO] [stdout] --> src/game.rs:56:16 [INFO] [stdout] | [INFO] [stdout] 54 | ... if self.attempted_direction.is_some() { [INFO] [stdout] | ------------------------------------- help: try: `if let Some() = self.attempted_direction` [INFO] [stdout] 55 | ... // dot product to check for valid direction change [INFO] [stdout] 56 | ... if self.attempted_direction.unwrap().0*self.move_direction.0 + self.attempted_direction.unwrap().1*self.move_direction.1 =... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.attempted_direction` after checking its variant with `is_some` [INFO] [stdout] --> src/game.rs:56:76 [INFO] [stdout] | [INFO] [stdout] 54 | ... if self.attempted_direction.is_some() { [INFO] [stdout] | ------------------------------------- help: try: `if let Some() = self.attempted_direction` [INFO] [stdout] 55 | ... // dot product to check for valid direction change [INFO] [stdout] 56 | ... if self.attempted_direction.unwrap().0*self.move_direction.0 + self.attempted_direction.unwrap().1*self.move_direction.1 =... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.attempted_direction` after checking its variant with `is_some` [INFO] [stdout] --> src/game.rs:57:39 [INFO] [stdout] | [INFO] [stdout] 54 | if self.attempted_direction.is_some() { [INFO] [stdout] | ------------------------------------- help: try: `if let Some() = self.attempted_direction` [INFO] [stdout] ... [INFO] [stdout] 57 | self.move_direction = self.attempted_direction.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.target` after checking its variant with `is_some` [INFO] [stdout] --> src/game.rs:221:42 [INFO] [stdout] | [INFO] [stdout] 220 | if self.target.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = self.target` [INFO] [stdout] 221 | let target_x = game_area.x + self.target.unwrap().0 as f32 * cell_width; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.target` after checking its variant with `is_some` [INFO] [stdout] --> src/game.rs:222:42 [INFO] [stdout] | [INFO] [stdout] 220 | if self.target.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = self.target` [INFO] [stdout] 221 | let target_x = game_area.x + self.target.unwrap().0 as f32 * cell_width; [INFO] [stdout] 222 | let target_y = game_area.y + self.target.unwrap().1 as f32 * cell_height; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/game.rs:175:13 [INFO] [stdout] | [INFO] [stdout] 175 | score_text_size as f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `score_text_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:283:26 [INFO] [stdout] | [INFO] [stdout] 283 | let food_eaten = !(self.score == score_before_move); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.score != score_before_move)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/game.rs:450:9 [INFO] [stdout] | [INFO] [stdout] 450 | assert_eq!(done, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 450 - assert_eq!(done, false); [INFO] [stdout] 450 + assert!(!done); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/game.rs:465:9 [INFO] [stdout] | [INFO] [stdout] 465 | assert_eq!(done, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 465 - assert_eq!(done, true); [INFO] [stdout] 465 + assert!(done); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.05s [INFO] running `Command { std: "docker" "inspect" "b08e7f85c2bd2be4cabe5691b88708b8621d7655ba725a912122033f8807f5c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b08e7f85c2bd2be4cabe5691b88708b8621d7655ba725a912122033f8807f5c7", kill_on_drop: false }` [INFO] [stdout] b08e7f85c2bd2be4cabe5691b88708b8621d7655ba725a912122033f8807f5c7