[INFO] cloning repository https://github.com/Leo-LiHao/search_trees [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Leo-LiHao/search_trees" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeo-LiHao%2Fsearch_trees", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeo-LiHao%2Fsearch_trees'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 52dd868063fb5ffadc01f6fd5bdbe60bfd4c37f6 [INFO] linting Leo-LiHao/search_trees against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeo-LiHao%2Fsearch_trees" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Leo-LiHao/search_trees [INFO] finished tweaking git repo https://github.com/Leo-LiHao/search_trees [INFO] tweaked toml for git repo https://github.com/Leo-LiHao/search_trees written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Leo-LiHao/search_trees on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 72 packages to latest compatible versions [INFO] [stderr] Adding criterion v0.3.6 (available: v0.8.2) [INFO] [stderr] Adding rand v0.7.3 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded csv-core v0.1.13 [INFO] [stderr] Downloaded half v1.8.3 [INFO] [stderr] Downloaded criterion v0.3.6 [INFO] [stderr] Downloaded serde_cbor v0.11.2 [INFO] [stderr] Downloaded csv v1.4.0 [INFO] [stderr] Downloaded criterion-plot v0.4.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bcbd60e06ed6325bdf7392e6640c06592c80a46a2323e02e5a1b3c3cfb46e230 [INFO] running `Command { std: "docker" "start" "-a" "bcbd60e06ed6325bdf7392e6640c06592c80a46a2323e02e5a1b3c3cfb46e230", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bcbd60e06ed6325bdf7392e6640c06592c80a46a2323e02e5a1b3c3cfb46e230", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bcbd60e06ed6325bdf7392e6640c06592c80a46a2323e02e5a1b3c3cfb46e230", kill_on_drop: false }` [INFO] [stdout] bcbd60e06ed6325bdf7392e6640c06592c80a46a2323e02e5a1b3c3cfb46e230 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f761ef6dedb3d9948ce43af02ee56a4e5718fd1e67aec3cc34e53e49bdb0e56c [INFO] running `Command { std: "docker" "start" "-a" "f761ef6dedb3d9948ce43af02ee56a4e5718fd1e67aec3cc34e53e49bdb0e56c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking ryu v1.0.23 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking search_trees v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rbtree.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | data: data, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `left` after checking its variant with `is_some` [INFO] [stdout] --> src/rbtree.rs:284:30 [INFO] [stdout] | [INFO] [stdout] 283 | if left.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = left` [INFO] [stdout] 284 | Self::delete(left.unwrap(), val); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `right` after checking its variant with `is_some` [INFO] [stdout] --> src/rbtree.rs:289:30 [INFO] [stdout] | [INFO] [stdout] 288 | if right.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = right` [INFO] [stdout] 289 | Self::delete(right.unwrap(), val); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/rbtree.rs:321:13 [INFO] [stdout] | [INFO] [stdout] 321 | / match node_sibling { [INFO] [stdout] 322 | | Some(node_sibling) =>{ [INFO] [stdout] 323 | | //let node_sibling = node_sibling.unwrap(); [INFO] [stdout] 324 | | let left = node_sibling.borrow().left.clone(); [INFO] [stdout] ... | [INFO] [stdout] 334 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 321 ~ if let Some(node_sibling) = node_sibling { [INFO] [stdout] 322 + //let node_sibling = node_sibling.unwrap(); [INFO] [stdout] 323 + let left = node_sibling.borrow().left.clone(); [INFO] [stdout] 324 + let right = node_sibling.borrow().right.clone(); [INFO] [stdout] 325 + if Self::color(left) == NodeColor::Black && Self::color(right) == NodeColor::Black { [INFO] [stdout] 326 + node_sibling.borrow_mut().color = NodeColor::Red; [INFO] [stdout] 327 + Self::delete_repair(parent.unwrap()); [INFO] [stdout] 328 + return; [INFO] [stdout] 329 + } [INFO] [stdout] 330 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/rbtree.rs:427:10 [INFO] [stdout] | [INFO] [stdout] 427 | /// has the same number of black nodes. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 427 | /// has the same number of black nodes. [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rbtree.rs:452:13 [INFO] [stdout] | [INFO] [stdout] 452 | / if node.borrow().color == NodeColor::Red { [INFO] [stdout] 453 | | if Self::color(node.borrow().left.clone()) == NodeColor::Red [INFO] [stdout] 454 | | || Self::color(node.borrow().right.clone()) == NodeColor::Red [INFO] [stdout] ... | [INFO] [stdout] 458 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 452 ~ if node.borrow().color == NodeColor::Red [INFO] [stdout] 453 ~ && (Self::color(node.borrow().left.clone()) == NodeColor::Red [INFO] [stdout] 454 ~ || Self::color(node.borrow().right.clone()) == NodeColor::Red) [INFO] [stdout] 455 | { [INFO] [stdout] 456 | return false; [INFO] [stdout] 457 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/rbtree.rs:463:21 [INFO] [stdout] | [INFO] [stdout] 463 | / if !Self::check_coloring(left) { [INFO] [stdout] 464 | | return false; [INFO] [stdout] 465 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 462 ~ Some(left) [INFO] [stdout] 463 ~ if !Self::check_coloring(left) => { [INFO] [stdout] 464 | return false; [INFO] [stdout] 465 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/rbtree.rs:461:13 [INFO] [stdout] | [INFO] [stdout] 461 | / match left { [INFO] [stdout] 462 | | Some(left) => { [INFO] [stdout] 463 | | if !Self::check_coloring(left) { [INFO] [stdout] 464 | | return false; [INFO] [stdout] ... | [INFO] [stdout] 467 | | None => (), [INFO] [stdout] 468 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 461 ~ if let Some(left) = left { [INFO] [stdout] 462 + if !Self::check_coloring(left) { [INFO] [stdout] 463 + return false; [INFO] [stdout] 464 + } [INFO] [stdout] 465 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/rbtree.rs:473:21 [INFO] [stdout] | [INFO] [stdout] 473 | / if !Self::check_coloring(right) { [INFO] [stdout] 474 | | return false; [INFO] [stdout] 475 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 472 ~ Some(right) [INFO] [stdout] 473 ~ if !Self::check_coloring(right) => { [INFO] [stdout] 474 | return false; [INFO] [stdout] 475 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/rbtree.rs:471:13 [INFO] [stdout] | [INFO] [stdout] 471 | / match right { [INFO] [stdout] 472 | | Some(right) => { [INFO] [stdout] 473 | | if !Self::check_coloring(right) { [INFO] [stdout] 474 | | return false; [INFO] [stdout] ... | [INFO] [stdout] 477 | | None => (), [INFO] [stdout] 478 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 471 ~ if let Some(right) = right { [INFO] [stdout] 472 + if !Self::check_coloring(right) { [INFO] [stdout] 473 + return false; [INFO] [stdout] 474 + } [INFO] [stdout] 475 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `left` after checking its variant with `is_some` [INFO] [stdout] --> src/rbtree.rs:624:37 [INFO] [stdout] | [INFO] [stdout] 623 | if left.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = left` [INFO] [stdout] 624 | Self::preorder_traverse(left.unwrap(), container); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `right` after checking its variant with `is_some` [INFO] [stdout] --> src/rbtree.rs:628:37 [INFO] [stdout] | [INFO] [stdout] 627 | if right.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = right` [INFO] [stdout] 628 | Self::preorder_traverse(right.unwrap(), container); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `left` after checking its variant with `is_some` [INFO] [stdout] --> src/rbtree.rs:635:36 [INFO] [stdout] | [INFO] [stdout] 634 | if left.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = left` [INFO] [stdout] 635 | Self::inorder_traverse(left.unwrap(), container); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `right` after checking its variant with `is_some` [INFO] [stdout] --> src/rbtree.rs:640:36 [INFO] [stdout] | [INFO] [stdout] 639 | if right.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = right` [INFO] [stdout] 640 | Self::inorder_traverse(right.unwrap(), container); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `left` after checking its variant with `is_some` [INFO] [stdout] --> src/rbtree.rs:647:38 [INFO] [stdout] | [INFO] [stdout] 646 | if left.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = left` [INFO] [stdout] 647 | Self::postorder_traverse(left.unwrap(), container); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `right` after checking its variant with `is_some` [INFO] [stdout] --> src/rbtree.rs:651:38 [INFO] [stdout] | [INFO] [stdout] 650 | if right.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = right` [INFO] [stdout] 651 | Self::postorder_traverse(right.unwrap(), container); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rbtree.rs:684:21 [INFO] [stdout] | [INFO] [stdout] 684 | None => return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 684 - None => return [INFO] [stdout] 684 + None => () [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rbtree.rs:697:9 [INFO] [stdout] | [INFO] [stdout] 697 | return &self.left; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 697 - return &self.left; [INFO] [stdout] 697 + &self.left [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rbtree.rs:700:9 [INFO] [stdout] | [INFO] [stdout] 700 | return &self.right; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 700 - return &self.right; [INFO] [stdout] 700 + &self.right [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rbtree.rs:703:9 [INFO] [stdout] | [INFO] [stdout] 703 | return self.data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 703 - return self.data; [INFO] [stdout] 703 + self.data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RedBlackTree` [INFO] [stdout] --> src/rbtree.rs:723:5 [INFO] [stdout] | [INFO] [stdout] 723 | / pub fn new() -> Self { [INFO] [stdout] 724 | | Self { root: None } [INFO] [stdout] 725 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 713 + impl Default for RedBlackTree { [INFO] [stdout] 714 + fn default() -> Self { [INFO] [stdout] 715 + Self::new() [INFO] [stdout] 716 + } [INFO] [stdout] 717 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/rbtree.rs:787:9 [INFO] [stdout] | [INFO] [stdout] 787 | / match self.root.clone() { [INFO] [stdout] 788 | | Some(root) => { [INFO] [stdout] 789 | | let r = RedBlackTreeNode::delete(root, val); [INFO] [stdout] 790 | | self.root = r; [INFO] [stdout] 791 | | } [INFO] [stdout] 792 | | None => (), [INFO] [stdout] 793 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 787 ~ if let Some(root) = self.root.clone() { [INFO] [stdout] 788 + let r = RedBlackTreeNode::delete(root, val); [INFO] [stdout] 789 + self.root = r; [INFO] [stdout] 790 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:35:45 [INFO] [stdout] | [INFO] [stdout] 35 | fn get_left(&self) -> &AVLNodeLink { return &self.left; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - fn get_left(&self) -> &AVLNodeLink { return &self.left; } [INFO] [stdout] 35 + fn get_left(&self) -> &AVLNodeLink { &self.left} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:36:46 [INFO] [stdout] | [INFO] [stdout] 36 | fn get_right(&self) -> &AVLNodeLink { return &self.right; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - fn get_right(&self) -> &AVLNodeLink { return &self.right; } [INFO] [stdout] 36 + fn get_right(&self) -> &AVLNodeLink { &self.right} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:37:31 [INFO] [stdout] | [INFO] [stdout] 37 | fn get_data(&self) -> T { return self.data; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - fn get_data(&self) -> T { return self.data; } [INFO] [stdout] 37 + fn get_data(&self) -> T { self.data} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | / return if delta_height.abs() > 1 { [INFO] [stdout] 75 | | println!("{:?} {:?}", left_height, right_height); [INFO] [stdout] 76 | | false [INFO] [stdout] 77 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 89 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 ~ if delta_height.abs() > 1 { [INFO] [stdout] 75 + println!("{:?} {:?}", left_height, right_height); [INFO] [stdout] 76 + false [INFO] [stdout] 77 + } else { [INFO] [stdout] 78 + let left_balanced = self.get_left().as_ref().map( [INFO] [stdout] 79 + |n| n.borrow()._is_balanced() [INFO] [stdout] 80 + ).unwrap_or(true); [INFO] [stdout] 81 + let right_balanced = self.get_right().as_ref().map( [INFO] [stdout] 82 + |n| n.borrow()._is_balanced() [INFO] [stdout] 83 + ).unwrap_or(true); [INFO] [stdout] 84 + if left_balanced && right_balanced { [INFO] [stdout] 85 + true [INFO] [stdout] 86 + } else { [INFO] [stdout] 87 + false [INFO] [stdout] 88 + } [INFO] [stdout] 89 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/avltree.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | / if left_balanced && right_balanced { [INFO] [stdout] 85 | | true [INFO] [stdout] 86 | | } else { [INFO] [stdout] 87 | | false [INFO] [stdout] 88 | | } [INFO] [stdout] | |_____________^ help: you can reduce it to: `left_balanced && right_balanced` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | return Self::_right_rotate(root) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return Self::_right_rotate(root) [INFO] [stdout] 111 + Self::_right_rotate(root) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Option::take()` on a temporary value [INFO] [stdout] --> src/avltree.rs:109:20 [INFO] [stdout] | [INFO] [stdout] 109 | let left = root.borrow().left.clone().take().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | help: remove [INFO] [stdout] | [INFO] [stdout] = note: `clone` creates a temporary value, so calling take() has no effect [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_take [INFO] [stdout] = note: `#[warn(clippy::needless_option_take)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | return Self::_left_rotate(root) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return Self::_left_rotate(root) [INFO] [stdout] 117 + Self::_left_rotate(root) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Option::take()` on a temporary value [INFO] [stdout] --> src/avltree.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | let right = root.borrow().right.clone().take().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | help: remove [INFO] [stdout] | [INFO] [stdout] = note: `clone` creates a temporary value, so calling take() has no effect [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_take [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | return new_root [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 - return new_root [INFO] [stdout] 132 + new_root [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Option::take()` on a temporary value [INFO] [stdout] --> src/avltree.rs:122:34 [INFO] [stdout] | [INFO] [stdout] 122 | root.borrow_mut().left = new_root.borrow().right.clone().take(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | help: remove [INFO] [stdout] | [INFO] [stdout] = note: `clone` creates a temporary value, so calling take() has no effect [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_take [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | return new_root [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return new_root [INFO] [stdout] 147 + new_root [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Option::take()` on a temporary value [INFO] [stdout] --> src/avltree.rs:137:35 [INFO] [stdout] | [INFO] [stdout] 137 | root.borrow_mut().right = new_root.borrow().left.clone().take(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | help: remove [INFO] [stdout] | [INFO] [stdout] = note: `clone` creates a temporary value, so calling take() has no effect [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_take [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Option::take()` on a temporary value [INFO] [stdout] --> src/avltree.rs:208:41 [INFO] [stdout] | [INFO] [stdout] 208 | ... let right = n.borrow().right.clone().take(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | help: remove [INFO] [stdout] | [INFO] [stdout] = note: `clone` creates a temporary value, so calling take() has no effect [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_take [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Option::take()` on a temporary value [INFO] [stdout] --> src/avltree.rs:224:36 [INFO] [stdout] | [INFO] [stdout] 224 | let left = n.borrow().left.clone().take(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | help: remove [INFO] [stdout] | [INFO] [stdout] = note: `clone` creates a temporary value, so calling take() has no effect [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_take [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Option::take()` on a temporary value [INFO] [stdout] --> src/avltree.rs:235:37 [INFO] [stdout] | [INFO] [stdout] 235 | let right = n.borrow().right.clone().take(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | help: remove [INFO] [stdout] | [INFO] [stdout] = note: `clone` creates a temporary value, so calling take() has no effect [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_take [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `AVLTree` [INFO] [stdout] --> src/avltree.rs:285:5 [INFO] [stdout] | [INFO] [stdout] 285 | / pub fn new() -> Self { [INFO] [stdout] 286 | | Self { root: None } [INFO] [stdout] 287 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 275 + impl Default for AVLTree { [INFO] [stdout] 276 + fn default() -> Self { [INFO] [stdout] 277 + Self::new() [INFO] [stdout] 278 + } [INFO] [stdout] 279 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:320:21 [INFO] [stdout] | [INFO] [stdout] 320 | None => return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 320 - None => return [INFO] [stdout] 320 + None => () [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bstree.rs:30:46 [INFO] [stdout] | [INFO] [stdout] 30 | fn get_left(&self) -> &BaseNodeLink { return &self.left; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - fn get_left(&self) -> &BaseNodeLink { return &self.left; } [INFO] [stdout] 30 + fn get_left(&self) -> &BaseNodeLink { &self.left} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bstree.rs:31:47 [INFO] [stdout] | [INFO] [stdout] 31 | fn get_right(&self) -> &BaseNodeLink { return &self.right; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - fn get_right(&self) -> &BaseNodeLink { return &self.right; } [INFO] [stdout] 31 + fn get_right(&self) -> &BaseNodeLink { &self.right} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bstree.rs:32:31 [INFO] [stdout] | [INFO] [stdout] 32 | fn get_data(&self) -> T { return self.data; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - fn get_data(&self) -> T { return self.data; } [INFO] [stdout] 32 + fn get_data(&self) -> T { self.data} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bstree.rs:72:60 [INFO] [stdout] | [INFO] [stdout] 72 | } else if right.borrow().left.is_none() && !right.borrow().right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `right.borrow().right.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bstree.rs:76:27 [INFO] [stdout] | [INFO] [stdout] 76 | } else if !right.borrow().left.is_none() && right.borrow().right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `right.borrow().left.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bstree.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 73 | / self.right.take().map(|node| { [INFO] [stdout] 74 | | self.right = node.borrow().right.clone() [INFO] [stdout] 75 | | }); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 73 - self.right.take().map(|node| { [INFO] [stdout] 74 - self.right = node.borrow().right.clone() [INFO] [stdout] 75 - }); [INFO] [stdout] 73 + if let Some(node) = self.right.take() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bstree.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 77 | / self.right.take().map(|node| { [INFO] [stdout] 78 | | self.right = node.borrow().left.clone() [INFO] [stdout] 79 | | }); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 77 - self.right.take().map(|node| { [INFO] [stdout] 78 - self.right = node.borrow().left.clone() [INFO] [stdout] 79 - }); [INFO] [stdout] 77 + if let Some(node) = self.right.take() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bstree.rs:94:59 [INFO] [stdout] | [INFO] [stdout] 94 | } else if left.borrow().left.is_none() && !left.borrow().right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `left.borrow().right.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bstree.rs:98:27 [INFO] [stdout] | [INFO] [stdout] 98 | } else if !left.borrow().left.is_none() && left.borrow().right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `left.borrow().left.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bstree.rs:95:21 [INFO] [stdout] | [INFO] [stdout] 95 | / self.left.take().map(|node| { [INFO] [stdout] 96 | | self.left = node.borrow().right.clone() [INFO] [stdout] 97 | | }); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 95 - self.left.take().map(|node| { [INFO] [stdout] 96 - self.left = node.borrow().right.clone() [INFO] [stdout] 97 - }); [INFO] [stdout] 95 + if let Some(node) = self.left.take() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bstree.rs:99:21 [INFO] [stdout] | [INFO] [stdout] 99 | / self.left.take().map(|node| { [INFO] [stdout] 100 | | self.left = node.borrow().left.clone() [INFO] [stdout] 101 | | }); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 99 - self.left.take().map(|node| { [INFO] [stdout] 100 - self.left = node.borrow().left.clone() [INFO] [stdout] 101 - }); [INFO] [stdout] 99 + if let Some(node) = self.left.take() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BinarySearchTree` [INFO] [stdout] --> src/bstree.rs:140:5 [INFO] [stdout] | [INFO] [stdout] 140 | / pub fn new() -> Self { [INFO] [stdout] 141 | | Self{ root: None } [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 130 + impl Default for BinarySearchTree { [INFO] [stdout] 131 + fn default() -> Self { [INFO] [stdout] 132 + Self::new() [INFO] [stdout] 133 + } [INFO] [stdout] 134 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.root` after checking its variant with `is_none` [INFO] [stdout] --> src/bstree.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 155 | if self.root.is_none() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = &self.root` [INFO] [stdout] ... [INFO] [stdout] 162 | self.root.as_ref().unwrap().borrow_mut().insert(new_val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bstree.rs:184:63 [INFO] [stdout] | [INFO] [stdout] 184 | } else if root.borrow().left.is_none() && !root.borrow().right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `root.borrow().right.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bstree.rs:188:31 [INFO] [stdout] | [INFO] [stdout] 188 | } else if !root.borrow().left.is_none() && root.borrow().right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `root.borrow().left.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bstree.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 177 - if self.root.is_none() { [INFO] [stdout] 178 - return [INFO] [stdout] 177 + if self.root.is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bstree.rs:185:25 [INFO] [stdout] | [INFO] [stdout] 185 | / self.root.take().map(|node| { [INFO] [stdout] 186 | | self.root = node.borrow().right.clone() [INFO] [stdout] 187 | | }); [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 185 - self.root.take().map(|node| { [INFO] [stdout] 186 - self.root = node.borrow().right.clone() [INFO] [stdout] 187 - }); [INFO] [stdout] 185 + if let Some(node) = self.root.take() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bstree.rs:189:25 [INFO] [stdout] | [INFO] [stdout] 189 | / self.root.take().map(|node| { [INFO] [stdout] 190 | | self.root = node.borrow().left.clone() [INFO] [stdout] 191 | | }); [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 189 - self.root.take().map(|node| { [INFO] [stdout] 190 - self.root = node.borrow().left.clone() [INFO] [stdout] 191 - }); [INFO] [stdout] 189 + if let Some(node) = self.root.take() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `QueryableTreeNode` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stdout] --> src/base.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | / pub trait QueryableTreeNode { [INFO] [stdout] 16 | | /// Get left child node [INFO] [stdout] 17 | | fn get_left(&self) -> &Option>>; [INFO] [stdout] ... | [INFO] [stdout] 114 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/base.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | / return if self.get_data() == value { [INFO] [stdout] 90 | | true [INFO] [stdout] 91 | | } else if self.get_data() < value { [INFO] [stdout] 92 | | self.get_right().as_ref().map( [INFO] [stdout] ... | [INFO] [stdout] 98 | | ).unwrap_or(false) [INFO] [stdout] 99 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 ~ if self.get_data() == value { [INFO] [stdout] 90 + true [INFO] [stdout] 91 + } else if self.get_data() < value { [INFO] [stdout] 92 + self.get_right().as_ref().map( [INFO] [stdout] 93 + |node| node.borrow().contains(value) [INFO] [stdout] 94 + ).unwrap_or(false) [INFO] [stdout] 95 + } else { [INFO] [stdout] 96 + self.get_left().as_ref().map( [INFO] [stdout] 97 + |node| node.borrow().contains(value) [INFO] [stdout] 98 + ).unwrap_or(false) [INFO] [stdout] 99 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/base.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | / match self.get_root() { [INFO] [stdout] 211 | | None => true, [INFO] [stdout] 212 | | Some(_) => false [INFO] [stdout] 213 | | } [INFO] [stdout] | |_________^ help: try: `self.get_root().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/base.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | / match self.get_root() { [INFO] [stdout] 235 | | None => None, [INFO] [stdout] 236 | | Some(node) => Some(node.borrow().min()), [INFO] [stdout] 237 | | } [INFO] [stdout] | |_________^ help: try: `self.get_root().as_ref().map(|node| node.borrow().min())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/base.rs:258:9 [INFO] [stdout] | [INFO] [stdout] 258 | / match self.get_root() { [INFO] [stdout] 259 | | None => None, [INFO] [stdout] 260 | | Some(node) => Some(node.borrow().max()), [INFO] [stdout] 261 | | } [INFO] [stdout] | |_________^ help: try: `self.get_root().as_ref().map(|node| node.borrow().max())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `eprint!()` with a format string that ends in a single newline [INFO] [stdout] --> src/cli.rs:189:17 [INFO] [stdout] | [INFO] [stdout] 189 | eprint!("Command not recognized. \n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `eprintln!` instead [INFO] [stdout] | [INFO] [stdout] 189 - eprint!("Command not recognized. \n"); [INFO] [stdout] 189 + eprintln!("Command not recognized. "); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rbtree.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | data: data, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `eprint!()` with a format string that ends in a single newline [INFO] [stdout] --> src/cli.rs:189:17 [INFO] [stdout] | [INFO] [stdout] 189 | eprint!("Command not recognized. \n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `eprintln!` instead [INFO] [stdout] | [INFO] [stdout] 189 - eprint!("Command not recognized. \n"); [INFO] [stdout] 189 + eprintln!("Command not recognized. "); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `left` after checking its variant with `is_some` [INFO] [stdout] --> src/rbtree.rs:284:30 [INFO] [stdout] | [INFO] [stdout] 283 | if left.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = left` [INFO] [stdout] 284 | Self::delete(left.unwrap(), val); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `right` after checking its variant with `is_some` [INFO] [stdout] --> src/rbtree.rs:289:30 [INFO] [stdout] | [INFO] [stdout] 288 | if right.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = right` [INFO] [stdout] 289 | Self::delete(right.unwrap(), val); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/rbtree.rs:321:13 [INFO] [stdout] | [INFO] [stdout] 321 | / match node_sibling { [INFO] [stdout] 322 | | Some(node_sibling) =>{ [INFO] [stdout] 323 | | //let node_sibling = node_sibling.unwrap(); [INFO] [stdout] 324 | | let left = node_sibling.borrow().left.clone(); [INFO] [stdout] ... | [INFO] [stdout] 334 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 321 ~ if let Some(node_sibling) = node_sibling { [INFO] [stdout] 322 + //let node_sibling = node_sibling.unwrap(); [INFO] [stdout] 323 + let left = node_sibling.borrow().left.clone(); [INFO] [stdout] 324 + let right = node_sibling.borrow().right.clone(); [INFO] [stdout] 325 + if Self::color(left) == NodeColor::Black && Self::color(right) == NodeColor::Black { [INFO] [stdout] 326 + node_sibling.borrow_mut().color = NodeColor::Red; [INFO] [stdout] 327 + Self::delete_repair(parent.unwrap()); [INFO] [stdout] 328 + return; [INFO] [stdout] 329 + } [INFO] [stdout] 330 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/rbtree.rs:427:10 [INFO] [stdout] | [INFO] [stdout] 427 | /// has the same number of black nodes. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 427 | /// has the same number of black nodes. [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rbtree.rs:452:13 [INFO] [stdout] | [INFO] [stdout] 452 | / if node.borrow().color == NodeColor::Red { [INFO] [stdout] 453 | | if Self::color(node.borrow().left.clone()) == NodeColor::Red [INFO] [stdout] 454 | | || Self::color(node.borrow().right.clone()) == NodeColor::Red [INFO] [stdout] ... | [INFO] [stdout] 458 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 452 ~ if node.borrow().color == NodeColor::Red [INFO] [stdout] 453 ~ && (Self::color(node.borrow().left.clone()) == NodeColor::Red [INFO] [stdout] 454 ~ || Self::color(node.borrow().right.clone()) == NodeColor::Red) [INFO] [stdout] 455 | { [INFO] [stdout] 456 | return false; [INFO] [stdout] 457 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/rbtree.rs:463:21 [INFO] [stdout] | [INFO] [stdout] 463 | / if !Self::check_coloring(left) { [INFO] [stdout] 464 | | return false; [INFO] [stdout] 465 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 462 ~ Some(left) [INFO] [stdout] 463 ~ if !Self::check_coloring(left) => { [INFO] [stdout] 464 | return false; [INFO] [stdout] 465 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/rbtree.rs:461:13 [INFO] [stdout] | [INFO] [stdout] 461 | / match left { [INFO] [stdout] 462 | | Some(left) => { [INFO] [stdout] 463 | | if !Self::check_coloring(left) { [INFO] [stdout] 464 | | return false; [INFO] [stdout] ... | [INFO] [stdout] 467 | | None => (), [INFO] [stdout] 468 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 461 ~ if let Some(left) = left { [INFO] [stdout] 462 + if !Self::check_coloring(left) { [INFO] [stdout] 463 + return false; [INFO] [stdout] 464 + } [INFO] [stdout] 465 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/rbtree.rs:473:21 [INFO] [stdout] | [INFO] [stdout] 473 | / if !Self::check_coloring(right) { [INFO] [stdout] 474 | | return false; [INFO] [stdout] 475 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 472 ~ Some(right) [INFO] [stdout] 473 ~ if !Self::check_coloring(right) => { [INFO] [stdout] 474 | return false; [INFO] [stdout] 475 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/rbtree.rs:471:13 [INFO] [stdout] | [INFO] [stdout] 471 | / match right { [INFO] [stdout] 472 | | Some(right) => { [INFO] [stdout] 473 | | if !Self::check_coloring(right) { [INFO] [stdout] 474 | | return false; [INFO] [stdout] ... | [INFO] [stdout] 477 | | None => (), [INFO] [stdout] 478 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 471 ~ if let Some(right) = right { [INFO] [stdout] 472 + if !Self::check_coloring(right) { [INFO] [stdout] 473 + return false; [INFO] [stdout] 474 + } [INFO] [stdout] 475 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `left` after checking its variant with `is_some` [INFO] [stdout] --> src/rbtree.rs:624:37 [INFO] [stdout] | [INFO] [stdout] 623 | if left.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = left` [INFO] [stdout] 624 | Self::preorder_traverse(left.unwrap(), container); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `right` after checking its variant with `is_some` [INFO] [stdout] --> src/rbtree.rs:628:37 [INFO] [stdout] | [INFO] [stdout] 627 | if right.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = right` [INFO] [stdout] 628 | Self::preorder_traverse(right.unwrap(), container); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `left` after checking its variant with `is_some` [INFO] [stdout] --> src/rbtree.rs:635:36 [INFO] [stdout] | [INFO] [stdout] 634 | if left.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = left` [INFO] [stdout] 635 | Self::inorder_traverse(left.unwrap(), container); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `right` after checking its variant with `is_some` [INFO] [stdout] --> src/rbtree.rs:640:36 [INFO] [stdout] | [INFO] [stdout] 639 | if right.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = right` [INFO] [stdout] 640 | Self::inorder_traverse(right.unwrap(), container); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `left` after checking its variant with `is_some` [INFO] [stdout] --> src/rbtree.rs:647:38 [INFO] [stdout] | [INFO] [stdout] 646 | if left.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = left` [INFO] [stdout] 647 | Self::postorder_traverse(left.unwrap(), container); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `right` after checking its variant with `is_some` [INFO] [stdout] --> src/rbtree.rs:651:38 [INFO] [stdout] | [INFO] [stdout] 650 | if right.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = right` [INFO] [stdout] 651 | Self::postorder_traverse(right.unwrap(), container); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rbtree.rs:684:21 [INFO] [stdout] | [INFO] [stdout] 684 | None => return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 684 - None => return [INFO] [stdout] 684 + None => () [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rbtree.rs:697:9 [INFO] [stdout] | [INFO] [stdout] 697 | return &self.left; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 697 - return &self.left; [INFO] [stdout] 697 + &self.left [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rbtree.rs:700:9 [INFO] [stdout] | [INFO] [stdout] 700 | return &self.right; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 700 - return &self.right; [INFO] [stdout] 700 + &self.right [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rbtree.rs:703:9 [INFO] [stdout] | [INFO] [stdout] 703 | return self.data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 703 - return self.data; [INFO] [stdout] 703 + self.data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RedBlackTree` [INFO] [stdout] --> src/rbtree.rs:723:5 [INFO] [stdout] | [INFO] [stdout] 723 | / pub fn new() -> Self { [INFO] [stdout] 724 | | Self { root: None } [INFO] [stdout] 725 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 713 + impl Default for RedBlackTree { [INFO] [stdout] 714 + fn default() -> Self { [INFO] [stdout] 715 + Self::new() [INFO] [stdout] 716 + } [INFO] [stdout] 717 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/rbtree.rs:787:9 [INFO] [stdout] | [INFO] [stdout] 787 | / match self.root.clone() { [INFO] [stdout] 788 | | Some(root) => { [INFO] [stdout] 789 | | let r = RedBlackTreeNode::delete(root, val); [INFO] [stdout] 790 | | self.root = r; [INFO] [stdout] 791 | | } [INFO] [stdout] 792 | | None => (), [INFO] [stdout] 793 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 787 ~ if let Some(root) = self.root.clone() { [INFO] [stdout] 788 + let r = RedBlackTreeNode::delete(root, val); [INFO] [stdout] 789 + self.root = r; [INFO] [stdout] 790 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:35:45 [INFO] [stdout] | [INFO] [stdout] 35 | fn get_left(&self) -> &AVLNodeLink { return &self.left; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - fn get_left(&self) -> &AVLNodeLink { return &self.left; } [INFO] [stdout] 35 + fn get_left(&self) -> &AVLNodeLink { &self.left} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:36:46 [INFO] [stdout] | [INFO] [stdout] 36 | fn get_right(&self) -> &AVLNodeLink { return &self.right; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - fn get_right(&self) -> &AVLNodeLink { return &self.right; } [INFO] [stdout] 36 + fn get_right(&self) -> &AVLNodeLink { &self.right} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:37:31 [INFO] [stdout] | [INFO] [stdout] 37 | fn get_data(&self) -> T { return self.data; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - fn get_data(&self) -> T { return self.data; } [INFO] [stdout] 37 + fn get_data(&self) -> T { self.data} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | / return if delta_height.abs() > 1 { [INFO] [stdout] 75 | | println!("{:?} {:?}", left_height, right_height); [INFO] [stdout] 76 | | false [INFO] [stdout] 77 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 89 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 ~ if delta_height.abs() > 1 { [INFO] [stdout] 75 + println!("{:?} {:?}", left_height, right_height); [INFO] [stdout] 76 + false [INFO] [stdout] 77 + } else { [INFO] [stdout] 78 + let left_balanced = self.get_left().as_ref().map( [INFO] [stdout] 79 + |n| n.borrow()._is_balanced() [INFO] [stdout] 80 + ).unwrap_or(true); [INFO] [stdout] 81 + let right_balanced = self.get_right().as_ref().map( [INFO] [stdout] 82 + |n| n.borrow()._is_balanced() [INFO] [stdout] 83 + ).unwrap_or(true); [INFO] [stdout] 84 + if left_balanced && right_balanced { [INFO] [stdout] 85 + true [INFO] [stdout] 86 + } else { [INFO] [stdout] 87 + false [INFO] [stdout] 88 + } [INFO] [stdout] 89 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/avltree.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | / if left_balanced && right_balanced { [INFO] [stdout] 85 | | true [INFO] [stdout] 86 | | } else { [INFO] [stdout] 87 | | false [INFO] [stdout] 88 | | } [INFO] [stdout] | |_____________^ help: you can reduce it to: `left_balanced && right_balanced` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | return Self::_right_rotate(root) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return Self::_right_rotate(root) [INFO] [stdout] 111 + Self::_right_rotate(root) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Option::take()` on a temporary value [INFO] [stdout] --> src/avltree.rs:109:20 [INFO] [stdout] | [INFO] [stdout] 109 | let left = root.borrow().left.clone().take().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | help: remove [INFO] [stdout] | [INFO] [stdout] = note: `clone` creates a temporary value, so calling take() has no effect [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_take [INFO] [stdout] = note: `#[warn(clippy::needless_option_take)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | return Self::_left_rotate(root) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return Self::_left_rotate(root) [INFO] [stdout] 117 + Self::_left_rotate(root) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Option::take()` on a temporary value [INFO] [stdout] --> src/avltree.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | let right = root.borrow().right.clone().take().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | help: remove [INFO] [stdout] | [INFO] [stdout] = note: `clone` creates a temporary value, so calling take() has no effect [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_take [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | return new_root [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 - return new_root [INFO] [stdout] 132 + new_root [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Option::take()` on a temporary value [INFO] [stdout] --> src/avltree.rs:122:34 [INFO] [stdout] | [INFO] [stdout] 122 | root.borrow_mut().left = new_root.borrow().right.clone().take(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | help: remove [INFO] [stdout] | [INFO] [stdout] = note: `clone` creates a temporary value, so calling take() has no effect [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_take [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | return new_root [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return new_root [INFO] [stdout] 147 + new_root [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Option::take()` on a temporary value [INFO] [stdout] --> src/avltree.rs:137:35 [INFO] [stdout] | [INFO] [stdout] 137 | root.borrow_mut().right = new_root.borrow().left.clone().take(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | help: remove [INFO] [stdout] | [INFO] [stdout] = note: `clone` creates a temporary value, so calling take() has no effect [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_take [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Option::take()` on a temporary value [INFO] [stdout] --> src/avltree.rs:208:41 [INFO] [stdout] | [INFO] [stdout] 208 | ... let right = n.borrow().right.clone().take(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | help: remove [INFO] [stdout] | [INFO] [stdout] = note: `clone` creates a temporary value, so calling take() has no effect [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_take [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Option::take()` on a temporary value [INFO] [stdout] --> src/avltree.rs:224:36 [INFO] [stdout] | [INFO] [stdout] 224 | let left = n.borrow().left.clone().take(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | help: remove [INFO] [stdout] | [INFO] [stdout] = note: `clone` creates a temporary value, so calling take() has no effect [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_take [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Option::take()` on a temporary value [INFO] [stdout] --> src/avltree.rs:235:37 [INFO] [stdout] | [INFO] [stdout] 235 | let right = n.borrow().right.clone().take(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | help: remove [INFO] [stdout] | [INFO] [stdout] = note: `clone` creates a temporary value, so calling take() has no effect [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_take [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `AVLTree` [INFO] [stdout] --> src/avltree.rs:285:5 [INFO] [stdout] | [INFO] [stdout] 285 | / pub fn new() -> Self { [INFO] [stdout] 286 | | Self { root: None } [INFO] [stdout] 287 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 275 + impl Default for AVLTree { [INFO] [stdout] 276 + fn default() -> Self { [INFO] [stdout] 277 + Self::new() [INFO] [stdout] 278 + } [INFO] [stdout] 279 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/avltree.rs:320:21 [INFO] [stdout] | [INFO] [stdout] 320 | None => return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 320 - None => return [INFO] [stdout] 320 + None => () [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/avltree.rs:344:9 [INFO] [stdout] | [INFO] [stdout] 344 | assert_eq!(avl.is_empty(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 344 - assert_eq!(avl.is_empty(), true); [INFO] [stdout] 344 + assert!(avl.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/avltree.rs:353:9 [INFO] [stdout] | [INFO] [stdout] 353 | assert_eq!(avl.is_empty(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 353 - assert_eq!(avl.is_empty(), false); [INFO] [stdout] 353 + assert!(!avl.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/avltree.rs:355:9 [INFO] [stdout] | [INFO] [stdout] 355 | assert_eq!(avl.contains(2),true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 355 - assert_eq!(avl.contains(2),true); [INFO] [stdout] 355 + assert!(avl.contains(2)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/avltree.rs:356:9 [INFO] [stdout] | [INFO] [stdout] 356 | assert_eq!(avl.contains(8),false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 356 - assert_eq!(avl.contains(8),false); [INFO] [stdout] 356 + assert!(!avl.contains(8)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bstree.rs:30:46 [INFO] [stdout] | [INFO] [stdout] 30 | fn get_left(&self) -> &BaseNodeLink { return &self.left; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - fn get_left(&self) -> &BaseNodeLink { return &self.left; } [INFO] [stdout] 30 + fn get_left(&self) -> &BaseNodeLink { &self.left} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bstree.rs:31:47 [INFO] [stdout] | [INFO] [stdout] 31 | fn get_right(&self) -> &BaseNodeLink { return &self.right; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - fn get_right(&self) -> &BaseNodeLink { return &self.right; } [INFO] [stdout] 31 + fn get_right(&self) -> &BaseNodeLink { &self.right} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bstree.rs:32:31 [INFO] [stdout] | [INFO] [stdout] 32 | fn get_data(&self) -> T { return self.data; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - fn get_data(&self) -> T { return self.data; } [INFO] [stdout] 32 + fn get_data(&self) -> T { self.data} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bstree.rs:72:60 [INFO] [stdout] | [INFO] [stdout] 72 | } else if right.borrow().left.is_none() && !right.borrow().right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `right.borrow().right.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bstree.rs:76:27 [INFO] [stdout] | [INFO] [stdout] 76 | } else if !right.borrow().left.is_none() && right.borrow().right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `right.borrow().left.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bstree.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 73 | / self.right.take().map(|node| { [INFO] [stdout] 74 | | self.right = node.borrow().right.clone() [INFO] [stdout] 75 | | }); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 73 - self.right.take().map(|node| { [INFO] [stdout] 74 - self.right = node.borrow().right.clone() [INFO] [stdout] 75 - }); [INFO] [stdout] 73 + if let Some(node) = self.right.take() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bstree.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 77 | / self.right.take().map(|node| { [INFO] [stdout] 78 | | self.right = node.borrow().left.clone() [INFO] [stdout] 79 | | }); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 77 - self.right.take().map(|node| { [INFO] [stdout] 78 - self.right = node.borrow().left.clone() [INFO] [stdout] 79 - }); [INFO] [stdout] 77 + if let Some(node) = self.right.take() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bstree.rs:94:59 [INFO] [stdout] | [INFO] [stdout] 94 | } else if left.borrow().left.is_none() && !left.borrow().right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `left.borrow().right.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bstree.rs:98:27 [INFO] [stdout] | [INFO] [stdout] 98 | } else if !left.borrow().left.is_none() && left.borrow().right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `left.borrow().left.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bstree.rs:95:21 [INFO] [stdout] | [INFO] [stdout] 95 | / self.left.take().map(|node| { [INFO] [stdout] 96 | | self.left = node.borrow().right.clone() [INFO] [stdout] 97 | | }); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 95 - self.left.take().map(|node| { [INFO] [stdout] 96 - self.left = node.borrow().right.clone() [INFO] [stdout] 97 - }); [INFO] [stdout] 95 + if let Some(node) = self.left.take() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bstree.rs:99:21 [INFO] [stdout] | [INFO] [stdout] 99 | / self.left.take().map(|node| { [INFO] [stdout] 100 | | self.left = node.borrow().left.clone() [INFO] [stdout] 101 | | }); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 99 - self.left.take().map(|node| { [INFO] [stdout] 100 - self.left = node.borrow().left.clone() [INFO] [stdout] 101 - }); [INFO] [stdout] 99 + if let Some(node) = self.left.take() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BinarySearchTree` [INFO] [stdout] --> src/bstree.rs:140:5 [INFO] [stdout] | [INFO] [stdout] 140 | / pub fn new() -> Self { [INFO] [stdout] 141 | | Self{ root: None } [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 130 + impl Default for BinarySearchTree { [INFO] [stdout] 131 + fn default() -> Self { [INFO] [stdout] 132 + Self::new() [INFO] [stdout] 133 + } [INFO] [stdout] 134 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.root` after checking its variant with `is_none` [INFO] [stdout] --> src/bstree.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 155 | if self.root.is_none() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = &self.root` [INFO] [stdout] ... [INFO] [stdout] 162 | self.root.as_ref().unwrap().borrow_mut().insert(new_val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bstree.rs:184:63 [INFO] [stdout] | [INFO] [stdout] 184 | } else if root.borrow().left.is_none() && !root.borrow().right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `root.borrow().right.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bstree.rs:188:31 [INFO] [stdout] | [INFO] [stdout] 188 | } else if !root.borrow().left.is_none() && root.borrow().right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `root.borrow().left.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bstree.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 177 - if self.root.is_none() { [INFO] [stdout] 178 - return [INFO] [stdout] 177 + if self.root.is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bstree.rs:185:25 [INFO] [stdout] | [INFO] [stdout] 185 | / self.root.take().map(|node| { [INFO] [stdout] 186 | | self.root = node.borrow().right.clone() [INFO] [stdout] 187 | | }); [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 185 - self.root.take().map(|node| { [INFO] [stdout] 186 - self.root = node.borrow().right.clone() [INFO] [stdout] 187 - }); [INFO] [stdout] 185 + if let Some(node) = self.root.take() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bstree.rs:189:25 [INFO] [stdout] | [INFO] [stdout] 189 | / self.root.take().map(|node| { [INFO] [stdout] 190 | | self.root = node.borrow().left.clone() [INFO] [stdout] 191 | | }); [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 189 - self.root.take().map(|node| { [INFO] [stdout] 190 - self.root = node.borrow().left.clone() [INFO] [stdout] 191 - }); [INFO] [stdout] 189 + if let Some(node) = self.root.take() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bstree.rs:265:9 [INFO] [stdout] | [INFO] [stdout] 265 | assert_eq!(bst.is_empty(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 265 - assert_eq!(bst.is_empty(), true); [INFO] [stdout] 265 + assert!(bst.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bstree.rs:267:9 [INFO] [stdout] | [INFO] [stdout] 267 | assert_eq!(bst.is_empty(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 267 - assert_eq!(bst.is_empty(), false); [INFO] [stdout] 267 + assert!(!bst.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bstree.rs:269:9 [INFO] [stdout] | [INFO] [stdout] 269 | assert_eq!(bst.is_empty(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 269 - assert_eq!(bst.is_empty(), true); [INFO] [stdout] 269 + assert!(bst.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bstree.rs:315:9 [INFO] [stdout] | [INFO] [stdout] 315 | assert_eq!(bst.contains(5), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 315 - assert_eq!(bst.contains(5), false); [INFO] [stdout] 315 + assert!(!bst.contains(5)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bstree.rs:317:9 [INFO] [stdout] | [INFO] [stdout] 317 | assert_eq!(bst.contains(5), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 317 - assert_eq!(bst.contains(5), true); [INFO] [stdout] 317 + assert!(bst.contains(5)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bstree.rs:318:9 [INFO] [stdout] | [INFO] [stdout] 318 | assert_eq!(bst.contains(3), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 318 - assert_eq!(bst.contains(3), false); [INFO] [stdout] 318 + assert!(!bst.contains(3)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bstree.rs:320:9 [INFO] [stdout] | [INFO] [stdout] 320 | assert_eq!(bst.contains(3), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 320 - assert_eq!(bst.contains(3), true); [INFO] [stdout] 320 + assert!(bst.contains(3)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bstree.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 321 | assert_eq!(bst.contains(2), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 321 - assert_eq!(bst.contains(2), false); [INFO] [stdout] 321 + assert!(!bst.contains(2)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bstree.rs:323:9 [INFO] [stdout] | [INFO] [stdout] 323 | assert_eq!(bst.contains(2), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 323 - assert_eq!(bst.contains(2), true); [INFO] [stdout] 323 + assert!(bst.contains(2)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bstree.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | assert_eq!(bst.contains(4), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 324 - assert_eq!(bst.contains(4), false); [INFO] [stdout] 324 + assert!(!bst.contains(4)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bstree.rs:326:9 [INFO] [stdout] | [INFO] [stdout] 326 | assert_eq!(bst.contains(4), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 326 - assert_eq!(bst.contains(4), true); [INFO] [stdout] 326 + assert!(bst.contains(4)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bstree.rs:327:9 [INFO] [stdout] | [INFO] [stdout] 327 | assert_eq!(bst.contains(7), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 327 - assert_eq!(bst.contains(7), false); [INFO] [stdout] 327 + assert!(!bst.contains(7)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bstree.rs:329:9 [INFO] [stdout] | [INFO] [stdout] 329 | assert_eq!(bst.contains(7), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 329 - assert_eq!(bst.contains(7), true); [INFO] [stdout] 329 + assert!(bst.contains(7)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bstree.rs:330:9 [INFO] [stdout] | [INFO] [stdout] 330 | assert_eq!(bst.contains(6), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 330 - assert_eq!(bst.contains(6), false); [INFO] [stdout] 330 + assert!(!bst.contains(6)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bstree.rs:332:9 [INFO] [stdout] | [INFO] [stdout] 332 | assert_eq!(bst.contains(6), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 332 - assert_eq!(bst.contains(6), true); [INFO] [stdout] 332 + assert!(bst.contains(6)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bstree.rs:333:9 [INFO] [stdout] | [INFO] [stdout] 333 | assert_eq!(bst.contains(8), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 333 - assert_eq!(bst.contains(8), false); [INFO] [stdout] 333 + assert!(!bst.contains(8)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bstree.rs:335:9 [INFO] [stdout] | [INFO] [stdout] 335 | assert_eq!(bst.contains(8), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 335 - assert_eq!(bst.contains(8), true); [INFO] [stdout] 335 + assert!(bst.contains(8)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `QueryableTreeNode` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stdout] --> src/base.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | / pub trait QueryableTreeNode { [INFO] [stdout] 16 | | /// Get left child node [INFO] [stdout] 17 | | fn get_left(&self) -> &Option>>; [INFO] [stdout] ... | [INFO] [stdout] 114 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/base.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | / return if self.get_data() == value { [INFO] [stdout] 90 | | true [INFO] [stdout] 91 | | } else if self.get_data() < value { [INFO] [stdout] 92 | | self.get_right().as_ref().map( [INFO] [stdout] ... | [INFO] [stdout] 98 | | ).unwrap_or(false) [INFO] [stdout] 99 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 ~ if self.get_data() == value { [INFO] [stdout] 90 + true [INFO] [stdout] 91 + } else if self.get_data() < value { [INFO] [stdout] 92 + self.get_right().as_ref().map( [INFO] [stdout] 93 + |node| node.borrow().contains(value) [INFO] [stdout] 94 + ).unwrap_or(false) [INFO] [stdout] 95 + } else { [INFO] [stdout] 96 + self.get_left().as_ref().map( [INFO] [stdout] 97 + |node| node.borrow().contains(value) [INFO] [stdout] 98 + ).unwrap_or(false) [INFO] [stdout] 99 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/base.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | / match self.get_root() { [INFO] [stdout] 211 | | None => true, [INFO] [stdout] 212 | | Some(_) => false [INFO] [stdout] 213 | | } [INFO] [stdout] | |_________^ help: try: `self.get_root().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/base.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | / match self.get_root() { [INFO] [stdout] 235 | | None => None, [INFO] [stdout] 236 | | Some(node) => Some(node.borrow().min()), [INFO] [stdout] 237 | | } [INFO] [stdout] | |_________^ help: try: `self.get_root().as_ref().map(|node| node.borrow().min())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/base.rs:258:9 [INFO] [stdout] | [INFO] [stdout] 258 | / match self.get_root() { [INFO] [stdout] 259 | | None => None, [INFO] [stdout] 260 | | Some(node) => Some(node.borrow().max()), [INFO] [stdout] 261 | | } [INFO] [stdout] | |_________^ help: try: `self.get_root().as_ref().map(|node| node.borrow().max())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/rbtree.rs:904:9 [INFO] [stdout] | [INFO] [stdout] 904 | vec![8, -8, 4, 12, 10, 11].iter().for_each(|v| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[8, -8, 4, 12, 10, 11]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/rbtree.rs:956:9 [INFO] [stdout] | [INFO] [stdout] 956 | vec![8, -8, 4, 12, 10, 11].iter().for_each(|v| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[8, -8, 4, 12, 10, 11]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/rbtree.rs:960:9 [INFO] [stdout] | [INFO] [stdout] 960 | vec![5, -6, -10, 13].iter().for_each(|v| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[5, -6, -10, 13]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/rbtree.rs:964:9 [INFO] [stdout] | [INFO] [stdout] 964 | vec![11, 12, -8, 0].iter().for_each(|v| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[11, 12, -8, 0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/rbtree.rs:975:9 [INFO] [stdout] | [INFO] [stdout] 975 | vec![-12, 8, -8, 15, 4, 12, 10, 9, 11].iter().for_each(|v| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[-12, 8, -8, 15, 4, 12, 10, 9, 11]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/rbtree.rs:978:9 [INFO] [stdout] | [INFO] [stdout] 978 | vec![15, -12, 9].iter().for_each(|v| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: you can use an array directly: `[15, -12, 9]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/rbtree.rs:997:9 [INFO] [stdout] | [INFO] [stdout] 997 | vec![-16, 16, 8, 24, 20, 22].iter().for_each(|v| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[-16, 16, 8, 24, 20, 22]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/rbtree.rs:1020:9 [INFO] [stdout] | [INFO] [stdout] 1020 | vec![-16, 16, 8, 24, 20, 22].iter().for_each(|v| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[-16, 16, 8, 24, 20, 22]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 39.23s [INFO] running `Command { std: "docker" "inspect" "f761ef6dedb3d9948ce43af02ee56a4e5718fd1e67aec3cc34e53e49bdb0e56c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f761ef6dedb3d9948ce43af02ee56a4e5718fd1e67aec3cc34e53e49bdb0e56c", kill_on_drop: false }` [INFO] [stdout] f761ef6dedb3d9948ce43af02ee56a4e5718fd1e67aec3cc34e53e49bdb0e56c