[INFO] cloning repository https://github.com/LegusX/daypapers [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LegusX/daypapers" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLegusX%2Fdaypapers", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLegusX%2Fdaypapers'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fd31d4f27fa1e59a6495fad4d3747c173154a322 [INFO] linting LegusX/daypapers against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLegusX%2Fdaypapers" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/LegusX/daypapers [INFO] finished tweaking git repo https://github.com/LegusX/daypapers [INFO] tweaked toml for git repo https://github.com/LegusX/daypapers written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/LegusX/daypapers on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/LegusX/daypapers already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded toml_datetime v0.6.3 [INFO] [stderr] Downloaded getrandom v0.2.10 [INFO] [stderr] Downloaded toml v0.7.6 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.87 [INFO] [stderr] Downloaded execute-command-tokens v0.1.6 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.87 [INFO] [stderr] Downloaded execute-command-macro-impl v0.1.9 [INFO] [stderr] Downloaded serde_spanned v0.6.3 [INFO] [stderr] Downloaded execute-command-macro v0.1.8 [INFO] [stderr] Downloaded execute v0.2.12 [INFO] [stderr] Downloaded quote v1.0.32 [INFO] [stderr] Downloaded core-foundation-sys v0.8.4 [INFO] [stderr] Downloaded iana-time-zone v0.1.57 [INFO] [stderr] Downloaded time v0.1.45 [INFO] [stderr] Downloaded wasi v0.10.0+wasi-snapshot-preview1 [INFO] [stderr] Downloaded toml_edit v0.19.14 [INFO] [stderr] Downloaded once_cell v1.18.0 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.87 [INFO] [stderr] Downloaded indexmap v2.0.0 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.87 [INFO] [stderr] Downloaded proc-macro2 v1.0.66 [INFO] [stderr] Downloaded num-traits v0.2.16 [INFO] [stderr] Downloaded unicode-ident v1.0.11 [INFO] [stderr] Downloaded serde v1.0.183 [INFO] [stderr] Downloaded js-sys v0.3.64 [INFO] [stderr] Downloaded cc v1.0.82 [INFO] [stderr] Downloaded bumpalo v3.13.0 [INFO] [stderr] Downloaded hashbrown v0.14.0 [INFO] [stderr] Downloaded chrono v0.4.26 [INFO] [stderr] Downloaded wasm-bindgen v0.2.87 [INFO] [stderr] Downloaded winnow v0.5.4 [INFO] [stderr] Downloaded syn v2.0.28 [INFO] [stderr] Downloaded windows v0.48.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fee49bca26eb5e0d0dd82294b79325e74cb9b462b265b7291b240da8a34b17a4 [INFO] running `Command { std: "docker" "start" "-a" "fee49bca26eb5e0d0dd82294b79325e74cb9b462b265b7291b240da8a34b17a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fee49bca26eb5e0d0dd82294b79325e74cb9b462b265b7291b240da8a34b17a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fee49bca26eb5e0d0dd82294b79325e74cb9b462b265b7291b240da8a34b17a4", kill_on_drop: false }` [INFO] [stdout] fee49bca26eb5e0d0dd82294b79325e74cb9b462b265b7291b240da8a34b17a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2336f0712fef9840970ea4a05c37ae0e88f5492e5c5e6725fed8d6b6def4a40b [INFO] running `Command { std: "docker" "start" "-a" "2336f0712fef9840970ea4a05c37ae0e88f5492e5c5e6725fed8d6b6def4a40b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling serde v1.0.183 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Compiling execute-command-tokens v0.1.6 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking winnow v0.5.4 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling syn v2.0.28 [INFO] [stderr] Checking chrono v0.4.26 [INFO] [stderr] Compiling execute-command-macro-impl v0.1.9 [INFO] [stderr] Checking execute-command-macro v0.1.8 [INFO] [stderr] Checking execute v0.2.12 [INFO] [stderr] Checking serde_spanned v0.6.3 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking toml_edit v0.19.14 [INFO] [stderr] Checking toml v0.7.6 [INFO] [stderr] Checking wallhelper v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:14:2 [INFO] [stdout] | [INFO] [stdout] 14 | return Path::new(path).exists(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return Path::new(path).exists(); [INFO] [stdout] 14 + Path::new(path).exists() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:55:2 [INFO] [stdout] | [INFO] [stdout] 55 | return (config, daypart_images, hour_images); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return (config, daypart_images, hour_images); [INFO] [stdout] 55 + (config, daypart_images, hour_images) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:31:55 [INFO] [stdout] | [INFO] [stdout] 31 | fs::create_dir(format!("{}/{}", dayparts_path, i)).expect( [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 32 | | &format!("Failed to create dayparts subfolder: {}", i) [INFO] [stdout] 33 | | ); [INFO] [stdout] | |_____________^ help: try: `unwrap_or_else(|_| panic!("Failed to create dayparts subfolder: {}", i))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:39:53 [INFO] [stdout] | [INFO] [stdout] 39 | fs::create_dir(format!("{}/{}", &hours_path, i)).expect( [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 40 | | &format!("Failed to create hours subfolder: {:?}", i) [INFO] [stdout] 41 | | ); [INFO] [stdout] | |_____________^ help: try: `unwrap_or_else(|_| panic!("Failed to create hours subfolder: {:?}", i))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:53:54 [INFO] [stdout] | [INFO] [stdout] 53 | let (daypart_images, hour_images) = register_images(&path); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:95:2 [INFO] [stdout] | [INFO] [stdout] 95 | return (daypart_images, hour_images); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return (daypart_images, hour_images); [INFO] [stdout] 95 + (daypart_images, hour_images) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `hour` is used to index `hour_images` [INFO] [stdout] --> src/main.rs:79:14 [INFO] [stdout] | [INFO] [stdout] 79 | for hour in 0..24 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 79 - for hour in 0..24 { [INFO] [stdout] 79 + for (hour, ) in hour_images.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:101:2 [INFO] [stdout] | [INFO] [stdout] 101 | return hour; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return hour; [INFO] [stdout] 101 + hour [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:166:6 [INFO] [stdout] | [INFO] [stdout] 166 | if !always_change || (always_change && chosen_image != last_image && total_images > 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!always_change || chosen_image != last_image && total_images > 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:143:6 [INFO] [stdout] | [INFO] [stdout] 143 | if hour_images[hour].len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!hour_images[hour].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:167:7 [INFO] [stdout] | [INFO] [stdout] 167 | if chosen_image.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!chosen_image.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:14:2 [INFO] [stdout] | [INFO] [stdout] 14 | return Path::new(path).exists(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return Path::new(path).exists(); [INFO] [stdout] 14 + Path::new(path).exists() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:55:2 [INFO] [stdout] | [INFO] [stdout] 55 | return (config, daypart_images, hour_images); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return (config, daypart_images, hour_images); [INFO] [stdout] 55 + (config, daypart_images, hour_images) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:31:55 [INFO] [stdout] | [INFO] [stdout] 31 | fs::create_dir(format!("{}/{}", dayparts_path, i)).expect( [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 32 | | &format!("Failed to create dayparts subfolder: {}", i) [INFO] [stdout] 33 | | ); [INFO] [stdout] | |_____________^ help: try: `unwrap_or_else(|_| panic!("Failed to create dayparts subfolder: {}", i))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:39:53 [INFO] [stdout] | [INFO] [stdout] 39 | fs::create_dir(format!("{}/{}", &hours_path, i)).expect( [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 40 | | &format!("Failed to create hours subfolder: {:?}", i) [INFO] [stdout] 41 | | ); [INFO] [stdout] | |_____________^ help: try: `unwrap_or_else(|_| panic!("Failed to create hours subfolder: {:?}", i))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:53:54 [INFO] [stdout] | [INFO] [stdout] 53 | let (daypart_images, hour_images) = register_images(&path); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:95:2 [INFO] [stdout] | [INFO] [stdout] 95 | return (daypart_images, hour_images); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return (daypart_images, hour_images); [INFO] [stdout] 95 + (daypart_images, hour_images) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `hour` is used to index `hour_images` [INFO] [stdout] --> src/main.rs:79:14 [INFO] [stdout] | [INFO] [stdout] 79 | for hour in 0..24 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 79 - for hour in 0..24 { [INFO] [stdout] 79 + for (hour, ) in hour_images.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:101:2 [INFO] [stdout] | [INFO] [stdout] 101 | return hour; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return hour; [INFO] [stdout] 101 + hour [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:166:6 [INFO] [stdout] | [INFO] [stdout] 166 | if !always_change || (always_change && chosen_image != last_image && total_images > 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!always_change || chosen_image != last_image && total_images > 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:143:6 [INFO] [stdout] | [INFO] [stdout] 143 | if hour_images[hour].len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!hour_images[hour].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:167:7 [INFO] [stdout] | [INFO] [stdout] 167 | if chosen_image.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!chosen_image.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.10s [INFO] running `Command { std: "docker" "inspect" "2336f0712fef9840970ea4a05c37ae0e88f5492e5c5e6725fed8d6b6def4a40b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2336f0712fef9840970ea4a05c37ae0e88f5492e5c5e6725fed8d6b6def4a40b", kill_on_drop: false }` [INFO] [stdout] 2336f0712fef9840970ea4a05c37ae0e88f5492e5c5e6725fed8d6b6def4a40b