[INFO] cloning repository https://github.com/LeShork/snake-game [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LeShork/snake-game" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeShork%2Fsnake-game", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeShork%2Fsnake-game'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] af429ce41504286bfda24ad4390a6d1833c3bb3f [INFO] linting LeShork/snake-game against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeShork%2Fsnake-game" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/LeShork/snake-game [INFO] finished tweaking git repo https://github.com/LeShork/snake-game [INFO] tweaked toml for git repo https://github.com/LeShork/snake-game written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/LeShork/snake-game on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/LeShork/snake-game already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 50070274b06c4a8fe9f0fa98ebf10a098fa860e4d14c1e9c14beae726e8f2a22 [INFO] running `Command { std: "docker" "start" "-a" "50070274b06c4a8fe9f0fa98ebf10a098fa860e4d14c1e9c14beae726e8f2a22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "50070274b06c4a8fe9f0fa98ebf10a098fa860e4d14c1e9c14beae726e8f2a22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50070274b06c4a8fe9f0fa98ebf10a098fa860e4d14c1e9c14beae726e8f2a22", kill_on_drop: false }` [INFO] [stdout] 50070274b06c4a8fe9f0fa98ebf10a098fa860e4d14c1e9c14beae726e8f2a22 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b3b13d6be4637a2ce8a153fa1cca4501a48fa1019371cffcd703f184503ebfba [INFO] running `Command { std: "docker" "start" "-a" "b3b13d6be4637a2ce8a153fa1cca4501a48fa1019371cffcd703f184503ebfba", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling sdl2 v0.35.2 [INFO] [stderr] Compiling sdl2-sys v0.35.2 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking snake-game v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `GameContext` [INFO] [stdout] --> src/main.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | / pub fn new() -> GameContext { [INFO] [stdout] 116 | | GameContext { [INFO] [stdout] 117 | | player_position: vec![Point(3,1), Point(2,1), Point(1,1)], [INFO] [stdout] 118 | | player_direction: PlayerDirection::Right, [INFO] [stdout] ... | [INFO] [stdout] 125 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 103 + impl Default for GameContext { [INFO] [stdout] 104 + fn default() -> Self { [INFO] [stdout] 105 + Self::new() [INFO] [stdout] 106 + } [INFO] [stdout] 107 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | return spacevec [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return spacevec [INFO] [stdout] 112 + spacevec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:150:16 [INFO] [stdout] | [INFO] [stdout] 150 | if !((self.speed-ACC_RATE) <= TOP_SPEED){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((self.speed-ACC_RATE) > TOP_SPEED)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | return *x; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 - return *x; [INFO] [stdout] 164 + *x [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `GameContext` [INFO] [stdout] --> src/main.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | / pub fn new() -> GameContext { [INFO] [stdout] 116 | | GameContext { [INFO] [stdout] 117 | | player_position: vec![Point(3,1), Point(2,1), Point(1,1)], [INFO] [stdout] 118 | | player_direction: PlayerDirection::Right, [INFO] [stdout] ... | [INFO] [stdout] 125 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 103 + impl Default for GameContext { [INFO] [stdout] 104 + fn default() -> Self { [INFO] [stdout] 105 + Self::new() [INFO] [stdout] 106 + } [INFO] [stdout] 107 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | return spacevec [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return spacevec [INFO] [stdout] 112 + spacevec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:150:16 [INFO] [stdout] | [INFO] [stdout] 150 | if !((self.speed-ACC_RATE) <= TOP_SPEED){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((self.speed-ACC_RATE) > TOP_SPEED)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | return *x; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 - return *x; [INFO] [stdout] 164 + *x [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.19s [INFO] running `Command { std: "docker" "inspect" "b3b13d6be4637a2ce8a153fa1cca4501a48fa1019371cffcd703f184503ebfba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3b13d6be4637a2ce8a153fa1cca4501a48fa1019371cffcd703f184503ebfba", kill_on_drop: false }` [INFO] [stdout] b3b13d6be4637a2ce8a153fa1cca4501a48fa1019371cffcd703f184503ebfba