[INFO] cloning repository https://github.com/LayerTwo-Labs/orchard_sandbox [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LayerTwo-Labs/orchard_sandbox" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLayerTwo-Labs%2Forchard_sandbox", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLayerTwo-Labs%2Forchard_sandbox'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ee04bef545944a9f6874da98762e146a3fbd6ba3 [INFO] linting LayerTwo-Labs/orchard_sandbox against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLayerTwo-Labs%2Forchard_sandbox" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/LayerTwo-Labs/orchard_sandbox [INFO] finished tweaking git repo https://github.com/LayerTwo-Labs/orchard_sandbox [INFO] tweaked toml for git repo https://github.com/LayerTwo-Labs/orchard_sandbox written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/LayerTwo-Labs/orchard_sandbox on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/LayerTwo-Labs/orchard_sandbox already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zcash_spec v0.1.2 [INFO] [stderr] Downloaded zip32 v0.1.2 [INFO] [stderr] Downloaded blake2b_simd v1.0.2 [INFO] [stderr] Downloaded memuse v0.2.1 [INFO] [stderr] Downloaded supports-hyperlinks v3.0.0 [INFO] [stderr] Downloaded supports-color v3.0.1 [INFO] [stderr] Downloaded backtrace-ext v0.2.1 [INFO] [stderr] Downloaded miette-derive v7.2.0 [INFO] [stderr] Downloaded owo-colors v4.1.0 [INFO] [stderr] Downloaded incrementalmerkletree v0.7.0 [INFO] [stderr] Downloaded pasta_curves v0.5.1 [INFO] [stderr] Downloaded jubjub v0.10.0 [INFO] [stderr] Downloaded tiny-bip39 v2.0.0 [INFO] [stderr] Downloaded miette v7.2.0 [INFO] [stderr] Downloaded halo2_proofs v0.3.0 [INFO] [stderr] Downloaded reddsa v0.5.1 [INFO] [stderr] Downloaded fpe v0.6.1 [INFO] [stderr] Downloaded serde_rusqlite v0.36.0 [INFO] [stderr] Downloaded halo2_legacy_pdqsort v0.1.0 [INFO] [stderr] Downloaded proptest v1.5.0 [INFO] [stderr] Downloaded zcash_note_encryption v0.4.0 [INFO] [stderr] Downloaded rusqlite_migration v1.3.1 [INFO] [stderr] Downloaded halo2_gadgets v0.3.0 [INFO] [stderr] Downloaded orchard v0.10.0 [INFO] [stderr] Downloaded bls12_381 v0.8.0 [INFO] [stderr] Downloaded libc v0.2.162 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2201cbdc903d7dc0e23c7dfbfe96aa300ec818264de180c55c89ff5fcea7ec0 [INFO] running `Command { std: "docker" "start" "-a" "a2201cbdc903d7dc0e23c7dfbfe96aa300ec818264de180c55c89ff5fcea7ec0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2201cbdc903d7dc0e23c7dfbfe96aa300ec818264de180c55c89ff5fcea7ec0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2201cbdc903d7dc0e23c7dfbfe96aa300ec818264de180c55c89ff5fcea7ec0", kill_on_drop: false }` [INFO] [stdout] a2201cbdc903d7dc0e23c7dfbfe96aa300ec818264de180c55c89ff5fcea7ec0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c2dd0acc99c9feb803d6b48f4096c86c893001ae2c7d73fb1112f1a29ee901b3 [INFO] running `Command { std: "docker" "start" "-a" "c2dd0acc99c9feb803d6b48f4096c86c893001ae2c7d73fb1112f1a29ee901b3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Compiling libc v0.2.162 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Compiling serde v1.0.215 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rustix v0.38.41 [INFO] [stderr] Compiling libm v0.2.11 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking blake2b_simd v1.0.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking pin-project-lite v0.2.15 [INFO] [stderr] Checking fastrand v2.2.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking object v0.36.5 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Compiling cc v1.2.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Checking halo2_legacy_pdqsort v0.1.0 [INFO] [stderr] Compiling owo-colors v4.1.0 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking uint v0.9.5 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Compiling rusqlite_migration v1.3.1 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking clap_lex v0.7.3 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking clap_builder v4.5.21 [INFO] [stderr] Checking supports-color v3.0.1 [INFO] [stderr] Checking zcash_spec v0.1.2 [INFO] [stderr] Checking incrementalmerkletree v0.7.0 [INFO] [stderr] Checking supports-unicode v3.0.0 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Checking supports-hyperlinks v3.0.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking bs58 v0.5.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling blake3 v1.5.4 [INFO] [stderr] Checking tempfile v3.14.0 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking bls12_381 v0.8.0 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Checking backtrace-ext v0.2.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.215 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling miette-derive v7.2.0 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Compiling visibility v0.1.1 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking fpe v0.6.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking miette v7.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking zcash_note_encryption v0.4.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking clap v4.5.21 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking rusqlite v0.32.1 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking tiny-bip39 v2.0.0 [INFO] [stderr] Checking nonempty v0.7.0 [INFO] [stderr] Checking serde_rusqlite v0.36.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking memuse v0.2.1 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking zip32 v0.1.2 [INFO] [stderr] Checking pasta_curves v0.5.1 [INFO] [stderr] Checking jubjub v0.10.0 [INFO] [stderr] Checking halo2_proofs v0.3.0 [INFO] [stderr] Checking reddsa v0.5.1 [INFO] [stderr] Checking halo2_gadgets v0.3.0 [INFO] [stderr] Checking orchard v0.10.0 [INFO] [stderr] Checking orchard_sandbox v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/db.rs:323:9 [INFO] [stdout] | [INFO] [stdout] 322 | panic!(); [INFO] [stdout] | -------- any code following this expression is unreachable [INFO] [stdout] 323 | let shielded_outputs = Self::get_shielded_outputs(&tx)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/db.rs:323:9 [INFO] [stdout] | [INFO] [stdout] 322 | panic!(); [INFO] [stdout] | -------- any code following this expression is unreachable [INFO] [stdout] 323 | let shielded_outputs = Self::get_shielded_outputs(&tx)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `get_notes` is never used [INFO] [stdout] --> src/db.rs:832:12 [INFO] [stdout] | [INFO] [stdout] 26 | impl Db { [INFO] [stdout] | ------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 832 | pub fn get_notes(tx: &rusqlite::Transaction, block: &Block) -> miette::Result> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `get_notes` is never used [INFO] [stdout] --> src/db.rs:832:12 [INFO] [stdout] | [INFO] [stdout] 26 | impl Db { [INFO] [stdout] | ------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 832 | pub fn get_notes(tx: &rusqlite::Transaction, block: &Block) -> miette::Result> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/db.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 118 | if !Db::get_mnemonic(&tx).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Db::get_mnemonic(&tx).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/db.rs:109:60 [INFO] [stdout] | [INFO] [stdout] 109 | conn.pragma_update_and_check(None, "journal_mode", &"WAL", |_| Ok(())) [INFO] [stdout] | ^^^^^^ help: change this to: `"WAL"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/db.rs:129:34 [INFO] [stdout] | [INFO] [stdout] 129 | .query_map([], |row| Ok(row.get(0)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 129 - .query_map([], |row| Ok(row.get(0)?)) [INFO] [stdout] 129 + .query_map([], |row| row.get(0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/db.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 118 | if !Db::get_mnemonic(&tx).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Db::get_mnemonic(&tx).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/db.rs:139:34 [INFO] [stdout] | [INFO] [stdout] 139 | .query_map([], |row| Ok(row.get(0)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 139 - .query_map([], |row| Ok(row.get(0)?)) [INFO] [stdout] 139 + .query_map([], |row| row.get(0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/db.rs:109:60 [INFO] [stdout] | [INFO] [stdout] 109 | conn.pragma_update_and_check(None, "journal_mode", &"WAL", |_| Ok(())) [INFO] [stdout] | ^^^^^^ help: change this to: `"WAL"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/db.rs:152:34 [INFO] [stdout] | [INFO] [stdout] 152 | .query_map([], |row| Ok(row.get(0)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 152 - .query_map([], |row| Ok(row.get(0)?)) [INFO] [stdout] 152 + .query_map([], |row| row.get(0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/db.rs:129:34 [INFO] [stdout] | [INFO] [stdout] 129 | .query_map([], |row| Ok(row.get(0)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 129 - .query_map([], |row| Ok(row.get(0)?)) [INFO] [stdout] 129 + .query_map([], |row| row.get(0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/db.rs:139:34 [INFO] [stdout] | [INFO] [stdout] 139 | .query_map([], |row| Ok(row.get(0)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 139 - .query_map([], |row| Ok(row.get(0)?)) [INFO] [stdout] 139 + .query_map([], |row| row.get(0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/db.rs:152:34 [INFO] [stdout] | [INFO] [stdout] 152 | .query_map([], |row| Ok(row.get(0)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 152 - .query_map([], |row| Ok(row.get(0)?)) [INFO] [stdout] 152 + .query_map([], |row| row.get(0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/db.rs:367:34 [INFO] [stdout] | [INFO] [stdout] 367 | .query_map([], |row| Ok(row.get(0)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 367 - .query_map([], |row| Ok(row.get(0)?)) [INFO] [stdout] 367 + .query_map([], |row| row.get(0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db.rs:472:39 [INFO] [stdout] | [INFO] [stdout] 472 | if Self::nullifier_exists(&tx, nullifier)? { [INFO] [stdout] | ^^^ help: change this to: `tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/db.rs:367:34 [INFO] [stdout] | [INFO] [stdout] 367 | .query_map([], |row| Ok(row.get(0)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 367 - .query_map([], |row| Ok(row.get(0)?)) [INFO] [stdout] 367 + .query_map([], |row| row.get(0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/db.rs:552:16 [INFO] [stdout] | [INFO] [stdout] 552 | if notes.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!notes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db.rs:472:39 [INFO] [stdout] | [INFO] [stdout] 472 | if Self::nullifier_exists(&tx, nullifier)? { [INFO] [stdout] | ^^^ help: change this to: `tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db.rs:610:43 [INFO] [stdout] | [INFO] [stdout] 610 | if Self::nullifier_exists(&tx, nullifier)? { [INFO] [stdout] | ^^^ help: change this to: `tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db.rs:613:40 [INFO] [stdout] | [INFO] [stdout] 613 | Self::insert_nullifier(&tx, nullifier)?; [INFO] [stdout] | ^^^ help: change this to: `tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db.rs:616:57 [INFO] [stdout] | [INFO] [stdout] 616 | let last_frontier = Self::get_last_frontier(&tx)?; [INFO] [stdout] | ^^^ help: change this to: `tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/db.rs:552:16 [INFO] [stdout] | [INFO] [stdout] 552 | if notes.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!notes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/db.rs:651:12 [INFO] [stdout] | [INFO] [stdout] 651 | if transactions.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `transactions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db.rs:610:43 [INFO] [stdout] | [INFO] [stdout] 610 | if Self::nullifier_exists(&tx, nullifier)? { [INFO] [stdout] | ^^^ help: change this to: `tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db.rs:613:40 [INFO] [stdout] | [INFO] [stdout] 613 | Self::insert_nullifier(&tx, nullifier)?; [INFO] [stdout] | ^^^ help: change this to: `tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db.rs:616:57 [INFO] [stdout] | [INFO] [stdout] 616 | let last_frontier = Self::get_last_frontier(&tx)?; [INFO] [stdout] | ^^^ help: change this to: `tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/db.rs:651:12 [INFO] [stdout] | [INFO] [stdout] 651 | if transactions.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `transactions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/db.rs:854:33 [INFO] [stdout] | [INFO] [stdout] 854 | let (tree, filled, cursor): ( [INFO] [stdout] | _________________________________^ [INFO] [stdout] 855 | | ( [INFO] [stdout] 856 | | Option, [INFO] [stdout] 857 | | Option, [INFO] [stdout] ... | [INFO] [stdout] 865 | | )>, [INFO] [stdout] 866 | | ) = bincode::deserialize(bytes).into_diagnostic()?; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/db.rs:854:33 [INFO] [stdout] | [INFO] [stdout] 854 | let (tree, filled, cursor): ( [INFO] [stdout] | _________________________________^ [INFO] [stdout] 855 | | ( [INFO] [stdout] 856 | | Option, [INFO] [stdout] 857 | | Option, [INFO] [stdout] ... | [INFO] [stdout] 865 | | )>, [INFO] [stdout] 866 | | ) = bincode::deserialize(bytes).into_diagnostic()?; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/types.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 61 | let actions = match nonempty::NonEmpty::from_vec(actions) { [INFO] [stdout] | _______________________^ [INFO] [stdout] 62 | | Some(actions) => actions, [INFO] [stdout] 63 | | None => return None, [INFO] [stdout] 64 | | }; [INFO] [stdout] | |_________^ help: try instead: `nonempty::NonEmpty::from_vec(actions)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/types.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 61 | let actions = match nonempty::NonEmpty::from_vec(actions) { [INFO] [stdout] | _______________________^ [INFO] [stdout] 62 | | Some(actions) => actions, [INFO] [stdout] 63 | | None => return None, [INFO] [stdout] 64 | | }; [INFO] [stdout] | |_________^ help: try instead: `nonempty::NonEmpty::from_vec(actions)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 42.11s [INFO] running `Command { std: "docker" "inspect" "c2dd0acc99c9feb803d6b48f4096c86c893001ae2c7d73fb1112f1a29ee901b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2dd0acc99c9feb803d6b48f4096c86c893001ae2c7d73fb1112f1a29ee901b3", kill_on_drop: false }` [INFO] [stdout] c2dd0acc99c9feb803d6b48f4096c86c893001ae2c7d73fb1112f1a29ee901b3