[INFO] cloning repository https://github.com/KwdeTfpv/fishpi-undercover
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KwdeTfpv/fishpi-undercover" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKwdeTfpv%2Ffishpi-undercover", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKwdeTfpv%2Ffishpi-undercover'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] cee32d7078b5c1036f2bb1f6d3befe008239d1f1
[INFO] linting KwdeTfpv/fishpi-undercover against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKwdeTfpv%2Ffishpi-undercover" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/KwdeTfpv/fishpi-undercover
[INFO] finished tweaking git repo https://github.com/KwdeTfpv/fishpi-undercover
[INFO] tweaked toml for git repo https://github.com/KwdeTfpv/fishpi-undercover written to /workspace/builds/worker-0-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/KwdeTfpv/fishpi-undercover on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/KwdeTfpv/fishpi-undercover already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded sha1_smol v1.0.1
[INFO] [stderr]   Downloaded config v0.13.4
[INFO] [stderr]   Downloaded backon v1.5.1
[INFO] [stderr]   Downloaded textwrap v0.16.2
[INFO] [stderr]   Downloaded redis v0.32.0
[INFO] [stderr]   Downloaded syn v2.0.103
[INFO] [stderr]   Downloaded libc v0.2.173
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 5b62bee2f27bc91f4240e19b2ea10b3d235e9d31e97783278f6db6a50b64993a
[INFO] running `Command { std: "docker" "start" "-a" "5b62bee2f27bc91f4240e19b2ea10b3d235e9d31e97783278f6db6a50b64993a", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "5b62bee2f27bc91f4240e19b2ea10b3d235e9d31e97783278f6db6a50b64993a", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "5b62bee2f27bc91f4240e19b2ea10b3d235e9d31e97783278f6db6a50b64993a", kill_on_drop: false }`
[INFO] [stdout] 5b62bee2f27bc91f4240e19b2ea10b3d235e9d31e97783278f6db6a50b64993a
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 637e32a21ff9c70a863b1cf96a5af9907c16664f1689b9e207753eded34d4355
[INFO] running `Command { std: "docker" "start" "-a" "637e32a21ff9c70a863b1cf96a5af9907c16664f1689b9e207753eded34d4355", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.173
[INFO] [stderr]     Checking cfg-if v1.0.1
[INFO] [stderr]     Checking smallvec v1.15.1
[INFO] [stderr]     Checking bytes v1.10.1
[INFO] [stderr]    Compiling lock_api v0.4.13
[INFO] [stderr]    Compiling syn v2.0.103
[INFO] [stderr]    Compiling parking_lot_core v0.9.11
[INFO] [stderr]     Checking log v0.4.27
[INFO] [stderr]     Checking slab v0.4.10
[INFO] [stderr]    Compiling cc v1.2.27
[INFO] [stderr]    Compiling zerocopy v0.8.25
[INFO] [stderr]     Checking memchr v2.7.5
[INFO] [stderr]     Checking writeable v0.6.1
[INFO] [stderr]     Checking litemap v0.8.0
[INFO] [stderr]    Compiling ahash v0.7.8
[INFO] [stderr]    Compiling icu_normalizer_data v2.0.0
[INFO] [stderr]    Compiling icu_properties_data v2.0.1
[INFO] [stderr]    Compiling num-traits v0.2.19
[INFO] [stderr]     Checking http v1.3.1
[INFO] [stderr]    Compiling getrandom v0.3.3
[INFO] [stderr]    Compiling ucd-trie v0.1.7
[INFO] [stderr]     Checking http v0.2.12
[INFO] [stderr]     Checking digest v0.10.7
[INFO] [stderr]     Checking getrandom v0.2.16
[INFO] [stderr]     Checking signal-hook-registry v1.4.5
[INFO] [stderr]     Checking parking_lot v0.12.4
[INFO] [stderr]     Checking socket2 v0.5.10
[INFO] [stderr]     Checking mio v1.0.4
[INFO] [stderr]     Checking rand_core v0.6.4
[INFO] [stderr]     Checking http-body v1.0.1
[INFO] [stderr]    Compiling proc-macro-error-attr v1.0.4
[INFO] [stderr]     Checking hashbrown v0.15.4
[INFO] [stderr]     Checking hashbrown v0.12.3
[INFO] [stderr]    Compiling rustls v0.21.12
[INFO] [stderr]    Compiling serde_json v1.0.140
[INFO] [stderr]    Compiling proc-macro-error v1.0.4
[INFO] [stderr]     Checking tower-layer v0.3.3
[INFO] [stderr]    Compiling rustversion v1.0.21
[INFO] [stderr]    Compiling ring v0.17.14
[INFO] [stderr]    Compiling syn v1.0.109
[INFO] [stderr]     Checking ppv-lite86 v0.2.21
[INFO] [stderr]     Checking indexmap v2.9.0
[INFO] [stderr]     Checking sha1 v0.10.6
[INFO] [stderr]     Checking http-body v0.4.6
[INFO] [stderr]     Checking http-body-util v0.1.3
[INFO] [stderr]    Compiling indexmap v1.9.3
[INFO] [stderr]     Checking dlv-list v0.3.0
[INFO] [stderr]     Checking data-encoding v2.9.0
[INFO] [stderr]     Checking utf-8 v0.7.6
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking byteorder v1.5.0
[INFO] [stderr]     Checking regex-syntax v0.8.5
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]     Checking sync_wrapper v1.0.2
[INFO] [stderr]     Checking ordered-multimap v0.4.3
[INFO] [stderr]     Checking num-integer v0.1.46
[INFO] [stderr]     Checking rand_core v0.9.3
[INFO] [stderr]     Checking fastrand v2.3.0
[INFO] [stderr]     Checking base64 v0.13.1
[INFO] [stderr]     Checking linked-hash-map v0.5.6
[INFO] [stderr]     Checking minimal-lexical v0.2.1
[INFO] [stderr]     Checking os_str_bytes v6.6.1
[INFO] [stderr]    Compiling anyhow v1.0.98
[INFO] [stderr]     Checking yaml-rust v0.4.5
[INFO] [stderr]     Checking nom v7.1.3
[INFO] [stderr]     Checking clap_lex v0.2.4
[INFO] [stderr]     Checking backon v1.5.1
[INFO] [stderr]     Checking rand_chacha v0.9.0
[INFO] [stderr]     Checking num-bigint v0.4.6
[INFO] [stderr]     Checking rust-ini v0.18.0
[INFO] [stderr]     Checking atty v0.2.14
[INFO] [stderr]     Checking tracing-log v0.2.0
[INFO] [stderr]     Checking thread_local v1.1.9
[INFO] [stderr]     Checking encoding_rs v0.8.35
[INFO] [stderr]     Checking regex-automata v0.4.9
[INFO] [stderr]     Checking hashbrown v0.14.5
[INFO] [stderr]    Compiling synstructure v0.13.2
[INFO] [stderr]     Checking textwrap v0.16.2
[INFO] [stderr]     Checking ipnet v2.11.0
[INFO] [stderr]     Checking termcolor v1.4.1
[INFO] [stderr]     Checking webpki-roots v0.25.4
[INFO] [stderr]     Checking sha1_smol v1.0.1
[INFO] [stderr]     Checking pathdiff v0.2.3
[INFO] [stderr]     Checking regex v1.11.1
[INFO] [stderr]     Checking iana-time-zone v0.1.63
[INFO] [stderr]     Checking arc-swap v1.7.1
[INFO] [stderr]     Checking tower-http v0.5.2
[INFO] [stderr]     Checking dashmap v6.1.0
[INFO] [stderr]     Checking rand v0.9.1
[INFO] [stderr]     Checking sha2 v0.10.9
[INFO] [stderr]     Checking urlencoding v2.1.3
[INFO] [stderr]     Checking sct v0.7.1
[INFO] [stderr]     Checking rustls-webpki v0.101.7
[INFO] [stderr]    Compiling zerofrom-derive v0.1.6
[INFO] [stderr]    Compiling yoke-derive v0.8.0
[INFO] [stderr]    Compiling tokio-macros v2.5.0
[INFO] [stderr]    Compiling zerovec-derive v0.11.1
[INFO] [stderr]    Compiling displaydoc v0.2.5
[INFO] [stderr]    Compiling serde_derive v1.0.219
[INFO] [stderr]    Compiling futures-macro v0.3.31
[INFO] [stderr]    Compiling thiserror-impl v2.0.12
[INFO] [stderr]     Checking tokio v1.45.1
[INFO] [stderr]    Compiling tracing-attributes v0.1.29
[INFO] [stderr]    Compiling thiserror-impl v1.0.69
[INFO] [stderr]     Checking futures-util v0.3.31
[INFO] [stderr]     Checking zerofrom v0.1.6
[INFO] [stderr]     Checking yoke v0.8.0
[INFO] [stderr]     Checking zerovec v0.11.2
[INFO] [stderr]     Checking zerotrie v0.2.2
[INFO] [stderr]     Checking tracing v0.1.41
[INFO] [stderr]    Compiling thiserror v2.0.12
[INFO] [stderr]    Compiling pest v2.8.1
[INFO] [stderr]     Checking thiserror v1.0.69
[INFO] [stderr]    Compiling async-trait v0.1.88
[INFO] [stderr]     Checking tungstenite v0.24.0
[INFO] [stderr]    Compiling clap_derive v3.2.25
[INFO] [stderr]     Checking tracing-subscriber v0.3.19
[INFO] [stderr]     Checking tinystr v0.8.1
[INFO] [stderr]     Checking icu_locale_core v2.0.0
[INFO] [stderr]     Checking potential_utf v0.1.2
[INFO] [stderr]     Checking icu_collections v2.0.0
[INFO] [stderr]    Compiling pest_meta v2.8.1
[INFO] [stderr]     Checking serde v1.0.219
[INFO] [stderr]     Checking axum-core v0.4.5
[INFO] [stderr]     Checking icu_provider v2.0.0
[INFO] [stderr]     Checking icu_properties v2.0.1
[INFO] [stderr]     Checking icu_normalizer v2.0.0
[INFO] [stderr]    Compiling pest_generator v2.8.1
[INFO] [stderr]     Checking clap v3.2.25
[INFO] [stderr]    Compiling pest_derive v2.8.1
[INFO] [stderr]     Checking tokio-util v0.7.15
[INFO] [stderr]     Checking tokio-rustls v0.24.1
[INFO] [stderr]     Checking hyper v1.6.0
[INFO] [stderr]     Checking tower v0.5.2
[INFO] [stderr]     Checking idna_adapter v1.2.1
[INFO] [stderr]     Checking idna v1.0.3
[INFO] [stderr]     Checking tokio-tungstenite v0.24.0
[INFO] [stderr]     Checking h2 v0.3.26
[INFO] [stderr]     Checking combine v4.6.7
[INFO] [stderr]     Checking url v2.5.4
[INFO] [stderr]     Checking hyper-util v0.1.14
[INFO] [stderr]     Checking serde_urlencoded v0.7.1
[INFO] [stderr]     Checking serde_path_to_error v0.1.17
[INFO] [stderr]     Checking json5 v0.4.1
[INFO] [stderr]     Checking toml v0.5.11
[INFO] [stderr]     Checking ron v0.7.1
[INFO] [stderr]     Checking chrono v0.4.41
[INFO] [stderr]     Checking uuid v1.17.0
[INFO] [stderr]     Checking axum v0.7.9
[INFO] [stderr]     Checking config v0.13.4
[INFO] [stderr]     Checking hyper v0.14.32
[INFO] [stderr]     Checking redis v0.32.0
[INFO] [stderr]     Checking hyper-rustls v0.24.2
[INFO] [stderr]     Checking reqwest v0.11.27
[INFO] [stderr]     Checking fishpi-undercover v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/game.rs:706:17
[INFO] [stdout]     |
[INFO] [stdout] 706 | /                 if *eliminated != "tie" {
[INFO] [stdout] 707 | |                     if let Some(player) = players.iter_mut().find(|p| p.id == *eliminated) {
[INFO] [stdout] 708 | |                         player.is_alive = false;
[INFO] [stdout] 709 | |                     }
[INFO] [stdout] 710 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 706 ~                 if *eliminated != "tie"
[INFO] [stdout] 707 ~                     && let Some(player) = players.iter_mut().find(|p| p.id == *eliminated) {
[INFO] [stdout] 708 |                         player.is_alive = false;
[INFO] [stdout] 709 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/game.rs:706:17
[INFO] [stdout]     |
[INFO] [stdout] 706 | /                 if *eliminated != "tie" {
[INFO] [stdout] 707 | |                     if let Some(player) = players.iter_mut().find(|p| p.id == *eliminated) {
[INFO] [stdout] 708 | |                         player.is_alive = false;
[INFO] [stdout] 709 | |                     }
[INFO] [stdout] 710 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 706 ~                 if *eliminated != "tie"
[INFO] [stdout] 707 ~                     && let Some(player) = players.iter_mut().find(|p| p.id == *eliminated) {
[INFO] [stdout] 708 |                         player.is_alive = false;
[INFO] [stdout] 709 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stdout]    --> src/game.rs:928:21
[INFO] [stdout]     |
[INFO] [stdout] 928 | /                     if !votes.contains_key(&player_id) {
[INFO] [stdout] 929 | |                         let available_targets: Vec<PlayerId> = alive_players
[INFO] [stdout] 930 | |                             .iter()
[INFO] [stdout] 931 | |                             .filter(|id| *id != &player_id)
[INFO] [stdout] ...   |
[INFO] [stdout] 940 | |                     }
[INFO] [stdout]     | |_____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stdout]     = note: `#[warn(clippy::map_entry)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 928 ~                     if let std::collections::hash_map::Entry::Vacant(e) = votes.entry(player_id) {
[INFO] [stdout] 929 +                         let available_targets: Vec<PlayerId> = alive_players
[INFO] [stdout] 930 +                             .iter()
[INFO] [stdout] 931 +                             .filter(|id| *id != &player_id)
[INFO] [stdout] 932 +                             .cloned()
[INFO] [stdout] 933 +                             .collect();
[INFO] [stdout] 934 + 
[INFO] [stdout] 935 +                         if let Some(target) = available_targets.choose(&mut rng) {
[INFO] [stdout] 936 +                             e.insert(target.clone());
[INFO] [stdout] 937 +                         } else {
[INFO] [stdout] 938 ~                             return Err("无法选择投票目标".to_string());
[INFO] [stdout] 939 +                         }
[INFO] [stdout] 940 +                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stdout]    --> src/game.rs:928:21
[INFO] [stdout]     |
[INFO] [stdout] 928 | /                     if !votes.contains_key(&player_id) {
[INFO] [stdout] 929 | |                         let available_targets: Vec<PlayerId> = alive_players
[INFO] [stdout] 930 | |                             .iter()
[INFO] [stdout] 931 | |                             .filter(|id| *id != &player_id)
[INFO] [stdout] ...   |
[INFO] [stdout] 940 | |                     }
[INFO] [stdout]     | |_____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stdout]     = note: `#[warn(clippy::map_entry)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 928 ~                     if let std::collections::hash_map::Entry::Vacant(e) = votes.entry(player_id) {
[INFO] [stdout] 929 +                         let available_targets: Vec<PlayerId> = alive_players
[INFO] [stdout] 930 +                             .iter()
[INFO] [stdout] 931 +                             .filter(|id| *id != &player_id)
[INFO] [stdout] 932 +                             .cloned()
[INFO] [stdout] 933 +                             .collect();
[INFO] [stdout] 934 + 
[INFO] [stdout] 935 +                         if let Some(target) = available_targets.choose(&mut rng) {
[INFO] [stdout] 936 +                             e.insert(target.clone());
[INFO] [stdout] 937 +                         } else {
[INFO] [stdout] 938 ~                             return Err("无法选择投票目标".to_string());
[INFO] [stdout] 939 +                         }
[INFO] [stdout] 940 +                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `MessageBatch`
[INFO] [stdout]   --> src/message.rs:59:5
[INFO] [stdout]    |
[INFO] [stdout] 59 | /     pub fn new() -> Self {
[INFO] [stdout] 60 | |         Self {
[INFO] [stdout] 61 | |             messages: Vec::new(),
[INFO] [stdout] 62 | |             timestamp: chrono::Utc::now().timestamp(),
[INFO] [stdout] 63 | |         }
[INFO] [stdout] 64 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 58 + impl Default for MessageBatch {
[INFO] [stdout] 59 +     fn default() -> Self {
[INFO] [stdout] 60 +         Self::new()
[INFO] [stdout] 61 +     }
[INFO] [stdout] 62 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `MessageQueue`
[INFO] [stdout]   --> src/message.rs:86:5
[INFO] [stdout]    |
[INFO] [stdout] 86 | /     pub fn new() -> Self {
[INFO] [stdout] 87 | |         Self {
[INFO] [stdout] 88 | |             batches: VecDeque::new(),
[INFO] [stdout] 89 | |             current_batch: None,
[INFO] [stdout] 90 | |         }
[INFO] [stdout] 91 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 85 + impl Default for MessageQueue {
[INFO] [stdout] 86 +     fn default() -> Self {
[INFO] [stdout] 87 +         Self::new()
[INFO] [stdout] 88 +     }
[INFO] [stdout] 89 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/message.rs:94:9
[INFO] [stdout]    |
[INFO] [stdout] 94 | /         if let Some(batch) = &mut self.current_batch {
[INFO] [stdout] 95 | |             if !batch.is_full() && !batch.is_expired() {
[INFO] [stdout] 96 | |                 batch.add_message(message);
[INFO] [stdout] 97 | |                 return;
[INFO] [stdout] 98 | |             }
[INFO] [stdout] 99 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 94 ~         if let Some(batch) = &mut self.current_batch
[INFO] [stdout] 95 ~             && !batch.is_full() && !batch.is_expired() {
[INFO] [stdout] 96 |                 batch.add_message(message);
[INFO] [stdout] 97 |                 return;
[INFO] [stdout] 98 ~             }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `MessageBatch`
[INFO] [stdout]   --> src/message.rs:59:5
[INFO] [stdout]    |
[INFO] [stdout] 59 | /     pub fn new() -> Self {
[INFO] [stdout] 60 | |         Self {
[INFO] [stdout] 61 | |             messages: Vec::new(),
[INFO] [stdout] 62 | |             timestamp: chrono::Utc::now().timestamp(),
[INFO] [stdout] 63 | |         }
[INFO] [stdout] 64 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 58 + impl Default for MessageBatch {
[INFO] [stdout] 59 +     fn default() -> Self {
[INFO] [stdout] 60 +         Self::new()
[INFO] [stdout] 61 +     }
[INFO] [stdout] 62 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `MessageQueue`
[INFO] [stdout]   --> src/message.rs:86:5
[INFO] [stdout]    |
[INFO] [stdout] 86 | /     pub fn new() -> Self {
[INFO] [stdout] 87 | |         Self {
[INFO] [stdout] 88 | |             batches: VecDeque::new(),
[INFO] [stdout] 89 | |             current_batch: None,
[INFO] [stdout] 90 | |         }
[INFO] [stdout] 91 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 85 + impl Default for MessageQueue {
[INFO] [stdout] 86 +     fn default() -> Self {
[INFO] [stdout] 87 +         Self::new()
[INFO] [stdout] 88 +     }
[INFO] [stdout] 89 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/message.rs:94:9
[INFO] [stdout]    |
[INFO] [stdout] 94 | /         if let Some(batch) = &mut self.current_batch {
[INFO] [stdout] 95 | |             if !batch.is_full() && !batch.is_expired() {
[INFO] [stdout] 96 | |                 batch.add_message(message);
[INFO] [stdout] 97 | |                 return;
[INFO] [stdout] 98 | |             }
[INFO] [stdout] 99 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 94 ~         if let Some(batch) = &mut self.current_batch
[INFO] [stdout] 95 ~             && !batch.is_full() && !batch.is_expired() {
[INFO] [stdout] 96 |                 batch.add_message(message);
[INFO] [stdout] 97 |                 return;
[INFO] [stdout] 98 ~             }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `ConnectionManager`
[INFO] [stdout]    --> src/network.rs:111:5
[INFO] [stdout]     |
[INFO] [stdout] 111 | /     pub fn new() -> Self {
[INFO] [stdout] 112 | |         Self {
[INFO] [stdout] 113 | |             player_connections: Arc::new(DashMap::new()),
[INFO] [stdout] 114 | |         }
[INFO] [stdout] 115 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 110 + impl Default for ConnectionManager {
[INFO] [stdout] 111 +     fn default() -> Self {
[INFO] [stdout] 112 +         Self::new()
[INFO] [stdout] 113 +     }
[INFO] [stdout] 114 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `ConnectionManager`
[INFO] [stdout]    --> src/network.rs:111:5
[INFO] [stdout]     |
[INFO] [stdout] 111 | /     pub fn new() -> Self {
[INFO] [stdout] 112 | |         Self {
[INFO] [stdout] 113 | |             player_connections: Arc::new(DashMap::new()),
[INFO] [stdout] 114 | |         }
[INFO] [stdout] 115 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 110 + impl Default for ConnectionManager {
[INFO] [stdout] 111 +     fn default() -> Self {
[INFO] [stdout] 112 +         Self::new()
[INFO] [stdout] 113 +     }
[INFO] [stdout] 114 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/network.rs:126:9
[INFO] [stdout]     |
[INFO] [stdout] 125 |         let old_connection = self.player_connections.insert(player_id.clone(), (room_id, tx));
[INFO] [stdout]     |         -------------------------------------------------------------------------------------- unnecessary `let` binding
[INFO] [stdout] 126 |         old_connection
[INFO] [stdout]     |         ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 125 ~         
[INFO] [stdout] 126 ~         self.player_connections.insert(player_id.clone(), (room_id, tx))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/network.rs:126:9
[INFO] [stdout]     |
[INFO] [stdout] 125 |         let old_connection = self.player_connections.insert(player_id.clone(), (room_id, tx));
[INFO] [stdout]     |         -------------------------------------------------------------------------------------- unnecessary `let` binding
[INFO] [stdout] 126 |         old_connection
[INFO] [stdout]     |         ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 125 ~         
[INFO] [stdout] 126 ~         self.player_connections.insert(player_id.clone(), (room_id, tx))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/network.rs:619:18
[INFO] [stdout]     |
[INFO] [stdout] 619 |             Html(format!("<h1>404 Not Found</h1><p>找不到index.html文件</p>"))
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"<h1>404 Not Found</h1><p>找不到index.html文件</p>".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]     = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/network.rs:631:18
[INFO] [stdout]     |
[INFO] [stdout] 631 |             Html(format!("<h1>404 Not Found</h1><p>rooms.html文件</p>"))
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"<h1>404 Not Found</h1><p>rooms.html文件</p>".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/network.rs:619:18
[INFO] [stdout]     |
[INFO] [stdout] 619 |             Html(format!("<h1>404 Not Found</h1><p>找不到index.html文件</p>"))
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"<h1>404 Not Found</h1><p>找不到index.html文件</p>".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]     = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/network.rs:631:18
[INFO] [stdout]     |
[INFO] [stdout] 631 |             Html(format!("<h1>404 Not Found</h1><p>rooms.html文件</p>"))
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"<h1>404 Not Found</h1><p>rooms.html文件</p>".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/network.rs:883:25
[INFO] [stdout]     |
[INFO] [stdout] 883 | /                         if let Ok(text) = serde_json::to_string(&error) {
[INFO] [stdout] 884 | |                             if let Err(e) = ws_sender.lock().await.send(Message::Text(text)).await {
[INFO] [stdout] 885 | |                                 error!("发送错误消息失败: {}", e);
[INFO] [stdout] 886 | |                             }
[INFO] [stdout] 887 | |                         }
[INFO] [stdout]     | |_________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 883 ~                         if let Ok(text) = serde_json::to_string(&error)
[INFO] [stdout] 884 ~                             && let Err(e) = ws_sender.lock().await.send(Message::Text(text)).await {
[INFO] [stdout] 885 |                                 error!("发送错误消息失败: {}", e);
[INFO] [stdout] 886 ~                             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/room.rs:130:29
[INFO] [stdout]     |
[INFO] [stdout] 130 |         let should_delete = (is_empty && !is_new) || (idle_duration > self.max_idle_time) && is_empty;
[INFO] [stdout]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 130 -         let should_delete = (is_empty && !is_new) || (idle_duration > self.max_idle_time) && is_empty;
[INFO] [stdout] 130 +         let should_delete = !(!is_empty || is_new && idle_duration <= self.max_idle_time);
[INFO] [stdout]     |
[INFO] [stdout] 130 -         let should_delete = (is_empty && !is_new) || (idle_duration > self.max_idle_time) && is_empty;
[INFO] [stdout] 130 +         let should_delete = ((idle_duration > self.max_idle_time) || !is_new) && is_empty;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/network.rs:883:25
[INFO] [stdout]     |
[INFO] [stdout] 883 | /                         if let Ok(text) = serde_json::to_string(&error) {
[INFO] [stdout] 884 | |                             if let Err(e) = ws_sender.lock().await.send(Message::Text(text)).await {
[INFO] [stdout] 885 | |                                 error!("发送错误消息失败: {}", e);
[INFO] [stdout] 886 | |                             }
[INFO] [stdout] 887 | |                         }
[INFO] [stdout]     | |_________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 883 ~                         if let Ok(text) = serde_json::to_string(&error)
[INFO] [stdout] 884 ~                             && let Err(e) = ws_sender.lock().await.send(Message::Text(text)).await {
[INFO] [stdout] 885 |                                 error!("发送错误消息失败: {}", e);
[INFO] [stdout] 886 ~                             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stdout]    --> src/room.rs:203:32
[INFO] [stdout]     |
[INFO] [stdout] 203 |                         if let Some(_) = self.update_countdown().await {
[INFO] [stdout]     |                         -------^^^^^^^-------------------------------- help: try: `if self.update_countdown().await.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = note: this will change drop order of the result, as well as all temporaries
[INFO] [stdout]     = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/room.rs:224:9
[INFO] [stdout]     |
[INFO] [stdout] 224 | /         if let Some(other_room_id) = self.storage.get_player_current_room(&player.id).await? {
[INFO] [stdout] 225 | |             if other_room_id != self.id {
[INFO] [stdout] 226 | |                 debug!("玩家 {} 已在房间 {} 中，自动离开原房间", player.name, other_room_id);
[INFO] [stdout] ...   |
[INFO] [stdout] 238 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 224 ~         if let Some(other_room_id) = self.storage.get_player_current_room(&player.id).await?
[INFO] [stdout] 225 ~             && other_room_id != self.id {
[INFO] [stdout] 226 |                 debug!("玩家 {} 已在房间 {} 中，自动离开原房间", player.name, other_room_id);
[INFO] [stdout] ...
[INFO] [stdout] 236 |                 }
[INFO] [stdout] 237 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:254:22
[INFO] [stdout]     |
[INFO] [stdout] 254 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]     = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:288:22
[INFO] [stdout]     |
[INFO] [stdout] 288 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/room.rs:130:29
[INFO] [stdout]     |
[INFO] [stdout] 130 |         let should_delete = (is_empty && !is_new) || (idle_duration > self.max_idle_time) && is_empty;
[INFO] [stdout]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 130 -         let should_delete = (is_empty && !is_new) || (idle_duration > self.max_idle_time) && is_empty;
[INFO] [stdout] 130 +         let should_delete = !(!is_empty || is_new && idle_duration <= self.max_idle_time);
[INFO] [stdout]     |
[INFO] [stdout] 130 -         let should_delete = (is_empty && !is_new) || (idle_duration > self.max_idle_time) && is_empty;
[INFO] [stdout] 130 +         let should_delete = ((idle_duration > self.max_idle_time) || !is_new) && is_empty;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/room.rs:500:13
[INFO] [stdout]     |
[INFO] [stdout] 500 | /             if let Some(other_room_id) = self.storage.get_player_current_room(&player.id).await? {
[INFO] [stdout] 501 | |                 if other_room_id != self.id {
[INFO] [stdout] 502 | |                     debug!("玩家 {} 从房间 {} 切换到房间 {}", player_name, other_room_id, self.id);
[INFO] [stdout] ...   |
[INFO] [stdout] 514 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 500 ~             if let Some(other_room_id) = self.storage.get_player_current_room(&player.id).await?
[INFO] [stdout] 501 ~                 && other_room_id != self.id {
[INFO] [stdout] 502 |                     debug!("玩家 {} 从房间 {} 切换到房间 {}", player_name, other_room_id, self.id);
[INFO] [stdout] ...
[INFO] [stdout] 512 |                     }
[INFO] [stdout] 513 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:532:22
[INFO] [stdout]     |
[INFO] [stdout] 532 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:555:22
[INFO] [stdout]     |
[INFO] [stdout] 555 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stdout]    --> src/room.rs:203:32
[INFO] [stdout]     |
[INFO] [stdout] 203 |                         if let Some(_) = self.update_countdown().await {
[INFO] [stdout]     |                         -------^^^^^^^-------------------------------- help: try: `if self.update_countdown().await.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = note: this will change drop order of the result, as well as all temporaries
[INFO] [stdout]     = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:579:22
[INFO] [stdout]     |
[INFO] [stdout] 579 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:602:22
[INFO] [stdout]     |
[INFO] [stdout] 602 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:625:22
[INFO] [stdout]     |
[INFO] [stdout] 625 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:719:22
[INFO] [stdout]     |
[INFO] [stdout] 719 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/room.rs:224:9
[INFO] [stdout]     |
[INFO] [stdout] 224 | /         if let Some(other_room_id) = self.storage.get_player_current_room(&player.id).await? {
[INFO] [stdout] 225 | |             if other_room_id != self.id {
[INFO] [stdout] 226 | |                 debug!("玩家 {} 已在房间 {} 中，自动离开原房间", player.name, other_room_id);
[INFO] [stdout] ...   |
[INFO] [stdout] 238 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 224 ~         if let Some(other_room_id) = self.storage.get_player_current_room(&player.id).await?
[INFO] [stdout] 225 ~             && other_room_id != self.id {
[INFO] [stdout] 226 |                 debug!("玩家 {} 已在房间 {} 中，自动离开原房间", player.name, other_room_id);
[INFO] [stdout] ...
[INFO] [stdout] 236 |                 }
[INFO] [stdout] 237 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref which would be done by auto-deref
[INFO] [stdout]    --> src/room.rs:748:47
[INFO] [stdout]     |
[INFO] [stdout] 748 |             .save_room_state(self.id.clone(), &*state)
[INFO] [stdout]     |                                               ^^^^^^^ help: try: `&state`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
[INFO] [stdout]     = note: `#[warn(clippy::explicit_auto_deref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:791:30
[INFO] [stdout]     |
[INFO] [stdout] 791 |                     .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:800:30
[INFO] [stdout]     |
[INFO] [stdout] 800 |                     .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:809:30
[INFO] [stdout]     |
[INFO] [stdout] 809 |                     .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:942:30
[INFO] [stdout]     |
[INFO] [stdout] 942 |                     .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:254:22
[INFO] [stdout]     |
[INFO] [stdout] 254 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]     = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]     --> src/room.rs:1164:30
[INFO] [stdout]      |
[INFO] [stdout] 1164 |                     .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]      |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:288:22
[INFO] [stdout]     |
[INFO] [stdout] 288 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]     --> src/room.rs:1298:22
[INFO] [stdout]      |
[INFO] [stdout] 1298 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]      |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]     --> src/room.rs:1315:13
[INFO] [stdout]      |
[INFO] [stdout] 1315 | /             if let Some(role) = player.role {
[INFO] [stdout] 1316 | |                 if let Some(word) = &player.word {
[INFO] [stdout] 1317 | |                     match role {
[INFO] [stdout] 1318 | |                         crate::game::Role::Civilian => {
[INFO] [stdout] ...    |
[INFO] [stdout] 1330 | |             }
[INFO] [stdout]      | |_____________^
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]      |
[INFO] [stdout] 1315 ~             if let Some(role) = player.role
[INFO] [stdout] 1316 ~                 && let Some(word) = &player.word {
[INFO] [stdout] 1317 |                     match role {
[INFO] [stdout]  ...
[INFO] [stdout] 1328 |                     }
[INFO] [stdout] 1329 ~                 }
[INFO] [stdout]      |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/storage.rs:227:13
[INFO] [stdout]     |
[INFO] [stdout] 227 | /             if let Some(data) = conn.get::<_, Option<String>>(&key).await? {
[INFO] [stdout] 228 | |                 if let Ok(result) = serde_json::from_str::<GameResult>(&data) {
[INFO] [stdout] 229 | |                     results.push(result);
[INFO] [stdout] 230 | |                 }
[INFO] [stdout] 231 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 227 ~             if let Some(data) = conn.get::<_, Option<String>>(&key).await?
[INFO] [stdout] 228 ~                 && let Ok(result) = serde_json::from_str::<GameResult>(&data) {
[INFO] [stdout] 229 |                     results.push(result);
[INFO] [stdout] 230 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/room.rs:500:13
[INFO] [stdout]     |
[INFO] [stdout] 500 | /             if let Some(other_room_id) = self.storage.get_player_current_room(&player.id).await? {
[INFO] [stdout] 501 | |                 if other_room_id != self.id {
[INFO] [stdout] 502 | |                     debug!("玩家 {} 从房间 {} 切换到房间 {}", player_name, other_room_id, self.id);
[INFO] [stdout] ...   |
[INFO] [stdout] 514 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 500 ~             if let Some(other_room_id) = self.storage.get_player_current_room(&player.id).await?
[INFO] [stdout] 501 ~                 && other_room_id != self.id {
[INFO] [stdout] 502 |                     debug!("玩家 {} 从房间 {} 切换到房间 {}", player_name, other_room_id, self.id);
[INFO] [stdout] ...
[INFO] [stdout] 512 |                     }
[INFO] [stdout] 513 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]    --> src/storage.rs:528:12
[INFO] [stdout]     |
[INFO] [stdout] 528 |         Ok(prev_hash.map_or(true, |h| h == state_hash))
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_map_or)]` on by default
[INFO] [stdout] help: use `is_none_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 528 -         Ok(prev_hash.map_or(true, |h| h == state_hash))
[INFO] [stdout] 528 +         Ok(prev_hash.is_none_or(|h| h == state_hash))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:532:22
[INFO] [stdout]     |
[INFO] [stdout] 532 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:555:22
[INFO] [stdout]     |
[INFO] [stdout] 555 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:579:22
[INFO] [stdout]     |
[INFO] [stdout] 579 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:602:22
[INFO] [stdout]     |
[INFO] [stdout] 602 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:625:22
[INFO] [stdout]     |
[INFO] [stdout] 625 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:719:22
[INFO] [stdout]     |
[INFO] [stdout] 719 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref which would be done by auto-deref
[INFO] [stdout]    --> src/room.rs:748:47
[INFO] [stdout]     |
[INFO] [stdout] 748 |             .save_room_state(self.id.clone(), &*state)
[INFO] [stdout]     |                                               ^^^^^^^ help: try: `&state`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
[INFO] [stdout]     = note: `#[warn(clippy::explicit_auto_deref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:791:30
[INFO] [stdout]     |
[INFO] [stdout] 791 |                     .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:800:30
[INFO] [stdout]     |
[INFO] [stdout] 800 |                     .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:809:30
[INFO] [stdout]     |
[INFO] [stdout] 809 |                     .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/user.rs:119:25
[INFO] [stdout]     |
[INFO] [stdout] 119 |                         return Ok(user_id.to_string());
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 119 -                         return Ok(user_id.to_string());
[INFO] [stdout] 119 +                         Ok(user_id.to_string())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/room.rs:942:30
[INFO] [stdout]     |
[INFO] [stdout] 942 |                     .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/user.rs:121:25
[INFO] [stdout]     |
[INFO] [stdout] 121 | /                         return Err(crate::Error::Auth(
[INFO] [stdout] 122 | |                             "无法从claimed_id中提取用户ID".to_string(),
[INFO] [stdout] 123 | |                         ));
[INFO] [stdout]     | |__________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 121 ~                         Err(crate::Error::Auth(
[INFO] [stdout] 122 ~                             "无法从claimed_id中提取用户ID".to_string(),
[INFO] [stdout] 123 ~                         ))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/user.rs:126:21
[INFO] [stdout]     |
[INFO] [stdout] 126 |                     return Err(crate::Error::Auth("缺少openid.claimed_id参数".to_string()));
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 126 -                     return Err(crate::Error::Auth("缺少openid.claimed_id参数".to_string()));
[INFO] [stdout] 126 +                     Err(crate::Error::Auth("缺少openid.claimed_id参数".to_string()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/user.rs:129:17
[INFO] [stdout]     |
[INFO] [stdout] 129 |                 return Err(crate::Error::Auth("无效的OpenID模式".to_string()));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 129 -                 return Err(crate::Error::Auth("无效的OpenID模式".to_string()));
[INFO] [stdout] 129 +                 Err(crate::Error::Auth("无效的OpenID模式".to_string()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/user.rs:132:13
[INFO] [stdout]     |
[INFO] [stdout] 132 |             return Err(crate::Error::Auth("缺少openid.mode参数".to_string()));
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 132 -             return Err(crate::Error::Auth("缺少openid.mode参数".to_string()));
[INFO] [stdout] 132 +             Err(crate::Error::Auth("缺少openid.mode参数".to_string()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
[INFO] [stdout]    --> src/user.rs:118:44
[INFO] [stdout]     |
[INFO] [stdout] 118 |                     if let Some(user_id) = claimed_id.split('/').last() {
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last
[INFO] [stdout]     = note: `#[warn(clippy::double_ended_iterator_last)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 118 -                     if let Some(user_id) = claimed_id.split('/').last() {
[INFO] [stdout] 118 +                     if let Some(user_id) = claimed_id.split('/').next_back() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/user.rs:139:9
[INFO] [stdout]     |
[INFO] [stdout] 139 | /         if let Some(timestamp_str) = response_nonce.split('Z').next() {
[INFO] [stdout] 140 | |             if let Ok(timestamp) = DateTime::parse_from_rfc3339(&format!("{}Z", timestamp_str)) {
[INFO] [stdout] 141 | |                 let now = Utc::now();
[INFO] [stdout] 142 | |                 let diff = now.signed_duration_since(timestamp.naive_utc().and_utc());
[INFO] [stdout] ...   |
[INFO] [stdout] 153 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 139 ~         if let Some(timestamp_str) = response_nonce.split('Z').next()
[INFO] [stdout] 140 ~             && let Ok(timestamp) = DateTime::parse_from_rfc3339(&format!("{}Z", timestamp_str)) {
[INFO] [stdout] 141 |                 let now = Utc::now();
[INFO] [stdout] ...
[INFO] [stdout] 151 |                 }
[INFO] [stdout] 152 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]     --> src/room.rs:1164:30
[INFO] [stdout]      |
[INFO] [stdout] 1164 |                     .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]      |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]     --> src/room.rs:1298:22
[INFO] [stdout]      |
[INFO] [stdout] 1298 |             .map_err(|e| crate::Error::Game(e))?;
[INFO] [stdout]      |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `crate::Error::Game`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]     --> src/room.rs:1315:13
[INFO] [stdout]      |
[INFO] [stdout] 1315 | /             if let Some(role) = player.role {
[INFO] [stdout] 1316 | |                 if let Some(word) = &player.word {
[INFO] [stdout] 1317 | |                     match role {
[INFO] [stdout] 1318 | |                         crate::game::Role::Civilian => {
[INFO] [stdout] ...    |
[INFO] [stdout] 1330 | |             }
[INFO] [stdout]      | |_____________^
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]      |
[INFO] [stdout] 1315 ~             if let Some(role) = player.role
[INFO] [stdout] 1316 ~                 && let Some(word) = &player.word {
[INFO] [stdout] 1317 |                     match role {
[INFO] [stdout]  ...
[INFO] [stdout] 1328 |                     }
[INFO] [stdout] 1329 ~                 }
[INFO] [stdout]      |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/storage.rs:227:13
[INFO] [stdout]     |
[INFO] [stdout] 227 | /             if let Some(data) = conn.get::<_, Option<String>>(&key).await? {
[INFO] [stdout] 228 | |                 if let Ok(result) = serde_json::from_str::<GameResult>(&data) {
[INFO] [stdout] 229 | |                     results.push(result);
[INFO] [stdout] 230 | |                 }
[INFO] [stdout] 231 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 227 ~             if let Some(data) = conn.get::<_, Option<String>>(&key).await?
[INFO] [stdout] 228 ~                 && let Ok(result) = serde_json::from_str::<GameResult>(&data) {
[INFO] [stdout] 229 |                     results.push(result);
[INFO] [stdout] 230 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str`
[INFO] [stdout]   --> src/word_bank.rs:26:5
[INFO] [stdout]    |
[INFO] [stdout] 26 | /     pub fn from_str(s: &str) -> Self {
[INFO] [stdout] 27 | |         match s.to_lowercase().as_str() {
[INFO] [stdout] 28 | |             "easy" => Difficulty::Easy,
[INFO] [stdout] 29 | |             "medium" => Difficulty::Medium,
[INFO] [stdout] ...  |
[INFO] [stdout] 33 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stdout]    = note: `#[warn(clippy::should_implement_trait)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `or_insert_with` to construct default value
[INFO] [stdout]    --> src/word_bank.rs:208:14
[INFO] [stdout]     |
[INFO] [stdout] 208 |             .or_insert_with(Vec::new)
[INFO] [stdout]     |              ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout]     = note: `#[warn(clippy::unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]    --> src/storage.rs:528:12
[INFO] [stdout]     |
[INFO] [stdout] 528 |         Ok(prev_hash.map_or(true, |h| h == state_hash))
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_map_or)]` on by default
[INFO] [stdout] help: use `is_none_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 528 -         Ok(prev_hash.map_or(true, |h| h == state_hash))
[INFO] [stdout] 528 +         Ok(prev_hash.is_none_or(|h| h == state_hash))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/user.rs:119:25
[INFO] [stdout]     |
[INFO] [stdout] 119 |                         return Ok(user_id.to_string());
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 119 -                         return Ok(user_id.to_string());
[INFO] [stdout] 119 +                         Ok(user_id.to_string())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/user.rs:121:25
[INFO] [stdout]     |
[INFO] [stdout] 121 | /                         return Err(crate::Error::Auth(
[INFO] [stdout] 122 | |                             "无法从claimed_id中提取用户ID".to_string(),
[INFO] [stdout] 123 | |                         ));
[INFO] [stdout]     | |__________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 121 ~                         Err(crate::Error::Auth(
[INFO] [stdout] 122 ~                             "无法从claimed_id中提取用户ID".to_string(),
[INFO] [stdout] 123 ~                         ))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/user.rs:126:21
[INFO] [stdout]     |
[INFO] [stdout] 126 |                     return Err(crate::Error::Auth("缺少openid.claimed_id参数".to_string()));
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 126 -                     return Err(crate::Error::Auth("缺少openid.claimed_id参数".to_string()));
[INFO] [stdout] 126 +                     Err(crate::Error::Auth("缺少openid.claimed_id参数".to_string()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/user.rs:129:17
[INFO] [stdout]     |
[INFO] [stdout] 129 |                 return Err(crate::Error::Auth("无效的OpenID模式".to_string()));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 129 -                 return Err(crate::Error::Auth("无效的OpenID模式".to_string()));
[INFO] [stdout] 129 +                 Err(crate::Error::Auth("无效的OpenID模式".to_string()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/user.rs:132:13
[INFO] [stdout]     |
[INFO] [stdout] 132 |             return Err(crate::Error::Auth("缺少openid.mode参数".to_string()));
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 132 -             return Err(crate::Error::Auth("缺少openid.mode参数".to_string()));
[INFO] [stdout] 132 +             Err(crate::Error::Auth("缺少openid.mode参数".to_string()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
[INFO] [stdout]    --> src/user.rs:118:44
[INFO] [stdout]     |
[INFO] [stdout] 118 |                     if let Some(user_id) = claimed_id.split('/').last() {
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last
[INFO] [stdout]     = note: `#[warn(clippy::double_ended_iterator_last)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 118 -                     if let Some(user_id) = claimed_id.split('/').last() {
[INFO] [stdout] 118 +                     if let Some(user_id) = claimed_id.split('/').next_back() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/user.rs:139:9
[INFO] [stdout]     |
[INFO] [stdout] 139 | /         if let Some(timestamp_str) = response_nonce.split('Z').next() {
[INFO] [stdout] 140 | |             if let Ok(timestamp) = DateTime::parse_from_rfc3339(&format!("{}Z", timestamp_str)) {
[INFO] [stdout] 141 | |                 let now = Utc::now();
[INFO] [stdout] 142 | |                 let diff = now.signed_duration_since(timestamp.naive_utc().and_utc());
[INFO] [stdout] ...   |
[INFO] [stdout] 153 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 139 ~         if let Some(timestamp_str) = response_nonce.split('Z').next()
[INFO] [stdout] 140 ~             && let Ok(timestamp) = DateTime::parse_from_rfc3339(&format!("{}Z", timestamp_str)) {
[INFO] [stdout] 141 |                 let now = Utc::now();
[INFO] [stdout] ...
[INFO] [stdout] 151 |                 }
[INFO] [stdout] 152 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str`
[INFO] [stdout]   --> src/word_bank.rs:26:5
[INFO] [stdout]    |
[INFO] [stdout] 26 | /     pub fn from_str(s: &str) -> Self {
[INFO] [stdout] 27 | |         match s.to_lowercase().as_str() {
[INFO] [stdout] 28 | |             "easy" => Difficulty::Easy,
[INFO] [stdout] 29 | |             "medium" => Difficulty::Medium,
[INFO] [stdout] ...  |
[INFO] [stdout] 33 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stdout]    = note: `#[warn(clippy::should_implement_trait)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `or_insert_with` to construct default value
[INFO] [stdout]    --> src/word_bank.rs:208:14
[INFO] [stdout]     |
[INFO] [stdout] 208 |             .or_insert_with(Vec::new)
[INFO] [stdout]     |              ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout]     = note: `#[warn(clippy::unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:12:30
[INFO] [stdout]    |
[INFO] [stdout] 12 |         .with(EnvFilter::new(&config.log_filter()))
[INFO] [stdout]    |                              ^^^^^^^^^^^^^^^^^^^^ help: change this to: `config.log_filter()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:12:30
[INFO] [stdout]    |
[INFO] [stdout] 12 |         .with(EnvFilter::new(&config.log_filter()))
[INFO] [stdout]    |                              ^^^^^^^^^^^^^^^^^^^^ help: change this to: `config.log_filter()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 10s
[INFO] running `Command { std: "docker" "inspect" "637e32a21ff9c70a863b1cf96a5af9907c16664f1689b9e207753eded34d4355", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "637e32a21ff9c70a863b1cf96a5af9907c16664f1689b9e207753eded34d4355", kill_on_drop: false }`
[INFO] [stdout] 637e32a21ff9c70a863b1cf96a5af9907c16664f1689b9e207753eded34d4355