[INFO] cloning repository https://github.com/KronosWasTaken/quicksort-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KronosWasTaken/quicksort-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKronosWasTaken%2Fquicksort-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKronosWasTaken%2Fquicksort-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 09db33b723b39eea8c7231eaad338393f3a4c1c7 [INFO] linting KronosWasTaken/quicksort-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKronosWasTaken%2Fquicksort-rs" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/KronosWasTaken/quicksort-rs [INFO] finished tweaking git repo https://github.com/KronosWasTaken/quicksort-rs [INFO] tweaked toml for git repo https://github.com/KronosWasTaken/quicksort-rs written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/KronosWasTaken/quicksort-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/KronosWasTaken/quicksort-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: file `/workspace/builds/worker-7-tc1/source/benches/internal_benchmark.rs` found to be present in multiple build targets: [INFO] [stderr] * `bin` target `benchmark` [INFO] [stderr] * `bench` target `internal_benchmark` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2f03fb7332fb0df1bf24a92aa028374c2a09757627fdf83d4ae194adc3ec8cc8 [INFO] running `Command { std: "docker" "start" "-a" "2f03fb7332fb0df1bf24a92aa028374c2a09757627fdf83d4ae194adc3ec8cc8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2f03fb7332fb0df1bf24a92aa028374c2a09757627fdf83d4ae194adc3ec8cc8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f03fb7332fb0df1bf24a92aa028374c2a09757627fdf83d4ae194adc3ec8cc8", kill_on_drop: false }` [INFO] [stdout] 2f03fb7332fb0df1bf24a92aa028374c2a09757627fdf83d4ae194adc3ec8cc8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 54abc8b793f20b2145d6e5cb46d13155d79a24436e52060146e086f2cd7517f4 [INFO] running `Command { std: "docker" "start" "-a" "54abc8b793f20b2145d6e5cb46d13155d79a24436e52060146e086f2cd7517f4", kill_on_drop: false }` [INFO] [stderr] warning: file `/opt/rustwide/workdir/benches/internal_benchmark.rs` found to be present in multiple build targets: [INFO] [stderr] * `bin` target `benchmark` [INFO] [stderr] * `bench` target `internal_benchmark` [INFO] [stderr] Checking qs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> benches/../src/quicksort.rs:59:16 [INFO] [stdout] | [INFO] [stdout] 59 | if !(ancestor < pivot_val) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ancestor >= pivot_val)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> benches/../src/quicksort.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | / if let Some(ancestor) = ancestor_pivot { [INFO] [stdout] 59 | | if !(ancestor < pivot_val) { [INFO] [stdout] 60 | | let num_lt = partition_slice(v, pivot_pos, true); [INFO] [stdout] 61 | | v = &mut v[(num_lt + 1)..]; [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 58 ~ if let Some(ancestor) = ancestor_pivot [INFO] [stdout] 59 ~ && !(ancestor < pivot_val) { [INFO] [stdout] 60 | let num_lt = partition_slice(v, pivot_pos, true); [INFO] [stdout] ... [INFO] [stdout] 63 | continue; [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> benches/../src/quicksort.rs:121:31 [INFO] [stdout] | [INFO] [stdout] 121 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> benches/../src/quicksort.rs:129:31 [INFO] [stdout] | [INFO] [stdout] 129 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> benches/../src/quicksort.rs:143:31 [INFO] [stdout] | [INFO] [stdout] 143 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> benches/../src/quicksort.rs:59:16 [INFO] [stdout] | [INFO] [stdout] 59 | if !(ancestor < pivot_val) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ancestor >= pivot_val)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> benches/../src/quicksort.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | / if let Some(ancestor) = ancestor_pivot { [INFO] [stdout] 59 | | if !(ancestor < pivot_val) { [INFO] [stdout] 60 | | let num_lt = partition_slice(v, pivot_pos, true); [INFO] [stdout] 61 | | v = &mut v[(num_lt + 1)..]; [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 58 ~ if let Some(ancestor) = ancestor_pivot [INFO] [stdout] 59 ~ && !(ancestor < pivot_val) { [INFO] [stdout] 60 | let num_lt = partition_slice(v, pivot_pos, true); [INFO] [stdout] ... [INFO] [stdout] 63 | continue; [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> benches/../src/quicksort.rs:121:31 [INFO] [stdout] | [INFO] [stdout] 121 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> benches/../src/quicksort.rs:129:31 [INFO] [stdout] | [INFO] [stdout] 129 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> benches/../src/quicksort.rs:143:31 [INFO] [stdout] | [INFO] [stdout] 143 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/quicksort.rs:59:16 [INFO] [stdout] | [INFO] [stdout] 59 | if !(ancestor < pivot_val) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ancestor >= pivot_val)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/quicksort.rs:59:16 [INFO] [stdout] | [INFO] [stdout] 59 | if !(ancestor < pivot_val) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ancestor >= pivot_val)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/quicksort.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | / if let Some(ancestor) = ancestor_pivot { [INFO] [stdout] 59 | | if !(ancestor < pivot_val) { [INFO] [stdout] 60 | | let num_lt = partition_slice(v, pivot_pos, true); [INFO] [stdout] 61 | | v = &mut v[(num_lt + 1)..]; [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 58 ~ if let Some(ancestor) = ancestor_pivot [INFO] [stdout] 59 ~ && !(ancestor < pivot_val) { [INFO] [stdout] 60 | let num_lt = partition_slice(v, pivot_pos, true); [INFO] [stdout] ... [INFO] [stdout] 63 | continue; [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/quicksort.rs:121:31 [INFO] [stdout] | [INFO] [stdout] 121 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/quicksort.rs:129:31 [INFO] [stdout] | [INFO] [stdout] 129 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/quicksort.rs:143:31 [INFO] [stdout] | [INFO] [stdout] 143 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/quicksort.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | / if let Some(ancestor) = ancestor_pivot { [INFO] [stdout] 59 | | if !(ancestor < pivot_val) { [INFO] [stdout] 60 | | let num_lt = partition_slice(v, pivot_pos, true); [INFO] [stdout] 61 | | v = &mut v[(num_lt + 1)..]; [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 58 ~ if let Some(ancestor) = ancestor_pivot [INFO] [stdout] 59 ~ && !(ancestor < pivot_val) { [INFO] [stdout] 60 | let num_lt = partition_slice(v, pivot_pos, true); [INFO] [stdout] ... [INFO] [stdout] 63 | continue; [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/quicksort.rs:121:31 [INFO] [stdout] | [INFO] [stdout] 121 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/quicksort.rs:129:31 [INFO] [stdout] | [INFO] [stdout] 129 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/quicksort.rs:143:31 [INFO] [stdout] | [INFO] [stdout] 143 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> benches/../src/quicksort.rs:59:16 [INFO] [stdout] | [INFO] [stdout] 59 | if !(ancestor < pivot_val) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ancestor >= pivot_val)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> benches/../src/quicksort.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | / if let Some(ancestor) = ancestor_pivot { [INFO] [stdout] 59 | | if !(ancestor < pivot_val) { [INFO] [stdout] 60 | | let num_lt = partition_slice(v, pivot_pos, true); [INFO] [stdout] 61 | | v = &mut v[(num_lt + 1)..]; [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 58 ~ if let Some(ancestor) = ancestor_pivot [INFO] [stdout] 59 ~ && !(ancestor < pivot_val) { [INFO] [stdout] 60 | let num_lt = partition_slice(v, pivot_pos, true); [INFO] [stdout] ... [INFO] [stdout] 63 | continue; [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> benches/../src/quicksort.rs:121:31 [INFO] [stdout] | [INFO] [stdout] 121 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> benches/../src/quicksort.rs:129:31 [INFO] [stdout] | [INFO] [stdout] 129 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> benches/../src/quicksort.rs:143:31 [INFO] [stdout] | [INFO] [stdout] 143 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> benches/../src/quicksort.rs:59:16 [INFO] [stdout] | [INFO] [stdout] 59 | if !(ancestor < pivot_val) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ancestor >= pivot_val)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> benches/../src/quicksort.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | / if let Some(ancestor) = ancestor_pivot { [INFO] [stdout] 59 | | if !(ancestor < pivot_val) { [INFO] [stdout] 60 | | let num_lt = partition_slice(v, pivot_pos, true); [INFO] [stdout] 61 | | v = &mut v[(num_lt + 1)..]; [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 58 ~ if let Some(ancestor) = ancestor_pivot [INFO] [stdout] 59 ~ && !(ancestor < pivot_val) { [INFO] [stdout] 60 | let num_lt = partition_slice(v, pivot_pos, true); [INFO] [stdout] ... [INFO] [stdout] 63 | continue; [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> benches/../src/quicksort.rs:121:31 [INFO] [stdout] | [INFO] [stdout] 121 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> benches/../src/quicksort.rs:129:31 [INFO] [stdout] | [INFO] [stdout] 129 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> benches/../src/quicksort.rs:143:31 [INFO] [stdout] | [INFO] [stdout] 143 | let right_is_lt = !(*pivot < *right) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*pivot >= *right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [optimized + debuginfo] target(s) in 0.67s [INFO] running `Command { std: "docker" "inspect" "54abc8b793f20b2145d6e5cb46d13155d79a24436e52060146e086f2cd7517f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54abc8b793f20b2145d6e5cb46d13155d79a24436e52060146e086f2cd7517f4", kill_on_drop: false }` [INFO] [stdout] 54abc8b793f20b2145d6e5cb46d13155d79a24436e52060146e086f2cd7517f4