[INFO] cloning repository https://github.com/Krelix/rust_vm_tutorial [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Krelix/rust_vm_tutorial" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKrelix%2Frust_vm_tutorial", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKrelix%2Frust_vm_tutorial'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6ac69ddb70fa130b142c83f18e6339d8eb23e122 [INFO] linting Krelix/rust_vm_tutorial against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKrelix%2Frust_vm_tutorial" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Krelix/rust_vm_tutorial [INFO] finished tweaking git repo https://github.com/Krelix/rust_vm_tutorial [INFO] tweaked toml for git repo https://github.com/Krelix/rust_vm_tutorial written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Krelix/rust_vm_tutorial on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Krelix/rust_vm_tutorial already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cfg-if v0.1.5 [INFO] [stderr] Downloaded memchr v2.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b72c39116a6dd92d1924ea7b286531f09bc4b2a5cd0ade650254b8912df8b88d [INFO] running `Command { std: "docker" "start" "-a" "b72c39116a6dd92d1924ea7b286531f09bc4b2a5cd0ade650254b8912df8b88d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b72c39116a6dd92d1924ea7b286531f09bc4b2a5cd0ade650254b8912df8b88d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b72c39116a6dd92d1924ea7b286531f09bc4b2a5cd0ade650254b8912df8b88d", kill_on_drop: false }` [INFO] [stdout] b72c39116a6dd92d1924ea7b286531f09bc4b2a5cd0ade650254b8912df8b88d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2f0bdb54152f3b933ff9cf85394af7b175b482cf69ccb05f124ab053ae84a640 [INFO] running `Command { std: "docker" "start" "-a" "2f0bdb54152f3b933ff9cf85394af7b175b482cf69ccb05f124ab053ae84a640", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Checking cfg-if v0.1.5 [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Compiling memchr v2.1.0 [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Checking rust_vm v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unknown lint: `clippy` [INFO] [stdout] --> src/main.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | #![warn(clippy)] [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unknown_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `vm::VM` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use vm::VM; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unknown lint: `clippy` [INFO] [stdout] --> src/main.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | #![warn(clippy)] [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unknown_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `vm::VM` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use vm::VM; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `opcode` is never read [INFO] [stdout] --> src/instruction.rs:85:3 [INFO] [stdout] | [INFO] [stdout] 84 | pub struct Instruction { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 85 | opcode: OpCode [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/repl/mod.rs:78:43 [INFO] [stdout] | [INFO] [stdout] 78 | let byte = u8::from_str_radix(&hex_string, 16); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `hex_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:32:7 [INFO] [stdout] | [INFO] [stdout] 32 | / match operand { [INFO] [stdout] 33 | | Some(t) => AssemblerInstruction::extract_operand(t, &mut result), [INFO] [stdout] 34 | | None => {} [INFO] [stdout] 35 | | } [INFO] [stdout] | |_______^ help: try: `if let Some(t) = operand { AssemblerInstruction::extract_operand(t, &mut result) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/repl/mod.rs:78:43 [INFO] [stdout] | [INFO] [stdout] 78 | let byte = u8::from_str_radix(&hex_string, 16); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `hex_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assembler/opcode_parsers.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | assert!(!result.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/opcode_parsers.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 27 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 27 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assembler/register_parsers.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | assert!(!result.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assembler/register_parsers.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | assert!(!result.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assembler/operand_parsers.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | assert!(!result.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assembler/operand_parsers.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | assert!(!result.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:32:7 [INFO] [stdout] | [INFO] [stdout] 32 | / match operand { [INFO] [stdout] 33 | | Some(t) => AssemblerInstruction::extract_operand(t, &mut result), [INFO] [stdout] 34 | | None => {} [INFO] [stdout] 35 | | } [INFO] [stdout] | |_______^ help: try: `if let Some(t) = operand { AssemblerInstruction::extract_operand(t, &mut result) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assembler/label_parsers.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | assert!(!result.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assembler/label_parsers.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | assert!(!result.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.93s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v4.0.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "2f0bdb54152f3b933ff9cf85394af7b175b482cf69ccb05f124ab053ae84a640", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f0bdb54152f3b933ff9cf85394af7b175b482cf69ccb05f124ab053ae84a640", kill_on_drop: false }` [INFO] [stdout] 2f0bdb54152f3b933ff9cf85394af7b175b482cf69ccb05f124ab053ae84a640