[INFO] cloning repository https://github.com/KosukeMizuno/simulate_monty_hall [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KosukeMizuno/simulate_monty_hall" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKosukeMizuno%2Fsimulate_monty_hall", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKosukeMizuno%2Fsimulate_monty_hall'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] aeeec65ef2736350203f9bb2b9cbe1f9df54c38a [INFO] linting KosukeMizuno/simulate_monty_hall against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKosukeMizuno%2Fsimulate_monty_hall" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/KosukeMizuno/simulate_monty_hall [INFO] finished tweaking git repo https://github.com/KosukeMizuno/simulate_monty_hall [INFO] tweaked toml for git repo https://github.com/KosukeMizuno/simulate_monty_hall written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/KosukeMizuno/simulate_monty_hall on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/KosukeMizuno/simulate_monty_hall already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ebe21e35bd1743b7c7bd4822375fa9f61841e73460d1102d53673e47cc004ae2 [INFO] running `Command { std: "docker" "start" "-a" "ebe21e35bd1743b7c7bd4822375fa9f61841e73460d1102d53673e47cc004ae2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ebe21e35bd1743b7c7bd4822375fa9f61841e73460d1102d53673e47cc004ae2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ebe21e35bd1743b7c7bd4822375fa9f61841e73460d1102d53673e47cc004ae2", kill_on_drop: false }` [INFO] [stdout] ebe21e35bd1743b7c7bd4822375fa9f61841e73460d1102d53673e47cc004ae2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5ba3c7a8b64bd82543f4aeeb29268cf93b29750cd8bbe454e440067c9ba24d4f [INFO] running `Command { std: "docker" "start" "-a" "5ba3c7a8b64bd82543f4aeeb29268cf93b29750cd8bbe454e440067c9ba24d4f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking simulate_monty_hall v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/main.rs:33:10 [INFO] [stdout] | [INFO] [stdout] 33 | if !(n_door >= n_leftclose + 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `n_door > n_leftclose` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 29 | if !(n_leftclose >= 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(n_leftclose < 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 33 | if !(n_door >= n_leftclose + 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(n_door < n_leftclose + 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/main.rs:47:38 [INFO] [stdout] | [INFO] [stdout] 47 | let results: Vec<(bool, bool)> = iter::repeat(0 as usize) [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 48 | | .take(n_trial) [INFO] [stdout] | |______________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(0 as usize, n_trial)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/main.rs:47:51 [INFO] [stdout] | [INFO] [stdout] 47 | let results: Vec<(bool, bool)> = iter::repeat(0 as usize) [INFO] [stdout] | ^^^^^^^^^^ help: try: `0_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 81 | if !(n_leftclose >= 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(n_leftclose < 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/main.rs:33:10 [INFO] [stdout] | [INFO] [stdout] 33 | if !(n_door >= n_leftclose + 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `n_door > n_leftclose` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 29 | if !(n_leftclose >= 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(n_leftclose < 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 33 | if !(n_door >= n_leftclose + 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(n_door < n_leftclose + 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/main.rs:47:38 [INFO] [stdout] | [INFO] [stdout] 47 | let results: Vec<(bool, bool)> = iter::repeat(0 as usize) [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 48 | | .take(n_trial) [INFO] [stdout] | |______________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(0 as usize, n_trial)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/main.rs:47:51 [INFO] [stdout] | [INFO] [stdout] 47 | let results: Vec<(bool, bool)> = iter::repeat(0 as usize) [INFO] [stdout] | ^^^^^^^^^^ help: try: `0_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 81 | if !(n_leftclose >= 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(n_leftclose < 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.56s [INFO] running `Command { std: "docker" "inspect" "5ba3c7a8b64bd82543f4aeeb29268cf93b29750cd8bbe454e440067c9ba24d4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ba3c7a8b64bd82543f4aeeb29268cf93b29750cd8bbe454e440067c9ba24d4f", kill_on_drop: false }` [INFO] [stdout] 5ba3c7a8b64bd82543f4aeeb29268cf93b29750cd8bbe454e440067c9ba24d4f