[INFO] cloning repository https://github.com/Kooshi/maze-generator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Kooshi/maze-generator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKooshi%2Fmaze-generator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKooshi%2Fmaze-generator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3d80f73a467c011785f2ce9fabf561a74f733884 [INFO] linting Kooshi/maze-generator against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKooshi%2Fmaze-generator" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Kooshi/maze-generator [INFO] finished tweaking git repo https://github.com/Kooshi/maze-generator [INFO] tweaked toml for git repo https://github.com/Kooshi/maze-generator written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Kooshi/maze-generator on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Kooshi/maze-generator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded structopt-derive v0.4.14 [INFO] [stderr] Downloaded rand_hc v0.3.0 [INFO] [stderr] Downloaded rand_core v0.6.0 [INFO] [stderr] Downloaded rand_chacha v0.3.0 [INFO] [stderr] Downloaded structopt v0.3.21 [INFO] [stderr] Downloaded getrandom v0.2.0 [INFO] [stderr] Downloaded rand v0.8.0 [INFO] [stderr] Downloaded libc v0.2.81 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 83938276de3f070d9173e035c3270692473deef43157260ac44f66cdc52289be [INFO] running `Command { std: "docker" "start" "-a" "83938276de3f070d9173e035c3270692473deef43157260ac44f66cdc52289be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "83938276de3f070d9173e035c3270692473deef43157260ac44f66cdc52289be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "83938276de3f070d9173e035c3270692473deef43157260ac44f66cdc52289be", kill_on_drop: false }` [INFO] [stdout] 83938276de3f070d9173e035c3270692473deef43157260ac44f66cdc52289be [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c43397e094d365c7a26eb8c6ca941da999a46fb2c9b80ea0f0a35ff80313a349 [INFO] running `Command { std: "docker" "start" "-a" "c43397e094d365c7a26eb8c6ca941da999a46fb2c9b80ea0f0a35ff80313a349", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling syn v1.0.54 [INFO] [stderr] Compiling getrandom v0.2.0 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rand_core v0.6.0 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.0 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking mazegen v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::ops::Index` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::ops::Index; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Index` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::ops::Index; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `same_set` are never used [INFO] [stdout] --> src/disjoint_set.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 6 | impl DisjointSet { [INFO] [stdout] | ---------------- associated items in this implementation [INFO] [stdout] 7 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | pub fn same_set(&mut self, object1: usize, object2: usize) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `output` is never read [INFO] [stdout] --> src/options.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Opt { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 14 | pub output: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `same_set` are never used [INFO] [stdout] --> src/disjoint_set.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 6 | impl DisjointSet { [INFO] [stdout] | ---------------- associated items in this implementation [INFO] [stdout] 7 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | pub fn same_set(&mut self, object1: usize, object2: usize) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `output` is never read [INFO] [stdout] --> src/options.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Opt { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 14 | pub output: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 47 | if !(cell < w) { //northern border [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(cell >= w)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 50 | if !((cell + 1) % w == 0) { //eastern border [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `((cell + 1) % w != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | if !(cell + 1 > w * h - w) { //southern border [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(cell + 1 <= w * h - w)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:56:8 [INFO] [stdout] | [INFO] [stdout] 56 | if !((cell + 1) % w == 1) { //western border [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `((cell + 1) % w != 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:44:61 [INFO] [stdout] | [INFO] [stdout] 44 | fn remove_wall(cell:usize, cells:&mut DisjointSet, walls:&mut Vec, w:usize, h:usize, rng:&mut R) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 44 - fn remove_wall(cell:usize, cells:&mut DisjointSet, walls:&mut Vec, w:usize, h:usize, rng:&mut R) [INFO] [stdout] 44 + fn remove_wall(cell:usize, cells:&mut DisjointSet, walls:&mut [bool], w:usize, h:usize, rng:&mut R) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | if !((cell + 1) % w == 0) { //eastern border [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(cell + 1).is_multiple_of(w)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | fn render(walls:&Vec, w:usize, h:usize) -> String { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 76 - fn render(walls:&Vec, w:usize, h:usize) -> String { [INFO] [stdout] 76 + fn render(walls:&[bool], w:usize, h:usize) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 47 | if !(cell < w) { //northern border [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(cell >= w)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 50 | if !((cell + 1) % w == 0) { //eastern border [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `((cell + 1) % w != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | if !(cell + 1 > w * h - w) { //southern border [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(cell + 1 <= w * h - w)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:56:8 [INFO] [stdout] | [INFO] [stdout] 56 | if !((cell + 1) % w == 1) { //western border [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `((cell + 1) % w != 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:44:61 [INFO] [stdout] | [INFO] [stdout] 44 | fn remove_wall(cell:usize, cells:&mut DisjointSet, walls:&mut Vec, w:usize, h:usize, rng:&mut R) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 44 - fn remove_wall(cell:usize, cells:&mut DisjointSet, walls:&mut Vec, w:usize, h:usize, rng:&mut R) [INFO] [stdout] 44 + fn remove_wall(cell:usize, cells:&mut DisjointSet, walls:&mut [bool], w:usize, h:usize, rng:&mut R) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | if !((cell + 1) % w == 0) { //eastern border [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(cell + 1).is_multiple_of(w)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | fn render(walls:&Vec, w:usize, h:usize) -> String { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 76 - fn render(walls:&Vec, w:usize, h:usize) -> String { [INFO] [stdout] 76 + fn render(walls:&[bool], w:usize, h:usize) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.00s [INFO] running `Command { std: "docker" "inspect" "c43397e094d365c7a26eb8c6ca941da999a46fb2c9b80ea0f0a35ff80313a349", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c43397e094d365c7a26eb8c6ca941da999a46fb2c9b80ea0f0a35ff80313a349", kill_on_drop: false }` [INFO] [stdout] c43397e094d365c7a26eb8c6ca941da999a46fb2c9b80ea0f0a35ff80313a349