[INFO] cloning repository https://github.com/KojoBailey/nucc-json-lib-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KojoBailey/nucc-json-lib-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKojoBailey%2Fnucc-json-lib-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKojoBailey%2Fnucc-json-lib-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1c27d4eab2729578cfde103c7b56404fba4df710 [INFO] linting KojoBailey/nucc-json-lib-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKojoBailey%2Fnucc-json-lib-rs" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/KojoBailey/nucc-json-lib-rs [INFO] finished tweaking git repo https://github.com/KojoBailey/nucc-json-lib-rs [INFO] tweaked toml for git repo https://github.com/KojoBailey/nucc-json-lib-rs written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/KojoBailey/nucc-json-lib-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/KojoBailey/nucc-json-lib-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating git repository `https://github.com/KojoBailey/nucc-binary-lib-rs.git` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_with_macros v3.16.1 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.113 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.113 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.113 [INFO] [stderr] Downloaded wasm-bindgen v0.2.113 [INFO] [stderr] Downloaded js-sys v0.3.90 [INFO] [stderr] Downloaded serde_with v3.16.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 256ffa8786d0fcabf11ebcd3832e2e60276334aea4fca63ec241c4abeb8fe948 [INFO] running `Command { std: "docker" "start" "-a" "256ffa8786d0fcabf11ebcd3832e2e60276334aea4fca63ec241c4abeb8fe948", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "256ffa8786d0fcabf11ebcd3832e2e60276334aea4fca63ec241c4abeb8fe948", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "256ffa8786d0fcabf11ebcd3832e2e60276334aea4fca63ec241c4abeb8fe948", kill_on_drop: false }` [INFO] [stdout] 256ffa8786d0fcabf11ebcd3832e2e60276334aea4fca63ec241c4abeb8fe948 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5fabca7a7434a21239be03d0743b563a88e712764fc6fc2206f0542688e001a5 [INFO] running `Command { std: "docker" "start" "-a" "5fabca7a7434a21239be03d0743b563a88e712764fc6fc2206f0542688e001a5", kill_on_drop: false }` [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking nucc-message-info v0.1.0 (https://github.com/KojoBailey/nucc-binary-lib-rs.git#8945284b) [INFO] [stderr] Checking nucc-player-color-param v0.1.0 (https://github.com/KojoBailey/nucc-binary-lib-rs.git#8945284b) [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Compiling serde_with_macros v3.16.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking nucc-player-color-param-json v0.1.0 (/opt/rustwide/workdir/player-color-param) [INFO] [stderr] Checking serde_with v3.16.1 [INFO] [stderr] Checking nucc-message-info-json v0.1.0 (/opt/rustwide/workdir/message-info) [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.map(..)` [INFO] [stdout] --> message-info/src/lib.rs:41:14 [INFO] [stdout] | [INFO] [stdout] 41 | .filter_map(|(key, val)| { [INFO] [stdout] | ______________^ [INFO] [stdout] 42 | | let (hash_id, string_id) = match u32::from_str_radix(&key, 16) { [INFO] [stdout] 43 | | Ok(id) => (id, None), [INFO] [stdout] 44 | | Err(_) => (hash(&key), Some(key.clone())), [INFO] [stdout] ... | [INFO] [stdout] 73 | | )) [INFO] [stdout] 74 | | }).collect(), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_filter_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> message-info/src/lib.rs:102:37 [INFO] [stdout] | [INFO] [stdout] 102 | adx2_cue_index: val.adx2_cue_index.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `val.adx2_cue_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> message-info/src/lib.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | assert!(!param.entries[&hashed_key].reference_id.is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `param.entries[&hashed_key].reference_id.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> message-info/src/lib.rs:130:13 [INFO] [stdout] | [INFO] [stdout] 130 | hashed_key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `hashed_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.map(..)` [INFO] [stdout] --> message-info/src/lib.rs:41:14 [INFO] [stdout] | [INFO] [stdout] 41 | .filter_map(|(key, val)| { [INFO] [stdout] | ______________^ [INFO] [stdout] 42 | | let (hash_id, string_id) = match u32::from_str_radix(&key, 16) { [INFO] [stdout] 43 | | Ok(id) => (id, None), [INFO] [stdout] 44 | | Err(_) => (hash(&key), Some(key.clone())), [INFO] [stdout] ... | [INFO] [stdout] 73 | | )) [INFO] [stdout] 74 | | }).collect(), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_filter_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> message-info/src/lib.rs:102:37 [INFO] [stdout] | [INFO] [stdout] 102 | adx2_cue_index: val.adx2_cue_index.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `val.adx2_cue_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.01s [INFO] running `Command { std: "docker" "inspect" "5fabca7a7434a21239be03d0743b563a88e712764fc6fc2206f0542688e001a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5fabca7a7434a21239be03d0743b563a88e712764fc6fc2206f0542688e001a5", kill_on_drop: false }` [INFO] [stdout] 5fabca7a7434a21239be03d0743b563a88e712764fc6fc2206f0542688e001a5