[INFO] cloning repository https://github.com/KojoBailey/nucc-binary-asbr-lib-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KojoBailey/nucc-binary-asbr-lib-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKojoBailey%2Fnucc-binary-asbr-lib-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKojoBailey%2Fnucc-binary-asbr-lib-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9c02c13b900b957b6e53fae0fb429815b1621402 [INFO] linting KojoBailey/nucc-binary-asbr-lib-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKojoBailey%2Fnucc-binary-asbr-lib-rs" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/KojoBailey/nucc-binary-asbr-lib-rs [INFO] finished tweaking git repo https://github.com/KojoBailey/nucc-binary-asbr-lib-rs [INFO] tweaked toml for git repo https://github.com/KojoBailey/nucc-binary-asbr-lib-rs written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/KojoBailey/nucc-binary-asbr-lib-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/KojoBailey/nucc-binary-asbr-lib-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/KojoBailey/nucc-binary-lib-rs.git` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4ac7fd5e1b7f731e7b9602bee12e8da55ee6b7f005c53733e7257dfaeabe2062 [INFO] running `Command { std: "docker" "start" "-a" "4ac7fd5e1b7f731e7b9602bee12e8da55ee6b7f005c53733e7257dfaeabe2062", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4ac7fd5e1b7f731e7b9602bee12e8da55ee6b7f005c53733e7257dfaeabe2062", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ac7fd5e1b7f731e7b9602bee12e8da55ee6b7f005c53733e7257dfaeabe2062", kill_on_drop: false }` [INFO] [stdout] 4ac7fd5e1b7f731e7b9602bee12e8da55ee6b7f005c53733e7257dfaeabe2062 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 15854221b63fefabf50af91754df81bbbb082e79d4d8e3c57b382adce4c792c9 [INFO] running `Command { std: "docker" "start" "-a" "15854221b63fefabf50af91754df81bbbb082e79d4d8e3c57b382adce4c792c9", kill_on_drop: false }` [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking nucc-player-color-param v0.1.0 (https://github.com/KojoBailey/nucc-binary-lib-rs.git#8c05d17d) [INFO] [stderr] Checking nucc-player-color-param-asbr v0.1.0 (/opt/rustwide/workdir/player-color-param) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> player-color-param/src/lib.rs:85:32 [INFO] [stdout] | [INFO] [stdout] 85 | let bytes = to_binary_data(&data)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> player-color-param/src/lib.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | for (key, value) in &entries { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, (key, value)) in (&entries).into_iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> player-color-param/src/lib.rs:85:32 [INFO] [stdout] | [INFO] [stdout] 85 | let bytes = to_binary_data(&data)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> player-color-param/src/lib.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | for (key, value) in &entries { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, (key, value)) in (&entries).into_iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> player-color-param/src/lib.rs:161:17 [INFO] [stdout] | [INFO] [stdout] 161 | assert!(!result.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.40s [INFO] running `Command { std: "docker" "inspect" "15854221b63fefabf50af91754df81bbbb082e79d4d8e3c57b382adce4c792c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "15854221b63fefabf50af91754df81bbbb082e79d4d8e3c57b382adce4c792c9", kill_on_drop: false }` [INFO] [stdout] 15854221b63fefabf50af91754df81bbbb082e79d4d8e3c57b382adce4c792c9