[INFO] cloning repository https://github.com/KlotzAndrew/concur [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KlotzAndrew/concur" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKlotzAndrew%2Fconcur", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKlotzAndrew%2Fconcur'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 91d606d7c2bfb42b5d83464c6b5a4f6da33b5058 [INFO] linting KlotzAndrew/concur against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKlotzAndrew%2Fconcur" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/KlotzAndrew/concur [INFO] finished tweaking git repo https://github.com/KlotzAndrew/concur [INFO] tweaked toml for git repo https://github.com/KlotzAndrew/concur written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/KlotzAndrew/concur on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/KlotzAndrew/concur already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rand_core v0.2.2 [INFO] [stderr] Downloaded thread_local v0.3.6 [INFO] [stderr] Downloaded rand_core v0.3.0 [INFO] [stderr] Downloaded utf8-ranges v1.0.2 [INFO] [stderr] Downloaded uuid v0.7.1 [INFO] [stderr] Downloaded cfg-if v0.1.6 [INFO] [stderr] Downloaded aho-corasick v0.6.10 [INFO] [stderr] Downloaded rustc-demangle v0.1.13 [INFO] [stderr] Downloaded cargo_metadata v0.5.8 [INFO] [stderr] Downloaded if_chain v0.1.3 [INFO] [stderr] Downloaded cc v1.0.29 [INFO] [stderr] Downloaded serde_derive v1.0.88 [INFO] [stderr] Downloaded unicode-normalization v0.1.8 [INFO] [stderr] Downloaded serde_json v1.0.38 [INFO] [stderr] Downloaded itertools v0.7.11 [INFO] [stderr] Downloaded num-traits v0.2.6 [INFO] [stderr] Downloaded memchr v2.2.0 [INFO] [stderr] Downloaded pulldown-cmark v0.1.2 [INFO] [stderr] Downloaded syn v0.15.26 [INFO] [stderr] Downloaded regex v1.1.0 [INFO] [stderr] Downloaded clippy v0.0.212 [INFO] [stderr] Downloaded backtrace v0.3.14 [INFO] [stderr] Downloaded toml v0.4.10 [INFO] [stderr] Downloaded clippy_lints v0.0.212 [INFO] [stderr] Downloaded regex-syntax v0.6.5 [INFO] [stderr] Downloaded ucd-util v0.1.3 [INFO] [stderr] Downloaded serde v1.0.88 [INFO] [stderr] Downloaded either v1.5.1 [INFO] [stderr] Downloaded quine-mc_cluskey v0.2.4 [INFO] [stderr] Downloaded smallvec v0.6.9 [INFO] [stderr] Downloaded libc v0.2.45 [INFO] [stderr] Downloaded backtrace-sys v0.1.28 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 597bb43bcb32ee629646fa48ee5c33c48dd33f46411ae05cb92ead45637eecd2 [INFO] running `Command { std: "docker" "start" "-a" "597bb43bcb32ee629646fa48ee5c33c48dd33f46411ae05cb92ead45637eecd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "597bb43bcb32ee629646fa48ee5c33c48dd33f46411ae05cb92ead45637eecd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "597bb43bcb32ee629646fa48ee5c33c48dd33f46411ae05cb92ead45637eecd2", kill_on_drop: false }` [INFO] [stdout] 597bb43bcb32ee629646fa48ee5c33c48dd33f46411ae05cb92ead45637eecd2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 49a95e0c39fdaad477bb533294ac4b3fe3b94641a4e737bd3708f949050c10ae [INFO] running `Command { std: "docker" "start" "-a" "49a95e0c39fdaad477bb533294ac4b3fe3b94641a4e737bd3708f949050c10ae", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.45 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Checking concur v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/or_set.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let mut element = self.elements.entry(value.to_string()).or_insert(Element{version: 0, removed: true}); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/mv_register.rs:10:3 [INFO] [stdout] | [INFO] [stdout] 9 | struct Element { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 10 | id: String, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `Element` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/or_set.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let mut element = self.elements.entry(value.to_string()).or_insert(Element{version: 0, removed: true}); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/mv_register.rs:10:3 [INFO] [stdout] | [INFO] [stdout] 9 | struct Element { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 10 | id: String, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `Element` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/mv_register_test.rs:10:53 [INFO] [stdout] | [INFO] [stdout] 10 | assert_eq!("dog".to_string(), first.clone().get(&"a")); [INFO] [stdout] | ^^^^ help: change this to: `"a"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/mv_register_test.rs:16:53 [INFO] [stdout] | [INFO] [stdout] 16 | assert_eq!("cat".to_string(), first.clone().get(&"b")); [INFO] [stdout] | ^^^^ help: change this to: `"b"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/mv_register_test.rs:24:46 [INFO] [stdout] | [INFO] [stdout] 24 | assert_eq!("pup3".to_string(), first.get(&"c")); [INFO] [stdout] | ^^^^ help: change this to: `"c"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/lww_register_test.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | assert!(!crdt.assign(2, 1).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `crdt.assign(2, 1).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.99s [INFO] running `Command { std: "docker" "inspect" "49a95e0c39fdaad477bb533294ac4b3fe3b94641a4e737bd3708f949050c10ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "49a95e0c39fdaad477bb533294ac4b3fe3b94641a4e737bd3708f949050c10ae", kill_on_drop: false }` [INFO] [stdout] 49a95e0c39fdaad477bb533294ac4b3fe3b94641a4e737bd3708f949050c10ae