[INFO] cloning repository https://github.com/KingAkin/rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KingAkin/rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKingAkin%2Frust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKingAkin%2Frust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8f240f977699859f59d5220777b981c4b6f8c49b [INFO] linting KingAkin/rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKingAkin%2Frust" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/KingAkin/rust [INFO] finished tweaking git repo https://github.com/KingAkin/rust [INFO] tweaked toml for git repo https://github.com/KingAkin/rust written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/KingAkin/rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/KingAkin/rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3374ede521bac1ca4daeeba087b181aa7e2402d421670160d1364538b2e6dd91 [INFO] running `Command { std: "docker" "start" "-a" "3374ede521bac1ca4daeeba087b181aa7e2402d421670160d1364538b2e6dd91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3374ede521bac1ca4daeeba087b181aa7e2402d421670160d1364538b2e6dd91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3374ede521bac1ca4daeeba087b181aa7e2402d421670160d1364538b2e6dd91", kill_on_drop: false }` [INFO] [stdout] 3374ede521bac1ca4daeeba087b181aa7e2402d421670160d1364538b2e6dd91 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a147f1cf6fd6c9ff786b38cc5c9051e5fd1cc418ccb920f3c222730041a4d432 [INFO] running `Command { std: "docker" "start" "-a" "a147f1cf6fd6c9ff786b38cc5c9051e5fd1cc418ccb920f3c222730041a4d432", kill_on_drop: false }` [INFO] [stderr] Checking my_project_name_lib v0.1.0 (/opt/rustwide/workdir/my_project_name_lib) [INFO] [stderr] Checking my_project_name v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/how_to_hold_data_for_operations/derived/user_defined.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | bottom_right: bottom_right, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bottom_right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/how_to_hold_data_for_operations/derived/user_defined.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | bottom_right: bottom_right, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bottom_right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `0`, `1`, `2`, and `3` are never read [INFO] [stdout] --> src/how_to_hold_data_for_operations/primitives/compound.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 28 | struct Matrix(f32, f32, f32, f32); [INFO] [stdout] | ------ ^^^ ^^^ ^^^ ^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing these fields [INFO] [stdout] = note: `Matrix` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `0`, `1`, `2`, and `3` are never read [INFO] [stdout] --> src/how_to_hold_data_for_operations/primitives/compound.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 28 | struct Matrix(f32, f32, f32, f32); [INFO] [stdout] | ------ ^^^ ^^^ ^^^ ^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing these fields [INFO] [stdout] = note: `Matrix` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/greetings/french.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | let message = String::from("Alo"); [INFO] [stdout] | ---------------------------------- unnecessary `let` binding [INFO] [stdout] 3 | message [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 2 ~ [INFO] [stdout] 3 ~ String::from("Alo") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/greetings/french.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | let message = String::from("Alo"); [INFO] [stdout] | ---------------------------------- unnecessary `let` binding [INFO] [stdout] 3 | message [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 2 ~ [INFO] [stdout] 3 ~ String::from("Alo") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/greetings/spanish.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | let message = String::from("Hola"); [INFO] [stdout] | ----------------------------------- unnecessary `let` binding [INFO] [stdout] 3 | message [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 2 ~ [INFO] [stdout] 3 ~ String::from("Hola") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/greetings/spanish.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | let message = String::from("Hola"); [INFO] [stdout] | ----------------------------------- unnecessary `let` binding [INFO] [stdout] 3 | message [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 2 ~ [INFO] [stdout] 3 ~ String::from("Hola") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/greetings/english.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | let message = String::from("Hi!"); [INFO] [stdout] | ---------------------------------- unnecessary `let` binding [INFO] [stdout] 3 | message [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 2 ~ [INFO] [stdout] 3 ~ String::from("Hi!") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/greetings/english.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | let message = String::from("Hi!"); [INFO] [stdout] | ---------------------------------- unnecessary `let` binding [INFO] [stdout] 3 | message [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 2 ~ [INFO] [stdout] 3 ~ String::from("Hi!") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/how_to_hold_data_for_operations/primitives/compound.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | let message = String::from("Gen V for the win!!!!!!!!!"); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 3 | message [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 2 ~ [INFO] [stdout] 3 ~ String::from("Gen V for the win!!!!!!!!!") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/how_to_hold_data_for_operations/primitives/compound.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | let message = String::from("Gen V for the win!!!!!!!!!"); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 3 | message [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 2 ~ [INFO] [stdout] 3 ~ String::from("Gen V for the win!!!!!!!!!") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/how_to_hold_data_for_operations/primitives/scalar.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | let message = String::from("Scalar"); [INFO] [stdout] | ------------------------------------- unnecessary `let` binding [INFO] [stdout] 3 | message [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 2 ~ [INFO] [stdout] 3 ~ String::from("Scalar") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/how_to_hold_data_for_operations/primitives/scalar.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | return b; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return b; [INFO] [stdout] 9 + b [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/how_to_hold_data_for_operations/primitives/scalar.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return a + b; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return a + b; [INFO] [stdout] 16 + a + b [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/how_to_hold_data_for_operations/primitives/scalar.rs:38:38 [INFO] [stdout] | [INFO] [stdout] 38 | println!("true AND false is {}", true && false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/how_to_hold_data_for_operations/primitives/scalar.rs:39:37 [INFO] [stdout] | [INFO] [stdout] 39 | println!("true OR false is {}", true || false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/how_to_hold_data_for_operations/primitives/scalar.rs:40:32 [INFO] [stdout] | [INFO] [stdout] 40 | println!("NOT true is {}", !true); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/how_to_hold_data_for_operations/primitives/scalar.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | let message = String::from("Scalar"); [INFO] [stdout] | ------------------------------------- unnecessary `let` binding [INFO] [stdout] 3 | message [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 2 ~ [INFO] [stdout] 3 ~ String::from("Scalar") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/how_to_hold_data_for_operations/primitives/scalar.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | return b; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return b; [INFO] [stdout] 9 + b [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/how_to_hold_data_for_operations/primitives/scalar.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return a + b; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return a + b; [INFO] [stdout] 16 + a + b [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/how_to_hold_data_for_operations/primitives/scalar.rs:38:38 [INFO] [stdout] | [INFO] [stdout] 38 | println!("true AND false is {}", true && false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/how_to_hold_data_for_operations/primitives/scalar.rs:39:37 [INFO] [stdout] | [INFO] [stdout] 39 | println!("true OR false is {}", true || false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/how_to_hold_data_for_operations/primitives/scalar.rs:40:32 [INFO] [stdout] | [INFO] [stdout] 40 | println!("NOT true is {}", !true); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.21s [INFO] running `Command { std: "docker" "inspect" "a147f1cf6fd6c9ff786b38cc5c9051e5fd1cc418ccb920f3c222730041a4d432", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a147f1cf6fd6c9ff786b38cc5c9051e5fd1cc418ccb920f3c222730041a4d432", kill_on_drop: false }` [INFO] [stdout] a147f1cf6fd6c9ff786b38cc5c9051e5fd1cc418ccb920f3c222730041a4d432