[INFO] cloning repository https://github.com/KilDesu/playsync [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KilDesu/playsync" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKilDesu%2Fplaysync", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKilDesu%2Fplaysync'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2b6a77d8c404668957bade3f759a6dc4e6a319c4 [INFO] linting KilDesu/playsync against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKilDesu%2Fplaysync" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/KilDesu/playsync [INFO] finished tweaking git repo https://github.com/KilDesu/playsync [INFO] tweaked toml for git repo https://github.com/KilDesu/playsync written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/KilDesu/playsync on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/KilDesu/playsync already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded openssl-probe v0.2.0 [INFO] [stderr] Downloaded confy v1.0.0 [INFO] [stderr] Downloaded directories v6.0.0 [INFO] [stderr] Downloaded zmij v1.0.7 [INFO] [stderr] Downloaded google-apis-common v7.0.0 [INFO] [stderr] Downloaded unit-prefix v0.5.2 [INFO] [stderr] Downloaded console v0.16.2 [INFO] [stderr] Downloaded schemars v1.2.0 [INFO] [stderr] Downloaded yup-oauth2 v11.0.0 [INFO] [stderr] Downloaded indicatif v0.18.3 [INFO] [stderr] Downloaded google-youtube3 v6.0.0+20240626 [INFO] [stderr] Downloaded cliclack v0.3.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e18f90f5f6f368539dc42a96a0299172979513ecb4a664457a39078284542f02 [INFO] running `Command { std: "docker" "start" "-a" "e18f90f5f6f368539dc42a96a0299172979513ecb4a664457a39078284542f02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e18f90f5f6f368539dc42a96a0299172979513ecb4a664457a39078284542f02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e18f90f5f6f368539dc42a96a0299172979513ecb4a664457a39078284542f02", kill_on_drop: false }` [INFO] [stdout] e18f90f5f6f368539dc42a96a0299172979513ecb4a664457a39078284542f02 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 52805bedb5a79946fcd7ac3c364d55736b67e17dde93f0e466b91773f160252c [INFO] running `Command { std: "docker" "start" "-a" "52805bedb5a79946fcd7ac3c364d55736b67e17dde93f0e466b91773f160252c", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.112 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Compiling aws-lc-rs v1.15.2 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking ipnet v2.11.0 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling rustls v0.23.35 [INFO] [stderr] Compiling zmij v1.0.7 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Compiling serde_json v1.0.148 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking openssl-probe v0.2.0 [INFO] [stderr] Checking unicode-width v0.2.2 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking openssl-probe v0.1.6 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Checking time-core v0.1.6 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Compiling portable-atomic v1.13.0 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking iana-time-zone v0.1.64 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking seahash v4.1.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking ryu v1.0.22 [INFO] [stderr] Checking unit-prefix v0.5.2 [INFO] [stderr] Checking iri-string v0.7.10 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking textwrap v0.16.2 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling cc v1.2.51 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking console v0.16.2 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking directories v6.0.0 [INFO] [stderr] Checking indicatif v0.18.3 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Compiling aws-lc-sys v0.35.0 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling zeroize_derive v1.4.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking rustls-pki-types v1.13.2 [INFO] [stderr] Checking cliclack v0.3.7 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking rustls-native-certs v0.8.3 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Compiling serde_with_macros v3.16.1 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_with v3.16.1 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking confy v1.0.0 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking yup-oauth2 v11.0.0 [INFO] [stderr] Checking google-apis-common v7.0.0 [INFO] [stderr] Checking google-youtube3 v6.0.0+20240626 [INFO] [stderr] Checking playsync v0.1.1-rc (/opt/rustwide/workdir) [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:61:1 [INFO] [stdout] | [INFO] [stdout] 61 | / impl Default for Config { [INFO] [stdout] 62 | | fn default() -> Self { [INFO] [stdout] 63 | | Config { [INFO] [stdout] 64 | | playlists: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 68 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 38 + #[derive(Default)] [INFO] [stdout] 39 | pub struct Config { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/config.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 142 | / let selected = multiselect("Select playlists to sync from:") [INFO] [stdout] 143 | | .items(&items) [INFO] [stdout] 144 | | .filter_mode() [INFO] [stdout] 145 | | .required(false) [INFO] [stdout] 146 | | .interact() [INFO] [stdout] 147 | | .unwrap_or_default(); [INFO] [stdout] | |_____________________________- unnecessary `let` binding [INFO] [stdout] 148 | [INFO] [stdout] 149 | selected [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 142 ~ [INFO] [stdout] 143 | [INFO] [stdout] 144 ~ multiselect("Select playlists to sync from:") [INFO] [stdout] 145 + .items(&items) [INFO] [stdout] 146 + .filter_mode() [INFO] [stdout] 147 + .required(false) [INFO] [stdout] 148 + .interact() [INFO] [stdout] 149 + .unwrap_or_default() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sync.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 13 | sp.start(&format!("Syncing playlist: {}", target_playlist.title)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Syncing playlist: {}", target_playlist.title)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:61:1 [INFO] [stdout] | [INFO] [stdout] 61 | / impl Default for Config { [INFO] [stdout] 62 | | fn default() -> Self { [INFO] [stdout] 63 | | Config { [INFO] [stdout] 64 | | playlists: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 68 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 38 + #[derive(Default)] [INFO] [stdout] 39 | pub struct Config { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/config.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 142 | / let selected = multiselect("Select playlists to sync from:") [INFO] [stdout] 143 | | .items(&items) [INFO] [stdout] 144 | | .filter_mode() [INFO] [stdout] 145 | | .required(false) [INFO] [stdout] 146 | | .interact() [INFO] [stdout] 147 | | .unwrap_or_default(); [INFO] [stdout] | |_____________________________- unnecessary `let` binding [INFO] [stdout] 148 | [INFO] [stdout] 149 | selected [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 142 ~ [INFO] [stdout] 143 | [INFO] [stdout] 144 ~ multiselect("Select playlists to sync from:") [INFO] [stdout] 145 + .items(&items) [INFO] [stdout] 146 + .filter_mode() [INFO] [stdout] 147 + .required(false) [INFO] [stdout] 148 + .interact() [INFO] [stdout] 149 + .unwrap_or_default() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sync.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 13 | sp.start(&format!("Syncing playlist: {}", target_playlist.title)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Syncing playlist: {}", target_playlist.title)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sync.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | sp.stop(&format!( [INFO] [stdout] | _____________^ [INFO] [stdout] 38 | | "Found {} videos to sync to '{}'", [INFO] [stdout] 39 | | videos_to_add.len(), [INFO] [stdout] 40 | | target_playlist.title [INFO] [stdout] 41 | | )); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 ~ sp.stop(format!( [INFO] [stdout] 38 + "Found {} videos to sync to '{}'", [INFO] [stdout] 39 + videos_to_add.len(), [INFO] [stdout] 40 + target_playlist.title [INFO] [stdout] 41 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sync.rs:48:19 [INFO] [stdout] | [INFO] [stdout] 48 | log::info(&format!("Would add {} videos:", videos_to_add.len()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Would add {} videos:", videos_to_add.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sync.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | sp.stop(&format!( [INFO] [stdout] | _____________^ [INFO] [stdout] 38 | | "Found {} videos to sync to '{}'", [INFO] [stdout] 39 | | videos_to_add.len(), [INFO] [stdout] 40 | | target_playlist.title [INFO] [stdout] 41 | | )); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 ~ sp.stop(format!( [INFO] [stdout] 38 + "Found {} videos to sync to '{}'", [INFO] [stdout] 39 + videos_to_add.len(), [INFO] [stdout] 40 + target_playlist.title [INFO] [stdout] 41 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sync.rs:50:23 [INFO] [stdout] | [INFO] [stdout] 50 | log::info(&format!(" - {}", video.title))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!(" - {}", video.title)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sync.rs:57:14 [INFO] [stdout] | [INFO] [stdout] 57 | sp.start(&format!( [INFO] [stdout] | ______________^ [INFO] [stdout] 58 | | "Adding {} videos to playlist", [INFO] [stdout] 59 | | videos_to_add.len() [INFO] [stdout] 60 | | )); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 57 ~ sp.start(format!( [INFO] [stdout] 58 + "Adding {} videos to playlist", [INFO] [stdout] 59 + videos_to_add.len() [INFO] [stdout] 60 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sync.rs:71:27 [INFO] [stdout] | [INFO] [stdout] 71 | log::info(&format!("Added: {}", video.title))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Added: {}", video.title)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sync.rs:48:19 [INFO] [stdout] | [INFO] [stdout] 48 | log::info(&format!("Would add {} videos:", videos_to_add.len()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Would add {} videos:", videos_to_add.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sync.rs:74:30 [INFO] [stdout] | [INFO] [stdout] 74 | log::warning(&format!("Failed to add '{}': {}", video.title, e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Failed to add '{}': {}", video.title, e)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sync.rs:50:23 [INFO] [stdout] | [INFO] [stdout] 50 | log::info(&format!(" - {}", video.title))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!(" - {}", video.title)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sync.rs:79:18 [INFO] [stdout] | [INFO] [stdout] 79 | log::success(&format!("Successfully added {} videos", added_count))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Successfully added {} videos", added_count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sync.rs:57:14 [INFO] [stdout] | [INFO] [stdout] 57 | sp.start(&format!( [INFO] [stdout] | ______________^ [INFO] [stdout] 58 | | "Adding {} videos to playlist", [INFO] [stdout] 59 | | videos_to_add.len() [INFO] [stdout] 60 | | )); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 57 ~ sp.start(format!( [INFO] [stdout] 58 + "Adding {} videos to playlist", [INFO] [stdout] 59 + videos_to_add.len() [INFO] [stdout] 60 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sync.rs:71:27 [INFO] [stdout] | [INFO] [stdout] 71 | log::info(&format!("Added: {}", video.title))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Added: {}", video.title)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sync.rs:74:30 [INFO] [stdout] | [INFO] [stdout] 74 | log::warning(&format!("Failed to add '{}': {}", video.title, e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Failed to add '{}': {}", video.title, e)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sync.rs:79:18 [INFO] [stdout] | [INFO] [stdout] 79 | log::success(&format!("Successfully added {} videos", added_count))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Successfully added {} videos", added_count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/youtube.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | / if let Some(items) = result.1.items { [INFO] [stdout] 77 | | if let Some(playlist) = items.first() { [INFO] [stdout] 78 | | if let Some(snippet) = &playlist.snippet { [INFO] [stdout] 79 | | return Ok(snippet.title.clone().unwrap_or_default()); [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 76 ~ if let Some(items) = result.1.items [INFO] [stdout] 77 ~ && let Some(playlist) = items.first() { [INFO] [stdout] 78 | if let Some(snippet) = &playlist.snippet { [INFO] [stdout] 79 | return Ok(snippet.title.clone().unwrap_or_default()); [INFO] [stdout] 80 | } [INFO] [stdout] 81 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/youtube.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | / if let Some(playlist) = items.first() { [INFO] [stdout] 78 | | if let Some(snippet) = &playlist.snippet { [INFO] [stdout] 79 | | return Ok(snippet.title.clone().unwrap_or_default()); [INFO] [stdout] 80 | | } [INFO] [stdout] 81 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 77 ~ if let Some(playlist) = items.first() [INFO] [stdout] 78 ~ && let Some(snippet) = &playlist.snippet { [INFO] [stdout] 79 | return Ok(snippet.title.clone().unwrap_or_default()); [INFO] [stdout] 80 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/youtube.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 110 | / if let (Some(snippet), Some(content_details)) = [INFO] [stdout] 111 | | (&item.snippet, &item.content_details) [INFO] [stdout] 112 | | { [INFO] [stdout] 113 | | if let Some(video_id) = &content_details.video_id { [INFO] [stdout] ... | [INFO] [stdout] 119 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 111 ~ (&item.snippet, &item.content_details) [INFO] [stdout] 112 ~ && let Some(video_id) = &content_details.video_id { [INFO] [stdout] 113 | videos.push(VideoInfo { [INFO] [stdout] ... [INFO] [stdout] 116 | }); [INFO] [stdout] 117 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/youtube.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | / if let Some(items) = result.1.items { [INFO] [stdout] 77 | | if let Some(playlist) = items.first() { [INFO] [stdout] 78 | | if let Some(snippet) = &playlist.snippet { [INFO] [stdout] 79 | | return Ok(snippet.title.clone().unwrap_or_default()); [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 76 ~ if let Some(items) = result.1.items [INFO] [stdout] 77 ~ && let Some(playlist) = items.first() { [INFO] [stdout] 78 | if let Some(snippet) = &playlist.snippet { [INFO] [stdout] 79 | return Ok(snippet.title.clone().unwrap_or_default()); [INFO] [stdout] 80 | } [INFO] [stdout] 81 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/youtube.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | / if let Some(playlist) = items.first() { [INFO] [stdout] 78 | | if let Some(snippet) = &playlist.snippet { [INFO] [stdout] 79 | | return Ok(snippet.title.clone().unwrap_or_default()); [INFO] [stdout] 80 | | } [INFO] [stdout] 81 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 77 ~ if let Some(playlist) = items.first() [INFO] [stdout] 78 ~ && let Some(snippet) = &playlist.snippet { [INFO] [stdout] 79 | return Ok(snippet.title.clone().unwrap_or_default()); [INFO] [stdout] 80 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/youtube.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 110 | / if let (Some(snippet), Some(content_details)) = [INFO] [stdout] 111 | | (&item.snippet, &item.content_details) [INFO] [stdout] 112 | | { [INFO] [stdout] 113 | | if let Some(video_id) = &content_details.video_id { [INFO] [stdout] ... | [INFO] [stdout] 119 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 111 ~ (&item.snippet, &item.content_details) [INFO] [stdout] 112 ~ && let Some(video_id) = &content_details.video_id { [INFO] [stdout] 113 | videos.push(VideoInfo { [INFO] [stdout] ... [INFO] [stdout] 116 | }); [INFO] [stdout] 117 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:93:8 [INFO] [stdout] | [INFO] [stdout] 93 | if !args.oauth2_json.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.oauth2_json.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `playlist.sync_from` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:155:32 [INFO] [stdout] | [INFO] [stdout] 152 | if playlist.sync_from.is_some() { [INFO] [stdout] | ------------------------------- help: try: `if let Some() = &playlist.sync_from` [INFO] [stdout] ... [INFO] [stdout] 155 | for sync_id in playlist.sync_from.as_ref().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:107:36 [INFO] [stdout] | [INFO] [stdout] 107 | let sync_from = if cfg.playlists.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cfg.playlists.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:128:23 [INFO] [stdout] | [INFO] [stdout] 128 | outro(&format!("❌ Failed to fetch playlist info: {}", e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("❌ Failed to fetch playlist info: {}", e)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:93:8 [INFO] [stdout] | [INFO] [stdout] 93 | if !args.oauth2_json.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.oauth2_json.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `playlist.sync_from` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:155:32 [INFO] [stdout] | [INFO] [stdout] 152 | if playlist.sync_from.is_some() { [INFO] [stdout] | ------------------------------- help: try: `if let Some() = &playlist.sync_from` [INFO] [stdout] ... [INFO] [stdout] 155 | for sync_id in playlist.sync_from.as_ref().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:107:36 [INFO] [stdout] | [INFO] [stdout] 107 | let sync_from = if cfg.playlists.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cfg.playlists.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:128:23 [INFO] [stdout] | [INFO] [stdout] 128 | outro(&format!("❌ Failed to fetch playlist info: {}", e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("❌ Failed to fetch playlist info: {}", e)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 57.29s [INFO] running `Command { std: "docker" "inspect" "52805bedb5a79946fcd7ac3c364d55736b67e17dde93f0e466b91773f160252c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52805bedb5a79946fcd7ac3c364d55736b67e17dde93f0e466b91773f160252c", kill_on_drop: false }` [INFO] [stdout] 52805bedb5a79946fcd7ac3c364d55736b67e17dde93f0e466b91773f160252c