[INFO] cloning repository https://github.com/KhaledSharif/TsetlinMachine [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KhaledSharif/TsetlinMachine" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKhaledSharif%2FTsetlinMachine", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKhaledSharif%2FTsetlinMachine'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 27e4d57c599b5add4d63b212d92a72ed0ef78ee8 [INFO] linting KhaledSharif/TsetlinMachine against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKhaledSharif%2FTsetlinMachine" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/KhaledSharif/TsetlinMachine [INFO] finished tweaking git repo https://github.com/KhaledSharif/TsetlinMachine [INFO] tweaked toml for git repo https://github.com/KhaledSharif/TsetlinMachine written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/KhaledSharif/TsetlinMachine on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/KhaledSharif/TsetlinMachine already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded matrixmultiply v0.1.14 [INFO] [stderr] Downloaded rand_core v0.1.0-pre.0 [INFO] [stderr] Downloaded memchr v2.0.1 [INFO] [stderr] Downloaded num-traits v0.2.2 [INFO] [stderr] Downloaded either v1.5.0 [INFO] [stderr] Downloaded rawpointer v0.1.0 [INFO] [stderr] Downloaded bitflags v1.0.1 [INFO] [stderr] Downloaded num-complex v0.1.43 [INFO] [stderr] Downloaded csv-core v0.1.4 [INFO] [stderr] Downloaded rand v0.5.0-pre.0 [INFO] [stderr] Downloaded serde v1.0.37 [INFO] [stderr] Downloaded itertools v0.7.8 [INFO] [stderr] Downloaded ndarray v0.11.2 [INFO] [stderr] Downloaded libc v0.2.40 [INFO] [stderr] Downloaded winapi v0.3.4 [INFO] [stderr] Downloaded csv v1.0.0-beta.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3ebf4b08a1f077c8cda71b1d7bf8bbf9423f17bb26febd5b2bed6e7557f01187 [INFO] running `Command { std: "docker" "start" "-a" "3ebf4b08a1f077c8cda71b1d7bf8bbf9423f17bb26febd5b2bed6e7557f01187", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3ebf4b08a1f077c8cda71b1d7bf8bbf9423f17bb26febd5b2bed6e7557f01187", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ebf4b08a1f077c8cda71b1d7bf8bbf9423f17bb26febd5b2bed6e7557f01187", kill_on_drop: false }` [INFO] [stdout] 3ebf4b08a1f077c8cda71b1d7bf8bbf9423f17bb26febd5b2bed6e7557f01187 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7d22a8686371293a260d346d76de2719a8b3afce9a7fafa06c3c4803c8ed4a60 [INFO] running `Command { std: "docker" "start" "-a" "7d22a8686371293a260d346d76de2719a8b3afce9a7fafa06c3c4803c8ed4a60", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking libc v0.2.40 [INFO] [stderr] Compiling matrixmultiply v0.1.14 [INFO] [stderr] Checking num-traits v0.2.2 [INFO] [stderr] Checking rawpointer v0.1.0 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Compiling ndarray v0.11.2 [INFO] [stderr] Checking serde v1.0.37 [INFO] [stderr] Checking rand_core v0.1.0-pre.0 [INFO] [stderr] Checking itertools v0.7.8 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking rand v0.5.0-pre.0 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking tsetlin_machine v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:206:29 [INFO] [stdout] | [INFO] [stdout] 206 | for (outputs_index, mut outputs_element) in self.outputs.iter_mut().enumerate() [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TsetlinMachine` [INFO] [stdout] --> src/lib.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn new() -> TsetlinMachine [INFO] [stdout] 17 | | { [INFO] [stdout] 18 | | TsetlinMachine [INFO] [stdout] ... | [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for TsetlinMachine { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `it` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:41:64 [INFO] [stdout] | [INFO] [stdout] 39 | if it.is_some() [INFO] [stdout] | --------------- help: try: `if let Some() = it` [INFO] [stdout] 40 | { [INFO] [stdout] 41 | self.outputs[oi].clauses[ci].inclusions.remove(it.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/lib.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 59 | / { [INFO] [stdout] 60 | | if s < s_inverse_conjugate [INFO] [stdout] 61 | | { [INFO] [stdout] 62 | | self.outputs[oi].clauses[ci].automata_states[ai] += 1; [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/lib.rs:67:21 [INFO] [stdout] | [INFO] [stdout] 67 | / { [INFO] [stdout] 68 | | if s < s_inverse_conjugate [INFO] [stdout] 69 | | { [INFO] [stdout] 70 | | self.outputs[oi].clauses[ci].automata_states[ai] += 1; [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/lib.rs:87:17 [INFO] [stdout] | [INFO] [stdout] 87 | / { [INFO] [stdout] 88 | | if inclusion [INFO] [stdout] 89 | | { [INFO] [stdout] 90 | | if s < s_inverse [INFO] [stdout] ... | [INFO] [stdout] 104 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/lib.rs:105:22 [INFO] [stdout] | [INFO] [stdout] 105 | else { [INFO] [stdout] | ______________________^ [INFO] [stdout] 106 | | if inclusion [INFO] [stdout] 107 | | { [INFO] [stdout] 108 | | if s < s_inverse [INFO] [stdout] ... | [INFO] [stdout] 122 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/lib.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | / { [INFO] [stdout] 90 | | if s < s_inverse [INFO] [stdout] 91 | | { [INFO] [stdout] 92 | | self.outputs[oi].clauses[ci].automata_states[ai] -= 1; [INFO] [stdout] ... | [INFO] [stdout] 95 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/lib.rs:97:21 [INFO] [stdout] | [INFO] [stdout] 97 | / { [INFO] [stdout] 98 | | if s < s_inverse [INFO] [stdout] 99 | | { [INFO] [stdout] 100 | | self.outputs[oi].clauses[ci].automata_states[ai] -= 1; [INFO] [stdout] ... | [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/lib.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | / { [INFO] [stdout] 108 | | if s < s_inverse [INFO] [stdout] 109 | | { [INFO] [stdout] 110 | | self.outputs[oi].clauses[ci].automata_states[ai] -= 1; [INFO] [stdout] ... | [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/lib.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | / { [INFO] [stdout] 116 | | if s < s_inverse [INFO] [stdout] 117 | | { [INFO] [stdout] 118 | | self.outputs[oi].clauses[ci].automata_states[ai] -= 1; [INFO] [stdout] ... | [INFO] [stdout] 121 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/lib.rs:151:88 [INFO] [stdout] | [INFO] [stdout] 151 | self.outputs[oi].clauses[ci].automata_states.resize(number_of_inputs * (2 as usize), 0); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `2_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:157:52 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn learn(&mut self, target_output_states : &Vec, s : f32, t : f32, rng : &mut ThreadRng) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 157 - pub fn learn(&mut self, target_output_states : &Vec, s : f32, t : f32, rng : &mut ThreadRng) [INFO] [stdout] 157 + pub fn learn(&mut self, target_output_states : &[bool], s : f32, t : f32, rng : &mut ThreadRng) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `oi` is used to index `target_output_states` [INFO] [stdout] --> src/lib.rs:161:19 [INFO] [stdout] | [INFO] [stdout] 161 | for oi in 0..self.outputs.len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 161 - for oi in 0..self.outputs.len() [INFO] [stdout] 161 + for (oi, ) in target_output_states.iter().enumerate().take(self.outputs.len()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/lib.rs:164:33 [INFO] [stdout] | [INFO] [stdout] 164 | let rescale = 1.0 / ((2.0 * t) as f32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(2.0 * t)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:206:29 [INFO] [stdout] | [INFO] [stdout] 206 | for (outputs_index, mut outputs_element) in self.outputs.iter_mut().enumerate() [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TsetlinMachine` [INFO] [stdout] --> src/lib.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn new() -> TsetlinMachine [INFO] [stdout] 17 | | { [INFO] [stdout] 18 | | TsetlinMachine [INFO] [stdout] ... | [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for TsetlinMachine { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | label : label, [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:135:21 [INFO] [stdout] | [INFO] [stdout] 135 | data : data, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `it` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:41:64 [INFO] [stdout] | [INFO] [stdout] 39 | if it.is_some() [INFO] [stdout] | --------------- help: try: `if let Some() = it` [INFO] [stdout] 40 | { [INFO] [stdout] 41 | self.outputs[oi].clauses[ci].inclusions.remove(it.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/lib.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 59 | / { [INFO] [stdout] 60 | | if s < s_inverse_conjugate [INFO] [stdout] 61 | | { [INFO] [stdout] 62 | | self.outputs[oi].clauses[ci].automata_states[ai] += 1; [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/lib.rs:67:21 [INFO] [stdout] | [INFO] [stdout] 67 | / { [INFO] [stdout] 68 | | if s < s_inverse_conjugate [INFO] [stdout] 69 | | { [INFO] [stdout] 70 | | self.outputs[oi].clauses[ci].automata_states[ai] += 1; [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/lib.rs:87:17 [INFO] [stdout] | [INFO] [stdout] 87 | / { [INFO] [stdout] 88 | | if inclusion [INFO] [stdout] 89 | | { [INFO] [stdout] 90 | | if s < s_inverse [INFO] [stdout] ... | [INFO] [stdout] 104 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/lib.rs:105:22 [INFO] [stdout] | [INFO] [stdout] 105 | else { [INFO] [stdout] | ______________________^ [INFO] [stdout] 106 | | if inclusion [INFO] [stdout] 107 | | { [INFO] [stdout] 108 | | if s < s_inverse [INFO] [stdout] ... | [INFO] [stdout] 122 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/lib.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | / { [INFO] [stdout] 90 | | if s < s_inverse [INFO] [stdout] 91 | | { [INFO] [stdout] 92 | | self.outputs[oi].clauses[ci].automata_states[ai] -= 1; [INFO] [stdout] ... | [INFO] [stdout] 95 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/lib.rs:97:21 [INFO] [stdout] | [INFO] [stdout] 97 | / { [INFO] [stdout] 98 | | if s < s_inverse [INFO] [stdout] 99 | | { [INFO] [stdout] 100 | | self.outputs[oi].clauses[ci].automata_states[ai] -= 1; [INFO] [stdout] ... | [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/lib.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | / { [INFO] [stdout] 108 | | if s < s_inverse [INFO] [stdout] 109 | | { [INFO] [stdout] 110 | | self.outputs[oi].clauses[ci].automata_states[ai] -= 1; [INFO] [stdout] ... | [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/lib.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | / { [INFO] [stdout] 116 | | if s < s_inverse [INFO] [stdout] 117 | | { [INFO] [stdout] 118 | | self.outputs[oi].clauses[ci].automata_states[ai] -= 1; [INFO] [stdout] ... | [INFO] [stdout] 121 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/lib.rs:151:88 [INFO] [stdout] | [INFO] [stdout] 151 | self.outputs[oi].clauses[ci].automata_states.resize(number_of_inputs * (2 as usize), 0); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `2_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:157:52 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn learn(&mut self, target_output_states : &Vec, s : f32, t : f32, rng : &mut ThreadRng) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 157 - pub fn learn(&mut self, target_output_states : &Vec, s : f32, t : f32, rng : &mut ThreadRng) [INFO] [stdout] 157 + pub fn learn(&mut self, target_output_states : &[bool], s : f32, t : f32, rng : &mut ThreadRng) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `oi` is used to index `target_output_states` [INFO] [stdout] --> src/lib.rs:161:19 [INFO] [stdout] | [INFO] [stdout] 161 | for oi in 0..self.outputs.len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 161 - for oi in 0..self.outputs.len() [INFO] [stdout] 161 + for (oi, ) in target_output_states.iter().enumerate().take(self.outputs.len()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/lib.rs:164:33 [INFO] [stdout] | [INFO] [stdout] 164 | let rescale = 1.0 / ((2.0 * t) as f32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(2.0 * t)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | label : label, [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:135:21 [INFO] [stdout] | [INFO] [stdout] 135 | data : data, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 114 | assert!(!rdr_with_error.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rdr_with_error.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | return m; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return m; [INFO] [stdout] 96 + m [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return true; [INFO] [stdout] 157 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:145:31 [INFO] [stdout] | [INFO] [stdout] 145 | fn check_two_vectors(y_true : &Vec, y_pred : &Vec) -> bool [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 145 - fn check_two_vectors(y_true : &Vec, y_pred : &Vec) -> bool [INFO] [stdout] 145 + fn check_two_vectors(y_true : &[bool], y_pred : &Vec) -> bool [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:145:52 [INFO] [stdout] | [INFO] [stdout] 145 | fn check_two_vectors(y_true : &Vec, y_pred : &Vec) -> bool [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 145 - fn check_two_vectors(y_true : &Vec, y_pred : &Vec) -> bool [INFO] [stdout] 145 + fn check_two_vectors(y_true : &Vec, y_pred : &[bool]) -> bool [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | assert!(y_true.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!y_true.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 114 | assert!(!rdr_with_error.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rdr_with_error.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | return m; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return m; [INFO] [stdout] 96 + m [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return true; [INFO] [stdout] 157 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:145:31 [INFO] [stdout] | [INFO] [stdout] 145 | fn check_two_vectors(y_true : &Vec, y_pred : &Vec) -> bool [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 145 - fn check_two_vectors(y_true : &Vec, y_pred : &Vec) -> bool [INFO] [stdout] 145 + fn check_two_vectors(y_true : &[bool], y_pred : &Vec) -> bool [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:145:52 [INFO] [stdout] | [INFO] [stdout] 145 | fn check_two_vectors(y_true : &Vec, y_pred : &Vec) -> bool [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 145 - fn check_two_vectors(y_true : &Vec, y_pred : &Vec) -> bool [INFO] [stdout] 145 + fn check_two_vectors(y_true : &Vec, y_pred : &[bool]) -> bool [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | assert!(y_true.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!y_true.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> tests/xor.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | / { [INFO] [stdout] 46 | | correct = true; [INFO] [stdout] 47 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> tests/xor.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | / { [INFO] [stdout] 50 | | correct = true; [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.30s [INFO] running `Command { std: "docker" "inspect" "7d22a8686371293a260d346d76de2719a8b3afce9a7fafa06c3c4803c8ed4a60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d22a8686371293a260d346d76de2719a8b3afce9a7fafa06c3c4803c8ed4a60", kill_on_drop: false }` [INFO] [stdout] 7d22a8686371293a260d346d76de2719a8b3afce9a7fafa06c3c4803c8ed4a60