[INFO] cloning repository https://github.com/KeystonCloud/satellite [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KeystonCloud/satellite" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKeystonCloud%2Fsatellite", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKeystonCloud%2Fsatellite'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f8072f1aee226d624e3e68d585a2c284a672961d [INFO] linting KeystonCloud/satellite against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKeystonCloud%2Fsatellite" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/KeystonCloud/satellite [INFO] finished tweaking git repo https://github.com/KeystonCloud/satellite [INFO] tweaked toml for git repo https://github.com/KeystonCloud/satellite written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/KeystonCloud/satellite on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/KeystonCloud/satellite already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded fast_chemail v0.9.6 [INFO] [stderr] Downloaded struct_iterable_derive v0.1.0 [INFO] [stderr] Downloaded struct_iterable_internal v0.1.1 [INFO] [stderr] Downloaded struct_iterable v0.1.1 [INFO] [stderr] Downloaded crc16 v0.4.0 [INFO] [stderr] Downloaded sqlx-macros v0.8.6 [INFO] [stderr] Downloaded async-graphql-value v7.0.17 [INFO] [stderr] Downloaded async-graphql-axum v7.0.17 [INFO] [stderr] Downloaded ascii_utils v0.9.3 [INFO] [stderr] Downloaded argon2 v0.5.3 [INFO] [stderr] Downloaded async-graphql-derive v7.0.17 [INFO] [stderr] Downloaded async-graphql-parser v7.0.17 [INFO] [stderr] Downloaded tungstenite v0.28.0 [INFO] [stderr] Downloaded handlebars v5.1.2 [INFO] [stderr] Downloaded h2 v0.4.12 [INFO] [stderr] Downloaded sqlx-core v0.8.6 [INFO] [stderr] Downloaded num-bigint-dig v0.8.5 [INFO] [stderr] Downloaded sqlx-postgres v0.8.6 [INFO] [stderr] Downloaded axum v0.8.6 [INFO] [stderr] Downloaded p384 v0.13.1 [INFO] [stderr] Downloaded sqlx v0.8.6 [INFO] [stderr] Downloaded openssl v0.10.74 [INFO] [stderr] Downloaded yaml-rust2 v0.10.4 [INFO] [stderr] Downloaded sqlx-mysql v0.8.6 [INFO] [stderr] Downloaded sqlx-sqlite v0.8.6 [INFO] [stderr] Downloaded openssl-sys v0.9.110 [INFO] [stderr] Downloaded axum-extra v0.12.1 [INFO] [stderr] Downloaded async-graphql v7.0.17 [INFO] [stderr] Downloaded redis v0.32.7 [INFO] [stderr] Downloaded rustls v0.23.34 [INFO] [stderr] Downloaded toml v0.9.8 [INFO] [stderr] Downloaded config v0.15.18 [INFO] [stderr] Downloaded jsonwebtoken v10.1.0 [INFO] [stderr] Downloaded rust-ini v0.21.3 [INFO] [stderr] Downloaded sqlx-macros-core v0.8.6 [INFO] [stderr] Downloaded multer v3.1.0 [INFO] [stderr] Downloaded tokio-tungstenite v0.28.0 [INFO] [stderr] Downloaded static_assertions_next v1.1.2 [INFO] [stderr] Downloaded axum-core v0.5.5 [INFO] [stderr] Downloaded ordered-multimap v0.7.3 [INFO] [stderr] Downloaded erased-serde v0.4.8 [INFO] [stderr] Downloaded serde-untagged v0.1.9 [INFO] [stderr] Downloaded serde_spanned v1.0.3 [INFO] [stderr] Downloaded password-hash v0.5.0 [INFO] [stderr] Downloaded indexmap v2.12.0 [INFO] [stderr] Downloaded rustls-pki-types v1.13.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d601353b3229730d0ae060956e668d0ae77745a8219cdbbcacd697b24e204fb2 [INFO] running `Command { std: "docker" "start" "-a" "d601353b3229730d0ae060956e668d0ae77745a8219cdbbcacd697b24e204fb2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d601353b3229730d0ae060956e668d0ae77745a8219cdbbcacd697b24e204fb2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d601353b3229730d0ae060956e668d0ae77745a8219cdbbcacd697b24e204fb2", kill_on_drop: false }` [INFO] [stdout] d601353b3229730d0ae060956e668d0ae77745a8219cdbbcacd697b24e204fb2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6fc8db2d239f6876f4e09cefef78471092e3fcc70854a441b0d0dfd6affe6cf2 [INFO] running `Command { std: "docker" "start" "-a" "6fc8db2d239f6876f4e09cefef78471092e3fcc70854a441b0d0dfd6affe6cf2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Compiling generic-array v0.14.9 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Compiling icu_properties_data v2.1.1 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling stable_deref_trait v1.2.1 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking base64ct v1.8.0 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling syn v2.0.108 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking mio v1.1.0 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Compiling litemap v0.8.1 [INFO] [stderr] Compiling writeable v0.6.2 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Compiling itoa v1.0.15 [INFO] [stderr] Compiling ucd-trie v0.1.7 [INFO] [stderr] Compiling ryu v1.0.20 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Compiling pest v2.8.3 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking indexmap v2.12.0 [INFO] [stderr] Compiling pin-project-lite v0.2.16 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Compiling futures-core v0.3.31 [INFO] [stderr] Compiling crunchy v0.2.4 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling lock_api v0.4.14 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking ff v0.13.1 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Compiling zerocopy v0.8.27 [INFO] [stderr] Compiling pest_meta v2.8.3 [INFO] [stderr] Compiling allocator-api2 v0.2.21 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Compiling utf8_iter v1.0.4 [INFO] [stderr] Compiling futures-sink v0.3.31 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling percent-encoding v2.3.2 [INFO] [stderr] Compiling foldhash v0.1.5 [INFO] [stderr] Compiling tinyvec v1.10.0 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling pest_generator v2.8.3 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Compiling regex-syntax v0.8.8 [INFO] [stderr] Compiling parking v2.2.1 [INFO] [stderr] Compiling slab v0.4.11 [INFO] [stderr] Compiling winnow v0.7.13 [INFO] [stderr] Checking ipnet v2.11.0 [INFO] [stderr] Checking iana-time-zone v0.1.64 [INFO] [stderr] Compiling futures-task v0.3.31 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Compiling chrono v0.4.42 [INFO] [stderr] Compiling crc v3.3.0 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling yoke v0.8.1 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling regex-automata v0.4.13 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Compiling toml_parser v1.0.4 [INFO] [stderr] Compiling pest_derive v2.8.3 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Compiling event-listener v5.4.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling hashlink v0.10.0 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking bytes v1.10.1 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling unicode-normalization v0.1.25 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Compiling unicode-bidi v0.3.18 [INFO] [stderr] Compiling unicode-properties v0.1.4 [INFO] [stderr] Compiling typeid v1.0.3 [INFO] [stderr] Compiling toml_datetime v0.7.3 [INFO] [stderr] Checking data-encoding v2.9.0 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Compiling toml_edit v0.23.7 [INFO] [stderr] Checking tungstenite v0.28.0 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling regex v1.12.2 [INFO] [stderr] Compiling async-graphql-value v7.0.17 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling futures-channel v0.3.31 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Compiling multer v3.1.0 [INFO] [stderr] Compiling time-core v0.1.6 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling erased-serde v0.4.8 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling whoami v1.6.1 [INFO] [stderr] Compiling home v0.5.12 [INFO] [stderr] Compiling num-bigint-dig v0.8.5 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Compiling time-macros v0.2.24 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Compiling strum v0.26.3 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Compiling async-graphql-parser v7.0.17 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking tokio-tungstenite v0.28.0 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking axum-core v0.5.5 [INFO] [stderr] Compiling sqlx-core v0.8.6 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking ascii_utils v0.9.3 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Compiling crc16 v0.4.0 [INFO] [stderr] Checking matchit v0.8.4 [INFO] [stderr] Compiling find-msvc-tools v0.1.4 [INFO] [stderr] Compiling cc v1.2.43 [INFO] [stderr] Checking ordered-multimap v0.7.3 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Compiling async-graphql-derive v7.0.17 [INFO] [stderr] Checking fast_chemail v0.9.6 [INFO] [stderr] Compiling sqlx-postgres v0.8.6 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking handlebars v5.1.2 [INFO] [stderr] Checking headers-core v0.3.0 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Compiling erased-serde v0.3.31 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking serde_spanned v1.0.3 [INFO] [stderr] Compiling struct_iterable_internal v0.1.1 [INFO] [stderr] Checking arraydeque v0.5.1 [INFO] [stderr] Checking static_assertions_next v1.1.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Compiling openssl-sys v0.9.110 [INFO] [stderr] Checking yaml-rust2 v0.10.4 [INFO] [stderr] Checking toml v0.9.8 [INFO] [stderr] Compiling struct_iterable_derive v0.1.0 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking rsa v0.9.8 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking headers v0.4.1 [INFO] [stderr] Checking serde-untagged v0.1.9 [INFO] [stderr] Checking simple_asn1 v0.6.3 [INFO] [stderr] Checking rust-ini v0.21.3 [INFO] [stderr] Checking p384 v0.13.1 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking pem v3.0.6 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking config v0.15.18 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Checking struct_iterable v0.1.1 [INFO] [stderr] Checking jsonwebtoken v10.1.0 [INFO] [stderr] Checking axum v0.8.6 [INFO] [stderr] Compiling openssl v0.10.74 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking openssl-probe v0.1.6 [INFO] [stderr] Compiling unicase v2.8.1 [INFO] [stderr] Checking iri-string v0.7.8 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling sqlx-macros-core v0.8.6 [INFO] [stderr] Checking rustls-pki-types v1.13.0 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking async-graphql v7.0.17 [INFO] [stderr] Compiling sqlx-macros v0.8.6 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking redis v0.32.7 [INFO] [stderr] Checking axum-extra v0.12.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.24 [INFO] [stderr] Checking async-graphql-axum v7.0.17 [INFO] [stderr] Checking kc-core v0.1.0 (/opt/rustwide/workdir/crates/kc-core) [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/app.rs:62:51 [INFO] [stdout] | [INFO] [stdout] 62 | pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 62 - pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 62 + pub async fn find_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/app.rs:89:56 [INFO] [stdout] | [INFO] [stdout] 89 | pub async fn find_by_user_id(db_pool: &DbPool, id: &String) -> Result, String> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 89 - pub async fn find_by_user_id(db_pool: &DbPool, id: &String) -> Result, String> { [INFO] [stdout] 89 + pub async fn find_by_user_id(db_pool: &DbPool, id: &str) -> Result, String> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/app.rs:121:53 [INFO] [stdout] | [INFO] [stdout] 121 | pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 121 - pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 121 + pub async fn delete_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/app.rs:62:51 [INFO] [stdout] | [INFO] [stdout] 62 | pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 62 - pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 62 + pub async fn find_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/app.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | id: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 140 - id: &String, [INFO] [stdout] 140 + id: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> crates/kc-core/src/models/app.rs:150:21 [INFO] [stdout] | [INFO] [stdout] 150 | / if let Some(v) = value { [INFO] [stdout] 151 | | if i == 0 { [INFO] [stdout] 152 | | query_builder.push(" SET "); [INFO] [stdout] 153 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 158 | | i += 1; [INFO] [stdout] 159 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> crates/kc-core/src/models/app.rs:149:29 [INFO] [stdout] | [INFO] [stdout] 149 | if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 150 | if let Some(v) = value { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/app.rs:149:17 [INFO] [stdout] | [INFO] [stdout] 149 | / if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] 150 | | if let Some(v) = value { [INFO] [stdout] 151 | | if i == 0 { [INFO] [stdout] 152 | | query_builder.push(" SET "); [INFO] [stdout] ... | [INFO] [stdout] 160 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 149 ~ if let Some(value) = field_value.downcast_ref::>() [INFO] [stdout] 150 ~ && let Some(v) = value { [INFO] [stdout] 151 | if i == 0 { [INFO] [stdout] ... [INFO] [stdout] 158 | i += 1; [INFO] [stdout] 159 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/app.rs:89:56 [INFO] [stdout] | [INFO] [stdout] 89 | pub async fn find_by_user_id(db_pool: &DbPool, id: &String) -> Result, String> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 89 - pub async fn find_by_user_id(db_pool: &DbPool, id: &String) -> Result, String> { [INFO] [stdout] 89 + pub async fn find_by_user_id(db_pool: &DbPool, id: &str) -> Result, String> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/app.rs:121:53 [INFO] [stdout] | [INFO] [stdout] 121 | pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 121 - pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 121 + pub async fn delete_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/app.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | id: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 140 - id: &String, [INFO] [stdout] 140 + id: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> crates/kc-core/src/models/app.rs:150:21 [INFO] [stdout] | [INFO] [stdout] 150 | / if let Some(v) = value { [INFO] [stdout] 151 | | if i == 0 { [INFO] [stdout] 152 | | query_builder.push(" SET "); [INFO] [stdout] 153 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 158 | | i += 1; [INFO] [stdout] 159 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> crates/kc-core/src/models/app.rs:149:29 [INFO] [stdout] | [INFO] [stdout] 149 | if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 150 | if let Some(v) = value { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/app.rs:149:17 [INFO] [stdout] | [INFO] [stdout] 149 | / if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] 150 | | if let Some(v) = value { [INFO] [stdout] 151 | | if i == 0 { [INFO] [stdout] 152 | | query_builder.push(" SET "); [INFO] [stdout] ... | [INFO] [stdout] 160 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 149 ~ if let Some(value) = field_value.downcast_ref::>() [INFO] [stdout] 150 ~ && let Some(v) = value { [INFO] [stdout] 151 | if i == 0 { [INFO] [stdout] ... [INFO] [stdout] 158 | i += 1; [INFO] [stdout] 159 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:78:51 [INFO] [stdout] | [INFO] [stdout] 78 | pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 - pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 78 + pub async fn find_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:110:53 [INFO] [stdout] | [INFO] [stdout] 110 | pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 110 - pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 110 + pub async fn delete_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | id: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 131 - id: &String, [INFO] [stdout] 131 + id: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:78:51 [INFO] [stdout] | [INFO] [stdout] 78 | pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 - pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 78 + pub async fn find_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:141:21 [INFO] [stdout] | [INFO] [stdout] 141 | / if let Some(v) = value { [INFO] [stdout] 142 | | if i == 0 { [INFO] [stdout] 143 | | query_builder.push(" SET "); [INFO] [stdout] 144 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 149 | | i += 1; [INFO] [stdout] 150 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:140:29 [INFO] [stdout] | [INFO] [stdout] 140 | if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 141 | if let Some(v) = value { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | / if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] 141 | | if let Some(v) = value { [INFO] [stdout] 142 | | if i == 0 { [INFO] [stdout] 143 | | query_builder.push(" SET "); [INFO] [stdout] ... | [INFO] [stdout] 151 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 140 ~ if let Some(value) = field_value.downcast_ref::>() [INFO] [stdout] 141 ~ && let Some(v) = value { [INFO] [stdout] 142 | if i == 0 { [INFO] [stdout] ... [INFO] [stdout] 149 | i += 1; [INFO] [stdout] 150 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:154:21 [INFO] [stdout] | [INFO] [stdout] 154 | / if let Some(v) = value { [INFO] [stdout] 155 | | if i == 0 { [INFO] [stdout] 156 | | query_builder.push(" SET "); [INFO] [stdout] 157 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 162 | | i += 1; [INFO] [stdout] 163 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:153:29 [INFO] [stdout] | [INFO] [stdout] 153 | if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 154 | if let Some(v) = value { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:153:17 [INFO] [stdout] | [INFO] [stdout] 153 | / if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] 154 | | if let Some(v) = value { [INFO] [stdout] 155 | | if i == 0 { [INFO] [stdout] 156 | | query_builder.push(" SET "); [INFO] [stdout] ... | [INFO] [stdout] 164 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 153 ~ if let Some(value) = field_value.downcast_ref::>() [INFO] [stdout] 154 ~ && let Some(v) = value { [INFO] [stdout] 155 | if i == 0 { [INFO] [stdout] ... [INFO] [stdout] 162 | i += 1; [INFO] [stdout] 163 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:110:53 [INFO] [stdout] | [INFO] [stdout] 110 | pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 110 - pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 110 + pub async fn delete_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | id: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 131 - id: &String, [INFO] [stdout] 131 + id: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:141:21 [INFO] [stdout] | [INFO] [stdout] 141 | / if let Some(v) = value { [INFO] [stdout] 142 | | if i == 0 { [INFO] [stdout] 143 | | query_builder.push(" SET "); [INFO] [stdout] 144 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 149 | | i += 1; [INFO] [stdout] 150 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:140:29 [INFO] [stdout] | [INFO] [stdout] 140 | if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 141 | if let Some(v) = value { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | / if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] 141 | | if let Some(v) = value { [INFO] [stdout] 142 | | if i == 0 { [INFO] [stdout] 143 | | query_builder.push(" SET "); [INFO] [stdout] ... | [INFO] [stdout] 151 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 140 ~ if let Some(value) = field_value.downcast_ref::>() [INFO] [stdout] 141 ~ && let Some(v) = value { [INFO] [stdout] 142 | if i == 0 { [INFO] [stdout] ... [INFO] [stdout] 149 | i += 1; [INFO] [stdout] 150 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:154:21 [INFO] [stdout] | [INFO] [stdout] 154 | / if let Some(v) = value { [INFO] [stdout] 155 | | if i == 0 { [INFO] [stdout] 156 | | query_builder.push(" SET "); [INFO] [stdout] 157 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 162 | | i += 1; [INFO] [stdout] 163 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:153:29 [INFO] [stdout] | [INFO] [stdout] 153 | if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 154 | if let Some(v) = value { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/deployment.rs:153:17 [INFO] [stdout] | [INFO] [stdout] 153 | / if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] 154 | | if let Some(v) = value { [INFO] [stdout] 155 | | if i == 0 { [INFO] [stdout] 156 | | query_builder.push(" SET "); [INFO] [stdout] ... | [INFO] [stdout] 164 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 153 ~ if let Some(value) = field_value.downcast_ref::>() [INFO] [stdout] 154 ~ && let Some(v) = value { [INFO] [stdout] 155 | if i == 0 { [INFO] [stdout] ... [INFO] [stdout] 162 | i += 1; [INFO] [stdout] 163 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:72:27 [INFO] [stdout] | [INFO] [stdout] 72 | Err(e) => return Err(format!("Invalid node_id UUID format: {}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - Err(e) => return Err(format!("Invalid node_id UUID format: {}", e)), [INFO] [stdout] 72 + Err(e) => Err(format!("Invalid node_id UUID format: {}", e)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 74 | Err(e) => return Err(format!("Invalid deployment_id UUID format: {}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - Err(e) => return Err(format!("Invalid deployment_id UUID format: {}", e)), [INFO] [stdout] 74 + Err(e) => Err(format!("Invalid deployment_id UUID format: {}", e)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:78:51 [INFO] [stdout] | [INFO] [stdout] 78 | pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 - pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 78 + pub async fn find_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:112:53 [INFO] [stdout] | [INFO] [stdout] 112 | pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 112 - pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 112 + pub async fn delete_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | id: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 133 - id: &String, [INFO] [stdout] 133 + id: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:72:27 [INFO] [stdout] | [INFO] [stdout] 72 | Err(e) => return Err(format!("Invalid node_id UUID format: {}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - Err(e) => return Err(format!("Invalid node_id UUID format: {}", e)), [INFO] [stdout] 72 + Err(e) => Err(format!("Invalid node_id UUID format: {}", e)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 74 | Err(e) => return Err(format!("Invalid deployment_id UUID format: {}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - Err(e) => return Err(format!("Invalid deployment_id UUID format: {}", e)), [INFO] [stdout] 74 + Err(e) => Err(format!("Invalid deployment_id UUID format: {}", e)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:78:51 [INFO] [stdout] | [INFO] [stdout] 78 | pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 - pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 78 + pub async fn find_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:143:21 [INFO] [stdout] | [INFO] [stdout] 143 | / if let Some(v) = value { [INFO] [stdout] 144 | | if i == 0 { [INFO] [stdout] 145 | | query_builder.push(" SET "); [INFO] [stdout] 146 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 151 | | i += 1; [INFO] [stdout] 152 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:142:29 [INFO] [stdout] | [INFO] [stdout] 142 | if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 143 | if let Some(v) = value { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:142:17 [INFO] [stdout] | [INFO] [stdout] 142 | / if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] 143 | | if let Some(v) = value { [INFO] [stdout] 144 | | if i == 0 { [INFO] [stdout] 145 | | query_builder.push(" SET "); [INFO] [stdout] ... | [INFO] [stdout] 153 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 142 ~ if let Some(value) = field_value.downcast_ref::>() [INFO] [stdout] 143 ~ && let Some(v) = value { [INFO] [stdout] 144 | if i == 0 { [INFO] [stdout] ... [INFO] [stdout] 151 | i += 1; [INFO] [stdout] 152 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:155:21 [INFO] [stdout] | [INFO] [stdout] 155 | / if let Some(v) = value { [INFO] [stdout] 156 | | if i == 0 { [INFO] [stdout] 157 | | query_builder.push(" SET "); [INFO] [stdout] 158 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 163 | | i += 1; [INFO] [stdout] 164 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:154:29 [INFO] [stdout] | [INFO] [stdout] 154 | if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 155 | if let Some(v) = value { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:154:17 [INFO] [stdout] | [INFO] [stdout] 154 | / if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] 155 | | if let Some(v) = value { [INFO] [stdout] 156 | | if i == 0 { [INFO] [stdout] 157 | | query_builder.push(" SET "); [INFO] [stdout] ... | [INFO] [stdout] 165 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 154 ~ if let Some(value) = field_value.downcast_ref::>() [INFO] [stdout] 155 ~ && let Some(v) = value { [INFO] [stdout] 156 | if i == 0 { [INFO] [stdout] ... [INFO] [stdout] 163 | i += 1; [INFO] [stdout] 164 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:112:53 [INFO] [stdout] | [INFO] [stdout] 112 | pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 112 - pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 112 + pub async fn delete_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | id: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 133 - id: &String, [INFO] [stdout] 133 + id: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:143:21 [INFO] [stdout] | [INFO] [stdout] 143 | / if let Some(v) = value { [INFO] [stdout] 144 | | if i == 0 { [INFO] [stdout] 145 | | query_builder.push(" SET "); [INFO] [stdout] 146 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 151 | | i += 1; [INFO] [stdout] 152 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:142:29 [INFO] [stdout] | [INFO] [stdout] 142 | if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 143 | if let Some(v) = value { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:142:17 [INFO] [stdout] | [INFO] [stdout] 142 | / if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] 143 | | if let Some(v) = value { [INFO] [stdout] 144 | | if i == 0 { [INFO] [stdout] 145 | | query_builder.push(" SET "); [INFO] [stdout] ... | [INFO] [stdout] 153 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 142 ~ if let Some(value) = field_value.downcast_ref::>() [INFO] [stdout] 143 ~ && let Some(v) = value { [INFO] [stdout] 144 | if i == 0 { [INFO] [stdout] ... [INFO] [stdout] 151 | i += 1; [INFO] [stdout] 152 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:155:21 [INFO] [stdout] | [INFO] [stdout] 155 | / if let Some(v) = value { [INFO] [stdout] 156 | | if i == 0 { [INFO] [stdout] 157 | | query_builder.push(" SET "); [INFO] [stdout] 158 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 163 | | i += 1; [INFO] [stdout] 164 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:154:29 [INFO] [stdout] | [INFO] [stdout] 154 | if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 155 | if let Some(v) = value { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/deployment_node.rs:154:17 [INFO] [stdout] | [INFO] [stdout] 154 | / if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] 155 | | if let Some(v) = value { [INFO] [stdout] 156 | | if i == 0 { [INFO] [stdout] 157 | | query_builder.push(" SET "); [INFO] [stdout] ... | [INFO] [stdout] 165 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 154 ~ if let Some(value) = field_value.downcast_ref::>() [INFO] [stdout] 155 ~ && let Some(v) = value { [INFO] [stdout] 156 | if i == 0 { [INFO] [stdout] ... [INFO] [stdout] 163 | i += 1; [INFO] [stdout] 164 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/node.rs:77:51 [INFO] [stdout] | [INFO] [stdout] 77 | pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 77 - pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 77 + pub async fn find_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/node.rs:93:56 [INFO] [stdout] | [INFO] [stdout] 93 | pub async fn find_by_user_id(db_pool: &DbPool, id: &String) -> Result, String> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 93 - pub async fn find_by_user_id(db_pool: &DbPool, id: &String) -> Result, String> { [INFO] [stdout] 93 + pub async fn find_by_user_id(db_pool: &DbPool, id: &str) -> Result, String> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/node.rs:111:13 [INFO] [stdout] | [INFO] [stdout] 111 | id: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 111 - id: &String, [INFO] [stdout] 111 + id: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> crates/kc-core/src/models/node.rs:121:25 [INFO] [stdout] | [INFO] [stdout] 121 | / if let Some(v) = value { [INFO] [stdout] 122 | | if i == 0 { [INFO] [stdout] 123 | | query_builder.push(" SET "); [INFO] [stdout] 124 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 129 | | i += 1; [INFO] [stdout] 130 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> crates/kc-core/src/models/node.rs:120:33 [INFO] [stdout] | [INFO] [stdout] 120 | if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 121 | if let Some(v) = value { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/node.rs:120:21 [INFO] [stdout] | [INFO] [stdout] 120 | / if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] 121 | | if let Some(v) = value { [INFO] [stdout] 122 | | if i == 0 { [INFO] [stdout] 123 | | query_builder.push(" SET "); [INFO] [stdout] ... | [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 120 ~ if let Some(value) = field_value.downcast_ref::>() [INFO] [stdout] 121 ~ && let Some(v) = value { [INFO] [stdout] 122 | if i == 0 { [INFO] [stdout] ... [INFO] [stdout] 129 | i += 1; [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/node.rs:148:53 [INFO] [stdout] | [INFO] [stdout] 148 | pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 148 - pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 148 + pub async fn delete_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/node.rs:77:51 [INFO] [stdout] | [INFO] [stdout] 77 | pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 77 - pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 77 + pub async fn find_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/node.rs:93:56 [INFO] [stdout] | [INFO] [stdout] 93 | pub async fn find_by_user_id(db_pool: &DbPool, id: &String) -> Result, String> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 93 - pub async fn find_by_user_id(db_pool: &DbPool, id: &String) -> Result, String> { [INFO] [stdout] 93 + pub async fn find_by_user_id(db_pool: &DbPool, id: &str) -> Result, String> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/node.rs:111:13 [INFO] [stdout] | [INFO] [stdout] 111 | id: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 111 - id: &String, [INFO] [stdout] 111 + id: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> crates/kc-core/src/models/node.rs:121:25 [INFO] [stdout] | [INFO] [stdout] 121 | / if let Some(v) = value { [INFO] [stdout] 122 | | if i == 0 { [INFO] [stdout] 123 | | query_builder.push(" SET "); [INFO] [stdout] 124 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 129 | | i += 1; [INFO] [stdout] 130 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> crates/kc-core/src/models/node.rs:120:33 [INFO] [stdout] | [INFO] [stdout] 120 | if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 121 | if let Some(v) = value { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/node.rs:120:21 [INFO] [stdout] | [INFO] [stdout] 120 | / if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] 121 | | if let Some(v) = value { [INFO] [stdout] 122 | | if i == 0 { [INFO] [stdout] 123 | | query_builder.push(" SET "); [INFO] [stdout] ... | [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 120 ~ if let Some(value) = field_value.downcast_ref::>() [INFO] [stdout] 121 ~ && let Some(v) = value { [INFO] [stdout] 122 | if i == 0 { [INFO] [stdout] ... [INFO] [stdout] 129 | i += 1; [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/node.rs:148:53 [INFO] [stdout] | [INFO] [stdout] 148 | pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 148 - pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 148 + pub async fn delete_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/kc-core/src/models/query.rs:118:27 [INFO] [stdout] | [INFO] [stdout] 118 | Err(e) => return Err(format!("Invalid User UUID format: {}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - Err(e) => return Err(format!("Invalid User UUID format: {}", e)), [INFO] [stdout] 118 + Err(e) => Err(format!("Invalid User UUID format: {}", e)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> crates/kc-core/src/models/query.rs:92:28 [INFO] [stdout] | [INFO] [stdout] 92 | if let Err(_) = [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 92 ~ if sqlx::query("SELECT * FROM team_users WHERE team_id = $1 AND user_id = $2") [INFO] [stdout] 93 + .bind(team_uuid) [INFO] [stdout] 94 + .bind(user_uuid) [INFO] [stdout] 95 + .fetch_one(&state.db_pool) [INFO] [stdout] 96 + .await.is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/query.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 92 | / if let Err(_) = [INFO] [stdout] 93 | | sqlx::query("SELECT * FROM team_users WHERE team_id = $1 AND user_id = $2") [INFO] [stdout] 94 | | .bind(team_uuid) [INFO] [stdout] 95 | | .bind(user_uuid) [INFO] [stdout] ... | [INFO] [stdout] 104 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 97 ~ .await [INFO] [stdout] 98 ~ && claims.role != "admin" { [INFO] [stdout] 99 | return Err( [INFO] [stdout] 100 | "You do not have permission to perform this action.".to_string() [INFO] [stdout] 101 | ); [INFO] [stdout] 102 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/kc-core/src/models/query.rs:118:27 [INFO] [stdout] | [INFO] [stdout] 118 | Err(e) => return Err(format!("Invalid User UUID format: {}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - Err(e) => return Err(format!("Invalid User UUID format: {}", e)), [INFO] [stdout] 118 + Err(e) => Err(format!("Invalid User UUID format: {}", e)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> crates/kc-core/src/models/query.rs:92:28 [INFO] [stdout] | [INFO] [stdout] 92 | if let Err(_) = [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 92 ~ if sqlx::query("SELECT * FROM team_users WHERE team_id = $1 AND user_id = $2") [INFO] [stdout] 93 + .bind(team_uuid) [INFO] [stdout] 94 + .bind(user_uuid) [INFO] [stdout] 95 + .fetch_one(&state.db_pool) [INFO] [stdout] 96 + .await.is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/query.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 92 | / if let Err(_) = [INFO] [stdout] 93 | | sqlx::query("SELECT * FROM team_users WHERE team_id = $1 AND user_id = $2") [INFO] [stdout] 94 | | .bind(team_uuid) [INFO] [stdout] 95 | | .bind(user_uuid) [INFO] [stdout] ... | [INFO] [stdout] 104 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 97 ~ .await [INFO] [stdout] 98 ~ && claims.role != "admin" { [INFO] [stdout] 99 | return Err( [INFO] [stdout] 100 | "You do not have permission to perform this action.".to_string() [INFO] [stdout] 101 | ); [INFO] [stdout] 102 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/team.rs:48:51 [INFO] [stdout] | [INFO] [stdout] 48 | pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 48 - pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 48 + pub async fn find_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/team.rs:64:56 [INFO] [stdout] | [INFO] [stdout] 64 | pub async fn find_by_user_id(db_pool: &DbPool, id: &String) -> Result, String> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 64 - pub async fn find_by_user_id(db_pool: &DbPool, id: &String) -> Result, String> { [INFO] [stdout] 64 + pub async fn find_by_user_id(db_pool: &DbPool, id: &str) -> Result, String> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/team.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | id: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 82 - id: &String, [INFO] [stdout] 82 + id: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> crates/kc-core/src/models/team.rs:92:25 [INFO] [stdout] | [INFO] [stdout] 92 | / if let Some(v) = value { [INFO] [stdout] 93 | | if i == 0 { [INFO] [stdout] 94 | | query_builder.push(" SET "); [INFO] [stdout] 95 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 100 | | i += 1; [INFO] [stdout] 101 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> crates/kc-core/src/models/team.rs:91:33 [INFO] [stdout] | [INFO] [stdout] 91 | if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 92 | if let Some(v) = value { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/team.rs:91:21 [INFO] [stdout] | [INFO] [stdout] 91 | / if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] 92 | | if let Some(v) = value { [INFO] [stdout] 93 | | if i == 0 { [INFO] [stdout] 94 | | query_builder.push(" SET "); [INFO] [stdout] ... | [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 91 ~ if let Some(value) = field_value.downcast_ref::>() [INFO] [stdout] 92 ~ && let Some(v) = value { [INFO] [stdout] 93 | if i == 0 { [INFO] [stdout] ... [INFO] [stdout] 100 | i += 1; [INFO] [stdout] 101 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/team.rs:48:51 [INFO] [stdout] | [INFO] [stdout] 48 | pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 48 - pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 48 + pub async fn find_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/team.rs:119:53 [INFO] [stdout] | [INFO] [stdout] 119 | pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 119 - pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 119 + pub async fn delete_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/team.rs:64:56 [INFO] [stdout] | [INFO] [stdout] 64 | pub async fn find_by_user_id(db_pool: &DbPool, id: &String) -> Result, String> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 64 - pub async fn find_by_user_id(db_pool: &DbPool, id: &String) -> Result, String> { [INFO] [stdout] 64 + pub async fn find_by_user_id(db_pool: &DbPool, id: &str) -> Result, String> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/team.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | id: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 82 - id: &String, [INFO] [stdout] 82 + id: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> crates/kc-core/src/models/team.rs:92:25 [INFO] [stdout] | [INFO] [stdout] 92 | / if let Some(v) = value { [INFO] [stdout] 93 | | if i == 0 { [INFO] [stdout] 94 | | query_builder.push(" SET "); [INFO] [stdout] 95 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 100 | | i += 1; [INFO] [stdout] 101 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> crates/kc-core/src/models/team.rs:91:33 [INFO] [stdout] | [INFO] [stdout] 91 | if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 92 | if let Some(v) = value { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/team.rs:91:21 [INFO] [stdout] | [INFO] [stdout] 91 | / if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] 92 | | if let Some(v) = value { [INFO] [stdout] 93 | | if i == 0 { [INFO] [stdout] 94 | | query_builder.push(" SET "); [INFO] [stdout] ... | [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 91 ~ if let Some(value) = field_value.downcast_ref::>() [INFO] [stdout] 92 ~ && let Some(v) = value { [INFO] [stdout] 93 | if i == 0 { [INFO] [stdout] ... [INFO] [stdout] 100 | i += 1; [INFO] [stdout] 101 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/team.rs:119:53 [INFO] [stdout] | [INFO] [stdout] 119 | pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 119 - pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 119 + pub async fn delete_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/user.rs:66:51 [INFO] [stdout] | [INFO] [stdout] 66 | pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 - pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 66 + pub async fn find_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> crates/kc-core/src/models/user.rs:124:25 [INFO] [stdout] | [INFO] [stdout] 124 | / if let Some(v) = value { [INFO] [stdout] 125 | | if i == 0 { [INFO] [stdout] 126 | | query_builder.push(" SET "); [INFO] [stdout] 127 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 132 | | i += 1; [INFO] [stdout] 133 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> crates/kc-core/src/models/user.rs:123:33 [INFO] [stdout] | [INFO] [stdout] 123 | if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 124 | if let Some(v) = value { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/user.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 123 | / if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] 124 | | if let Some(v) = value { [INFO] [stdout] 125 | | if i == 0 { [INFO] [stdout] 126 | | query_builder.push(" SET "); [INFO] [stdout] ... | [INFO] [stdout] 134 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 123 ~ if let Some(value) = field_value.downcast_ref::>() [INFO] [stdout] 124 ~ && let Some(v) = value { [INFO] [stdout] 125 | if i == 0 { [INFO] [stdout] ... [INFO] [stdout] 132 | i += 1; [INFO] [stdout] 133 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/user.rs:151:53 [INFO] [stdout] | [INFO] [stdout] 151 | pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 151 - pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 151 + pub async fn delete_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/user.rs:66:51 [INFO] [stdout] | [INFO] [stdout] 66 | pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 - pub async fn find_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 66 + pub async fn find_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/kc-core/src/models/user.rs:184:25 [INFO] [stdout] | [INFO] [stdout] 184 | return Err("Error in password verification".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 184 - return Err("Error in password verification".to_string()); [INFO] [stdout] 184 + Err("Error in password verification".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> crates/kc-core/src/models/user.rs:124:25 [INFO] [stdout] | [INFO] [stdout] 124 | / if let Some(v) = value { [INFO] [stdout] 125 | | if i == 0 { [INFO] [stdout] 126 | | query_builder.push(" SET "); [INFO] [stdout] 127 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 132 | | i += 1; [INFO] [stdout] 133 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> crates/kc-core/src/models/user.rs:123:33 [INFO] [stdout] | [INFO] [stdout] 123 | if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 124 | if let Some(v) = value { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kc-core/src/models/user.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 123 | / if let Some(value) = field_value.downcast_ref::>() { [INFO] [stdout] 124 | | if let Some(v) = value { [INFO] [stdout] 125 | | if i == 0 { [INFO] [stdout] 126 | | query_builder.push(" SET "); [INFO] [stdout] ... | [INFO] [stdout] 134 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 123 ~ if let Some(value) = field_value.downcast_ref::>() [INFO] [stdout] 124 ~ && let Some(v) = value { [INFO] [stdout] 125 | if i == 0 { [INFO] [stdout] ... [INFO] [stdout] 132 | i += 1; [INFO] [stdout] 133 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> crates/kc-core/src/models/user.rs:151:53 [INFO] [stdout] | [INFO] [stdout] 151 | pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 151 - pub async fn delete_by_id(db_pool: &DbPool, id: &String) -> Result { [INFO] [stdout] 151 + pub async fn delete_by_id(db_pool: &DbPool, id: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/kc-core/src/models/user.rs:184:25 [INFO] [stdout] | [INFO] [stdout] 184 | return Err("Error in password verification".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 184 - return Err("Error in password verification".to_string()); [INFO] [stdout] 184 + Err("Error in password verification".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking api-app v0.1.0 (/opt/rustwide/workdir/crates/api-app) [INFO] [stderr] Checking api-graphql v0.1.0 (/opt/rustwide/workdir/crates/api-graphql) [INFO] [stderr] Checking api-user v0.1.0 (/opt/rustwide/workdir/crates/api-user) [INFO] [stderr] Checking api-node v0.1.0 (/opt/rustwide/workdir/crates/api-node) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> crates/api-app/src/routes/deploy.rs:385:17 [INFO] [stdout] | [INFO] [stdout] 385 | team_id: team_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `team_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> crates/api-app/src/routes/deploy.rs:386:17 [INFO] [stdout] | [INFO] [stdout] 386 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> crates/api-app/src/routes/deploy.rs:385:17 [INFO] [stdout] | [INFO] [stdout] 385 | team_id: team_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `team_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> crates/api-app/src/routes/deploy.rs:386:17 [INFO] [stdout] | [INFO] [stdout] 386 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/api-node/src/routes/node.rs:71:21 [INFO] [stdout] | [INFO] [stdout] 71 | / return ( [INFO] [stdout] 72 | | StatusCode::OK, [INFO] [stdout] 73 | | Json(DataJsonResponse { [INFO] [stdout] 74 | | data: Some(node), [INFO] [stdout] 75 | | error: None, [INFO] [stdout] 76 | | }), [INFO] [stdout] 77 | | ); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 ~ ( [INFO] [stdout] 72 + StatusCode::OK, [INFO] [stdout] 73 + Json(DataJsonResponse { [INFO] [stdout] 74 + data: Some(node), [INFO] [stdout] 75 + error: None, [INFO] [stdout] 76 + }), [INFO] [stdout] 77 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/api-node/src/routes/node.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | / return ( [INFO] [stdout] 91 | | StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] 92 | | Json(DataJsonResponse { [INFO] [stdout] 93 | | error: Some("Error creating node".to_string()), [INFO] [stdout] 94 | | data: None, [INFO] [stdout] 95 | | }), [INFO] [stdout] 96 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 ~ ( [INFO] [stdout] 91 + StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] 92 + Json(DataJsonResponse { [INFO] [stdout] 93 + error: Some("Error creating node".to_string()), [INFO] [stdout] 94 + data: None, [INFO] [stdout] 95 + }), [INFO] [stdout] 96 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/api-node/src/routes/node.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | / return ( [INFO] [stdout] 116 | | StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] 117 | | Json(DataJsonResponse { [INFO] [stdout] 118 | | error: Some("Error fetching nodes from DB".to_string()), [INFO] [stdout] 119 | | data: None, [INFO] [stdout] 120 | | }), [INFO] [stdout] 121 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 ~ ( [INFO] [stdout] 116 + StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] 117 + Json(DataJsonResponse { [INFO] [stdout] 118 + error: Some("Error fetching nodes from DB".to_string()), [INFO] [stdout] 119 + data: None, [INFO] [stdout] 120 + }), [INFO] [stdout] 121 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/api-node/src/routes/node.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | / return ( [INFO] [stdout] 141 | | StatusCode::NOT_FOUND, [INFO] [stdout] 142 | | Json(DataJsonResponse { [INFO] [stdout] 143 | | error: Some("Nodes not found".to_string()), [INFO] [stdout] 144 | | data: None, [INFO] [stdout] 145 | | }), [INFO] [stdout] 146 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 ~ ( [INFO] [stdout] 141 + StatusCode::NOT_FOUND, [INFO] [stdout] 142 + Json(DataJsonResponse { [INFO] [stdout] 143 + error: Some("Nodes not found".to_string()), [INFO] [stdout] 144 + data: None, [INFO] [stdout] 145 + }), [INFO] [stdout] 146 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> crates/api-node/src/routes/node.rs:198:40 [INFO] [stdout] | [INFO] [stdout] 198 | Some(info_json) => match serde_json::from_str::(&info_json) { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 199 | | Ok(info) => Some(info), [INFO] [stdout] 200 | | Err(_) => None, [INFO] [stdout] 201 | | }, [INFO] [stdout] | |_____________________^ help: replace with: `serde_json::from_str::(&info_json).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/api-user/src/routes/team.rs:131:16 [INFO] [stdout] | [INFO] [stdout] 131 | if !(authenticated_claims.role == "admin") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(authenticated_claims.role != "admin")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/api-user/src/routes/user.rs:41:25 [INFO] [stdout] | [INFO] [stdout] 41 | / return ( [INFO] [stdout] 42 | | StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] 43 | | Json(DataJsonResponse { [INFO] [stdout] 44 | | error: Some(format!("Failed to associate user with team: {}", e)), [INFO] [stdout] 45 | | data: None, [INFO] [stdout] 46 | | }), [INFO] [stdout] 47 | | ); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 ~ ( [INFO] [stdout] 42 + StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] 43 + Json(DataJsonResponse { [INFO] [stdout] 44 + error: Some(format!("Failed to associate user with team: {}", e)), [INFO] [stdout] 45 + data: None, [INFO] [stdout] 46 + }), [INFO] [stdout] 47 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/api-user/src/routes/user.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 51 | / return ( [INFO] [stdout] 52 | | StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] 53 | | Json(DataJsonResponse { [INFO] [stdout] 54 | | error: Some(format!("Failed to create user's team: {}", e)), [INFO] [stdout] 55 | | data: None, [INFO] [stdout] 56 | | }), [INFO] [stdout] 57 | | ); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 ~ ( [INFO] [stdout] 52 + StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] 53 + Json(DataJsonResponse { [INFO] [stdout] 54 + error: Some(format!("Failed to create user's team: {}", e)), [INFO] [stdout] 55 + data: None, [INFO] [stdout] 56 + }), [INFO] [stdout] 57 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> crates/api-user/src/routes/user.rs:259:37 [INFO] [stdout] | [INFO] [stdout] 259 | error: Some(format!("Failed to generate token")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Failed to generate token".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/api-node/src/routes/node.rs:71:21 [INFO] [stdout] | [INFO] [stdout] 71 | / return ( [INFO] [stdout] 72 | | StatusCode::OK, [INFO] [stdout] 73 | | Json(DataJsonResponse { [INFO] [stdout] 74 | | data: Some(node), [INFO] [stdout] 75 | | error: None, [INFO] [stdout] 76 | | }), [INFO] [stdout] 77 | | ); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 ~ ( [INFO] [stdout] 72 + StatusCode::OK, [INFO] [stdout] 73 + Json(DataJsonResponse { [INFO] [stdout] 74 + data: Some(node), [INFO] [stdout] 75 + error: None, [INFO] [stdout] 76 + }), [INFO] [stdout] 77 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/api-node/src/routes/node.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | / return ( [INFO] [stdout] 91 | | StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] 92 | | Json(DataJsonResponse { [INFO] [stdout] 93 | | error: Some("Error creating node".to_string()), [INFO] [stdout] 94 | | data: None, [INFO] [stdout] 95 | | }), [INFO] [stdout] 96 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 ~ ( [INFO] [stdout] 91 + StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] 92 + Json(DataJsonResponse { [INFO] [stdout] 93 + error: Some("Error creating node".to_string()), [INFO] [stdout] 94 + data: None, [INFO] [stdout] 95 + }), [INFO] [stdout] 96 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/api-node/src/routes/node.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | / return ( [INFO] [stdout] 116 | | StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] 117 | | Json(DataJsonResponse { [INFO] [stdout] 118 | | error: Some("Error fetching nodes from DB".to_string()), [INFO] [stdout] 119 | | data: None, [INFO] [stdout] 120 | | }), [INFO] [stdout] 121 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 ~ ( [INFO] [stdout] 116 + StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] 117 + Json(DataJsonResponse { [INFO] [stdout] 118 + error: Some("Error fetching nodes from DB".to_string()), [INFO] [stdout] 119 + data: None, [INFO] [stdout] 120 + }), [INFO] [stdout] 121 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/api-node/src/routes/node.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | / return ( [INFO] [stdout] 141 | | StatusCode::NOT_FOUND, [INFO] [stdout] 142 | | Json(DataJsonResponse { [INFO] [stdout] 143 | | error: Some("Nodes not found".to_string()), [INFO] [stdout] 144 | | data: None, [INFO] [stdout] 145 | | }), [INFO] [stdout] 146 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 ~ ( [INFO] [stdout] 141 + StatusCode::NOT_FOUND, [INFO] [stdout] 142 + Json(DataJsonResponse { [INFO] [stdout] 143 + error: Some("Nodes not found".to_string()), [INFO] [stdout] 144 + data: None, [INFO] [stdout] 145 + }), [INFO] [stdout] 146 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> crates/api-node/src/routes/node.rs:198:40 [INFO] [stdout] | [INFO] [stdout] 198 | Some(info_json) => match serde_json::from_str::(&info_json) { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 199 | | Ok(info) => Some(info), [INFO] [stdout] 200 | | Err(_) => None, [INFO] [stdout] 201 | | }, [INFO] [stdout] | |_____________________^ help: replace with: `serde_json::from_str::(&info_json).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/api-user/src/routes/team.rs:131:16 [INFO] [stdout] | [INFO] [stdout] 131 | if !(authenticated_claims.role == "admin") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(authenticated_claims.role != "admin")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/api-user/src/routes/user.rs:41:25 [INFO] [stdout] | [INFO] [stdout] 41 | / return ( [INFO] [stdout] 42 | | StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] 43 | | Json(DataJsonResponse { [INFO] [stdout] 44 | | error: Some(format!("Failed to associate user with team: {}", e)), [INFO] [stdout] 45 | | data: None, [INFO] [stdout] 46 | | }), [INFO] [stdout] 47 | | ); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 ~ ( [INFO] [stdout] 42 + StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] 43 + Json(DataJsonResponse { [INFO] [stdout] 44 + error: Some(format!("Failed to associate user with team: {}", e)), [INFO] [stdout] 45 + data: None, [INFO] [stdout] 46 + }), [INFO] [stdout] 47 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/api-user/src/routes/user.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 51 | / return ( [INFO] [stdout] 52 | | StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] 53 | | Json(DataJsonResponse { [INFO] [stdout] 54 | | error: Some(format!("Failed to create user's team: {}", e)), [INFO] [stdout] 55 | | data: None, [INFO] [stdout] 56 | | }), [INFO] [stdout] 57 | | ); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 ~ ( [INFO] [stdout] 52 + StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] 53 + Json(DataJsonResponse { [INFO] [stdout] 54 + error: Some(format!("Failed to create user's team: {}", e)), [INFO] [stdout] 55 + data: None, [INFO] [stdout] 56 + }), [INFO] [stdout] 57 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> crates/api-user/src/routes/user.rs:259:37 [INFO] [stdout] | [INFO] [stdout] 259 | error: Some(format!("Failed to generate token")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Failed to generate token".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/api-app/src/routes/app.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | / return ( [INFO] [stdout] 21 | | StatusCode::NOT_FOUND, [INFO] [stdout] 22 | | Json(DataJsonResponse { [INFO] [stdout] 23 | | error: Some("Nodes not found".to_string()), [INFO] [stdout] 24 | | data: None, [INFO] [stdout] 25 | | }), [INFO] [stdout] 26 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 ~ ( [INFO] [stdout] 21 + StatusCode::NOT_FOUND, [INFO] [stdout] 22 + Json(DataJsonResponse { [INFO] [stdout] 23 + error: Some("Nodes not found".to_string()), [INFO] [stdout] 24 + data: None, [INFO] [stdout] 25 + }), [INFO] [stdout] 26 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/api-app/src/routes/app.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | / return ( [INFO] [stdout] 21 | | StatusCode::NOT_FOUND, [INFO] [stdout] 22 | | Json(DataJsonResponse { [INFO] [stdout] 23 | | error: Some("Nodes not found".to_string()), [INFO] [stdout] 24 | | data: None, [INFO] [stdout] 25 | | }), [INFO] [stdout] 26 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 ~ ( [INFO] [stdout] 21 + StatusCode::NOT_FOUND, [INFO] [stdout] 22 + Json(DataJsonResponse { [INFO] [stdout] 23 + error: Some("Nodes not found".to_string()), [INFO] [stdout] 24 + data: None, [INFO] [stdout] 25 + }), [INFO] [stdout] 26 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> crates/api-app/src/routes/deploy.rs:91:33 [INFO] [stdout] | [INFO] [stdout] 91 | error: Some(format!("{}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> crates/api-app/src/routes/deploy.rs:91:33 [INFO] [stdout] | [INFO] [stdout] 91 | error: Some(format!("{}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking web-server v0.1.0 (/opt/rustwide/workdir/crates/web-server) [INFO] [stderr] Checking gateway v0.1.0 (/opt/rustwide/workdir/gateway) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> gateway/src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | db_pool: db_pool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `db_pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> gateway/src/main.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | redis_client: redis_client, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `redis_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> gateway/src/main.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | graphql_schema: graphql_schema, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `graphql_schema` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> gateway/src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | db_pool: db_pool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `db_pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> gateway/src/main.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | redis_client: redis_client, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `redis_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> gateway/src/main.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | graphql_schema: graphql_schema, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `graphql_schema` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4m 12s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: num-bigint-dig v0.8.5 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "6fc8db2d239f6876f4e09cefef78471092e3fcc70854a441b0d0dfd6affe6cf2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6fc8db2d239f6876f4e09cefef78471092e3fcc70854a441b0d0dfd6affe6cf2", kill_on_drop: false }` [INFO] [stdout] 6fc8db2d239f6876f4e09cefef78471092e3fcc70854a441b0d0dfd6affe6cf2