[INFO] cloning repository https://github.com/KennyThrug/Pokemon_Randomizer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KennyThrug/Pokemon_Randomizer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKennyThrug%2FPokemon_Randomizer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKennyThrug%2FPokemon_Randomizer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 48cf2bdb543aa7b4d45b273d12a28f2433ff8045 [INFO] linting KennyThrug/Pokemon_Randomizer against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKennyThrug%2FPokemon_Randomizer" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/KennyThrug/Pokemon_Randomizer [INFO] finished tweaking git repo https://github.com/KennyThrug/Pokemon_Randomizer [INFO] tweaked toml for git repo https://github.com/KennyThrug/Pokemon_Randomizer written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/KennyThrug/Pokemon_Randomizer on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/KennyThrug/Pokemon_Randomizer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded num_enum v0.7.0 [INFO] [stderr] Downloaded num_enum_derive v0.7.0 [INFO] [stderr] Downloaded try-catch v0.2.2 [INFO] [stderr] Downloaded getrandom v0.2.10 [INFO] [stderr] Downloaded proc-macro2 v1.0.66 [INFO] [stderr] Downloaded toml_datetime v0.6.3 [INFO] [stderr] Downloaded neon-build v0.9.0 [INFO] [stderr] Downloaded cslice v0.2.0 [INFO] [stderr] Downloaded proc-macro-crate v1.3.1 [INFO] [stderr] Downloaded unicode-ident v1.0.11 [INFO] [stderr] Downloaded csv-core v0.1.10 [INFO] [stderr] Downloaded libloading v0.6.7 [INFO] [stderr] Downloaded serde_derive v1.0.188 [INFO] [stderr] Downloaded serde v1.0.188 [INFO] [stderr] Downloaded indexmap v2.0.0 [INFO] [stderr] Downloaded memchr v2.6.2 [INFO] [stderr] Downloaded json v0.12.4 [INFO] [stderr] Downloaded winnow v0.5.15 [INFO] [stderr] Downloaded hashbrown v0.14.0 [INFO] [stderr] Downloaded toml_edit v0.19.14 [INFO] [stderr] Downloaded syn v1.0.74 [INFO] [stderr] Downloaded syn v2.0.29 [INFO] [stderr] Downloaded smallvec v1.6.1 [INFO] [stderr] Downloaded once_cell v1.18.0 [INFO] [stderr] Downloaded neon-macros v0.9.0 [INFO] [stderr] Downloaded neon-runtime v0.9.0 [INFO] [stderr] Downloaded csv v1.2.2 [INFO] [stderr] Downloaded libc v0.2.147 [INFO] [stderr] Downloaded neon v0.9.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 726f70921ff24b3c9deb6a4fbd7d79b8a6eb98c21e5f069e90f3602f4229a809 [INFO] running `Command { std: "docker" "start" "-a" "726f70921ff24b3c9deb6a4fbd7d79b8a6eb98c21e5f069e90f3602f4229a809", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "726f70921ff24b3c9deb6a4fbd7d79b8a6eb98c21e5f069e90f3602f4229a809", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "726f70921ff24b3c9deb6a4fbd7d79b8a6eb98c21e5f069e90f3602f4229a809", kill_on_drop: false }` [INFO] [stdout] 726f70921ff24b3c9deb6a4fbd7d79b8a6eb98c21e5f069e90f3602f4229a809 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 901b31b6863340a38ededa2a6b110460dccc696780b88b363f3d66f41c07486b [INFO] running `Command { std: "docker" "start" "-a" "901b31b6863340a38ededa2a6b110460dccc696780b88b363f3d66f41c07486b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling neon-build v0.9.0 [INFO] [stderr] Compiling syn v1.0.74 [INFO] [stderr] Compiling hashbrown v0.14.0 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling winnow v0.5.15 [INFO] [stderr] Compiling toml_datetime v0.6.3 [INFO] [stderr] Compiling once_cell v1.18.0 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking memchr v2.6.2 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking libloading v0.6.7 [INFO] [stderr] Checking semver-parser v0.7.0 [INFO] [stderr] Checking cslice v0.2.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking neon-runtime v0.9.0 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Compiling neon v0.9.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling indexmap v2.0.0 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling toml_edit v0.19.14 [INFO] [stderr] Checking csv v1.2.2 [INFO] [stderr] Compiling neon-macros v0.9.0 [INFO] [stderr] Compiling try-catch v0.2.2 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling num_enum_derive v0.7.0 [INFO] [stderr] Checking num_enum v0.7.0 [INFO] [stderr] Checking neon-electron v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:430:15 [INFO] [stdout] | [INFO] [stdout] 430 | ...le (pokemon::get_pokemon_data(temp_mon.species,all_stats).type1 != pkmn_type && pokemon::get_pokemon_data(temp_mon.species,all_stats).type2 != pkmn_type){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 430 - while (pokemon::get_pokemon_data(temp_mon.species,all_stats).type1 != pkmn_type && pokemon::get_pokemon_data(temp_mon.species,all_stats).type2 != pkmn_type){ [INFO] [stdout] 430 + while pokemon::get_pokemon_data(temp_mon.species,all_stats).type1 != pkmn_type && pokemon::get_pokemon_data(temp_mon.species,all_stats).type2 != pkmn_type { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `JsonValue::Null` [INFO] [stdout] --> src/src/gen3/trainers.rs:3:18 [INFO] [stdout] | [INFO] [stdout] 3 | use json::{self, JsonValue::Null}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/src/gen3/trainers.rs:287:47 [INFO] [stdout] | [INFO] [stdout] 287 | let rand_val = settings::get_next_seed(0, (pokemon_data.len() as i32), settings); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 287 - let rand_val = settings::get_next_seed(0, (pokemon_data.len() as i32), settings); [INFO] [stdout] 287 + let rand_val = settings::get_next_seed(0, pokemon_data.len() as i32 , settings); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Location_type` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:23:10 [INFO] [stdout] | [INFO] [stdout] 23 | pub enum Location_type{ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `LocationType` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `ITEM_BALL` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | ITEM_BALL, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `ItemBall` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HIDDEN_ITEM` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | HIDDEN_ITEM, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `HiddenItem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `LEGENDARY_POKEMON` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | LEGENDARY_POKEMON, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `LegendaryPokemon` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `GYM_LEADER` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | GYM_LEADER, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `GymLeader` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Item_type` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:32:10 [INFO] [stdout] | [INFO] [stdout] 32 | pub enum Item_type{ [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `ItemType` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `NORMAL_ITEM` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | NORMAL_ITEM, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `NormalItem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `RAW_SCRIPT` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | RAW_SCRIPT //For use when you just want to use the "Item Name" as the full script, inserted into code raw [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `RawScript` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:73:15 [INFO] [stdout] | [INFO] [stdout] 73 | if(cur_item[i].to_string() == ""){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 73 - if(cur_item[i].to_string() == ""){ [INFO] [stdout] 73 + if cur_item[i].to_string() == "" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:293:10 [INFO] [stdout] | [INFO] [stdout] 293 | while(items.len() != 0){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 293 - while(items.len() != 0){ [INFO] [stdout] 293 + while items.len() != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:303:10 [INFO] [stdout] | [INFO] [stdout] 303 | while(items.len() != 0){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 303 - while(items.len() != 0){ [INFO] [stdout] 303 + while items.len() != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:322:7 [INFO] [stdout] | [INFO] [stdout] 322 | if(settings.randomize_key_items){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 322 - if(settings.randomize_key_items){ [INFO] [stdout] 322 + if settings.randomize_key_items { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:329:7 [INFO] [stdout] | [INFO] [stdout] 329 | if(settings.randomize_hms){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 329 - if(settings.randomize_hms){ [INFO] [stdout] 329 + if settings.randomize_hms { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:335:7 [INFO] [stdout] | [INFO] [stdout] 335 | if(settings.randomize_gym_badges){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 335 - if(settings.randomize_gym_badges){ [INFO] [stdout] 335 + if settings.randomize_gym_badges { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:353:7 [INFO] [stdout] | [INFO] [stdout] 353 | if(settings.add_revives){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 353 - if(settings.add_revives){ [INFO] [stdout] 353 + if settings.add_revives { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:358:7 [INFO] [stdout] | [INFO] [stdout] 358 | if(settings.allow_healing_items){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 358 - if(settings.allow_healing_items){ [INFO] [stdout] 358 + if settings.allow_healing_items { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::src::gen3::trainers` [INFO] [stdout] --> src/src/gen3/startup.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::src::gen3::trainers; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::src::gen3::starter_randomization` [INFO] [stdout] --> src/src/gen3/startup.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::src::gen3::starter_randomization; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Type::*` [INFO] [stdout] --> src/src/pokemon.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use Type::*; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `LegendStatus::*` [INFO] [stdout] --> src/src/pokemon.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use LegendStatus::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Reader` [INFO] [stdout] --> src/src/pokemon.rs:9:17 [INFO] [stdout] | [INFO] [stdout] 9 | use csv::{self, Reader}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `try_catch::catch` [INFO] [stdout] --> src/src/pokemon.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use try_catch::catch; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/src/pokemon.rs:1293:13 [INFO] [stdout] | [INFO] [stdout] 1293 | min_level: min_level, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_level` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:430:15 [INFO] [stdout] | [INFO] [stdout] 430 | ...le (pokemon::get_pokemon_data(temp_mon.species,all_stats).type1 != pkmn_type && pokemon::get_pokemon_data(temp_mon.species,all_stats).type2 != pkmn_type){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 430 - while (pokemon::get_pokemon_data(temp_mon.species,all_stats).type1 != pkmn_type && pokemon::get_pokemon_data(temp_mon.species,all_stats).type2 != pkmn_type){ [INFO] [stdout] 430 + while pokemon::get_pokemon_data(temp_mon.species,all_stats).type1 != pkmn_type && pokemon::get_pokemon_data(temp_mon.species,all_stats).type2 != pkmn_type { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `JsonValue::Null` [INFO] [stdout] --> src/src/gen3/trainers.rs:3:18 [INFO] [stdout] | [INFO] [stdout] 3 | use json::{self, JsonValue::Null}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/src/gen3/trainers.rs:287:47 [INFO] [stdout] | [INFO] [stdout] 287 | let rand_val = settings::get_next_seed(0, (pokemon_data.len() as i32), settings); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 287 - let rand_val = settings::get_next_seed(0, (pokemon_data.len() as i32), settings); [INFO] [stdout] 287 + let rand_val = settings::get_next_seed(0, pokemon_data.len() as i32 , settings); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Location_type` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:23:10 [INFO] [stdout] | [INFO] [stdout] 23 | pub enum Location_type{ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `LocationType` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `ITEM_BALL` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | ITEM_BALL, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `ItemBall` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HIDDEN_ITEM` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | HIDDEN_ITEM, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `HiddenItem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `LEGENDARY_POKEMON` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | LEGENDARY_POKEMON, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `LegendaryPokemon` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `GYM_LEADER` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | GYM_LEADER, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `GymLeader` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Item_type` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:32:10 [INFO] [stdout] | [INFO] [stdout] 32 | pub enum Item_type{ [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `ItemType` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `NORMAL_ITEM` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | NORMAL_ITEM, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `NormalItem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `RAW_SCRIPT` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | RAW_SCRIPT //For use when you just want to use the "Item Name" as the full script, inserted into code raw [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `RawScript` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:73:15 [INFO] [stdout] | [INFO] [stdout] 73 | if(cur_item[i].to_string() == ""){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 73 - if(cur_item[i].to_string() == ""){ [INFO] [stdout] 73 + if cur_item[i].to_string() == "" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:293:10 [INFO] [stdout] | [INFO] [stdout] 293 | while(items.len() != 0){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 293 - while(items.len() != 0){ [INFO] [stdout] 293 + while items.len() != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:303:10 [INFO] [stdout] | [INFO] [stdout] 303 | while(items.len() != 0){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 303 - while(items.len() != 0){ [INFO] [stdout] 303 + while items.len() != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:322:7 [INFO] [stdout] | [INFO] [stdout] 322 | if(settings.randomize_key_items){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 322 - if(settings.randomize_key_items){ [INFO] [stdout] 322 + if settings.randomize_key_items { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:329:7 [INFO] [stdout] | [INFO] [stdout] 329 | if(settings.randomize_hms){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 329 - if(settings.randomize_hms){ [INFO] [stdout] 329 + if settings.randomize_hms { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:335:7 [INFO] [stdout] | [INFO] [stdout] 335 | if(settings.randomize_gym_badges){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 335 - if(settings.randomize_gym_badges){ [INFO] [stdout] 335 + if settings.randomize_gym_badges { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:353:7 [INFO] [stdout] | [INFO] [stdout] 353 | if(settings.add_revives){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 353 - if(settings.add_revives){ [INFO] [stdout] 353 + if settings.add_revives { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:358:7 [INFO] [stdout] | [INFO] [stdout] 358 | if(settings.allow_healing_items){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 358 - if(settings.allow_healing_items){ [INFO] [stdout] 358 + if settings.allow_healing_items { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::src::gen3::trainers` [INFO] [stdout] --> src/src/gen3/startup.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::src::gen3::trainers; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::src::gen3::starter_randomization` [INFO] [stdout] --> src/src/gen3/startup.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::src::gen3::starter_randomization; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Type::*` [INFO] [stdout] --> src/src/pokemon.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use Type::*; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `LegendStatus::*` [INFO] [stdout] --> src/src/pokemon.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use LegendStatus::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Reader` [INFO] [stdout] --> src/src/pokemon.rs:9:17 [INFO] [stdout] | [INFO] [stdout] 9 | use csv::{self, Reader}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `try_catch::catch` [INFO] [stdout] --> src/src/pokemon.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use try_catch::catch; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:430:15 [INFO] [stdout] | [INFO] [stdout] 430 | ...le (pokemon::get_pokemon_data(temp_mon.species,all_stats).type1 != pkmn_type && pokemon::get_pokemon_data(temp_mon.species,all_stats).type2 != pkmn_type){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 430 - while (pokemon::get_pokemon_data(temp_mon.species,all_stats).type1 != pkmn_type && pokemon::get_pokemon_data(temp_mon.species,all_stats).type2 != pkmn_type){ [INFO] [stdout] 430 + while pokemon::get_pokemon_data(temp_mon.species,all_stats).type1 != pkmn_type && pokemon::get_pokemon_data(temp_mon.species,all_stats).type2 != pkmn_type { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `JsonValue::Null` [INFO] [stdout] --> src/src/gen3/trainers.rs:3:18 [INFO] [stdout] | [INFO] [stdout] 3 | use json::{self, JsonValue::Null}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/src/gen3/trainers.rs:287:47 [INFO] [stdout] | [INFO] [stdout] 287 | let rand_val = settings::get_next_seed(0, (pokemon_data.len() as i32), settings); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 287 - let rand_val = settings::get_next_seed(0, (pokemon_data.len() as i32), settings); [INFO] [stdout] 287 + let rand_val = settings::get_next_seed(0, pokemon_data.len() as i32 , settings); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/src/pokemon.rs:1293:13 [INFO] [stdout] | [INFO] [stdout] 1293 | min_level: min_level, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_level` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Location_type` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:23:10 [INFO] [stdout] | [INFO] [stdout] 23 | pub enum Location_type{ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `LocationType` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `ITEM_BALL` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | ITEM_BALL, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `ItemBall` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HIDDEN_ITEM` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | HIDDEN_ITEM, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `HiddenItem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `LEGENDARY_POKEMON` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | LEGENDARY_POKEMON, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `LegendaryPokemon` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `GYM_LEADER` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | GYM_LEADER, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `GymLeader` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Item_type` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:32:10 [INFO] [stdout] | [INFO] [stdout] 32 | pub enum Item_type{ [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `ItemType` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `NORMAL_ITEM` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | NORMAL_ITEM, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `NormalItem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `RAW_SCRIPT` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | RAW_SCRIPT //For use when you just want to use the "Item Name" as the full script, inserted into code raw [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `RawScript` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:73:15 [INFO] [stdout] | [INFO] [stdout] 73 | if(cur_item[i].to_string() == ""){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 73 - if(cur_item[i].to_string() == ""){ [INFO] [stdout] 73 + if cur_item[i].to_string() == "" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:293:10 [INFO] [stdout] | [INFO] [stdout] 293 | while(items.len() != 0){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 293 - while(items.len() != 0){ [INFO] [stdout] 293 + while items.len() != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:303:10 [INFO] [stdout] | [INFO] [stdout] 303 | while(items.len() != 0){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 303 - while(items.len() != 0){ [INFO] [stdout] 303 + while items.len() != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:430:15 [INFO] [stdout] | [INFO] [stdout] 430 | ...le (pokemon::get_pokemon_data(temp_mon.species,all_stats).type1 != pkmn_type && pokemon::get_pokemon_data(temp_mon.species,all_stats).type2 != pkmn_type){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 430 - while (pokemon::get_pokemon_data(temp_mon.species,all_stats).type1 != pkmn_type && pokemon::get_pokemon_data(temp_mon.species,all_stats).type2 != pkmn_type){ [INFO] [stdout] 430 + while pokemon::get_pokemon_data(temp_mon.species,all_stats).type1 != pkmn_type && pokemon::get_pokemon_data(temp_mon.species,all_stats).type2 != pkmn_type { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `JsonValue::Null` [INFO] [stdout] --> src/src/gen3/trainers.rs:3:18 [INFO] [stdout] | [INFO] [stdout] 3 | use json::{self, JsonValue::Null}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:322:7 [INFO] [stdout] | [INFO] [stdout] 322 | if(settings.randomize_key_items){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 322 - if(settings.randomize_key_items){ [INFO] [stdout] 322 + if settings.randomize_key_items { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/src/gen3/trainers.rs:287:47 [INFO] [stdout] | [INFO] [stdout] 287 | let rand_val = settings::get_next_seed(0, (pokemon_data.len() as i32), settings); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 287 - let rand_val = settings::get_next_seed(0, (pokemon_data.len() as i32), settings); [INFO] [stdout] 287 + let rand_val = settings::get_next_seed(0, pokemon_data.len() as i32 , settings); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:329:7 [INFO] [stdout] | [INFO] [stdout] 329 | if(settings.randomize_hms){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 329 - if(settings.randomize_hms){ [INFO] [stdout] 329 + if settings.randomize_hms { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:335:7 [INFO] [stdout] | [INFO] [stdout] 335 | if(settings.randomize_gym_badges){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 335 - if(settings.randomize_gym_badges){ [INFO] [stdout] 335 + if settings.randomize_gym_badges { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:353:7 [INFO] [stdout] | [INFO] [stdout] 353 | if(settings.add_revives){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 353 - if(settings.add_revives){ [INFO] [stdout] 353 + if settings.add_revives { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:358:7 [INFO] [stdout] | [INFO] [stdout] 358 | if(settings.allow_healing_items){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 358 - if(settings.allow_healing_items){ [INFO] [stdout] 358 + if settings.allow_healing_items { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Location_type` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:23:10 [INFO] [stdout] | [INFO] [stdout] 23 | pub enum Location_type{ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `LocationType` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::src::gen3::trainers` [INFO] [stdout] --> src/src/gen3/startup.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::src::gen3::trainers; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `ITEM_BALL` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | ITEM_BALL, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `ItemBall` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::src::gen3::starter_randomization` [INFO] [stdout] --> src/src/gen3/startup.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::src::gen3::starter_randomization; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Type::*` [INFO] [stdout] --> src/src/pokemon.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use Type::*; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `LegendStatus::*` [INFO] [stdout] --> src/src/pokemon.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use LegendStatus::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Reader` [INFO] [stdout] --> src/src/pokemon.rs:9:17 [INFO] [stdout] | [INFO] [stdout] 9 | use csv::{self, Reader}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `try_catch::catch` [INFO] [stdout] --> src/src/pokemon.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use try_catch::catch; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HIDDEN_ITEM` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | HIDDEN_ITEM, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `HiddenItem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `LEGENDARY_POKEMON` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | LEGENDARY_POKEMON, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `LegendaryPokemon` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `GYM_LEADER` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | GYM_LEADER, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `GymLeader` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Item_type` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:32:10 [INFO] [stdout] | [INFO] [stdout] 32 | pub enum Item_type{ [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `ItemType` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `NORMAL_ITEM` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | NORMAL_ITEM, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `NormalItem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `RAW_SCRIPT` should have an upper camel case name [INFO] [stdout] --> src/src/gen3/item_randomization.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | RAW_SCRIPT //For use when you just want to use the "Item Name" as the full script, inserted into code raw [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `RawScript` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:73:15 [INFO] [stdout] | [INFO] [stdout] 73 | if(cur_item[i].to_string() == ""){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 73 - if(cur_item[i].to_string() == ""){ [INFO] [stdout] 73 + if cur_item[i].to_string() == "" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:293:10 [INFO] [stdout] | [INFO] [stdout] 293 | while(items.len() != 0){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 293 - while(items.len() != 0){ [INFO] [stdout] 293 + while items.len() != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:303:10 [INFO] [stdout] | [INFO] [stdout] 303 | while(items.len() != 0){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 303 - while(items.len() != 0){ [INFO] [stdout] 303 + while items.len() != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:322:7 [INFO] [stdout] | [INFO] [stdout] 322 | if(settings.randomize_key_items){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 322 - if(settings.randomize_key_items){ [INFO] [stdout] 322 + if settings.randomize_key_items { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:329:7 [INFO] [stdout] | [INFO] [stdout] 329 | if(settings.randomize_hms){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 329 - if(settings.randomize_hms){ [INFO] [stdout] 329 + if settings.randomize_hms { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:335:7 [INFO] [stdout] | [INFO] [stdout] 335 | if(settings.randomize_gym_badges){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 335 - if(settings.randomize_gym_badges){ [INFO] [stdout] 335 + if settings.randomize_gym_badges { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:353:7 [INFO] [stdout] | [INFO] [stdout] 353 | if(settings.add_revives){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 353 - if(settings.add_revives){ [INFO] [stdout] 353 + if settings.add_revives { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/src/gen3/item_randomization.rs:358:7 [INFO] [stdout] | [INFO] [stdout] 358 | if(settings.allow_healing_items){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 358 - if(settings.allow_healing_items){ [INFO] [stdout] 358 + if settings.allow_healing_items { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::src::gen3::trainers` [INFO] [stdout] --> src/src/gen3/startup.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::src::gen3::trainers; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::src::gen3::starter_randomization` [INFO] [stdout] --> src/src/gen3/startup.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::src::gen3::starter_randomization; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Type::*` [INFO] [stdout] --> src/src/pokemon.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use Type::*; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `LegendStatus::*` [INFO] [stdout] --> src/src/pokemon.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use LegendStatus::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Reader` [INFO] [stdout] --> src/src/pokemon.rs:9:17 [INFO] [stdout] | [INFO] [stdout] 9 | use csv::{self, Reader}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `try_catch::catch` [INFO] [stdout] --> src/src/pokemon.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use try_catch::catch; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/src/gen3/trainers.rs:497:5 [INFO] [stdout] | [INFO] [stdout] 363 | / return match rand_val{ [INFO] [stdout] 364 | | 0 => get_gem(pokemon,pokemon_data,settings), [INFO] [stdout] 365 | | 1 => get_type_boosting_item(pokemon,pokemon_data,settings), [INFO] [stdout] 366 | | 2 => "ITEM_CHOICE_BAND".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 495 | | _ => "".to_string() [INFO] [stdout] 496 | | }; [INFO] [stdout] | |_____- any code following this expression is unreachable [INFO] [stdout] 497 | old_item [INFO] [stdout] | ^^^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/src/pokemon.rs:1293:13 [INFO] [stdout] | [INFO] [stdout] 1293 | min_level: min_level, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_level` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/src/pokemon.rs:1293:13 [INFO] [stdout] | [INFO] [stdout] 1293 | min_level: min_level, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_level` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:552:9 [INFO] [stdout] | [INFO] [stdout] 552 | let mut fake_starter_trainer = Trainer{ [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/src/gen3/frlg/static_pokemon.rs:4:33 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn randomize_static_pokemon(settings: &mut settings::Settings,pokemon_data: &Vec,rival: &Vec src/src/gen3/frlg/static_pokemon.rs:4:67 [INFO] [stdout] | [INFO] [stdout] 4 | ...t settings::Settings,pokemon_data: &Vec,rival: &Vec>){ [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pokemon_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rival` [INFO] [stdout] --> src/src/gen3/frlg/static_pokemon.rs:4:109 [INFO] [stdout] | [INFO] [stdout] 4 | ...&Vec,rival: &Vec>){ [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_rival` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/trainers.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | let mut second_half_temp = "".to_string(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `second_half_temp` [INFO] [stdout] --> src/src/gen3/trainers.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | let mut second_half_temp = "".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_second_half_temp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/trainers.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | let mut formatted_name : String = if pokemon.held_items == ""{ [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/src/gen3/trainers.rs:342:23 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn create_moveset(settings: &mut settings::Settings,pokemon: pokemon::Pokemon,level: i32,old_moveset: Vec) -> Vec{ [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pokemon` [INFO] [stdout] --> src/src/gen3/trainers.rs:342:57 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn create_moveset(settings: &mut settings::Settings,pokemon: pokemon::Pokemon,level: i32,old_moveset: Vec) -> Vec{ [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pokemon` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `level` [INFO] [stdout] --> src/src/gen3/trainers.rs:342:83 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn create_moveset(settings: &mut settings::Settings,pokemon: pokemon::Pokemon,level: i32,old_moveset: Vec) -> Vec{ [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_level` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `old_moveset` [INFO] [stdout] --> src/src/gen3/trainers.rs:342:94 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn create_moveset(settings: &mut settings::Settings,pokemon: pokemon::Pokemon,level: i32,old_moveset: Vec) -> Vec{ [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_old_moveset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/src/gen3/evolution_changes.rs:2:30 [INFO] [stdout] | [INFO] [stdout] 2 | pub fn setup_evolution_fixes(settings: &settings::Settings){ [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/item_randomization.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | let mut all_items = randomize_vector_item(settings,&mut all_item_locations.clone()); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `added` is never read [INFO] [stdout] --> src/src/gen3/item_randomization.rs:127:21 [INFO] [stdout] | [INFO] [stdout] 127 | let mut added = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/src/gen3/trainers.rs:497:5 [INFO] [stdout] | [INFO] [stdout] 363 | / return match rand_val{ [INFO] [stdout] 364 | | 0 => get_gem(pokemon,pokemon_data,settings), [INFO] [stdout] 365 | | 1 => get_type_boosting_item(pokemon,pokemon_data,settings), [INFO] [stdout] 366 | | 2 => "ITEM_CHOICE_BAND".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 495 | | _ => "".to_string() [INFO] [stdout] 496 | | }; [INFO] [stdout] | |_____- any code following this expression is unreachable [INFO] [stdout] 497 | old_item [INFO] [stdout] | ^^^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:316:9 [INFO] [stdout] | [INFO] [stdout] 316 | for i in 0..settings.add_rare_candy{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:319:9 [INFO] [stdout] | [INFO] [stdout] 319 | for i in 0..settings.add_pokeballs{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:331:13 [INFO] [stdout] | [INFO] [stdout] 331 | for i in 0..(settings.number_hms+1){ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:354:13 [INFO] [stdout] | [INFO] [stdout] 354 | for i in 0..6{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:359:13 [INFO] [stdout] | [INFO] [stdout] 359 | for i in 0..6{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:450:9 [INFO] [stdout] | [INFO] [stdout] 450 | for i in 0..data_temp.len(){ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/src/gen3/logic.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn check_logic(settings: &mut settings::Settings,item_name: String, location_name: String, prereqs: Vec) -> bool{ [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `previous_areas` [INFO] [stdout] --> src/src/gen3/logic.rs:20:24 [INFO] [stdout] | [INFO] [stdout] 20 | fn check_area_for_item(previous_areas: Vec,item_name : String,location_name: String,requirements: Vec) -> bool{ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_previous_areas` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `requirements` [INFO] [stdout] --> src/src/gen3/logic.rs:20:93 [INFO] [stdout] | [INFO] [stdout] 20 | fn check_area_for_item(previous_areas: Vec,item_name : String,location_name: String,requirements: Vec) -> bool{ [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_requirements` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_connections` [INFO] [stdout] --> src/src/gen3/logic.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 30 | fn add_connection(all_connections : &mut Vec, current_location: String, previous_location: String, requirements: Vec src/src/gen3/logic.rs:30:60 [INFO] [stdout] | [INFO] [stdout] 30 | ...c, current_location: String, previous_location: String, requirements: Vec){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_location` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `previous_location` [INFO] [stdout] --> src/src/gen3/logic.rs:30:86 [INFO] [stdout] | [INFO] [stdout] 30 | ...ation: String, previous_location: String, requirements: Vec){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_previous_location` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `requirements` [INFO] [stdout] --> src/src/gen3/logic.rs:30:113 [INFO] [stdout] | [INFO] [stdout] 30 | ...s_location: String, requirements: Vec){ [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_requirements` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/logic.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let mut all_connections : Vec = Vec::new(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/startup.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | let mut all_items : Vec = item_randomization::randomize_items(settings,&pkmn_data,&gym_types); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/src/gen3/trainers.rs:497:5 [INFO] [stdout] | [INFO] [stdout] 363 | / return match rand_val{ [INFO] [stdout] 364 | | 0 => get_gem(pokemon,pokemon_data,settings), [INFO] [stdout] 365 | | 1 => get_type_boosting_item(pokemon,pokemon_data,settings), [INFO] [stdout] 366 | | 2 => "ITEM_CHOICE_BAND".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 495 | | _ => "".to_string() [INFO] [stdout] 496 | | }; [INFO] [stdout] | |_____- any code following this expression is unreachable [INFO] [stdout] 497 | old_item [INFO] [stdout] | ^^^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/src/gen3/trainers.rs:497:5 [INFO] [stdout] | [INFO] [stdout] 363 | / return match rand_val{ [INFO] [stdout] 364 | | 0 => get_gem(pokemon,pokemon_data,settings), [INFO] [stdout] 365 | | 1 => get_type_boosting_item(pokemon,pokemon_data,settings), [INFO] [stdout] 366 | | 2 => "ITEM_CHOICE_BAND".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 495 | | _ => "".to_string() [INFO] [stdout] 496 | | }; [INFO] [stdout] | |_____- any code following this expression is unreachable [INFO] [stdout] 497 | old_item [INFO] [stdout] | ^^^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_stats` [INFO] [stdout] --> src/src/pokemon.rs:1369:49 [INFO] [stdout] | [INFO] [stdout] 1369 | pub fn pokemon_alternate_forms(species: Pokemon,all_stats: &Vec,settings: &mut settings::Settings) -> String{ [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_all_stats` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MUSIC` is never used [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | const MUSIC: [&str;20] = ["MUS_VS_KYOGRE_GROUDON","MUS_VS_RAYQUAZA","MUS_RG_VS_DEOXYS","MUS_RG_VS_LEGEND","MUS_VS_MEW","MUS_VS_REGI" [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_music` is never used [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:12:4 [INFO] [stdout] | [INFO] [stdout] 12 | fn get_music(settings: &mut settings::Settings) -> String{ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `TRANSITION` is never used [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | const TRANSITION: [&str;17] = ["B_TRANSITION_KYOGRE","B_TRANSITION_GROUDON","B_TRANSITION_RAYQUAZA","B_TRANSITION_BLUR", [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_transition` is never used [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:18:4 [INFO] [stdout] | [INFO] [stdout] 18 | fn get_transition(settings: &mut settings::Settings) -> String{ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `BLUE_STARTER` is never used [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | const BLUE_STARTER: usize = 6; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_random_starter` is never used [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:551:4 [INFO] [stdout] | [INFO] [stdout] 551 | fn get_random_starter(settings: &mut settings::Settings,all_stats: &Vec) -> pokemon::Pokemon{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `post_item_script` is never read [INFO] [stdout] --> src/src/gen3/item_randomization.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Item{ [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 15 | pub post_item_script: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Item` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Connections` is never constructed [INFO] [stdout] --> src/src/gen3/logic.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Connections{ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `add_connection` is never used [INFO] [stdout] --> src/src/gen3/logic.rs:30:4 [INFO] [stdout] | [INFO] [stdout] 30 | fn add_connection(all_connections : &mut Vec, current_location: String, previous_location: String, requirements: Vec src/src/gen3/logic.rs:34:4 [INFO] [stdout] | [INFO] [stdout] 34 | fn setup_all_connections() -> Vec{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Mythical` is never constructed [INFO] [stdout] --> src/src/pokemon.rs:1226:5 [INFO] [stdout] | [INFO] [stdout] 1223 | pub enum LegendStatus{ [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] ... [INFO] [stdout] 1226 | Mythical, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LegendStatus` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_pokemon_data_integer` is never used [INFO] [stdout] --> src/src/pokemon.rs:1240:8 [INFO] [stdout] | [INFO] [stdout] 1240 | pub fn get_pokemon_data_integer(pokemon: i32,all_stats: &Vec) -> PokemonStats{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `randomize_gym_locations`, `gym_leader_keys`, `randomize_stores`, `allow_pokeballs_from_store`, `allow_healing_from_store`, and `allow_status_healing_from_store` are never read [INFO] [stdout] --> src/src/settings.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Settings{ [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 42 | pub randomize_gym_locations: GymLocationRandomization, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 56 | pub gym_leader_keys: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 57 | //Poke Mart Settings [INFO] [stdout] 58 | pub randomize_stores: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 59 | pub allow_pokeballs_from_store: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 60 | pub allow_healing_from_store: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 61 | pub allow_status_healing_from_store: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Settings` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | return all; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return all; [INFO] [stdout] 124 + all [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / let mut all : Vec> = Vec::new(); [INFO] [stdout] 22 | | all.push(Vec::new()); [INFO] [stdout] 23 | | all.push(Vec::new()); [INFO] [stdout] | |_________________________^ help: consider using the `vec![]` macro: `let mut all: Vec> = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:250:5 [INFO] [stdout] | [INFO] [stdout] 250 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 250 - return false; [INFO] [stdout] 250 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:132:36 [INFO] [stdout] | [INFO] [stdout] 132 | if trainer.trainer_name == i.to_string(){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:143:36 [INFO] [stdout] | [INFO] [stdout] 143 | if trainer.trainer_name == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:154:51 [INFO] [stdout] | [INFO] [stdout] 154 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:165:51 [INFO] [stdout] | [INFO] [stdout] 165 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:179:51 [INFO] [stdout] | [INFO] [stdout] 179 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:192:51 [INFO] [stdout] | [INFO] [stdout] 192 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:204:51 [INFO] [stdout] | [INFO] [stdout] 204 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:222:51 [INFO] [stdout] | [INFO] [stdout] 222 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:238:51 [INFO] [stdout] | [INFO] [stdout] 238 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:248:51 [INFO] [stdout] | [INFO] [stdout] 248 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:262:25 [INFO] [stdout] | [INFO] [stdout] 262 | "MARC" => { return handle_gym_trainer(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 262 - "MARC" => { return handle_gym_trainer(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock);} [INFO] [stdout] 262 + "MARC" => { handle_gym_trainer(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:263:27 [INFO] [stdout] | [INFO] [stdout] 263 | "ROXANNE" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock,0);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 - "ROXANNE" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock,0);} [INFO] [stdout] 263 + "ROXANNE" => {handle_gym_leader(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock,0)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:269:27 [INFO] [stdout] | [INFO] [stdout] 269 | "JOCELYN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 269 - "JOCELYN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting)} [INFO] [stdout] 269 + "JOCELYN" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:270:26 [INFO] [stdout] | [INFO] [stdout] 270 | "BRAWLY" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting,1);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 - "BRAWLY" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting,1);} [INFO] [stdout] 270 + "BRAWLY" => {handle_gym_leader(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting,1)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:276:26 [INFO] [stdout] | [INFO] [stdout] 276 | "SHAWN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 276 - "SHAWN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric)} [INFO] [stdout] 276 + "SHAWN" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:277:26 [INFO] [stdout] | [INFO] [stdout] 277 | "WATTSON" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric,2);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - "WATTSON" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric,2);} [INFO] [stdout] 277 + "WATTSON" =>{handle_gym_leader(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric,2)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:286:27 [INFO] [stdout] | [INFO] [stdout] 286 | "DANIELLE" =>{return handle_gym_trainer(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 286 - "DANIELLE" =>{return handle_gym_trainer(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire)} [INFO] [stdout] 286 + "DANIELLE" =>{handle_gym_trainer(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:287:27 [INFO] [stdout] | [INFO] [stdout] 287 | "FLANNERY" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire,3);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 287 - "FLANNERY" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire,3);} [INFO] [stdout] 287 + "FLANNERY" =>{handle_gym_leader(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire,3)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:295:25 [INFO] [stdout] | [INFO] [stdout] 295 | "BERKE" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - "BERKE" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal)} [INFO] [stdout] 295 + "BERKE" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:296:24 [INFO] [stdout] | [INFO] [stdout] 296 | "NORMAN"=>{return handle_gym_leader(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal,4);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 296 - "NORMAN"=>{return handle_gym_leader(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal,4);} [INFO] [stdout] 296 + "NORMAN"=>{handle_gym_leader(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal,4)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:303:26 [INFO] [stdout] | [INFO] [stdout] 303 | "DARIUS" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 303 - "DARIUS" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying)} [INFO] [stdout] 303 + "DARIUS" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:304:26 [INFO] [stdout] | [INFO] [stdout] 304 | "WINONA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying,5);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 304 - "WINONA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying,5);} [INFO] [stdout] 304 + "WINONA" => {handle_gym_leader(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying,5)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:317:26 [INFO] [stdout] | [INFO] [stdout] 317 | "HANNAH" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 317 - "HANNAH" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic)} [INFO] [stdout] 317 + "HANNAH" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:318:29 [INFO] [stdout] | [INFO] [stdout] 318 | "TATE&LIZA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic,6);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 318 - "TATE&LIZA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic,6);} [INFO] [stdout] 318 + "TATE&LIZA" => {handle_gym_leader(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic,6)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:329:27 [INFO] [stdout] | [INFO] [stdout] 329 | "BRIDGET" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 329 - "BRIDGET" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water)} [INFO] [stdout] 329 + "BRIDGET" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:330:24 [INFO] [stdout] | [INFO] [stdout] 330 | "JUAN" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water,7);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 330 - "JUAN" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water,7);} [INFO] [stdout] 330 + "JUAN" => {handle_gym_leader(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water,7)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:332:26 [INFO] [stdout] | [INFO] [stdout] 332 | "SIDNEY" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[0],pokemon::Type::Dark,8);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 332 - "SIDNEY" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[0],pokemon::Type::Dark,8);} [INFO] [stdout] 332 + "SIDNEY" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[0],pokemon::Type::Dark,8)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:333:26 [INFO] [stdout] | [INFO] [stdout] 333 | "GLACIA" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[1],pokemon::Type::Ice,9);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 333 - "GLACIA" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[1],pokemon::Type::Ice,9);} [INFO] [stdout] 333 + "GLACIA" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[1],pokemon::Type::Ice,9)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:334:26 [INFO] [stdout] | [INFO] [stdout] 334 | "PHOEBE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[2],pokemon::Type::Ghost,10);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 334 - "PHOEBE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[2],pokemon::Type::Ghost,10);} [INFO] [stdout] 334 + "PHOEBE" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[2],pokemon::Type::Ghost,10)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:335:25 [INFO] [stdout] | [INFO] [stdout] 335 | "DRAKE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[3],pokemon::Type::Dragon,11);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 335 - "DRAKE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[3],pokemon::Type::Dragon,11);} [INFO] [stdout] 335 + "DRAKE" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[3],pokemon::Type::Dragon,11)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:336:27 [INFO] [stdout] | [INFO] [stdout] 336 | "WALLACE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[4],pokemon::Type::Water,12);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 336 - "WALLACE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[4],pokemon::Type::Water,12);} [INFO] [stdout] 336 + "WALLACE" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[4],pokemon::Type::Water,12)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:340:21 [INFO] [stdout] | [INFO] [stdout] 340 | ... return if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 1, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 340 - return if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 1, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] 340 + if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 1, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:343:21 [INFO] [stdout] | [INFO] [stdout] 343 | ... return if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 2, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 343 - return if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 2, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] 343 + if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 2, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:365:17 [INFO] [stdout] | [INFO] [stdout] 365 | return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 365 - return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] 365 + trainers::get_random_trainer(trainer, settings, all_stats) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:374:9 [INFO] [stdout] | [INFO] [stdout] 374 | return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 374 - return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] 374 + trainers::get_random_trainer(trainer, settings, all_stats) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:378:9 [INFO] [stdout] | [INFO] [stdout] 378 | return get_gym_trainer_pokemon(trainer,settings,all_stats,pkmn_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 378 - return get_gym_trainer_pokemon(trainer,settings,all_stats,pkmn_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] 378 + get_gym_trainer_pokemon(trainer,settings,all_stats,pkmn_type,settings.allow_trainer_legendaries.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:382:9 [INFO] [stdout] | [INFO] [stdout] 382 | return get_gym_trainer_pokemon(trainer,settings,all_stats,standard_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 382 - return get_gym_trainer_pokemon(trainer,settings,all_stats,standard_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] 382 + get_gym_trainer_pokemon(trainer,settings,all_stats,standard_type,settings.allow_trainer_legendaries.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:546:5 [INFO] [stdout] | [INFO] [stdout] 546 | return new_trainer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 546 - return new_trainer; [INFO] [stdout] 546 + new_trainer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:405:17 [INFO] [stdout] | [INFO] [stdout] 405 | / if !has_mega{ [INFO] [stdout] 406 | | has_mega = settings.gym_leader_megas; [INFO] [stdout] 407 | | num_gimmick += 1; [INFO] [stdout] 408 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 404 ~ 0 [INFO] [stdout] 405 ~ if !has_mega=> { [INFO] [stdout] 406 | has_mega = settings.gym_leader_megas; [INFO] [stdout] 407 | num_gimmick += 1; [INFO] [stdout] 408 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:411:17 [INFO] [stdout] | [INFO] [stdout] 411 | / if !has_legend{ [INFO] [stdout] 412 | | has_legend = settings.gym_leader_legends; [INFO] [stdout] 413 | | num_gimmick += 1; [INFO] [stdout] 414 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 410 ~ 1 [INFO] [stdout] 411 ~ if !has_legend=> { [INFO] [stdout] 412 | has_legend = settings.gym_leader_legends; [INFO] [stdout] 413 | num_gimmick += 1; [INFO] [stdout] 414 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:417:17 [INFO] [stdout] | [INFO] [stdout] 417 | / if !has_z_crystal{ [INFO] [stdout] 418 | | has_z_crystal = settings.gym_leader_z_crystal; [INFO] [stdout] 419 | | num_gimmick += 1; [INFO] [stdout] 420 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 416 ~ 2 [INFO] [stdout] 417 ~ if !has_z_crystal=> { [INFO] [stdout] 418 | has_z_crystal = settings.gym_leader_z_crystal; [INFO] [stdout] 419 | num_gimmick += 1; [INFO] [stdout] 420 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:423:17 [INFO] [stdout] | [INFO] [stdout] 423 | / if !has_dynamax{ [INFO] [stdout] 424 | | has_dynamax = settings.gym_leader_dynamax; [INFO] [stdout] 425 | | num_gimmick += 1; [INFO] [stdout] 426 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 422 ~ 3 [INFO] [stdout] 423 ~ if !has_dynamax=> { [INFO] [stdout] 424 | has_dynamax = settings.gym_leader_dynamax; [INFO] [stdout] 425 | num_gimmick += 1; [INFO] [stdout] 426 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:429:17 [INFO] [stdout] | [INFO] [stdout] 429 | / if !has_terra{ [INFO] [stdout] 430 | | has_terra = settings.gym_leader_terra; [INFO] [stdout] 431 | | num_gimmick += 1; [INFO] [stdout] 432 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 428 ~ 4 [INFO] [stdout] 429 ~ if !has_terra=> { [INFO] [stdout] 430 | has_terra = settings.gym_leader_terra; [INFO] [stdout] 431 | num_gimmick += 1; [INFO] [stdout] 432 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:403:42 [INFO] [stdout] | [INFO] [stdout] 403 | match settings::get_next_seed(0, 10 as i32, settings){ [INFO] [stdout] | ^^^^^^^^^ help: try: `10_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:464:48 [INFO] [stdout] | [INFO] [stdout] 464 | if (has_mega || has_legend) && added_pokemon.len() == 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `added_pokemon.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:558:17 [INFO] [stdout] | [INFO] [stdout] 558 | / (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 559 | | legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 558 - (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 559 - legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 558 + !(!has_legend || legend_rule != settings::AllowLegendaries::OneLegend && legend_rule != settings::AllowLegendaries::AceLegend) [INFO] [stdout] | [INFO] [stdout] 558 - (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 559 - legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 558 + (legend_rule == settings::AllowLegendaries::AceLegend || legend_rule == settings::AllowLegendaries::OneLegend) && has_legend [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:574:5 [INFO] [stdout] | [INFO] [stdout] 574 | return new_trainer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 574 - return new_trainer; [INFO] [stdout] 574 + new_trainer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:557:98 [INFO] [stdout] | [INFO] [stdout] 557 | ...r_trainer(trainer.clone().trainer_name, &cur_pokemon,all_stats,settings,if settings.allow_trainer_legendaries.clone() == setting... [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `cur_pokemon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:557:130 [INFO] [stdout] | [INFO] [stdout] 557 | ... let pokemon = trainers::get_random_pokemon_for_trainer(trainer.clone().trainer_name, &cur_pokemon,all_stats,settings,if set... [INFO] [stdout] | ____________________________________________________________________________________________________________________________^ [INFO] [stdout] 558 | | ... (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 559 | | ... legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 560 | | ... {false}else{true}); [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] help: you can reduce it to [INFO] [stdout] | [INFO] [stdout] 557 ~ let pokemon = trainers::get_random_pokemon_for_trainer(trainer.clone().trainer_name, &cur_pokemon,all_stats,settings,!(settings.allow_trainer_legendaries.clone() == settings::AllowLegendaries::NoLegends || (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 558 ~ legend_rule == settings::AllowLegendaries::AceLegend && has_legend))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:646:5 [INFO] [stdout] | [INFO] [stdout] 646 | return random_rival; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 646 - return random_rival; [INFO] [stdout] 646 + random_rival [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:769:5 [INFO] [stdout] | [INFO] [stdout] 769 | return trainer; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 769 - return trainer; [INFO] [stdout] 769 + trainer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:660:40 [INFO] [stdout] | [INFO] [stdout] 660 | species: scale_pokemon(rival_team[RIVAL_TROPIUS].clone(), 13, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_TROPIUS]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:661:73 [INFO] [stdout] | [INFO] [stdout] 661 | ... scale_pokemon(rival_team[RIVAL_TROPIUS].clone(), 13, all_stats, &mut settings.clone()).pokemon_id, 13, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_TROPIUS]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:662:80 [INFO] [stdout] | [INFO] [stdout] 662 | ... scale_pokemon(rival_team[RIVAL_TROPIUS].clone(), 13, all_stats, &mut settings.clone()).pokemon_id, 13, "".to_string(),true,all_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_TROPIUS]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:668:40 [INFO] [stdout] | [INFO] [stdout] 668 | species: scale_pokemon(starter.clone(), 15, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:669:73 [INFO] [stdout] | [INFO] [stdout] 669 | ... moves: trainers::create_moveset(settings, scale_pokemon(starter.clone(), 15, all_stats, &mut settings.clone()).pokemon_id, 15... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:670:80 [INFO] [stdout] | [INFO] [stdout] 670 | ... held_items: trainers::create_held_item(settings, scale_pokemon(starter.clone(), 15, all_stats, &mut settings.clone()).pokemon... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:678:40 [INFO] [stdout] | [INFO] [stdout] 678 | species: scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:679:73 [INFO] [stdout] | [INFO] [stdout] 679 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, &mut settings.clone()).pokemon_id, 18, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:680:80 [INFO] [stdout] | [INFO] [stdout] 680 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, &mut settings.clone()).pokemon_id, 18, "".to_string(),true,all_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:687:73 [INFO] [stdout] | [INFO] [stdout] 687 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, &mut settings.clone()).pokemon_id, 18, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:688:80 [INFO] [stdout] | [INFO] [stdout] 688 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, &mut settings.clone()).pokemon_id, 18, "".to_string(),true,all_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:694:40 [INFO] [stdout] | [INFO] [stdout] 694 | species: scale_pokemon(starter.clone(), 20, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:695:73 [INFO] [stdout] | [INFO] [stdout] 695 | ... moves: trainers::create_moveset(settings, scale_pokemon(starter.clone(), 20, all_stats, &mut settings.clone()).pokemon_id, 20... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:696:80 [INFO] [stdout] | [INFO] [stdout] 696 | ... held_items: trainers::create_held_item(settings, scale_pokemon(starter.clone(), 20, all_stats, &mut settings.clone()).pokemon... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:704:40 [INFO] [stdout] | [INFO] [stdout] 704 | species: scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 29, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:705:73 [INFO] [stdout] | [INFO] [stdout] 705 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 29, all_stats, &mut settings.clone()).pokemon_id, 29, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:706:80 [INFO] [stdout] | [INFO] [stdout] 706 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 29, all_stats, &mut settings.clone()).pokemon_id, 29, "".to_string(),true,all_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:713:73 [INFO] [stdout] | [INFO] [stdout] 713 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 29, all_stats, &mut settings.clone()).pokemon_id, 29, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:714:80 [INFO] [stdout] | [INFO] [stdout] 714 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 29, all_stats, &mut settings.clone()).pokemon_id, 29, "".to_string(),true,all_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:720:40 [INFO] [stdout] | [INFO] [stdout] 720 | species: scale_pokemon(starter.clone(), 31, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:721:73 [INFO] [stdout] | [INFO] [stdout] 721 | ... moves: trainers::create_moveset(settings, scale_pokemon(starter.clone(), 31, all_stats, &mut settings.clone()).pokemon_id, 31... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:722:80 [INFO] [stdout] | [INFO] [stdout] 722 | ... held_items: trainers::create_held_item(settings, scale_pokemon(starter.clone(), 31, all_stats, &mut settings.clone()).pokemon... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:731:26 [INFO] [stdout] | [INFO] [stdout] 731 | species: rival_team[RIVAL_SLUGMA].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_SLUGMA]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:732:58 [INFO] [stdout] | [INFO] [stdout] 732 | moves: trainers::create_moveset(settings,rival_team[RIVAL_SLUGMA].clone(),31,Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_SLUGMA]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:733:66 [INFO] [stdout] | [INFO] [stdout] 733 | held_items: trainers::create_held_item(settings, rival_team[RIVAL_SLUGMA].clone(), 31, "".to_string(),true,all_stats) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_SLUGMA]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:739:26 [INFO] [stdout] | [INFO] [stdout] 739 | species: rival_team[RIVAL_LUDICOLO].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:740:59 [INFO] [stdout] | [INFO] [stdout] 740 | moves: trainers::create_moveset(settings, rival_team[RIVAL_LUDICOLO].clone(), 32, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:741:66 [INFO] [stdout] | [INFO] [stdout] 741 | ...tem(settings, rival_team[RIVAL_LUDICOLO].clone(), 32, "".to_string(),true,all_stats) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:747:26 [INFO] [stdout] | [INFO] [stdout] 747 | species: rival_team[RIVAL_TROPIUS].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_TROPIUS]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:748:59 [INFO] [stdout] | [INFO] [stdout] 748 | moves: trainers::create_moveset(settings, rival_team[RIVAL_LUDICOLO].clone(), 32, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:749:66 [INFO] [stdout] | [INFO] [stdout] 749 | ...tem(settings, rival_team[RIVAL_LUDICOLO].clone(), 32, "".to_string(),true,all_stats) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:755:40 [INFO] [stdout] | [INFO] [stdout] 755 | species: scale_pokemon(starter.clone(), 34, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:756:59 [INFO] [stdout] | [INFO] [stdout] 756 | moves: trainers::create_moveset(settings, starter.clone(), 34, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:757:66 [INFO] [stdout] | [INFO] [stdout] 757 | held_items: trainers::create_held_item(settings, starter.clone(), 34, "".to_string(),true,all_stats) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:764:36 [INFO] [stdout] | [INFO] [stdout] 764 | species: scale_pokemon(starter.clone(), 5, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:790:44 [INFO] [stdout] | [INFO] [stdout] 790 | species: scale_pokemon(wally_team[WALLY_GARDEVOIR].clone(),16,all_stats,settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `wally_team[WALLY_GARDEVOIR]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/src/gen3/emerald/other.rs:4:78 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn randomize_birch_pokemon(settings: &mut settings::Settings, all_stats: &Vec){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - pub fn randomize_birch_pokemon(settings: &mut settings::Settings, all_stats: &Vec){ [INFO] [stdout] 4 + pub fn randomize_birch_pokemon(settings: &mut settings::Settings, all_stats: &[pokemon::PokemonStats]){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:21:116 [INFO] [stdout] | [INFO] [stdout] 21 | ...s,pokemon_data: &Vec,rival: &Vec>){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 21 - pub fn randomize_static_pokemon(settings: &mut settings::Settings,pokemon_data: &Vec,rival: &Vec>){ [INFO] [stdout] 21 + pub fn randomize_static_pokemon(settings: &mut settings::Settings,pokemon_data: &Vec,rival: &[Vec]){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | return legends; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return legends; [INFO] [stdout] 50 + legends [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `levels` [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:47:14 [INFO] [stdout] | [INFO] [stdout] 47 | for i in 0..9{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 47 - for i in 0..9{ [INFO] [stdout] 47 + for in levels.iter().take(9){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/startup_stuff.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return final_string [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return final_string [INFO] [stdout] 11 + final_string [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/src/gen3/emerald/startup_stuff.rs:9:27 [INFO] [stdout] | [INFO] [stdout] 9 | final_string.push_str(&get_level_cap(settings).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `get_level_cap(settings).as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/startup_stuff.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / return if settings.make_pokeballs_masterballs{ [INFO] [stdout] 18 | | "setflag FLAG_ALL_BALLS_MASTERBALL\n".to_string() [INFO] [stdout] 19 | | } [INFO] [stdout] 20 | | else{ [INFO] [stdout] 21 | | "clearflag FLAG_ALL_BALLS_MASTERBALL\n".to_string() [INFO] [stdout] 22 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ if settings.make_pokeballs_masterballs{ [INFO] [stdout] 18 + "setflag FLAG_ALL_BALLS_MASTERBALL\n".to_string() [INFO] [stdout] 19 + } [INFO] [stdout] 20 + else{ [INFO] [stdout] 21 + "clearflag FLAG_ALL_BALLS_MASTERBALL\n".to_string() [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/startup_stuff.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / return if settings.allow_hm_use{ [INFO] [stdout] 27 | | "clearflag FLAG_HMS_NEED_BADGES\n".to_string() [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | else{ [INFO] [stdout] 30 | | "setflag FLAG_HMS_NEED_BADGES\n".to_string() [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 ~ if settings.allow_hm_use{ [INFO] [stdout] 27 + "clearflag FLAG_HMS_NEED_BADGES\n".to_string() [INFO] [stdout] 28 + } [INFO] [stdout] 29 + else{ [INFO] [stdout] 30 + "setflag FLAG_HMS_NEED_BADGES\n".to_string() [INFO] [stdout] 31 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/startup_stuff.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | / return if settings.rare_candy_modification{ [INFO] [stdout] 36 | | "setflag FLAG_RARE_CANDY_MOD\n".to_string() [INFO] [stdout] 37 | | } [INFO] [stdout] 38 | | else{ [INFO] [stdout] 39 | | "clearflag FLAG_RARE_CANDY_MOD\n".to_string() [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 ~ if settings.rare_candy_modification{ [INFO] [stdout] 36 + "setflag FLAG_RARE_CANDY_MOD\n".to_string() [INFO] [stdout] 37 + } [INFO] [stdout] 38 + else{ [INFO] [stdout] 39 + "clearflag FLAG_RARE_CANDY_MOD\n".to_string() [INFO] [stdout] 40 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/startup_stuff.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | / return if settings.follower_pokemon{ [INFO] [stdout] 45 | | "setflag OW_FOLLOWERS_ENABLED\n".to_string() [INFO] [stdout] 46 | | } [INFO] [stdout] 47 | | else{ [INFO] [stdout] 48 | | "clearflag OW_FOLLOWERS_ENABLED\n".to_string() [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 ~ if settings.follower_pokemon{ [INFO] [stdout] 45 + "setflag OW_FOLLOWERS_ENABLED\n".to_string() [INFO] [stdout] 46 + } [INFO] [stdout] 47 + else{ [INFO] [stdout] 48 + "clearflag OW_FOLLOWERS_ENABLED\n".to_string() [INFO] [stdout] 49 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/startup_stuff.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | / return if settings.enforce_level_cap{ [INFO] [stdout] 54 | | "setflag B_RARE_CANDY_CAP\n [INFO] [stdout] 55 | | setflag B_LEVEL_CAP_EXP_UP\n".to_string() [INFO] [stdout] ... | [INFO] [stdout] 59 | | clearflag B_LEVEL_CAP_EXP_UP\n".to_string() [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 ~ if settings.enforce_level_cap{ [INFO] [stdout] 54 + "setflag B_RARE_CANDY_CAP\n [INFO] [stdout] 55 + setflag B_LEVEL_CAP_EXP_UP\n".to_string() [INFO] [stdout] 56 + } [INFO] [stdout] 57 + else{ [INFO] [stdout] 58 + "clearflag B_RARE_CANDY_CAP\n [INFO] [stdout] 59 + clearflag B_LEVEL_CAP_EXP_UP\n".to_string() [INFO] [stdout] 60 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | return all; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return all; [INFO] [stdout] 123 + all [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / let mut all : Vec> = Vec::new(); [INFO] [stdout] 22 | | all.push(Vec::new()); [INFO] [stdout] | |_________________________^ help: consider using the `vec![]` macro: `let mut all: Vec> = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:230:5 [INFO] [stdout] | [INFO] [stdout] 230 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 230 - return false; [INFO] [stdout] 230 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:129:32 [INFO] [stdout] | [INFO] [stdout] 129 | if trainer.trainer_name == "TERRY".to_string(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"TERRY"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:137:36 [INFO] [stdout] | [INFO] [stdout] 137 | if trainer.trainer_name == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:145:51 [INFO] [stdout] | [INFO] [stdout] 145 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:154:51 [INFO] [stdout] | [INFO] [stdout] 154 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:167:51 [INFO] [stdout] | [INFO] [stdout] 167 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:179:51 [INFO] [stdout] | [INFO] [stdout] 179 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:192:51 [INFO] [stdout] | [INFO] [stdout] 192 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:205:51 [INFO] [stdout] | [INFO] [stdout] 205 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:219:51 [INFO] [stdout] | [INFO] [stdout] 219 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:228:51 [INFO] [stdout] | [INFO] [stdout] 228 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:240:25 [INFO] [stdout] | [INFO] [stdout] 240 | "LIAM" => { return handle_gym_trainer(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 240 - "LIAM" => { return handle_gym_trainer(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock);} [INFO] [stdout] 240 + "LIAM" => { handle_gym_trainer(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:241:25 [INFO] [stdout] | [INFO] [stdout] 241 | "BROCK" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock,0);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 241 - "BROCK" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock,0);} [INFO] [stdout] 241 + "BROCK" => {handle_gym_leader(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock,0)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:244:25 [INFO] [stdout] | [INFO] [stdout] 244 | "DIANA" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 244 - "DIANA" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting)} [INFO] [stdout] 244 + "DIANA" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:245:25 [INFO] [stdout] | [INFO] [stdout] 245 | "MISTY" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting,1);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 245 - "MISTY" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting,1);} [INFO] [stdout] 245 + "MISTY" => {handle_gym_leader(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting,1)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:249:27 [INFO] [stdout] | [INFO] [stdout] 249 | "TUCKER" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 249 - "TUCKER" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric)} [INFO] [stdout] 249 + "TUCKER" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:250:28 [INFO] [stdout] | [INFO] [stdout] 250 | "LT. SURGE" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric,2);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 250 - "LT. SURGE" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric,2);} [INFO] [stdout] 250 + "LT. SURGE" =>{handle_gym_leader(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric,2)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:258:24 [INFO] [stdout] | [INFO] [stdout] 258 | "TAMIA" =>{return handle_gym_trainer(trainer,settings,all_stats,gym_types[3],pokemon::Type::Grass)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 258 - "TAMIA" =>{return handle_gym_trainer(trainer,settings,all_stats,gym_types[3],pokemon::Type::Grass)} [INFO] [stdout] 258 + "TAMIA" =>{handle_gym_trainer(trainer,settings,all_stats,gym_types[3],pokemon::Type::Grass)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:259:24 [INFO] [stdout] | [INFO] [stdout] 259 | "ERIKA" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[3],pokemon::Type::Grass,3);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 259 - "ERIKA" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[3],pokemon::Type::Grass,3);} [INFO] [stdout] 259 + "ERIKA" =>{handle_gym_leader(trainer,settings,all_stats,gym_types[3],pokemon::Type::Grass,3)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:266:25 [INFO] [stdout] | [INFO] [stdout] 266 | "SHAWN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[4],pokemon::Type::Poison)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 266 - "SHAWN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[4],pokemon::Type::Poison)} [INFO] [stdout] 266 + "SHAWN" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[4],pokemon::Type::Poison)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:267:22 [INFO] [stdout] | [INFO] [stdout] 267 | "KOGA"=>{return handle_gym_leader(trainer,settings,all_stats,gym_types[4],pokemon::Type::Poison,4);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 267 - "KOGA"=>{return handle_gym_leader(trainer,settings,all_stats,gym_types[4],pokemon::Type::Poison,4);} [INFO] [stdout] 267 + "KOGA"=>{handle_gym_leader(trainer,settings,all_stats,gym_types[4],pokemon::Type::Poison,4)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:275:25 [INFO] [stdout] | [INFO] [stdout] 275 | "JOHAN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[5],pokemon::Type::Psychic)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 275 - "JOHAN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[5],pokemon::Type::Psychic)} [INFO] [stdout] 275 + "JOHAN" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[5],pokemon::Type::Psychic)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:276:27 [INFO] [stdout] | [INFO] [stdout] 276 | "SABRINA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[5],pokemon::Type::Psychic,5);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 276 - "SABRINA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[5],pokemon::Type::Psychic,5);} [INFO] [stdout] 276 + "SABRINA" => {handle_gym_leader(trainer,settings,all_stats,gym_types[5],pokemon::Type::Psychic,5)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:284:23 [INFO] [stdout] | [INFO] [stdout] 284 | "ZAC" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 284 - "ZAC" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic)} [INFO] [stdout] 284 + "ZAC" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:285:26 [INFO] [stdout] | [INFO] [stdout] 285 | "BLAINE" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic,6);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 285 - "BLAINE" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic,6);} [INFO] [stdout] 285 + "BLAINE" => {handle_gym_leader(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic,6)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:294:27 [INFO] [stdout] | [INFO] [stdout] 294 | "TAKASHI" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 294 - "TAKASHI" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water)} [INFO] [stdout] 294 + "TAKASHI" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:295:28 [INFO] [stdout] | [INFO] [stdout] 295 | "GIOVANNI" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water,7);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - "GIOVANNI" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water,7);} [INFO] [stdout] 295 + "GIOVANNI" => {handle_gym_leader(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water,7)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:297:27 [INFO] [stdout] | [INFO] [stdout] 297 | "LORELEI" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[0],pokemon::Type::Dark,8);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 297 - "LORELEI" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[0],pokemon::Type::Dark,8);} [INFO] [stdout] 297 + "LORELEI" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[0],pokemon::Type::Dark,8)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:298:25 [INFO] [stdout] | [INFO] [stdout] 298 | "BRUNO" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[1],pokemon::Type::Ice,9);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 - "BRUNO" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[1],pokemon::Type::Ice,9);} [INFO] [stdout] 298 + "BRUNO" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[1],pokemon::Type::Ice,9)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:299:26 [INFO] [stdout] | [INFO] [stdout] 299 | "AGATHA" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[2],pokemon::Type::Ghost,10);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 299 - "AGATHA" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[2],pokemon::Type::Ghost,10);} [INFO] [stdout] 299 + "AGATHA" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[2],pokemon::Type::Ghost,10)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:300:25 [INFO] [stdout] | [INFO] [stdout] 300 | "LANCE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[3],pokemon::Type::Dragon,11);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 300 - "LANCE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[3],pokemon::Type::Dragon,11);} [INFO] [stdout] 300 + "LANCE" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[3],pokemon::Type::Dragon,11)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:313:17 [INFO] [stdout] | [INFO] [stdout] 313 | / return handle_blue(trainer,settings,all_stats,new_rivals,if settings.rival_keeps_starter{ [INFO] [stdout] 314 | | starters [INFO] [stdout] 315 | | } [INFO] [stdout] 316 | | else{ [INFO] [stdout] ... | [INFO] [stdout] 319 | | ); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 313 ~ handle_blue(trainer,settings,all_stats,new_rivals,if settings.rival_keeps_starter{ [INFO] [stdout] 314 + starters [INFO] [stdout] 315 + } [INFO] [stdout] 316 + else{ [INFO] [stdout] 317 + &new_starter [INFO] [stdout] 318 + } [INFO] [stdout] 319 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:354:5 [INFO] [stdout] | [INFO] [stdout] 354 | return new_trainer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 354 - return new_trainer; [INFO] [stdout] 354 + new_trainer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:361:9 [INFO] [stdout] | [INFO] [stdout] 361 | return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 361 - return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] 361 + trainers::get_random_trainer(trainer, settings, all_stats) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:365:9 [INFO] [stdout] | [INFO] [stdout] 365 | return get_gym_trainer_pokemon(trainer,settings,all_stats,pkmn_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 365 - return get_gym_trainer_pokemon(trainer,settings,all_stats,pkmn_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] 365 + get_gym_trainer_pokemon(trainer,settings,all_stats,pkmn_type,settings.allow_trainer_legendaries.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:369:9 [INFO] [stdout] | [INFO] [stdout] 369 | return get_gym_trainer_pokemon(trainer,settings,all_stats,standard_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 369 - return get_gym_trainer_pokemon(trainer,settings,all_stats,standard_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] 369 + get_gym_trainer_pokemon(trainer,settings,all_stats,standard_type,settings.allow_trainer_legendaries.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:520:5 [INFO] [stdout] | [INFO] [stdout] 520 | return new_trainer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 520 - return new_trainer; [INFO] [stdout] 520 + new_trainer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:392:17 [INFO] [stdout] | [INFO] [stdout] 392 | / if !has_mega{ [INFO] [stdout] 393 | | has_mega = settings.gym_leader_megas; [INFO] [stdout] 394 | | num_gimmick += 1; [INFO] [stdout] 395 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 391 ~ 0 [INFO] [stdout] 392 ~ if !has_mega=> { [INFO] [stdout] 393 | has_mega = settings.gym_leader_megas; [INFO] [stdout] 394 | num_gimmick += 1; [INFO] [stdout] 395 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:398:17 [INFO] [stdout] | [INFO] [stdout] 398 | / if !has_legend{ [INFO] [stdout] 399 | | has_legend = settings.gym_leader_legends; [INFO] [stdout] 400 | | num_gimmick += 1; [INFO] [stdout] 401 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 397 ~ 1 [INFO] [stdout] 398 ~ if !has_legend=> { [INFO] [stdout] 399 | has_legend = settings.gym_leader_legends; [INFO] [stdout] 400 | num_gimmick += 1; [INFO] [stdout] 401 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:404:17 [INFO] [stdout] | [INFO] [stdout] 404 | / if !has_z_crystal{ [INFO] [stdout] 405 | | has_z_crystal = settings.gym_leader_z_crystal; [INFO] [stdout] 406 | | num_gimmick += 1; [INFO] [stdout] 407 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 403 ~ 2 [INFO] [stdout] 404 ~ if !has_z_crystal=> { [INFO] [stdout] 405 | has_z_crystal = settings.gym_leader_z_crystal; [INFO] [stdout] 406 | num_gimmick += 1; [INFO] [stdout] 407 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:410:17 [INFO] [stdout] | [INFO] [stdout] 410 | / if !has_dynamax{ [INFO] [stdout] 411 | | has_dynamax = settings.gym_leader_dynamax; [INFO] [stdout] 412 | | num_gimmick += 1; [INFO] [stdout] 413 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 409 ~ 3 [INFO] [stdout] 410 ~ if !has_dynamax=> { [INFO] [stdout] 411 | has_dynamax = settings.gym_leader_dynamax; [INFO] [stdout] 412 | num_gimmick += 1; [INFO] [stdout] 413 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:416:17 [INFO] [stdout] | [INFO] [stdout] 416 | / if !has_terra{ [INFO] [stdout] 417 | | has_terra = settings.gym_leader_terra; [INFO] [stdout] 418 | | num_gimmick += 1; [INFO] [stdout] 419 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 415 ~ 4 [INFO] [stdout] 416 ~ if !has_terra=> { [INFO] [stdout] 417 | has_terra = settings.gym_leader_terra; [INFO] [stdout] 418 | num_gimmick += 1; [INFO] [stdout] 419 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:390:42 [INFO] [stdout] | [INFO] [stdout] 390 | match settings::get_next_seed(0, 10 as i32, settings){ [INFO] [stdout] | ^^^^^^^^^ help: try: `10_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:449:48 [INFO] [stdout] | [INFO] [stdout] 449 | if (has_mega || has_legend) && added_pokemon.len() == 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `added_pokemon.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:532:17 [INFO] [stdout] | [INFO] [stdout] 532 | / (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 533 | | legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 532 - (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 533 - legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 532 + !(!has_legend || legend_rule != settings::AllowLegendaries::OneLegend && legend_rule != settings::AllowLegendaries::AceLegend) [INFO] [stdout] | [INFO] [stdout] 532 - (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 533 - legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 532 + (legend_rule == settings::AllowLegendaries::AceLegend || legend_rule == settings::AllowLegendaries::OneLegend) && has_legend [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:548:5 [INFO] [stdout] | [INFO] [stdout] 548 | return new_trainer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 548 - return new_trainer; [INFO] [stdout] 548 + new_trainer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:531:98 [INFO] [stdout] | [INFO] [stdout] 531 | ...r_trainer(trainer.clone().trainer_name, &cur_pokemon,all_stats,settings,if settings.allow_trainer_legendaries.clone() == setting... [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `cur_pokemon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:531:130 [INFO] [stdout] | [INFO] [stdout] 531 | ... let pokemon = trainers::get_random_pokemon_for_trainer(trainer.clone().trainer_name, &cur_pokemon,all_stats,settings,if set... [INFO] [stdout] | ____________________________________________________________________________________________________________________________^ [INFO] [stdout] 532 | | ... (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 533 | | ... legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 534 | | ... {false}else{true}); [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] help: you can reduce it to [INFO] [stdout] | [INFO] [stdout] 531 ~ let pokemon = trainers::get_random_pokemon_for_trainer(trainer.clone().trainer_name, &cur_pokemon,all_stats,settings,!(settings.allow_trainer_legendaries.clone() == settings::AllowLegendaries::NoLegends || (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 532 ~ legend_rule == settings::AllowLegendaries::AceLegend && has_legend))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/src/gen3/frlg/other.rs:4:76 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn randomize_oak_pokemon(settings: &mut settings::Settings, all_stats: &Vec){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - pub fn randomize_oak_pokemon(settings: &mut settings::Settings, all_stats: &Vec){ [INFO] [stdout] 4 + pub fn randomize_oak_pokemon(settings: &mut settings::Settings, all_stats: &[pokemon::PokemonStats]){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/src/gen3/frlg/static_pokemon.rs:4:81 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn randomize_static_pokemon(settings: &mut settings::Settings,pokemon_data: &Vec,rival: &Vec,rival: &Vec>){ [INFO] [stdout] 4 + pub fn randomize_static_pokemon(settings: &mut settings::Settings,pokemon_data: &[pokemon::PokemonStats],rival: &Vec>){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/src/gen3/frlg/static_pokemon.rs:4:116 [INFO] [stdout] | [INFO] [stdout] 4 | ...s,pokemon_data: &Vec,rival: &Vec>){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - pub fn randomize_static_pokemon(settings: &mut settings::Settings,pokemon_data: &Vec,rival: &Vec>){ [INFO] [stdout] 4 + pub fn randomize_static_pokemon(settings: &mut settings::Settings,pokemon_data: &Vec,rival: &[Vec]){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/startup_stuff.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return final_string [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return final_string [INFO] [stdout] 10 + final_string [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/startup_stuff.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / return if settings.make_pokeballs_masterballs{ [INFO] [stdout] 17 | | "setflag FLAG_ALL_BALLS_MASTERBALL\n".to_string() [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | else{ [INFO] [stdout] 20 | | "clearflag FLAG_ALL_BALLS_MASTERBALL\n".to_string() [INFO] [stdout] 21 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 ~ if settings.make_pokeballs_masterballs{ [INFO] [stdout] 17 + "setflag FLAG_ALL_BALLS_MASTERBALL\n".to_string() [INFO] [stdout] 18 + } [INFO] [stdout] 19 + else{ [INFO] [stdout] 20 + "clearflag FLAG_ALL_BALLS_MASTERBALL\n".to_string() [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/startup_stuff.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / return if settings.allow_hm_use{ [INFO] [stdout] 26 | | "clearflag FLAG_HMS_NEED_BADGES\n".to_string() [INFO] [stdout] 27 | | } [INFO] [stdout] 28 | | else{ [INFO] [stdout] 29 | | "setflag FLAG_HMS_NEED_BADGES\n".to_string() [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 ~ if settings.allow_hm_use{ [INFO] [stdout] 26 + "clearflag FLAG_HMS_NEED_BADGES\n".to_string() [INFO] [stdout] 27 + } [INFO] [stdout] 28 + else{ [INFO] [stdout] 29 + "setflag FLAG_HMS_NEED_BADGES\n".to_string() [INFO] [stdout] 30 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/startup_stuff.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | / return if settings.rare_candy_modification{ [INFO] [stdout] 35 | | "setflag FLAG_RARE_CANDY_MOD\n".to_string() [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | else{ [INFO] [stdout] 38 | | "clearflag FLAG_RARE_CANDY_MOD\n".to_string() [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 ~ if settings.rare_candy_modification{ [INFO] [stdout] 35 + "setflag FLAG_RARE_CANDY_MOD\n".to_string() [INFO] [stdout] 36 + } [INFO] [stdout] 37 + else{ [INFO] [stdout] 38 + "clearflag FLAG_RARE_CANDY_MOD\n".to_string() [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/frlg/startup_stuff.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | / return if settings.follower_pokemon{ [INFO] [stdout] 44 | | "setflag OW_FOLLOWERS_ENABLED\n".to_string() [INFO] [stdout] 45 | | } [INFO] [stdout] 46 | | else{ [INFO] [stdout] 47 | | "clearflag OW_FOLLOWERS_ENABLED\n".to_string() [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 ~ if settings.follower_pokemon{ [INFO] [stdout] 44 + "setflag OW_FOLLOWERS_ENABLED\n".to_string() [INFO] [stdout] 45 + } [INFO] [stdout] 46 + else{ [INFO] [stdout] 47 + "clearflag OW_FOLLOWERS_ENABLED\n".to_string() [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/src/gen3/trainers.rs:48:22 [INFO] [stdout] | [INFO] [stdout] 48 | file_text += format!("{}",cur_trainer.trainer_full_name).as_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `cur_trainer.trainer_full_name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/src/gen3/trainers.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 53 | if cur_trainer.items != ""{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cur_trainer.items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/src/gen3/trainers.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 58 | if cur_trainer.ai != ""{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cur_trainer.ai.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/src/gen3/trainers.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | if cur_trainer.portrait != ""{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cur_trainer.portrait.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/trainers.rs:182:5 [INFO] [stdout] | [INFO] [stdout] 182 | return all_trainers; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 182 - return all_trainers; [INFO] [stdout] 182 + all_trainers [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `cat` [INFO] [stdout] --> src/src/gen3/trainers.rs:99:18 [INFO] [stdout] | [INFO] [stdout] 99 | for i in 0..cat.len(){ [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 99 - for i in 0..cat.len(){ [INFO] [stdout] 99 + for in &mut cat{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/src/gen3/trainers.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 102 | if i != "" && i.to_string().chars().nth(0).unwrap() == '='{ [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!i.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/src/gen3/trainers.rs:102:23 [INFO] [stdout] | [INFO] [stdout] 102 | if i != "" && i.to_string().chars().nth(0).unwrap() == '='{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `i.to_string().chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/src/gen3/trainers.rs:103:16 [INFO] [stdout] | [INFO] [stdout] 103 | if cur_trainer.trainer_full_name != ""{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cur_trainer.trainer_full_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/src/gen3/trainers.rs:148:17 [INFO] [stdout] | [INFO] [stdout] 148 | else if i == ""{ [INFO] [stdout] | ^^^^^^^ help: using `is_empty` is clearer and more explicit: `i.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/src/gen3/trainers.rs:177:17 [INFO] [stdout] | [INFO] [stdout] 177 | else if i != "" && i.to_string().chars().nth(0).unwrap() == '-'{ [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!i.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/src/gen3/trainers.rs:177:28 [INFO] [stdout] | [INFO] [stdout] 177 | else if i != "" && i.to_string().chars().nth(0).unwrap() == '-'{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `i.to_string().chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/trainers.rs:205:5 [INFO] [stdout] | [INFO] [stdout] 205 | / return format!("{pkmn_name} [INFO] [stdout] 206 | | Level: {level}{extra_script} [INFO] [stdout] 207 | | IVs: {iv} HP / {iv} Atk / {iv} Def / {iv} SpA / {iv} SpD / {iv} Spe [INFO] [stdout] 208 | | {moves} [INFO] [stdout] 209 | | ",pkmn_name=formatted_name,level=pokemon.level, [INFO] [stdout] 210 | | iv=pokemon.iv,moves=formatted_moves,extra_script=pokemon.extra_scripts); [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 205 ~ format!("{pkmn_name} [INFO] [stdout] 206 + Level: {level}{extra_script} [INFO] [stdout] 207 + IVs: {iv} HP / {iv} Atk / {iv} Def / {iv} SpA / {iv} SpD / {iv} Spe [INFO] [stdout] 208 + {moves} [INFO] [stdout] 209 + ",pkmn_name=formatted_name,level=pokemon.level, [INFO] [stdout] 210 ~ iv=pokemon.iv,moves=formatted_moves,extra_script=pokemon.extra_scripts) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/src/gen3/trainers.rs:190:8 [INFO] [stdout] | [INFO] [stdout] 190 | if pre_formatted_name == ""{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pre_formatted_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/src/gen3/trainers.rs:196:42 [INFO] [stdout] | [INFO] [stdout] 196 | let mut formatted_name : String = if pokemon.held_items == ""{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pokemon.held_items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/trainers.rs:239:5 [INFO] [stdout] | [INFO] [stdout] 239 | return gym_types; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 239 - return gym_types; [INFO] [stdout] 239 + gym_types [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `trainer_data` [INFO] [stdout] --> src/src/gen3/trainers.rs:229:14 [INFO] [stdout] | [INFO] [stdout] 229 | for i in 0..trainer_data.len(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 229 - for i in 0..trainer_data.len(){ [INFO] [stdout] 229 + for in &mut trainer_data{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/src/gen3/trainers.rs:248:22 [INFO] [stdout] | [INFO] [stdout] 248 | / (settings.allow_trainer_legendaries == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 249 | | settings.allow_trainer_legendaries == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] | |______________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 248 - (settings.allow_trainer_legendaries == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 249 - settings.allow_trainer_legendaries == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 248 + !(!has_legend || settings.allow_trainer_legendaries != settings::AllowLegendaries::OneLegend && settings.allow_trainer_legendaries != settings::AllowLegendaries::AceLegend) [INFO] [stdout] | [INFO] [stdout] 248 - (settings.allow_trainer_legendaries == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 249 - settings.allow_trainer_legendaries == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 248 + (settings.allow_trainer_legendaries == settings::AllowLegendaries::AceLegend || settings.allow_trainer_legendaries == settings::AllowLegendaries::OneLegend) && has_legend [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/trainers.rs:268:5 [INFO] [stdout] | [INFO] [stdout] 268 | / return Trainer{ [INFO] [stdout] 269 | | trainer_full_name: trainer.trainer_full_name, [INFO] [stdout] 270 | | trainer_name: trainer.trainer_name, [INFO] [stdout] 271 | | class: trainer.class, [INFO] [stdout] ... | [INFO] [stdout] 279 | | pokemon: trainer_pkmn [INFO] [stdout] 280 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 268 ~ Trainer{ [INFO] [stdout] 269 + trainer_full_name: trainer.trainer_full_name, [INFO] [stdout] 270 + trainer_name: trainer.trainer_name, [INFO] [stdout] 271 + class: trainer.class, [INFO] [stdout] 272 + pic: trainer.pic, [INFO] [stdout] 273 + gender: trainer.gender, [INFO] [stdout] 274 + music: trainer.music, [INFO] [stdout] 275 + items: "".to_string(), [INFO] [stdout] 276 + double_battle: trainer.double_battle, [INFO] [stdout] 277 + ai: trainer.ai, [INFO] [stdout] 278 + portrait: "".to_string(), [INFO] [stdout] 279 + pokemon: trainer_pkmn [INFO] [stdout] 280 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/src/gen3/trainers.rs:247:17 [INFO] [stdout] | [INFO] [stdout] 247 | / if settings.allow_trainer_legendaries == settings::AllowLegendaries::NoLegends || [INFO] [stdout] 248 | | (settings.allow_trainer_legendaries == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 249 | | settings.allow_trainer_legendaries == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 250 | | {false}else{true}); [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] help: you can reduce it to [INFO] [stdout] | [INFO] [stdout] 247 ~ !(settings.allow_trainer_legendaries == settings::AllowLegendaries::NoLegends || (settings.allow_trainer_legendaries == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 248 ~ settings.allow_trainer_legendaries == settings::AllowLegendaries::AceLegend && has_legend))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/src/gen3/trainers.rs:292:5 [INFO] [stdout] | [INFO] [stdout] 292 | / if settings.trainer_legendaries_rare && (new_pokemon.status == pokemon::LegendStatus::Legendary || new_pokemon.status == poke... [INFO] [stdout] 293 | | if settings::get_next_seed(0, 20, settings) != 0{ [INFO] [stdout] 294 | | return get_random_pokemon_for_trainer(trainer_name, pokemon, pokemon_data, settings, can_be_legend) [INFO] [stdout] 295 | | } [INFO] [stdout] 296 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 292 ~ if settings.trainer_legendaries_rare && (new_pokemon.status == pokemon::LegendStatus::Legendary || new_pokemon.status == pokemon::LegendStatus::LegendMega) [INFO] [stdout] 293 ~ && settings::get_next_seed(0, 20, settings) != 0{ [INFO] [stdout] 294 | return get_random_pokemon_for_trainer(trainer_name, pokemon, pokemon_data, settings, can_be_legend) [INFO] [stdout] 295 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/trainers.rs:300:18 [INFO] [stdout] | [INFO] [stdout] 300 | species: new_pokemon.pokemon_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_pokemon.pokemon_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/src/gen3/trainers.rs:283:39 [INFO] [stdout] | [INFO] [stdout] 283 | pub fn get_random_pokemon_for_trainer(trainer_name: String, pokemon: &TrainerPokemon,pokemon_data: &Vec,sett... [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_trainer_name` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/src/gen3/trainers.rs:290:47 [INFO] [stdout] | [INFO] [stdout] 290 | return get_random_pokemon_for_trainer(trainer_name, pokemon, pokemon_data, settings,can_be_legend); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 294 | return get_random_pokemon_for_trainer(trainer_name, pokemon, pokemon_data, settings, can_be_legend) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/trainers.rs:331:5 [INFO] [stdout] | [INFO] [stdout] 331 | return stats; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 331 - return stats; [INFO] [stdout] 331 + stats [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/trainers.rs:339:5 [INFO] [stdout] | [INFO] [stdout] 339 | return return_values; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 339 - return return_values; [INFO] [stdout] 339 + return_values [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/src/gen3/trainers.rs:336:11 [INFO] [stdout] | [INFO] [stdout] 336 | while next_evolutions.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!next_evolutions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/trainers.rs:344:5 [INFO] [stdout] | [INFO] [stdout] 344 | return Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 344 - return Vec::new(); [INFO] [stdout] 344 + Vec::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/src/gen3/trainers.rs:349:8 [INFO] [stdout] | [INFO] [stdout] 349 | if item != "" {return item;} [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!item.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/src/gen3/trainers.rs:356:8 [INFO] [stdout] | [INFO] [stdout] 356 | if old_item != "" && rand_val <= level / 2{ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!old_item.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/src/gen3/trainers.rs:361:8 [INFO] [stdout] | [INFO] [stdout] 361 | if item != "" && rand_val != 0{return item;} // 1/3 chance to not have a mon specific item, to spice things up [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!item.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/trainers.rs:607:5 [INFO] [stdout] | [INFO] [stdout] 607 | return "".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 607 - return "".to_string(); [INFO] [stdout] 607 + "".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/trainers.rs:688:5 [INFO] [stdout] | [INFO] [stdout] 688 | / return match prefered_type{ [INFO] [stdout] 689 | | pokemon::Type::Normal => "ITEM_NORMALIUM_Z".to_string(), [INFO] [stdout] 690 | | pokemon::Type::Fire => "ITEM_FIRIUM_Z".to_string(), [INFO] [stdout] 691 | | pokemon::Type::Water => "ITEM_WATERIUM_Z".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 707 | | _ => "ITEM_NORMALIUM_Z".to_string(), [INFO] [stdout] 708 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 688 ~ match prefered_type{ [INFO] [stdout] 689 + pokemon::Type::Normal => "ITEM_NORMALIUM_Z".to_string(), [INFO] [stdout] 690 + pokemon::Type::Fire => "ITEM_FIRIUM_Z".to_string(), [INFO] [stdout] 691 + pokemon::Type::Water => "ITEM_WATERIUM_Z".to_string(), [INFO] [stdout] 692 + pokemon::Type::Electric => "ITEM_ELECTRIUM_Z".to_string(), [INFO] [stdout] 693 + pokemon::Type::Grass => "ITEM_GRASSIUM_Z".to_string(), [INFO] [stdout] 694 + pokemon::Type::Ice => "ITEM_ICIUM_Z".to_string(), [INFO] [stdout] 695 + pokemon::Type::Fighting => "ITEM_FIGHTINIUM_Z".to_string(), [INFO] [stdout] 696 + pokemon::Type::Poison => "ITEM_POISONIUM_Z".to_string(), [INFO] [stdout] 697 + pokemon::Type::Ground => "ITEM_GROUNDIUM_Z".to_string(), [INFO] [stdout] 698 + pokemon::Type::Flying => "ITEM_FLYINIUM_Z".to_string(), [INFO] [stdout] 699 + pokemon::Type::Psychic => "ITEM_PSYCHIUM_Z".to_string(), [INFO] [stdout] 700 + pokemon::Type::Bug => "ITEM_BUGINIUM_Z".to_string(), [INFO] [stdout] 701 + pokemon::Type::Rock => "ITEM_ROCKIUM_Z".to_string(), [INFO] [stdout] 702 + pokemon::Type::Ghost => "ITEM_GHOSTIUM_Z".to_string(), [INFO] [stdout] 703 + pokemon::Type::Dragon => "ITEM_DRAGONIUM_Z".to_string(), [INFO] [stdout] 704 + pokemon::Type::Dark => "ITEM_DARKINIUM_Z".to_string(), [INFO] [stdout] 705 + pokemon::Type::Steel => "ITEM_STEELIUM_Z".to_string(), [INFO] [stdout] 706 + pokemon::Type::Fairy => "ITEM_FAIRIUM_Z".to_string(), [INFO] [stdout] 707 + _ => "ITEM_NORMALIUM_Z".to_string(), [INFO] [stdout] 708 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/src/gen3/trainers.rs:687:8 [INFO] [stdout] | [INFO] [stdout] 687 | if special_crystal != "" {return special_crystal;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!special_crystal.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/trainers.rs:717:5 [INFO] [stdout] | [INFO] [stdout] 717 | / return match pkmn_type{ [INFO] [stdout] 718 | | pokemon::Type::Normal => "ITEM_SILK_SCARF".to_string(), [INFO] [stdout] 719 | | pokemon::Type::Fire => "ITEM_CHARCOAL".to_string(), [INFO] [stdout] 720 | | pokemon::Type::Water => "ITEM_MYSTIC_WATER".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 735 | | _ => "".to_string(), [INFO] [stdout] 736 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 717 ~ match pkmn_type{ [INFO] [stdout] 718 + pokemon::Type::Normal => "ITEM_SILK_SCARF".to_string(), [INFO] [stdout] 719 + pokemon::Type::Fire => "ITEM_CHARCOAL".to_string(), [INFO] [stdout] 720 + pokemon::Type::Water => "ITEM_MYSTIC_WATER".to_string(), [INFO] [stdout] 721 + pokemon::Type::Electric => "ITEM_MAGNET".to_string(), [INFO] [stdout] 722 + pokemon::Type::Grass => "ITEM_MIRACLE_SEED".to_string(), [INFO] [stdout] 723 + pokemon::Type::Ice => "ITEM_NEVER_MELT_ICE".to_string(), [INFO] [stdout] 724 + pokemon::Type::Fighting => "ITEM_BLACK_BELT".to_string(), [INFO] [stdout] 725 + pokemon::Type::Poison => "ITEM_POISON_BARB".to_string(), [INFO] [stdout] 726 + pokemon::Type::Ground => "ITEM_SOFT_SAND".to_string(), [INFO] [stdout] 727 + pokemon::Type::Flying => "ITEM_SHARP_BEAK".to_string(), [INFO] [stdout] 728 + pokemon::Type::Psychic => "ITEM_TWISTED_SPOON".to_string(), [INFO] [stdout] 729 + pokemon::Type::Bug => "ITEM_SILVER_POWDER".to_string(), [INFO] [stdout] 730 + pokemon::Type::Rock => "ITEM_HARD_STONE".to_string(), [INFO] [stdout] 731 + pokemon::Type::Ghost => "ITEM_SPELL_TAG".to_string(), [INFO] [stdout] 732 + pokemon::Type::Dragon => "ITEM_DRAGON_FANG".to_string(), [INFO] [stdout] 733 + pokemon::Type::Dark => "ITEM_BLACK_GLASSES".to_string(), [INFO] [stdout] 734 + pokemon::Type::Steel => "ITEM_METAL_COAT".to_string(), [INFO] [stdout] 735 + _ => "".to_string(), [INFO] [stdout] 736 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/trainers.rs:745:5 [INFO] [stdout] | [INFO] [stdout] 745 | / return match pkmn_type{ [INFO] [stdout] 746 | | pokemon::Type::Normal => "ITEM_NORMAL_GEM".to_string(), [INFO] [stdout] 747 | | pokemon::Type::Fire => "ITEM_FIRE_GEM".to_string(), [INFO] [stdout] 748 | | pokemon::Type::Water => "ITEM_WATER_GEM".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 764 | | _ => "".to_string(), [INFO] [stdout] 765 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 745 ~ match pkmn_type{ [INFO] [stdout] 746 + pokemon::Type::Normal => "ITEM_NORMAL_GEM".to_string(), [INFO] [stdout] 747 + pokemon::Type::Fire => "ITEM_FIRE_GEM".to_string(), [INFO] [stdout] 748 + pokemon::Type::Water => "ITEM_WATER_GEM".to_string(), [INFO] [stdout] 749 + pokemon::Type::Electric => "ITEM_ELECTRIC_GEM".to_string(), [INFO] [stdout] 750 + pokemon::Type::Grass => "ITEM_GRASS_GEM".to_string(), [INFO] [stdout] 751 + pokemon::Type::Ice => "ITEM_ICE_GEM".to_string(), [INFO] [stdout] 752 + pokemon::Type::Fighting => "ITEM_FIGHTING_GEM".to_string(), [INFO] [stdout] 753 + pokemon::Type::Poison => "ITEM_POISON_GEM".to_string(), [INFO] [stdout] 754 + pokemon::Type::Ground => "ITEM_GROUND_GEM".to_string(), [INFO] [stdout] 755 + pokemon::Type::Flying => "ITEM_FLYING_GEM".to_string(), [INFO] [stdout] 756 + pokemon::Type::Psychic => "ITEM_PSYCHIC_GEM".to_string(), [INFO] [stdout] 757 + pokemon::Type::Bug => "ITEM_BUG_GEM".to_string(), [INFO] [stdout] 758 + pokemon::Type::Rock => "ITEM_ROCK_GEM".to_string(), [INFO] [stdout] 759 + pokemon::Type::Ghost => "ITEM_GHOST_GEM".to_string(), [INFO] [stdout] 760 + pokemon::Type::Dragon => "ITEM_DRAGON_GEM".to_string(), [INFO] [stdout] 761 + pokemon::Type::Dark => "ITEM_DARK_GEM".to_string(), [INFO] [stdout] 762 + pokemon::Type::Steel => "ITEM_STEEL_GEM".to_string(), [INFO] [stdout] 763 + pokemon::Type::Fairy => "ITEM_FAIRY_GEM".to_string(), [INFO] [stdout] 764 + _ => "".to_string(), [INFO] [stdout] 765 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/trainers.rs:773:5 [INFO] [stdout] | [INFO] [stdout] 773 | return pokemon::pokemon_alternate_forms(species,all_stats,settings); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 773 - return pokemon::pokemon_alternate_forms(species,all_stats,settings); [INFO] [stdout] 773 + pokemon::pokemon_alternate_forms(species,all_stats,settings) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/trainers.rs:778:5 [INFO] [stdout] | [INFO] [stdout] 778 | / return match rand_val{ [INFO] [stdout] 779 | | 0 => pokemon::Type::Normal, [INFO] [stdout] 780 | | 1 => pokemon::Type::Fire, [INFO] [stdout] 781 | | 2 => pokemon::Type::Water, [INFO] [stdout] ... | [INFO] [stdout] 796 | | _ => pokemon::Type::Fairy, [INFO] [stdout] 797 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 778 ~ match rand_val{ [INFO] [stdout] 779 + 0 => pokemon::Type::Normal, [INFO] [stdout] 780 + 1 => pokemon::Type::Fire, [INFO] [stdout] 781 + 2 => pokemon::Type::Water, [INFO] [stdout] 782 + 4 => pokemon::Type::Electric, [INFO] [stdout] 783 + 5 => pokemon::Type::Grass, [INFO] [stdout] 784 + 6 => pokemon::Type::Ice, [INFO] [stdout] 785 + 7 => pokemon::Type::Fighting, [INFO] [stdout] 786 + 8 => pokemon::Type::Poison, [INFO] [stdout] 787 + 9 => pokemon::Type::Ground, [INFO] [stdout] 788 + 10 => pokemon::Type::Flying, [INFO] [stdout] 789 + 11 => pokemon::Type::Psychic, [INFO] [stdout] 790 + 12 => pokemon::Type::Bug, [INFO] [stdout] 791 + 13 => pokemon::Type::Rock, [INFO] [stdout] 792 + 14 => pokemon::Type::Ghost, [INFO] [stdout] 793 + 15 => pokemon::Type::Dragon, [INFO] [stdout] 794 + 16 => pokemon::Type::Dark, [INFO] [stdout] 795 + 17 => pokemon::Type::Steel, [INFO] [stdout] 796 + _ => pokemon::Type::Fairy, [INFO] [stdout] 797 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/src/gen3/trainers.rs:777:47 [INFO] [stdout] | [INFO] [stdout] 777 | let rand_val = settings::get_next_seed(0, 18 as i32, settings); [INFO] [stdout] | ^^^^^^^^^ help: try: `18_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/trainers.rs:806:5 [INFO] [stdout] | [INFO] [stdout] 806 | return all_badges; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 806 - return all_badges; [INFO] [stdout] 806 + all_badges [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/wild_pokemon.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | return pokemon::format_pokemon_name(pokemon.pokemon_name); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return pokemon::format_pokemon_name(pokemon.pokemon_name); [INFO] [stdout] 64 + pokemon::format_pokemon_name(pokemon.pokemon_name) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/src/gen3/wild_pokemon.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | / if settings.allow_legends_in_wild_pool == settings::WildLegends::SometimesLegends && (pokemon.status == LegendStatus::Legendar... [INFO] [stdout] 50 | | if settings::get_next_seed(0, 25, settings) != 0{ [INFO] [stdout] 51 | | return get_random_wild_pokemon(settings, pokemon_data, level); [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 49 ~ if settings.allow_legends_in_wild_pool == settings::WildLegends::SometimesLegends && (pokemon.status == LegendStatus::Legendary || pokemon.status == LegendStatus::LegendMega) [INFO] [stdout] 50 ~ && settings::get_next_seed(0, 25, settings) != 0{ [INFO] [stdout] 51 | return get_random_wild_pokemon(settings, pokemon_data, level); [INFO] [stdout] 52 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/src/gen3/wild_pokemon.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | / if settings.allow_megas_in_wild_pool == settings::WildLegends::SometimesLegends && (pokemon.status == LegendStatus::Mega || po... [INFO] [stdout] 58 | | if settings::get_next_seed(0, 25, settings) != 0{ [INFO] [stdout] 59 | | return get_random_wild_pokemon(settings, pokemon_data, level); [INFO] [stdout] 60 | | } [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 57 ~ if settings.allow_megas_in_wild_pool == settings::WildLegends::SometimesLegends && (pokemon.status == LegendStatus::Mega || pokemon.status == LegendStatus::LegendMega) [INFO] [stdout] 58 ~ && settings::get_next_seed(0, 25, settings) != 0{ [INFO] [stdout] 59 | return get_random_wild_pokemon(settings, pokemon_data, level); [INFO] [stdout] 60 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/wild_pokemon.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | return trainers::scale_pokemon(pokemon.pokemon_id, level, pokemon_data, settings); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return trainers::scale_pokemon(pokemon.pokemon_id, level, pokemon_data, settings); [INFO] [stdout] 88 + trainers::scale_pokemon(pokemon.pokemon_id, level, pokemon_data, settings) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/src/gen3/wild_pokemon.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | / if settings.force_legendaries_to_legendaries == settings::LegendRarity::LikelyLegendary && !(pokemon.status == LegendStatus::L... [INFO] [stdout] 75 | | if !settings::get_next_seed(0, 200, settings) == 0{ [INFO] [stdout] 76 | | return get_legendary_pokemon(settings, pokemon_data, level,other_legends); [INFO] [stdout] 77 | | } [INFO] [stdout] 78 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ if settings.force_legendaries_to_legendaries == settings::LegendRarity::LikelyLegendary && !(pokemon.status == LegendStatus::LegendMega ||pokemon.status == LegendStatus::Legendary) [INFO] [stdout] 75 ~ && !settings::get_next_seed(0, 200, settings) == 0{ [INFO] [stdout] 76 | return get_legendary_pokemon(settings, pokemon_data, level,other_legends); [INFO] [stdout] 77 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TRAINER` contains a capitalized acronym [INFO] [stdout] --> src/src/gen3/item_randomization.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | TRAINER, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Trainer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NPC` contains a capitalized acronym [INFO] [stdout] --> src/src/gen3/item_randomization.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | NPC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Npc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TRAINER` contains a capitalized acronym [INFO] [stdout] --> src/src/gen3/item_randomization.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | TRAINER, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Trainer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EGG` contains a capitalized acronym [INFO] [stdout] --> src/src/gen3/item_randomization.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | EGG, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Egg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `POKEMON` contains a capitalized acronym [INFO] [stdout] --> src/src/gen3/item_randomization.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | POKEMON, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Pokemon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TRAP` contains a capitalized acronym [INFO] [stdout] --> src/src/gen3/item_randomization.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | TRAP, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Trap` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BADGE` contains a capitalized acronym [INFO] [stdout] --> src/src/gen3/item_randomization.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | BADGE, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Badge` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/item_randomization.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | return all_items; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return all_items; [INFO] [stdout] 92 + all_items [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/src/gen3/item_randomization.rs:87:30 [INFO] [stdout] | [INFO] [stdout] 87 | item_hidden: if cur_item[6].to_string() == "TRUE" {true} else {false}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `cur_item[6].to_string() == "TRUE"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/item_randomization.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | return all_items; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return all_items; [INFO] [stdout] 103 + all_items [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/item_randomization.rs:158:5 [INFO] [stdout] | [INFO] [stdout] 158 | return final_items; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 158 - return final_items; [INFO] [stdout] 158 + final_items [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/src/gen3/item_randomization.rs:107:136 [INFO] [stdout] | [INFO] [stdout] 107 | ...pokemon_data: &Vec, gym_types: &Vec) -> Vec{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 107 - fn randomize(mut all_item_locations: Vec,settings: &mut settings::Settings,pokemon_data: &Vec, gym_types: &Vec) -> Vec{ [INFO] [stdout] 107 + fn randomize(mut all_item_locations: Vec,settings: &mut settings::Settings,pokemon_data: &Vec, gym_types: &[pokemon::Type]) -> Vec{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `gym_types` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:113:14 [INFO] [stdout] | [INFO] [stdout] 113 | for i in 0..gym_types.len(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 113 - for i in 0..gym_types.len(){ [INFO] [stdout] 113 + for (i, ) in gym_types.iter().enumerate(){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/src/gen3/item_randomization.rs:119:8 [INFO] [stdout] | [INFO] [stdout] 119 | if settings.randomize_items == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!settings.randomize_items` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/src/gen3/item_randomization.rs:132:49 [INFO] [stdout] | [INFO] [stdout] 132 | || (!settings.randomize_hidden_items && cur_loc.item_hidden == true){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cur_loc.item_hidden` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/src/gen3/item_randomization.rs:138:31 [INFO] [stdout] | [INFO] [stdout] 138 | let item_add = if all_items_to_add.len() == 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `all_items_to_add.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/item_randomization.rs:171:5 [INFO] [stdout] | [INFO] [stdout] 171 | return new_item; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 171 - return new_item; [INFO] [stdout] 171 + new_item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:168:16 [INFO] [stdout] | [INFO] [stdout] 168 | return format!("{}", [INFO] [stdout] | ________________^ [INFO] [stdout] 169 | | wild_pokemon::get_random_wild_pokemon(settings,pokemon_data,level_of_pokemon));//Some pokemon [INFO] [stdout] | |__________________________________________________________________________________________^ help: consider using `.to_string()`: `wild_pokemon::get_random_wild_pokemon(settings,pokemon_data,level_of_pokemon).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/item_randomization.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | return Item_type::EGG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 177 - return Item_type::EGG; [INFO] [stdout] 177 + Item_type::EGG [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/item_randomization.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | return Item_type::POKEMON; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return Item_type::POKEMON; [INFO] [stdout] 180 + Item_type::POKEMON [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/item_randomization.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | return Item_type::BADGE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 184 - return Item_type::BADGE; [INFO] [stdout] 184 + Item_type::BADGE [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/item_randomization.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | return Item_type::TRAP; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 187 - return Item_type::TRAP; [INFO] [stdout] 187 + Item_type::TRAP [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/item_randomization.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | return Item_type::NORMAL_ITEM; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 190 - return Item_type::NORMAL_ITEM; [INFO] [stdout] 190 + Item_type::NORMAL_ITEM [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/item_randomization.rs:183:32 [INFO] [stdout] | [INFO] [stdout] 183 | else if item.len() > 11 && item[0..10].to_string() == "FLAG_BADGE".to_string(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `item[0..10]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/item_randomization.rs:183:59 [INFO] [stdout] | [INFO] [stdout] 183 | else if item.len() > 11 && item[0..10].to_string() == "FLAG_BADGE".to_string(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"FLAG_BADGE"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/item_randomization.rs:200:5 [INFO] [stdout] | [INFO] [stdout] 200 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 200 - return false; [INFO] [stdout] 200 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/item_randomization.rs:287:5 [INFO] [stdout] | [INFO] [stdout] 287 | return banned_list; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 287 - return banned_list; [INFO] [stdout] 287 + banned_list [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/src/gen3/item_randomization.rs:205:8 [INFO] [stdout] | [INFO] [stdout] 205 | if settings.randomize_hms == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!settings.randomize_hms` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/src/gen3/item_randomization.rs:217:8 [INFO] [stdout] | [INFO] [stdout] 217 | if settings.randomize_gym_badges == false{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!settings.randomize_gym_badges` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/src/gen3/item_randomization.rs:229:8 [INFO] [stdout] | [INFO] [stdout] 229 | if settings.randomize_key_items == false{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!settings.randomize_key_items` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/item_randomization.rs:298:5 [INFO] [stdout] | [INFO] [stdout] 298 | return randomized_items; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 - return randomized_items; [INFO] [stdout] 298 + randomized_items [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/src/gen3/item_randomization.rs:293:11 [INFO] [stdout] | [INFO] [stdout] 293 | while(items.len() != 0){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/item_randomization.rs:308:5 [INFO] [stdout] | [INFO] [stdout] 308 | return randomized_items; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 308 - return randomized_items; [INFO] [stdout] 308 + randomized_items [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/src/gen3/item_randomization.rs:303:11 [INFO] [stdout] | [INFO] [stdout] 303 | while(items.len() != 0){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/item_randomization.rs:372:5 [INFO] [stdout] | [INFO] [stdout] 372 | return new_suffled; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 372 - return new_suffled; [INFO] [stdout] 372 + new_suffled [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/item_randomization.rs:436:5 [INFO] [stdout] | [INFO] [stdout] 436 | return all_gym_rewards; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 436 - return all_gym_rewards; [INFO] [stdout] 436 + all_gym_rewards [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/starter_randomization.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | / return Starter{ [INFO] [stdout] 52 | | treeko: trainers::scale_pokemon(starters.treeko.pokemon_id, 34, all_stats, settings), [INFO] [stdout] 53 | | torchic: trainers::scale_pokemon(starters.torchic.pokemon_id, 34, all_stats, settings), [INFO] [stdout] 54 | | mudkip: trainers::scale_pokemon(starters.mudkip.pokemon_id, 34, all_stats, settings) [INFO] [stdout] 55 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 ~ Starter{ [INFO] [stdout] 52 + treeko: trainers::scale_pokemon(starters.treeko.pokemon_id, 34, all_stats, settings), [INFO] [stdout] 53 + torchic: trainers::scale_pokemon(starters.torchic.pokemon_id, 34, all_stats, settings), [INFO] [stdout] 54 + mudkip: trainers::scale_pokemon(starters.mudkip.pokemon_id, 34, all_stats, settings) [INFO] [stdout] 55 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `WildLegends` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/starter_randomization.rs:16:27 [INFO] [stdout] | [INFO] [stdout] 16 | let temp_legend_set = settings.allow_legends_in_wild_pool.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `settings.allow_legends_in_wild_pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/starter_randomization.rs:17:22 [INFO] [stdout] | [INFO] [stdout] 17 | let temp_scale = settings.scale_wild_pokemon.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `settings.scale_wild_pokemon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `WildLegends` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/starter_randomization.rs:18:43 [INFO] [stdout] | [INFO] [stdout] 18 | settings.allow_legends_in_wild_pool = settings.allow_starter_legendary.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `settings.allow_starter_legendary` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/starter_randomization.rs:19:35 [INFO] [stdout] | [INFO] [stdout] 19 | settings.scale_wild_pokemon = settings.scale_starter.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `settings.scale_starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/src/gen3/starter_randomization.rs:40:31 [INFO] [stdout] | [INFO] [stdout] 40 | fs::write(file_name_write,format!("{}\n{},\n{},\n{}\n{}", [INFO] [stdout] | _______________________________^ [INFO] [stdout] 41 | | part1, [INFO] [stdout] 42 | | pokemon::format_pokemon_name(starters.treeko.pokemon_name.clone()), [INFO] [stdout] 43 | | pokemon::format_pokemon_name(starters.torchic.pokemon_name.clone()), [INFO] [stdout] 44 | | pokemon::format_pokemon_name(starters.mudkip.pokemon_name.clone()), [INFO] [stdout] 45 | | part2).to_string()).expect("could not write to file starter_choose.c"); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 40 ~ fs::write(file_name_write,&format!("{}\n{},\n{},\n{}\n{}", [INFO] [stdout] 41 + part1, [INFO] [stdout] 42 + pokemon::format_pokemon_name(starters.treeko.pokemon_name.clone()), [INFO] [stdout] 43 + pokemon::format_pokemon_name(starters.torchic.pokemon_name.clone()), [INFO] [stdout] 44 + pokemon::format_pokemon_name(starters.mudkip.pokemon_name.clone()), [INFO] [stdout] 45 ~ part2)).expect("could not write to file starter_choose.c"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/logic.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return check_area_for_item(Vec::new(),item_name,location_name,Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return check_area_for_item(Vec::new(),item_name,location_name,Vec::new()); [INFO] [stdout] 17 + check_area_for_item(Vec::new(),item_name,location_name,Vec::new()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/logic.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return true; [INFO] [stdout] 27 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/src/gen3/logic.rs:30:37 [INFO] [stdout] | [INFO] [stdout] 30 | fn add_connection(all_connections : &mut Vec, current_location: String, previous_location: String, requirements: Vec, current_location: String, previous_location: String, requirements: Vec){ [INFO] [stdout] 30 + fn add_connection(all_connections : &mut [Connections], current_location: String, previous_location: String, requirements: Vec){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/logic.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return all_connections; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return all_connections; [INFO] [stdout] 39 + all_connections [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/create_rando_script.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return all_items; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return all_items; [INFO] [stdout] 41 + all_items [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/create_rando_script.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | / return " [INFO] [stdout] 46 | | case TRAINER_BRENDAN_ROUTE_103_MUDKIP, TRAINER_MAY_ROUTE_103_MUDKIP_EVENTSCRIPT_ITEM [INFO] [stdout] 47 | | case TRAINER_BRENDAN_ROUTE_110_MUDKIP, TRAINER_May_Route_110_Mudkip_EVENTSCRIPT_ITEM [INFO] [stdout] 48 | | case TRAINER_BRENDAN_ROUTE_119_MUDKIP, TRAINER_May_Route_119_Mudkip_EVENTSCRIPT_ITEM [INFO] [stdout] ... | [INFO] [stdout] 66 | | case TRAINER_MAY_LILYCOVE_TORCHIC, TRAINER_MAY_LILLYCOVE_MUDKIP_EVENTSCRIPT_ITEM [INFO] [stdout] 67 | | return".to_string() [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 ~ " [INFO] [stdout] 46 + case TRAINER_BRENDAN_ROUTE_103_MUDKIP, TRAINER_MAY_ROUTE_103_MUDKIP_EVENTSCRIPT_ITEM [INFO] [stdout] 47 + case TRAINER_BRENDAN_ROUTE_110_MUDKIP, TRAINER_May_Route_110_Mudkip_EVENTSCRIPT_ITEM [INFO] [stdout] 48 + case TRAINER_BRENDAN_ROUTE_119_MUDKIP, TRAINER_May_Route_119_Mudkip_EVENTSCRIPT_ITEM [INFO] [stdout] 49 + case TRAINER_BRENDAN_ROUTE_103_TREECKO, TRAINER_MAY_ROUTE_103_MUDKIP_EVENTSCRIPT_ITEM [INFO] [stdout] 50 + case TRAINER_BRENDAN_ROUTE_110_TREECKO, TRAINER_May_Route_110_Mudkip_EVENTSCRIPT_ITEM [INFO] [stdout] 51 + case TRAINER_BRENDAN_ROUTE_119_TREECKO, TRAINER_May_Route_119_Mudkip_EVENTSCRIPT_ITEM [INFO] [stdout] 52 + case TRAINER_BRENDAN_ROUTE_103_TORCHIC, TRAINER_MAY_ROUTE_103_MUDKIP_EVENTSCRIPT_ITEM [INFO] [stdout] 53 + case TRAINER_BRENDAN_ROUTE_110_TORCHIC, TRAINER_May_Route_110_Mudkip_EVENTSCRIPT_ITEM [INFO] [stdout] 54 + case TRAINER_BRENDAN_ROUTE_119_TORCHIC, TRAINER_May_Route_119_Mudkip_EVENTSCRIPT_ITEM [INFO] [stdout] 55 + case TRAINER_BRENDAN_ROUTE_103_MUDKIP, TRAINER_MAY_ROUTE_103_MUDKIP_EVENTSCRIPT_ITEM [INFO] [stdout] 56 + case TRAINER_MAY_ROUTE_103_TREECKO, TRAINER_MAY_ROUTE_103_MUDKIP_EVENTSCRIPT_ITEM [INFO] [stdout] 57 + case TRAINER_MAY_ROUTE_110_TREECKO, TRAINER_May_Route_110_Mudkip_EVENTSCRIPT_ITEM [INFO] [stdout] 58 + case TRAINER_MAY_ROUTE_119_TREECKO, TRAINER_May_Route_119_Mudkip_EVENTSCRIPT_ITEM [INFO] [stdout] 59 + case TRAINER_MAY_ROUTE_103_TORCHIC, TRAINER_MAY_ROUTE_103_MUDKIP_EVENTSCRIPT_ITEM [INFO] [stdout] 60 + case TRAINER_MAY_ROUTE_110_TORCHIC, TRAINER_May_Route_110_Mudkip_EVENTSCRIPT_ITEM [INFO] [stdout] 61 + case TRAINER_MAY_ROUTE_119_TORCHIC, TRAINER_May_Route_119_Mudkip_EVENTSCRIPT_ITEM [INFO] [stdout] 62 + case TRAINER_BRENDAN_LILYCOVE_MUDKIP, TRAINER_MAY_LILLYCOVE_MUDKIP_EVENTSCRIPT_ITEM [INFO] [stdout] 63 + case TRAINER_BRENDAN_LILYCOVE_TREECKO, TRAINER_MAY_LILLYCOVE_MUDKIP_EVENTSCRIPT_ITEM [INFO] [stdout] 64 + case TRAINER_BRENDAN_LILYCOVE_TORCHIC, TRAINER_MAY_LILLYCOVE_MUDKIP_EVENTSCRIPT_ITEM [INFO] [stdout] 65 + case TRAINER_MAY_LILYCOVE_TREECKO, TRAINER_MAY_LILLYCOVE_MUDKIP_EVENTSCRIPT_ITEM [INFO] [stdout] 66 + case TRAINER_MAY_LILYCOVE_TORCHIC, TRAINER_MAY_LILLYCOVE_MUDKIP_EVENTSCRIPT_ITEM [INFO] [stdout] 67 + return".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/src/gen3/create_rando_script.rs:71:56 [INFO] [stdout] | [INFO] [stdout] 71 | fn change_item_in_map_json(filename: String,all_items: &mut Vec){ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 71 - fn change_item_in_map_json(filename: String,all_items: &mut Vec){ [INFO] [stdout] 71 + fn change_item_in_map_json(filename: String,all_items: &mut [Item]){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/create_rando_script.rs:80:16 [INFO] [stdout] | [INFO] [stdout] 80 | if cur_obj["flag"].to_string() == cur_item.item_script{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cur_obj["flag"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/src/gen3/create_rando_script.rs:93:57 [INFO] [stdout] | [INFO] [stdout] 93 | fs::write(filename.clone(),parsed_data.to_string()).expect(format!("Writing to map.json {} failed",filename).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Writing to map.json {} failed",filename))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/create_rando_script.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | / return match item_type{ [INFO] [stdout] 98 | | Item_type::NORMAL_ITEM => "Common_EventScript_FindItem".to_string(), [INFO] [stdout] 99 | | Item_type::TRAINER => "common_rando_".to_string(), [INFO] [stdout] 100 | | Item_type::EGG => "Randomizer_Eventscript_Give_Egg_From_Template".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 104 | | Item_type::RAW_SCRIPT => "If this is being used, there is something wrong".to_string() [INFO] [stdout] 105 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 ~ match item_type{ [INFO] [stdout] 98 + Item_type::NORMAL_ITEM => "Common_EventScript_FindItem".to_string(), [INFO] [stdout] 99 + Item_type::TRAINER => "common_rando_".to_string(), [INFO] [stdout] 100 + Item_type::EGG => "Randomizer_Eventscript_Give_Egg_From_Template".to_string(), [INFO] [stdout] 101 + Item_type::POKEMON => "Randomizer_Eventscript_Give_Pokemon".to_string(), [INFO] [stdout] 102 + Item_type::TRAP => "Randomizer_Eventscript_Do_Trap_From_Template".to_string(), [INFO] [stdout] 103 + Item_type::BADGE => "common_rando_".to_string(), [INFO] [stdout] 104 + Item_type::RAW_SCRIPT => "If this is being used, there is something wrong".to_string() [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/src/gen3/create_rando_script.rs:111:8 [INFO] [stdout] | [INFO] [stdout] 111 | if cur_item.item_script == ""{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cur_item.item_script.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/create_rando_script.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | / return match badge_name.as_str(){ [INFO] [stdout] 157 | | "FLAG_BADGE01_GET" => "RustboroCity_Gym_Text_ReceivedStoneBadge", [INFO] [stdout] 158 | | "FLAG_BADGE02_GET" => "DewfordTown_Gym_Text_ReceivedKnuckleBadge", [INFO] [stdout] 159 | | "FLAG_BADGE03_GET" => "MauvilleCity_Gym_Text_ReceivedDynamoBadge", [INFO] [stdout] ... | [INFO] [stdout] 165 | | &_ => "" [INFO] [stdout] 166 | | }.to_string(); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 ~ match badge_name.as_str(){ [INFO] [stdout] 157 + "FLAG_BADGE01_GET" => "RustboroCity_Gym_Text_ReceivedStoneBadge", [INFO] [stdout] 158 + "FLAG_BADGE02_GET" => "DewfordTown_Gym_Text_ReceivedKnuckleBadge", [INFO] [stdout] 159 + "FLAG_BADGE03_GET" => "MauvilleCity_Gym_Text_ReceivedDynamoBadge", [INFO] [stdout] 160 + "FLAG_BADGE04_GET" => "LavaridgeTown_Gym_1F_Text_ReceivedHeatBadge", [INFO] [stdout] 161 + "FLAG_BADGE05_GET" => "PetalburgCity_Gym_Text_ReceivedBalanceBadge", [INFO] [stdout] 162 + "FLAG_BADGE06_GET" => "FortreeCity_Gym_Text_ReceivedFeatherBadge", [INFO] [stdout] 163 + "FLAG_BADGE07_GET" => "MossdeepCity_Gym_Text_ReceivedMindBadge", [INFO] [stdout] 164 + "FLAG_BADGE08_GET" => "SootopolisCity_Gym_1F_Text_ReceivedRainBadge", [INFO] [stdout] 165 + &_ => "" [INFO] [stdout] 166 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/create_rando_script.rs:180:5 [INFO] [stdout] | [INFO] [stdout] 180 | return all_functions; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return all_functions; [INFO] [stdout] 180 + all_functions [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/create_rando_script.rs:184:5 [INFO] [stdout] | [INFO] [stdout] 184 | / return match trainer_name.as_str(){ [INFO] [stdout] 185 | | "TRAINER_ROXANNE_1" => "\n call gym_number_0", [INFO] [stdout] 186 | | "TRAINER_BRAWLY_1" => "\n call gym_number_1", [INFO] [stdout] 187 | | "TRAINER_WATTSON_1" => "\n call gym_number_2", [INFO] [stdout] ... | [INFO] [stdout] 193 | | _ => "" [INFO] [stdout] 194 | | }.to_string(); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 184 ~ match trainer_name.as_str(){ [INFO] [stdout] 185 + "TRAINER_ROXANNE_1" => "\n call gym_number_0", [INFO] [stdout] 186 + "TRAINER_BRAWLY_1" => "\n call gym_number_1", [INFO] [stdout] 187 + "TRAINER_WATTSON_1" => "\n call gym_number_2", [INFO] [stdout] 188 + "TRAINER_FLANNERY_1" => "\n call gym_number_3", [INFO] [stdout] 189 + "TRAINER_NORMAN_1" => "\n call gym_number_4", [INFO] [stdout] 190 + "TRAINER_WINONA_1" => "\n call gym_number_5", [INFO] [stdout] 191 + "TRAINER_TATE_AND_LIZA_1" => "\n call gym_number_6", [INFO] [stdout] 192 + "TRAINER_JUAN_1" => "\n call gym_number_7", [INFO] [stdout] 193 + _ => "" [INFO] [stdout] 194 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/src/gen3/startup.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | / Command::new("sh") [INFO] [stdout] 46 | | .arg("-C") [INFO] [stdout] 47 | | .arg(format!("{}/{}",path.display(),make_rom_path)) [INFO] [stdout] 48 | | .arg(settings.seed.clone()) [INFO] [stdout] 49 | | .spawn() [INFO] [stdout] 50 | | .expect("sh command failed to start"); [INFO] [stdout] | | ^- help: try: `.wait()` [INFO] [stdout] | |_________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAUROSPALDEANCOMBATBREED` contains a capitalized acronym [INFO] [stdout] --> src/src/pokemon.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | TAUROSPALDEANCOMBATBREED, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Taurospaldeancombatbreed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAUROSPALDEANBLAZEBREED` contains a capitalized acronym [INFO] [stdout] --> src/src/pokemon.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 187 | TAUROSPALDEANBLAZEBREED, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Taurospaldeanblazebreed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAUROSPALDEANAQUABREED` contains a capitalized acronym [INFO] [stdout] --> src/src/pokemon.rs:188:5 [INFO] [stdout] | [INFO] [stdout] 188 | TAUROSPALDEANAQUABREED, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Taurospaldeanaquabreed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WOOPERPALDEAN` contains a capitalized acronym [INFO] [stdout] --> src/src/pokemon.rs:264:5 [INFO] [stdout] | [INFO] [stdout] 264 | WOOPERPALDEAN, [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Wooperpaldean` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:552:9 [INFO] [stdout] | [INFO] [stdout] 552 | let mut fake_starter_trainer = Trainer{ [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/src/gen3/frlg/static_pokemon.rs:4:33 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn randomize_static_pokemon(settings: &mut settings::Settings,pokemon_data: &Vec,rival: &Vec src/src/gen3/frlg/static_pokemon.rs:4:67 [INFO] [stdout] | [INFO] [stdout] 4 | ...t settings::Settings,pokemon_data: &Vec,rival: &Vec>){ [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pokemon_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rival` [INFO] [stdout] --> src/src/gen3/frlg/static_pokemon.rs:4:109 [INFO] [stdout] | [INFO] [stdout] 4 | ...&Vec,rival: &Vec>){ [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_rival` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/trainers.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | let mut second_half_temp = "".to_string(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `second_half_temp` [INFO] [stdout] --> src/src/gen3/trainers.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | let mut second_half_temp = "".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_second_half_temp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/trainers.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | let mut formatted_name : String = if pokemon.held_items == ""{ [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:552:9 [INFO] [stdout] | [INFO] [stdout] 552 | let mut fake_starter_trainer = Trainer{ [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/src/gen3/trainers.rs:342:23 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn create_moveset(settings: &mut settings::Settings,pokemon: pokemon::Pokemon,level: i32,old_moveset: Vec) -> Vec{ [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/src/gen3/frlg/static_pokemon.rs:4:33 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn randomize_static_pokemon(settings: &mut settings::Settings,pokemon_data: &Vec,rival: &Vec src/src/gen3/frlg/static_pokemon.rs:4:67 [INFO] [stdout] | [INFO] [stdout] 4 | ...t settings::Settings,pokemon_data: &Vec,rival: &Vec>){ [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pokemon_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rival` [INFO] [stdout] --> src/src/gen3/frlg/static_pokemon.rs:4:109 [INFO] [stdout] | [INFO] [stdout] 4 | ...&Vec,rival: &Vec>){ [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_rival` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pokemon` [INFO] [stdout] --> src/src/gen3/trainers.rs:342:57 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn create_moveset(settings: &mut settings::Settings,pokemon: pokemon::Pokemon,level: i32,old_moveset: Vec) -> Vec{ [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pokemon` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `level` [INFO] [stdout] --> src/src/gen3/trainers.rs:342:83 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn create_moveset(settings: &mut settings::Settings,pokemon: pokemon::Pokemon,level: i32,old_moveset: Vec) -> Vec{ [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_level` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `old_moveset` [INFO] [stdout] --> src/src/gen3/trainers.rs:342:94 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn create_moveset(settings: &mut settings::Settings,pokemon: pokemon::Pokemon,level: i32,old_moveset: Vec) -> Vec{ [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_old_moveset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/pokemon.rs:1232:5 [INFO] [stdout] | [INFO] [stdout] 1232 | return format!("SPECIES_{}",pkmn_name.to_uppercase()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1232 - return format!("SPECIES_{}",pkmn_name.to_uppercase()); [INFO] [stdout] 1232 + format!("SPECIES_{}",pkmn_name.to_uppercase()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/src/pokemon.rs:1234:54 [INFO] [stdout] | [INFO] [stdout] 1234 | pub fn get_pokemon_data(pokemon: Pokemon, all_stats: &Vec) -> PokemonStats{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1234 - pub fn get_pokemon_data(pokemon: Pokemon, all_stats: &Vec) -> PokemonStats{ [INFO] [stdout] 1234 + pub fn get_pokemon_data(pokemon: Pokemon, all_stats: &[PokemonStats]) -> PokemonStats{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/pokemon.rs:1238:5 [INFO] [stdout] | [INFO] [stdout] 1238 | return format_pokemon_name(get_pokemon_data(pkmn,all_stats).pokemon_name); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1238 - return format_pokemon_name(get_pokemon_data(pkmn,all_stats).pokemon_name); [INFO] [stdout] 1238 + format_pokemon_name(get_pokemon_data(pkmn,all_stats).pokemon_name) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/src/pokemon.rs:1240:57 [INFO] [stdout] | [INFO] [stdout] 1240 | pub fn get_pokemon_data_integer(pokemon: i32,all_stats: &Vec) -> PokemonStats{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1240 - pub fn get_pokemon_data_integer(pokemon: i32,all_stats: &Vec) -> PokemonStats{ [INFO] [stdout] 1240 + pub fn get_pokemon_data_integer(pokemon: i32,all_stats: &[PokemonStats]) -> PokemonStats{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/pokemon.rs:1256:5 [INFO] [stdout] | [INFO] [stdout] 1256 | return Pokemon::None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1256 - return Pokemon::None; [INFO] [stdout] 1256 + Pokemon::None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/src/pokemon.rs:1243:62 [INFO] [stdout] | [INFO] [stdout] 1243 | pub fn get_pokemon_from_name(pokemon_name: String,all_stats: &Vec) -> Pokemon{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1243 - pub fn get_pokemon_from_name(pokemon_name: String,all_stats: &Vec) -> Pokemon{ [INFO] [stdout] 1243 + pub fn get_pokemon_from_name(pokemon_name: String,all_stats: &[PokemonStats]) -> Pokemon{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/src/pokemon.rs:1245:8 [INFO] [stdout] | [INFO] [stdout] 1245 | if pokemon_name == ""{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pokemon_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `all_stats` [INFO] [stdout] --> src/src/pokemon.rs:1248:14 [INFO] [stdout] | [INFO] [stdout] 1248 | for i in 0..all_stats.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1248 - for i in 0..all_stats.len() { [INFO] [stdout] 1248 + for in &all_stats { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `cur_num` is used as a loop counter [INFO] [stdout] --> src/src/pokemon.rs:1264:5 [INFO] [stdout] | [INFO] [stdout] 1264 | for cur_pokemon in reader.records(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (cur_num, cur_pokemon) in reader.records().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/pokemon.rs:1271:48 [INFO] [stdout] | [INFO] [stdout] 1271 | let min_level = if min_level_string == "Other".to_string() || min_level_string == "Mega".to_string(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"Other"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/pokemon.rs:1271:91 [INFO] [stdout] | [INFO] [stdout] 1271 | let min_level = if min_level_string == "Other".to_string() || min_level_string == "Mega".to_string(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"Mega"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/src/pokemon.rs:1280:16 [INFO] [stdout] | [INFO] [stdout] 1280 | if next_pkmn == ""{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `next_pkmn.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/pokemon.rs:1370:5 [INFO] [stdout] | [INFO] [stdout] 1370 | / return match species{ [INFO] [stdout] 1371 | | Pokemon::Pikachu => get_random_name_from_list_with_prefered(settings,vec![ [INFO] [stdout] 1372 | | "PIKACHU".to_string(), [INFO] [stdout] 1373 | | "PIKACHU_COSPLAY".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 1680 | | _ => "".to_string() [INFO] [stdout] 1681 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1370 ~ match species{ [INFO] [stdout] 1371 + Pokemon::Pikachu => get_random_name_from_list_with_prefered(settings,vec![ [INFO] [stdout] 1372 + "PIKACHU".to_string(), [INFO] [stdout] 1373 + "PIKACHU_COSPLAY".to_string(), [INFO] [stdout] 1374 + "PIKACHU_ROCK_STAR".to_string(), [INFO] [stdout] 1375 + "PIKACHU_BELLE".to_string(), [INFO] [stdout] 1376 + "PIKACHU_POP_STAR".to_string(), [INFO] [stdout] 1377 + "PIKACHU_PH_D".to_string(), [INFO] [stdout] 1378 + "PIKACHU_LIBRE".to_string(), [INFO] [stdout] 1379 + "PIKACHU_ORIGINAL".to_string(), [INFO] [stdout] 1380 + "PIKACHU_HOENN".to_string(), [INFO] [stdout] 1381 + "PIKACHU_SINNOH".to_string(), [INFO] [stdout] 1382 + "PIKACHU_UNOVA".to_string(), [INFO] [stdout] 1383 + "PIKACHU_KALOS".to_string(), [INFO] [stdout] 1384 + "PIKACHU_ALOLA".to_string(), [INFO] [stdout] 1385 + "PIKACHU_PARTNER".to_string(), [INFO] [stdout] 1386 + "PIKACHU_WORLD".to_string()],0), [INFO] [stdout] 1387 + Pokemon::Unown => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1388 + "UNOWN".to_string(), [INFO] [stdout] 1389 + "UNOWN_B".to_string(), [INFO] [stdout] 1390 + "UNOWN_C".to_string(), [INFO] [stdout] 1391 + "UNOWN_D".to_string(), [INFO] [stdout] 1392 + "UNOWN_E".to_string(), [INFO] [stdout] 1393 + "UNOWN_F".to_string(), [INFO] [stdout] 1394 + "UNOWN_G".to_string(), [INFO] [stdout] 1395 + "UNOWN_H".to_string(), [INFO] [stdout] 1396 + "UNOWN_I".to_string(), [INFO] [stdout] 1397 + "UNOWN_J".to_string(), [INFO] [stdout] 1398 + "UNOWN_K".to_string(), [INFO] [stdout] 1399 + "UNOWN_L".to_string(), [INFO] [stdout] 1400 + "UNOWN_M".to_string(), [INFO] [stdout] 1401 + "UNOWN_N".to_string(), [INFO] [stdout] 1402 + "UNOWN_O".to_string(), [INFO] [stdout] 1403 + "UNOWN_P".to_string(), [INFO] [stdout] 1404 + "UNOWN_Q".to_string(), [INFO] [stdout] 1405 + "UNOWN_R".to_string(), [INFO] [stdout] 1406 + "UNOWN_S".to_string(), [INFO] [stdout] 1407 + "UNOWN_T".to_string(), [INFO] [stdout] 1408 + "UNOWN_U".to_string(), [INFO] [stdout] 1409 + "UNOWN_V".to_string(), [INFO] [stdout] 1410 + "UNOWN_W".to_string(), [INFO] [stdout] 1411 + "UNOWN_X".to_string(), [INFO] [stdout] 1412 + "UNOWN_Y".to_string(), [INFO] [stdout] 1413 + "UNOWN_Z".to_string(), [INFO] [stdout] 1414 + "UNOWN_EMARK".to_string(), [INFO] [stdout] 1415 + "UNOWN_QMARK".to_string() [INFO] [stdout] 1416 + ]), [INFO] [stdout] 1417 + Pokemon::Deoxys => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1418 + "DEOXYS_NORMAL".to_string(), [INFO] [stdout] 1419 + "DEOXYS_ATTACK".to_string(), [INFO] [stdout] 1420 + "DEOXYS_DEFENSE".to_string(), [INFO] [stdout] 1421 + "DEOXYS_SPEED".to_string() [INFO] [stdout] 1422 + ]), [INFO] [stdout] 1423 + Pokemon::Burmy => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1424 + "BURMY_PLANT".to_string(), [INFO] [stdout] 1425 + "BURMY_SANDY".to_string(), [INFO] [stdout] 1426 + "BURMY_TRASH".to_string() [INFO] [stdout] 1427 + ]), [INFO] [stdout] 1428 + Pokemon::Wormadam => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1429 + "WORMADAM_PLANT".to_string(), [INFO] [stdout] 1430 + "WORMADAM_SANDY".to_string(), [INFO] [stdout] 1431 + "WORMADAM_TRASH".to_string() [INFO] [stdout] 1432 + ]), [INFO] [stdout] 1433 + Pokemon::Mothim => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1434 + "MOTHIM_PLANT".to_string(), [INFO] [stdout] 1435 + "MOTHIM_SANDY".to_string(), [INFO] [stdout] 1436 + "MOTHIM_TRASH".to_string() [INFO] [stdout] 1437 + ]), [INFO] [stdout] 1438 + Pokemon::Shellos => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1439 + "SHELLOS_EAST".to_string(), [INFO] [stdout] 1440 + "SHELLOS_WEST".to_string() [INFO] [stdout] 1441 + ]), [INFO] [stdout] 1442 + Pokemon::Gastrodon => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1443 + "GASTRODON_EAST".to_string(), [INFO] [stdout] 1444 + "GASTRODON_WEST".to_string() [INFO] [stdout] 1445 + ]), [INFO] [stdout] 1446 + Pokemon::Shaymin => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1447 + "SHAYMIN_SKY".to_string(), [INFO] [stdout] 1448 + "SHAYMIN_LAND".to_string() [INFO] [stdout] 1449 + ]), [INFO] [stdout] 1450 + Pokemon::Basculin => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1451 + "BASCULIN_RED_STRIPED".to_string(), [INFO] [stdout] 1452 + "BASCULIN_BLUE_STRIPED".to_string(), [INFO] [stdout] 1453 + "BASCULIN_WHITE_STRIPED".to_string() [INFO] [stdout] 1454 + ]), [INFO] [stdout] 1455 + Pokemon::Deerling => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1456 + "DEERLING_SPRING".to_string(), [INFO] [stdout] 1457 + "DEERLING_SUMMER".to_string(), [INFO] [stdout] 1458 + "DEERLING_AUTUMN".to_string(), [INFO] [stdout] 1459 + "DEERLING_WINTER".to_string() [INFO] [stdout] 1460 + ]), [INFO] [stdout] 1461 + Pokemon::Sawsbuck => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1462 + "SAWSBUCK_SPRING".to_string(), [INFO] [stdout] 1463 + "SAWSBUCK_SUMMER".to_string(), [INFO] [stdout] 1464 + "SAWSBUCK_AUTUMN".to_string(), [INFO] [stdout] 1465 + "SAWSBUCK_WINTER".to_string() [INFO] [stdout] 1466 + ]), [INFO] [stdout] 1467 + Pokemon::Greninja => get_random_name_from_list_with_prefered(settings,vec![ [INFO] [stdout] 1468 + "GRENINJA".to_string(), [INFO] [stdout] 1469 + "GRENINJA_BATTLE_BOND".to_string() [INFO] [stdout] 1470 + ],0), [INFO] [stdout] 1471 + Pokemon::Vivillon => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1472 + "VIVILLON_ICY_SNOW".to_string(), [INFO] [stdout] 1473 + "VIVILLON_POLAR".to_string(), [INFO] [stdout] 1474 + "VIVILLON_TUNDRA".to_string(), [INFO] [stdout] 1475 + "VIVILLON_CONTINENTAL".to_string(), [INFO] [stdout] 1476 + "VIVILLON_GARDEN".to_string(), [INFO] [stdout] 1477 + "VIVILLON_ELEGANT".to_string(), [INFO] [stdout] 1478 + "VIVILLON_MEADOW".to_string(), [INFO] [stdout] 1479 + "VIVILLON_MODERN".to_string(), [INFO] [stdout] 1480 + "VIVILLON_MARINE".to_string(), [INFO] [stdout] 1481 + "VIVILLON_ARCHIPELAGO".to_string(), [INFO] [stdout] 1482 + "VIVILLON_HIGH_PLAINS".to_string(), [INFO] [stdout] 1483 + "VIVILLON_SANDSTORM".to_string(), [INFO] [stdout] 1484 + "VIVILLON_RIVER".to_string(), [INFO] [stdout] 1485 + "VIVILLON_MONSOON".to_string(), [INFO] [stdout] 1486 + "VIVILLON_SAVANNA".to_string(), [INFO] [stdout] 1487 + "VIVILLON_SUN".to_string(), [INFO] [stdout] 1488 + "VIVILLON_OCEAN".to_string(), [INFO] [stdout] 1489 + "VIVILLON_JUNGLE".to_string(), [INFO] [stdout] 1490 + "VIVILLON_FANCY".to_string(), [INFO] [stdout] 1491 + "VIVILLON_POKE_BALL".to_string() [INFO] [stdout] 1492 + ]), [INFO] [stdout] 1493 + Pokemon::Spewpa => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1494 + "SPEWPA_ICY_SNOW".to_string(), [INFO] [stdout] 1495 + "SPEWPA_POLAR".to_string(), [INFO] [stdout] 1496 + "SPEWPA_TUNDRA".to_string(), [INFO] [stdout] 1497 + "SPEWPA_CONTINENTAL".to_string(), [INFO] [stdout] 1498 + "SPEWPA_GARDEN".to_string(), [INFO] [stdout] 1499 + "SPEWPA_ELEGANT".to_string(), [INFO] [stdout] 1500 + "SPEWPA_MEADOW".to_string(), [INFO] [stdout] 1501 + "SPEWPA_MODERN".to_string(), [INFO] [stdout] 1502 + "SPEWPA_MARINE".to_string(), [INFO] [stdout] 1503 + "SPEWPA_ARCHIPELAGO".to_string(), [INFO] [stdout] 1504 + "SPEWPA_HIGH_PLAINS".to_string(), [INFO] [stdout] 1505 + "SPEWPA_SANDSTORM".to_string(), [INFO] [stdout] 1506 + "SPEWPA_RIVER".to_string(), [INFO] [stdout] 1507 + "SPEWPA_MONSOON".to_string(), [INFO] [stdout] 1508 + "SPEWPA_SAVANNA".to_string(), [INFO] [stdout] 1509 + "SPEWPA_SUN".to_string(), [INFO] [stdout] 1510 + "SPEWPA_OCEAN".to_string(), [INFO] [stdout] 1511 + "SPEWPA_JUNGLE".to_string(), [INFO] [stdout] 1512 + "SPEWPA_FANCY".to_string(), [INFO] [stdout] 1513 + "SPEWPA_POKE_BALL".to_string() [INFO] [stdout] 1514 + ]), [INFO] [stdout] 1515 + Pokemon::Scatterbug => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1516 + "SCATTERBUG_ICY_SNOW".to_string(), [INFO] [stdout] 1517 + "SCATTERBUG_POLAR".to_string(), [INFO] [stdout] 1518 + "SCATTERBUG_TUNDRA".to_string(), [INFO] [stdout] 1519 + "SCATTERBUG_CONTINENTAL".to_string(), [INFO] [stdout] 1520 + "SCATTERBUG_GARDEN".to_string(), [INFO] [stdout] 1521 + "SCATTERBUG_ELEGANT".to_string(), [INFO] [stdout] 1522 + "SCATTERBUG_MEADOW".to_string(), [INFO] [stdout] 1523 + "SCATTERBUG_MODERN".to_string(), [INFO] [stdout] 1524 + "SCATTERBUG_MARINE".to_string(), [INFO] [stdout] 1525 + "SCATTERBUG_ARCHIPELAGO".to_string(), [INFO] [stdout] 1526 + "SCATTERBUG_HIGH_PLAINS".to_string(), [INFO] [stdout] 1527 + "SCATTERBUG_SANDSTORM".to_string(), [INFO] [stdout] 1528 + "SCATTERBUG_RIVER".to_string(), [INFO] [stdout] 1529 + "SCATTERBUG_MONSOON".to_string(), [INFO] [stdout] 1530 + "SCATTERBUG_SAVANNA".to_string(), [INFO] [stdout] 1531 + "SCATTERBUG_SUN".to_string(), [INFO] [stdout] 1532 + "SCATTERBUG_OCEAN".to_string(), [INFO] [stdout] 1533 + "SCATTERBUG_JUNGLE".to_string(), [INFO] [stdout] 1534 + "SCATTERBUG_FANCY".to_string(), [INFO] [stdout] 1535 + "SCATTERBUG_POKE_BALL".to_string() [INFO] [stdout] 1536 + ]), [INFO] [stdout] 1537 + Pokemon::Flabebe => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1538 + "FLABEBE_RED".to_string(), [INFO] [stdout] 1539 + "FLABEBE_YELLOW".to_string(), [INFO] [stdout] 1540 + "FLABEBE_ORANGE".to_string(), [INFO] [stdout] 1541 + "FLABEBE_BLUE".to_string(), [INFO] [stdout] 1542 + "FLABEBE_WHITE".to_string() [INFO] [stdout] 1543 + ]), [INFO] [stdout] 1544 + Pokemon::Floette => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1545 + "FLOETTE_RED".to_string(), [INFO] [stdout] 1546 + "FLOETTE_YELLOW".to_string(), [INFO] [stdout] 1547 + "FLOETTE_ORANGE".to_string(), [INFO] [stdout] 1548 + "FLOETTE_BLUE".to_string(), [INFO] [stdout] 1549 + "FLOETTE_WHITE".to_string(), [INFO] [stdout] 1550 + "FLOETTE_ETERNAL".to_string() [INFO] [stdout] 1551 + ]), [INFO] [stdout] 1552 + Pokemon::Florges => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1553 + "FLORGES_RED".to_string(), [INFO] [stdout] 1554 + "FLORGES_YELLOW".to_string(), [INFO] [stdout] 1555 + "FLORGES_ORANGE".to_string(), [INFO] [stdout] 1556 + "FLORGES_BLUE".to_string(), [INFO] [stdout] 1557 + "FLORGES_WHITE".to_string() [INFO] [stdout] 1558 + ]), [INFO] [stdout] 1559 + Pokemon::Furfrou => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1560 + "FURFROU_NATURAL".to_string(), [INFO] [stdout] 1561 + "FURFROU_HEART".to_string(), [INFO] [stdout] 1562 + "FURFROU_STAR_T".to_string(), [INFO] [stdout] 1563 + "FURFROU_DIAMOND".to_string(), [INFO] [stdout] 1564 + "FURFROU_DEBUTANTE".to_string(), [INFO] [stdout] 1565 + "FURFROU_MATRON".to_string(), [INFO] [stdout] 1566 + "FURFROU_DANDY".to_string(), [INFO] [stdout] 1567 + "FURFROU_LA_REINE".to_string(), [INFO] [stdout] 1568 + "FURFROU_KABUKI".to_string(), [INFO] [stdout] 1569 + "FURFROU_PHARAOH".to_string() [INFO] [stdout] 1570 + ]), [INFO] [stdout] 1571 + Pokemon::Pumpkaboo => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1572 + "PUMPKABOO_SMALL".to_string(), [INFO] [stdout] 1573 + "PUMPKABOO_AVERAGE".to_string(), [INFO] [stdout] 1574 + "PUMPKABOO_LARGE".to_string(), [INFO] [stdout] 1575 + "PUMPKABOO_SUPER".to_string() [INFO] [stdout] 1576 + ]), [INFO] [stdout] 1577 + Pokemon::Gourgeist => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1578 + "GOURGEIST_SMALL".to_string(), [INFO] [stdout] 1579 + "GOURGEIST_AVERAGE".to_string(), [INFO] [stdout] 1580 + "GOURGEIST_LARGE".to_string(), [INFO] [stdout] 1581 + "GOURGEIST_SUPER".to_string() [INFO] [stdout] 1582 + ]), [INFO] [stdout] 1583 + Pokemon::Zygarde10 => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1584 + "ZYGARDE_10_AURA_BREAK".to_string(), [INFO] [stdout] 1585 + "ZYGARDE_10_POWER_CONSTRUCT".to_string() [INFO] [stdout] 1586 + ]), [INFO] [stdout] 1587 + Pokemon::Zygarde => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1588 + "ZYGARDE_50_AURA_BREAK".to_string(), [INFO] [stdout] 1589 + "ZYGARDE_50_POWER_CONSTRUCT".to_string() [INFO] [stdout] 1590 + ]), [INFO] [stdout] 1591 + Pokemon::Rockruff => get_random_name_from_list_with_prefered(settings,vec![ [INFO] [stdout] 1592 + "ROCKRUFF".to_string(), [INFO] [stdout] 1593 + "ROCKRUFF_OWN_TEMPO".to_string() [INFO] [stdout] 1594 + ],0), [INFO] [stdout] 1595 + Pokemon::Lycanroc => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1596 + "LYCANROC_MIDNIGHT".to_string(), [INFO] [stdout] 1597 + "LYCANROC_DUSK".to_string() [INFO] [stdout] 1598 + ]), [INFO] [stdout] 1599 + Pokemon::Minior => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1600 + "MINIOR_ORANGE".to_string(), [INFO] [stdout] 1601 + "MINIOR_YELLOW".to_string(), [INFO] [stdout] 1602 + "MINIOR_GREEN".to_string(), [INFO] [stdout] 1603 + "MINIOR_BLUE".to_string(), [INFO] [stdout] 1604 + "MINIOR_INDIGO".to_string(), [INFO] [stdout] 1605 + "MINIOR_VIOLET".to_string() [INFO] [stdout] 1606 + ]), [INFO] [stdout] 1607 + Pokemon::Magearna => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1608 + "MAGEARNA".to_string(), [INFO] [stdout] 1609 + "MAGEARNA_ORIGINAL_COLOR".to_string() [INFO] [stdout] 1610 + ]), [INFO] [stdout] 1611 + Pokemon::Toxtricity => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1612 + "TOXTRICITY_AMPED".to_string(), [INFO] [stdout] 1613 + "TOXTRICITY_LOW_KEY".to_string() [INFO] [stdout] 1614 + ]), [INFO] [stdout] 1615 + Pokemon::Sinistea => get_random_name_from_list_with_prefered(settings,vec![ [INFO] [stdout] 1616 + "SINISTEA_PHONY".to_string(), [INFO] [stdout] 1617 + "SINISTEA_ANTIQUE".to_string() [INFO] [stdout] 1618 + ],0), [INFO] [stdout] 1619 + Pokemon::Polteageist => get_random_name_from_list_with_prefered(settings,vec![ [INFO] [stdout] 1620 + "POLTEAGEIST_PHONY".to_string(), [INFO] [stdout] 1621 + "POLTEAGEIST_ANTIQUE".to_string() [INFO] [stdout] 1622 + ],0), [INFO] [stdout] 1623 + Pokemon::Alcremie => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1624 + "ALCREMIE_RUBY_CREAM".to_string(), [INFO] [stdout] 1625 + "ALCREMIE_MATCHA_CREAM".to_string(), [INFO] [stdout] 1626 + "ALCREMIE_MINT_CREAM".to_string(), [INFO] [stdout] 1627 + "ALCREMIE_LEMON_CREAM".to_string(), [INFO] [stdout] 1628 + "ALCREMIE_SALTED_CREAM".to_string(), [INFO] [stdout] 1629 + "ALCREMIE_RUBY_SWIRL".to_string(), [INFO] [stdout] 1630 + "ALCREMIE_CARAMEL_SWIRL".to_string(), [INFO] [stdout] 1631 + "ALCREMIE_RAINBOW_SWIRL".to_string(), [INFO] [stdout] 1632 + "ALCREMIE_STRAWBERRY_RUBY_CREAM".to_string(), [INFO] [stdout] 1633 + "ALCREMIE_STRAWBERRY_MATCHA_CREAM".to_string(), [INFO] [stdout] 1634 + "ALCREMIE_STRAWBERRY_MINT_CREAM".to_string(), [INFO] [stdout] 1635 + "ALCREMIE_STRAWBERRY_LEMON_CREAM".to_string(), [INFO] [stdout] 1636 + "ALCREMIE_STRAWBERRY_SALTED_CREAM".to_string(), [INFO] [stdout] 1637 + "ALCREMIE_STRAWBERRY_RUBY_SWIRL".to_string(), [INFO] [stdout] 1638 + "ALCREMIE_STRAWBERRY_CARAMEL_SWIRL".to_string(), [INFO] [stdout] 1639 + "ALCREMIE_STRAWBERRY_RAINBOW_SWIRL".to_string() [INFO] [stdout] 1640 + ]), [INFO] [stdout] 1641 + Pokemon::Zarude => get_random_name_from_list_with_prefered(settings,vec![ [INFO] [stdout] 1642 + "ZARUDE".to_string(), [INFO] [stdout] 1643 + "ZARUDE_DADA".to_string() [INFO] [stdout] 1644 + ],0), [INFO] [stdout] 1645 + Pokemon::Ursaluna => get_random_name_from_list_with_prefered(settings,vec![ [INFO] [stdout] 1646 + "URSALUNA".to_string(), [INFO] [stdout] 1647 + "URSALUNA_BLOODMOON".to_string() [INFO] [stdout] 1648 + ],0), [INFO] [stdout] 1649 + Pokemon::Maushold => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1650 + "MAUSHOLD_THREE".to_string(), [INFO] [stdout] 1651 + "MAUSHOLD_FOUR".to_string() [INFO] [stdout] 1652 + ]), [INFO] [stdout] 1653 + Pokemon::Squawkabilly => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1654 + "SQUAWKABILLY_GREEN".to_string(), [INFO] [stdout] 1655 + "SQUAWKABILLY_BLUE".to_string(), [INFO] [stdout] 1656 + "SQUAWKABILLY_YELLOW".to_string(), [INFO] [stdout] 1657 + "SQUAWKABILLY_WHITE".to_string() [INFO] [stdout] 1658 + ]), [INFO] [stdout] 1659 + Pokemon::Tatsugiri => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1660 + "TATSUGIRI_CURLY".to_string(), [INFO] [stdout] 1661 + "TATSUGIRI_DROOPY".to_string(), [INFO] [stdout] 1662 + "TATSUGIRI_STRETCHY".to_string() [INFO] [stdout] 1663 + ]), [INFO] [stdout] 1664 + Pokemon::Dudunsparce => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1665 + "DUDUNSPARCE_TWO_SEGMENT".to_string(), [INFO] [stdout] 1666 + "DUDUNSPARCE_THREE_SEGMENT".to_string() [INFO] [stdout] 1667 + ]), [INFO] [stdout] 1668 + Pokemon::Gimmighoul => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1669 + "GIMMIGHOUL_CHEST".to_string(), [INFO] [stdout] 1670 + "GIMMIGHOUL_ROAMING".to_string() [INFO] [stdout] 1671 + ]), [INFO] [stdout] 1672 + Pokemon::Poltchageist => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1673 + "POLTCHAGEIST_COUNTERFEIT".to_string(), [INFO] [stdout] 1674 + "POLTCHAGEIST_ARTISAN".to_string() [INFO] [stdout] 1675 + ]), [INFO] [stdout] 1676 + Pokemon::Sinistcha => get_random_name_from_list(settings,vec![ [INFO] [stdout] 1677 + "SINISTCHA_UNREMARKABLE".to_string(), [INFO] [stdout] 1678 + "SINISTCHA_MASTERPIECE".to_string() [INFO] [stdout] 1679 + ]), [INFO] [stdout] 1680 + _ => "".to_string() [INFO] [stdout] 1681 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/src/pokemon.rs:1369:60 [INFO] [stdout] | [INFO] [stdout] 1369 | pub fn pokemon_alternate_forms(species: Pokemon,all_stats: &Vec,settings: &mut settings::Settings) -> String{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1369 - pub fn pokemon_alternate_forms(species: Pokemon,all_stats: &Vec,settings: &mut settings::Settings) -> String{ [INFO] [stdout] 1369 + pub fn pokemon_alternate_forms(species: Pokemon,all_stats: &[PokemonStats],settings: &mut settings::Settings) -> String{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/src/gen3/evolution_changes.rs:2:30 [INFO] [stdout] | [INFO] [stdout] 2 | pub fn setup_evolution_fixes(settings: &settings::Settings){ [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/pokemon.rs:1686:5 [INFO] [stdout] | [INFO] [stdout] 1686 | return list_of_names[index as usize].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1686 - return list_of_names[index as usize].clone(); [INFO] [stdout] 1686 + list_of_names[index as usize].clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/pokemon.rs:1692:5 [INFO] [stdout] | [INFO] [stdout] 1692 | return get_random_name_from_list(settings,list_of_names); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1692 - return get_random_name_from_list(settings,list_of_names); [INFO] [stdout] 1692 + get_random_name_from_list(settings,list_of_names) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Legendary` [INFO] [stdout] --> src/src/settings.rs:75:1 [INFO] [stdout] | [INFO] [stdout] 75 | / pub enum LegendRarity{ [INFO] [stdout] 76 | | AlwaysLegendary, [INFO] [stdout] 77 | | SometimesLegendary,//Will allow it to be legendary, but wont force it [INFO] [stdout] 78 | | LikelyLegendary,//Will ignore 1 in 100 non-legendaries, and will try to force a pokemon to be legendary, but can fail [INFO] [stdout] 79 | | NotLegendary [INFO] [stdout] 80 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Legends` [INFO] [stdout] --> src/src/settings.rs:91:1 [INFO] [stdout] | [INFO] [stdout] 91 | / pub enum WildLegends{ [INFO] [stdout] 92 | | NoLegends, //Or Always Legends [INFO] [stdout] 93 | | SometimesLegends, //Tries not to have legends, but sometimes fails [INFO] [stdout] 94 | | AllowLegends //Allows Legends in same pool as regular pokemon [INFO] [stdout] 95 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/trainers.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | let mut second_half_temp = "".to_string(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `second_half_temp` [INFO] [stdout] --> src/src/gen3/trainers.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | let mut second_half_temp = "".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_second_half_temp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/trainers.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | let mut formatted_name : String = if pokemon.held_items == ""{ [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/settings.rs:188:5 [INFO] [stdout] | [INFO] [stdout] 188 | / return match string.as_str() { [INFO] [stdout] 189 | | "Emerald" => Game::Emerald, [INFO] [stdout] 190 | | "FireRed" => Game::FrLg, [INFO] [stdout] 191 | | "LeafGreen" => Game::FrLg, [INFO] [stdout] 192 | | _ => Game::Emerald [INFO] [stdout] 193 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 188 ~ match string.as_str() { [INFO] [stdout] 189 + "Emerald" => Game::Emerald, [INFO] [stdout] 190 + "FireRed" => Game::FrLg, [INFO] [stdout] 191 + "LeafGreen" => Game::FrLg, [INFO] [stdout] 192 + _ => Game::Emerald [INFO] [stdout] 193 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/settings.rs:251:5 [INFO] [stdout] | [INFO] [stdout] 251 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 251 - return result; [INFO] [stdout] 251 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `result` [INFO] [stdout] --> src/src/settings.rs:244:14 [INFO] [stdout] | [INFO] [stdout] 244 | for i in 0..32{ [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 244 - for i in 0..32{ [INFO] [stdout] 244 + for in &mut result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/item_randomization.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | let mut all_items = randomize_vector_item(settings,&mut all_item_locations.clone()); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `added` is never read [INFO] [stdout] --> src/src/gen3/item_randomization.rs:127:21 [INFO] [stdout] | [INFO] [stdout] 127 | let mut added = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | / return match settings.game{ [INFO] [stdout] 55 | | settings::Game::Emerald => starter_randomization::randomize_starter_pokemon(settings,pkmn_data,"data/gen3/emerald/starter_... [INFO] [stdout] 56 | | settings::Game::FrLg => starter_randomization::randomize_starter_pokemon(settings,pkmn_data,"data/gen3/firered/field_speci... [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 ~ match settings.game{ [INFO] [stdout] 55 + settings::Game::Emerald => starter_randomization::randomize_starter_pokemon(settings,pkmn_data,"data/gen3/emerald/starter_choose.c".to_string(),"data/gen3/emerald/starter_choose_2.c".to_string(),"decomp/pokeemerald-expansion/src/starter_choose.c".to_string()), [INFO] [stdout] 56 + settings::Game::FrLg => starter_randomization::randomize_starter_pokemon(settings,pkmn_data,"data/gen3/firered/field_special.c".to_string(),"data/gen3/firered/field_special2.c".to_string(),"decomp/pokefirered/src/field_specials.c".to_string()) [INFO] [stdout] 57 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | / return match settings.game{ [INFO] [stdout] 62 | | settings::Game::Emerald => trainers::shuffle_trainers(settings,&pkmn_data,"data/gen3/emerald/trainers.txt".to_string(),"de... [INFO] [stdout] 63 | | settings::Game::FrLg => trainers::shuffle_trainers(settings,&pkmn_data,"data/gen3/firered/trainers.party".to_string(),"dec... [INFO] [stdout] 64 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ match settings.game{ [INFO] [stdout] 62 + settings::Game::Emerald => trainers::shuffle_trainers(settings,&pkmn_data,"data/gen3/emerald/trainers.txt".to_string(),"decomp/pokeemerald-expansion/src/data/trainers.party".to_string(),starters), [INFO] [stdout] 63 + settings::Game::FrLg => trainers::shuffle_trainers(settings,&pkmn_data,"data/gen3/firered/trainers.party".to_string(),"decomp/pokefirered/src/data/trainers.party".to_string(),starters) [INFO] [stdout] 64 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/src/game_chooser.rs:62:72 [INFO] [stdout] | [INFO] [stdout] 62 | ... settings::Game::Emerald => trainers::shuffle_trainers(settings,&pkmn_data,"data/gen3/emerald/trainers.txt".to_string(),"decomp... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `pkmn_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/src/game_chooser.rs:63:69 [INFO] [stdout] | [INFO] [stdout] 63 | ... settings::Game::FrLg => trainers::shuffle_trainers(settings,&pkmn_data,"data/gen3/firered/trainers.party".to_string(),"decomp/... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `pkmn_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/src/gen3/trainers.rs:342:23 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn create_moveset(settings: &mut settings::Settings,pokemon: pokemon::Pokemon,level: i32,old_moveset: Vec) -> Vec{ [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pokemon` [INFO] [stdout] --> src/src/gen3/trainers.rs:342:57 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn create_moveset(settings: &mut settings::Settings,pokemon: pokemon::Pokemon,level: i32,old_moveset: Vec) -> Vec{ [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pokemon` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `level` [INFO] [stdout] --> src/src/gen3/trainers.rs:342:83 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn create_moveset(settings: &mut settings::Settings,pokemon: pokemon::Pokemon,level: i32,old_moveset: Vec) -> Vec{ [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_level` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `old_moveset` [INFO] [stdout] --> src/src/gen3/trainers.rs:342:94 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn create_moveset(settings: &mut settings::Settings,pokemon: pokemon::Pokemon,level: i32,old_moveset: Vec) -> Vec{ [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_old_moveset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | / return match settings.game{ [INFO] [stdout] 89 | | settings::Game::Emerald => emerald::special_trainers::check_if_special_trainer(trainer), [INFO] [stdout] 90 | | settings::Game::FrLg => frlg::special_trainers::check_if_special_trainer(trainer) [INFO] [stdout] 91 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 ~ match settings.game{ [INFO] [stdout] 89 + settings::Game::Emerald => emerald::special_trainers::check_if_special_trainer(trainer), [INFO] [stdout] 90 + settings::Game::FrLg => frlg::special_trainers::check_if_special_trainer(trainer) [INFO] [stdout] 91 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | / return match settings.game{ [INFO] [stdout] 97 | | settings::Game::Emerald => emerald::special_trainers::handle_special_trainer(trainer,settings,all_stats,starters,rivals,gy... [INFO] [stdout] 98 | | settings::Game::FrLg => frlg::special_trainers::handle_special_trainer(trainer,settings,all_stats,starters,rivals,gym_type... [INFO] [stdout] 99 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 ~ match settings.game{ [INFO] [stdout] 97 + settings::Game::Emerald => emerald::special_trainers::handle_special_trainer(trainer,settings,all_stats,starters,rivals,gym_types,elite_4_types), [INFO] [stdout] 98 + settings::Game::FrLg => frlg::special_trainers::handle_special_trainer(trainer,settings,all_stats,starters,rivals,gym_types,elite_4_types) [INFO] [stdout] 99 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | / return match settings.game{ [INFO] [stdout] 104 | | settings::Game::Emerald => emerald::startup_stuff::get_startup_stuff(settings), [INFO] [stdout] 105 | | settings::Game::FrLg => frlg::startup_stuff::get_startup_stuff(settings) [INFO] [stdout] 106 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 ~ match settings.game{ [INFO] [stdout] 104 + settings::Game::Emerald => emerald::startup_stuff::get_startup_stuff(settings), [INFO] [stdout] 105 + settings::Game::FrLg => frlg::startup_stuff::get_startup_stuff(settings) [INFO] [stdout] 106 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | / return match settings.game{ [INFO] [stdout] 111 | | settings::Game::Emerald => emerald::special_trainers::get_rivals(settings, all_stats), [INFO] [stdout] 112 | | settings::Game::FrLg => frlg::special_trainers::get_rivals(settings, all_stats) [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 ~ match settings.game{ [INFO] [stdout] 111 + settings::Game::Emerald => emerald::special_trainers::get_rivals(settings, all_stats), [INFO] [stdout] 112 + settings::Game::FrLg => frlg::special_trainers::get_rivals(settings, all_stats) [INFO] [stdout] 113 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | / return match settings.game{ [INFO] [stdout] 119 | | settings::Game::Emerald | settings::Game::FrLg => "data/gen3/pokemon.csv".to_string() [INFO] [stdout] 120 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 ~ match settings.game{ [INFO] [stdout] 119 + settings::Game::Emerald | settings::Game::FrLg => "data/gen3/pokemon.csv".to_string() [INFO] [stdout] 120 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | / return match settings.game{ [INFO] [stdout] 125 | | settings::Game::Emerald => "data/gen3/emerald/wild_encounters.json".to_string(), [INFO] [stdout] 126 | | settings::Game::FrLg => "data/gen3/firered/wild_encounters.json".to_string() [INFO] [stdout] 127 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 ~ match settings.game{ [INFO] [stdout] 125 + settings::Game::Emerald => "data/gen3/emerald/wild_encounters.json".to_string(), [INFO] [stdout] 126 + settings::Game::FrLg => "data/gen3/firered/wild_encounters.json".to_string() [INFO] [stdout] 127 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | / return match settings.game{ [INFO] [stdout] 132 | | settings::Game::Emerald => "decomp/pokeemerald-expansion/src/data/wild_encounters.json".to_string(), [INFO] [stdout] 133 | | settings::Game::FrLg => "decomp/pokefirered/src/data/wild_encounters.json".to_string() [INFO] [stdout] 134 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 ~ match settings.game{ [INFO] [stdout] 132 + settings::Game::Emerald => "decomp/pokeemerald-expansion/src/data/wild_encounters.json".to_string(), [INFO] [stdout] 133 + settings::Game::FrLg => "decomp/pokefirered/src/data/wild_encounters.json".to_string() [INFO] [stdout] 134 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 138 | / return match settings.game{ [INFO] [stdout] 139 | | settings::Game::Emerald => "data/gen3/emerald/item_locations.csv".to_string(), [INFO] [stdout] 140 | | settings::Game::FrLg => "data/gen3/firered/item_locations.csv".to_string() [INFO] [stdout] 141 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 ~ match settings.game{ [INFO] [stdout] 139 + settings::Game::Emerald => "data/gen3/emerald/item_locations.csv".to_string(), [INFO] [stdout] 140 + settings::Game::FrLg => "data/gen3/firered/item_locations.csv".to_string() [INFO] [stdout] 141 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 145 | / return match settings.game{ [INFO] [stdout] 146 | | settings::Game::Emerald | settings::Game::FrLg => "data/gen3/items.json".to_string() [INFO] [stdout] 147 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 145 ~ match settings.game{ [INFO] [stdout] 146 + settings::Game::Emerald | settings::Game::FrLg => "data/gen3/items.json".to_string() [INFO] [stdout] 147 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | / return match settings.game{ [INFO] [stdout] 152 | | settings::Game::Emerald => "src/src/gen3/emerald/make_rom.sh".to_string(), [INFO] [stdout] 153 | | settings::Game::FrLg => "src/src/gen3/frlg/make_rom.sh".to_string() [INFO] [stdout] 154 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 ~ match settings.game{ [INFO] [stdout] 152 + settings::Game::Emerald => "src/src/gen3/emerald/make_rom.sh".to_string(), [INFO] [stdout] 153 + settings::Game::FrLg => "src/src/gen3/frlg/make_rom.sh".to_string() [INFO] [stdout] 154 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | / return match settings.game{ [INFO] [stdout] 158 | | settings::Game::Emerald => "decomp/pokeemerald-expansion/data/scripts/randomizer_scripts.inc".to_string(), [INFO] [stdout] 159 | | settings::Game::FrLg => "decomp/pokefirered/data/scripts/randomizer_scripts.inc".to_string(), [INFO] [stdout] 160 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 ~ match settings.game{ [INFO] [stdout] 158 + settings::Game::Emerald => "decomp/pokeemerald-expansion/data/scripts/randomizer_scripts.inc".to_string(), [INFO] [stdout] 159 + settings::Game::FrLg => "decomp/pokefirered/data/scripts/randomizer_scripts.inc".to_string(), [INFO] [stdout] 160 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:164:5 [INFO] [stdout] | [INFO] [stdout] 164 | / return match settings.game{ [INFO] [stdout] 165 | | settings::Game::Emerald => "decomp/pokeemerald-expansion/data/maps/**/*.json".to_string(), [INFO] [stdout] 166 | | settings::Game::FrLg => "decomp/pokefirered/data/maps/**/*.json".to_string() [INFO] [stdout] 167 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 ~ match settings.game{ [INFO] [stdout] 165 + settings::Game::Emerald => "decomp/pokeemerald-expansion/data/maps/**/*.json".to_string(), [INFO] [stdout] 166 + settings::Game::FrLg => "decomp/pokefirered/data/maps/**/*.json".to_string() [INFO] [stdout] 167 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:174:5 [INFO] [stdout] | [INFO] [stdout] 174 | / return match settings.game{ [INFO] [stdout] 175 | | settings::Game::Emerald | settings::Game::FrLg => 8 [INFO] [stdout] 176 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 174 ~ match settings.game{ [INFO] [stdout] 175 + settings::Game::Emerald | settings::Game::FrLg => 8 [INFO] [stdout] 176 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 181 | / return match settings.game{ [INFO] [stdout] 182 | | settings::Game::Emerald | settings::Game::FrLg => 5 [INFO] [stdout] 183 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 181 ~ match settings.game{ [INFO] [stdout] 182 + settings::Game::Emerald | settings::Game::FrLg => 5 [INFO] [stdout] 183 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 187 | / return match settings.game{ [INFO] [stdout] 188 | | settings::Game::Emerald => vec![15,19,24,29,31,33,42,46][num_gym as usize], [INFO] [stdout] 189 | | settings::Game::FrLg => vec![14,21,24,29,43,43,47,50][num_gym as usize] [INFO] [stdout] 190 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 187 ~ match settings.game{ [INFO] [stdout] 188 + settings::Game::Emerald => vec![15,19,24,29,31,33,42,46][num_gym as usize], [INFO] [stdout] 189 + settings::Game::FrLg => vec![14,21,24,29,43,43,47,50][num_gym as usize] [INFO] [stdout] 190 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:194:5 [INFO] [stdout] | [INFO] [stdout] 194 | / return match settings.game{ [INFO] [stdout] 195 | | settings::Game::Emerald => vec![pokemon::Type::Rock,pokemon::Type::Fighting,pokemon::Type::Electric,pokemon::Type::Fire,p... [INFO] [stdout] 196 | | settings::Game::FrLg => vec![pokemon::Type::Rock,pokemon::Type::Water,pokemon::Type::Electric,pokemon::Type::Grass,pokemo... [INFO] [stdout] 197 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 194 ~ match settings.game{ [INFO] [stdout] 195 + settings::Game::Emerald => vec![pokemon::Type::Rock,pokemon::Type::Fighting,pokemon::Type::Electric,pokemon::Type::Fire,pokemon::Type::Normal,pokemon::Type::Flying,pokemon::Type::Psychic,pokemon::Type::Water], [INFO] [stdout] 196 + settings::Game::FrLg => vec![pokemon::Type::Rock,pokemon::Type::Water,pokemon::Type::Electric,pokemon::Type::Grass,pokemon::Type::Poison,pokemon::Type::Psychic,pokemon::Type::Fire,pokemon::Type::Ground] [INFO] [stdout] 197 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/game_chooser.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | / return match settings.game{ [INFO] [stdout] 202 | | settings::Game::Emerald => vec![pokemon::Type::Dark,pokemon::Type::Ghost,pokemon::Type::Ice,pokemon::Type::Dragon,pokemon... [INFO] [stdout] 203 | | settings::Game::FrLg => vec![pokemon::Type::Ice,pokemon::Type::Fighting,pokemon::Type::Ghost,pokemon::Type::Dragon] [INFO] [stdout] 204 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 ~ match settings.game{ [INFO] [stdout] 202 + settings::Game::Emerald => vec![pokemon::Type::Dark,pokemon::Type::Ghost,pokemon::Type::Ice,pokemon::Type::Dragon,pokemon::Type::Water], [INFO] [stdout] 203 + settings::Game::FrLg => vec![pokemon::Type::Ice,pokemon::Type::Fighting,pokemon::Type::Ghost,pokemon::Type::Dragon] [INFO] [stdout] 204 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:552:9 [INFO] [stdout] | [INFO] [stdout] 552 | let mut fake_starter_trainer = Trainer{ [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/src/gen3/evolution_changes.rs:2:30 [INFO] [stdout] | [INFO] [stdout] 2 | pub fn setup_evolution_fixes(settings: &settings::Settings){ [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/src/gen3/frlg/static_pokemon.rs:4:33 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn randomize_static_pokemon(settings: &mut settings::Settings,pokemon_data: &Vec,rival: &Vec src/src/gen3/item_randomization.rs:316:9 [INFO] [stdout] | [INFO] [stdout] 316 | for i in 0..settings.add_rare_candy{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pokemon_data` [INFO] [stdout] --> src/src/gen3/frlg/static_pokemon.rs:4:67 [INFO] [stdout] | [INFO] [stdout] 4 | ...t settings::Settings,pokemon_data: &Vec,rival: &Vec>){ [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pokemon_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:319:9 [INFO] [stdout] | [INFO] [stdout] 319 | for i in 0..settings.add_pokeballs{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rival` [INFO] [stdout] --> src/src/gen3/frlg/static_pokemon.rs:4:109 [INFO] [stdout] | [INFO] [stdout] 4 | ...&Vec,rival: &Vec>){ [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_rival` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:331:13 [INFO] [stdout] | [INFO] [stdout] 331 | for i in 0..(settings.number_hms+1){ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:354:13 [INFO] [stdout] | [INFO] [stdout] 354 | for i in 0..6{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:359:13 [INFO] [stdout] | [INFO] [stdout] 359 | for i in 0..6{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:450:9 [INFO] [stdout] | [INFO] [stdout] 450 | for i in 0..data_temp.len(){ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/src/hint_system.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | fs::write(format!("out/{}/spoiler.txt",settings.seed),&settings.spoiler); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 11 | let _ = fs::write(format!("out/{}/spoiler.txt",settings.seed),&settings.spoiler); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/item_randomization.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | let mut all_items = randomize_vector_item(settings,&mut all_item_locations.clone()); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `added` is never read [INFO] [stdout] --> src/src/gen3/item_randomization.rs:127:21 [INFO] [stdout] | [INFO] [stdout] 127 | let mut added = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/src/gen3/logic.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn check_logic(settings: &mut settings::Settings,item_name: String, location_name: String, prereqs: Vec) -> bool{ [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `previous_areas` [INFO] [stdout] --> src/src/gen3/logic.rs:20:24 [INFO] [stdout] | [INFO] [stdout] 20 | fn check_area_for_item(previous_areas: Vec,item_name : String,location_name: String,requirements: Vec) -> bool{ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_previous_areas` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `requirements` [INFO] [stdout] --> src/src/gen3/logic.rs:20:93 [INFO] [stdout] | [INFO] [stdout] 20 | fn check_area_for_item(previous_areas: Vec,item_name : String,location_name: String,requirements: Vec) -> bool{ [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_requirements` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_connections` [INFO] [stdout] --> src/src/gen3/logic.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 30 | fn add_connection(all_connections : &mut Vec, current_location: String, previous_location: String, requirements: Vec src/src/gen3/logic.rs:30:60 [INFO] [stdout] | [INFO] [stdout] 30 | ...c, current_location: String, previous_location: String, requirements: Vec){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_location` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `previous_location` [INFO] [stdout] --> src/src/gen3/logic.rs:30:86 [INFO] [stdout] | [INFO] [stdout] 30 | ...ation: String, previous_location: String, requirements: Vec){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_previous_location` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `requirements` [INFO] [stdout] --> src/src/gen3/logic.rs:30:113 [INFO] [stdout] | [INFO] [stdout] 30 | ...s_location: String, requirements: Vec){ [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_requirements` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/logic.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let mut all_connections : Vec = Vec::new(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/trainers.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | let mut second_half_temp = "".to_string(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `second_half_temp` [INFO] [stdout] --> src/src/gen3/trainers.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | let mut second_half_temp = "".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_second_half_temp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/trainers.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | let mut formatted_name : String = if pokemon.held_items == ""{ [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:316:9 [INFO] [stdout] | [INFO] [stdout] 316 | for i in 0..settings.add_rare_candy{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:319:9 [INFO] [stdout] | [INFO] [stdout] 319 | for i in 0..settings.add_pokeballs{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:331:13 [INFO] [stdout] | [INFO] [stdout] 331 | for i in 0..(settings.number_hms+1){ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:354:13 [INFO] [stdout] | [INFO] [stdout] 354 | for i in 0..6{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:359:13 [INFO] [stdout] | [INFO] [stdout] 359 | for i in 0..6{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/startup.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | let mut all_items : Vec = item_randomization::randomize_items(settings,&pkmn_data,&gym_types); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/src/gen3/trainers.rs:342:23 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn create_moveset(settings: &mut settings::Settings,pokemon: pokemon::Pokemon,level: i32,old_moveset: Vec) -> Vec{ [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:450:9 [INFO] [stdout] | [INFO] [stdout] 450 | for i in 0..data_temp.len(){ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/src/gen3/logic.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn check_logic(settings: &mut settings::Settings,item_name: String, location_name: String, prereqs: Vec) -> bool{ [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `previous_areas` [INFO] [stdout] --> src/src/gen3/logic.rs:20:24 [INFO] [stdout] | [INFO] [stdout] 20 | fn check_area_for_item(previous_areas: Vec,item_name : String,location_name: String,requirements: Vec) -> bool{ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_previous_areas` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `requirements` [INFO] [stdout] --> src/src/gen3/logic.rs:20:93 [INFO] [stdout] | [INFO] [stdout] 20 | fn check_area_for_item(previous_areas: Vec,item_name : String,location_name: String,requirements: Vec) -> bool{ [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_requirements` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pokemon` [INFO] [stdout] --> src/src/gen3/trainers.rs:342:57 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn create_moveset(settings: &mut settings::Settings,pokemon: pokemon::Pokemon,level: i32,old_moveset: Vec) -> Vec{ [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pokemon` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `level` [INFO] [stdout] --> src/src/gen3/trainers.rs:342:83 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn create_moveset(settings: &mut settings::Settings,pokemon: pokemon::Pokemon,level: i32,old_moveset: Vec) -> Vec{ [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_level` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `old_moveset` [INFO] [stdout] --> src/src/gen3/trainers.rs:342:94 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn create_moveset(settings: &mut settings::Settings,pokemon: pokemon::Pokemon,level: i32,old_moveset: Vec) -> Vec{ [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_old_moveset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_connections` [INFO] [stdout] --> src/src/gen3/logic.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 30 | fn add_connection(all_connections : &mut Vec, current_location: String, previous_location: String, requirements: Vec src/src/gen3/logic.rs:30:60 [INFO] [stdout] | [INFO] [stdout] 30 | ...c, current_location: String, previous_location: String, requirements: Vec){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_location` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `previous_location` [INFO] [stdout] --> src/src/gen3/logic.rs:30:86 [INFO] [stdout] | [INFO] [stdout] 30 | ...ation: String, previous_location: String, requirements: Vec){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_previous_location` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `requirements` [INFO] [stdout] --> src/src/gen3/logic.rs:30:113 [INFO] [stdout] | [INFO] [stdout] 30 | ...s_location: String, requirements: Vec){ [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_requirements` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/logic.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let mut all_connections : Vec = Vec::new(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/startup.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | let mut all_items : Vec = item_randomization::randomize_items(settings,&pkmn_data,&gym_types); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/src/gen3/evolution_changes.rs:2:30 [INFO] [stdout] | [INFO] [stdout] 2 | pub fn setup_evolution_fixes(settings: &settings::Settings){ [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/item_randomization.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | let mut all_items = randomize_vector_item(settings,&mut all_item_locations.clone()); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `added` is never read [INFO] [stdout] --> src/src/gen3/item_randomization.rs:127:21 [INFO] [stdout] | [INFO] [stdout] 127 | let mut added = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:316:9 [INFO] [stdout] | [INFO] [stdout] 316 | for i in 0..settings.add_rare_candy{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:319:9 [INFO] [stdout] | [INFO] [stdout] 319 | for i in 0..settings.add_pokeballs{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:331:13 [INFO] [stdout] | [INFO] [stdout] 331 | for i in 0..(settings.number_hms+1){ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:354:13 [INFO] [stdout] | [INFO] [stdout] 354 | for i in 0..6{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:359:13 [INFO] [stdout] | [INFO] [stdout] 359 | for i in 0..6{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/src/gen3/item_randomization.rs:450:9 [INFO] [stdout] | [INFO] [stdout] 450 | for i in 0..data_temp.len(){ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/src/gen3/logic.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn check_logic(settings: &mut settings::Settings,item_name: String, location_name: String, prereqs: Vec) -> bool{ [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `previous_areas` [INFO] [stdout] --> src/src/gen3/logic.rs:20:24 [INFO] [stdout] | [INFO] [stdout] 20 | fn check_area_for_item(previous_areas: Vec,item_name : String,location_name: String,requirements: Vec) -> bool{ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_previous_areas` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `requirements` [INFO] [stdout] --> src/src/gen3/logic.rs:20:93 [INFO] [stdout] | [INFO] [stdout] 20 | fn check_area_for_item(previous_areas: Vec,item_name : String,location_name: String,requirements: Vec) -> bool{ [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_requirements` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_connections` [INFO] [stdout] --> src/src/gen3/logic.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 30 | fn add_connection(all_connections : &mut Vec, current_location: String, previous_location: String, requirements: Vec src/src/gen3/logic.rs:30:60 [INFO] [stdout] | [INFO] [stdout] 30 | ...c, current_location: String, previous_location: String, requirements: Vec){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_location` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `previous_location` [INFO] [stdout] --> src/src/gen3/logic.rs:30:86 [INFO] [stdout] | [INFO] [stdout] 30 | ...ation: String, previous_location: String, requirements: Vec){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_previous_location` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `requirements` [INFO] [stdout] --> src/src/gen3/logic.rs:30:113 [INFO] [stdout] | [INFO] [stdout] 30 | ...s_location: String, requirements: Vec){ [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_requirements` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/logic.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let mut all_connections : Vec = Vec::new(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/src/gen3/startup.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | let mut all_items : Vec = item_randomization::randomize_items(settings,&pkmn_data,&gym_types); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_stats` [INFO] [stdout] --> src/src/pokemon.rs:1369:49 [INFO] [stdout] | [INFO] [stdout] 1369 | pub fn pokemon_alternate_forms(species: Pokemon,all_stats: &Vec,settings: &mut settings::Settings) -> String{ [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_all_stats` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_stats` [INFO] [stdout] --> src/src/pokemon.rs:1369:49 [INFO] [stdout] | [INFO] [stdout] 1369 | pub fn pokemon_alternate_forms(species: Pokemon,all_stats: &Vec,settings: &mut settings::Settings) -> String{ [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_all_stats` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MUSIC` is never used [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | const MUSIC: [&str;20] = ["MUS_VS_KYOGRE_GROUDON","MUS_VS_RAYQUAZA","MUS_RG_VS_DEOXYS","MUS_RG_VS_LEGEND","MUS_VS_MEW","MUS_VS_REGI" [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_music` is never used [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:12:4 [INFO] [stdout] | [INFO] [stdout] 12 | fn get_music(settings: &mut settings::Settings) -> String{ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `TRANSITION` is never used [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | const TRANSITION: [&str;17] = ["B_TRANSITION_KYOGRE","B_TRANSITION_GROUDON","B_TRANSITION_RAYQUAZA","B_TRANSITION_BLUR", [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_transition` is never used [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:18:4 [INFO] [stdout] | [INFO] [stdout] 18 | fn get_transition(settings: &mut settings::Settings) -> String{ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `BLUE_STARTER` is never used [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | const BLUE_STARTER: usize = 6; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_random_starter` is never used [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:551:4 [INFO] [stdout] | [INFO] [stdout] 551 | fn get_random_starter(settings: &mut settings::Settings,all_stats: &Vec) -> pokemon::Pokemon{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `post_item_script` is never read [INFO] [stdout] --> src/src/gen3/item_randomization.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Item{ [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 15 | pub post_item_script: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Item` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Connections` is never constructed [INFO] [stdout] --> src/src/gen3/logic.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Connections{ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `add_connection` is never used [INFO] [stdout] --> src/src/gen3/logic.rs:30:4 [INFO] [stdout] | [INFO] [stdout] 30 | fn add_connection(all_connections : &mut Vec, current_location: String, previous_location: String, requirements: Vec src/src/gen3/logic.rs:34:4 [INFO] [stdout] | [INFO] [stdout] 34 | fn setup_all_connections() -> Vec{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Mythical` is never constructed [INFO] [stdout] --> src/src/pokemon.rs:1226:5 [INFO] [stdout] | [INFO] [stdout] 1223 | pub enum LegendStatus{ [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] ... [INFO] [stdout] 1226 | Mythical, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LegendStatus` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_pokemon_data_integer` is never used [INFO] [stdout] --> src/src/pokemon.rs:1240:8 [INFO] [stdout] | [INFO] [stdout] 1240 | pub fn get_pokemon_data_integer(pokemon: i32,all_stats: &Vec) -> PokemonStats{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `randomize_gym_locations`, `gym_leader_keys`, `randomize_stores`, `allow_pokeballs_from_store`, `allow_healing_from_store`, and `allow_status_healing_from_store` are never read [INFO] [stdout] --> src/src/settings.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Settings{ [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 42 | pub randomize_gym_locations: GymLocationRandomization, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 56 | pub gym_leader_keys: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 57 | //Poke Mart Settings [INFO] [stdout] 58 | pub randomize_stores: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 59 | pub allow_pokeballs_from_store: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 60 | pub allow_healing_from_store: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 61 | pub allow_status_healing_from_store: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Settings` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | return all; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return all; [INFO] [stdout] 124 + all [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / let mut all : Vec> = Vec::new(); [INFO] [stdout] 22 | | all.push(Vec::new()); [INFO] [stdout] 23 | | all.push(Vec::new()); [INFO] [stdout] | |_________________________^ help: consider using the `vec![]` macro: `let mut all: Vec> = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:250:5 [INFO] [stdout] | [INFO] [stdout] 250 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 250 - return false; [INFO] [stdout] 250 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:132:36 [INFO] [stdout] | [INFO] [stdout] 132 | if trainer.trainer_name == i.to_string(){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:143:36 [INFO] [stdout] | [INFO] [stdout] 143 | if trainer.trainer_name == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:154:51 [INFO] [stdout] | [INFO] [stdout] 154 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:165:51 [INFO] [stdout] | [INFO] [stdout] 165 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:179:51 [INFO] [stdout] | [INFO] [stdout] 179 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_stats` [INFO] [stdout] --> src/src/pokemon.rs:1369:49 [INFO] [stdout] | [INFO] [stdout] 1369 | pub fn pokemon_alternate_forms(species: Pokemon,all_stats: &Vec,settings: &mut settings::Settings) -> String{ [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_all_stats` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:192:51 [INFO] [stdout] | [INFO] [stdout] 192 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:204:51 [INFO] [stdout] | [INFO] [stdout] 204 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MUSIC` is never used [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | const MUSIC: [&str;20] = ["MUS_VS_KYOGRE_GROUDON","MUS_VS_RAYQUAZA","MUS_RG_VS_DEOXYS","MUS_RG_VS_LEGEND","MUS_VS_MEW","MUS_VS_REGI" [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:222:51 [INFO] [stdout] | [INFO] [stdout] 222 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:238:51 [INFO] [stdout] | [INFO] [stdout] 238 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_music` is never used [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:12:4 [INFO] [stdout] | [INFO] [stdout] 12 | fn get_music(settings: &mut settings::Settings) -> String{ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `TRANSITION` is never used [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | const TRANSITION: [&str;17] = ["B_TRANSITION_KYOGRE","B_TRANSITION_GROUDON","B_TRANSITION_RAYQUAZA","B_TRANSITION_BLUR", [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_transition` is never used [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:18:4 [INFO] [stdout] | [INFO] [stdout] 18 | fn get_transition(settings: &mut settings::Settings) -> String{ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `BLUE_STARTER` is never used [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | const BLUE_STARTER: usize = 6; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_random_starter` is never used [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:551:4 [INFO] [stdout] | [INFO] [stdout] 551 | fn get_random_starter(settings: &mut settings::Settings,all_stats: &Vec) -> pokemon::Pokemon{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `post_item_script` is never read [INFO] [stdout] --> src/src/gen3/item_randomization.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Item{ [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 15 | pub post_item_script: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Item` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:248:51 [INFO] [stdout] | [INFO] [stdout] 248 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Connections` is never constructed [INFO] [stdout] --> src/src/gen3/logic.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Connections{ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `add_connection` is never used [INFO] [stdout] --> src/src/gen3/logic.rs:30:4 [INFO] [stdout] | [INFO] [stdout] 30 | fn add_connection(all_connections : &mut Vec, current_location: String, previous_location: String, requirements: Vec src/src/gen3/logic.rs:34:4 [INFO] [stdout] | [INFO] [stdout] 34 | fn setup_all_connections() -> Vec{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Mythical` is never constructed [INFO] [stdout] --> src/src/pokemon.rs:1226:5 [INFO] [stdout] | [INFO] [stdout] 1223 | pub enum LegendStatus{ [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] ... [INFO] [stdout] 1226 | Mythical, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LegendStatus` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_pokemon_data_integer` is never used [INFO] [stdout] --> src/src/pokemon.rs:1240:8 [INFO] [stdout] | [INFO] [stdout] 1240 | pub fn get_pokemon_data_integer(pokemon: i32,all_stats: &Vec) -> PokemonStats{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `randomize_gym_locations`, `gym_leader_keys`, `randomize_stores`, `allow_pokeballs_from_store`, `allow_healing_from_store`, and `allow_status_healing_from_store` are never read [INFO] [stdout] --> src/src/settings.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Settings{ [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 42 | pub randomize_gym_locations: GymLocationRandomization, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 56 | pub gym_leader_keys: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 57 | //Poke Mart Settings [INFO] [stdout] 58 | pub randomize_stores: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 59 | pub allow_pokeballs_from_store: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 60 | pub allow_healing_from_store: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 61 | pub allow_status_healing_from_store: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Settings` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:262:25 [INFO] [stdout] | [INFO] [stdout] 262 | "MARC" => { return handle_gym_trainer(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 262 - "MARC" => { return handle_gym_trainer(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock);} [INFO] [stdout] 262 + "MARC" => { handle_gym_trainer(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:263:27 [INFO] [stdout] | [INFO] [stdout] 263 | "ROXANNE" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock,0);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 - "ROXANNE" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock,0);} [INFO] [stdout] 263 + "ROXANNE" => {handle_gym_leader(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock,0)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:269:27 [INFO] [stdout] | [INFO] [stdout] 269 | "JOCELYN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 269 - "JOCELYN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting)} [INFO] [stdout] 269 + "JOCELYN" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:270:26 [INFO] [stdout] | [INFO] [stdout] 270 | "BRAWLY" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting,1);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 - "BRAWLY" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting,1);} [INFO] [stdout] 270 + "BRAWLY" => {handle_gym_leader(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting,1)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:276:26 [INFO] [stdout] | [INFO] [stdout] 276 | "SHAWN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 276 - "SHAWN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric)} [INFO] [stdout] 276 + "SHAWN" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:277:26 [INFO] [stdout] | [INFO] [stdout] 277 | "WATTSON" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric,2);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - "WATTSON" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric,2);} [INFO] [stdout] 277 + "WATTSON" =>{handle_gym_leader(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric,2)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:286:27 [INFO] [stdout] | [INFO] [stdout] 286 | "DANIELLE" =>{return handle_gym_trainer(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 286 - "DANIELLE" =>{return handle_gym_trainer(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire)} [INFO] [stdout] 286 + "DANIELLE" =>{handle_gym_trainer(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | return all; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return all; [INFO] [stdout] 124 + all [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / let mut all : Vec> = Vec::new(); [INFO] [stdout] 22 | | all.push(Vec::new()); [INFO] [stdout] 23 | | all.push(Vec::new()); [INFO] [stdout] | |_________________________^ help: consider using the `vec![]` macro: `let mut all: Vec> = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:287:27 [INFO] [stdout] | [INFO] [stdout] 287 | "FLANNERY" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire,3);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 287 - "FLANNERY" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire,3);} [INFO] [stdout] 287 + "FLANNERY" =>{handle_gym_leader(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire,3)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:295:25 [INFO] [stdout] | [INFO] [stdout] 295 | "BERKE" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - "BERKE" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal)} [INFO] [stdout] 295 + "BERKE" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:296:24 [INFO] [stdout] | [INFO] [stdout] 296 | "NORMAN"=>{return handle_gym_leader(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal,4);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 296 - "NORMAN"=>{return handle_gym_leader(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal,4);} [INFO] [stdout] 296 + "NORMAN"=>{handle_gym_leader(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal,4)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:303:26 [INFO] [stdout] | [INFO] [stdout] 303 | "DARIUS" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 303 - "DARIUS" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying)} [INFO] [stdout] 303 + "DARIUS" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:304:26 [INFO] [stdout] | [INFO] [stdout] 304 | "WINONA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying,5);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 304 - "WINONA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying,5);} [INFO] [stdout] 304 + "WINONA" => {handle_gym_leader(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying,5)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:317:26 [INFO] [stdout] | [INFO] [stdout] 317 | "HANNAH" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 317 - "HANNAH" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic)} [INFO] [stdout] 317 + "HANNAH" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:318:29 [INFO] [stdout] | [INFO] [stdout] 318 | "TATE&LIZA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic,6);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 318 - "TATE&LIZA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic,6);} [INFO] [stdout] 318 + "TATE&LIZA" => {handle_gym_leader(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic,6)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:329:27 [INFO] [stdout] | [INFO] [stdout] 329 | "BRIDGET" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 329 - "BRIDGET" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water)} [INFO] [stdout] 329 + "BRIDGET" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:330:24 [INFO] [stdout] | [INFO] [stdout] 330 | "JUAN" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water,7);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 330 - "JUAN" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water,7);} [INFO] [stdout] 330 + "JUAN" => {handle_gym_leader(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water,7)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:332:26 [INFO] [stdout] | [INFO] [stdout] 332 | "SIDNEY" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[0],pokemon::Type::Dark,8);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 332 - "SIDNEY" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[0],pokemon::Type::Dark,8);} [INFO] [stdout] 332 + "SIDNEY" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[0],pokemon::Type::Dark,8)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:333:26 [INFO] [stdout] | [INFO] [stdout] 333 | "GLACIA" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[1],pokemon::Type::Ice,9);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 333 - "GLACIA" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[1],pokemon::Type::Ice,9);} [INFO] [stdout] 333 + "GLACIA" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[1],pokemon::Type::Ice,9)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:334:26 [INFO] [stdout] | [INFO] [stdout] 334 | "PHOEBE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[2],pokemon::Type::Ghost,10);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 334 - "PHOEBE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[2],pokemon::Type::Ghost,10);} [INFO] [stdout] 334 + "PHOEBE" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[2],pokemon::Type::Ghost,10)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:335:25 [INFO] [stdout] | [INFO] [stdout] 335 | "DRAKE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[3],pokemon::Type::Dragon,11);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 335 - "DRAKE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[3],pokemon::Type::Dragon,11);} [INFO] [stdout] 335 + "DRAKE" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[3],pokemon::Type::Dragon,11)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:336:27 [INFO] [stdout] | [INFO] [stdout] 336 | "WALLACE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[4],pokemon::Type::Water,12);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 336 - "WALLACE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[4],pokemon::Type::Water,12);} [INFO] [stdout] 336 + "WALLACE" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[4],pokemon::Type::Water,12)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:340:21 [INFO] [stdout] | [INFO] [stdout] 340 | ... return if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 1, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 340 - return if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 1, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] 340 + if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 1, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:343:21 [INFO] [stdout] | [INFO] [stdout] 343 | ... return if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 2, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 343 - return if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 2, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] 343 + if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 2, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:365:17 [INFO] [stdout] | [INFO] [stdout] 365 | return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 365 - return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] 365 + trainers::get_random_trainer(trainer, settings, all_stats) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:250:5 [INFO] [stdout] | [INFO] [stdout] 250 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 250 - return false; [INFO] [stdout] 250 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:374:9 [INFO] [stdout] | [INFO] [stdout] 374 | return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 374 - return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] 374 + trainers::get_random_trainer(trainer, settings, all_stats) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:378:9 [INFO] [stdout] | [INFO] [stdout] 378 | return get_gym_trainer_pokemon(trainer,settings,all_stats,pkmn_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 378 - return get_gym_trainer_pokemon(trainer,settings,all_stats,pkmn_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] 378 + get_gym_trainer_pokemon(trainer,settings,all_stats,pkmn_type,settings.allow_trainer_legendaries.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:132:36 [INFO] [stdout] | [INFO] [stdout] 132 | if trainer.trainer_name == i.to_string(){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:382:9 [INFO] [stdout] | [INFO] [stdout] 382 | return get_gym_trainer_pokemon(trainer,settings,all_stats,standard_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 382 - return get_gym_trainer_pokemon(trainer,settings,all_stats,standard_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] 382 + get_gym_trainer_pokemon(trainer,settings,all_stats,standard_type,settings.allow_trainer_legendaries.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:143:36 [INFO] [stdout] | [INFO] [stdout] 143 | if trainer.trainer_name == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:154:51 [INFO] [stdout] | [INFO] [stdout] 154 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:165:51 [INFO] [stdout] | [INFO] [stdout] 165 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:546:5 [INFO] [stdout] | [INFO] [stdout] 546 | return new_trainer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 546 - return new_trainer; [INFO] [stdout] 546 + new_trainer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:179:51 [INFO] [stdout] | [INFO] [stdout] 179 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:192:51 [INFO] [stdout] | [INFO] [stdout] 192 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:405:17 [INFO] [stdout] | [INFO] [stdout] 405 | / if !has_mega{ [INFO] [stdout] 406 | | has_mega = settings.gym_leader_megas; [INFO] [stdout] 407 | | num_gimmick += 1; [INFO] [stdout] 408 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 404 ~ 0 [INFO] [stdout] 405 ~ if !has_mega=> { [INFO] [stdout] 406 | has_mega = settings.gym_leader_megas; [INFO] [stdout] 407 | num_gimmick += 1; [INFO] [stdout] 408 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:204:51 [INFO] [stdout] | [INFO] [stdout] 204 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:411:17 [INFO] [stdout] | [INFO] [stdout] 411 | / if !has_legend{ [INFO] [stdout] 412 | | has_legend = settings.gym_leader_legends; [INFO] [stdout] 413 | | num_gimmick += 1; [INFO] [stdout] 414 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 410 ~ 1 [INFO] [stdout] 411 ~ if !has_legend=> { [INFO] [stdout] 412 | has_legend = settings.gym_leader_legends; [INFO] [stdout] 413 | num_gimmick += 1; [INFO] [stdout] 414 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:417:17 [INFO] [stdout] | [INFO] [stdout] 417 | / if !has_z_crystal{ [INFO] [stdout] 418 | | has_z_crystal = settings.gym_leader_z_crystal; [INFO] [stdout] 419 | | num_gimmick += 1; [INFO] [stdout] 420 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 416 ~ 2 [INFO] [stdout] 417 ~ if !has_z_crystal=> { [INFO] [stdout] 418 | has_z_crystal = settings.gym_leader_z_crystal; [INFO] [stdout] 419 | num_gimmick += 1; [INFO] [stdout] 420 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:222:51 [INFO] [stdout] | [INFO] [stdout] 222 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:423:17 [INFO] [stdout] | [INFO] [stdout] 423 | / if !has_dynamax{ [INFO] [stdout] 424 | | has_dynamax = settings.gym_leader_dynamax; [INFO] [stdout] 425 | | num_gimmick += 1; [INFO] [stdout] 426 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 422 ~ 3 [INFO] [stdout] 423 ~ if !has_dynamax=> { [INFO] [stdout] 424 | has_dynamax = settings.gym_leader_dynamax; [INFO] [stdout] 425 | num_gimmick += 1; [INFO] [stdout] 426 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MUSIC` is never used [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | const MUSIC: [&str;20] = ["MUS_VS_KYOGRE_GROUDON","MUS_VS_RAYQUAZA","MUS_RG_VS_DEOXYS","MUS_RG_VS_LEGEND","MUS_VS_MEW","MUS_VS_REGI" [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:429:17 [INFO] [stdout] | [INFO] [stdout] 429 | / if !has_terra{ [INFO] [stdout] 430 | | has_terra = settings.gym_leader_terra; [INFO] [stdout] 431 | | num_gimmick += 1; [INFO] [stdout] 432 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 428 ~ 4 [INFO] [stdout] 429 ~ if !has_terra=> { [INFO] [stdout] 430 | has_terra = settings.gym_leader_terra; [INFO] [stdout] 431 | num_gimmick += 1; [INFO] [stdout] 432 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_music` is never used [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:12:4 [INFO] [stdout] | [INFO] [stdout] 12 | fn get_music(settings: &mut settings::Settings) -> String{ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `TRANSITION` is never used [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | const TRANSITION: [&str;17] = ["B_TRANSITION_KYOGRE","B_TRANSITION_GROUDON","B_TRANSITION_RAYQUAZA","B_TRANSITION_BLUR", [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:403:42 [INFO] [stdout] | [INFO] [stdout] 403 | match settings::get_next_seed(0, 10 as i32, settings){ [INFO] [stdout] | ^^^^^^^^^ help: try: `10_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:238:51 [INFO] [stdout] | [INFO] [stdout] 238 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_transition` is never used [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:18:4 [INFO] [stdout] | [INFO] [stdout] 18 | fn get_transition(settings: &mut settings::Settings) -> String{ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `BLUE_STARTER` is never used [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | const BLUE_STARTER: usize = 6; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_random_starter` is never used [INFO] [stdout] --> src/src/gen3/frlg/special_trainers.rs:551:4 [INFO] [stdout] | [INFO] [stdout] 551 | fn get_random_starter(settings: &mut settings::Settings,all_stats: &Vec) -> pokemon::Pokemon{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:248:51 [INFO] [stdout] | [INFO] [stdout] 248 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `post_item_script` is never read [INFO] [stdout] --> src/src/gen3/item_randomization.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Item{ [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 15 | pub post_item_script: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Item` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Connections` is never constructed [INFO] [stdout] --> src/src/gen3/logic.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Connections{ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `add_connection` is never used [INFO] [stdout] --> src/src/gen3/logic.rs:30:4 [INFO] [stdout] | [INFO] [stdout] 30 | fn add_connection(all_connections : &mut Vec, current_location: String, previous_location: String, requirements: Vec src/src/gen3/logic.rs:34:4 [INFO] [stdout] | [INFO] [stdout] 34 | fn setup_all_connections() -> Vec{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Mythical` is never constructed [INFO] [stdout] --> src/src/pokemon.rs:1226:5 [INFO] [stdout] | [INFO] [stdout] 1223 | pub enum LegendStatus{ [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] ... [INFO] [stdout] 1226 | Mythical, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LegendStatus` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_pokemon_data_integer` is never used [INFO] [stdout] --> src/src/pokemon.rs:1240:8 [INFO] [stdout] | [INFO] [stdout] 1240 | pub fn get_pokemon_data_integer(pokemon: i32,all_stats: &Vec) -> PokemonStats{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:262:25 [INFO] [stdout] | [INFO] [stdout] 262 | "MARC" => { return handle_gym_trainer(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 262 - "MARC" => { return handle_gym_trainer(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock);} [INFO] [stdout] 262 + "MARC" => { handle_gym_trainer(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:263:27 [INFO] [stdout] | [INFO] [stdout] 263 | "ROXANNE" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock,0);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 - "ROXANNE" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock,0);} [INFO] [stdout] 263 + "ROXANNE" => {handle_gym_leader(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock,0)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `randomize_gym_locations`, `gym_leader_keys`, `randomize_stores`, `allow_pokeballs_from_store`, `allow_healing_from_store`, and `allow_status_healing_from_store` are never read [INFO] [stdout] --> src/src/settings.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Settings{ [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 42 | pub randomize_gym_locations: GymLocationRandomization, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 56 | pub gym_leader_keys: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 57 | //Poke Mart Settings [INFO] [stdout] 58 | pub randomize_stores: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 59 | pub allow_pokeballs_from_store: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 60 | pub allow_healing_from_store: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 61 | pub allow_status_healing_from_store: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Settings` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:269:27 [INFO] [stdout] | [INFO] [stdout] 269 | "JOCELYN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 269 - "JOCELYN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting)} [INFO] [stdout] 269 + "JOCELYN" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:270:26 [INFO] [stdout] | [INFO] [stdout] 270 | "BRAWLY" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting,1);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 - "BRAWLY" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting,1);} [INFO] [stdout] 270 + "BRAWLY" => {handle_gym_leader(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting,1)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:276:26 [INFO] [stdout] | [INFO] [stdout] 276 | "SHAWN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 276 - "SHAWN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric)} [INFO] [stdout] 276 + "SHAWN" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:277:26 [INFO] [stdout] | [INFO] [stdout] 277 | "WATTSON" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric,2);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - "WATTSON" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric,2);} [INFO] [stdout] 277 + "WATTSON" =>{handle_gym_leader(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric,2)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:286:27 [INFO] [stdout] | [INFO] [stdout] 286 | "DANIELLE" =>{return handle_gym_trainer(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 286 - "DANIELLE" =>{return handle_gym_trainer(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire)} [INFO] [stdout] 286 + "DANIELLE" =>{handle_gym_trainer(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:287:27 [INFO] [stdout] | [INFO] [stdout] 287 | "FLANNERY" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire,3);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 287 - "FLANNERY" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire,3);} [INFO] [stdout] 287 + "FLANNERY" =>{handle_gym_leader(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire,3)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:295:25 [INFO] [stdout] | [INFO] [stdout] 295 | "BERKE" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - "BERKE" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal)} [INFO] [stdout] 295 + "BERKE" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | return all; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return all; [INFO] [stdout] 124 + all [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:296:24 [INFO] [stdout] | [INFO] [stdout] 296 | "NORMAN"=>{return handle_gym_leader(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal,4);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 296 - "NORMAN"=>{return handle_gym_leader(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal,4);} [INFO] [stdout] 296 + "NORMAN"=>{handle_gym_leader(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal,4)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:464:48 [INFO] [stdout] | [INFO] [stdout] 464 | if (has_mega || has_legend) && added_pokemon.len() == 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `added_pokemon.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:303:26 [INFO] [stdout] | [INFO] [stdout] 303 | "DARIUS" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 303 - "DARIUS" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying)} [INFO] [stdout] 303 + "DARIUS" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:304:26 [INFO] [stdout] | [INFO] [stdout] 304 | "WINONA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying,5);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 304 - "WINONA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying,5);} [INFO] [stdout] 304 + "WINONA" => {handle_gym_leader(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying,5)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / let mut all : Vec> = Vec::new(); [INFO] [stdout] 22 | | all.push(Vec::new()); [INFO] [stdout] 23 | | all.push(Vec::new()); [INFO] [stdout] | |_________________________^ help: consider using the `vec![]` macro: `let mut all: Vec> = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:317:26 [INFO] [stdout] | [INFO] [stdout] 317 | "HANNAH" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 317 - "HANNAH" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic)} [INFO] [stdout] 317 + "HANNAH" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:318:29 [INFO] [stdout] | [INFO] [stdout] 318 | "TATE&LIZA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic,6);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 318 - "TATE&LIZA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic,6);} [INFO] [stdout] 318 + "TATE&LIZA" => {handle_gym_leader(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic,6)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:329:27 [INFO] [stdout] | [INFO] [stdout] 329 | "BRIDGET" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 329 - "BRIDGET" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water)} [INFO] [stdout] 329 + "BRIDGET" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:330:24 [INFO] [stdout] | [INFO] [stdout] 330 | "JUAN" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water,7);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 330 - "JUAN" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water,7);} [INFO] [stdout] 330 + "JUAN" => {handle_gym_leader(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water,7)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:332:26 [INFO] [stdout] | [INFO] [stdout] 332 | "SIDNEY" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[0],pokemon::Type::Dark,8);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 332 - "SIDNEY" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[0],pokemon::Type::Dark,8);} [INFO] [stdout] 332 + "SIDNEY" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[0],pokemon::Type::Dark,8)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:333:26 [INFO] [stdout] | [INFO] [stdout] 333 | "GLACIA" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[1],pokemon::Type::Ice,9);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 333 - "GLACIA" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[1],pokemon::Type::Ice,9);} [INFO] [stdout] 333 + "GLACIA" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[1],pokemon::Type::Ice,9)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:334:26 [INFO] [stdout] | [INFO] [stdout] 334 | "PHOEBE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[2],pokemon::Type::Ghost,10);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 334 - "PHOEBE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[2],pokemon::Type::Ghost,10);} [INFO] [stdout] 334 + "PHOEBE" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[2],pokemon::Type::Ghost,10)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:335:25 [INFO] [stdout] | [INFO] [stdout] 335 | "DRAKE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[3],pokemon::Type::Dragon,11);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 335 - "DRAKE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[3],pokemon::Type::Dragon,11);} [INFO] [stdout] 335 + "DRAKE" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[3],pokemon::Type::Dragon,11)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:336:27 [INFO] [stdout] | [INFO] [stdout] 336 | "WALLACE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[4],pokemon::Type::Water,12);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 336 - "WALLACE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[4],pokemon::Type::Water,12);} [INFO] [stdout] 336 + "WALLACE" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[4],pokemon::Type::Water,12)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:340:21 [INFO] [stdout] | [INFO] [stdout] 340 | ... return if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 1, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 340 - return if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 1, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] 340 + if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 1, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:343:21 [INFO] [stdout] | [INFO] [stdout] 343 | ... return if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 2, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 343 - return if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 2, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] 343 + if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 2, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:365:17 [INFO] [stdout] | [INFO] [stdout] 365 | return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 365 - return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] 365 + trainers::get_random_trainer(trainer, settings, all_stats) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:250:5 [INFO] [stdout] | [INFO] [stdout] 250 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 250 - return false; [INFO] [stdout] 250 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:132:36 [INFO] [stdout] | [INFO] [stdout] 132 | if trainer.trainer_name == i.to_string(){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:143:36 [INFO] [stdout] | [INFO] [stdout] 143 | if trainer.trainer_name == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:154:51 [INFO] [stdout] | [INFO] [stdout] 154 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:165:51 [INFO] [stdout] | [INFO] [stdout] 165 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:179:51 [INFO] [stdout] | [INFO] [stdout] 179 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:192:51 [INFO] [stdout] | [INFO] [stdout] 192 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:204:51 [INFO] [stdout] | [INFO] [stdout] 204 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:558:17 [INFO] [stdout] | [INFO] [stdout] 558 | / (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 559 | | legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 558 - (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 559 - legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 558 + !(!has_legend || legend_rule != settings::AllowLegendaries::OneLegend && legend_rule != settings::AllowLegendaries::AceLegend) [INFO] [stdout] | [INFO] [stdout] 558 - (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 559 - legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 558 + (legend_rule == settings::AllowLegendaries::AceLegend || legend_rule == settings::AllowLegendaries::OneLegend) && has_legend [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:574:5 [INFO] [stdout] | [INFO] [stdout] 574 | return new_trainer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 574 - return new_trainer; [INFO] [stdout] 574 + new_trainer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:222:51 [INFO] [stdout] | [INFO] [stdout] 222 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:238:51 [INFO] [stdout] | [INFO] [stdout] 238 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:557:98 [INFO] [stdout] | [INFO] [stdout] 557 | ...r_trainer(trainer.clone().trainer_name, &cur_pokemon,all_stats,settings,if settings.allow_trainer_legendaries.clone() == setting... [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `cur_pokemon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:248:51 [INFO] [stdout] | [INFO] [stdout] 248 | if trainer.trainer_name.to_uppercase() == i.to_string(){return true;} [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:557:130 [INFO] [stdout] | [INFO] [stdout] 557 | ... let pokemon = trainers::get_random_pokemon_for_trainer(trainer.clone().trainer_name, &cur_pokemon,all_stats,settings,if set... [INFO] [stdout] | ____________________________________________________________________________________________________________________________^ [INFO] [stdout] 558 | | ... (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 559 | | ... legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 560 | | ... {false}else{true}); [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] help: you can reduce it to [INFO] [stdout] | [INFO] [stdout] 557 ~ let pokemon = trainers::get_random_pokemon_for_trainer(trainer.clone().trainer_name, &cur_pokemon,all_stats,settings,!(settings.allow_trainer_legendaries.clone() == settings::AllowLegendaries::NoLegends || (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 558 ~ legend_rule == settings::AllowLegendaries::AceLegend && has_legend))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:262:25 [INFO] [stdout] | [INFO] [stdout] 262 | "MARC" => { return handle_gym_trainer(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 262 - "MARC" => { return handle_gym_trainer(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock);} [INFO] [stdout] 262 + "MARC" => { handle_gym_trainer(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:374:9 [INFO] [stdout] | [INFO] [stdout] 374 | return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 374 - return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] 374 + trainers::get_random_trainer(trainer, settings, all_stats) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:378:9 [INFO] [stdout] | [INFO] [stdout] 378 | return get_gym_trainer_pokemon(trainer,settings,all_stats,pkmn_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 378 - return get_gym_trainer_pokemon(trainer,settings,all_stats,pkmn_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] 378 + get_gym_trainer_pokemon(trainer,settings,all_stats,pkmn_type,settings.allow_trainer_legendaries.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:382:9 [INFO] [stdout] | [INFO] [stdout] 382 | return get_gym_trainer_pokemon(trainer,settings,all_stats,standard_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 382 - return get_gym_trainer_pokemon(trainer,settings,all_stats,standard_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] 382 + get_gym_trainer_pokemon(trainer,settings,all_stats,standard_type,settings.allow_trainer_legendaries.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:263:27 [INFO] [stdout] | [INFO] [stdout] 263 | "ROXANNE" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock,0);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 - "ROXANNE" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock,0);} [INFO] [stdout] 263 + "ROXANNE" => {handle_gym_leader(trainer,settings,all_stats,gym_types[0],pokemon::Type::Rock,0)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:269:27 [INFO] [stdout] | [INFO] [stdout] 269 | "JOCELYN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 269 - "JOCELYN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting)} [INFO] [stdout] 269 + "JOCELYN" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:270:26 [INFO] [stdout] | [INFO] [stdout] 270 | "BRAWLY" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting,1);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 - "BRAWLY" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting,1);} [INFO] [stdout] 270 + "BRAWLY" => {handle_gym_leader(trainer,settings,all_stats,gym_types[1],pokemon::Type::Fighting,1)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:276:26 [INFO] [stdout] | [INFO] [stdout] 276 | "SHAWN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 276 - "SHAWN" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric)} [INFO] [stdout] 276 + "SHAWN" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:546:5 [INFO] [stdout] | [INFO] [stdout] 546 | return new_trainer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 546 - return new_trainer; [INFO] [stdout] 546 + new_trainer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:277:26 [INFO] [stdout] | [INFO] [stdout] 277 | "WATTSON" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric,2);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - "WATTSON" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric,2);} [INFO] [stdout] 277 + "WATTSON" =>{handle_gym_leader(trainer,settings,all_stats,gym_types[2],pokemon::Type::Electric,2)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:646:5 [INFO] [stdout] | [INFO] [stdout] 646 | return random_rival; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 646 - return random_rival; [INFO] [stdout] 646 + random_rival [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:286:27 [INFO] [stdout] | [INFO] [stdout] 286 | "DANIELLE" =>{return handle_gym_trainer(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 286 - "DANIELLE" =>{return handle_gym_trainer(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire)} [INFO] [stdout] 286 + "DANIELLE" =>{handle_gym_trainer(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:287:27 [INFO] [stdout] | [INFO] [stdout] 287 | "FLANNERY" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire,3);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 287 - "FLANNERY" =>{return handle_gym_leader(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire,3);} [INFO] [stdout] 287 + "FLANNERY" =>{handle_gym_leader(trainer,settings,all_stats,gym_types[3],pokemon::Type::Fire,3)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:295:25 [INFO] [stdout] | [INFO] [stdout] 295 | "BERKE" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - "BERKE" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal)} [INFO] [stdout] 295 + "BERKE" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:296:24 [INFO] [stdout] | [INFO] [stdout] 296 | "NORMAN"=>{return handle_gym_leader(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal,4);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 296 - "NORMAN"=>{return handle_gym_leader(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal,4);} [INFO] [stdout] 296 + "NORMAN"=>{handle_gym_leader(trainer,settings,all_stats,gym_types[4],pokemon::Type::Normal,4)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:303:26 [INFO] [stdout] | [INFO] [stdout] 303 | "DARIUS" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 303 - "DARIUS" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying)} [INFO] [stdout] 303 + "DARIUS" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:304:26 [INFO] [stdout] | [INFO] [stdout] 304 | "WINONA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying,5);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 304 - "WINONA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying,5);} [INFO] [stdout] 304 + "WINONA" => {handle_gym_leader(trainer,settings,all_stats,gym_types[5],pokemon::Type::Flying,5)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:317:26 [INFO] [stdout] | [INFO] [stdout] 317 | "HANNAH" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 317 - "HANNAH" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic)} [INFO] [stdout] 317 + "HANNAH" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:318:29 [INFO] [stdout] | [INFO] [stdout] 318 | "TATE&LIZA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic,6);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 318 - "TATE&LIZA" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic,6);} [INFO] [stdout] 318 + "TATE&LIZA" => {handle_gym_leader(trainer,settings,all_stats,gym_types[6],pokemon::Type::Psychic,6)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:405:17 [INFO] [stdout] | [INFO] [stdout] 405 | / if !has_mega{ [INFO] [stdout] 406 | | has_mega = settings.gym_leader_megas; [INFO] [stdout] 407 | | num_gimmick += 1; [INFO] [stdout] 408 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 404 ~ 0 [INFO] [stdout] 405 ~ if !has_mega=> { [INFO] [stdout] 406 | has_mega = settings.gym_leader_megas; [INFO] [stdout] 407 | num_gimmick += 1; [INFO] [stdout] 408 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:329:27 [INFO] [stdout] | [INFO] [stdout] 329 | "BRIDGET" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 329 - "BRIDGET" => {return handle_gym_trainer(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water)} [INFO] [stdout] 329 + "BRIDGET" => {handle_gym_trainer(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:330:24 [INFO] [stdout] | [INFO] [stdout] 330 | "JUAN" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water,7);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 330 - "JUAN" => {return handle_gym_leader(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water,7);} [INFO] [stdout] 330 + "JUAN" => {handle_gym_leader(trainer,settings,all_stats,gym_types[7],pokemon::Type::Water,7)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:332:26 [INFO] [stdout] | [INFO] [stdout] 332 | "SIDNEY" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[0],pokemon::Type::Dark,8);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 332 - "SIDNEY" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[0],pokemon::Type::Dark,8);} [INFO] [stdout] 332 + "SIDNEY" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[0],pokemon::Type::Dark,8)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:333:26 [INFO] [stdout] | [INFO] [stdout] 333 | "GLACIA" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[1],pokemon::Type::Ice,9);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 333 - "GLACIA" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[1],pokemon::Type::Ice,9);} [INFO] [stdout] 333 + "GLACIA" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[1],pokemon::Type::Ice,9)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:411:17 [INFO] [stdout] | [INFO] [stdout] 411 | / if !has_legend{ [INFO] [stdout] 412 | | has_legend = settings.gym_leader_legends; [INFO] [stdout] 413 | | num_gimmick += 1; [INFO] [stdout] 414 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 410 ~ 1 [INFO] [stdout] 411 ~ if !has_legend=> { [INFO] [stdout] 412 | has_legend = settings.gym_leader_legends; [INFO] [stdout] 413 | num_gimmick += 1; [INFO] [stdout] 414 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:334:26 [INFO] [stdout] | [INFO] [stdout] 334 | "PHOEBE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[2],pokemon::Type::Ghost,10);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 334 - "PHOEBE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[2],pokemon::Type::Ghost,10);} [INFO] [stdout] 334 + "PHOEBE" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[2],pokemon::Type::Ghost,10)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:335:25 [INFO] [stdout] | [INFO] [stdout] 335 | "DRAKE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[3],pokemon::Type::Dragon,11);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 335 - "DRAKE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[3],pokemon::Type::Dragon,11);} [INFO] [stdout] 335 + "DRAKE" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[3],pokemon::Type::Dragon,11)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:336:27 [INFO] [stdout] | [INFO] [stdout] 336 | "WALLACE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[4],pokemon::Type::Water,12);} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 336 - "WALLACE" => {return handle_gym_leader(trainer,settings,all_stats,elite_4_types[4],pokemon::Type::Water,12);} [INFO] [stdout] 336 + "WALLACE" => {handle_gym_leader(trainer,settings,all_stats,elite_4_types[4],pokemon::Type::Water,12)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:417:17 [INFO] [stdout] | [INFO] [stdout] 417 | / if !has_z_crystal{ [INFO] [stdout] 418 | | has_z_crystal = settings.gym_leader_z_crystal; [INFO] [stdout] 419 | | num_gimmick += 1; [INFO] [stdout] 420 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 416 ~ 2 [INFO] [stdout] 417 ~ if !has_z_crystal=> { [INFO] [stdout] 418 | has_z_crystal = settings.gym_leader_z_crystal; [INFO] [stdout] 419 | num_gimmick += 1; [INFO] [stdout] 420 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:340:21 [INFO] [stdout] | [INFO] [stdout] 340 | ... return if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 1, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 340 - return if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 1, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] 340 + if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 1, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:423:17 [INFO] [stdout] | [INFO] [stdout] 423 | / if !has_dynamax{ [INFO] [stdout] 424 | | has_dynamax = settings.gym_leader_dynamax; [INFO] [stdout] 425 | | num_gimmick += 1; [INFO] [stdout] 426 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 422 ~ 3 [INFO] [stdout] 423 ~ if !has_dynamax=> { [INFO] [stdout] 424 | has_dynamax = settings.gym_leader_dynamax; [INFO] [stdout] 425 | num_gimmick += 1; [INFO] [stdout] 426 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:769:5 [INFO] [stdout] | [INFO] [stdout] 769 | return trainer; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 769 - return trainer; [INFO] [stdout] 769 + trainer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:429:17 [INFO] [stdout] | [INFO] [stdout] 429 | / if !has_terra{ [INFO] [stdout] 430 | | has_terra = settings.gym_leader_terra; [INFO] [stdout] 431 | | num_gimmick += 1; [INFO] [stdout] 432 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 428 ~ 4 [INFO] [stdout] 429 ~ if !has_terra=> { [INFO] [stdout] 430 | has_terra = settings.gym_leader_terra; [INFO] [stdout] 431 | num_gimmick += 1; [INFO] [stdout] 432 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:403:42 [INFO] [stdout] | [INFO] [stdout] 403 | match settings::get_next_seed(0, 10 as i32, settings){ [INFO] [stdout] | ^^^^^^^^^ help: try: `10_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:343:21 [INFO] [stdout] | [INFO] [stdout] 343 | ... return if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 2, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 343 - return if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 2, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] 343 + if settings.wally_keeps_starter{handle_wally(settings, all_stats, trainer.trainer_full_name, 2, rivals.clone()[WALLY].clone())}else{trainers::get_random_trainer(trainer, settings, all_stats)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:365:17 [INFO] [stdout] | [INFO] [stdout] 365 | return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 365 - return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] 365 + trainers::get_random_trainer(trainer, settings, all_stats) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:464:48 [INFO] [stdout] | [INFO] [stdout] 464 | if (has_mega || has_legend) && added_pokemon.len() == 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `added_pokemon.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:374:9 [INFO] [stdout] | [INFO] [stdout] 374 | return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 374 - return trainers::get_random_trainer(trainer, settings, all_stats); [INFO] [stdout] 374 + trainers::get_random_trainer(trainer, settings, all_stats) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:378:9 [INFO] [stdout] | [INFO] [stdout] 378 | return get_gym_trainer_pokemon(trainer,settings,all_stats,pkmn_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 378 - return get_gym_trainer_pokemon(trainer,settings,all_stats,pkmn_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] 378 + get_gym_trainer_pokemon(trainer,settings,all_stats,pkmn_type,settings.allow_trainer_legendaries.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:660:40 [INFO] [stdout] | [INFO] [stdout] 660 | species: scale_pokemon(rival_team[RIVAL_TROPIUS].clone(), 13, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_TROPIUS]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:382:9 [INFO] [stdout] | [INFO] [stdout] 382 | return get_gym_trainer_pokemon(trainer,settings,all_stats,standard_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 382 - return get_gym_trainer_pokemon(trainer,settings,all_stats,standard_type,settings.allow_trainer_legendaries.clone()); [INFO] [stdout] 382 + get_gym_trainer_pokemon(trainer,settings,all_stats,standard_type,settings.allow_trainer_legendaries.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:661:73 [INFO] [stdout] | [INFO] [stdout] 661 | ... scale_pokemon(rival_team[RIVAL_TROPIUS].clone(), 13, all_stats, &mut settings.clone()).pokemon_id, 13, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_TROPIUS]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:662:80 [INFO] [stdout] | [INFO] [stdout] 662 | ... scale_pokemon(rival_team[RIVAL_TROPIUS].clone(), 13, all_stats, &mut settings.clone()).pokemon_id, 13, "".to_string(),true,all_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_TROPIUS]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:668:40 [INFO] [stdout] | [INFO] [stdout] 668 | species: scale_pokemon(starter.clone(), 15, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:669:73 [INFO] [stdout] | [INFO] [stdout] 669 | ... moves: trainers::create_moveset(settings, scale_pokemon(starter.clone(), 15, all_stats, &mut settings.clone()).pokemon_id, 15... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:670:80 [INFO] [stdout] | [INFO] [stdout] 670 | ... held_items: trainers::create_held_item(settings, scale_pokemon(starter.clone(), 15, all_stats, &mut settings.clone()).pokemon... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:546:5 [INFO] [stdout] | [INFO] [stdout] 546 | return new_trainer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 546 - return new_trainer; [INFO] [stdout] 546 + new_trainer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:678:40 [INFO] [stdout] | [INFO] [stdout] 678 | species: scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:679:73 [INFO] [stdout] | [INFO] [stdout] 679 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, &mut settings.clone()).pokemon_id, 18, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:680:80 [INFO] [stdout] | [INFO] [stdout] 680 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, &mut settings.clone()).pokemon_id, 18, "".to_string(),true,all_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:405:17 [INFO] [stdout] | [INFO] [stdout] 405 | / if !has_mega{ [INFO] [stdout] 406 | | has_mega = settings.gym_leader_megas; [INFO] [stdout] 407 | | num_gimmick += 1; [INFO] [stdout] 408 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 404 ~ 0 [INFO] [stdout] 405 ~ if !has_mega=> { [INFO] [stdout] 406 | has_mega = settings.gym_leader_megas; [INFO] [stdout] 407 | num_gimmick += 1; [INFO] [stdout] 408 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:411:17 [INFO] [stdout] | [INFO] [stdout] 411 | / if !has_legend{ [INFO] [stdout] 412 | | has_legend = settings.gym_leader_legends; [INFO] [stdout] 413 | | num_gimmick += 1; [INFO] [stdout] 414 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 410 ~ 1 [INFO] [stdout] 411 ~ if !has_legend=> { [INFO] [stdout] 412 | has_legend = settings.gym_leader_legends; [INFO] [stdout] 413 | num_gimmick += 1; [INFO] [stdout] 414 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:687:73 [INFO] [stdout] | [INFO] [stdout] 687 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, &mut settings.clone()).pokemon_id, 18, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:688:80 [INFO] [stdout] | [INFO] [stdout] 688 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, &mut settings.clone()).pokemon_id, 18, "".to_string(),true,all_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:694:40 [INFO] [stdout] | [INFO] [stdout] 694 | species: scale_pokemon(starter.clone(), 20, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:695:73 [INFO] [stdout] | [INFO] [stdout] 695 | ... moves: trainers::create_moveset(settings, scale_pokemon(starter.clone(), 20, all_stats, &mut settings.clone()).pokemon_id, 20... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:558:17 [INFO] [stdout] | [INFO] [stdout] 558 | / (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 559 | | legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 558 - (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 559 - legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 558 + !(!has_legend || legend_rule != settings::AllowLegendaries::OneLegend && legend_rule != settings::AllowLegendaries::AceLegend) [INFO] [stdout] | [INFO] [stdout] 558 - (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 559 - legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 558 + (legend_rule == settings::AllowLegendaries::AceLegend || legend_rule == settings::AllowLegendaries::OneLegend) && has_legend [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:696:80 [INFO] [stdout] | [INFO] [stdout] 696 | ... held_items: trainers::create_held_item(settings, scale_pokemon(starter.clone(), 20, all_stats, &mut settings.clone()).pokemon... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:574:5 [INFO] [stdout] | [INFO] [stdout] 574 | return new_trainer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 574 - return new_trainer; [INFO] [stdout] 574 + new_trainer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:557:98 [INFO] [stdout] | [INFO] [stdout] 557 | ...r_trainer(trainer.clone().trainer_name, &cur_pokemon,all_stats,settings,if settings.allow_trainer_legendaries.clone() == setting... [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `cur_pokemon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:557:130 [INFO] [stdout] | [INFO] [stdout] 557 | ... let pokemon = trainers::get_random_pokemon_for_trainer(trainer.clone().trainer_name, &cur_pokemon,all_stats,settings,if set... [INFO] [stdout] | ____________________________________________________________________________________________________________________________^ [INFO] [stdout] 558 | | ... (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 559 | | ... legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 560 | | ... {false}else{true}); [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] help: you can reduce it to [INFO] [stdout] | [INFO] [stdout] 557 ~ let pokemon = trainers::get_random_pokemon_for_trainer(trainer.clone().trainer_name, &cur_pokemon,all_stats,settings,!(settings.allow_trainer_legendaries.clone() == settings::AllowLegendaries::NoLegends || (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 558 ~ legend_rule == settings::AllowLegendaries::AceLegend && has_legend))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:704:40 [INFO] [stdout] | [INFO] [stdout] 704 | species: scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 29, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:417:17 [INFO] [stdout] | [INFO] [stdout] 417 | / if !has_z_crystal{ [INFO] [stdout] 418 | | has_z_crystal = settings.gym_leader_z_crystal; [INFO] [stdout] 419 | | num_gimmick += 1; [INFO] [stdout] 420 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 416 ~ 2 [INFO] [stdout] 417 ~ if !has_z_crystal=> { [INFO] [stdout] 418 | has_z_crystal = settings.gym_leader_z_crystal; [INFO] [stdout] 419 | num_gimmick += 1; [INFO] [stdout] 420 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:705:73 [INFO] [stdout] | [INFO] [stdout] 705 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 29, all_stats, &mut settings.clone()).pokemon_id, 29, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:423:17 [INFO] [stdout] | [INFO] [stdout] 423 | / if !has_dynamax{ [INFO] [stdout] 424 | | has_dynamax = settings.gym_leader_dynamax; [INFO] [stdout] 425 | | num_gimmick += 1; [INFO] [stdout] 426 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 422 ~ 3 [INFO] [stdout] 423 ~ if !has_dynamax=> { [INFO] [stdout] 424 | has_dynamax = settings.gym_leader_dynamax; [INFO] [stdout] 425 | num_gimmick += 1; [INFO] [stdout] 426 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:429:17 [INFO] [stdout] | [INFO] [stdout] 429 | / if !has_terra{ [INFO] [stdout] 430 | | has_terra = settings.gym_leader_terra; [INFO] [stdout] 431 | | num_gimmick += 1; [INFO] [stdout] 432 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 428 ~ 4 [INFO] [stdout] 429 ~ if !has_terra=> { [INFO] [stdout] 430 | has_terra = settings.gym_leader_terra; [INFO] [stdout] 431 | num_gimmick += 1; [INFO] [stdout] 432 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:403:42 [INFO] [stdout] | [INFO] [stdout] 403 | match settings::get_next_seed(0, 10 as i32, settings){ [INFO] [stdout] | ^^^^^^^^^ help: try: `10_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:706:80 [INFO] [stdout] | [INFO] [stdout] 706 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 29, all_stats, &mut settings.clone()).pokemon_id, 29, "".to_string(),true,all_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:464:48 [INFO] [stdout] | [INFO] [stdout] 464 | if (has_mega || has_legend) && added_pokemon.len() == 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `added_pokemon.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:713:73 [INFO] [stdout] | [INFO] [stdout] 713 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 29, all_stats, &mut settings.clone()).pokemon_id, 29, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:714:80 [INFO] [stdout] | [INFO] [stdout] 714 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 29, all_stats, &mut settings.clone()).pokemon_id, 29, "".to_string(),true,all_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:720:40 [INFO] [stdout] | [INFO] [stdout] 720 | species: scale_pokemon(starter.clone(), 31, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:646:5 [INFO] [stdout] | [INFO] [stdout] 646 | return random_rival; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 646 - return random_rival; [INFO] [stdout] 646 + random_rival [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:721:73 [INFO] [stdout] | [INFO] [stdout] 721 | ... moves: trainers::create_moveset(settings, scale_pokemon(starter.clone(), 31, all_stats, &mut settings.clone()).pokemon_id, 31... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:722:80 [INFO] [stdout] | [INFO] [stdout] 722 | ... held_items: trainers::create_held_item(settings, scale_pokemon(starter.clone(), 31, all_stats, &mut settings.clone()).pokemon... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:731:26 [INFO] [stdout] | [INFO] [stdout] 731 | species: rival_team[RIVAL_SLUGMA].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_SLUGMA]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:732:58 [INFO] [stdout] | [INFO] [stdout] 732 | moves: trainers::create_moveset(settings,rival_team[RIVAL_SLUGMA].clone(),31,Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_SLUGMA]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:733:66 [INFO] [stdout] | [INFO] [stdout] 733 | held_items: trainers::create_held_item(settings, rival_team[RIVAL_SLUGMA].clone(), 31, "".to_string(),true,all_stats) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_SLUGMA]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:769:5 [INFO] [stdout] | [INFO] [stdout] 769 | return trainer; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 769 - return trainer; [INFO] [stdout] 769 + trainer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:739:26 [INFO] [stdout] | [INFO] [stdout] 739 | species: rival_team[RIVAL_LUDICOLO].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:740:59 [INFO] [stdout] | [INFO] [stdout] 740 | moves: trainers::create_moveset(settings, rival_team[RIVAL_LUDICOLO].clone(), 32, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:741:66 [INFO] [stdout] | [INFO] [stdout] 741 | ...tem(settings, rival_team[RIVAL_LUDICOLO].clone(), 32, "".to_string(),true,all_stats) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:747:26 [INFO] [stdout] | [INFO] [stdout] 747 | species: rival_team[RIVAL_TROPIUS].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_TROPIUS]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:748:59 [INFO] [stdout] | [INFO] [stdout] 748 | moves: trainers::create_moveset(settings, rival_team[RIVAL_LUDICOLO].clone(), 32, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:749:66 [INFO] [stdout] | [INFO] [stdout] 749 | ...tem(settings, rival_team[RIVAL_LUDICOLO].clone(), 32, "".to_string(),true,all_stats) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:755:40 [INFO] [stdout] | [INFO] [stdout] 755 | species: scale_pokemon(starter.clone(), 34, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:756:59 [INFO] [stdout] | [INFO] [stdout] 756 | moves: trainers::create_moveset(settings, starter.clone(), 34, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:757:66 [INFO] [stdout] | [INFO] [stdout] 757 | held_items: trainers::create_held_item(settings, starter.clone(), 34, "".to_string(),true,all_stats) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:764:36 [INFO] [stdout] | [INFO] [stdout] 764 | species: scale_pokemon(starter.clone(), 5, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:790:44 [INFO] [stdout] | [INFO] [stdout] 790 | species: scale_pokemon(wally_team[WALLY_GARDEVOIR].clone(),16,all_stats,settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `wally_team[WALLY_GARDEVOIR]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:558:17 [INFO] [stdout] | [INFO] [stdout] 558 | / (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 559 | | legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 558 - (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 559 - legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 558 + !(!has_legend || legend_rule != settings::AllowLegendaries::OneLegend && legend_rule != settings::AllowLegendaries::AceLegend) [INFO] [stdout] | [INFO] [stdout] 558 - (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 559 - legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 558 + (legend_rule == settings::AllowLegendaries::AceLegend || legend_rule == settings::AllowLegendaries::OneLegend) && has_legend [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:574:5 [INFO] [stdout] | [INFO] [stdout] 574 | return new_trainer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 574 - return new_trainer; [INFO] [stdout] 574 + new_trainer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:557:98 [INFO] [stdout] | [INFO] [stdout] 557 | ...r_trainer(trainer.clone().trainer_name, &cur_pokemon,all_stats,settings,if settings.allow_trainer_legendaries.clone() == setting... [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `cur_pokemon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:557:130 [INFO] [stdout] | [INFO] [stdout] 557 | ... let pokemon = trainers::get_random_pokemon_for_trainer(trainer.clone().trainer_name, &cur_pokemon,all_stats,settings,if set... [INFO] [stdout] | ____________________________________________________________________________________________________________________________^ [INFO] [stdout] 558 | | ... (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 559 | | ... legend_rule == settings::AllowLegendaries::AceLegend && has_legend) [INFO] [stdout] 560 | | ... {false}else{true}); [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] help: you can reduce it to [INFO] [stdout] | [INFO] [stdout] 557 ~ let pokemon = trainers::get_random_pokemon_for_trainer(trainer.clone().trainer_name, &cur_pokemon,all_stats,settings,!(settings.allow_trainer_legendaries.clone() == settings::AllowLegendaries::NoLegends || (legend_rule == settings::AllowLegendaries::OneLegend && has_legend || [INFO] [stdout] 558 ~ legend_rule == settings::AllowLegendaries::AceLegend && has_legend))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:660:40 [INFO] [stdout] | [INFO] [stdout] 660 | species: scale_pokemon(rival_team[RIVAL_TROPIUS].clone(), 13, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_TROPIUS]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:661:73 [INFO] [stdout] | [INFO] [stdout] 661 | ... scale_pokemon(rival_team[RIVAL_TROPIUS].clone(), 13, all_stats, &mut settings.clone()).pokemon_id, 13, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_TROPIUS]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:662:80 [INFO] [stdout] | [INFO] [stdout] 662 | ... scale_pokemon(rival_team[RIVAL_TROPIUS].clone(), 13, all_stats, &mut settings.clone()).pokemon_id, 13, "".to_string(),true,all_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_TROPIUS]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:668:40 [INFO] [stdout] | [INFO] [stdout] 668 | species: scale_pokemon(starter.clone(), 15, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:669:73 [INFO] [stdout] | [INFO] [stdout] 669 | ... moves: trainers::create_moveset(settings, scale_pokemon(starter.clone(), 15, all_stats, &mut settings.clone()).pokemon_id, 15... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:646:5 [INFO] [stdout] | [INFO] [stdout] 646 | return random_rival; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 646 - return random_rival; [INFO] [stdout] 646 + random_rival [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:670:80 [INFO] [stdout] | [INFO] [stdout] 670 | ... held_items: trainers::create_held_item(settings, scale_pokemon(starter.clone(), 15, all_stats, &mut settings.clone()).pokemon... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/src/gen3/emerald/other.rs:4:78 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn randomize_birch_pokemon(settings: &mut settings::Settings, all_stats: &Vec){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - pub fn randomize_birch_pokemon(settings: &mut settings::Settings, all_stats: &Vec){ [INFO] [stdout] 4 + pub fn randomize_birch_pokemon(settings: &mut settings::Settings, all_stats: &[pokemon::PokemonStats]){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:678:40 [INFO] [stdout] | [INFO] [stdout] 678 | species: scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:679:73 [INFO] [stdout] | [INFO] [stdout] 679 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, &mut settings.clone()).pokemon_id, 18, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:680:80 [INFO] [stdout] | [INFO] [stdout] 680 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, &mut settings.clone()).pokemon_id, 18, "".to_string(),true,all_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:769:5 [INFO] [stdout] | [INFO] [stdout] 769 | return trainer; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 769 - return trainer; [INFO] [stdout] 769 + trainer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:687:73 [INFO] [stdout] | [INFO] [stdout] 687 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, &mut settings.clone()).pokemon_id, 18, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:688:80 [INFO] [stdout] | [INFO] [stdout] 688 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, &mut settings.clone()).pokemon_id, 18, "".to_string(),true,all_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:660:40 [INFO] [stdout] | [INFO] [stdout] 660 | species: scale_pokemon(rival_team[RIVAL_TROPIUS].clone(), 13, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_TROPIUS]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:21:116 [INFO] [stdout] | [INFO] [stdout] 21 | ...s,pokemon_data: &Vec,rival: &Vec>){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 21 - pub fn randomize_static_pokemon(settings: &mut settings::Settings,pokemon_data: &Vec,rival: &Vec>){ [INFO] [stdout] 21 + pub fn randomize_static_pokemon(settings: &mut settings::Settings,pokemon_data: &Vec,rival: &[Vec]){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:661:73 [INFO] [stdout] | [INFO] [stdout] 661 | ... scale_pokemon(rival_team[RIVAL_TROPIUS].clone(), 13, all_stats, &mut settings.clone()).pokemon_id, 13, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_TROPIUS]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | return legends; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return legends; [INFO] [stdout] 50 + legends [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:662:80 [INFO] [stdout] | [INFO] [stdout] 662 | ... scale_pokemon(rival_team[RIVAL_TROPIUS].clone(), 13, all_stats, &mut settings.clone()).pokemon_id, 13, "".to_string(),true,all_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_TROPIUS]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `levels` [INFO] [stdout] --> src/src/gen3/emerald/static_pokemon.rs:47:14 [INFO] [stdout] | [INFO] [stdout] 47 | for i in 0..9{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 47 - for i in 0..9{ [INFO] [stdout] 47 + for in levels.iter().take(9){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:668:40 [INFO] [stdout] | [INFO] [stdout] 668 | species: scale_pokemon(starter.clone(), 15, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/startup_stuff.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return final_string [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return final_string [INFO] [stdout] 11 + final_string [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:669:73 [INFO] [stdout] | [INFO] [stdout] 669 | ... moves: trainers::create_moveset(settings, scale_pokemon(starter.clone(), 15, all_stats, &mut settings.clone()).pokemon_id, 15... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/src/gen3/emerald/startup_stuff.rs:9:27 [INFO] [stdout] | [INFO] [stdout] 9 | final_string.push_str(&get_level_cap(settings).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `get_level_cap(settings).as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:670:80 [INFO] [stdout] | [INFO] [stdout] 670 | ... held_items: trainers::create_held_item(settings, scale_pokemon(starter.clone(), 15, all_stats, &mut settings.clone()).pokemon... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*starter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:678:40 [INFO] [stdout] | [INFO] [stdout] 678 | species: scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, settings).pokemon_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/startup_stuff.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / return if settings.make_pokeballs_masterballs{ [INFO] [stdout] 18 | | "setflag FLAG_ALL_BALLS_MASTERBALL\n".to_string() [INFO] [stdout] 19 | | } [INFO] [stdout] 20 | | else{ [INFO] [stdout] 21 | | "clearflag FLAG_ALL_BALLS_MASTERBALL\n".to_string() [INFO] [stdout] 22 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ if settings.make_pokeballs_masterballs{ [INFO] [stdout] 18 + "setflag FLAG_ALL_BALLS_MASTERBALL\n".to_string() [INFO] [stdout] 19 + } [INFO] [stdout] 20 + else{ [INFO] [stdout] 21 + "clearflag FLAG_ALL_BALLS_MASTERBALL\n".to_string() [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:679:73 [INFO] [stdout] | [INFO] [stdout] 679 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, &mut settings.clone()).pokemon_id, 18, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:680:80 [INFO] [stdout] | [INFO] [stdout] 680 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, &mut settings.clone()).pokemon_id, 18, "".to_string(),true,all_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/startup_stuff.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / return if settings.allow_hm_use{ [INFO] [stdout] 27 | | "clearflag FLAG_HMS_NEED_BADGES\n".to_string() [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | else{ [INFO] [stdout] 30 | | "setflag FLAG_HMS_NEED_BADGES\n".to_string() [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 ~ if settings.allow_hm_use{ [INFO] [stdout] 27 + "clearflag FLAG_HMS_NEED_BADGES\n".to_string() [INFO] [stdout] 28 + } [INFO] [stdout] 29 + else{ [INFO] [stdout] 30 + "setflag FLAG_HMS_NEED_BADGES\n".to_string() [INFO] [stdout] 31 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:687:73 [INFO] [stdout] | [INFO] [stdout] 687 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, &mut settings.clone()).pokemon_id, 18, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pokemon` which implements the `Copy` trait [INFO] [stdout] --> src/src/gen3/emerald/special_trainers.rs:688:80 [INFO] [stdout] | [INFO] [stdout] 688 | ...scale_pokemon(rival_team[RIVAL_LUDICOLO].clone(), 18, all_stats, &mut settings.clone()).pokemon_id, 18, "".to_string(),true,all_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rival_team[RIVAL_LUDICOLO]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/src/gen3/emerald/startup_stuff.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | / return if settings.rare_candy_modification{ [INFO] [stdout] 36 | | "setflag FLAG_RARE_CANDY_MOD\n".to_string() [INFO] [stdout] 37 | | } [INFO] [stdout] 38 | | else{ [INFO] [stdout] 39 | | "clearflag FLAG_RARE_CANDY_MOD\n".to_string() [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 ~ if settings.rare_candy_modification{ [INFO] [stdout] 36 + "setflag FLAG_RARE_CANDY_MOD\n".to_string() [WARN] too many lines in the log, truncating it