[INFO] cloning repository https://github.com/Keksoj/uri_parser [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Keksoj/uri_parser" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKeksoj%2Furi_parser", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKeksoj%2Furi_parser'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fd8c401aed1b21ec4072ca259d10d75ac14b1f0e [INFO] linting Keksoj/uri_parser against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKeksoj%2Furi_parser" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Keksoj/uri_parser [INFO] finished tweaking git repo https://github.com/Keksoj/uri_parser [INFO] tweaked toml for git repo https://github.com/Keksoj/uri_parser written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Keksoj/uri_parser on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Keksoj/uri_parser already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded nom v7.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 320008d6b82857c9458a7a13a28446f89152dd7aad82d1b6f5d5438df2fa842b [INFO] running `Command { std: "docker" "start" "-a" "320008d6b82857c9458a7a13a28446f89152dd7aad82d1b6f5d5438df2fa842b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "320008d6b82857c9458a7a13a28446f89152dd7aad82d1b6f5d5438df2fa842b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "320008d6b82857c9458a7a13a28446f89152dd7aad82d1b6f5d5438df2fa842b", kill_on_drop: false }` [INFO] [stdout] 320008d6b82857c9458a7a13a28446f89152dd7aad82d1b6f5d5438df2fa842b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dbed8484fca19d5ea7fa733e544969c94f0ba48ff1f2ba09e50d104beda71381 [INFO] running `Command { std: "docker" "start" "-a" "dbed8484fca19d5ea7fa733e544969c94f0ba48ff1f2ba09e50d104beda71381", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling nom v7.1.0 [INFO] [stderr] Checking uri_parser v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: name `HOST` contains a capitalized acronym [INFO] [stdout] --> src/uri/host.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | HOST(String), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Host` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/uri/host.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | take(0 as usize), // bytes::complete::take [INFO] [stdout] | ^^^^^^^^^^ help: try: `0_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/uri/host.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | !(char_item == '-') && !char_item.is_alphanum() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/uri/path.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | !(char_item == '-') && !char_item.is_alphanum() && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/uri/path.rs:21:64 [INFO] [stdout] | [INFO] [stdout] 21 | !(char_item == '-') && !char_item.is_alphanum() && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HOST` contains a capitalized acronym [INFO] [stdout] --> src/uri/host.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | HOST(String), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Host` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/uri/host.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | take(0 as usize), // bytes::complete::take [INFO] [stdout] | ^^^^^^^^^^ help: try: `0_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/uri/host.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | !(char_item == '-') && !char_item.is_alphanum() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/uri/path.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | !(char_item == '-') && !char_item.is_alphanum() && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/uri/path.rs:21:64 [INFO] [stdout] | [INFO] [stdout] 21 | !(char_item == '-') && !char_item.is_alphanum() && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HTTP` contains a capitalized acronym [INFO] [stdout] --> src/uri/scheme.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | HTTP, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Http` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HTTPS` contains a capitalized acronym [INFO] [stdout] --> src/uri/scheme.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | HTTPS, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Https` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HTTP` contains a capitalized acronym [INFO] [stdout] --> src/uri/scheme.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | HTTP, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Http` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HTTPS` contains a capitalized acronym [INFO] [stdout] --> src/uri/scheme.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | HTTPS, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Https` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `URI` contains a capitalized acronym [INFO] [stdout] --> src/uri/mod.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 51 | pub struct URI<'a> { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Uri` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `URI` contains a capitalized acronym [INFO] [stdout] --> src/uri/mod.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 51 | pub struct URI<'a> { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Uri` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u16` is unnecessary [INFO] [stdout] --> src/uri/mod.rs:119:28 [INFO] [stdout] | [INFO] [stdout] 119 | port: Some(65_000 as u16), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `65_000_u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/uri/mod.rs:61:26 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn uri_parser(input: &str) -> CustomResult<&str, URI> { [INFO] [stdout] | ^^^^ ^^^^ ^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 61 | pub fn uri_parser(input: &str) -> CustomResult<&str, URI<'_>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/uri/authority.rs:14:32 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn authority_parser(input: &str) -> CustomResult<&str, Authority> { [INFO] [stdout] | ^^^^ ^^^^ ^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 14 | pub fn authority_parser(input: &str) -> CustomResult<&str, Authority<'_>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/uri/query.rs:22:35 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn query_params_parser(input: &str) -> CustomResult<&str, Vec> { [INFO] [stdout] | ^^^^ ^^^^ ^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 22 | pub fn query_params_parser(input: &str) -> CustomResult<&str, Vec>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/uri/mod.rs:61:26 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn uri_parser(input: &str) -> CustomResult<&str, URI> { [INFO] [stdout] | ^^^^ ^^^^ ^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 61 | pub fn uri_parser(input: &str) -> CustomResult<&str, URI<'_>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/uri/authority.rs:14:32 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn authority_parser(input: &str) -> CustomResult<&str, Authority> { [INFO] [stdout] | ^^^^ ^^^^ ^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 14 | pub fn authority_parser(input: &str) -> CustomResult<&str, Authority<'_>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/uri/query.rs:22:35 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn query_params_parser(input: &str) -> CustomResult<&str, Vec> { [INFO] [stdout] | ^^^^ ^^^^ ^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 22 | pub fn query_params_parser(input: &str) -> CustomResult<&str, Vec>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.78s [INFO] running `Command { std: "docker" "inspect" "dbed8484fca19d5ea7fa733e544969c94f0ba48ff1f2ba09e50d104beda71381", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dbed8484fca19d5ea7fa733e544969c94f0ba48ff1f2ba09e50d104beda71381", kill_on_drop: false }` [INFO] [stdout] dbed8484fca19d5ea7fa733e544969c94f0ba48ff1f2ba09e50d104beda71381