[INFO] cloning repository https://github.com/Katamithetaka/codecrafters-sqlite-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Katamithetaka/codecrafters-sqlite-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKatamithetaka%2Fcodecrafters-sqlite-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKatamithetaka%2Fcodecrafters-sqlite-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 02f29c470a8d6f8611b407848bc733658d17ba51 [INFO] linting Katamithetaka/codecrafters-sqlite-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKatamithetaka%2Fcodecrafters-sqlite-rust" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Katamithetaka/codecrafters-sqlite-rust [INFO] finished tweaking git repo https://github.com/Katamithetaka/codecrafters-sqlite-rust [INFO] tweaked toml for git repo https://github.com/Katamithetaka/codecrafters-sqlite-rust written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Katamithetaka/codecrafters-sqlite-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Katamithetaka/codecrafters-sqlite-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 13dd2cb4f8fda445beca1b446cd29d96f2be009c4d4f106260cb3156a6e5898e [INFO] running `Command { std: "docker" "start" "-a" "13dd2cb4f8fda445beca1b446cd29d96f2be009c4d4f106260cb3156a6e5898e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "13dd2cb4f8fda445beca1b446cd29d96f2be009c4d4f106260cb3156a6e5898e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "13dd2cb4f8fda445beca1b446cd29d96f2be009c4d4f106260cb3156a6e5898e", kill_on_drop: false }` [INFO] [stdout] 13dd2cb4f8fda445beca1b446cd29d96f2be009c4d4f106260cb3156a6e5898e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f88558dcdbfb5fe24aca75c01a6d356e1e8ce092118797edda272a83b780147 [INFO] running `Command { std: "docker" "start" "-a" "1f88558dcdbfb5fe24aca75c01a6d356e1e8ce092118797edda272a83b780147", kill_on_drop: false }` [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking codecrafters-sqlite v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cell.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | records_begin: records_begin, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `records_begin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/index_parser.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | root_page: root_page, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_page` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cell.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | records_begin: records_begin, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `records_begin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/reader.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | file: file, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/reader.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | header: header, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/reader.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | page_header: page_header, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `page_header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/select_builder.rs:302:13 [INFO] [stdout] | [INFO] [stdout] 302 | where_comps: where_comps, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `where_comps` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/index_parser.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | root_page: root_page, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_page` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/reader.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | file: file, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/reader.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | header: header, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/reader.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | page_header: page_header, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `page_header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/select_builder.rs:302:13 [INFO] [stdout] | [INFO] [stdout] 302 | where_comps: where_comps, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `where_comps` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / return Ok(LazyLeafCell { [INFO] [stdout] 28 | | record_size, [INFO] [stdout] 29 | | rowid, [INFO] [stdout] 30 | | records_begin: offset, [INFO] [stdout] 31 | | record_types: serial_types, [INFO] [stdout] 32 | | page_data, [INFO] [stdout] 33 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 ~ Ok(LazyLeafCell { [INFO] [stdout] 28 + record_size, [INFO] [stdout] 29 + rowid, [INFO] [stdout] 30 + records_begin: offset, [INFO] [stdout] 31 + record_types: serial_types, [INFO] [stdout] 32 + page_data, [INFO] [stdout] 33 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | / return Ok(InteriorCell { [INFO] [stdout] 41 | | page_number, [INFO] [stdout] 42 | | rowid: row_id, [INFO] [stdout] 43 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 ~ Ok(InteriorCell { [INFO] [stdout] 41 + page_number, [INFO] [stdout] 42 + rowid: row_id, [INFO] [stdout] 43 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return Ok(row_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Ok(row_id); [INFO] [stdout] 75 + Ok(row_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/cell.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 69 | row_id.rowid = i128::from_str_radix(row_id.get_column(serial_types.len()-1)?.as_str(), 10).map_err(|_| ParsingError::InvalidVari... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `row_id.get_column(serial_types.len()-1)?.as_str().parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 119 | return Ok(v.into_iter().flatten().collect()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 119 - return Ok(v.into_iter().flatten().collect()); [INFO] [stdout] 119 + Ok(v.into_iter().flatten().collect()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / return Ok(LazyLeafCell { [INFO] [stdout] 28 | | record_size, [INFO] [stdout] 29 | | rowid, [INFO] [stdout] 30 | | records_begin: offset, [INFO] [stdout] 31 | | record_types: serial_types, [INFO] [stdout] 32 | | page_data, [INFO] [stdout] 33 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 ~ Ok(LazyLeafCell { [INFO] [stdout] 28 + record_size, [INFO] [stdout] 29 + rowid, [INFO] [stdout] 30 + records_begin: offset, [INFO] [stdout] 31 + record_types: serial_types, [INFO] [stdout] 32 + page_data, [INFO] [stdout] 33 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 181 | return Ok(results); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 181 - return Ok(results); [INFO] [stdout] 181 + Ok(results) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | / return Ok(InteriorCell { [INFO] [stdout] 41 | | page_number, [INFO] [stdout] 42 | | rowid: row_id, [INFO] [stdout] 43 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 ~ Ok(InteriorCell { [INFO] [stdout] 41 + page_number, [INFO] [stdout] 42 + rowid: row_id, [INFO] [stdout] 43 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return Ok(row_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Ok(row_id); [INFO] [stdout] 75 + Ok(row_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/cell.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 69 | row_id.rowid = i128::from_str_radix(row_id.get_column(serial_types.len()-1)?.as_str(), 10).map_err(|_| ParsingError::InvalidVari... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `row_id.get_column(serial_types.len()-1)?.as_str().parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/cell.rs:168:34 [INFO] [stdout] | [INFO] [stdout] 168 | let above_prev = prev_rowid.map_or(true, |prev| rowid > prev); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 168 - let above_prev = prev_rowid.map_or(true, |prev| rowid > prev); [INFO] [stdout] 168 + let above_prev = prev_rowid.is_none_or(|prev| rowid > prev); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 119 | return Ok(v.into_iter().flatten().collect()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 119 - return Ok(v.into_iter().flatten().collect()); [INFO] [stdout] 119 + Ok(v.into_iter().flatten().collect()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:202:5 [INFO] [stdout] | [INFO] [stdout] 202 | return Ok(results); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 - return Ok(results); [INFO] [stdout] 202 + Ok(results) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/cell.rs:197:10 [INFO] [stdout] | [INFO] [stdout] 197 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 181 | return Ok(results); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 181 - return Ok(results); [INFO] [stdout] 181 + Ok(results) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:263:13 [INFO] [stdout] | [INFO] [stdout] 263 | return Ok(return_val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 - return Ok(return_val); [INFO] [stdout] 263 + Ok(return_val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:295:13 [INFO] [stdout] | [INFO] [stdout] 295 | return Ok(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - return Ok(result); [INFO] [stdout] 295 + Ok(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/cell.rs:168:34 [INFO] [stdout] | [INFO] [stdout] 168 | let above_prev = prev_rowid.map_or(true, |prev| rowid > prev); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 168 - let above_prev = prev_rowid.map_or(true, |prev| rowid > prev); [INFO] [stdout] 168 + let above_prev = prev_rowid.is_none_or(|prev| rowid > prev); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:202:5 [INFO] [stdout] | [INFO] [stdout] 202 | return Ok(results); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 - return Ok(results); [INFO] [stdout] 202 + Ok(results) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/cell.rs:197:10 [INFO] [stdout] | [INFO] [stdout] 197 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:263:13 [INFO] [stdout] | [INFO] [stdout] 263 | return Ok(return_val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 - return Ok(return_val); [INFO] [stdout] 263 + Ok(return_val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:295:13 [INFO] [stdout] | [INFO] [stdout] 295 | return Ok(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - return Ok(result); [INFO] [stdout] 295 + Ok(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:425:13 [INFO] [stdout] | [INFO] [stdout] 425 | return Ok(results); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 425 - return Ok(results); [INFO] [stdout] 425 + Ok(results) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `parsed` [INFO] [stdout] --> src/cell.rs:341:30 [INFO] [stdout] | [INFO] [stdout] 341 | for i in 0..parsed.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 341 - for i in 0..parsed.len() { [INFO] [stdout] 341 + for in &parsed { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cell.rs:425:13 [INFO] [stdout] | [INFO] [stdout] 425 | return Ok(results); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 425 - return Ok(results); [INFO] [stdout] 425 + Ok(results) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `parsed` [INFO] [stdout] --> src/cell.rs:372:30 [INFO] [stdout] | [INFO] [stdout] 372 | for i in 0..parsed.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 372 - for i in 0..parsed.len() { [INFO] [stdout] 372 + for in &parsed { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `parsed` [INFO] [stdout] --> src/cell.rs:341:30 [INFO] [stdout] | [INFO] [stdout] 341 | for i in 0..parsed.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 341 - for i in 0..parsed.len() { [INFO] [stdout] 341 + for in &parsed { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `parsed` [INFO] [stdout] --> src/cell.rs:372:30 [INFO] [stdout] | [INFO] [stdout] 372 | for i in 0..parsed.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 372 - for i in 0..parsed.len() { [INFO] [stdout] 372 + for in &parsed { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/index_parser.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | / return Ok(IndexData { [INFO] [stdout] 38 | | index_name: index_name.to_string(), [INFO] [stdout] 39 | | table_name: table_name.to_string(), [INFO] [stdout] 40 | | columns, [INFO] [stdout] 41 | | root_page: root_page, [INFO] [stdout] 42 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 ~ Ok(IndexData { [INFO] [stdout] 38 + index_name: index_name.to_string(), [INFO] [stdout] 39 + table_name: table_name.to_string(), [INFO] [stdout] 40 + columns, [INFO] [stdout] 41 + root_page: root_page, [INFO] [stdout] 42 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/index_parser.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | / return Ok(IndexData { [INFO] [stdout] 38 | | index_name: index_name.to_string(), [INFO] [stdout] 39 | | table_name: table_name.to_string(), [INFO] [stdout] 40 | | columns, [INFO] [stdout] 41 | | root_page: root_page, [INFO] [stdout] 42 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 ~ Ok(IndexData { [INFO] [stdout] 38 + index_name: index_name.to_string(), [INFO] [stdout] 39 + table_name: table_name.to_string(), [INFO] [stdout] 40 + columns, [INFO] [stdout] 41 + root_page: root_page, [INFO] [stdout] 42 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/leaf_cell.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return Ok(value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return Ok(value); [INFO] [stdout] 82 + Ok(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/leaf_cell.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | / return match self { [INFO] [stdout] 87 | | SerialType::Null => 0, [INFO] [stdout] 88 | | SerialType::I8 => 1, [INFO] [stdout] 89 | | SerialType::I16 => 2, [INFO] [stdout] ... | [INFO] [stdout] 99 | | SerialType::String(size) => *size, [INFO] [stdout] 100 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 ~ match self { [INFO] [stdout] 87 + SerialType::Null => 0, [INFO] [stdout] 88 + SerialType::I8 => 1, [INFO] [stdout] 89 + SerialType::I16 => 2, [INFO] [stdout] 90 + SerialType::I24 => 3, [INFO] [stdout] 91 + SerialType::I32 => 4, [INFO] [stdout] 92 + SerialType::I48 => 6, [INFO] [stdout] 93 + SerialType::I64 => 8, [INFO] [stdout] 94 + SerialType::Double => 8, [INFO] [stdout] 95 + SerialType::False => 0, [INFO] [stdout] 96 + SerialType::True => 0, [INFO] [stdout] 97 + SerialType::Unused => 0, [INFO] [stdout] 98 + SerialType::Blob(size) => *size, [INFO] [stdout] 99 + SerialType::String(size) => *size, [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/leaf_cell.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return Ok(value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return Ok(value); [INFO] [stdout] 82 + Ok(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/leaf_cell.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | / return match self { [INFO] [stdout] 87 | | SerialType::Null => 0, [INFO] [stdout] 88 | | SerialType::I8 => 1, [INFO] [stdout] 89 | | SerialType::I16 => 2, [INFO] [stdout] ... | [INFO] [stdout] 99 | | SerialType::String(size) => *size, [INFO] [stdout] 100 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 ~ match self { [INFO] [stdout] 87 + SerialType::Null => 0, [INFO] [stdout] 88 + SerialType::I8 => 1, [INFO] [stdout] 89 + SerialType::I16 => 2, [INFO] [stdout] 90 + SerialType::I24 => 3, [INFO] [stdout] 91 + SerialType::I32 => 4, [INFO] [stdout] 92 + SerialType::I48 => 6, [INFO] [stdout] 93 + SerialType::I64 => 8, [INFO] [stdout] 94 + SerialType::Double => 8, [INFO] [stdout] 95 + SerialType::False => 0, [INFO] [stdout] 96 + SerialType::True => 0, [INFO] [stdout] 97 + SerialType::Unused => 0, [INFO] [stdout] 98 + SerialType::Blob(size) => *size, [INFO] [stdout] 99 + SerialType::String(size) => *size, [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/leaf_cell.rs:118:44 [INFO] [stdout] | [INFO] [stdout] 118 | SerialType::String(size) => Ok(format!( [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 119 | | "{}", [INFO] [stdout] 120 | | String::from_utf8_lossy(&bytes[0..*size]).to_string() [INFO] [stdout] 121 | | )), [INFO] [stdout] | |_____________^ help: consider using `.to_string()`: `String::from_utf8_lossy(&bytes[0..*size]).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/leaf_cell.rs:120:58 [INFO] [stdout] | [INFO] [stdout] 120 | String::from_utf8_lossy(&bytes[0..*size]).to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/leaf_cell.rs:130:35 [INFO] [stdout] | [INFO] [stdout] 130 | SerialType::I24 => Ok(format!("{}", format!("{}", "unimplemented i24"))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `format!("{}", "unimplemented i24").to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/leaf_cell.rs:130:35 [INFO] [stdout] | [INFO] [stdout] 130 | SerialType::I24 => Ok(format!("{}", format!("{}", "unimplemented i24"))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/leaf_cell.rs:132:35 [INFO] [stdout] | [INFO] [stdout] 132 | SerialType::I48 => Ok(format!("{}", format!("{}", "unimplemented i48"))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `format!("{}", "unimplemented i48").to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/leaf_cell.rs:132:35 [INFO] [stdout] | [INFO] [stdout] 132 | SerialType::I48 => Ok(format!("{}", format!("{}", "unimplemented i48"))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/leaf_cell.rs:118:44 [INFO] [stdout] | [INFO] [stdout] 118 | SerialType::String(size) => Ok(format!( [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 119 | | "{}", [INFO] [stdout] 120 | | String::from_utf8_lossy(&bytes[0..*size]).to_string() [INFO] [stdout] 121 | | )), [INFO] [stdout] | |_____________^ help: consider using `.to_string()`: `String::from_utf8_lossy(&bytes[0..*size]).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/leaf_cell.rs:120:58 [INFO] [stdout] | [INFO] [stdout] 120 | String::from_utf8_lossy(&bytes[0..*size]).to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/leaf_cell.rs:130:35 [INFO] [stdout] | [INFO] [stdout] 130 | SerialType::I24 => Ok(format!("{}", format!("{}", "unimplemented i24"))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `format!("{}", "unimplemented i24").to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/leaf_cell.rs:130:35 [INFO] [stdout] | [INFO] [stdout] 130 | SerialType::I24 => Ok(format!("{}", format!("{}", "unimplemented i24"))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/leaf_cell.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | / return self.record_types[0..column] [INFO] [stdout] 158 | | .iter() [INFO] [stdout] 159 | | .map(|value| value.size()) [INFO] [stdout] 160 | | .sum::() [INFO] [stdout] 161 | | + self.records_begin; [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 ~ self.record_types[0..column] [INFO] [stdout] 158 + .iter() [INFO] [stdout] 159 + .map(|value| value.size()) [INFO] [stdout] 160 + .sum::() [INFO] [stdout] 161 ~ + self.records_begin [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/leaf_cell.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | return self.record_types[column].size(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return self.record_types[column].size(); [INFO] [stdout] 165 + self.record_types[column].size() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/leaf_cell.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | return self.record_types[column]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return self.record_types[column]; [INFO] [stdout] 169 + self.record_types[column] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/leaf_cell.rs:132:35 [INFO] [stdout] | [INFO] [stdout] 132 | SerialType::I48 => Ok(format!("{}", format!("{}", "unimplemented i48"))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `format!("{}", "unimplemented i48").to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/leaf_cell.rs:132:35 [INFO] [stdout] | [INFO] [stdout] 132 | SerialType::I48 => Ok(format!("{}", format!("{}", "unimplemented i48"))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/page.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | assert!(remainder.len() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `remainder.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/page_header.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return Err(ParsingError::InvalidPageType) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return Err(ParsingError::InvalidPageType) [INFO] [stdout] 37 + Err(ParsingError::InvalidPageType) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/leaf_cell.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | / return self.record_types[0..column] [INFO] [stdout] 158 | | .iter() [INFO] [stdout] 159 | | .map(|value| value.size()) [INFO] [stdout] 160 | | .sum::() [INFO] [stdout] 161 | | + self.records_begin; [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 ~ self.record_types[0..column] [INFO] [stdout] 158 + .iter() [INFO] [stdout] 159 + .map(|value| value.size()) [INFO] [stdout] 160 + .sum::() [INFO] [stdout] 161 ~ + self.records_begin [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/leaf_cell.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | return self.record_types[column].size(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return self.record_types[column].size(); [INFO] [stdout] 165 + self.record_types[column].size() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/leaf_cell.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | return self.record_types[column]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return self.record_types[column]; [INFO] [stdout] 169 + self.record_types[column] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/page.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | assert!(remainder.len() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `remainder.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/page_header.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return Err(ParsingError::InvalidPageType) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return Err(ParsingError::InvalidPageType) [INFO] [stdout] 37 + Err(ParsingError::InvalidPageType) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parsing_error.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return ParsingError::IoError(value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return ParsingError::IoError(value) [INFO] [stdout] 47 + ParsingError::IoError(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parsing_error.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return ParsingError::SliceConversionError(value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return ParsingError::SliceConversionError(value) [INFO] [stdout] 53 + ParsingError::SliceConversionError(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/reader.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return &buffer[begin_index..end_index]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return &buffer[begin_index..end_index]; [INFO] [stdout] 16 + &buffer[begin_index..end_index] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/reader.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | / return Ok(SqliteReader { [INFO] [stdout] 46 | | file: file, [INFO] [stdout] 47 | | buffer: vec![0; header.page_size as usize], [INFO] [stdout] 48 | | header: header, [INFO] [stdout] 49 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 ~ Ok(SqliteReader { [INFO] [stdout] 46 + file: file, [INFO] [stdout] 47 + buffer: vec![0; header.page_size as usize], [INFO] [stdout] 48 + header: header, [INFO] [stdout] 49 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/reader.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / return Ok(Page { [INFO] [stdout] 61 | | page_header: page_header, [INFO] [stdout] 62 | | page: self.buffer[..].into(), [INFO] [stdout] 63 | | page_start: offset, [INFO] [stdout] 64 | | page_offset, [INFO] [stdout] 65 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 ~ Ok(Page { [INFO] [stdout] 61 + page_header: page_header, [INFO] [stdout] 62 + page: self.buffer[..].into(), [INFO] [stdout] 63 + page_start: offset, [INFO] [stdout] 64 + page_offset, [INFO] [stdout] 65 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parsing_error.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return ParsingError::IoError(value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return ParsingError::IoError(value) [INFO] [stdout] 47 + ParsingError::IoError(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parsing_error.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return ParsingError::SliceConversionError(value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return ParsingError::SliceConversionError(value) [INFO] [stdout] 53 + ParsingError::SliceConversionError(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/reader.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return &buffer[begin_index..end_index]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return &buffer[begin_index..end_index]; [INFO] [stdout] 16 + &buffer[begin_index..end_index] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/reader.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | / return Ok(SqliteReader { [INFO] [stdout] 46 | | file: file, [INFO] [stdout] 47 | | buffer: vec![0; header.page_size as usize], [INFO] [stdout] 48 | | header: header, [INFO] [stdout] 49 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 ~ Ok(SqliteReader { [INFO] [stdout] 46 + file: file, [INFO] [stdout] 47 + buffer: vec![0; header.page_size as usize], [INFO] [stdout] 48 + header: header, [INFO] [stdout] 49 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/reader.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / return Ok(Page { [INFO] [stdout] 61 | | page_header: page_header, [INFO] [stdout] 62 | | page: self.buffer[..].into(), [INFO] [stdout] 63 | | page_start: offset, [INFO] [stdout] 64 | | page_offset, [INFO] [stdout] 65 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 ~ Ok(Page { [INFO] [stdout] 61 + page_header: page_header, [INFO] [stdout] 62 + page: self.buffer[..].into(), [INFO] [stdout] 63 + page_start: offset, [INFO] [stdout] 64 + page_offset, [INFO] [stdout] 65 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | / return Self { [INFO] [stdout] 86 | | combinator: Some(Combinator::Or(Box::new(other))), [INFO] [stdout] 87 | | ..self [INFO] [stdout] 88 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 ~ Self { [INFO] [stdout] 86 + combinator: Some(Combinator::Or(Box::new(other))), [INFO] [stdout] 87 + ..self [INFO] [stdout] 88 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | / return Self { [INFO] [stdout] 93 | | combinator: Some(Combinator::And(Box::new(other))), [INFO] [stdout] 94 | | ..self [INFO] [stdout] 95 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 ~ Self { [INFO] [stdout] 93 + combinator: Some(Combinator::And(Box::new(other))), [INFO] [stdout] 94 + ..self [INFO] [stdout] 95 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/select_builder.rs:98:27 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn execute(&self, page_bytes: &[u8], cell: &LazyLeafCell) -> Result { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_page_bytes` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/select_builder.rs:106:74 [INFO] [stdout] | [INFO] [stdout] 106 | Some(Combinator::And(value)) => Ok(own_comp && value.execute(page_bytes, cell)?), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 107 | Some(Combinator::Or(value)) => Ok(own_comp || value.execute(page_bytes, cell)?), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | / return Ok(Where { [INFO] [stdout] 132 | | expression: Expression { [INFO] [stdout] 133 | | column, [INFO] [stdout] 134 | | op: comp.expression.op, [INFO] [stdout] ... | [INFO] [stdout] 137 | | combinator, [INFO] [stdout] 138 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 ~ Ok(Where { [INFO] [stdout] 132 + expression: Expression { [INFO] [stdout] 133 + column, [INFO] [stdout] 134 + op: comp.expression.op, [INFO] [stdout] 135 + value: comp.expression.value.clone(), [INFO] [stdout] 136 + }, [INFO] [stdout] 137 + combinator, [INFO] [stdout] 138 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/select_builder.rs:123:64 [INFO] [stdout] | [INFO] [stdout] 123 | Some(Combinator::And(Box::new(Self::from_table(&comb, table)?))) [INFO] [stdout] | ^^^^^ help: change this to: `comb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/select_builder.rs:126:63 [INFO] [stdout] | [INFO] [stdout] 126 | Some(Combinator::Or(Box::new(Self::from_table(&comb, table)?))) [INFO] [stdout] | ^^^^^ help: change this to: `comb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | return op.apply(&lhs_unquoted, &rhs_unquoted); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return op.apply(&lhs_unquoted, &rhs_unquoted); [INFO] [stdout] 147 + op.apply(&lhs_unquoted, &rhs_unquoted) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | / return Where { [INFO] [stdout] 152 | | expression: Expression { column, op, value }, [INFO] [stdout] 153 | | combinator: None, [INFO] [stdout] 154 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 ~ Where { [INFO] [stdout] 152 + expression: Expression { column, op, value }, [INFO] [stdout] 153 + combinator: None, [INFO] [stdout] 154 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | / return SelectBuilder { [INFO] [stdout] 167 | | index: None, [INFO] [stdout] 168 | | table, [INFO] [stdout] 169 | | columns, [INFO] [stdout] 170 | | where_comps: None, [INFO] [stdout] 171 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 166 ~ SelectBuilder { [INFO] [stdout] 167 + index: None, [INFO] [stdout] 168 + table, [INFO] [stdout] 169 + columns, [INFO] [stdout] 170 + where_comps: None, [INFO] [stdout] 171 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | / return Self { [INFO] [stdout] 86 | | combinator: Some(Combinator::Or(Box::new(other))), [INFO] [stdout] 87 | | ..self [INFO] [stdout] 88 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 ~ Self { [INFO] [stdout] 86 + combinator: Some(Combinator::Or(Box::new(other))), [INFO] [stdout] 87 + ..self [INFO] [stdout] 88 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | / return Self { [INFO] [stdout] 176 | | where_comps: Some(comp), [INFO] [stdout] 177 | | ..self [INFO] [stdout] 178 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 175 ~ Self { [INFO] [stdout] 176 + where_comps: Some(comp), [INFO] [stdout] 177 + ..self [INFO] [stdout] 178 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | / return Self { [INFO] [stdout] 93 | | combinator: Some(Combinator::And(Box::new(other))), [INFO] [stdout] 94 | | ..self [INFO] [stdout] 95 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 ~ Self { [INFO] [stdout] 93 + combinator: Some(Combinator::And(Box::new(other))), [INFO] [stdout] 94 + ..self [INFO] [stdout] 95 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 182 | / return Self { [INFO] [stdout] 183 | | index: Some((index_page, (op, value, index_column))), [INFO] [stdout] 184 | | ..self [INFO] [stdout] 185 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 182 ~ Self { [INFO] [stdout] 183 + index: Some((index_page, (op, value, index_column))), [INFO] [stdout] 184 + ..self [INFO] [stdout] 185 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:221:9 [INFO] [stdout] | [INFO] [stdout] 221 | / return cells [INFO] [stdout] 222 | | .iter() [INFO] [stdout] 223 | | .map(|cell| { [INFO] [stdout] 224 | | self.columns [INFO] [stdout] ... | [INFO] [stdout] 232 | | }) [INFO] [stdout] 233 | | .collect(); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 221 ~ cells [INFO] [stdout] 222 + .iter() [INFO] [stdout] 223 + .map(|cell| { [INFO] [stdout] 224 + self.columns [INFO] [stdout] 225 + .iter() [INFO] [stdout] 226 + .map(|column| match column { [INFO] [stdout] 227 + Column::RowId => Ok(cell.rowid.to_string()), [INFO] [stdout] 228 + Column::Count => Ok(count.to_string()), [INFO] [stdout] 229 + Column::Column(column) => cell.get_column(*column), [INFO] [stdout] 230 + }) [INFO] [stdout] 231 + .collect() [INFO] [stdout] 232 + }) [INFO] [stdout] 233 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/select_builder.rs:98:27 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn execute(&self, page_bytes: &[u8], cell: &LazyLeafCell) -> Result { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_page_bytes` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/select_builder.rs:106:74 [INFO] [stdout] | [INFO] [stdout] 106 | Some(Combinator::And(value)) => Ok(own_comp && value.execute(page_bytes, cell)?), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 107 | Some(Combinator::Or(value)) => Ok(own_comp || value.execute(page_bytes, cell)?), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | / return Ok(Where { [INFO] [stdout] 132 | | expression: Expression { [INFO] [stdout] 133 | | column, [INFO] [stdout] 134 | | op: comp.expression.op, [INFO] [stdout] ... | [INFO] [stdout] 137 | | combinator, [INFO] [stdout] 138 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 ~ Ok(Where { [INFO] [stdout] 132 + expression: Expression { [INFO] [stdout] 133 + column, [INFO] [stdout] 134 + op: comp.expression.op, [INFO] [stdout] 135 + value: comp.expression.value.clone(), [INFO] [stdout] 136 + }, [INFO] [stdout] 137 + combinator, [INFO] [stdout] 138 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/select_builder.rs:123:64 [INFO] [stdout] | [INFO] [stdout] 123 | Some(Combinator::And(Box::new(Self::from_table(&comb, table)?))) [INFO] [stdout] | ^^^^^ help: change this to: `comb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/select_builder.rs:126:63 [INFO] [stdout] | [INFO] [stdout] 126 | Some(Combinator::Or(Box::new(Self::from_table(&comb, table)?))) [INFO] [stdout] | ^^^^^ help: change this to: `comb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | return op.apply(&lhs_unquoted, &rhs_unquoted); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return op.apply(&lhs_unquoted, &rhs_unquoted); [INFO] [stdout] 147 + op.apply(&lhs_unquoted, &rhs_unquoted) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | / return Where { [INFO] [stdout] 152 | | expression: Expression { column, op, value }, [INFO] [stdout] 153 | | combinator: None, [INFO] [stdout] 154 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 ~ Where { [INFO] [stdout] 152 + expression: Expression { column, op, value }, [INFO] [stdout] 153 + combinator: None, [INFO] [stdout] 154 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/select_builder.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 217 | if &self.columns == &[Column::Count] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 217 - if &self.columns == &[Column::Count] { [INFO] [stdout] 217 + if self.columns == [Column::Count] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:298:9 [INFO] [stdout] | [INFO] [stdout] 298 | / return Ok(SelectBuilder { [INFO] [stdout] 299 | | index: table_index, [INFO] [stdout] 300 | | table: root_page, [INFO] [stdout] 301 | | columns, [INFO] [stdout] 302 | | where_comps: where_comps, [INFO] [stdout] 303 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 ~ Ok(SelectBuilder { [INFO] [stdout] 299 + index: table_index, [INFO] [stdout] 300 + table: root_page, [INFO] [stdout] 301 + columns, [INFO] [stdout] 302 + where_comps: where_comps, [INFO] [stdout] 303 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | / return SelectBuilder { [INFO] [stdout] 167 | | index: None, [INFO] [stdout] 168 | | table, [INFO] [stdout] 169 | | columns, [INFO] [stdout] 170 | | where_comps: None, [INFO] [stdout] 171 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 166 ~ SelectBuilder { [INFO] [stdout] 167 + index: None, [INFO] [stdout] 168 + table, [INFO] [stdout] 169 + columns, [INFO] [stdout] 170 + where_comps: None, [INFO] [stdout] 171 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | / return Self { [INFO] [stdout] 176 | | where_comps: Some(comp), [INFO] [stdout] 177 | | ..self [INFO] [stdout] 178 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 175 ~ Self { [INFO] [stdout] 176 + where_comps: Some(comp), [INFO] [stdout] 177 + ..self [INFO] [stdout] 178 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 182 | / return Self { [INFO] [stdout] 183 | | index: Some((index_page, (op, value, index_column))), [INFO] [stdout] 184 | | ..self [INFO] [stdout] 185 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 182 ~ Self { [INFO] [stdout] 183 + index: Some((index_page, (op, value, index_column))), [INFO] [stdout] 184 + ..self [INFO] [stdout] 185 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:221:9 [INFO] [stdout] | [INFO] [stdout] 221 | / return cells [INFO] [stdout] 222 | | .iter() [INFO] [stdout] 223 | | .map(|cell| { [INFO] [stdout] 224 | | self.columns [INFO] [stdout] ... | [INFO] [stdout] 232 | | }) [INFO] [stdout] 233 | | .collect(); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 221 ~ cells [INFO] [stdout] 222 + .iter() [INFO] [stdout] 223 + .map(|cell| { [INFO] [stdout] 224 + self.columns [INFO] [stdout] 225 + .iter() [INFO] [stdout] 226 + .map(|column| match column { [INFO] [stdout] 227 + Column::RowId => Ok(cell.rowid.to_string()), [INFO] [stdout] 228 + Column::Count => Ok(count.to_string()), [INFO] [stdout] 229 + Column::Column(column) => cell.get_column(*column), [INFO] [stdout] 230 + }) [INFO] [stdout] 231 + .collect() [INFO] [stdout] 232 + }) [INFO] [stdout] 233 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Result` [INFO] [stdout] --> src/select_builder.rs:266:22 [INFO] [stdout] | [INFO] [stdout] 266 | .map(|where_column| match where_column.expression.column { [INFO] [stdout] | ______________________^ [INFO] [stdout] 267 | | WhereColumn::RowId => Ok(( [INFO] [stdout] 268 | | where_column.expression.op, [INFO] [stdout] 269 | | where_column.expression.value, [INFO] [stdout] ... | [INFO] [stdout] 291 | | }) [INFO] [stdout] 292 | | .flatten(); [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `and_then` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 266 ~ .and_then(|where_column| match where_column.expression.column { [INFO] [stdout] 267 + WhereColumn::RowId => Ok(( [INFO] [stdout] 268 + where_column.expression.op, [INFO] [stdout] 269 + where_column.expression.value, [INFO] [stdout] 270 + WhereColumn::RowId, [INFO] [stdout] 271 + )), [INFO] [stdout] 272 + WhereColumn::Column(index) => match &table.columns[index] { [INFO] [stdout] 273 + TableColumn::RowId(_) => Ok(( [INFO] [stdout] 274 + where_column.expression.op, [INFO] [stdout] 275 + where_column.expression.value, [INFO] [stdout] 276 + WhereColumn::RowId, [INFO] [stdout] 277 + )), [INFO] [stdout] 278 + TableColumn::Column(_, b) => index_data [INFO] [stdout] 279 + .columns [INFO] [stdout] 280 + .iter() [INFO] [stdout] 281 + .position(|v| v.as_str() == b.as_str()) [INFO] [stdout] 282 + .map(|index| { [INFO] [stdout] 283 + ( [INFO] [stdout] 284 + where_column.expression.op, [INFO] [stdout] 285 + where_column.expression.value, [INFO] [stdout] 286 + WhereColumn::Column(index), [INFO] [stdout] 287 + ) [INFO] [stdout] 288 + }) [INFO] [stdout] 289 + .ok_or(ParsingError::InvalidStatement), [INFO] [stdout] 290 + }, [INFO] [stdout] 291 ~ }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/select_builder.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 217 | if &self.columns == &[Column::Count] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 217 - if &self.columns == &[Column::Count] { [INFO] [stdout] 217 + if self.columns == [Column::Count] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_builder.rs:298:9 [INFO] [stdout] | [INFO] [stdout] 298 | / return Ok(SelectBuilder { [INFO] [stdout] 299 | | index: table_index, [INFO] [stdout] 300 | | table: root_page, [INFO] [stdout] 301 | | columns, [INFO] [stdout] 302 | | where_comps: where_comps, [INFO] [stdout] 303 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 ~ Ok(SelectBuilder { [INFO] [stdout] 299 + index: table_index, [INFO] [stdout] 300 + table: root_page, [INFO] [stdout] 301 + columns, [INFO] [stdout] 302 + where_comps: where_comps, [INFO] [stdout] 303 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_parser.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return value.starts_with("\"") && value.ends_with("\""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return value.starts_with("\"") && value.ends_with("\""); [INFO] [stdout] 12 + value.starts_with("\"") && value.ends_with("\"") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_parser.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return format!("\"{v}\""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return format!("\"{v}\""); [INFO] [stdout] 23 + format!("\"{v}\"") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_parser.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return value.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return value.to_string(); [INFO] [stdout] 30 + value.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/select_parser.rs:41:52 [INFO] [stdout] | [INFO] [stdout] 41 | ParsedCombinator::And(parsed_where) => &parsed_where, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `parsed_where` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/select_parser.rs:42:51 [INFO] [stdout] | [INFO] [stdout] 42 | ParsedCombinator::Or(parsed_where) => &parsed_where, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `parsed_where` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_parser.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return return_val; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return return_val; [INFO] [stdout] 73 + return_val [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/select_parser.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | / match &self.combinator { [INFO] [stdout] 69 | | Some(comp) => return_val.append(&mut comp.get_where().get_columns()), [INFO] [stdout] 70 | | None => {}, [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(comp) = &self.combinator { return_val.append(&mut comp.get_where().get_columns()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Result` [INFO] [stdout] --> src/select_builder.rs:266:22 [INFO] [stdout] | [INFO] [stdout] 266 | .map(|where_column| match where_column.expression.column { [INFO] [stdout] | ______________________^ [INFO] [stdout] 267 | | WhereColumn::RowId => Ok(( [INFO] [stdout] 268 | | where_column.expression.op, [INFO] [stdout] 269 | | where_column.expression.value, [INFO] [stdout] ... | [INFO] [stdout] 291 | | }) [INFO] [stdout] 292 | | .flatten(); [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `and_then` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 266 ~ .and_then(|where_column| match where_column.expression.column { [INFO] [stdout] 267 + WhereColumn::RowId => Ok(( [INFO] [stdout] 268 + where_column.expression.op, [INFO] [stdout] 269 + where_column.expression.value, [INFO] [stdout] 270 + WhereColumn::RowId, [INFO] [stdout] 271 + )), [INFO] [stdout] 272 + WhereColumn::Column(index) => match &table.columns[index] { [INFO] [stdout] 273 + TableColumn::RowId(_) => Ok(( [INFO] [stdout] 274 + where_column.expression.op, [INFO] [stdout] 275 + where_column.expression.value, [INFO] [stdout] 276 + WhereColumn::RowId, [INFO] [stdout] 277 + )), [INFO] [stdout] 278 + TableColumn::Column(_, b) => index_data [INFO] [stdout] 279 + .columns [INFO] [stdout] 280 + .iter() [INFO] [stdout] 281 + .position(|v| v.as_str() == b.as_str()) [INFO] [stdout] 282 + .map(|index| { [INFO] [stdout] 283 + ( [INFO] [stdout] 284 + where_column.expression.op, [INFO] [stdout] 285 + where_column.expression.value, [INFO] [stdout] 286 + WhereColumn::Column(index), [INFO] [stdout] 287 + ) [INFO] [stdout] 288 + }) [INFO] [stdout] 289 + .ok_or(ParsingError::InvalidStatement), [INFO] [stdout] 290 + }, [INFO] [stdout] 291 ~ }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_parser.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return value.starts_with("\"") && value.ends_with("\""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return value.starts_with("\"") && value.ends_with("\""); [INFO] [stdout] 12 + value.starts_with("\"") && value.ends_with("\"") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_parser.rs:108:21 [INFO] [stdout] | [INFO] [stdout] 108 | None => return Ok(()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 108 - None => return Ok(()), [INFO] [stdout] 108 + None => Ok(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_parser.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return format!("\"{v}\""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return format!("\"{v}\""); [INFO] [stdout] 23 + format!("\"{v}\"") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_parser.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | / return value [INFO] [stdout] 125 | | .split(",") [INFO] [stdout] 126 | | .map(|value| value.trim().to_string()) [INFO] [stdout] 127 | | .collect(); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 ~ value [INFO] [stdout] 125 + .split(",") [INFO] [stdout] 126 + .map(|value| value.trim().to_string()) [INFO] [stdout] 127 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_parser.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return value.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return value.to_string(); [INFO] [stdout] 30 + value.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_parser.rs:178:5 [INFO] [stdout] | [INFO] [stdout] 178 | / return Ok(ParsedWhere { [INFO] [stdout] 179 | | expression: ParsedExpression { [INFO] [stdout] 180 | | column: column.to_string(), [INFO] [stdout] 181 | | op, [INFO] [stdout] ... | [INFO] [stdout] 184 | | combinator: None, [INFO] [stdout] 185 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 178 ~ Ok(ParsedWhere { [INFO] [stdout] 179 + expression: ParsedExpression { [INFO] [stdout] 180 + column: column.to_string(), [INFO] [stdout] 181 + op, [INFO] [stdout] 182 + value: value.to_string(), [INFO] [stdout] 183 + }, [INFO] [stdout] 184 + combinator: None, [INFO] [stdout] 185 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/select_parser.rs:41:52 [INFO] [stdout] | [INFO] [stdout] 41 | ParsedCombinator::And(parsed_where) => &parsed_where, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `parsed_where` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/select_parser.rs:42:51 [INFO] [stdout] | [INFO] [stdout] 42 | ParsedCombinator::Or(parsed_where) => &parsed_where, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `parsed_where` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_parser.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return return_val; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return return_val; [INFO] [stdout] 73 + return_val [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/select_parser.rs:176:29 [INFO] [stdout] | [INFO] [stdout] 176 | let value = parse_value(&select[op_index..].trim()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `select[op_index..].trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/select_parser.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | / match &self.combinator { [INFO] [stdout] 69 | | Some(comp) => return_val.append(&mut comp.get_where().get_columns()), [INFO] [stdout] 70 | | None => {}, [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(comp) = &self.combinator { return_val.append(&mut comp.get_where().get_columns()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/select_parser.rs:220:8 [INFO] [stdout] | [INFO] [stdout] 220 | if !(select_keyword < from_keyword) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(select_keyword >= from_keyword)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_parser.rs:108:21 [INFO] [stdout] | [INFO] [stdout] 108 | None => return Ok(()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 108 - None => return Ok(()), [INFO] [stdout] 108 + None => Ok(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/select_parser.rs:225:12 [INFO] [stdout] | [INFO] [stdout] 225 | && !(from_keyword < where_keyword) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(from_keyword >= where_keyword)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_parser.rs:257:5 [INFO] [stdout] | [INFO] [stdout] 257 | / return Ok(ParsedSelect { [INFO] [stdout] 258 | | table_name, [INFO] [stdout] 259 | | columns: column_names, [INFO] [stdout] 260 | | where_comp: where_cmp, [INFO] [stdout] 261 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 257 ~ Ok(ParsedSelect { [INFO] [stdout] 258 + table_name, [INFO] [stdout] 259 + columns: column_names, [INFO] [stdout] 260 + where_comp: where_cmp, [INFO] [stdout] 261 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_parser.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | / return value [INFO] [stdout] 125 | | .split(",") [INFO] [stdout] 126 | | .map(|value| value.trim().to_string()) [INFO] [stdout] 127 | | .collect(); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 ~ value [INFO] [stdout] 125 + .split(",") [INFO] [stdout] 126 + .map(|value| value.trim().to_string()) [INFO] [stdout] 127 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_parser.rs:178:5 [INFO] [stdout] | [INFO] [stdout] 178 | / return Ok(ParsedWhere { [INFO] [stdout] 179 | | expression: ParsedExpression { [INFO] [stdout] 180 | | column: column.to_string(), [INFO] [stdout] 181 | | op, [INFO] [stdout] ... | [INFO] [stdout] 184 | | combinator: None, [INFO] [stdout] 185 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 178 ~ Ok(ParsedWhere { [INFO] [stdout] 179 + expression: ParsedExpression { [INFO] [stdout] 180 + column: column.to_string(), [INFO] [stdout] 181 + op, [INFO] [stdout] 182 + value: value.to_string(), [INFO] [stdout] 183 + }, [INFO] [stdout] 184 + combinator: None, [INFO] [stdout] 185 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sqlite_header.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | / return Ok(SqliteHeader { [INFO] [stdout] 40 | | page_size: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 41 | | file_format_write_version: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 42 | | file_format_read_version: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] ... | [INFO] [stdout] 63 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 ~ Ok(SqliteHeader { [INFO] [stdout] 40 + page_size: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 41 + file_format_write_version: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 42 + file_format_read_version: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 43 + reserved_space: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 44 + max_payload_fraction: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 45 + min_payload_fraction: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 46 + leaf_payload_fraction: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 47 + file_change_counter: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 48 + database_size_in_pages: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 49 + first_freelist_trunk_page: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 50 + total_freelist_pages: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 51 + schema_cookie: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 52 + schema_format_number: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 53 + default_page_cache_size: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 54 + largest_root_btree_page_number: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 55 + text_encoding: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 56 + user_version: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 57 + incremental_vacuum_mode: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 58 + application_id: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 59 + reserved_for_expansion: offset_range(buffer, &mut offset, 20).try_into()?, [INFO] [stdout] 60 + version_valid_for_number: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 61 + sqlite_version_number: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 62 + [INFO] [stdout] 63 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/select_parser.rs:176:29 [INFO] [stdout] | [INFO] [stdout] 176 | let value = parse_value(&select[op_index..].trim()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `select[op_index..].trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/select_parser.rs:220:8 [INFO] [stdout] | [INFO] [stdout] 220 | if !(select_keyword < from_keyword) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(select_keyword >= from_keyword)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/select_parser.rs:225:12 [INFO] [stdout] | [INFO] [stdout] 225 | && !(from_keyword < where_keyword) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(from_keyword >= where_keyword)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select_parser.rs:257:5 [INFO] [stdout] | [INFO] [stdout] 257 | / return Ok(ParsedSelect { [INFO] [stdout] 258 | | table_name, [INFO] [stdout] 259 | | columns: column_names, [INFO] [stdout] 260 | | where_comp: where_cmp, [INFO] [stdout] 261 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 257 ~ Ok(ParsedSelect { [INFO] [stdout] 258 + table_name, [INFO] [stdout] 259 + columns: column_names, [INFO] [stdout] 260 + where_comp: where_cmp, [INFO] [stdout] 261 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/table_parser.rs:19:45 [INFO] [stdout] | [INFO] [stdout] 19 | TableColumn::RowId(name) => return name.as_str() == column_name, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - TableColumn::RowId(name) => return name.as_str() == column_name, [INFO] [stdout] 19 + TableColumn::RowId(name) => name.as_str() == column_name, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/table_parser.rs:20:50 [INFO] [stdout] | [INFO] [stdout] 20 | TableColumn::Column(_, name) => return name.as_str() == column_name, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - TableColumn::Column(_, name) => return name.as_str() == column_name, [INFO] [stdout] 20 + TableColumn::Column(_, name) => name.as_str() == column_name, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/table_parser.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | / return Ok(Table { [INFO] [stdout] 80 | | name: table_name.to_string(), [INFO] [stdout] 81 | | columns, [INFO] [stdout] 82 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 ~ Ok(Table { [INFO] [stdout] 80 + name: table_name.to_string(), [INFO] [stdout] 81 + columns, [INFO] [stdout] 82 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sqlite_header.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | / return Ok(SqliteHeader { [INFO] [stdout] 40 | | page_size: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 41 | | file_format_write_version: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 42 | | file_format_read_version: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] ... | [INFO] [stdout] 63 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 ~ Ok(SqliteHeader { [INFO] [stdout] 40 + page_size: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 41 + file_format_write_version: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 42 + file_format_read_version: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 43 + reserved_space: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 44 + max_payload_fraction: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 45 + min_payload_fraction: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 46 + leaf_payload_fraction: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 47 + file_change_counter: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 48 + database_size_in_pages: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 49 + first_freelist_trunk_page: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 50 + total_freelist_pages: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 51 + schema_cookie: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 52 + schema_format_number: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 53 + default_page_cache_size: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 54 + largest_root_btree_page_number: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 55 + text_encoding: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 56 + user_version: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 57 + incremental_vacuum_mode: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 58 + application_id: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 59 + reserved_for_expansion: offset_range(buffer, &mut offset, 20).try_into()?, [INFO] [stdout] 60 + version_valid_for_number: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 61 + sqlite_version_number: get_num_from_be(&mut offset, buffer)?, [INFO] [stdout] 62 + [INFO] [stdout] 63 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/table_parser.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | return TableColumn::RowId(column_tokens[0].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - return TableColumn::RowId(column_tokens[0].to_string()); [INFO] [stdout] 60 + TableColumn::RowId(column_tokens[0].to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/table_parser.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | return TableColumn::Column(0, column_tokens[0].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return TableColumn::Column(0, column_tokens[0].to_string()); [INFO] [stdout] 62 + TableColumn::Column(0, column_tokens[0].to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/varint.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return number & 0b1000_0000 != 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return number & 0b1000_0000 != 0 [INFO] [stdout] 24 + number & 0b1000_0000 != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/varint.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return Err(ParsingError::InvalidVarint) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return Err(ParsingError::InvalidVarint) [INFO] [stdout] 44 + Err(ParsingError::InvalidVarint) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/table_parser.rs:19:45 [INFO] [stdout] | [INFO] [stdout] 19 | TableColumn::RowId(name) => return name.as_str() == column_name, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - TableColumn::RowId(name) => return name.as_str() == column_name, [INFO] [stdout] 19 + TableColumn::RowId(name) => name.as_str() == column_name, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/table_parser.rs:20:50 [INFO] [stdout] | [INFO] [stdout] 20 | TableColumn::Column(_, name) => return name.as_str() == column_name, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - TableColumn::Column(_, name) => return name.as_str() == column_name, [INFO] [stdout] 20 + TableColumn::Column(_, name) => name.as_str() == column_name, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/table_parser.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | / return Ok(Table { [INFO] [stdout] 80 | | name: table_name.to_string(), [INFO] [stdout] 81 | | columns, [INFO] [stdout] 82 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 ~ Ok(Table { [INFO] [stdout] 80 + name: table_name.to_string(), [INFO] [stdout] 81 + columns, [INFO] [stdout] 82 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/table_parser.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | return TableColumn::RowId(column_tokens[0].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - return TableColumn::RowId(column_tokens[0].to_string()); [INFO] [stdout] 60 + TableColumn::RowId(column_tokens[0].to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/table_parser.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | return TableColumn::Column(0, column_tokens[0].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return TableColumn::Column(0, column_tokens[0].to_string()); [INFO] [stdout] 62 + TableColumn::Column(0, column_tokens[0].to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/varint.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return number & 0b1000_0000 != 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return number & 0b1000_0000 != 0 [INFO] [stdout] 24 + number & 0b1000_0000 != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/varint.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return Err(ParsingError::InvalidVarint) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return Err(ParsingError::InvalidVarint) [INFO] [stdout] 44 + Err(ParsingError::InvalidVarint) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/main.rs:126:38 [INFO] [stdout] | [INFO] [stdout] 126 | .map(|v| parse_index(u64::from_str_radix(&v[0], 10).unwrap_or(0), v[1].as_str())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `v[0].parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/main.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | u64::from_str_radix(&table_data[0][0], 10)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `table_data[0][0].parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/main.rs:126:38 [INFO] [stdout] | [INFO] [stdout] 126 | .map(|v| parse_index(u64::from_str_radix(&v[0], 10).unwrap_or(0), v[1].as_str())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `v[0].parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/main.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | u64::from_str_radix(&table_data[0][0], 10)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `table_data[0][0].parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.65s [INFO] running `Command { std: "docker" "inspect" "1f88558dcdbfb5fe24aca75c01a6d356e1e8ce092118797edda272a83b780147", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f88558dcdbfb5fe24aca75c01a6d356e1e8ce092118797edda272a83b780147", kill_on_drop: false }` [INFO] [stdout] 1f88558dcdbfb5fe24aca75c01a6d356e1e8ce092118797edda272a83b780147