[INFO] cloning repository https://github.com/Kasyima/rs-trees [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Kasyima/rs-trees" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKasyima%2Frs-trees", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKasyima%2Frs-trees'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f3fbcf445dea6a1ef87ae32f221889f7f6f7ba7c [INFO] linting Kasyima/rs-trees against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKasyima%2Frs-trees" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Kasyima/rs-trees [INFO] finished tweaking git repo https://github.com/Kasyima/rs-trees [INFO] tweaked toml for git repo https://github.com/Kasyima/rs-trees written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Kasyima/rs-trees on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Kasyima/rs-trees already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e69cab5df4c61287c8f0a92da3873c3e801d631e225b3e0797e2bd42b0d429fc [INFO] running `Command { std: "docker" "start" "-a" "e69cab5df4c61287c8f0a92da3873c3e801d631e225b3e0797e2bd42b0d429fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e69cab5df4c61287c8f0a92da3873c3e801d631e225b3e0797e2bd42b0d429fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e69cab5df4c61287c8f0a92da3873c3e801d631e225b3e0797e2bd42b0d429fc", kill_on_drop: false }` [INFO] [stdout] e69cab5df4c61287c8f0a92da3873c3e801d631e225b3e0797e2bd42b0d429fc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d7739bdc2a7fab04b7aa630f4f8412ddec19aa41a655d71df5688424103ccae9 [INFO] running `Command { std: "docker" "start" "-a" "d7739bdc2a7fab04b7aa630f4f8412ddec19aa41a655d71df5688424103ccae9", kill_on_drop: false }` [INFO] [stderr] Checking trees v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Display` [INFO] [stdout] --> src/lib.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 13 | use std::fmt::{Debug, Display}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | key: key, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/lib.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/level_order_traversal.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | let size = self.size(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_size` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Link` is never used [INFO] [stdout] --> src/lib.rs:16:6 [INFO] [stdout] | [INFO] [stdout] 16 | type Link = Option>>; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `BinaryTree` is never constructed [INFO] [stdout] --> src/lib.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 20 | struct BinaryTree { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/lib.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 28 | impl BinaryTree { [INFO] [stdout] | ----------------------------------------------------- associated items in this implementation [INFO] [stdout] 29 | fn new(key: T) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 43 | fn insert_left_node(&mut self, key: T) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | fn insert_right_node(&mut self, key: T) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | fn size(&self) -> usize { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 71 | fn calc_size(&self, mut size: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 85 | fn leaf_size(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 106 | fn none_leaf_size(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 111 | fn depth(&self) -> usize { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 127 | fn get_left(&self) -> Link { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 131 | fn get_right(&self) -> Link { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 136 | fn get_key(&self) -> T { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 141 | fn set_key(&mut self, key: T) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 146 | fn min(&self) -> Option<&T> { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 154 | fn max(&self) -> Option<&T> { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 163 | fn contains(&self, key: &T) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `preorder` is never used [INFO] [stdout] --> src/pre_order_traversal.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 12 | impl BinaryTree { [INFO] [stdout] | ----------------------------------------------------- method in this implementation [INFO] [stdout] 13 | fn preorder(&self) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `preorder` is never used [INFO] [stdout] --> src/pre_order_traversal.rs:27:4 [INFO] [stdout] | [INFO] [stdout] 27 | fn preorder (bt: Link) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `postorder` is never used [INFO] [stdout] --> src/post_order_traversal.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 7 | impl BinaryTree { [INFO] [stdout] | ----------------------------------------------------- method in this implementation [INFO] [stdout] 8 | fn postorder(&self) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `postorder` is never used [INFO] [stdout] --> src/post_order_traversal.rs:22:4 [INFO] [stdout] | [INFO] [stdout] 22 | fn postorder(bt: Link) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `inorder` is never used [INFO] [stdout] --> src/in_order_traversal.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 7 | impl BinaryTree { [INFO] [stdout] | ----------------------------------------------------- method in this implementation [INFO] [stdout] 8 | fn inorder(&self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `inorder` is never used [INFO] [stdout] --> src/in_order_traversal.rs:20:4 [INFO] [stdout] | [INFO] [stdout] 20 | fn inorder(bt: Link) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `levelorder` is never used [INFO] [stdout] --> src/level_order_traversal.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 8 | impl BinaryTree { [INFO] [stdout] | ----------------------------------------------------- method in this implementation [INFO] [stdout] 9 | fn levelorder(&self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `BinaryHeap` is never constructed [INFO] [stdout] --> src/binary_heap.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 58 | struct BinaryHeap{ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/binary_heap.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 64 | impl BinaryHeap { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 65 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 72 | fn size(&self) -> usize { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 76 | fn is_empty(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 80 | fn min(&self) -> Option { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | fn push(&mut self, val: i32) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 102 | fn move_up(&mut self, mut c: usize) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 116 | fn pop(&mut self) -> Option { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 158 | fn move_down(&mut self, mut c: usize) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 175 | fn min_child(&self, c: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 192 | fn build_new(&mut self, arr: &[i32]) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/pre_order_traversal.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | / match &self.left { [INFO] [stdout] 16 | | Some(node) => node.preorder(), [INFO] [stdout] 17 | | None => (), [INFO] [stdout] 18 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(node) = &self.left { node.preorder() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/pre_order_traversal.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / match &self.right { [INFO] [stdout] 20 | | Some(node) => node.preorder(), [INFO] [stdout] 21 | | None => (), [INFO] [stdout] 22 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(node) = &self.right { node.preorder() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/pre_order_traversal.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | if !bt.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `bt.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/pre_order_traversal.rs:29:31 [INFO] [stdout] | [INFO] [stdout] 28 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 29 | println!("key: {:?}", bt.as_ref().unwrap().get_key()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/pre_order_traversal.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 28 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 29 | println!("key: {:?}", bt.as_ref().unwrap().get_key()); [INFO] [stdout] 30 | preorder(bt.as_ref().unwrap().get_left()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/pre_order_traversal.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 28 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 31 | preorder(bt.as_ref().unwrap().get_right()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/post_order_traversal.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | / match &self.left { [INFO] [stdout] 10 | | Some(node) => node.postorder(), [INFO] [stdout] 11 | | None => (), [INFO] [stdout] 12 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(node) = &self.left { node.postorder() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/post_order_traversal.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | / match &self.right { [INFO] [stdout] 14 | | Some(node) => node.postorder(), [INFO] [stdout] 15 | | None => (), [INFO] [stdout] 16 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(node) = &self.right { node.postorder() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/post_order_traversal.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 23 | if !bt.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `bt.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/post_order_traversal.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 23 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 24 | postorder(bt.as_ref().unwrap().get_left()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/post_order_traversal.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 23 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 24 | postorder(bt.as_ref().unwrap().get_left()); [INFO] [stdout] 25 | postorder(bt.as_ref().unwrap().get_right()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/post_order_traversal.rs:26:31 [INFO] [stdout] | [INFO] [stdout] 23 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 26 | println!("key: {:?}", bt.as_ref().unwrap().get_key()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.left` after checking its variant with `is_some` [INFO] [stdout] --> src/in_order_traversal.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 9 | if self.left.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = &self.left` [INFO] [stdout] 10 | self.left.as_ref().unwrap().inorder(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.right` after checking its variant with `is_some` [INFO] [stdout] --> src/in_order_traversal.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 13 | if self.right.is_some(){ [INFO] [stdout] | ----------------------- help: try: `if let Some() = &self.right` [INFO] [stdout] 14 | self.right.as_ref().unwrap().inorder(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/in_order_traversal.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | if !bt.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `bt.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/in_order_traversal.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 21 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 22 | inorder(bt.as_ref().unwrap().get_left()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/in_order_traversal.rs:23:31 [INFO] [stdout] | [INFO] [stdout] 21 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 22 | inorder(bt.as_ref().unwrap().get_left()); [INFO] [stdout] 23 | println!("key: {:?}", bt.as_ref().unwrap().get_key()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/in_order_traversal.rs:24:17 [INFO] [stdout] | [INFO] [stdout] 21 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 24 | inorder(bt.as_ref().unwrap().get_right()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/level_order_traversal.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | let _r = q.push_back(Box::new(self.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 14 - let _r = q.push_back(Box::new(self.clone())); [INFO] [stdout] 14 + q.push_back(Box::new(self.clone())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/level_order_traversal.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | / match front.get_left() { [INFO] [stdout] 22 | | Some(left) => { [INFO] [stdout] 23 | | let _r = q.push_back(left); [INFO] [stdout] 24 | | }, [INFO] [stdout] 25 | | None => {}, [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 21 ~ if let Some(left) = front.get_left() { [INFO] [stdout] 22 + let _r = q.push_back(left); [INFO] [stdout] 23 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/level_order_traversal.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | let _r = q.push_back(left); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 23 - let _r = q.push_back(left); [INFO] [stdout] 23 + q.push_back(left); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/level_order_traversal.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | / match front.get_right() { [INFO] [stdout] 29 | | Some(right) => { [INFO] [stdout] 30 | | let _r = q.push_back(right); [INFO] [stdout] 31 | | }, [INFO] [stdout] 32 | | None => {}, [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 ~ if let Some(right) = front.get_right() { [INFO] [stdout] 29 + let _r = q.push_back(right); [INFO] [stdout] 30 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/level_order_traversal.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | let _r = q.push_back(right); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 30 - let _r = q.push_back(right); [INFO] [stdout] 30 + q.push_back(right); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Display` [INFO] [stdout] --> src/lib.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 13 | use std::fmt::{Debug, Display}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | key: key, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | if !self.left.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.left.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 77 | if !self.right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.right.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.left` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:75:20 [INFO] [stdout] | [INFO] [stdout] 74 | if !self.left.is_none() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] 75 | size = self.left.as_ref().unwrap().calc_size(size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.right` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:78:20 [INFO] [stdout] | [INFO] [stdout] 77 | if !self.right.is_none() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] 78 | size = self.right.as_ref().unwrap().calc_size(size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/level_order_traversal.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | let size = self.size(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_size` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Link` is never used [INFO] [stdout] --> src/lib.rs:16:6 [INFO] [stdout] | [INFO] [stdout] 16 | type Link = Option>>; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `BinaryTree` is never constructed [INFO] [stdout] --> src/lib.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 20 | struct BinaryTree { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/lib.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 28 | impl BinaryTree { [INFO] [stdout] | ----------------------------------------------------- associated items in this implementation [INFO] [stdout] 29 | fn new(key: T) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 43 | fn insert_left_node(&mut self, key: T) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | fn insert_right_node(&mut self, key: T) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | fn size(&self) -> usize { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 71 | fn calc_size(&self, mut size: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 85 | fn leaf_size(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 106 | fn none_leaf_size(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 111 | fn depth(&self) -> usize { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 127 | fn get_left(&self) -> Link { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 131 | fn get_right(&self) -> Link { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 136 | fn get_key(&self) -> T { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 141 | fn set_key(&mut self, key: T) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 146 | fn min(&self) -> Option<&T> { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 154 | fn max(&self) -> Option<&T> { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 163 | fn contains(&self, key: &T) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `preorder` is never used [INFO] [stdout] --> src/pre_order_traversal.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 12 | impl BinaryTree { [INFO] [stdout] | ----------------------------------------------------- method in this implementation [INFO] [stdout] 13 | fn preorder(&self) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `preorder` is never used [INFO] [stdout] --> src/pre_order_traversal.rs:27:4 [INFO] [stdout] | [INFO] [stdout] 27 | fn preorder (bt: Link) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `postorder` is never used [INFO] [stdout] --> src/post_order_traversal.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 7 | impl BinaryTree { [INFO] [stdout] | ----------------------------------------------------- method in this implementation [INFO] [stdout] 8 | fn postorder(&self) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `postorder` is never used [INFO] [stdout] --> src/post_order_traversal.rs:22:4 [INFO] [stdout] | [INFO] [stdout] 22 | fn postorder(bt: Link) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `inorder` is never used [INFO] [stdout] --> src/in_order_traversal.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 7 | impl BinaryTree { [INFO] [stdout] | ----------------------------------------------------- method in this implementation [INFO] [stdout] 8 | fn inorder(&self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `inorder` is never used [INFO] [stdout] --> src/in_order_traversal.rs:20:4 [INFO] [stdout] | [INFO] [stdout] 20 | fn inorder(bt: Link) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `levelorder` is never used [INFO] [stdout] --> src/level_order_traversal.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 8 | impl BinaryTree { [INFO] [stdout] | ----------------------------------------------------- method in this implementation [INFO] [stdout] 9 | fn levelorder(&self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `BinaryHeap` is never constructed [INFO] [stdout] --> src/binary_heap.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 58 | struct BinaryHeap{ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/binary_heap.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 64 | impl BinaryHeap { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 65 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 72 | fn size(&self) -> usize { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 76 | fn is_empty(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 80 | fn min(&self) -> Option { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | fn push(&mut self, val: i32) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 102 | fn move_up(&mut self, mut c: usize) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 116 | fn pop(&mut self) -> Option { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 158 | fn move_down(&mut self, mut c: usize) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 175 | fn min_child(&self, c: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 192 | fn build_new(&mut self, arr: &[i32]) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/pre_order_traversal.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | / match &self.left { [INFO] [stdout] 16 | | Some(node) => node.preorder(), [INFO] [stdout] 17 | | None => (), [INFO] [stdout] 18 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(node) = &self.left { node.preorder() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/pre_order_traversal.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / match &self.right { [INFO] [stdout] 20 | | Some(node) => node.preorder(), [INFO] [stdout] 21 | | None => (), [INFO] [stdout] 22 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(node) = &self.right { node.preorder() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/pre_order_traversal.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | if !bt.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `bt.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/pre_order_traversal.rs:29:31 [INFO] [stdout] | [INFO] [stdout] 28 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 29 | println!("key: {:?}", bt.as_ref().unwrap().get_key()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/pre_order_traversal.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 28 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 29 | println!("key: {:?}", bt.as_ref().unwrap().get_key()); [INFO] [stdout] 30 | preorder(bt.as_ref().unwrap().get_left()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/pre_order_traversal.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 28 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 31 | preorder(bt.as_ref().unwrap().get_right()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/post_order_traversal.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | / match &self.left { [INFO] [stdout] 10 | | Some(node) => node.postorder(), [INFO] [stdout] 11 | | None => (), [INFO] [stdout] 12 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(node) = &self.left { node.postorder() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/post_order_traversal.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | / match &self.right { [INFO] [stdout] 14 | | Some(node) => node.postorder(), [INFO] [stdout] 15 | | None => (), [INFO] [stdout] 16 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(node) = &self.right { node.postorder() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/post_order_traversal.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 23 | if !bt.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `bt.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/post_order_traversal.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 23 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 24 | postorder(bt.as_ref().unwrap().get_left()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/post_order_traversal.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 23 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 24 | postorder(bt.as_ref().unwrap().get_left()); [INFO] [stdout] 25 | postorder(bt.as_ref().unwrap().get_right()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/post_order_traversal.rs:26:31 [INFO] [stdout] | [INFO] [stdout] 23 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 26 | println!("key: {:?}", bt.as_ref().unwrap().get_key()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.left` after checking its variant with `is_some` [INFO] [stdout] --> src/in_order_traversal.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 9 | if self.left.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = &self.left` [INFO] [stdout] 10 | self.left.as_ref().unwrap().inorder(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.right` after checking its variant with `is_some` [INFO] [stdout] --> src/in_order_traversal.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 13 | if self.right.is_some(){ [INFO] [stdout] | ----------------------- help: try: `if let Some() = &self.right` [INFO] [stdout] 14 | self.right.as_ref().unwrap().inorder(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/in_order_traversal.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | if !bt.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `bt.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/in_order_traversal.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 21 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 22 | inorder(bt.as_ref().unwrap().get_left()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/in_order_traversal.rs:23:31 [INFO] [stdout] | [INFO] [stdout] 21 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 22 | inorder(bt.as_ref().unwrap().get_left()); [INFO] [stdout] 23 | println!("key: {:?}", bt.as_ref().unwrap().get_key()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bt` after checking its variant with `is_none` [INFO] [stdout] --> src/in_order_traversal.rs:24:17 [INFO] [stdout] | [INFO] [stdout] 21 | if !bt.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 24 | inorder(bt.as_ref().unwrap().get_right()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/level_order_traversal.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | let _r = q.push_back(Box::new(self.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 14 - let _r = q.push_back(Box::new(self.clone())); [INFO] [stdout] 14 + q.push_back(Box::new(self.clone())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/level_order_traversal.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | / match front.get_left() { [INFO] [stdout] 22 | | Some(left) => { [INFO] [stdout] 23 | | let _r = q.push_back(left); [INFO] [stdout] 24 | | }, [INFO] [stdout] 25 | | None => {}, [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 21 ~ if let Some(left) = front.get_left() { [INFO] [stdout] 22 + let _r = q.push_back(left); [INFO] [stdout] 23 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/level_order_traversal.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | let _r = q.push_back(left); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 23 - let _r = q.push_back(left); [INFO] [stdout] 23 + q.push_back(left); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/level_order_traversal.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | / match front.get_right() { [INFO] [stdout] 29 | | Some(right) => { [INFO] [stdout] 30 | | let _r = q.push_back(right); [INFO] [stdout] 31 | | }, [INFO] [stdout] 32 | | None => {}, [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 ~ if let Some(right) = front.get_right() { [INFO] [stdout] 29 + let _r = q.push_back(right); [INFO] [stdout] 30 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/level_order_traversal.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | let _r = q.push_back(right); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 30 - let _r = q.push_back(right); [INFO] [stdout] 30 + q.push_back(right); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | if !self.left.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.left.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 77 | if !self.right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.right.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.left` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:75:20 [INFO] [stdout] | [INFO] [stdout] 74 | if !self.left.is_none() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] 75 | size = self.left.as_ref().unwrap().calc_size(size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.right` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:78:20 [INFO] [stdout] | [INFO] [stdout] 77 | if !self.right.is_none() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] 78 | size = self.right.as_ref().unwrap().calc_size(size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.20s [INFO] running `Command { std: "docker" "inspect" "d7739bdc2a7fab04b7aa630f4f8412ddec19aa41a655d71df5688424103ccae9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d7739bdc2a7fab04b7aa630f4f8412ddec19aa41a655d71df5688424103ccae9", kill_on_drop: false }` [INFO] [stdout] d7739bdc2a7fab04b7aa630f4f8412ddec19aa41a655d71df5688424103ccae9