[INFO] cloning repository https://github.com/KashaveSathyvell/rust-rts-sensor-actuator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KashaveSathyvell/rust-rts-sensor-actuator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKashaveSathyvell%2Frust-rts-sensor-actuator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKashaveSathyvell%2Frust-rts-sensor-actuator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f9900eaae33954dfb1448c22564a3f2cc5784ee2 [INFO] linting KashaveSathyvell/rust-rts-sensor-actuator against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKashaveSathyvell%2Frust-rts-sensor-actuator" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/KashaveSathyvell/rust-rts-sensor-actuator [INFO] finished tweaking git repo https://github.com/KashaveSathyvell/rust-rts-sensor-actuator [INFO] tweaked toml for git repo https://github.com/KashaveSathyvell/rust-rts-sensor-actuator written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/KashaveSathyvell/rust-rts-sensor-actuator on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/KashaveSathyvell/rust-rts-sensor-actuator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded emath v0.24.1 [INFO] [stderr] Downloaded ecolor v0.24.1 [INFO] [stderr] Downloaded zbus_names v2.6.1 [INFO] [stderr] Downloaded atspi-connection v0.3.0 [INFO] [stderr] Downloaded async-process v1.8.1 [INFO] [stderr] Downloaded async-once-cell v0.5.4 [INFO] [stderr] Downloaded atspi-common v0.3.0 [INFO] [stderr] Downloaded zvariant v3.15.2 [INFO] [stderr] Downloaded event-listener v3.1.0 [INFO] [stderr] Downloaded egui-winit v0.24.1 [INFO] [stderr] Downloaded glow v0.12.3 [INFO] [stderr] Downloaded eframe v0.24.1 [INFO] [stderr] Downloaded zbus v3.15.2 [INFO] [stderr] Downloaded egui_plot v0.24.2 [INFO] [stderr] Downloaded atspi-proxies v0.3.0 [INFO] [stderr] Downloaded zbus_macros v3.15.2 [INFO] [stderr] Downloaded accesskit_unix v0.6.2 [INFO] [stderr] Downloaded android-activity v0.4.3 [INFO] [stderr] Downloaded egui v0.24.1 [INFO] [stderr] Downloaded accesskit_winit v0.15.0 [INFO] [stderr] Downloaded egui_glow v0.24.1 [INFO] [stderr] Downloaded glutin v0.30.10 [INFO] [stderr] Downloaded rustix v0.37.28 [INFO] [stderr] Downloaded glutin_egl_sys v0.5.1 [INFO] [stderr] Downloaded atspi v0.19.0 [INFO] [stderr] Downloaded winit v0.28.7 [INFO] [stderr] Downloaded zvariant_derive v3.15.2 [INFO] [stderr] Downloaded epaint v0.24.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d508e18ee0f5900a9fbce07e4d2c8d90bf933a83ec5ac6deda250065ca82e805 [INFO] running `Command { std: "docker" "start" "-a" "d508e18ee0f5900a9fbce07e4d2c8d90bf933a83ec5ac6deda250065ca82e805", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d508e18ee0f5900a9fbce07e4d2c8d90bf933a83ec5ac6deda250065ca82e805", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d508e18ee0f5900a9fbce07e4d2c8d90bf933a83ec5ac6deda250065ca82e805", kill_on_drop: false }` [INFO] [stdout] d508e18ee0f5900a9fbce07e4d2c8d90bf933a83ec5ac6deda250065ca82e805 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e22bedce06bc8dc33718b59fc015aaefc4dd4e8f4fb2418357550162ee11f0dc [INFO] running `Command { std: "docker" "start" "-a" "e22bedce06bc8dc33718b59fc015aaefc4dd4e8f4fb2418357550162ee11f0dc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.105 [INFO] [stderr] Compiling quote v1.0.43 [INFO] [stderr] Compiling libc v0.2.179 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling xml-rs v0.8.28 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Compiling indexmap v2.13.0 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Compiling once_cell v1.21.3 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling rustix v0.37.28 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Compiling regex-syntax v0.8.8 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Compiling slotmap v1.1.1 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.10 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking ryu v1.0.22 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Checking litemap v0.8.1 [INFO] [stderr] Checking writeable v0.6.2 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.16.1 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Checking xcursor v0.3.10 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking accesskit v0.12.3 [INFO] [stderr] Compiling regex-automata v0.4.13 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking bytes v1.11.0 [INFO] [stderr] Compiling winit v0.28.7 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Compiling glutin_egl_sys v0.5.1 [INFO] [stderr] Compiling glutin_glx_sys v0.4.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling wayland-sys v0.30.1 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling zmij v1.0.12 [INFO] [stderr] Checking accesskit_consumer v0.16.1 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Compiling glutin v0.30.10 [INFO] [stderr] Checking async-once-cell v0.5.4 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling glutin-winit v0.3.0 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking home v0.5.12 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking clap_builder v4.5.54 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking web-time v0.2.4 [INFO] [stderr] Checking glow v0.12.3 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Compiling winapi v0.3.9 [INFO] [stderr] Checking wayland-cursor v0.29.5 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Compiling regex v1.12.2 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking clap v4.5.54 [INFO] [stderr] Compiling zvariant_utils v1.0.1 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerocopy-derive v0.8.33 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling zvariant_derive v3.15.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling zbus_macros v3.15.2 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking calloop v0.10.6 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking tiny-skia-path v0.8.4 [INFO] [stderr] Checking emath v0.24.1 [INFO] [stderr] Checking ecolor v0.24.1 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking zerocopy v0.8.33 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking tiny-skia v0.8.4 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking epaint v0.24.1 [INFO] [stderr] Checking zvariant v3.15.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking egui v0.24.1 [INFO] [stderr] Checking zbus_names v2.6.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking zbus v3.15.2 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking webbrowser v0.8.15 [INFO] [stderr] Checking common v0.1.0 (/opt/rustwide/workdir/crates/common) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BenchmarkRecorder` [INFO] [stdout] --> crates/common/src/metrics.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / pub fn new() -> Self { [INFO] [stdout] 31 | | Self { [INFO] [stdout] 32 | | results: Arc::new(Mutex::new(Vec::with_capacity(10_000))), [INFO] [stdout] 33 | | missed_deadlines: Arc::new(AtomicUsize::new(0)), [INFO] [stdout] ... | [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 29 + impl Default for BenchmarkRecorder { [INFO] [stdout] 30 + fn default() -> Self { [INFO] [stdout] 31 + Self::new() [INFO] [stdout] 32 + } [INFO] [stdout] 33 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MutexStrategy` [INFO] [stdout] --> crates/common/src/sync_strategies.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | / pub fn new() -> Self { [INFO] [stdout] 25 | | Self { [INFO] [stdout] 26 | | results: Arc::new(Mutex::new(Vec::with_capacity(10_000))), [INFO] [stdout] 27 | | missed_deadlines: Arc::new(AtomicUsize::new(0)), [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 23 + impl Default for MutexStrategy { [INFO] [stdout] 24 + fn default() -> Self { [INFO] [stdout] 25 + Self::new() [INFO] [stdout] 26 + } [INFO] [stdout] 27 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RwLockStrategy` [INFO] [stdout] --> crates/common/src/sync_strategies.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | / pub fn new() -> Self { [INFO] [stdout] 86 | | Self { [INFO] [stdout] 87 | | results: Arc::new(RwLock::new(Vec::with_capacity(10_000))), [INFO] [stdout] 88 | | missed_deadlines: Arc::new(AtomicUsize::new(0)), [INFO] [stdout] 89 | | } [INFO] [stdout] 90 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 84 + impl Default for RwLockStrategy { [INFO] [stdout] 85 + fn default() -> Self { [INFO] [stdout] 86 + Self::new() [INFO] [stdout] 87 + } [INFO] [stdout] 88 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `AtomicStrategy` [INFO] [stdout] --> crates/common/src/sync_strategies.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | / pub fn new() -> Self { [INFO] [stdout] 150 | | Self { [INFO] [stdout] 151 | | results: Arc::new(Mutex::new(Vec::with_capacity(10_000))), [INFO] [stdout] 152 | | missed_deadlines: Arc::new(AtomicUsize::new(0)), [INFO] [stdout] ... | [INFO] [stdout] 155 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 148 + impl Default for AtomicStrategy { [INFO] [stdout] 149 + fn default() -> Self { [INFO] [stdout] 150 + Self::new() [INFO] [stdout] 151 + } [INFO] [stdout] 152 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DashboardBuffer` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> crates/common/src/dashboard.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BenchmarkRecorder` [INFO] [stdout] --> crates/common/src/metrics.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / pub fn new() -> Self { [INFO] [stdout] 31 | | Self { [INFO] [stdout] 32 | | results: Arc::new(Mutex::new(Vec::with_capacity(10_000))), [INFO] [stdout] 33 | | missed_deadlines: Arc::new(AtomicUsize::new(0)), [INFO] [stdout] ... | [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 29 + impl Default for BenchmarkRecorder { [INFO] [stdout] 30 + fn default() -> Self { [INFO] [stdout] 31 + Self::new() [INFO] [stdout] 32 + } [INFO] [stdout] 33 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking async_impl v0.1.0 (/opt/rustwide/workdir/crates/async_impl) [INFO] [stderr] Checking threaded_impl v0.1.0 (/opt/rustwide/workdir/crates/threaded_impl) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MutexStrategy` [INFO] [stdout] --> crates/common/src/sync_strategies.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | / pub fn new() -> Self { [INFO] [stdout] 25 | | Self { [INFO] [stdout] 26 | | results: Arc::new(Mutex::new(Vec::with_capacity(10_000))), [INFO] [stdout] 27 | | missed_deadlines: Arc::new(AtomicUsize::new(0)), [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 23 + impl Default for MutexStrategy { [INFO] [stdout] 24 + fn default() -> Self { [INFO] [stdout] 25 + Self::new() [INFO] [stdout] 26 + } [INFO] [stdout] 27 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RwLockStrategy` [INFO] [stdout] --> crates/common/src/sync_strategies.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | / pub fn new() -> Self { [INFO] [stdout] 86 | | Self { [INFO] [stdout] 87 | | results: Arc::new(RwLock::new(Vec::with_capacity(10_000))), [INFO] [stdout] 88 | | missed_deadlines: Arc::new(AtomicUsize::new(0)), [INFO] [stdout] 89 | | } [INFO] [stdout] 90 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 84 + impl Default for RwLockStrategy { [INFO] [stdout] 85 + fn default() -> Self { [INFO] [stdout] 86 + Self::new() [INFO] [stdout] 87 + } [INFO] [stdout] 88 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `AtomicStrategy` [INFO] [stdout] --> crates/common/src/sync_strategies.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | / pub fn new() -> Self { [INFO] [stdout] 150 | | Self { [INFO] [stdout] 151 | | results: Arc::new(Mutex::new(Vec::with_capacity(10_000))), [INFO] [stdout] 152 | | missed_deadlines: Arc::new(AtomicUsize::new(0)), [INFO] [stdout] ... | [INFO] [stdout] 155 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 148 + impl Default for AtomicStrategy { [INFO] [stdout] 149 + fn default() -> Self { [INFO] [stdout] 150 + Self::new() [INFO] [stdout] 151 + } [INFO] [stdout] 152 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DashboardBuffer` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> crates/common/src/dashboard.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> crates/threaded_impl/src/actuator.rs:74:1 [INFO] [stdout] | [INFO] [stdout] 74 | / pub fn run_actuator_thread( [INFO] [stdout] 75 | | actuator_type: ActuatorType, [INFO] [stdout] 76 | | deadline: Duration, [INFO] [stdout] 77 | | config: ExperimentConfig, [INFO] [stdout] ... | [INFO] [stdout] 82 | | start_time: Instant, [INFO] [stdout] 83 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/actuator.rs:122:37 [INFO] [stdout] | [INFO] [stdout] 122 | if config.enable_logging && cycle_count % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/actuator.rs:141:37 [INFO] [stdout] | [INFO] [stdout] 141 | if config.enable_logging && cycle_count % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/actuator.rs:184:37 [INFO] [stdout] | [INFO] [stdout] 184 | if config.enable_logging && cycle_count % 20 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:47:37 [INFO] [stdout] | [INFO] [stdout] 47 | if config.enable_logging && cycle_id % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:72:37 [INFO] [stdout] | [INFO] [stdout] 72 | if config.enable_logging && cycle_id % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:101:37 [INFO] [stdout] | [INFO] [stdout] 101 | if config.enable_logging && cycle_id % 20 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:129:37 [INFO] [stdout] | [INFO] [stdout] 129 | if config.enable_logging && cycle_id % 100 == 0 && cycle_id > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:149:39 [INFO] [stdout] | [INFO] [stdout] 149 | let processing_late = if processing_time_ns > PROCESSING_DEADLINE_NS { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 150 | | processing_time_ns - PROCESSING_DEADLINE_NS [INFO] [stdout] 151 | | } else { 0 }; [INFO] [stdout] | |____________________________^ help: replace it with: `processing_time_ns.saturating_sub(PROCESSING_DEADLINE_NS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:152:41 [INFO] [stdout] | [INFO] [stdout] 152 | let transmission_late = if transmission_time_ns > TRANSMISSION_DEADLINE_NS { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 153 | | transmission_time_ns - TRANSMISSION_DEADLINE_NS [INFO] [stdout] 154 | | } else { 0 }; [INFO] [stdout] | |____________________________^ help: replace it with: `transmission_time_ns.saturating_sub(TRANSMISSION_DEADLINE_NS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:166:20 [INFO] [stdout] | [INFO] [stdout] 166 | if cycle_id % 20 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:182:45 [INFO] [stdout] | [INFO] [stdout] 182 | if config.enable_logging && cycle_id % 20 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:189:45 [INFO] [stdout] | [INFO] [stdout] 189 | if config.enable_logging && cycle_id % 20 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:197:45 [INFO] [stdout] | [INFO] [stdout] 197 | if config.enable_logging && cycle_id % 20 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/threaded_impl/src/lib.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | / if dispatcher_config.enable_logging { [INFO] [stdout] 73 | | if config.enable_logging { [INFO] [stdout] 74 | | println!("[{:>8}] [SYSTEM] Threaded dispatcher initialized - routing sensor data to 3 actuators", [INFO] [stdout] 75 | | format!("{:.3}s", dispatcher_start.duration_since(start_time).as_secs_f64())); [INFO] [stdout] 76 | | } [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 72 ~ if dispatcher_config.enable_logging [INFO] [stdout] 73 ~ && config.enable_logging { [INFO] [stdout] 74 | println!("[{:>8}] [SYSTEM] Threaded dispatcher initialized - routing sensor data to 3 actuators", [INFO] [stdout] 75 | format!("{:.3}s", dispatcher_start.duration_since(start_time).as_secs_f64())); [INFO] [stdout] 76 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/lib.rs:86:56 [INFO] [stdout] | [INFO] [stdout] 86 | if dispatcher_config.enable_logging && cycle_count % 5 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/threaded_impl/src/lib.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | / if dispatcher_config.enable_logging { [INFO] [stdout] 104 | | if config.enable_logging { [INFO] [stdout] 105 | | println!("[SYSTEM] Threaded dispatcher shutting down"); [INFO] [stdout] 106 | | } [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 103 ~ if dispatcher_config.enable_logging [INFO] [stdout] 104 ~ && config.enable_logging { [INFO] [stdout] 105 | println!("[SYSTEM] Threaded dispatcher shutting down"); [INFO] [stdout] 106 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> crates/threaded_impl/src/lib.rs:210:1 [INFO] [stdout] | [INFO] [stdout] 210 | / fn spawn_actuator( [INFO] [stdout] 211 | | actuator_type: ActuatorType, [INFO] [stdout] 212 | | deadline: Duration, [INFO] [stdout] 213 | | config: ExperimentConfig, [INFO] [stdout] ... | [INFO] [stdout] 218 | | start_time: Instant, [INFO] [stdout] 219 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> crates/threaded_impl/src/actuator.rs:74:1 [INFO] [stdout] | [INFO] [stdout] 74 | / pub fn run_actuator_thread( [INFO] [stdout] 75 | | actuator_type: ActuatorType, [INFO] [stdout] 76 | | deadline: Duration, [INFO] [stdout] 77 | | config: ExperimentConfig, [INFO] [stdout] ... | [INFO] [stdout] 82 | | start_time: Instant, [INFO] [stdout] 83 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/actuator.rs:122:37 [INFO] [stdout] | [INFO] [stdout] 122 | if config.enable_logging && cycle_count % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/actuator.rs:141:37 [INFO] [stdout] | [INFO] [stdout] 141 | if config.enable_logging && cycle_count % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/actuator.rs:184:37 [INFO] [stdout] | [INFO] [stdout] 184 | if config.enable_logging && cycle_count % 20 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:47:37 [INFO] [stdout] | [INFO] [stdout] 47 | if config.enable_logging && cycle_id % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:72:37 [INFO] [stdout] | [INFO] [stdout] 72 | if config.enable_logging && cycle_id % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:101:37 [INFO] [stdout] | [INFO] [stdout] 101 | if config.enable_logging && cycle_id % 20 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:129:37 [INFO] [stdout] | [INFO] [stdout] 129 | if config.enable_logging && cycle_id % 100 == 0 && cycle_id > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:149:39 [INFO] [stdout] | [INFO] [stdout] 149 | let processing_late = if processing_time_ns > PROCESSING_DEADLINE_NS { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 150 | | processing_time_ns - PROCESSING_DEADLINE_NS [INFO] [stdout] 151 | | } else { 0 }; [INFO] [stdout] | |____________________________^ help: replace it with: `processing_time_ns.saturating_sub(PROCESSING_DEADLINE_NS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:152:41 [INFO] [stdout] | [INFO] [stdout] 152 | let transmission_late = if transmission_time_ns > TRANSMISSION_DEADLINE_NS { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 153 | | transmission_time_ns - TRANSMISSION_DEADLINE_NS [INFO] [stdout] 154 | | } else { 0 }; [INFO] [stdout] | |____________________________^ help: replace it with: `transmission_time_ns.saturating_sub(TRANSMISSION_DEADLINE_NS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:166:20 [INFO] [stdout] | [INFO] [stdout] 166 | if cycle_id % 20 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:182:45 [INFO] [stdout] | [INFO] [stdout] 182 | if config.enable_logging && cycle_id % 20 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:189:45 [INFO] [stdout] | [INFO] [stdout] 189 | if config.enable_logging && cycle_id % 20 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/sensor.rs:197:45 [INFO] [stdout] | [INFO] [stdout] 197 | if config.enable_logging && cycle_id % 20 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/threaded_impl/src/lib.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | / if dispatcher_config.enable_logging { [INFO] [stdout] 73 | | if config.enable_logging { [INFO] [stdout] 74 | | println!("[{:>8}] [SYSTEM] Threaded dispatcher initialized - routing sensor data to 3 actuators", [INFO] [stdout] 75 | | format!("{:.3}s", dispatcher_start.duration_since(start_time).as_secs_f64())); [INFO] [stdout] 76 | | } [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 72 ~ if dispatcher_config.enable_logging [INFO] [stdout] 73 ~ && config.enable_logging { [INFO] [stdout] 74 | println!("[{:>8}] [SYSTEM] Threaded dispatcher initialized - routing sensor data to 3 actuators", [INFO] [stdout] 75 | format!("{:.3}s", dispatcher_start.duration_since(start_time).as_secs_f64())); [INFO] [stdout] 76 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/threaded_impl/src/lib.rs:86:56 [INFO] [stdout] | [INFO] [stdout] 86 | if dispatcher_config.enable_logging && cycle_count % 5 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/threaded_impl/src/lib.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | / if dispatcher_config.enable_logging { [INFO] [stdout] 104 | | if config.enable_logging { [INFO] [stdout] 105 | | println!("[SYSTEM] Threaded dispatcher shutting down"); [INFO] [stdout] 106 | | } [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 103 ~ if dispatcher_config.enable_logging [INFO] [stdout] 104 ~ && config.enable_logging { [INFO] [stdout] 105 | println!("[SYSTEM] Threaded dispatcher shutting down"); [INFO] [stdout] 106 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> crates/threaded_impl/src/lib.rs:210:1 [INFO] [stdout] | [INFO] [stdout] 210 | / fn spawn_actuator( [INFO] [stdout] 211 | | actuator_type: ActuatorType, [INFO] [stdout] 212 | | deadline: Duration, [INFO] [stdout] 213 | | config: ExperimentConfig, [INFO] [stdout] ... | [INFO] [stdout] 218 | | start_time: Instant, [INFO] [stdout] 219 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> crates/async_impl/src/actuator.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | / pub async fn run_actuator_task( [INFO] [stdout] 18 | | actuator_type: ActuatorType, [INFO] [stdout] 19 | | deadline: Duration, [INFO] [stdout] 20 | | config: ExperimentConfig, [INFO] [stdout] ... | [INFO] [stdout] 26 | | dashboard: Option, [INFO] [stdout] 27 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/actuator.rs:65:37 [INFO] [stdout] | [INFO] [stdout] 65 | if config.enable_logging && cycle_count % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/actuator.rs:84:37 [INFO] [stdout] | [INFO] [stdout] 84 | if config.enable_logging && cycle_count % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/actuator.rs:107:37 [INFO] [stdout] | [INFO] [stdout] 107 | if config.enable_logging && cycle_count % 50 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(50)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/actuator.rs:138:37 [INFO] [stdout] | [INFO] [stdout] 138 | if config.enable_logging && cycle_count % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> crates/async_impl/src/sensor.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / pub async fn run_sensor_task( [INFO] [stdout] 17 | | config: ExperimentConfig, [INFO] [stdout] 18 | | sender: mpsc::Sender, [INFO] [stdout] 19 | | mut feedback_rx: mpsc::Receiver, [INFO] [stdout] ... | [INFO] [stdout] 24 | | dashboard: Option, [INFO] [stdout] 25 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> crates/async_impl/src/sensor.rs:48:23 [INFO] [stdout] | [INFO] [stdout] 48 | temperature = temperature.max(20.0).min(30.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `temperature.clamp(20.0, 30.0)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:51:37 [INFO] [stdout] | [INFO] [stdout] 51 | if config.enable_logging && cycle_id % 10 == 0 { // Log every 10th cycle for better visibility [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:83:37 [INFO] [stdout] | [INFO] [stdout] 83 | if config.enable_logging && cycle_id % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:95:37 [INFO] [stdout] | [INFO] [stdout] 95 | if config.enable_logging && cycle_id % 50 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(50)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:102:37 [INFO] [stdout] | [INFO] [stdout] 102 | if config.enable_logging && cycle_id % 100 == 0 && cycle_id > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:127:37 [INFO] [stdout] | [INFO] [stdout] 127 | if config.enable_logging && cycle_id % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> crates/async_impl/src/sensor.rs:141:35 [INFO] [stdout] | [INFO] [stdout] 141 | let processing_late = if processing_time_ns > PROCESSING_DEADLINE_NS { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 142 | | processing_time_ns - PROCESSING_DEADLINE_NS [INFO] [stdout] 143 | | } else { 0 }; [INFO] [stdout] | |________________________^ help: replace it with: `processing_time_ns.saturating_sub(PROCESSING_DEADLINE_NS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> crates/async_impl/src/sensor.rs:144:37 [INFO] [stdout] | [INFO] [stdout] 144 | let transmission_late = if transmission_time_ns > TRANSMISSION_DEADLINE_NS { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 145 | | transmission_time_ns - TRANSMISSION_DEADLINE_NS [INFO] [stdout] 146 | | } else { 0 }; [INFO] [stdout] | |________________________^ help: replace it with: `transmission_time_ns.saturating_sub(TRANSMISSION_DEADLINE_NS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:211:20 [INFO] [stdout] | [INFO] [stdout] 211 | if cycle_id % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:228:45 [INFO] [stdout] | [INFO] [stdout] 228 | if config.enable_logging && cycle_id % 10 == 0 && old_window != current_filter_window { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:238:45 [INFO] [stdout] | [INFO] [stdout] 238 | if config.enable_logging && cycle_id % 10 == 0 && old_window != current_filter_window { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:248:45 [INFO] [stdout] | [INFO] [stdout] 248 | if config.enable_logging && cycle_id % 20 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/lib.rs:103:56 [INFO] [stdout] | [INFO] [stdout] 103 | if dispatcher_config.enable_logging && cycle_count % 5 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> crates/async_impl/src/actuator.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | / pub async fn run_actuator_task( [INFO] [stdout] 18 | | actuator_type: ActuatorType, [INFO] [stdout] 19 | | deadline: Duration, [INFO] [stdout] 20 | | config: ExperimentConfig, [INFO] [stdout] ... | [INFO] [stdout] 26 | | dashboard: Option, [INFO] [stdout] 27 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/async_impl/src/lib.rs:192:17 [INFO] [stdout] | [INFO] [stdout] 192 | / if perf_config.enable_logging { [INFO] [stdout] 193 | | if config.enable_logging { [INFO] [stdout] 194 | | println!("[PERF] Throughput: {:.1} cycles/sec, Recent compliance: {:.1}% ({}/{} cycles met)", [INFO] [stdout] 195 | | throughput, compliance_rate, new_cycles - missed as u64, new_cycles); [INFO] [stdout] 196 | | } [INFO] [stdout] 197 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 192 ~ if perf_config.enable_logging [INFO] [stdout] 193 ~ && config.enable_logging { [INFO] [stdout] 194 | println!("[PERF] Throughput: {:.1} cycles/sec, Recent compliance: {:.1}% ({}/{} cycles met)", [INFO] [stdout] 195 | throughput, compliance_rate, new_cycles - missed as u64, new_cycles); [INFO] [stdout] 196 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> crates/async_impl/src/lib.rs:243:1 [INFO] [stdout] | [INFO] [stdout] 243 | / fn spawn_actuator( [INFO] [stdout] 244 | | actuator_type: ActuatorType, [INFO] [stdout] 245 | | deadline: Duration, [INFO] [stdout] 246 | | config: ExperimentConfig, [INFO] [stdout] ... | [INFO] [stdout] 252 | | dashboard: Option, [INFO] [stdout] 253 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/actuator.rs:65:37 [INFO] [stdout] | [INFO] [stdout] 65 | if config.enable_logging && cycle_count % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/actuator.rs:84:37 [INFO] [stdout] | [INFO] [stdout] 84 | if config.enable_logging && cycle_count % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/actuator.rs:107:37 [INFO] [stdout] | [INFO] [stdout] 107 | if config.enable_logging && cycle_count % 50 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(50)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/actuator.rs:138:37 [INFO] [stdout] | [INFO] [stdout] 138 | if config.enable_logging && cycle_count % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> crates/async_impl/src/sensor.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / pub async fn run_sensor_task( [INFO] [stdout] 17 | | config: ExperimentConfig, [INFO] [stdout] 18 | | sender: mpsc::Sender, [INFO] [stdout] 19 | | mut feedback_rx: mpsc::Receiver, [INFO] [stdout] ... | [INFO] [stdout] 24 | | dashboard: Option, [INFO] [stdout] 25 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> crates/async_impl/src/sensor.rs:48:23 [INFO] [stdout] | [INFO] [stdout] 48 | temperature = temperature.max(20.0).min(30.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `temperature.clamp(20.0, 30.0)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:51:37 [INFO] [stdout] | [INFO] [stdout] 51 | if config.enable_logging && cycle_id % 10 == 0 { // Log every 10th cycle for better visibility [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking egui_glow v0.24.1 [INFO] [stderr] Checking egui_plot v0.24.2 [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:83:37 [INFO] [stdout] | [INFO] [stdout] 83 | if config.enable_logging && cycle_id % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:95:37 [INFO] [stdout] | [INFO] [stdout] 95 | if config.enable_logging && cycle_id % 50 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(50)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:102:37 [INFO] [stdout] | [INFO] [stdout] 102 | if config.enable_logging && cycle_id % 100 == 0 && cycle_id > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:127:37 [INFO] [stdout] | [INFO] [stdout] 127 | if config.enable_logging && cycle_id % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> crates/async_impl/src/sensor.rs:141:35 [INFO] [stdout] | [INFO] [stdout] 141 | let processing_late = if processing_time_ns > PROCESSING_DEADLINE_NS { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 142 | | processing_time_ns - PROCESSING_DEADLINE_NS [INFO] [stdout] 143 | | } else { 0 }; [INFO] [stdout] | |________________________^ help: replace it with: `processing_time_ns.saturating_sub(PROCESSING_DEADLINE_NS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> crates/async_impl/src/sensor.rs:144:37 [INFO] [stdout] | [INFO] [stdout] 144 | let transmission_late = if transmission_time_ns > TRANSMISSION_DEADLINE_NS { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 145 | | transmission_time_ns - TRANSMISSION_DEADLINE_NS [INFO] [stdout] 146 | | } else { 0 }; [INFO] [stdout] | |________________________^ help: replace it with: `transmission_time_ns.saturating_sub(TRANSMISSION_DEADLINE_NS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:211:20 [INFO] [stdout] | [INFO] [stdout] 211 | if cycle_id % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:228:45 [INFO] [stdout] | [INFO] [stdout] 228 | if config.enable_logging && cycle_id % 10 == 0 && old_window != current_filter_window { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:238:45 [INFO] [stdout] | [INFO] [stdout] 238 | if config.enable_logging && cycle_id % 10 == 0 && old_window != current_filter_window { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/sensor.rs:248:45 [INFO] [stdout] | [INFO] [stdout] 248 | if config.enable_logging && cycle_id % 20 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/async_impl/src/lib.rs:103:56 [INFO] [stdout] | [INFO] [stdout] 103 | if dispatcher_config.enable_logging && cycle_count % 5 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_count.is_multiple_of(5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/async_impl/src/lib.rs:192:17 [INFO] [stdout] | [INFO] [stdout] 192 | / if perf_config.enable_logging { [INFO] [stdout] 193 | | if config.enable_logging { [INFO] [stdout] 194 | | println!("[PERF] Throughput: {:.1} cycles/sec, Recent compliance: {:.1}% ({}/{} cycles met)", [INFO] [stdout] 195 | | throughput, compliance_rate, new_cycles - missed as u64, new_cycles); [INFO] [stdout] 196 | | } [INFO] [stdout] 197 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 192 ~ if perf_config.enable_logging [INFO] [stdout] 193 ~ && config.enable_logging { [INFO] [stdout] 194 | println!("[PERF] Throughput: {:.1} cycles/sec, Recent compliance: {:.1}% ({}/{} cycles met)", [INFO] [stdout] 195 | throughput, compliance_rate, new_cycles - missed as u64, new_cycles); [INFO] [stdout] 196 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> crates/async_impl/src/lib.rs:243:1 [INFO] [stdout] | [INFO] [stdout] 243 | / fn spawn_actuator( [INFO] [stdout] 244 | | actuator_type: ActuatorType, [INFO] [stdout] 245 | | deadline: Duration, [INFO] [stdout] 246 | | config: ExperimentConfig, [INFO] [stdout] ... | [INFO] [stdout] 252 | | dashboard: Option, [INFO] [stdout] 253 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking real-time-sensor-actuator v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking benchmark_runner v0.1.0 (/opt/rustwide/workdir/bin/benchmark_runner) [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> bin/benchmark_runner/src/main.rs:177:35 [INFO] [stdout] | [INFO] [stdout] 177 | deadline_met: cycle_id % 100 != 0, // ~1% deadline misses [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `!cycle_id.is_multiple_of(100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> bin/benchmark_runner/src/main.rs:178:37 [INFO] [stdout] | [INFO] [stdout] 178 | lateness_ns: if cycle_id % 100 == 0 { 500 } else { 0 }, // Occasional lateness [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> bin/benchmark_runner/src/main.rs:334:9 [INFO] [stdout] | [INFO] [stdout] 334 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 333 - run_sync_strategy_csv_benchmarks(); [INFO] [stdout] 334 - return; [INFO] [stdout] 333 + run_sync_strategy_csv_benchmarks(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:132:15 [INFO] [stdout] | [INFO] [stdout] 132 | .args(&["run", "--release", "-p", "visualiser", "--", config_path, mode]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["run", "--release", "-p", "visualiser", "--", config_path, mode]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:165:15 [INFO] [stdout] | [INFO] [stdout] 165 | .args(&["run", "-p", "benchmark_runner", "--", config_path, mode, "--criterion"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["run", "-p", "benchmark_runner", "--", config_path, mode, "--criterion"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> bin/benchmark_runner/src/main.rs:177:35 [INFO] [stdout] | [INFO] [stdout] 177 | deadline_met: cycle_id % 100 != 0, // ~1% deadline misses [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `!cycle_id.is_multiple_of(100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> bin/benchmark_runner/src/main.rs:178:37 [INFO] [stdout] | [INFO] [stdout] 178 | lateness_ns: if cycle_id % 100 == 0 { 500 } else { 0 }, // Occasional lateness [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `cycle_id.is_multiple_of(100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> bin/benchmark_runner/src/main.rs:334:9 [INFO] [stdout] | [INFO] [stdout] 334 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 333 - run_sync_strategy_csv_benchmarks(); [INFO] [stdout] 334 - return; [INFO] [stdout] 333 + run_sync_strategy_csv_benchmarks(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:132:15 [INFO] [stdout] | [INFO] [stdout] 132 | .args(&["run", "--release", "-p", "visualiser", "--", config_path, mode]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["run", "--release", "-p", "visualiser", "--", config_path, mode]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:165:15 [INFO] [stdout] | [INFO] [stdout] 165 | .args(&["run", "-p", "benchmark_runner", "--", config_path, mode, "--criterion"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["run", "-p", "benchmark_runner", "--", config_path, mode, "--criterion"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking atspi-common v0.3.0 [INFO] [stderr] Checking atspi-proxies v0.3.0 [INFO] [stderr] Checking sctk-adwaita v0.5.4 [INFO] [stderr] Checking smithay-clipboard v0.6.6 [INFO] [stderr] Checking atspi-connection v0.3.0 [INFO] [stderr] Checking atspi v0.19.0 [INFO] [stderr] Checking accesskit_unix v0.6.2 [INFO] [stderr] Checking accesskit_winit v0.15.0 [INFO] [stderr] Checking egui-winit v0.24.1 [INFO] [stderr] Checking eframe v0.24.1 [INFO] [stderr] Checking visualiser v0.1.0 (/opt/rustwide/workdir/bin/visualiser) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> bin/visualiser/src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use async_impl; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> bin/visualiser/src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use async_impl; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> bin/visualiser/src/main.rs:528:23 [INFO] [stdout] | [INFO] [stdout] 528 | let config_path = args.get(1).map(|s| s.clone()).unwrap_or_else(|| "configs/experiment_baseline.toml".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `args.get(1).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> bin/visualiser/src/main.rs:529:16 [INFO] [stdout] | [INFO] [stdout] 529 | let mode = args.get(2).map(|s| s.clone()).unwrap_or_else(|| "async".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `args.get(2).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> bin/visualiser/src/main.rs:528:23 [INFO] [stdout] | [INFO] [stdout] 528 | let config_path = args.get(1).map(|s| s.clone()).unwrap_or_else(|| "configs/experiment_baseline.toml".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `args.get(1).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> bin/visualiser/src/main.rs:529:16 [INFO] [stdout] | [INFO] [stdout] 529 | let mode = args.get(2).map(|s| s.clone()).unwrap_or_else(|| "async".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `args.get(2).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 21s [INFO] running `Command { std: "docker" "inspect" "e22bedce06bc8dc33718b59fc015aaefc4dd4e8f4fb2418357550162ee11f0dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e22bedce06bc8dc33718b59fc015aaefc4dd4e8f4fb2418357550162ee11f0dc", kill_on_drop: false }` [INFO] [stdout] e22bedce06bc8dc33718b59fc015aaefc4dd4e8f4fb2418357550162ee11f0dc