[INFO] cloning repository https://github.com/Kanval87/rust_examples [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Kanval87/rust_examples" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKanval87%2Frust_examples", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKanval87%2Frust_examples'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 254a468dd4bd47225c84ac2ebdad3159b6816701 [INFO] linting Kanval87/rust_examples against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKanval87%2Frust_examples" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Kanval87/rust_examples [INFO] finished tweaking git repo https://github.com/Kanval87/rust_examples [INFO] tweaked toml for git repo https://github.com/Kanval87/rust_examples written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Kanval87/rust_examples on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Kanval87/rust_examples already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 122df17ca067c03abb2ea1661cd8b951fc260c27c3144f34476a6cadf61f0542 [INFO] running `Command { std: "docker" "start" "-a" "122df17ca067c03abb2ea1661cd8b951fc260c27c3144f34476a6cadf61f0542", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "122df17ca067c03abb2ea1661cd8b951fc260c27c3144f34476a6cadf61f0542", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "122df17ca067c03abb2ea1661cd8b951fc260c27c3144f34476a6cadf61f0542", kill_on_drop: false }` [INFO] [stdout] 122df17ca067c03abb2ea1661cd8b951fc260c27c3144f34476a6cadf61f0542 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 52dbf3955c184bf5b0b5f3fe67a5d6bceb1daad77a0b9ba1087cc386fbdff371 [INFO] running `Command { std: "docker" "start" "-a" "52dbf3955c184bf5b0b5f3fe67a5d6bceb1daad77a0b9ba1087cc386fbdff371", kill_on_drop: false }` [INFO] [stderr] Checking learningOne v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the `n @ _` pattern can be written as just `n` [INFO] [stdout] --> src/main.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | n @ _ => { [INFO] [stdout] | ^^^^^ help: try: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `n @ _` pattern can be written as just `n` [INFO] [stdout] --> src/main.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | n @ _ => { [INFO] [stdout] | ^^^^^ help: try: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/testing_custom_iterator.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | if !(self.number < 3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(self.number >= 3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/testing_custom_iterator.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return true; [INFO] [stdout] 36 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/testing_custom_iterator.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if prime_num % count == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `prime_num.is_multiple_of(count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/testing_closure_box_iterator.rs:104:46 [INFO] [stdout] | [INFO] [stdout] 104 | data.iter().take_while(|&&i| i == 2).fold(0, |s, i| s + i) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `sum::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/testing_closure_box_iterator.rs:108:26 [INFO] [stdout] | [INFO] [stdout] 108 | let list_map = (0..6).map(|i| i); [INFO] [stdout] | ^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/testing_custom_iterator.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | if !(self.number < 3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(self.number >= 3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/testing_custom_iterator.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return true; [INFO] [stdout] 36 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/testing_custom_iterator.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if prime_num % count == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `prime_num.is_multiple_of(count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/testing_closure_box_iterator.rs:104:46 [INFO] [stdout] | [INFO] [stdout] 104 | data.iter().take_while(|&&i| i == 2).fold(0, |s, i| s + i) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `sum::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/testing_closure_box_iterator.rs:108:26 [INFO] [stdout] | [INFO] [stdout] 108 | let list_map = (0..6).map(|i| i); [INFO] [stdout] | ^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.31s [INFO] running `Command { std: "docker" "inspect" "52dbf3955c184bf5b0b5f3fe67a5d6bceb1daad77a0b9ba1087cc386fbdff371", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52dbf3955c184bf5b0b5f3fe67a5d6bceb1daad77a0b9ba1087cc386fbdff371", kill_on_drop: false }` [INFO] [stdout] 52dbf3955c184bf5b0b5f3fe67a5d6bceb1daad77a0b9ba1087cc386fbdff371