[INFO] cloning repository https://github.com/KaiAF/grep-rs
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KaiAF/grep-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKaiAF%2Fgrep-rs", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKaiAF%2Fgrep-rs'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 03dc62aadaa2da135fb218cdf60443a8e2f3c39c
[INFO] linting KaiAF/grep-rs against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKaiAF%2Fgrep-rs" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/KaiAF/grep-rs
[INFO] finished tweaking git repo https://github.com/KaiAF/grep-rs
[INFO] tweaked toml for git repo https://github.com/KaiAF/grep-rs written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/KaiAF/grep-rs on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/KaiAF/grep-rs already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 3a67e1e0266e4678fd4ad5f51bff10365813f1f39381f99bab0d01f209780857
[INFO] running `Command { std: "docker" "start" "-a" "3a67e1e0266e4678fd4ad5f51bff10365813f1f39381f99bab0d01f209780857", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "3a67e1e0266e4678fd4ad5f51bff10365813f1f39381f99bab0d01f209780857", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "3a67e1e0266e4678fd4ad5f51bff10365813f1f39381f99bab0d01f209780857", kill_on_drop: false }`
[INFO] [stdout] 3a67e1e0266e4678fd4ad5f51bff10365813f1f39381f99bab0d01f209780857
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 6601603bef382eb47e35e1a51e5f7492bb8c2b1d4dba4f6411d54cdf99cf7024
[INFO] running `Command { std: "docker" "start" "-a" "6601603bef382eb47e35e1a51e5f7492bb8c2b1d4dba4f6411d54cdf99cf7024", kill_on_drop: false }`
[INFO] [stderr]     Checking memchr v2.7.2
[INFO] [stderr]     Checking regex-syntax v0.8.3
[INFO] [stderr]     Checking aho-corasick v1.1.3
[INFO] [stderr]     Checking regex-automata v0.4.6
[INFO] [stderr]     Checking regex v1.10.4
[INFO] [stderr]     Checking grep-rs v1.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:82:12
[INFO] [stdout]    |
[INFO] [stdout] 82 |         if !result_of_file.is_err() {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `result_of_file.is_ok()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `result_of_file` after checking its variant with `is_err`
[INFO] [stdout]   --> src/main.rs:83:33
[INFO] [stdout]    |
[INFO] [stdout] 82 |         if !result_of_file.is_err() {
[INFO] [stdout]    |             ----------------------- the check is happening here
[INFO] [stdout] 83 |             results.append(&mut result_of_file.unwrap());
[INFO] [stdout]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/main.rs:42:9
[INFO] [stdout]    |
[INFO] [stdout] 42 |         println!("");
[INFO] [stdout]    |         ^^^^^^^^^--^
[INFO] [stdout]    |                  |
[INFO] [stdout]    |                  help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]    = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/main.rs:51:9
[INFO] [stdout]    |
[INFO] [stdout] 51 |         println!("");
[INFO] [stdout]    |         ^^^^^^^^^--^
[INFO] [stdout]    |                  |
[INFO] [stdout]    |                  help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]   --> src/main.rs:68:61
[INFO] [stdout]    |
[INFO] [stdout] 68 |             println!("grep: {}: {}", &args[args.len() - 1], "");
[INFO] [stdout]    |                                                             ^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout]    = note: `#[warn(clippy::print_literal)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 68 -             println!("grep: {}: {}", &args[args.len() - 1], "");
[INFO] [stdout] 68 +             println!("grep: {}: ", &args[args.len() - 1]);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:128:5
[INFO] [stdout]     |
[INFO] [stdout] 128 |     return mapped_options;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 128 -     return mapped_options;
[INFO] [stdout] 128 +     mapped_options
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:90:29
[INFO] [stdout]    |
[INFO] [stdout] 90 | fn parse_options_bool(args: &Vec<String>) -> HashMap<&str, bool> {
[INFO] [stdout]    |                             ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 90 - fn parse_options_bool(args: &Vec<String>) -> HashMap<&str, bool> {
[INFO] [stdout] 90 + fn parse_options_bool(args: &[String]) -> HashMap<&str, bool> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/main.rs:100:8
[INFO] [stdout]     |
[INFO] [stdout] 100 |     if options.len() > 0 {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!options.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:144:5
[INFO] [stdout]     |
[INFO] [stdout] 144 |     return mapped_options;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 144 -     return mapped_options;
[INFO] [stdout] 144 +     mapped_options
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/main.rs:131:28
[INFO] [stdout]     |
[INFO] [stdout] 131 | fn parse_options_int(args: &Vec<String>) -> HashMap<&str, i32> {
[INFO] [stdout]     |                            ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 131 - fn parse_options_int(args: &Vec<String>) -> HashMap<&str, i32> {
[INFO] [stdout] 131 + fn parse_options_int(args: &[String]) -> HashMap<&str, i32> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/main.rs:136:8
[INFO] [stdout]     |
[INFO] [stdout] 136 |     if options.len() > 0 {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!options.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:208:13
[INFO] [stdout]     |
[INFO] [stdout] 208 |             return Ok(results);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 208 -             return Ok(results);
[INFO] [stdout] 208 +             Ok(results)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:222:13
[INFO] [stdout]     |
[INFO] [stdout] 222 |             return Err(());
[INFO] [stdout]     |             ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 222 -             return Err(());
[INFO] [stdout] 222 +             Err(())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:82:12
[INFO] [stdout]    |
[INFO] [stdout] 82 |         if !result_of_file.is_err() {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `result_of_file.is_ok()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `result_of_file` after checking its variant with `is_err`
[INFO] [stdout]   --> src/main.rs:83:33
[INFO] [stdout]    |
[INFO] [stdout] 82 |         if !result_of_file.is_err() {
[INFO] [stdout]    |             ----------------------- the check is happening here
[INFO] [stdout] 83 |             results.append(&mut result_of_file.unwrap());
[INFO] [stdout]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/main.rs:198:16
[INFO] [stdout]     |
[INFO] [stdout] 198 |             if results.len() > 0 {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!results.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/main.rs:42:9
[INFO] [stdout]    |
[INFO] [stdout] 42 |         println!("");
[INFO] [stdout]    |         ^^^^^^^^^--^
[INFO] [stdout]    |                  |
[INFO] [stdout]    |                  help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]    = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/main.rs:51:9
[INFO] [stdout]    |
[INFO] [stdout] 51 |         println!("");
[INFO] [stdout]    |         ^^^^^^^^^--^
[INFO] [stdout]    |                  |
[INFO] [stdout]    |                  help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `files` after checking its variant with `is_ok`
[INFO] [stdout]    --> src/main.rs:252:38
[INFO] [stdout]     |
[INFO] [stdout] 251 |                     if files.is_ok() {
[INFO] [stdout]     |                     ---------------- help: try: `if let Ok(<item>) = files`
[INFO] [stdout] 252 |                         let f = &mut files.unwrap();
[INFO] [stdout]     |                                      ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `result_of_file` after checking its variant with `is_ok`
[INFO] [stdout]    --> src/main.rs:268:45
[INFO] [stdout]     |
[INFO] [stdout] 267 |                     if result_of_file.is_ok() {
[INFO] [stdout]     |                     ------------------------- help: try: `if let Ok(<item>) = result_of_file`
[INFO] [stdout] 268 |                         results.append(&mut result_of_file.unwrap());
[INFO] [stdout]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:273:13
[INFO] [stdout]     |
[INFO] [stdout] 273 |             return Ok(results);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 273 -             return Ok(results);
[INFO] [stdout] 273 +             Ok(results)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]   --> src/main.rs:68:61
[INFO] [stdout]    |
[INFO] [stdout] 68 |             println!("grep: {}: {}", &args[args.len() - 1], "");
[INFO] [stdout]    |                                                             ^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout]    = note: `#[warn(clippy::print_literal)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 68 -             println!("grep: {}: {}", &args[args.len() - 1], "");
[INFO] [stdout] 68 +             println!("grep: {}: ", &args[args.len() - 1]);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:282:13
[INFO] [stdout]     |
[INFO] [stdout] 282 |             return Ok(results);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 282 -             return Ok(results);
[INFO] [stdout] 282 +             Ok(results)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/main.rs:253:28
[INFO] [stdout]     |
[INFO] [stdout] 253 |                         if f.len() > 0 {
[INFO] [stdout]     |                            ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!f.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:128:5
[INFO] [stdout]     |
[INFO] [stdout] 128 |     return mapped_options;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 128 -     return mapped_options;
[INFO] [stdout] 128 +     mapped_options
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:90:29
[INFO] [stdout]    |
[INFO] [stdout] 90 | fn parse_options_bool(args: &Vec<String>) -> HashMap<&str, bool> {
[INFO] [stdout]    |                             ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 90 - fn parse_options_bool(args: &Vec<String>) -> HashMap<&str, bool> {
[INFO] [stdout] 90 + fn parse_options_bool(args: &[String]) -> HashMap<&str, bool> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/main.rs:100:8
[INFO] [stdout]     |
[INFO] [stdout] 100 |     if options.len() > 0 {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!options.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:144:5
[INFO] [stdout]     |
[INFO] [stdout] 144 |     return mapped_options;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 144 -     return mapped_options;
[INFO] [stdout] 144 +     mapped_options
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/main.rs:131:28
[INFO] [stdout]     |
[INFO] [stdout] 131 | fn parse_options_int(args: &Vec<String>) -> HashMap<&str, i32> {
[INFO] [stdout]     |                            ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 131 - fn parse_options_int(args: &Vec<String>) -> HashMap<&str, i32> {
[INFO] [stdout] 131 + fn parse_options_int(args: &[String]) -> HashMap<&str, i32> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/main.rs:136:8
[INFO] [stdout]     |
[INFO] [stdout] 136 |     if options.len() > 0 {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!options.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:208:13
[INFO] [stdout]     |
[INFO] [stdout] 208 |             return Ok(results);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 208 -             return Ok(results);
[INFO] [stdout] 208 +             Ok(results)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:222:13
[INFO] [stdout]     |
[INFO] [stdout] 222 |             return Err(());
[INFO] [stdout]     |             ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 222 -             return Err(());
[INFO] [stdout] 222 +             Err(())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/main.rs:198:16
[INFO] [stdout]     |
[INFO] [stdout] 198 |             if results.len() > 0 {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!results.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `files` after checking its variant with `is_ok`
[INFO] [stdout]    --> src/main.rs:252:38
[INFO] [stdout]     |
[INFO] [stdout] 251 |                     if files.is_ok() {
[INFO] [stdout]     |                     ---------------- help: try: `if let Ok(<item>) = files`
[INFO] [stdout] 252 |                         let f = &mut files.unwrap();
[INFO] [stdout]     |                                      ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `result_of_file` after checking its variant with `is_ok`
[INFO] [stdout]    --> src/main.rs:268:45
[INFO] [stdout]     |
[INFO] [stdout] 267 |                     if result_of_file.is_ok() {
[INFO] [stdout]     |                     ------------------------- help: try: `if let Ok(<item>) = result_of_file`
[INFO] [stdout] 268 |                         results.append(&mut result_of_file.unwrap());
[INFO] [stdout]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:273:13
[INFO] [stdout]     |
[INFO] [stdout] 273 |             return Ok(results);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 273 -             return Ok(results);
[INFO] [stdout] 273 +             Ok(results)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:282:13
[INFO] [stdout]     |
[INFO] [stdout] 282 |             return Ok(results);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 282 -             return Ok(results);
[INFO] [stdout] 282 +             Ok(results)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/main.rs:253:28
[INFO] [stdout]     |
[INFO] [stdout] 253 |                         if f.len() > 0 {
[INFO] [stdout]     |                            ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!f.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.56s
[INFO] running `Command { std: "docker" "inspect" "6601603bef382eb47e35e1a51e5f7492bb8c2b1d4dba4f6411d54cdf99cf7024", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "6601603bef382eb47e35e1a51e5f7492bb8c2b1d4dba4f6411d54cdf99cf7024", kill_on_drop: false }`
[INFO] [stdout] 6601603bef382eb47e35e1a51e5f7492bb8c2b1d4dba4f6411d54cdf99cf7024