[INFO] cloning repository https://github.com/K4kug3n/nessy
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/K4kug3n/nessy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FK4kug3n%2Fnessy", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FK4kug3n%2Fnessy'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] b6987b5d81e91bebdd755a8991847a95ae9e86a3
[INFO] linting K4kug3n/nessy against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FK4kug3n%2Fnessy" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/K4kug3n/nessy
[INFO] finished tweaking git repo https://github.com/K4kug3n/nessy
[INFO] tweaked toml for git repo https://github.com/K4kug3n/nessy written to /workspace/builds/worker-1-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/K4kug3n/nessy on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/K4kug3n/nessy already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 757c346788056ffd5d2e0f60370095c9ad442ac31a41d6289ca6c6cae7433995
[INFO] running `Command { std: "docker" "start" "-a" "757c346788056ffd5d2e0f60370095c9ad442ac31a41d6289ca6c6cae7433995", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "757c346788056ffd5d2e0f60370095c9ad442ac31a41d6289ca6c6cae7433995", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "757c346788056ffd5d2e0f60370095c9ad442ac31a41d6289ca6c6cae7433995", kill_on_drop: false }`
[INFO] [stdout] 757c346788056ffd5d2e0f60370095c9ad442ac31a41d6289ca6c6cae7433995
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 1f61682f7d38f72bc3b6e1b7ce388349d4454effca9b91ee556a65027c06be0f
[INFO] running `Command { std: "docker" "start" "-a" "1f61682f7d38f72bc3b6e1b7ce388349d4454effca9b91ee556a65027c06be0f", kill_on_drop: false }`
[INFO] [stderr]     Checking nessy v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: constant `NAMETABLE1` is never used
[INFO] [stdout]   --> src/ppu.rs:62:7
[INFO] [stdout]    |
[INFO] [stdout] 62 | const NAMETABLE1             : u8 = 0b00000001;
[INFO] [stdout]    |       ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `NAMETABLE2` is never used
[INFO] [stdout]   --> src/ppu.rs:63:7
[INFO] [stdout]    |
[INFO] [stdout] 63 | const NAMETABLE2             : u8 = 0b00000010;
[INFO] [stdout]    |       ^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `SPRITE_PATTERN_ADDR` is never used
[INFO] [stdout]   --> src/ppu.rs:65:7
[INFO] [stdout]    |
[INFO] [stdout] 65 | const SPRITE_PATTERN_ADDR    : u8 = 0b00001000;
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `BACKROUND_PATTERN_ADDR` is never used
[INFO] [stdout]   --> src/ppu.rs:66:7
[INFO] [stdout]    |
[INFO] [stdout] 66 | const BACKROUND_PATTERN_ADDR : u8 = 0b00010000;
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `SPRITE_SIZE` is never used
[INFO] [stdout]   --> src/ppu.rs:67:7
[INFO] [stdout]    |
[INFO] [stdout] 67 | const SPRITE_SIZE            : u8 = 0b00100000;
[INFO] [stdout]    |       ^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `MASTER_SLAVE_SELECT` is never used
[INFO] [stdout]   --> src/ppu.rs:68:7
[INFO] [stdout]    |
[INFO] [stdout] 68 | const MASTER_SLAVE_SELECT    : u8 = 0b01000000;
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `GENERATE_NMI` is never used
[INFO] [stdout]   --> src/ppu.rs:69:7
[INFO] [stdout]    |
[INFO] [stdout] 69 | const GENERATE_NMI           : u8 = 0b10000000;
[INFO] [stdout]    |       ^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `oam_data` is never read
[INFO] [stdout]   --> src/ppu.rs:98:2
[INFO] [stdout]    |
[INFO] [stdout] 95 | pub struct Ppu {
[INFO] [stdout]    |            --- field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 98 |     oam_data: [u8; 256],
[INFO] [stdout]    |     ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Cpu`
[INFO] [stdout]    --> src/cpu.rs:125:2
[INFO] [stdout]     |
[INFO] [stdout] 125 | /     pub fn new() -> Cpu {
[INFO] [stdout] 126 | |         Cpu {
[INFO] [stdout] 127 | |             pc: 0x00,
[INFO] [stdout] 128 | |             sp: 0xFD,
[INFO] [stdout] ...   |
[INFO] [stdout] 144 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]     = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 124 + impl Default for Cpu {
[INFO] [stdout] 125 +     fn default() -> Self {
[INFO] [stdout] 126 +         Self::new()
[INFO] [stdout] 127 +     }
[INFO] [stdout] 128 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/cpu.rs:178:53
[INFO] [stdout]     |
[INFO] [stdout] 178 |     pub fn load_and_run(&mut self, bus: &mut Bus, pgr: &Vec<u8>) {
[INFO] [stdout]     |                                                        ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 178 -     pub fn load_and_run(&mut self, bus: &mut Bus, pgr: &Vec<u8>) {
[INFO] [stdout] 178 +     pub fn load_and_run(&mut self, bus: &mut Bus, pgr: &[u8]) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `NAMETABLE1` is never used
[INFO] [stdout]   --> src/ppu.rs:62:7
[INFO] [stdout]    |
[INFO] [stdout] 62 | const NAMETABLE1             : u8 = 0b00000001;
[INFO] [stdout]    |       ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `NAMETABLE2` is never used
[INFO] [stdout]   --> src/ppu.rs:63:7
[INFO] [stdout]    |
[INFO] [stdout] 63 | const NAMETABLE2             : u8 = 0b00000010;
[INFO] [stdout]    |       ^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `SPRITE_PATTERN_ADDR` is never used
[INFO] [stdout]   --> src/ppu.rs:65:7
[INFO] [stdout]    |
[INFO] [stdout] 65 | const SPRITE_PATTERN_ADDR    : u8 = 0b00001000;
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `BACKROUND_PATTERN_ADDR` is never used
[INFO] [stdout]   --> src/ppu.rs:66:7
[INFO] [stdout]    |
[INFO] [stdout] 66 | const BACKROUND_PATTERN_ADDR : u8 = 0b00010000;
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `SPRITE_SIZE` is never used
[INFO] [stdout]   --> src/ppu.rs:67:7
[INFO] [stdout]    |
[INFO] [stdout] 67 | const SPRITE_SIZE            : u8 = 0b00100000;
[INFO] [stdout]    |       ^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `MASTER_SLAVE_SELECT` is never used
[INFO] [stdout]   --> src/ppu.rs:68:7
[INFO] [stdout]    |
[INFO] [stdout] 68 | const MASTER_SLAVE_SELECT    : u8 = 0b01000000;
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `GENERATE_NMI` is never used
[INFO] [stdout]   --> src/ppu.rs:69:7
[INFO] [stdout]    |
[INFO] [stdout] 69 | const GENERATE_NMI           : u8 = 0b10000000;
[INFO] [stdout]    |       ^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `oam_data` is never read
[INFO] [stdout]   --> src/ppu.rs:98:2
[INFO] [stdout]    |
[INFO] [stdout] 95 | pub struct Ppu {
[INFO] [stdout]    |            --- field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 98 |     oam_data: [u8; 256],
[INFO] [stdout]    |     ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Cpu`
[INFO] [stdout]    --> src/cpu.rs:125:2
[INFO] [stdout]     |
[INFO] [stdout] 125 | /     pub fn new() -> Cpu {
[INFO] [stdout] 126 | |         Cpu {
[INFO] [stdout] 127 | |             pc: 0x00,
[INFO] [stdout] 128 | |             sp: 0xFD,
[INFO] [stdout] ...   |
[INFO] [stdout] 144 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]     = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 124 + impl Default for Cpu {
[INFO] [stdout] 125 +     fn default() -> Self {
[INFO] [stdout] 126 +         Self::new()
[INFO] [stdout] 127 +     }
[INFO] [stdout] 128 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/cpu.rs:178:53
[INFO] [stdout]     |
[INFO] [stdout] 178 |     pub fn load_and_run(&mut self, bus: &mut Bus, pgr: &Vec<u8>) {
[INFO] [stdout]     |                                                        ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 178 -     pub fn load_and_run(&mut self, bus: &mut Bus, pgr: &Vec<u8>) {
[INFO] [stdout] 178 +     pub fn load_and_run(&mut self, bus: &mut Bus, pgr: &[u8]) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]     --> src/cpu.rs:1038:22
[INFO] [stdout]      |
[INFO] [stdout] 1038 |         self.v =  u8::from(!(((self.a ^ value) & 0x80) != 0) && (((self.a ^ result) & 0x80) != 0));
[INFO] [stdout]      |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((self.a ^ value) & 0x80) == 0)`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]      = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]     --> src/cpu.rs:1097:3
[INFO] [stdout]      |
[INFO] [stdout] 1097 |         self.a = self.a | result;
[INFO] [stdout]      |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.a |= result`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]      = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]     --> src/cpu.rs:1111:3
[INFO] [stdout]      |
[INFO] [stdout] 1111 |         self.a = self.a ^ result;
[INFO] [stdout]      |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.a ^= result`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]     --> src/cpu.rs:1122:3
[INFO] [stdout]      |
[INFO] [stdout] 1122 |         self.a = self.a & result;
[INFO] [stdout]      |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.a &= result`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]     --> src/cpu.rs:1218:3
[INFO] [stdout]      |
[INFO] [stdout] 1218 |         assert_eq!(Cpu::is_crossing(0xABCD, 0xABCE), false);
[INFO] [stdout]      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout]      = note: `#[warn(clippy::bool_assert_comparison)]` on by default
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]      |
[INFO] [stdout] 1218 -         assert_eq!(Cpu::is_crossing(0xABCD, 0xABCE), false);
[INFO] [stdout] 1218 +         assert!(!Cpu::is_crossing(0xABCD, 0xABCE));
[INFO] [stdout]      |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]     --> src/cpu.rs:1219:3
[INFO] [stdout]      |
[INFO] [stdout] 1219 |         assert_eq!(Cpu::is_crossing(0x00FF, 0x0100), true);
[INFO] [stdout]      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]      |
[INFO] [stdout] 1219 -         assert_eq!(Cpu::is_crossing(0x00FF, 0x0100), true);
[INFO] [stdout] 1219 +         assert!(Cpu::is_crossing(0x00FF, 0x0100));
[INFO] [stdout]      |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]     --> src/cpu.rs:1220:3
[INFO] [stdout]      |
[INFO] [stdout] 1220 |         assert_eq!(Cpu::is_crossing(0xAB00, 0xFF00), true);
[INFO] [stdout]      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]      |
[INFO] [stdout] 1220 -         assert_eq!(Cpu::is_crossing(0xAB00, 0xFF00), true);
[INFO] [stdout] 1220 +         assert!(Cpu::is_crossing(0xAB00, 0xFF00));
[INFO] [stdout]      |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]     --> src/cpu.rs:1038:22
[INFO] [stdout]      |
[INFO] [stdout] 1038 |         self.v =  u8::from(!(((self.a ^ value) & 0x80) != 0) && (((self.a ^ result) & 0x80) != 0));
[INFO] [stdout]      |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((self.a ^ value) & 0x80) == 0)`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]      = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]     --> src/cpu.rs:1097:3
[INFO] [stdout]      |
[INFO] [stdout] 1097 |         self.a = self.a | result;
[INFO] [stdout]      |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.a |= result`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]      = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]     --> src/cpu.rs:1111:3
[INFO] [stdout]      |
[INFO] [stdout] 1111 |         self.a = self.a ^ result;
[INFO] [stdout]      |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.a ^= result`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]     --> src/cpu.rs:1122:3
[INFO] [stdout]      |
[INFO] [stdout] 1122 |         self.a = self.a & result;
[INFO] [stdout]      |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.a &= result`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `AddrRegister`
[INFO] [stdout]   --> src/ppu.rs:9:2
[INFO] [stdout]    |
[INFO] [stdout]  9 | /     pub fn new() -> AddrRegister {
[INFO] [stdout] 10 | |         AddrRegister {
[INFO] [stdout] 11 | |             value: 0x00,
[INFO] [stdout] 12 | |             is_hi: true
[INFO] [stdout] 13 | |         }
[INFO] [stdout] 14 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout]  8 + impl Default for AddrRegister {
[INFO] [stdout]  9 +     fn default() -> Self {
[INFO] [stdout] 10 +         Self::new()
[INFO] [stdout] 11 +     }
[INFO] [stdout] 12 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/ppu.rs:23:4
[INFO] [stdout]    |
[INFO] [stdout] 23 |             self.value = self.value & 0x3FFF; // Mirror down
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.value &= 0x3FFF`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/ppu.rs:33:4
[INFO] [stdout]    |
[INFO] [stdout] 33 |             self.value = self.value & 0x3FFF; // Mirror down
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.value &= 0x3FFF`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `ControlRegister`
[INFO] [stdout]   --> src/ppu.rs:72:2
[INFO] [stdout]    |
[INFO] [stdout] 72 | /     pub fn new() -> ControlRegister {
[INFO] [stdout] 73 | |         ControlRegister {
[INFO] [stdout] 74 | |             value: 0x00
[INFO] [stdout] 75 | |         }
[INFO] [stdout] 76 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 71 + impl Default for ControlRegister {
[INFO] [stdout] 72 +     fn default() -> Self {
[INFO] [stdout] 73 +         Self::new()
[INFO] [stdout] 74 +     }
[INFO] [stdout] 75 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/ppu.rs:79:3
[INFO] [stdout]    |
[INFO] [stdout] 79 |         return (self.value & flag) != 0;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 79 -         return (self.value & flag) != 0;
[INFO] [stdout] 79 +         (self.value & flag) != 0
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `AddrRegister`
[INFO] [stdout]   --> src/ppu.rs:9:2
[INFO] [stdout]    |
[INFO] [stdout]  9 | /     pub fn new() -> AddrRegister {
[INFO] [stdout] 10 | |         AddrRegister {
[INFO] [stdout] 11 | |             value: 0x00,
[INFO] [stdout] 12 | |             is_hi: true
[INFO] [stdout] 13 | |         }
[INFO] [stdout] 14 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout]  8 + impl Default for AddrRegister {
[INFO] [stdout]  9 +     fn default() -> Self {
[INFO] [stdout] 10 +         Self::new()
[INFO] [stdout] 11 +     }
[INFO] [stdout] 12 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/ppu.rs:23:4
[INFO] [stdout]    |
[INFO] [stdout] 23 |             self.value = self.value & 0x3FFF; // Mirror down
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.value &= 0x3FFF`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/ppu.rs:33:4
[INFO] [stdout]    |
[INFO] [stdout] 33 |             self.value = self.value & 0x3FFF; // Mirror down
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.value &= 0x3FFF`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `ControlRegister`
[INFO] [stdout]   --> src/ppu.rs:72:2
[INFO] [stdout]    |
[INFO] [stdout] 72 | /     pub fn new() -> ControlRegister {
[INFO] [stdout] 73 | |         ControlRegister {
[INFO] [stdout] 74 | |             value: 0x00
[INFO] [stdout] 75 | |         }
[INFO] [stdout] 76 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 71 + impl Default for ControlRegister {
[INFO] [stdout] 72 +     fn default() -> Self {
[INFO] [stdout] 73 +         Self::new()
[INFO] [stdout] 74 +     }
[INFO] [stdout] 75 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/ppu.rs:79:3
[INFO] [stdout]    |
[INFO] [stdout] 79 |         return (self.value & flag) != 0;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 79 -         return (self.value & flag) != 0;
[INFO] [stdout] 79 +         (self.value & flag) != 0
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.57s
[INFO] running `Command { std: "docker" "inspect" "1f61682f7d38f72bc3b6e1b7ce388349d4454effca9b91ee556a65027c06be0f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "1f61682f7d38f72bc3b6e1b7ce388349d4454effca9b91ee556a65027c06be0f", kill_on_drop: false }`
[INFO] [stdout] 1f61682f7d38f72bc3b6e1b7ce388349d4454effca9b91ee556a65027c06be0f