[INFO] cloning repository https://github.com/K-JBoon/bawk [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/K-JBoon/bawk" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FK-JBoon%2Fbawk", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FK-JBoon%2Fbawk'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d810cd5a669a1c2aabe8f2806363cf5ea45379b5 [INFO] linting K-JBoon/bawk against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FK-JBoon%2Fbawk" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/K-JBoon/bawk [INFO] finished tweaking git repo https://github.com/K-JBoon/bawk [INFO] tweaked toml for git repo https://github.com/K-JBoon/bawk written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/K-JBoon/bawk on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/K-JBoon/bawk already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded unicode-xid v0.1.0 [INFO] [stderr] Downloaded bit-vec v0.4.4 [INFO] [stderr] Downloaded redfa v0.0.2 [INFO] [stderr] Downloaded quote v0.6.13 [INFO] [stderr] Downloaded proc-macro2 v0.4.30 [INFO] [stderr] Downloaded bit-set v0.4.0 [INFO] [stderr] Downloaded vec_map v0.6.0 [INFO] [stderr] Downloaded lalr v0.0.2 [INFO] [stderr] Downloaded plex v0.2.5 [INFO] [stderr] Downloaded syn v0.15.44 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fd4d5b46e1c2cf6c0958ec748b8fff873de46a0b411ce62d6906e2f5d53d248b [INFO] running `Command { std: "docker" "start" "-a" "fd4d5b46e1c2cf6c0958ec748b8fff873de46a0b411ce62d6906e2f5d53d248b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fd4d5b46e1c2cf6c0958ec748b8fff873de46a0b411ce62d6906e2f5d53d248b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd4d5b46e1c2cf6c0958ec748b8fff873de46a0b411ce62d6906e2f5d53d248b", kill_on_drop: false }` [INFO] [stdout] fd4d5b46e1c2cf6c0958ec748b8fff873de46a0b411ce62d6906e2f5d53d248b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b5e507072d27b7f6ded6bc2bf2db76c7ef6207d3c25605588ab2fa4d303dacdd [INFO] running `Command { std: "docker" "start" "-a" "b5e507072d27b7f6ded6bc2bf2db76c7ef6207d3c25605588ab2fa4d303dacdd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling bit-vec v0.4.4 [INFO] [stderr] Compiling vec_map v0.6.0 [INFO] [stderr] Compiling lalr v0.0.2 [INFO] [stderr] Compiling bit-set v0.4.0 [INFO] [stderr] Compiling redfa v0.0.2 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling plex v0.2.5 [INFO] [stderr] Checking bawk v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/interpreter.rs:50:24 [INFO] [stdout] | [INFO] [stdout] 50 | _ => { () /* Just continue as normal, implement pattern rule here later */ } [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/interpreter.rs:50:24 [INFO] [stdout] | [INFO] [stdout] 50 | _ => { () /* Just continue as normal, implement pattern rule here later */ } [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | Print assign[a] Semi => Expr { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] = note: `#[warn(clippy::redundant_closure_call)]` on by default [INFO] [stdout] help: try doing something like [INFO] [stdout] | [INFO] [stdout] 55 ~ Expr { [INFO] [stdout] 56 + span: span!(), [INFO] [stdout] 57 + node: Expr_::Print(Box::new(a)), [INFO] [stdout] 58 ~ } => Expr { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | Ident(var) Equals assign[rhs] Semi => Expr { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try doing something like: `Ident(var) Equals assign[rhs] Semi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | atom[a] => a, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 - atom[a] => a, [INFO] [stdout] 63 + &mut [atom[a]] => a, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | atom[a] => a, [INFO] [stdout] | ^^^^^^^ help: try doing something like: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | Ident(i) => Expr { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 68 - Ident(i) => Expr { [INFO] [stdout] 68 + &mut [Ident(i)] => Expr { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | Ident(i) => Expr { [INFO] [stdout] | ^^^^^^^^ help: try doing something like: `Ident(i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | Integer(i) => Expr { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 72 - Integer(i) => Expr { [INFO] [stdout] 72 + &mut [Integer(i)] => Expr { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | Integer(i) => Expr { [INFO] [stdout] | ^^^^^^^^^^ help: try doing something like: `Integer(i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | Text(t) => Expr { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 76 - Text(t) => Expr { [INFO] [stdout] 76 + &mut [Text(t)] => Expr { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | Text(t) => Expr { [INFO] [stdout] | ^^^^^^^ help: try doing something like: `Text(t)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | LParen assign[a] RParen => a [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try doing something like: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | rules[r] => Program { rules: r } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - rules[r] => Program { rules: r } [INFO] [stdout] 19 + &mut [rules[r]] => Program { rules: r } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | rules[r] => Program { rules: r } [INFO] [stdout] | ^^^^^^^^ help: try doing something like: `Program { rules: r }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | => vec![], [INFO] [stdout] | ^^ help: try doing something like: `vec![]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | rules[mut rls] BeginRule statements[stmts] => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] help: try doing something like [INFO] [stdout] | [INFO] [stdout] 24 ~ { [INFO] [stdout] 25 + rls.push(Rule { rule_type: RuleType::BeginRule, statements: stmts }); [INFO] [stdout] 26 + rls [INFO] [stdout] 27 ~ } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | rules[mut rls] DefaultRule statements[stmts] => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] help: try doing something like [INFO] [stdout] | [INFO] [stdout] 28 ~ { [INFO] [stdout] 29 + rls.push(Rule { rule_type: RuleType::DefaultRule, statements: stmts }); [INFO] [stdout] 30 + rls [INFO] [stdout] 31 ~ } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | rules[mut rls] EndRule statements[stmts] => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] help: try doing something like [INFO] [stdout] | [INFO] [stdout] 32 ~ { [INFO] [stdout] 33 + rls.push(Rule { rule_type: RuleType::EndRule, statements: stmts }); [INFO] [stdout] 34 + rls [INFO] [stdout] 35 ~ } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | => Statement { expressions: vec![] }, [INFO] [stdout] | ^^ help: try doing something like: `Statement { expressions: vec![] }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | statement[mut st] assign[a] => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] help: try doing something like [INFO] [stdout] | [INFO] [stdout] 48 ~ { [INFO] [stdout] 49 + st.expressions.push(a); [INFO] [stdout] 50 + st [INFO] [stdout] 51 ~ } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | => vec![], [INFO] [stdout] | ^^ help: try doing something like: `vec![]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | statements[mut sts] statement[s] EndOfRule => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] help: try doing something like [INFO] [stdout] | [INFO] [stdout] 40 ~ { [INFO] [stdout] 41 + sts.push(s); [INFO] [stdout] 42 + sts [INFO] [stdout] 43 ~ } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/parser.rs:86:6 [INFO] [stdout] | [INFO] [stdout] 86 | ) -> Result, &'static str)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/interpreter.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn interp<'a>(p: &'a Program, file_path: &String) -> io::Result<()> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 7 - pub fn interp<'a>(p: &'a Program, file_path: &String) -> io::Result<()> { [INFO] [stdout] 7 + pub fn interp(p: &Program, file_path: &String) -> io::Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interpreter.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 48 | if !lines.peek().is_none() { continue; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `lines.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/interpreter.rs:55:43 [INFO] [stdout] | [INFO] [stdout] 55 | interp_expr(&mut env, &expr, &line); [INFO] [stdout] | ^^^^^ help: change this to: `expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/interpreter.rs:66:16 [INFO] [stdout] | [INFO] [stdout] 66 | fn interp_expr<'a>(env: &mut HashMap, expr: &'a Expr, l: &str) -> BawkType { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 66 - fn interp_expr<'a>(env: &mut HashMap, expr: &'a Expr, l: &str) -> BawkType { [INFO] [stdout] 66 + fn interp_expr(env: &mut HashMap, expr: &Expr, l: &str) -> BawkType { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/interpreter.rs:66:73 [INFO] [stdout] | [INFO] [stdout] 66 | fn interp_expr<'a>(env: &mut HashMap, expr: &'a Expr, l: &str) -> BawkType { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_l` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/interpreter.rs:71:43 [INFO] [stdout] | [INFO] [stdout] 71 | let val = interp_expr(env, b, l); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 79 | let val = interp_expr(env, e, l); [INFO] [stdout] | ^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `proc_macro_hygiene` is declared but not used [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(proc_macro_hygiene)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | Print assign[a] Semi => Expr { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] = note: `#[warn(clippy::redundant_closure_call)]` on by default [INFO] [stdout] help: try doing something like [INFO] [stdout] | [INFO] [stdout] 55 ~ Expr { [INFO] [stdout] 56 + span: span!(), [INFO] [stdout] 57 + node: Expr_::Print(Box::new(a)), [INFO] [stdout] 58 ~ } => Expr { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | Ident(var) Equals assign[rhs] Semi => Expr { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try doing something like: `Ident(var) Equals assign[rhs] Semi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | atom[a] => a, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 - atom[a] => a, [INFO] [stdout] 63 + &mut [atom[a]] => a, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | atom[a] => a, [INFO] [stdout] | ^^^^^^^ help: try doing something like: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | Ident(i) => Expr { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 68 - Ident(i) => Expr { [INFO] [stdout] 68 + &mut [Ident(i)] => Expr { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | Ident(i) => Expr { [INFO] [stdout] | ^^^^^^^^ help: try doing something like: `Ident(i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | Integer(i) => Expr { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 72 - Integer(i) => Expr { [INFO] [stdout] 72 + &mut [Integer(i)] => Expr { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | Integer(i) => Expr { [INFO] [stdout] | ^^^^^^^^^^ help: try doing something like: `Integer(i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | Text(t) => Expr { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 76 - Text(t) => Expr { [INFO] [stdout] 76 + &mut [Text(t)] => Expr { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | Text(t) => Expr { [INFO] [stdout] | ^^^^^^^ help: try doing something like: `Text(t)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | LParen assign[a] RParen => a [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try doing something like: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | rules[r] => Program { rules: r } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - rules[r] => Program { rules: r } [INFO] [stdout] 19 + &mut [rules[r]] => Program { rules: r } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | rules[r] => Program { rules: r } [INFO] [stdout] | ^^^^^^^^ help: try doing something like: `Program { rules: r }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | => vec![], [INFO] [stdout] | ^^ help: try doing something like: `vec![]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | rules[mut rls] BeginRule statements[stmts] => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] help: try doing something like [INFO] [stdout] | [INFO] [stdout] 24 ~ { [INFO] [stdout] 25 + rls.push(Rule { rule_type: RuleType::BeginRule, statements: stmts }); [INFO] [stdout] 26 + rls [INFO] [stdout] 27 ~ } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | rules[mut rls] DefaultRule statements[stmts] => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] help: try doing something like [INFO] [stdout] | [INFO] [stdout] 28 ~ { [INFO] [stdout] 29 + rls.push(Rule { rule_type: RuleType::DefaultRule, statements: stmts }); [INFO] [stdout] 30 + rls [INFO] [stdout] 31 ~ } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | rules[mut rls] EndRule statements[stmts] => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] help: try doing something like [INFO] [stdout] | [INFO] [stdout] 32 ~ { [INFO] [stdout] 33 + rls.push(Rule { rule_type: RuleType::EndRule, statements: stmts }); [INFO] [stdout] 34 + rls [INFO] [stdout] 35 ~ } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | => Statement { expressions: vec![] }, [INFO] [stdout] | ^^ help: try doing something like: `Statement { expressions: vec![] }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | statement[mut st] assign[a] => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] help: try doing something like [INFO] [stdout] | [INFO] [stdout] 48 ~ { [INFO] [stdout] 49 + st.expressions.push(a); [INFO] [stdout] 50 + st [INFO] [stdout] 51 ~ } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | => vec![], [INFO] [stdout] | ^^ help: try doing something like: `vec![]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> src/parser.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | statements[mut sts] statement[s] EndOfRule => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] help: try doing something like [INFO] [stdout] | [INFO] [stdout] 40 ~ { [INFO] [stdout] 41 + sts.push(s); [INFO] [stdout] 42 + sts [INFO] [stdout] 43 ~ } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/parser.rs:86:6 [INFO] [stdout] | [INFO] [stdout] 86 | ) -> Result, &'static str)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/interpreter.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn interp<'a>(p: &'a Program, file_path: &String) -> io::Result<()> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 7 - pub fn interp<'a>(p: &'a Program, file_path: &String) -> io::Result<()> { [INFO] [stdout] 7 + pub fn interp(p: &Program, file_path: &String) -> io::Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interpreter.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 48 | if !lines.peek().is_none() { continue; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `lines.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/interpreter.rs:55:43 [INFO] [stdout] | [INFO] [stdout] 55 | interp_expr(&mut env, &expr, &line); [INFO] [stdout] | ^^^^^ help: change this to: `expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/interpreter.rs:66:16 [INFO] [stdout] | [INFO] [stdout] 66 | fn interp_expr<'a>(env: &mut HashMap, expr: &'a Expr, l: &str) -> BawkType { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 66 - fn interp_expr<'a>(env: &mut HashMap, expr: &'a Expr, l: &str) -> BawkType { [INFO] [stdout] 66 + fn interp_expr(env: &mut HashMap, expr: &Expr, l: &str) -> BawkType { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/interpreter.rs:66:73 [INFO] [stdout] | [INFO] [stdout] 66 | fn interp_expr<'a>(env: &mut HashMap, expr: &'a Expr, l: &str) -> BawkType { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_l` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/interpreter.rs:71:43 [INFO] [stdout] | [INFO] [stdout] 71 | let val = interp_expr(env, b, l); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 79 | let val = interp_expr(env, e, l); [INFO] [stdout] | ^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `proc_macro_hygiene` is declared but not used [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(proc_macro_hygiene)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.99s [INFO] running `Command { std: "docker" "inspect" "b5e507072d27b7f6ded6bc2bf2db76c7ef6207d3c25605588ab2fa4d303dacdd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b5e507072d27b7f6ded6bc2bf2db76c7ef6207d3c25605588ab2fa4d303dacdd", kill_on_drop: false }` [INFO] [stdout] b5e507072d27b7f6ded6bc2bf2db76c7ef6207d3c25605588ab2fa4d303dacdd