[INFO] cloning repository https://github.com/JustAnotherStrange/tictactoe.rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JustAnotherStrange/tictactoe.rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJustAnotherStrange%2Ftictactoe.rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJustAnotherStrange%2Ftictactoe.rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 670c51ebf8fdb6603fdb28a9ff6e0b116e77b4e4 [INFO] linting JustAnotherStrange/tictactoe.rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJustAnotherStrange%2Ftictactoe.rs" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/JustAnotherStrange/tictactoe.rs [INFO] finished tweaking git repo https://github.com/JustAnotherStrange/tictactoe.rs [INFO] tweaked toml for git repo https://github.com/JustAnotherStrange/tictactoe.rs written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/JustAnotherStrange/tictactoe.rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/JustAnotherStrange/tictactoe.rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded getrandom v0.1.15 [INFO] [stderr] Downloaded libc v0.2.81 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 079a656a1e061808866add00847dc9601b7c735c82a69f88045ef6926f6bd725 [INFO] running `Command { std: "docker" "start" "-a" "079a656a1e061808866add00847dc9601b7c735c82a69f88045ef6926f6bd725", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "079a656a1e061808866add00847dc9601b7c735c82a69f88045ef6926f6bd725", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "079a656a1e061808866add00847dc9601b7c735c82a69f88045ef6926f6bd725", kill_on_drop: false }` [INFO] [stdout] 079a656a1e061808866add00847dc9601b7c735c82a69f88045ef6926f6bd725 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 28644979ba5fccff9d16813496477d18b6f0b78964b67fa0015e0019bd86a336 [INFO] running `Command { std: "docker" "start" "-a" "28644979ba5fccff9d16813496477d18b6f0b78964b67fa0015e0019bd86a336", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking tic v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / return match t { [INFO] [stdout] 26 | | Tile::X => 'X', [INFO] [stdout] 27 | | Tile::O => 'O', [INFO] [stdout] 28 | | _ => '-', [INFO] [stdout] 29 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 ~ match t { [INFO] [stdout] 26 + Tile::X => 'X', [INFO] [stdout] 27 + Tile::O => 'O', [INFO] [stdout] 28 + _ => '-', [INFO] [stdout] 29 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | return 2; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return 2; [INFO] [stdout] 90 + 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `board` [INFO] [stdout] --> src/main.rs:85:14 [INFO] [stdout] | [INFO] [stdout] 85 | for i in 0..9 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 85 - for i in 0..9 { [INFO] [stdout] 85 + for in board.iter().take(9) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 97 | if isx == true { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `isx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | input_int = input_int - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_int -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:208:5 [INFO] [stdout] | [INFO] [stdout] 208 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - return (0, false); [INFO] [stdout] 208 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:263:5 [INFO] [stdout] | [INFO] [stdout] 263 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 - return (0, false); [INFO] [stdout] 263 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:296:5 [INFO] [stdout] | [INFO] [stdout] 296 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 296 - return (0, false); [INFO] [stdout] 296 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / return match t { [INFO] [stdout] 26 | | Tile::X => 'X', [INFO] [stdout] 27 | | Tile::O => 'O', [INFO] [stdout] 28 | | _ => '-', [INFO] [stdout] 29 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 ~ match t { [INFO] [stdout] 26 + Tile::X => 'X', [INFO] [stdout] 27 + Tile::O => 'O', [INFO] [stdout] 28 + _ => '-', [INFO] [stdout] 29 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:314:5 [INFO] [stdout] | [INFO] [stdout] 314 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 314 - return (0, false); [INFO] [stdout] 314 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:309:16 [INFO] [stdout] | [INFO] [stdout] 309 | if norm_edge.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `norm_edge.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:321:5 [INFO] [stdout] | [INFO] [stdout] 321 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 321 - return (0, false); [INFO] [stdout] 321 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | return 2; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return 2; [INFO] [stdout] 90 + 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:351:5 [INFO] [stdout] | [INFO] [stdout] 351 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 351 - return (0, false); [INFO] [stdout] 351 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:381:5 [INFO] [stdout] | [INFO] [stdout] 381 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 381 - return (0, false); [INFO] [stdout] 381 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:389:20 [INFO] [stdout] | [INFO] [stdout] 389 | if (board[2] == Tile::X && board[0] == Tile::E) [INFO] [stdout] | ____________________^ [INFO] [stdout] 390 | | || (board[6] == Tile::X && board[0] == Tile::E) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 389 - if (board[2] == Tile::X && board[0] == Tile::E) [INFO] [stdout] 390 - || (board[6] == Tile::X && board[0] == Tile::E) [INFO] [stdout] 389 + if !(board[0] != Tile::E || board[2] != Tile::X && board[6] != Tile::X) [INFO] [stdout] | [INFO] [stdout] 389 - if (board[2] == Tile::X && board[0] == Tile::E) [INFO] [stdout] 390 - || (board[6] == Tile::X && board[0] == Tile::E) [INFO] [stdout] 389 + if (board[6] == Tile::X || board[2] == Tile::X) && board[0] == Tile::E [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:396:20 [INFO] [stdout] | [INFO] [stdout] 396 | if (board[0] == Tile::X && board[2] == Tile::E) [INFO] [stdout] | ____________________^ [INFO] [stdout] 397 | | || (board[8] == Tile::X && board[2] == Tile::E) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 396 - if (board[0] == Tile::X && board[2] == Tile::E) [INFO] [stdout] 397 - || (board[8] == Tile::X && board[2] == Tile::E) [INFO] [stdout] 396 + if !(board[2] != Tile::E || board[0] != Tile::X && board[8] != Tile::X) [INFO] [stdout] | [INFO] [stdout] 396 - if (board[0] == Tile::X && board[2] == Tile::E) [INFO] [stdout] 397 - || (board[8] == Tile::X && board[2] == Tile::E) [INFO] [stdout] 396 + if (board[8] == Tile::X || board[0] == Tile::X) && board[2] == Tile::E [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `board` [INFO] [stdout] --> src/main.rs:85:14 [INFO] [stdout] | [INFO] [stdout] 85 | for i in 0..9 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 85 - for i in 0..9 { [INFO] [stdout] 85 + for in board.iter().take(9) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 97 | if isx == true { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `isx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:403:20 [INFO] [stdout] | [INFO] [stdout] 403 | if (board[0] == Tile::X && board[6] == Tile::E) [INFO] [stdout] | ____________________^ [INFO] [stdout] 404 | | || (board[8] == Tile::X && board[6] == Tile::E) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 403 - if (board[0] == Tile::X && board[6] == Tile::E) [INFO] [stdout] 404 - || (board[8] == Tile::X && board[6] == Tile::E) [INFO] [stdout] 403 + if !(board[6] != Tile::E || board[0] != Tile::X && board[8] != Tile::X) [INFO] [stdout] | [INFO] [stdout] 403 - if (board[0] == Tile::X && board[6] == Tile::E) [INFO] [stdout] 404 - || (board[8] == Tile::X && board[6] == Tile::E) [INFO] [stdout] 403 + if (board[8] == Tile::X || board[0] == Tile::X) && board[6] == Tile::E [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:410:20 [INFO] [stdout] | [INFO] [stdout] 410 | if (board[2] == Tile::X && board[8] == Tile::E) [INFO] [stdout] | ____________________^ [INFO] [stdout] 411 | | || (board[6] == Tile::X && board[8] == Tile::E) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 410 - if (board[2] == Tile::X && board[8] == Tile::E) [INFO] [stdout] 411 - || (board[6] == Tile::X && board[8] == Tile::E) [INFO] [stdout] 410 + if !(board[8] != Tile::E || board[2] != Tile::X && board[6] != Tile::X) [INFO] [stdout] | [INFO] [stdout] 410 - if (board[2] == Tile::X && board[8] == Tile::E) [INFO] [stdout] 411 - || (board[6] == Tile::X && board[8] == Tile::E) [INFO] [stdout] 410 + if (board[6] == Tile::X || board[2] == Tile::X) && board[8] == Tile::E [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:419:5 [INFO] [stdout] | [INFO] [stdout] 419 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 419 - return (0, false); [INFO] [stdout] 419 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | input_int = input_int - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_int -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:474:5 [INFO] [stdout] | [INFO] [stdout] 474 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 474 - return (0, false); [INFO] [stdout] 474 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:208:5 [INFO] [stdout] | [INFO] [stdout] 208 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - return (0, false); [INFO] [stdout] 208 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:479:9 [INFO] [stdout] | [INFO] [stdout] 479 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 479 - return true; [INFO] [stdout] 479 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:483:13 [INFO] [stdout] | [INFO] [stdout] 483 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 483 - return false; [INFO] [stdout] 483 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:485:13 [INFO] [stdout] | [INFO] [stdout] 485 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 485 - return true; [INFO] [stdout] 485 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/main.rs:482:9 [INFO] [stdout] | [INFO] [stdout] 482 | / if rand >= diffgen { [INFO] [stdout] 483 | | return false; [INFO] [stdout] 484 | | } else { [INFO] [stdout] 485 | | return true; [INFO] [stdout] 486 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return rand < diffgen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:536:5 [INFO] [stdout] | [INFO] [stdout] 536 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 536 - return (0, false); [INFO] [stdout] 536 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:493:8 [INFO] [stdout] | [INFO] [stdout] 493 | if compdiffgen == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `compdiffgen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:495:12 [INFO] [stdout] | [INFO] [stdout] 495 | if two_os.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `two_os.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:499:12 [INFO] [stdout] | [INFO] [stdout] 499 | if two_xs.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `two_xs.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:503:12 [INFO] [stdout] | [INFO] [stdout] 503 | if two_xs_nonconsecutive.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `two_xs_nonconsecutive.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:507:12 [INFO] [stdout] | [INFO] [stdout] 507 | if middle.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `middle.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:511:12 [INFO] [stdout] | [INFO] [stdout] 511 | if randcorner_w_bordering_edge.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `randcorner_w_bordering_edge.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:515:12 [INFO] [stdout] | [INFO] [stdout] 515 | if rand_norm_corner.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rand_norm_corner.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:519:12 [INFO] [stdout] | [INFO] [stdout] 519 | if rand_norm_edge.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rand_norm_edge.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:523:12 [INFO] [stdout] | [INFO] [stdout] 523 | if rand_corner_w_bordering_corner.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rand_corner_w_bordering_corner.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:527:12 [INFO] [stdout] | [INFO] [stdout] 527 | if complete_random.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `complete_random.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:532:12 [INFO] [stdout] | [INFO] [stdout] 532 | if complete_random.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `complete_random.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:263:5 [INFO] [stdout] | [INFO] [stdout] 263 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 - return (0, false); [INFO] [stdout] 263 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:580:12 [INFO] [stdout] | [INFO] [stdout] 580 | if comp_turn.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `comp_turn.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:296:5 [INFO] [stdout] | [INFO] [stdout] 296 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 296 - return (0, false); [INFO] [stdout] 296 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:314:5 [INFO] [stdout] | [INFO] [stdout] 314 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 314 - return (0, false); [INFO] [stdout] 314 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:309:16 [INFO] [stdout] | [INFO] [stdout] 309 | if norm_edge.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `norm_edge.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:321:5 [INFO] [stdout] | [INFO] [stdout] 321 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 321 - return (0, false); [INFO] [stdout] 321 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:351:5 [INFO] [stdout] | [INFO] [stdout] 351 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 351 - return (0, false); [INFO] [stdout] 351 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:381:5 [INFO] [stdout] | [INFO] [stdout] 381 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 381 - return (0, false); [INFO] [stdout] 381 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:389:20 [INFO] [stdout] | [INFO] [stdout] 389 | if (board[2] == Tile::X && board[0] == Tile::E) [INFO] [stdout] | ____________________^ [INFO] [stdout] 390 | | || (board[6] == Tile::X && board[0] == Tile::E) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 389 - if (board[2] == Tile::X && board[0] == Tile::E) [INFO] [stdout] 390 - || (board[6] == Tile::X && board[0] == Tile::E) [INFO] [stdout] 389 + if !(board[0] != Tile::E || board[2] != Tile::X && board[6] != Tile::X) [INFO] [stdout] | [INFO] [stdout] 389 - if (board[2] == Tile::X && board[0] == Tile::E) [INFO] [stdout] 390 - || (board[6] == Tile::X && board[0] == Tile::E) [INFO] [stdout] 389 + if (board[6] == Tile::X || board[2] == Tile::X) && board[0] == Tile::E [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:396:20 [INFO] [stdout] | [INFO] [stdout] 396 | if (board[0] == Tile::X && board[2] == Tile::E) [INFO] [stdout] | ____________________^ [INFO] [stdout] 397 | | || (board[8] == Tile::X && board[2] == Tile::E) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 396 - if (board[0] == Tile::X && board[2] == Tile::E) [INFO] [stdout] 397 - || (board[8] == Tile::X && board[2] == Tile::E) [INFO] [stdout] 396 + if !(board[2] != Tile::E || board[0] != Tile::X && board[8] != Tile::X) [INFO] [stdout] | [INFO] [stdout] 396 - if (board[0] == Tile::X && board[2] == Tile::E) [INFO] [stdout] 397 - || (board[8] == Tile::X && board[2] == Tile::E) [INFO] [stdout] 396 + if (board[8] == Tile::X || board[0] == Tile::X) && board[2] == Tile::E [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:403:20 [INFO] [stdout] | [INFO] [stdout] 403 | if (board[0] == Tile::X && board[6] == Tile::E) [INFO] [stdout] | ____________________^ [INFO] [stdout] 404 | | || (board[8] == Tile::X && board[6] == Tile::E) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 403 - if (board[0] == Tile::X && board[6] == Tile::E) [INFO] [stdout] 404 - || (board[8] == Tile::X && board[6] == Tile::E) [INFO] [stdout] 403 + if !(board[6] != Tile::E || board[0] != Tile::X && board[8] != Tile::X) [INFO] [stdout] | [INFO] [stdout] 403 - if (board[0] == Tile::X && board[6] == Tile::E) [INFO] [stdout] 404 - || (board[8] == Tile::X && board[6] == Tile::E) [INFO] [stdout] 403 + if (board[8] == Tile::X || board[0] == Tile::X) && board[6] == Tile::E [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:410:20 [INFO] [stdout] | [INFO] [stdout] 410 | if (board[2] == Tile::X && board[8] == Tile::E) [INFO] [stdout] | ____________________^ [INFO] [stdout] 411 | | || (board[6] == Tile::X && board[8] == Tile::E) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 410 - if (board[2] == Tile::X && board[8] == Tile::E) [INFO] [stdout] 411 - || (board[6] == Tile::X && board[8] == Tile::E) [INFO] [stdout] 410 + if !(board[8] != Tile::E || board[2] != Tile::X && board[6] != Tile::X) [INFO] [stdout] | [INFO] [stdout] 410 - if (board[2] == Tile::X && board[8] == Tile::E) [INFO] [stdout] 411 - || (board[6] == Tile::X && board[8] == Tile::E) [INFO] [stdout] 410 + if (board[6] == Tile::X || board[2] == Tile::X) && board[8] == Tile::E [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:419:5 [INFO] [stdout] | [INFO] [stdout] 419 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 419 - return (0, false); [INFO] [stdout] 419 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:474:5 [INFO] [stdout] | [INFO] [stdout] 474 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 474 - return (0, false); [INFO] [stdout] 474 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:479:9 [INFO] [stdout] | [INFO] [stdout] 479 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 479 - return true; [INFO] [stdout] 479 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:483:13 [INFO] [stdout] | [INFO] [stdout] 483 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 483 - return false; [INFO] [stdout] 483 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:485:13 [INFO] [stdout] | [INFO] [stdout] 485 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 485 - return true; [INFO] [stdout] 485 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/main.rs:482:9 [INFO] [stdout] | [INFO] [stdout] 482 | / if rand >= diffgen { [INFO] [stdout] 483 | | return false; [INFO] [stdout] 484 | | } else { [INFO] [stdout] 485 | | return true; [INFO] [stdout] 486 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return rand < diffgen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:536:5 [INFO] [stdout] | [INFO] [stdout] 536 | return (0, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 536 - return (0, false); [INFO] [stdout] 536 + (0, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:493:8 [INFO] [stdout] | [INFO] [stdout] 493 | if compdiffgen == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `compdiffgen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:495:12 [INFO] [stdout] | [INFO] [stdout] 495 | if two_os.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `two_os.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:499:12 [INFO] [stdout] | [INFO] [stdout] 499 | if two_xs.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `two_xs.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:503:12 [INFO] [stdout] | [INFO] [stdout] 503 | if two_xs_nonconsecutive.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `two_xs_nonconsecutive.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:507:12 [INFO] [stdout] | [INFO] [stdout] 507 | if middle.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `middle.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:511:12 [INFO] [stdout] | [INFO] [stdout] 511 | if randcorner_w_bordering_edge.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `randcorner_w_bordering_edge.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:515:12 [INFO] [stdout] | [INFO] [stdout] 515 | if rand_norm_corner.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rand_norm_corner.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:519:12 [INFO] [stdout] | [INFO] [stdout] 519 | if rand_norm_edge.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rand_norm_edge.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:523:12 [INFO] [stdout] | [INFO] [stdout] 523 | if rand_corner_w_bordering_corner.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rand_corner_w_bordering_corner.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:527:12 [INFO] [stdout] | [INFO] [stdout] 527 | if complete_random.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `complete_random.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:532:12 [INFO] [stdout] | [INFO] [stdout] 532 | if complete_random.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `complete_random.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:580:12 [INFO] [stdout] | [INFO] [stdout] 580 | if comp_turn.1 == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `comp_turn.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.31s [INFO] running `Command { std: "docker" "inspect" "28644979ba5fccff9d16813496477d18b6f0b78964b67fa0015e0019bd86a336", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28644979ba5fccff9d16813496477d18b6f0b78964b67fa0015e0019bd86a336", kill_on_drop: false }` [INFO] [stdout] 28644979ba5fccff9d16813496477d18b6f0b78964b67fa0015e0019bd86a336