[INFO] cloning repository https://github.com/JulesCamuzet/rust-exercices [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JulesCamuzet/rust-exercices" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJulesCamuzet%2Frust-exercices", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJulesCamuzet%2Frust-exercices'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b2c5845cbfd9ff7612f140f8f73a0eb4a14768d1 [INFO] linting JulesCamuzet/rust-exercices against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJulesCamuzet%2Frust-exercices" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/JulesCamuzet/rust-exercices [INFO] finished tweaking git repo https://github.com/JulesCamuzet/rust-exercices [INFO] tweaked toml for git repo https://github.com/JulesCamuzet/rust-exercices written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/JulesCamuzet/rust-exercices on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/JulesCamuzet/rust-exercices already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cde632c7495bed0339f3514ca1bbb7a26309b0a3c05b708e7909ea28ab80afdb [INFO] running `Command { std: "docker" "start" "-a" "cde632c7495bed0339f3514ca1bbb7a26309b0a3c05b708e7909ea28ab80afdb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cde632c7495bed0339f3514ca1bbb7a26309b0a3c05b708e7909ea28ab80afdb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cde632c7495bed0339f3514ca1bbb7a26309b0a3c05b708e7909ea28ab80afdb", kill_on_drop: false }` [INFO] [stdout] cde632c7495bed0339f3514ca1bbb7a26309b0a3c05b708e7909ea28ab80afdb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a8dbb8229a30ba33b621ad3c8ea584613089edf17606f571530b2bf9461cd13d [INFO] running `Command { std: "docker" "start" "-a" "a8dbb8229a30ba33b621ad3c8ea584613089edf17606f571530b2bf9461cd13d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking cfg-if v1.0.1 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.1 [INFO] [stderr] Checking rust-exercices v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/mod.rs:10:3 [INFO] [stdout] | [INFO] [stdout] 10 | return parsed_result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return parsed_result; [INFO] [stdout] 10 + parsed_result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/mod.rs:19:3 [INFO] [stdout] | [INFO] [stdout] 19 | return parsed_result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return parsed_result; [INFO] [stdout] 19 + parsed_result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/mod.rs:27:3 [INFO] [stdout] | [INFO] [stdout] 27 | return entry; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return entry; [INFO] [stdout] 27 + entry [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/mod.rs:38:3 [INFO] [stdout] | [INFO] [stdout] 38 | return Some(cleaned_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return Some(cleaned_data); [INFO] [stdout] 38 + Some(cleaned_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tasks/display_tasks/mod.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | if !category.is_none() && !task.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `category.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tasks/display_tasks/mod.rs:41:31 [INFO] [stdout] | [INFO] [stdout] 41 | if !category.is_none() && !task.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `task.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `category` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/display_tasks/mod.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 41 | if !category.is_none() && !task.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 42 | match category.unwrap().as_str() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `task` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/display_tasks/mod.rs:46:33 [INFO] [stdout] | [INFO] [stdout] 41 | if !category.is_none() && !task.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 46 | todos_output.push_str(task.unwrap().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `task` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/display_tasks/mod.rs:53:32 [INFO] [stdout] | [INFO] [stdout] 41 | if !category.is_none() && !task.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 53 | done_output.push_str(task.unwrap().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `line_part_index` is used as a loop counter [INFO] [stdout] --> src/tasks/display_tasks/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | for part in line_parts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (line_part_index, part) in line_parts.enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/tasks/display_tasks/mod.rs:34:47 [INFO] [stdout] | [INFO] [stdout] 34 | } else if !current_part_is_category && !cleaned_part.eq("") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cleaned_part.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tasks/mark_as_done/mod.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `task.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tasks/mark_as_done/mod.rs:34:27 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `category.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `category` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/mark_as_done/mod.rs:35:32 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 35 | let unwrapped_category = category.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `task` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/mark_as_done/mod.rs:42:27 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 42 | new_data.push_str(task.unwrap().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `task` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/mark_as_done/mod.rs:47:27 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 47 | new_data.push_str(task.unwrap().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `line_part_index` is used as a loop counter [INFO] [stdout] --> src/tasks/mark_as_done/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | for part in line_parts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (line_part_index, part) in line_parts.enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/tasks/mark_as_done/mod.rs:27:47 [INFO] [stdout] | [INFO] [stdout] 27 | } else if !current_part_is_category && !cleaned_part.eq("") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cleaned_part.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tasks/mark_as_undone/mod.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `task.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tasks/mark_as_undone/mod.rs:34:27 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `category.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `category` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/mark_as_undone/mod.rs:35:32 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 35 | let unwrapped_category = category.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `task` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/mark_as_undone/mod.rs:41:27 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 41 | new_data.push_str(task.unwrap().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `task` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/mark_as_undone/mod.rs:46:27 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 46 | new_data.push_str(task.unwrap().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `line_part_index` is used as a loop counter [INFO] [stdout] --> src/tasks/mark_as_undone/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | for part in line_parts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (line_part_index, part) in line_parts.enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/tasks/mark_as_undone/mod.rs:27:47 [INFO] [stdout] | [INFO] [stdout] 27 | } else if !current_part_is_category && !cleaned_part.eq("") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cleaned_part.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tasks/delete_task/mod.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 35 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `task.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tasks/delete_task/mod.rs:35:27 [INFO] [stdout] | [INFO] [stdout] 35 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `category.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `category` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/delete_task/mod.rs:36:32 [INFO] [stdout] | [INFO] [stdout] 35 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 36 | let unwrapped_category = category.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `task` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/delete_task/mod.rs:43:27 [INFO] [stdout] | [INFO] [stdout] 35 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 43 | new_data.push_str(task.unwrap().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `line_part_index` is used as a loop counter [INFO] [stdout] --> src/tasks/delete_task/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | for part in line_parts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (line_part_index, part) in line_parts.enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/tasks/delete_task/mod.rs:28:47 [INFO] [stdout] | [INFO] [stdout] 28 | } else if !current_part_is_category && !cleaned_part.eq("") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cleaned_part.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/converter/helpers/mod.rs:2:3 [INFO] [stdout] | [INFO] [stdout] 2 | return meters * 3.28084; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 2 - return meters * 3.28084; [INFO] [stdout] 2 + meters * 3.28084 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/converter/helpers/mod.rs:6:3 [INFO] [stdout] | [INFO] [stdout] 6 | return feets / 3.28084; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 - return feets / 3.28084; [INFO] [stdout] 6 + feets / 3.28084 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/converter/helpers/mod.rs:10:3 [INFO] [stdout] | [INFO] [stdout] 10 | return celsius * (9.0 / 5.0) + 32.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return celsius * (9.0 / 5.0) + 32.0; [INFO] [stdout] 10 + celsius * (9.0 / 5.0) + 32.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/converter/helpers/mod.rs:14:3 [INFO] [stdout] | [INFO] [stdout] 14 | return fahr * (5.0 / 9.0) - 32.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return fahr * (5.0 / 9.0) - 32.0; [INFO] [stdout] 14 + fahr * (5.0 / 9.0) - 32.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | _ => return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 20 - _ => return [INFO] [stdout] 20 + _ => () [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/mod.rs:10:3 [INFO] [stdout] | [INFO] [stdout] 10 | return parsed_result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return parsed_result; [INFO] [stdout] 10 + parsed_result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/mod.rs:19:3 [INFO] [stdout] | [INFO] [stdout] 19 | return parsed_result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return parsed_result; [INFO] [stdout] 19 + parsed_result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/mod.rs:27:3 [INFO] [stdout] | [INFO] [stdout] 27 | return entry; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return entry; [INFO] [stdout] 27 + entry [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/mod.rs:38:3 [INFO] [stdout] | [INFO] [stdout] 38 | return Some(cleaned_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return Some(cleaned_data); [INFO] [stdout] 38 + Some(cleaned_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tasks/display_tasks/mod.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | if !category.is_none() && !task.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `category.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tasks/display_tasks/mod.rs:41:31 [INFO] [stdout] | [INFO] [stdout] 41 | if !category.is_none() && !task.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `task.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `category` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/display_tasks/mod.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 41 | if !category.is_none() && !task.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 42 | match category.unwrap().as_str() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `task` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/display_tasks/mod.rs:46:33 [INFO] [stdout] | [INFO] [stdout] 41 | if !category.is_none() && !task.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 46 | todos_output.push_str(task.unwrap().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `task` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/display_tasks/mod.rs:53:32 [INFO] [stdout] | [INFO] [stdout] 41 | if !category.is_none() && !task.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 53 | done_output.push_str(task.unwrap().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `line_part_index` is used as a loop counter [INFO] [stdout] --> src/tasks/display_tasks/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | for part in line_parts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (line_part_index, part) in line_parts.enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/tasks/display_tasks/mod.rs:34:47 [INFO] [stdout] | [INFO] [stdout] 34 | } else if !current_part_is_category && !cleaned_part.eq("") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cleaned_part.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tasks/mark_as_done/mod.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `task.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tasks/mark_as_done/mod.rs:34:27 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `category.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `category` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/mark_as_done/mod.rs:35:32 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 35 | let unwrapped_category = category.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `task` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/mark_as_done/mod.rs:42:27 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 42 | new_data.push_str(task.unwrap().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `task` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/mark_as_done/mod.rs:47:27 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 47 | new_data.push_str(task.unwrap().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `line_part_index` is used as a loop counter [INFO] [stdout] --> src/tasks/mark_as_done/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | for part in line_parts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (line_part_index, part) in line_parts.enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/tasks/mark_as_done/mod.rs:27:47 [INFO] [stdout] | [INFO] [stdout] 27 | } else if !current_part_is_category && !cleaned_part.eq("") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cleaned_part.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tasks/mark_as_undone/mod.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `task.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tasks/mark_as_undone/mod.rs:34:27 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `category.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `category` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/mark_as_undone/mod.rs:35:32 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 35 | let unwrapped_category = category.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `task` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/mark_as_undone/mod.rs:41:27 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 41 | new_data.push_str(task.unwrap().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `task` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/mark_as_undone/mod.rs:46:27 [INFO] [stdout] | [INFO] [stdout] 34 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 46 | new_data.push_str(task.unwrap().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `line_part_index` is used as a loop counter [INFO] [stdout] --> src/tasks/mark_as_undone/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | for part in line_parts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (line_part_index, part) in line_parts.enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/tasks/mark_as_undone/mod.rs:27:47 [INFO] [stdout] | [INFO] [stdout] 27 | } else if !current_part_is_category && !cleaned_part.eq("") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cleaned_part.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tasks/delete_task/mod.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 35 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `task.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tasks/delete_task/mod.rs:35:27 [INFO] [stdout] | [INFO] [stdout] 35 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `category.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `category` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/delete_task/mod.rs:36:32 [INFO] [stdout] | [INFO] [stdout] 35 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 36 | let unwrapped_category = category.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `task` after checking its variant with `is_none` [INFO] [stdout] --> src/tasks/delete_task/mod.rs:43:27 [INFO] [stdout] | [INFO] [stdout] 35 | if !task.is_none() && !category.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 43 | new_data.push_str(task.unwrap().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `line_part_index` is used as a loop counter [INFO] [stdout] --> src/tasks/delete_task/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | for part in line_parts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (line_part_index, part) in line_parts.enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/tasks/delete_task/mod.rs:28:47 [INFO] [stdout] | [INFO] [stdout] 28 | } else if !current_part_is_category && !cleaned_part.eq("") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cleaned_part.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/converter/helpers/mod.rs:2:3 [INFO] [stdout] | [INFO] [stdout] 2 | return meters * 3.28084; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 2 - return meters * 3.28084; [INFO] [stdout] 2 + meters * 3.28084 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/converter/helpers/mod.rs:6:3 [INFO] [stdout] | [INFO] [stdout] 6 | return feets / 3.28084; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 - return feets / 3.28084; [INFO] [stdout] 6 + feets / 3.28084 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/converter/helpers/mod.rs:10:3 [INFO] [stdout] | [INFO] [stdout] 10 | return celsius * (9.0 / 5.0) + 32.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return celsius * (9.0 / 5.0) + 32.0; [INFO] [stdout] 10 + celsius * (9.0 / 5.0) + 32.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/converter/helpers/mod.rs:14:3 [INFO] [stdout] | [INFO] [stdout] 14 | return fahr * (5.0 / 9.0) - 32.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return fahr * (5.0 / 9.0) - 32.0; [INFO] [stdout] 14 + fahr * (5.0 / 9.0) - 32.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | _ => return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 20 - _ => return [INFO] [stdout] 20 + _ => () [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.87s [INFO] running `Command { std: "docker" "inspect" "a8dbb8229a30ba33b621ad3c8ea584613089edf17606f571530b2bf9461cd13d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8dbb8229a30ba33b621ad3c8ea584613089edf17606f571530b2bf9461cd13d", kill_on_drop: false }` [INFO] [stdout] a8dbb8229a30ba33b621ad3c8ea584613089edf17606f571530b2bf9461cd13d