[INFO] cloning repository https://github.com/Jozi-Mwangi/Rust-server-client
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Jozi-Mwangi/Rust-server-client" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJozi-Mwangi%2FRust-server-client", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJozi-Mwangi%2FRust-server-client'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] c31550c3637bb209af921923f3000ec3be70300a
[INFO] linting Jozi-Mwangi/Rust-server-client against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJozi-Mwangi%2FRust-server-client" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/Jozi-Mwangi/Rust-server-client
[INFO] finished tweaking git repo https://github.com/Jozi-Mwangi/Rust-server-client
[INFO] tweaked toml for git repo https://github.com/Jozi-Mwangi/Rust-server-client written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/Jozi-Mwangi/Rust-server-client on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/Jozi-Mwangi/Rust-server-client already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded rustix v0.38.26
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] b10712859680958744bfd0592e5657bc78fe4e418a2a8d43059ebbfa264f502e
[INFO] running `Command { std: "docker" "start" "-a" "b10712859680958744bfd0592e5657bc78fe4e418a2a8d43059ebbfa264f502e", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "b10712859680958744bfd0592e5657bc78fe4e418a2a8d43059ebbfa264f502e", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "b10712859680958744bfd0592e5657bc78fe4e418a2a8d43059ebbfa264f502e", kill_on_drop: false }`
[INFO] [stdout] b10712859680958744bfd0592e5657bc78fe4e418a2a8d43059ebbfa264f502e
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 90cf02047858968ad65434a80771cf151018e1ddaaf88cf8082d881c39b0e32c
[INFO] running `Command { std: "docker" "start" "-a" "90cf02047858968ad65434a80771cf151018e1ddaaf88cf8082d881c39b0e32c", kill_on_drop: false }`
[INFO] [stderr]    Compiling rustix v0.38.26
[INFO] [stderr]     Checking linux-raw-sys v0.4.12
[INFO] [stderr]     Checking termcolor v1.4.0
[INFO] [stderr]     Checking regex-automata v0.4.3
[INFO] [stderr]     Checking is-terminal v0.4.9
[INFO] [stderr]     Checking regex v1.10.2
[INFO] [stderr]     Checking env_logger v0.10.1
[INFO] [stderr]     Checking server-side v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/lib.rs:4:1
[INFO] [stdout]   |
[INFO] [stdout] 4 | use base64;
[INFO] [stdout]   | ^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout]   = note: `#[warn(clippy::single_component_path_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/lib.rs:4:1
[INFO] [stdout]   |
[INFO] [stdout] 4 | use base64;
[INFO] [stdout]   | ^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout]   = note: `#[warn(clippy::single_component_path_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated function `base64::decode`: Use Engine::decode
[INFO] [stdout]  --> src/lib.rs:7:13
[INFO] [stdout]   |
[INFO] [stdout] 7 |     base64::decode(data)
[INFO] [stdout]   |             ^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(deprecated)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated function `base64::decode`: Use Engine::decode
[INFO] [stdout]  --> src/lib.rs:7:13
[INFO] [stdout]   |
[INFO] [stdout] 7 |     base64::decode(data)
[INFO] [stdout]   |             ^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(deprecated)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this can be `std::io::Error::other(_)`
[INFO] [stdout]   --> src/lib.rs:24:60
[INFO] [stdout]    |
[INFO] [stdout] 24 |         total_sales += parts[2].parse::<i32>().map_err(|_| io::Error::new(io::ErrorKind::Other, "Failed to parse sales data"))?;
[INFO] [stdout]    |                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
[INFO] [stdout]    = note: `#[warn(clippy::io_other_error)]` on by default
[INFO] [stdout] help: use `std::io::Error::other`
[INFO] [stdout]    |
[INFO] [stdout] 24 -         total_sales += parts[2].parse::<i32>().map_err(|_| io::Error::new(io::ErrorKind::Other, "Failed to parse sales data"))?;
[INFO] [stdout] 24 +         total_sales += parts[2].parse::<i32>().map_err(|_| io::Error::other("Failed to parse sales data"))?;
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)`
[INFO] [stdout]   --> src/lib.rs:35:9
[INFO] [stdout]    |
[INFO] [stdout] 35 |         .write(true)
[INFO] [stdout]    |         ^^^^^^^^^^^^ help: remove `.write(true)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options
[INFO] [stdout]    = note: `#[warn(clippy::ineffective_open_options)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this can be `std::io::Error::other(_)`
[INFO] [stdout]   --> src/lib.rs:24:60
[INFO] [stdout]    |
[INFO] [stdout] 24 |         total_sales += parts[2].parse::<i32>().map_err(|_| io::Error::new(io::ErrorKind::Other, "Failed to parse sales data"))?;
[INFO] [stdout]    |                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
[INFO] [stdout]    = note: `#[warn(clippy::io_other_error)]` on by default
[INFO] [stdout] help: use `std::io::Error::other`
[INFO] [stdout]    |
[INFO] [stdout] 24 -         total_sales += parts[2].parse::<i32>().map_err(|_| io::Error::new(io::ErrorKind::Other, "Failed to parse sales data"))?;
[INFO] [stdout] 24 +         total_sales += parts[2].parse::<i32>().map_err(|_| io::Error::other("Failed to parse sales data"))?;
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)`
[INFO] [stdout]   --> src/lib.rs:35:9
[INFO] [stdout]    |
[INFO] [stdout] 35 |         .write(true)
[INFO] [stdout]    |         ^^^^^^^^^^^^ help: remove `.write(true)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options
[INFO] [stdout]    = note: `#[warn(clippy::ineffective_open_options)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:35:8
[INFO] [stdout]    |
[INFO] [stdout] 35 |     if !fs::metadata(&output_dir).is_ok() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&output_dir).is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:35:22
[INFO] [stdout]    |
[INFO] [stdout] 35 |     if !fs::metadata(&output_dir).is_ok() {
[INFO] [stdout]    |                      ^^^^^^^^^^^ help: change this to: `output_dir`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:36:28
[INFO] [stdout]    |
[INFO] [stdout] 36 |         fs::create_dir_all(&output_dir).expect("Failed to create output directory");
[INFO] [stdout]    |                            ^^^^^^^^^^^ help: change this to: `output_dir`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:35:8
[INFO] [stdout]    |
[INFO] [stdout] 35 |     if !fs::metadata(&output_dir).is_ok() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&output_dir).is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:35:22
[INFO] [stdout]    |
[INFO] [stdout] 35 |     if !fs::metadata(&output_dir).is_ok() {
[INFO] [stdout]    |                      ^^^^^^^^^^^ help: change this to: `output_dir`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:36:28
[INFO] [stdout]    |
[INFO] [stdout] 36 |         fs::create_dir_all(&output_dir).expect("Failed to create output directory");
[INFO] [stdout]    |                            ^^^^^^^^^^^ help: change this to: `output_dir`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.87s
[INFO] running `Command { std: "docker" "inspect" "90cf02047858968ad65434a80771cf151018e1ddaaf88cf8082d881c39b0e32c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "90cf02047858968ad65434a80771cf151018e1ddaaf88cf8082d881c39b0e32c", kill_on_drop: false }`
[INFO] [stdout] 90cf02047858968ad65434a80771cf151018e1ddaaf88cf8082d881c39b0e32c