[INFO] cloning repository https://github.com/Jotrorox/supervocab [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Jotrorox/supervocab" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJotrorox%2Fsupervocab", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJotrorox%2Fsupervocab'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c8a4a93c72b599dc4e4347b93114382e52edf2f0 [INFO] linting Jotrorox/supervocab against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJotrorox%2Fsupervocab" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Jotrorox/supervocab [INFO] finished tweaking git repo https://github.com/Jotrorox/supervocab [INFO] tweaked toml for git repo https://github.com/Jotrorox/supervocab written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Jotrorox/supervocab on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Jotrorox/supervocab already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: package.authours [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.86 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.86 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.86 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.36 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.86 [INFO] [stderr] Downloaded security-framework-sys v2.9.0 [INFO] [stderr] Downloaded log v0.4.18 [INFO] [stderr] Downloaded tempfile v3.6.0 [INFO] [stderr] Downloaded openssl-sys v0.9.88 [INFO] [stderr] Downloaded tokio-util v0.7.8 [INFO] [stderr] Downloaded security-framework v2.9.1 [INFO] [stderr] Downloaded wasm-bindgen v0.2.86 [INFO] [stderr] Downloaded js-sys v0.3.63 [INFO] [stderr] Downloaded h2 v0.3.19 [INFO] [stderr] Downloaded reqwest v0.11.18 [INFO] [stderr] Downloaded openssl v0.10.54 [INFO] [stderr] Downloaded rustix v0.37.19 [INFO] [stderr] Downloaded tokio v1.28.2 [INFO] [stderr] Downloaded web-sys v0.3.63 [INFO] [stderr] Downloaded encoding_rs v0.8.32 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ed254d378b9d66dd65118bdcf0e6ce1b4a0d2cbd87f43c03dabf257bdc7db85f [INFO] running `Command { std: "docker" "start" "-a" "ed254d378b9d66dd65118bdcf0e6ce1b4a0d2cbd87f43c03dabf257bdc7db85f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ed254d378b9d66dd65118bdcf0e6ce1b4a0d2cbd87f43c03dabf257bdc7db85f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed254d378b9d66dd65118bdcf0e6ce1b4a0d2cbd87f43c03dabf257bdc7db85f", kill_on_drop: false }` [INFO] [stdout] ed254d378b9d66dd65118bdcf0e6ce1b4a0d2cbd87f43c03dabf257bdc7db85f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 368e3979aa0c55600e822c9a3ffff7983bfb04fb59e2194657e33a2efb557b07 [INFO] running `Command { std: "docker" "start" "-a" "368e3979aa0c55600e822c9a3ffff7983bfb04fb59e2194657e33a2efb557b07", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: package.authours [INFO] [stderr] Compiling libc v0.2.146 [INFO] [stderr] Compiling proc-macro2 v1.0.60 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling tokio v1.28.2 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Compiling log v0.4.18 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Compiling openssl v0.10.54 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Compiling serde v1.0.164 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Compiling serde_json v1.0.96 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking encoding_rs v0.8.32 [INFO] [stderr] Checking base64 v0.21.2 [INFO] [stderr] Checking ipnet v2.7.2 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Compiling openssl-sys v0.9.88 [INFO] [stderr] Compiling syn v2.0.18 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking rtoolbox v0.0.1 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking chrono v0.4.26 [INFO] [stderr] Checking rpassword v7.2.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking url v2.4.0 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.164 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.3.19 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyper v0.14.26 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.18 [INFO] [stderr] Checking super_vocab v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `card_ids` is never read [INFO] [stdout] --> src/markup_updater.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct MarkupUpdater { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 22 | key: Key, [INFO] [stdout] 23 | pub card_ids: Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `card_ids` is never read [INFO] [stdout] --> src/tag_updater.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct TagUpdater { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 22 | key: Key, [INFO] [stdout] 23 | pub card_ids: Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_key` is never used [INFO] [stdout] --> src/users.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 8 | impl Users { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 12 | pub fn add_key(&mut self, key: Key) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `card_ids` is never read [INFO] [stdout] --> src/markup_updater.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct MarkupUpdater { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 22 | key: Key, [INFO] [stdout] 23 | pub card_ids: Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/card_checker.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | if &resp[card_id]["data"]["tags"] [INFO] [stdout] | ________^ [INFO] [stdout] 17 | | .clone() [INFO] [stdout] 18 | | .to_owned() [INFO] [stdout] 19 | | .as_array_mut() [INFO] [stdout] 20 | | .unwrap() [INFO] [stdout] 21 | | .len() [INFO] [stdout] 22 | | <= &1 [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 16 ~ if resp[card_id]["data"]["tags"] [INFO] [stdout] 17 + .clone() [INFO] [stdout] 18 + .to_owned() [INFO] [stdout] 19 + .as_array_mut() [INFO] [stdout] 20 + .unwrap() [INFO] [stdout] 21 + .len() [INFO] [stdout] 22 ~ <= 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `card_ids` is never read [INFO] [stdout] --> src/tag_updater.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct TagUpdater { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 22 | key: Key, [INFO] [stdout] 23 | pub card_ids: Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_key` is never used [INFO] [stdout] --> src/users.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 8 | impl Users { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 12 | pub fn add_key(&mut self, key: Key) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/card_checker.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | if &resp[card_id]["data"]["tags"] [INFO] [stdout] | ________^ [INFO] [stdout] 17 | | .clone() [INFO] [stdout] 18 | | .to_owned() [INFO] [stdout] 19 | | .as_array_mut() [INFO] [stdout] 20 | | .unwrap() [INFO] [stdout] 21 | | .len() [INFO] [stdout] 22 | | <= &1 [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 16 ~ if resp[card_id]["data"]["tags"] [INFO] [stdout] 17 + .clone() [INFO] [stdout] 18 + .to_owned() [INFO] [stdout] 19 + .as_array_mut() [INFO] [stdout] 20 + .unwrap() [INFO] [stdout] 21 + .len() [INFO] [stdout] 22 ~ <= 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/card_checker.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | / if days_difference >= 3 { [INFO] [stdout] 67 | | return true; [INFO] [stdout] 68 | | } else { [INFO] [stdout] 69 | | return false; [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return days_difference >= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/card_checker.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | / if days_difference >= 7 { [INFO] [stdout] 75 | | return true; [INFO] [stdout] 76 | | } else { [INFO] [stdout] 77 | | return false; [INFO] [stdout] 78 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return days_difference >= 7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/card_checker.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | / if days_difference >= 14 { [INFO] [stdout] 83 | | return true; [INFO] [stdout] 84 | | } else { [INFO] [stdout] 85 | | return false; [INFO] [stdout] 86 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return days_difference >= 14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/card_checker.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | / if days_difference >= 3 { [INFO] [stdout] 67 | | return true; [INFO] [stdout] 68 | | } else { [INFO] [stdout] 69 | | return false; [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return days_difference >= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/card_checker.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | / if days_difference >= 30 { [INFO] [stdout] 91 | | return true; [INFO] [stdout] 92 | | } else { [INFO] [stdout] 93 | | return false; [INFO] [stdout] 94 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return days_difference >= 30` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/card_checker.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | / if days_difference >= 90 { [INFO] [stdout] 99 | | return true; [INFO] [stdout] 100 | | } else { [INFO] [stdout] 101 | | return false; [INFO] [stdout] 102 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return days_difference >= 90` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/card_checker.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | / if days_difference >= 7 { [INFO] [stdout] 75 | | return true; [INFO] [stdout] 76 | | } else { [INFO] [stdout] 77 | | return false; [INFO] [stdout] 78 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return days_difference >= 7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/card_checker.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | / if days_difference >= 180 { [INFO] [stdout] 107 | | return true; [INFO] [stdout] 108 | | } else { [INFO] [stdout] 109 | | return false; [INFO] [stdout] 110 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return days_difference >= 180` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/card_checker.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | / if days_difference >= 365 { [INFO] [stdout] 115 | | return true; [INFO] [stdout] 116 | | } else { [INFO] [stdout] 117 | | return false; [INFO] [stdout] 118 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return days_difference >= 365` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/card_checker.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | / if days_difference >= 14 { [INFO] [stdout] 83 | | return true; [INFO] [stdout] 84 | | } else { [INFO] [stdout] 85 | | return false; [INFO] [stdout] 86 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return days_difference >= 14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/card_checker.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | / if days_difference >= 30 { [INFO] [stdout] 91 | | return true; [INFO] [stdout] 92 | | } else { [INFO] [stdout] 93 | | return false; [INFO] [stdout] 94 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return days_difference >= 30` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/card_checker.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | / if days_difference >= 90 { [INFO] [stdout] 99 | | return true; [INFO] [stdout] 100 | | } else { [INFO] [stdout] 101 | | return false; [INFO] [stdout] 102 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return days_difference >= 90` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/card_checker.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | / if days_difference >= 180 { [INFO] [stdout] 107 | | return true; [INFO] [stdout] 108 | | } else { [INFO] [stdout] 109 | | return false; [INFO] [stdout] 110 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return days_difference >= 180` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/card_checker.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | / if days_difference >= 365 { [INFO] [stdout] 115 | | return true; [INFO] [stdout] 116 | | } else { [INFO] [stdout] 117 | | return false; [INFO] [stdout] 118 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return days_difference >= 365` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/card_checker.rs:169:54 [INFO] [stdout] | [INFO] [stdout] 169 | } else if current_state == "super-vocab-stage-7" { [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 170 | | current_state = "super-vocab-stage-8".to_string(); [INFO] [stdout] 171 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/card_checker.rs:171:12 [INFO] [stdout] | [INFO] [stdout] 171 | } else { [INFO] [stdout] | ____________^ [INFO] [stdout] 172 | | current_state = "super-vocab-stage-8".to_string(); [INFO] [stdout] 173 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/card_checker.rs:169:54 [INFO] [stdout] | [INFO] [stdout] 169 | } else if current_state == "super-vocab-stage-7" { [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 170 | | current_state = "super-vocab-stage-8".to_string(); [INFO] [stdout] 171 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/card_checker.rs:171:12 [INFO] [stdout] | [INFO] [stdout] 171 | } else { [INFO] [stdout] | ____________^ [INFO] [stdout] 172 | | current_state = "super-vocab-stage-8".to_string(); [INFO] [stdout] 173 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/card_checker.rs:233:53 [INFO] [stdout] | [INFO] [stdout] 233 | let _ = set_card_done(&card_id, &key).await; [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/card_checker.rs:233:53 [INFO] [stdout] | [INFO] [stdout] 233 | let _ = set_card_done(&card_id, &key).await; [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/card_getter.rs:44:15 [INFO] [stdout] | [INFO] [stdout] 44 | .post(&format!("{}/cards/get/select", BASE_URL)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/cards/get/select", BASE_URL)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/card_getter.rs:44:15 [INFO] [stdout] | [INFO] [stdout] 44 | .post(&format!("{}/cards/get/select", BASE_URL)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/cards/get/select", BASE_URL)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/key.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | if !fs::metadata("./config.json").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata("./config.json").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | return Self { key }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return Self { key }; [INFO] [stdout] 22 + Self { key } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | return Self { key }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return Self { key }; [INFO] [stdout] 31 + Self { key } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/key.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | let key: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ created here [INFO] [stdout] 13 | println!("Enter your key: "); [INFO] [stdout] 14 | / key = rpassword::read_password() [INFO] [stdout] 15 | | .unwrap() [INFO] [stdout] 16 | | .chars() [INFO] [stdout] 17 | | .collect::(); [INFO] [stdout] | |____________________________________^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `key` here [INFO] [stdout] | [INFO] [stdout] 12 ~ [INFO] [stdout] 13 | println!("Enter your key: "); [INFO] [stdout] 14 ~ let key: String = rpassword::read_password() [INFO] [stdout] 15 + .unwrap() [INFO] [stdout] 16 + .chars() [INFO] [stdout] 17 ~ .collect::(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/key.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | if !fs::metadata("./config.json").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata("./config.json").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | return Self { key }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return Self { key }; [INFO] [stdout] 22 + Self { key } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | return Self { key }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return Self { key }; [INFO] [stdout] 31 + Self { key } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/key.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | let key: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ created here [INFO] [stdout] 13 | println!("Enter your key: "); [INFO] [stdout] 14 | / key = rpassword::read_password() [INFO] [stdout] 15 | | .unwrap() [INFO] [stdout] 16 | | .chars() [INFO] [stdout] 17 | | .collect::(); [INFO] [stdout] | |____________________________________^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `key` here [INFO] [stdout] | [INFO] [stdout] 12 ~ [INFO] [stdout] 13 | println!("Enter your key: "); [INFO] [stdout] 14 ~ let key: String = rpassword::read_password() [INFO] [stdout] 15 + .unwrap() [INFO] [stdout] 16 + .chars() [INFO] [stdout] 17 ~ .collect::(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/markup_updater.rs:54:52 [INFO] [stdout] | [INFO] [stdout] 54 | println!("update_request_respnse: {}", json.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/markup_updater.rs:54:52 [INFO] [stdout] | [INFO] [stdout] 54 | println!("update_request_respnse: {}", json.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/simple_card.rs:52:19 [INFO] [stdout] | [INFO] [stdout] 52 | .post(&format!("{}/cards/simple", BASE_URL)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/cards/simple", BASE_URL)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/simple_card.rs:52:19 [INFO] [stdout] | [INFO] [stdout] 52 | .post(&format!("{}/cards/simple", BASE_URL)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/cards/simple", BASE_URL)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/util.rs:11:25 [INFO] [stdout] | [INFO] [stdout] 11 | .unwrap_or_else(|| Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/util.rs:11:25 [INFO] [stdout] | [INFO] [stdout] 11 | .unwrap_or_else(|| Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:26:33 [INFO] [stdout] | [INFO] [stdout] 26 | check_for_due_cards(&key).await; [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:26:33 [INFO] [stdout] | [INFO] [stdout] 26 | check_for_due_cards(&key).await; [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 25.00s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: openssl v0.10.54 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "368e3979aa0c55600e822c9a3ffff7983bfb04fb59e2194657e33a2efb557b07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "368e3979aa0c55600e822c9a3ffff7983bfb04fb59e2194657e33a2efb557b07", kill_on_drop: false }` [INFO] [stdout] 368e3979aa0c55600e822c9a3ffff7983bfb04fb59e2194657e33a2efb557b07