[INFO] cloning repository https://github.com/JoshuaSkootsky/todo [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JoshuaSkootsky/todo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJoshuaSkootsky%2Ftodo", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJoshuaSkootsky%2Ftodo'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cf8de8cff9e0d1f6ff7197ccd2f4de99cbd76fdf [INFO] linting JoshuaSkootsky/todo against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJoshuaSkootsky%2Ftodo" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/JoshuaSkootsky/todo [INFO] finished tweaking git repo https://github.com/JoshuaSkootsky/todo [INFO] tweaked toml for git repo https://github.com/JoshuaSkootsky/todo written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/JoshuaSkootsky/todo on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/JoshuaSkootsky/todo already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded windows-targets v0.48.5 [INFO] [stderr] Downloaded adler v1.0.2 [INFO] [stderr] Downloaded try-lock v0.2.5 [INFO] [stderr] Downloaded thiserror-impl v1.0.62 [INFO] [stderr] Downloaded httpdate v1.0.3 [INFO] [stderr] Downloaded untrusted v0.9.0 [INFO] [stderr] Downloaded percent-encoding v2.3.1 [INFO] [stderr] Downloaded itoa v1.0.11 [INFO] [stderr] Downloaded http-body v0.4.6 [INFO] [stderr] Downloaded sync_wrapper v0.1.2 [INFO] [stderr] Downloaded mime v0.3.17 [INFO] [stderr] Downloaded serde_urlencoded v0.7.1 [INFO] [stderr] Downloaded system-configuration v0.5.1 [INFO] [stderr] Downloaded tower-service v0.3.2 [INFO] [stderr] Downloaded httparse v1.9.4 [INFO] [stderr] Downloaded scopeguard v1.2.0 [INFO] [stderr] Downloaded tracing v0.1.40 [INFO] [stderr] Downloaded android_system_properties v0.1.5 [INFO] [stderr] Downloaded crossterm_winapi v0.9.1 [INFO] [stderr] Downloaded signal-hook-registry v1.4.2 [INFO] [stderr] Downloaded bitflags v2.6.0 [INFO] [stderr] Downloaded ppv-lite86 v0.2.17 [INFO] [stderr] Downloaded lock_api v0.4.12 [INFO] [stderr] Downloaded autocfg v1.3.0 [INFO] [stderr] Downloaded parking_lot v0.12.3 [INFO] [stderr] Downloaded base64 v0.13.1 [INFO] [stderr] Downloaded rand v0.8.5 [INFO] [stderr] Downloaded tokio-util v0.7.11 [INFO] [stderr] Downloaded crossterm v0.27.0 [INFO] [stderr] Downloaded hashbrown v0.14.5 [INFO] [stderr] Downloaded object v0.36.1 [INFO] [stderr] Downloaded futures-util v0.3.30 [INFO] [stderr] Downloaded rustls v0.21.12 [INFO] [stderr] Downloaded h2 v0.3.26 [INFO] [stderr] Downloaded windows_x86_64_gnullvm v0.48.5 [INFO] [stderr] Downloaded windows_aarch64_gnullvm v0.48.5 [INFO] [stderr] Downloaded windows_aarch64_gnullvm v0.52.6 [INFO] [stderr] Downloaded chrono v0.4.38 [INFO] [stderr] Downloaded windows_x86_64_gnullvm v0.52.6 [INFO] [stderr] Downloaded idna v0.5.0 [INFO] [stderr] Downloaded windows_i686_gnullvm v0.52.6 [INFO] [stderr] Downloaded gimli v0.29.0 [INFO] [stderr] Downloaded http v0.2.12 [INFO] [stderr] Downloaded indexmap v2.2.6 [INFO] [stderr] Downloaded webpki-roots v0.25.4 [INFO] [stderr] Downloaded syn v2.0.71 [INFO] [stderr] Downloaded iana-time-zone v0.1.60 [INFO] [stderr] Downloaded hyper v0.14.30 [INFO] [stderr] Downloaded signal-hook v0.3.17 [INFO] [stderr] Downloaded num-traits v0.2.19 [INFO] [stderr] Downloaded tracing-core v0.1.32 [INFO] [stderr] Downloaded wasm-bindgen v0.2.92 [INFO] [stderr] Downloaded slab v0.4.9 [INFO] [stderr] Downloaded libc v0.2.155 [INFO] [stderr] Downloaded web-sys v0.3.69 [INFO] [stderr] Downloaded windows_aarch64_msvc v0.48.5 [INFO] [stderr] Downloaded windows_i686_msvc v0.48.5 [INFO] [stderr] Downloaded windows_aarch64_msvc v0.52.6 [INFO] [stderr] Downloaded windows_i686_gnu v0.52.6 [INFO] [stderr] Downloaded windows_x86_64_msvc v0.52.6 [INFO] [stderr] Downloaded windows_i686_msvc v0.52.6 [INFO] [stderr] Downloaded windows_x86_64_gnu v0.52.6 [INFO] [stderr] Downloaded windows_i686_gnu v0.48.5 [INFO] [stderr] Downloaded windows_x86_64_gnu v0.48.5 [INFO] [stderr] Downloaded tokio v1.38.0 [INFO] [stderr] Downloaded windows_x86_64_msvc v0.48.5 [INFO] [stderr] Downloaded rustls-webpki v0.101.7 [INFO] [stderr] Downloaded reqwest v0.11.27 [INFO] [stderr] Downloaded redox_syscall v0.5.3 [INFO] [stderr] Downloaded smallvec v1.13.2 [INFO] [stderr] Downloaded parking_lot_core v0.9.10 [INFO] [stderr] Downloaded windows-core v0.52.0 [INFO] [stderr] Downloaded futures-channel v0.3.30 [INFO] [stderr] Downloaded futures-task v0.3.30 [INFO] [stderr] Downloaded pin-utils v0.1.0 [INFO] [stderr] Downloaded futures-core v0.3.30 [INFO] [stderr] Downloaded serde_json v1.0.120 [INFO] [stderr] Downloaded rand_core v0.6.4 [INFO] [stderr] Downloaded futures-sink v0.3.30 [INFO] [stderr] Downloaded unicode-normalization v0.1.23 [INFO] [stderr] Downloaded mio v0.8.11 [INFO] [stderr] Downloaded signal-hook-mio v0.2.3 [INFO] [stderr] Downloaded android-tzdata v0.1.1 [INFO] [stderr] Downloaded futures-io v0.3.30 [INFO] [stderr] Downloaded winapi v0.3.9 [INFO] [stderr] Downloaded equivalent v1.0.1 [INFO] [stderr] Downloaded backtrace v0.3.73 [INFO] [stderr] Downloaded base64 v0.21.7 [INFO] [stderr] Downloaded bumpalo v3.16.0 [INFO] [stderr] Downloaded memchr v2.7.4 [INFO] [stderr] Downloaded socket2 v0.5.7 [INFO] [stderr] Downloaded iana-time-zone-haiku v0.1.2 [INFO] [stderr] Downloaded rand_chacha v0.3.1 [INFO] [stderr] Downloaded fnv v1.0.7 [INFO] [stderr] Downloaded encoding_rs v0.8.34 [INFO] [stderr] Downloaded js-sys v0.3.69 [INFO] [stderr] Downloaded unicode-bidi v0.3.15 [INFO] [stderr] Downloaded tinyvec v1.8.0 [INFO] [stderr] Downloaded oauth2 v4.4.2 [INFO] [stderr] Downloaded serde_derive v1.0.204 [INFO] [stderr] Downloaded cc v1.1.3 [INFO] [stderr] Downloaded winreg v0.50.0 [INFO] [stderr] Downloaded typenum v1.17.0 [INFO] [stderr] Downloaded sha2 v0.10.8 [INFO] [stderr] Downloaded url v2.5.2 [INFO] [stderr] Downloaded ryu v1.0.18 [INFO] [stderr] Downloaded serde v1.0.204 [INFO] [stderr] Downloaded proc-macro2 v1.0.86 [INFO] [stderr] Downloaded quote v1.0.36 [INFO] [stderr] Downloaded addr2line v0.22.0 [INFO] [stderr] Downloaded miniz_oxide v0.7.4 [INFO] [stderr] Downloaded bytes v1.6.1 [INFO] [stderr] Downloaded hyper-rustls v0.24.2 [INFO] [stderr] Downloaded ipnet v2.9.0 [INFO] [stderr] Downloaded rustls-pemfile v1.0.4 [INFO] [stderr] Downloaded bitflags v1.3.2 [INFO] [stderr] Downloaded core-foundation-sys v0.8.6 [INFO] [stderr] Downloaded getrandom v0.2.15 [INFO] [stderr] Downloaded spin v0.9.8 [INFO] [stderr] Downloaded sct v0.7.1 [INFO] [stderr] Downloaded tokio-rustls v0.24.1 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.42 [INFO] [stderr] Downloaded once_cell v1.19.0 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.92 [INFO] [stderr] Downloaded serde_path_to_error v0.1.16 [INFO] [stderr] Downloaded digest v0.10.7 [INFO] [stderr] Downloaded unicode-ident v1.0.12 [INFO] [stderr] Downloaded pin-project-lite v0.2.14 [INFO] [stderr] Downloaded core-foundation v0.9.4 [INFO] [stderr] Downloaded rustc-demangle v0.1.24 [INFO] [stderr] Downloaded windows-targets v0.52.6 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.92 [INFO] [stderr] Downloaded thiserror v1.0.62 [INFO] [stderr] Downloaded log v0.4.22 [INFO] [stderr] Downloaded wasi v0.11.0+wasi-snapshot-preview1 [INFO] [stderr] Downloaded generic-array v0.14.7 [INFO] [stderr] Downloaded windows-sys v0.48.0 [INFO] [stderr] Downloaded block-buffer v0.10.4 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.92 [INFO] [stderr] Downloaded cpufeatures v0.2.12 [INFO] [stderr] Downloaded version_check v0.9.4 [INFO] [stderr] Downloaded tinyvec_macros v0.1.1 [INFO] [stderr] Downloaded want v0.3.1 [INFO] [stderr] Downloaded system-configuration-sys v0.5.0 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.92 [INFO] [stderr] Downloaded crypto-common v0.1.6 [INFO] [stderr] Downloaded form_urlencoded v1.2.1 [INFO] [stderr] Downloaded cfg-if v1.0.0 [INFO] [stderr] Downloaded windows-sys v0.52.0 [INFO] [stderr] Downloaded winapi-i686-pc-windows-gnu v0.4.0 [INFO] [stderr] Downloaded winapi-x86_64-pc-windows-gnu v0.4.0 [INFO] [stderr] Downloaded ring v0.17.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ec31deb46e54a28ecfb7740a3ddb9394e98ed449d29ea2b5ab9089c0ddba6908 [INFO] running `Command { std: "docker" "start" "-a" "ec31deb46e54a28ecfb7740a3ddb9394e98ed449d29ea2b5ab9089c0ddba6908", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ec31deb46e54a28ecfb7740a3ddb9394e98ed449d29ea2b5ab9089c0ddba6908", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec31deb46e54a28ecfb7740a3ddb9394e98ed449d29ea2b5ab9089c0ddba6908", kill_on_drop: false }` [INFO] [stdout] ec31deb46e54a28ecfb7740a3ddb9394e98ed449d29ea2b5ab9089c0ddba6908 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 964b308bd1d18db2d477c8f312055cd371d8eb3f59524a36da232403961840dd [INFO] running `Command { std: "docker" "start" "-a" "964b308bd1d18db2d477c8f312055cd371d8eb3f59524a36da232403961840dd", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling cc v1.1.3 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling thiserror v1.0.62 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking webpki-roots v0.25.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling thiserror-impl v1.0.62 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking oauth2 v4.4.2 [INFO] [stderr] Checking todo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/todo.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | use std::fs::{self, File}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/todo.rs:6:21 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{self, Read, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/todo.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | use std::fs::{self, File}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/todo.rs:6:21 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{self, Read, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/todo.rs:215:44 [INFO] [stdout] | [INFO] [stdout] 215 | let new_due_date = Some(NaiveDate::from_ymd(2023, 12, 31)); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/todo.rs:229:62 [INFO] [stdout] | [INFO] [stdout] 229 | DueDate::On(date) => assert_eq!(date, NaiveDate::from_ymd(2023, 12, 31)), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/todo.rs:6:27 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{self, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/todo.rs:6:27 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{self, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cli.rs:384:21 [INFO] [stdout] | [INFO] [stdout] 384 | / if selected > 0 { [INFO] [stdout] 385 | | selected -= 1; [INFO] [stdout] 386 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 383 ~ KeyCode::Up [INFO] [stdout] 384 ~ if selected > 0 => { [INFO] [stdout] 385 | selected -= 1; [INFO] [stdout] 386 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cli.rs:389:21 [INFO] [stdout] | [INFO] [stdout] 389 | / if selected < filenames.len() { [INFO] [stdout] 390 | | selected += 1; [INFO] [stdout] 391 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 388 ~ KeyCode::Down [INFO] [stdout] 389 ~ if selected < filenames.len() => { [INFO] [stdout] 390 | selected += 1; [INFO] [stdout] 391 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/cli.rs:384:21 [INFO] [stdout] | [INFO] [stdout] 384 | / if selected > 0 { [INFO] [stdout] 385 | | selected -= 1; [INFO] [stdout] 386 | | } [INFO] [stdout] | |_____________________^ help: try: `selected = selected.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/cli.rs:444:17 [INFO] [stdout] | [INFO] [stdout] 444 | Err(io::Error::new(io::ErrorKind::Other, e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 444 - Err(io::Error::new(io::ErrorKind::Other, e)) [INFO] [stdout] 444 + Err(io::Error::other(e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cli.rs:384:21 [INFO] [stdout] | [INFO] [stdout] 384 | / if selected > 0 { [INFO] [stdout] 385 | | selected -= 1; [INFO] [stdout] 386 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 383 ~ KeyCode::Up [INFO] [stdout] 384 ~ if selected > 0 => { [INFO] [stdout] 385 | selected -= 1; [INFO] [stdout] 386 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cli.rs:389:21 [INFO] [stdout] | [INFO] [stdout] 389 | / if selected < filenames.len() { [INFO] [stdout] 390 | | selected += 1; [INFO] [stdout] 391 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 388 ~ KeyCode::Down [INFO] [stdout] 389 ~ if selected < filenames.len() => { [INFO] [stdout] 390 | selected += 1; [INFO] [stdout] 391 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/cli.rs:384:21 [INFO] [stdout] | [INFO] [stdout] 384 | / if selected > 0 { [INFO] [stdout] 385 | | selected -= 1; [INFO] [stdout] 386 | | } [INFO] [stdout] | |_____________________^ help: try: `selected = selected.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/cli.rs:444:17 [INFO] [stdout] | [INFO] [stdout] 444 | Err(io::Error::new(io::ErrorKind::Other, e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 444 - Err(io::Error::new(io::ErrorKind::Other, e)) [INFO] [stdout] 444 + Err(io::Error::other(e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TodoList` [INFO] [stdout] --> src/todo.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | / pub fn new() -> TodoList { [INFO] [stdout] 76 | | TodoList { [INFO] [stdout] 77 | | tasks: HashMap::new(), [INFO] [stdout] 78 | | next_id: 1, [INFO] [stdout] 79 | | } [INFO] [stdout] 80 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 74 + impl Default for TodoList { [INFO] [stdout] 75 + fn default() -> Self { [INFO] [stdout] 76 + Self::new() [INFO] [stdout] 77 + } [INFO] [stdout] 78 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/todo.rs:112:28 [INFO] [stdout] | [INFO] [stdout] 112 | .filter(|task| category.map_or(true, |c| task.category == c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 112 - .filter(|task| category.map_or(true, |c| task.category == c)) [INFO] [stdout] 112 + .filter(|task| category.is_none_or(|c| task.category == c)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/todo.rs:201:17 [INFO] [stdout] | [INFO] [stdout] 201 | assert!(!list.remove_task(id).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `list.remove_task(id).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TodoList` [INFO] [stdout] --> src/todo.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | / pub fn new() -> TodoList { [INFO] [stdout] 76 | | TodoList { [INFO] [stdout] 77 | | tasks: HashMap::new(), [INFO] [stdout] 78 | | next_id: 1, [INFO] [stdout] 79 | | } [INFO] [stdout] 80 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 74 + impl Default for TodoList { [INFO] [stdout] 75 + fn default() -> Self { [INFO] [stdout] 76 + Self::new() [INFO] [stdout] 77 + } [INFO] [stdout] 78 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/todo.rs:112:28 [INFO] [stdout] | [INFO] [stdout] 112 | .filter(|task| category.map_or(true, |c| task.category == c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 112 - .filter(|task| category.map_or(true, |c| task.category == c)) [INFO] [stdout] 112 + .filter(|task| category.is_none_or(|c| task.category == c)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/todo.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | use std::fs::{self, File}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/todo.rs:6:21 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{self, Read, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/todo.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | use std::fs::{self, File}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/todo.rs:6:21 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{self, Read, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/todo_tests.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | assert!(!todo_list.remove_task(id).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `todo_list.remove_task(id).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> tests/todo_tests.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | todo_list.update_task(id, task_update); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 86 | let _ = todo_list.update_task(id, task_update); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> tests/todo_tests.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | todo_list.update_task(id, task_update); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 103 | let _ = todo_list.update_task(id, task_update); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> tests/todo_tests.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | todo_list.update_task(id, task_update); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 118 | let _ = todo_list.update_task(id, task_update); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> tests/todo_tests.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 133 | todo_list.update_task(id, task_update); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 133 | let _ = todo_list.update_task(id, task_update); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/todo.rs:215:44 [INFO] [stdout] | [INFO] [stdout] 215 | let new_due_date = Some(NaiveDate::from_ymd(2023, 12, 31)); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/todo.rs:229:62 [INFO] [stdout] | [INFO] [stdout] 229 | DueDate::On(date) => assert_eq!(date, NaiveDate::from_ymd(2023, 12, 31)), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/todo.rs:6:27 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{self, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/todo.rs:6:27 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{self, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Status` is never used [INFO] [stdout] --> src/todo.rs:50:10 [INFO] [stdout] | [INFO] [stdout] 50 | pub enum Status { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Status` is never used [INFO] [stdout] --> src/todo.rs:50:10 [INFO] [stdout] | [INFO] [stdout] 50 | pub enum Status { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cli.rs:384:21 [INFO] [stdout] | [INFO] [stdout] 384 | / if selected > 0 { [INFO] [stdout] 385 | | selected -= 1; [INFO] [stdout] 386 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 383 ~ KeyCode::Up [INFO] [stdout] 384 ~ if selected > 0 => { [INFO] [stdout] 385 | selected -= 1; [INFO] [stdout] 386 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cli.rs:389:21 [INFO] [stdout] | [INFO] [stdout] 389 | / if selected < filenames.len() { [INFO] [stdout] 390 | | selected += 1; [INFO] [stdout] 391 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 388 ~ KeyCode::Down [INFO] [stdout] 389 ~ if selected < filenames.len() => { [INFO] [stdout] 390 | selected += 1; [INFO] [stdout] 391 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/cli.rs:384:21 [INFO] [stdout] | [INFO] [stdout] 384 | / if selected > 0 { [INFO] [stdout] 385 | | selected -= 1; [INFO] [stdout] 386 | | } [INFO] [stdout] | |_____________________^ help: try: `selected = selected.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/cli.rs:444:17 [INFO] [stdout] | [INFO] [stdout] 444 | Err(io::Error::new(io::ErrorKind::Other, e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 444 - Err(io::Error::new(io::ErrorKind::Other, e)) [INFO] [stdout] 444 + Err(io::Error::other(e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cli.rs:384:21 [INFO] [stdout] | [INFO] [stdout] 384 | / if selected > 0 { [INFO] [stdout] 385 | | selected -= 1; [INFO] [stdout] 386 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 383 ~ KeyCode::Up [INFO] [stdout] 384 ~ if selected > 0 => { [INFO] [stdout] 385 | selected -= 1; [INFO] [stdout] 386 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cli.rs:389:21 [INFO] [stdout] | [INFO] [stdout] 389 | / if selected < filenames.len() { [INFO] [stdout] 390 | | selected += 1; [INFO] [stdout] 391 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 388 ~ KeyCode::Down [INFO] [stdout] 389 ~ if selected < filenames.len() => { [INFO] [stdout] 390 | selected += 1; [INFO] [stdout] 391 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/cli.rs:384:21 [INFO] [stdout] | [INFO] [stdout] 384 | / if selected > 0 { [INFO] [stdout] 385 | | selected -= 1; [INFO] [stdout] 386 | | } [INFO] [stdout] | |_____________________^ help: try: `selected = selected.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/cli.rs:444:17 [INFO] [stdout] | [INFO] [stdout] 444 | Err(io::Error::new(io::ErrorKind::Other, e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 444 - Err(io::Error::new(io::ErrorKind::Other, e)) [INFO] [stdout] 444 + Err(io::Error::other(e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/todo.rs:112:28 [INFO] [stdout] | [INFO] [stdout] 112 | .filter(|task| category.map_or(true, |c| task.category == c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 112 - .filter(|task| category.map_or(true, |c| task.category == c)) [INFO] [stdout] 112 + .filter(|task| category.is_none_or(|c| task.category == c)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/todo.rs:201:17 [INFO] [stdout] | [INFO] [stdout] 201 | assert!(!list.remove_task(id).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `list.remove_task(id).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/todo.rs:112:28 [INFO] [stdout] | [INFO] [stdout] 112 | .filter(|task| category.map_or(true, |c| task.category == c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 112 - .filter(|task| category.map_or(true, |c| task.category == c)) [INFO] [stdout] 112 + .filter(|task| category.is_none_or(|c| task.category == c)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.49s [INFO] running `Command { std: "docker" "inspect" "964b308bd1d18db2d477c8f312055cd371d8eb3f59524a36da232403961840dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "964b308bd1d18db2d477c8f312055cd371d8eb3f59524a36da232403961840dd", kill_on_drop: false }` [INFO] [stdout] 964b308bd1d18db2d477c8f312055cd371d8eb3f59524a36da232403961840dd