[INFO] cloning repository https://github.com/JosFer720/Proyecto-sistema-solar [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JosFer720/Proyecto-sistema-solar" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJosFer720%2FProyecto-sistema-solar", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJosFer720%2FProyecto-sistema-solar'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] af8a4157a848a085c0db184abf319185c6b2bf15 [INFO] linting JosFer720/Proyecto-sistema-solar against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJosFer720%2FProyecto-sistema-solar" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/JosFer720/Proyecto-sistema-solar [INFO] finished tweaking git repo https://github.com/JosFer720/Proyecto-sistema-solar [INFO] tweaked toml for git repo https://github.com/JosFer720/Proyecto-sistema-solar written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/JosFer720/Proyecto-sistema-solar on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/JosFer720/Proyecto-sistema-solar already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded glam v0.24.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2868ecd56ed1f23a318640fed8f7ef1498acf227b6ae53a9c2a7838ca2bc7456 [INFO] running `Command { std: "docker" "start" "-a" "2868ecd56ed1f23a318640fed8f7ef1498acf227b6ae53a9c2a7838ca2bc7456", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2868ecd56ed1f23a318640fed8f7ef1498acf227b6ae53a9c2a7838ca2bc7456", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2868ecd56ed1f23a318640fed8f7ef1498acf227b6ae53a9c2a7838ca2bc7456", kill_on_drop: false }` [INFO] [stdout] 2868ecd56ed1f23a318640fed8f7ef1498acf227b6ae53a9c2a7838ca2bc7456 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9ee76ff9a901cd94af72b33ef95967f8c232a1127cd89f06db9883f2ec56c2fd [INFO] running `Command { std: "docker" "start" "-a" "9ee76ff9a901cd94af72b33ef95967f8c232a1127cd89f06db9883f2ec56c2fd", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling sdl2 v0.35.2 [INFO] [stderr] Compiling sistema-solar v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking glam v0.24.2 [INFO] [stderr] Compiling sdl2-sys v0.35.2 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tobj v3.2.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stdout] warning: method `clear` is never used [INFO] [stdout] --> src/framebuffer.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 7 | impl ZBuffer { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 16 | pub fn clear(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/utils.rs:4:48 [INFO] [stdout] | [INFO] [stdout] 4 | let n = (x * 12.9898 + y * 78.233).sin() * 43758.5453; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 4 - let n = (x * 12.9898 + y * 78.233).sin() * 43758.5453; [INFO] [stdout] 4 + let n = (x * 12.9898 + y * 78.233).sin() * 43_758.547; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/shaders.rs:70:20 [INFO] [stdout] | [INFO] [stdout] 70 | if lat > 0.75 || lat < 0.25 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0.25..=0.75).contains(&lat)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `clear` is never used [INFO] [stdout] --> src/framebuffer.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 7 | impl ZBuffer { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 16 | pub fn clear(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/utils.rs:4:48 [INFO] [stdout] | [INFO] [stdout] 4 | let n = (x * 12.9898 + y * 78.233).sin() * 43758.5453; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 4 - let n = (x * 12.9898 + y * 78.233).sin() * 43758.5453; [INFO] [stdout] 4 + let n = (x * 12.9898 + y * 78.233).sin() * 43_758.547; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/shaders.rs:376:35 [INFO] [stdout] | [INFO] [stdout] 376 | let polar_factor = if lat < 0.15 || lat > 0.85 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0.15..=0.85).contains(&lat)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/shaders.rs:70:20 [INFO] [stdout] | [INFO] [stdout] 70 | if lat > 0.75 || lat < 0.25 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0.25..=0.75).contains(&lat)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/renderer.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn fill_triangle_zbuffer( [INFO] [stdout] 13 | | canvas: &mut sdl2::render::Canvas, [INFO] [stdout] 14 | | zbuffer: &mut ZBuffer, [INFO] [stdout] 15 | | mut p0: Point, mut p1: Point, mut p2: Point, [INFO] [stdout] 16 | | mut z0: f32, mut z1: f32, mut z2: f32, [INFO] [stdout] 17 | | color: Color [INFO] [stdout] 18 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/renderer.rs:96:1 [INFO] [stdout] | [INFO] [stdout] 96 | / pub fn render( [INFO] [stdout] 97 | | canvas: &mut sdl2::render::Canvas, [INFO] [stdout] 98 | | zbuffer: &mut ZBuffer, [INFO] [stdout] 99 | | model: &tobj::Model, [INFO] [stdout] ... | [INFO] [stdout] 107 | | time: f32, [INFO] [stdout] 108 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/renderer.rs:186:1 [INFO] [stdout] | [INFO] [stdout] 186 | / pub fn render_with_full_rotation( [INFO] [stdout] 187 | | canvas: &mut sdl2::render::Canvas, [INFO] [stdout] 188 | | zbuffer: &mut ZBuffer, [INFO] [stdout] 189 | | model: &tobj::Model, [INFO] [stdout] ... | [INFO] [stdout] 197 | | time: f32, [INFO] [stdout] 198 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/shaders.rs:376:35 [INFO] [stdout] | [INFO] [stdout] 376 | let polar_factor = if lat < 0.15 || lat > 0.85 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0.15..=0.85).contains(&lat)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:871:32 [INFO] [stdout] | [INFO] [stdout] 871 | ... if dy == 0 || dy == 3 || dy == 6 || [INFO] [stdout] | __________________________^ [INFO] [stdout] 872 | | ... (dx == 0 && (dy < 3 || dy == 6)) || (dx == 4 && (dy > 3 || dy == 0)) { [INFO] [stdout] | |_________________________________________________________^ help: try: `dy == 0 || dy == 3 || dy == 6 || dx == 0 && dy < 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/renderer.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn fill_triangle_zbuffer( [INFO] [stdout] 13 | | canvas: &mut sdl2::render::Canvas, [INFO] [stdout] 14 | | zbuffer: &mut ZBuffer, [INFO] [stdout] 15 | | mut p0: Point, mut p1: Point, mut p2: Point, [INFO] [stdout] 16 | | mut z0: f32, mut z1: f32, mut z2: f32, [INFO] [stdout] 17 | | color: Color [INFO] [stdout] 18 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/renderer.rs:96:1 [INFO] [stdout] | [INFO] [stdout] 96 | / pub fn render( [INFO] [stdout] 97 | | canvas: &mut sdl2::render::Canvas, [INFO] [stdout] 98 | | zbuffer: &mut ZBuffer, [INFO] [stdout] 99 | | model: &tobj::Model, [INFO] [stdout] ... | [INFO] [stdout] 107 | | time: f32, [INFO] [stdout] 108 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/renderer.rs:186:1 [INFO] [stdout] | [INFO] [stdout] 186 | / pub fn render_with_full_rotation( [INFO] [stdout] 187 | | canvas: &mut sdl2::render::Canvas, [INFO] [stdout] 188 | | zbuffer: &mut ZBuffer, [INFO] [stdout] 189 | | model: &tobj::Model, [INFO] [stdout] ... | [INFO] [stdout] 197 | | time: f32, [INFO] [stdout] 198 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | let _ = mouse_subsystem.set_relative_mouse_mode(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 185 - let _ = mouse_subsystem.set_relative_mouse_mode(true); [INFO] [stdout] 185 + mouse_subsystem.set_relative_mouse_mode(true); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:871:32 [INFO] [stdout] | [INFO] [stdout] 871 | ... if dy == 0 || dy == 3 || dy == 6 || [INFO] [stdout] | __________________________^ [INFO] [stdout] 872 | | ... (dx == 0 && (dy < 3 || dy == 6)) || (dx == 4 && (dy > 3 || dy == 0)) { [INFO] [stdout] | |_________________________________________________________^ help: try: `dy == 0 || dy == 3 || dy == 6 || dx == 0 && dy < 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:536:29 [INFO] [stdout] | [INFO] [stdout] 536 | ... let _ = canvas.set_draw_color(col); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 536 - let _ = canvas.set_draw_color(col); [INFO] [stdout] 536 + canvas.set_draw_color(col); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | let _ = mouse_subsystem.set_relative_mouse_mode(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 185 - let _ = mouse_subsystem.set_relative_mouse_mode(true); [INFO] [stdout] 185 + mouse_subsystem.set_relative_mouse_mode(true); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:536:29 [INFO] [stdout] | [INFO] [stdout] 536 | ... let _ = canvas.set_draw_color(col); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 536 - let _ = canvas.set_draw_color(col); [INFO] [stdout] 536 + canvas.set_draw_color(col); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.82s [INFO] running `Command { std: "docker" "inspect" "9ee76ff9a901cd94af72b33ef95967f8c232a1127cd89f06db9883f2ec56c2fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ee76ff9a901cd94af72b33ef95967f8c232a1127cd89f06db9883f2ec56c2fd", kill_on_drop: false }` [INFO] [stdout] 9ee76ff9a901cd94af72b33ef95967f8c232a1127cd89f06db9883f2ec56c2fd