[INFO] cloning repository https://github.com/JojiiOfficial/KanjiSRS [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JojiiOfficial/KanjiSRS" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJojiiOfficial%2FKanjiSRS", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJojiiOfficial%2FKanjiSRS'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a9339e0c74e3b3959c6dcc0a070693b90697a2cf [INFO] linting JojiiOfficial/KanjiSRS against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJojiiOfficial%2FKanjiSRS" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/JojiiOfficial/KanjiSRS [INFO] finished tweaking git repo https://github.com/JojiiOfficial/KanjiSRS [INFO] tweaked toml for git repo https://github.com/JojiiOfficial/KanjiSRS written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/JojiiOfficial/KanjiSRS on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/JojiiOfficial/KanjiSRS already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded term-table v1.3.2 [INFO] [stderr] Downloaded proc-lock-macro v0.4.0 [INFO] [stderr] Downloaded darling v0.13.2 [INFO] [stderr] Downloaded open v2.0.2 [INFO] [stderr] Downloaded darling_macro v0.13.2 [INFO] [stderr] Downloaded proc-lock v0.4.0 [INFO] [stderr] Downloaded darling_core v0.13.2 [INFO] [stderr] Downloaded proc-lock-api v0.4.0 [INFO] [stderr] Downloaded libc v0.2.114 [INFO] [stderr] Downloaded clap v3.0.12 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e532326b793551683d0d38f055b0a7cc952962b87dc959c5150b64060b503f69 [INFO] running `Command { std: "docker" "start" "-a" "e532326b793551683d0d38f055b0a7cc952962b87dc959c5150b64060b503f69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e532326b793551683d0d38f055b0a7cc952962b87dc959c5150b64060b503f69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e532326b793551683d0d38f055b0a7cc952962b87dc959c5150b64060b503f69", kill_on_drop: false }` [INFO] [stdout] e532326b793551683d0d38f055b0a7cc952962b87dc959c5150b64060b503f69 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0aa23be330081c7b1a2df04c8bd944c5fb9f5a97520c297a1b25d3b8ba99097f [INFO] running `Command { std: "docker" "start" "-a" "0aa23be330081c7b1a2df04c8bd944c5fb9f5a97520c297a1b25d3b8ba99097f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.114 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking term-table v1.3.2 [INFO] [stderr] Checking open v2.0.2 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking clap v3.0.12 [INFO] [stderr] Checking proc-lock-api v0.4.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Compiling darling_core v0.13.2 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling darling_macro v0.13.2 [INFO] [stderr] Compiling darling v0.13.2 [INFO] [stderr] Compiling proc-lock-macro v0.4.0 [INFO] [stderr] Checking proc-lock v0.4.0 [INFO] [stderr] Checking serde v1.0.136 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking kanji_srs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/japanese.rs:234:5 [INFO] [stdout] | [INFO] [stdout] 234 | / #[inline] [INFO] [stdout] 235 | | [INFO] [stdout] | |_^ [INFO] [stdout] 236 | fn is_small_katakana(&self) -> bool { [INFO] [stdout] | -------------------- the attribute applies to this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/japanese.rs:234:5 [INFO] [stdout] | [INFO] [stdout] 234 | / #[inline] [INFO] [stdout] 235 | | [INFO] [stdout] | |_^ [INFO] [stdout] 236 | fn is_small_katakana(&self) -> bool { [INFO] [stdout] | -------------------- the attribute applies to this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/cli/info.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | next.sort_by(|a, b| a.id.cmp(&b.id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 11 - next.sort_by(|a, b| a.id.cmp(&b.id)); [INFO] [stdout] 11 + next.sort_by_key(|a| a.id); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/cli/info.rs:42:21 [INFO] [stdout] | [INFO] [stdout] 42 | .filter(|i| i.due_on as u64 > tomorrow_time) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `i.due_on` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/cli/info.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | future.sort_by(|a, b| a.id.cmp(&b.id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 44 - future.sort_by(|a, b| a.id.cmp(&b.id)); [INFO] [stdout] 44 + future.sort_by_key(|a| a.id); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/cli/info.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | future.sort_by(|a, b| a.due_on.cmp(&b.due_on)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 45 - future.sort_by(|a, b| a.due_on.cmp(&b.due_on)); [INFO] [stdout] 45 + future.sort_by_key(|a| a.due_on); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/cli/info.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | srs_items.sort_by(|a, b| a.due_on.cmp(&b.due_on)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 101 - srs_items.sort_by(|a, b| a.due_on.cmp(&b.due_on)); [INFO] [stdout] 101 + srs_items.sort_by_key(|a| a.due_on); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> src/japanese.rs:226:9 [INFO] [stdout] | [INFO] [stdout] 226 | self.chars().into_iter().filter(|i| i.is_kanji()).count() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/sm2.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | //! successfully recalled in a row since the last time [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 10 | //! successfully recalled in a row since the last time [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/sm2.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | //! it was not. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 11 | //! it was not. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/sm2.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | //! the number of days to wait before doing a review again [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 14 | //! the number of days to wait before doing a review again [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/sm2.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | //! how quickly the inter-repetition interval grows [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 17 | //! how quickly the inter-repetition interval grows [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/cli/info.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | next.sort_by(|a, b| a.id.cmp(&b.id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 11 - next.sort_by(|a, b| a.id.cmp(&b.id)); [INFO] [stdout] 11 + next.sort_by_key(|a| a.id); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/cli/info.rs:42:21 [INFO] [stdout] | [INFO] [stdout] 42 | .filter(|i| i.due_on as u64 > tomorrow_time) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `i.due_on` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/cli/info.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | future.sort_by(|a, b| a.id.cmp(&b.id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 44 - future.sort_by(|a, b| a.id.cmp(&b.id)); [INFO] [stdout] 44 + future.sort_by_key(|a| a.id); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/cli/info.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | future.sort_by(|a, b| a.due_on.cmp(&b.due_on)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 45 - future.sort_by(|a, b| a.due_on.cmp(&b.due_on)); [INFO] [stdout] 45 + future.sort_by_key(|a| a.due_on); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/cli/info.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | srs_items.sort_by(|a, b| a.due_on.cmp(&b.due_on)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 101 - srs_items.sort_by(|a, b| a.due_on.cmp(&b.due_on)); [INFO] [stdout] 101 + srs_items.sort_by_key(|a| a.due_on); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sm2.rs:182:18 [INFO] [stdout] | [INFO] [stdout] 182 | 1 => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 182 - 1 => return 1, [INFO] [stdout] 182 + 1 => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sm2.rs:183:18 [INFO] [stdout] | [INFO] [stdout] 183 | 2 => return 6, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 183 - 2 => return 6, [INFO] [stdout] 183 + 2 => 6, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/storage/item.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | return Some(item_storage); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 - return Some(item_storage); [INFO] [stdout] 121 + Some(item_storage) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/storage/srs.rs:100:27 [INFO] [stdout] | [INFO] [stdout] 100 | let due = i.1.due_on as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `i.1.due_on` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/storage/srs.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | due.sort_by(|a, b| a.id.cmp(&b.id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 105 - due.sort_by(|a, b| a.id.cmp(&b.id)); [INFO] [stdout] 105 + due.sort_by_key(|a| a.id); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> src/japanese.rs:226:9 [INFO] [stdout] | [INFO] [stdout] 226 | self.chars().into_iter().filter(|i| i.is_kanji()).count() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `bool::then` in `filter_map` [INFO] [stdout] --> src/storage/srs.rs:114:14 [INFO] [stdout] | [INFO] [stdout] 114 | .filter_map(|i| (!i.1.in_learning).then(|| *i.0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `filter` then `map` instead: `filter(|&i| (!i.1.in_learning)).map(|i| *i.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_bool_then [INFO] [stdout] = note: `#[warn(clippy::filter_map_bool_then)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/storage/srs.rs:114:29 [INFO] [stdout] | [INFO] [stdout] 114 | .filter_map(|i| (!i.1.in_learning).then(|| *i.0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 114 - .filter_map(|i| (!i.1.in_learning).then(|| *i.0)) [INFO] [stdout] 114 + .filter_map(|i| (!i.1.in_learning).then_some(*i.0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/sm2.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | //! successfully recalled in a row since the last time [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 10 | //! successfully recalled in a row since the last time [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/sm2.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | //! it was not. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 11 | //! it was not. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/sm2.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | //! the number of days to wait before doing a review again [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 14 | //! the number of days to wait before doing a review again [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/sm2.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | //! how quickly the inter-repetition interval grows [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 17 | //! how quickly the inter-repetition interval grows [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/storage/srs.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | return Some(item_storage); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return Some(item_storage); [INFO] [stdout] 144 + Some(item_storage) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/storage/mod.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 127 | / let success = [INFO] [stdout] 128 | | self.item_storage.remove_item(item.id) && self.srs_storage.remove(item.id).is_some(); [INFO] [stdout] | |_________________________________________________________________________________________________- unnecessary `let` binding [INFO] [stdout] 129 | [INFO] [stdout] 130 | success [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 127 ~ [INFO] [stdout] 128 | [INFO] [stdout] 129 ~ self.item_storage.remove_item(item.id) && self.srs_storage.remove(item.id).is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/storage/mod.rs:180:25 [INFO] [stdout] | [INFO] [stdout] 180 | .any(|item| !self.srs_storage.find(item.id).is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.srs_storage.find(item.id).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/storage/mod.rs:190:22 [INFO] [stdout] | [INFO] [stdout] 190 | .any(|i| !self.item_storage.item_by_id(i.id).is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.item_storage.item_by_id(i.id).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sm2.rs:182:18 [INFO] [stdout] | [INFO] [stdout] 182 | 1 => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 182 - 1 => return 1, [INFO] [stdout] 182 + 1 => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sm2.rs:183:18 [INFO] [stdout] | [INFO] [stdout] 183 | 2 => return 6, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 183 - 2 => return 6, [INFO] [stdout] 183 + 2 => 6, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/storage/mod.rs:71:23 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn get_by_lit(&self, literal: char) -> Option { [INFO] [stdout] | ^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 71 | pub fn get_by_lit(&self, literal: char) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/storage/mod.rs:78:22 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn get_by_id(&self, id: u32) -> Option { [INFO] [stdout] | ^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 78 | pub fn get_by_id(&self, id: u32) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/storage/mod.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn iter(&self) -> impl Iterator { [INFO] [stdout] | ^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 104 | pub fn iter(&self) -> impl Iterator> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/storage/item.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | return Some(item_storage); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 - return Some(item_storage); [INFO] [stdout] 121 + Some(item_storage) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/storage/srs.rs:100:27 [INFO] [stdout] | [INFO] [stdout] 100 | let due = i.1.due_on as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `i.1.due_on` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/storage/srs.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | due.sort_by(|a, b| a.id.cmp(&b.id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 105 - due.sort_by(|a, b| a.id.cmp(&b.id)); [INFO] [stdout] 105 + due.sort_by_key(|a| a.id); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `bool::then` in `filter_map` [INFO] [stdout] --> src/storage/srs.rs:114:14 [INFO] [stdout] | [INFO] [stdout] 114 | .filter_map(|i| (!i.1.in_learning).then(|| *i.0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `filter` then `map` instead: `filter(|&i| (!i.1.in_learning)).map(|i| *i.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_bool_then [INFO] [stdout] = note: `#[warn(clippy::filter_map_bool_then)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/storage/srs.rs:114:29 [INFO] [stdout] | [INFO] [stdout] 114 | .filter_map(|i| (!i.1.in_learning).then(|| *i.0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 114 - .filter_map(|i| (!i.1.in_learning).then(|| *i.0)) [INFO] [stdout] 114 + .filter_map(|i| (!i.1.in_learning).then_some(*i.0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/storage/srs.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | return Some(item_storage); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return Some(item_storage); [INFO] [stdout] 144 + Some(item_storage) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/storage/mod.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 127 | / let success = [INFO] [stdout] 128 | | self.item_storage.remove_item(item.id) && self.srs_storage.remove(item.id).is_some(); [INFO] [stdout] | |_________________________________________________________________________________________________- unnecessary `let` binding [INFO] [stdout] 129 | [INFO] [stdout] 130 | success [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 127 ~ [INFO] [stdout] 128 | [INFO] [stdout] 129 ~ self.item_storage.remove_item(item.id) && self.srs_storage.remove(item.id).is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/storage/mod.rs:180:25 [INFO] [stdout] | [INFO] [stdout] 180 | .any(|item| !self.srs_storage.find(item.id).is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.srs_storage.find(item.id).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/storage/mod.rs:190:22 [INFO] [stdout] | [INFO] [stdout] 190 | .any(|i| !self.item_storage.item_by_id(i.id).is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.item_storage.item_by_id(i.id).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/storage/mod.rs:71:23 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn get_by_lit(&self, literal: char) -> Option { [INFO] [stdout] | ^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 71 | pub fn get_by_lit(&self, literal: char) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/storage/mod.rs:78:22 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn get_by_id(&self, id: u32) -> Option { [INFO] [stdout] | ^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 78 | pub fn get_by_id(&self, id: u32) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/storage/mod.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn iter(&self) -> impl Iterator { [INFO] [stdout] | ^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 104 | pub fn iter(&self) -> impl Iterator> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.64s [INFO] running `Command { std: "docker" "inspect" "0aa23be330081c7b1a2df04c8bd944c5fb9f5a97520c297a1b25d3b8ba99097f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0aa23be330081c7b1a2df04c8bd944c5fb9f5a97520c297a1b25d3b8ba99097f", kill_on_drop: false }` [INFO] [stdout] 0aa23be330081c7b1a2df04c8bd944c5fb9f5a97520c297a1b25d3b8ba99097f