[INFO] cloning repository https://github.com/Jip-Hoogendam/simple_compiler [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Jip-Hoogendam/simple_compiler" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJip-Hoogendam%2Fsimple_compiler", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJip-Hoogendam%2Fsimple_compiler'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dba599b82f4faf4a14424341e5f4275351850a6c [INFO] linting Jip-Hoogendam/simple_compiler against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJip-Hoogendam%2Fsimple_compiler" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Jip-Hoogendam/simple_compiler [INFO] finished tweaking git repo https://github.com/Jip-Hoogendam/simple_compiler [INFO] tweaked toml for git repo https://github.com/Jip-Hoogendam/simple_compiler written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Jip-Hoogendam/simple_compiler on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Jip-Hoogendam/simple_compiler already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 148d50d6e86b0fec8ed2cc22c70b834da24f9f12741bbf8d33557a8a2a1c33bf [INFO] running `Command { std: "docker" "start" "-a" "148d50d6e86b0fec8ed2cc22c70b834da24f9f12741bbf8d33557a8a2a1c33bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "148d50d6e86b0fec8ed2cc22c70b834da24f9f12741bbf8d33557a8a2a1c33bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "148d50d6e86b0fec8ed2cc22c70b834da24f9f12741bbf8d33557a8a2a1c33bf", kill_on_drop: false }` [INFO] [stdout] 148d50d6e86b0fec8ed2cc22c70b834da24f9f12741bbf8d33557a8a2a1c33bf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 95981ee1d251fdae1343d6d0b2c4fb76e8841cdfd9e94580cc470f03cd17f581 [INFO] running `Command { std: "docker" "start" "-a" "95981ee1d251fdae1343d6d0b2c4fb76e8841cdfd9e94580cc470f03cd17f581", kill_on_drop: false }` [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking UwU v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tokenizer.rs:34:15 [INFO] [stdout] | [INFO] [stdout] 34 | Token{type_: type_, value: None} [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `type_` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tokenizer.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 38 | Token{type_: type_, value: Some(value)} [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `type_` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parcer.rs:21:15 [INFO] [stdout] | [INFO] [stdout] 21 | Arena{size: size} [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/parcer.rs:133:1 [INFO] [stdout] | [INFO] [stdout] 133 | / #[deny(non_camel_case_types)] [INFO] [stdout] 134 | | [INFO] [stdout] | |_^ [INFO] [stdout] 135 | pub struct Parcer{ [INFO] [stdout] | ----------------- the attribute applies to this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokenizer::Token` [INFO] [stdout] --> src/generation.rs:1:42 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{parcer::node::{self, stmts}, tokenizer::Token, util::comp}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ops::Add` [INFO] [stdout] --> src/generation.rs:2:33 [INFO] [stdout] | [INFO] [stdout] 2 | use std::{collections::HashMap, ops::Add, process, str::FromStr}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `bin_expr` should have an upper camel case name [INFO] [stdout] --> src/generation.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | struct bin_expr{ [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper camel case: `BinExpr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/generation.rs:111:19 [INFO] [stdout] | [INFO] [stdout] 111 | ... Generator{root: root, index: 0, data: "".to_string(), data_vars: Vec::new(), text: "".to_string(), stack_size : 0, vars: Hash... [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `peek_ahead` is never used [INFO] [stdout] --> src/tokenizer.rs:169:8 [INFO] [stdout] | [INFO] [stdout] 47 | impl Tokenizer { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 169 | fn peek_ahead(&self, ahead: usize) -> Option{ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Arena` is never constructed [INFO] [stdout] --> src/parcer.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | struct Arena{ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/parcer.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl Arena { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 20 | pub fn new(size: usize) -> Arena{ [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `data_vars` is never read [INFO] [stdout] --> src/generation.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Generator{ [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | data_vars : Vec, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `peek_ahead` is never used [INFO] [stdout] --> src/generation.rs:184:8 [INFO] [stdout] | [INFO] [stdout] 24 | impl Generator { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 184 | fn peek_ahead(&self, ahead: usize) -> Option<&node::stmts>{ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokenizer.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | return tokens; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return tokens; [INFO] [stdout] 151 + tokens [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/tokenizer.rs:57:24 [INFO] [stdout] | [INFO] [stdout] 57 | let char = match self.pop(){ [INFO] [stdout] | ________________________^ [INFO] [stdout] 58 | | Some(value) => value, [INFO] [stdout] 59 | | _ => 0, [INFO] [stdout] 60 | | }; [INFO] [stdout] | |_____________^ help: replace it with: `self.pop().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/tokenizer.rs:122:25 [INFO] [stdout] | [INFO] [stdout] 122 | / let mut buffer = vec![]; [INFO] [stdout] 123 | | buffer.push(value); [INFO] [stdout] | |___________________________________________^ help: consider using the `vec![]` macro: `let buffer = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parcer.rs:193:16 [INFO] [stdout] | [INFO] [stdout] 193 | if !self.peek_ahead(1).is_some(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.peek_ahead(1).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parcer.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 217 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 217 - return None; [INFO] [stdout] 217 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/generation.rs:28:28 [INFO] [stdout] | [INFO] [stdout] 28 | self.text.push_str(®); [INFO] [stdout] | ^^^^ help: change this to: `reg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/generation.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | self.text.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.text.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/generation.rs:36:28 [INFO] [stdout] | [INFO] [stdout] 36 | self.text.push_str(®); [INFO] [stdout] | ^^^^ help: change this to: `reg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/generation.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | self.text.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.text.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/generation.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / let _ = match expr.var { [INFO] [stdout] 43 | | node::Expr_type::Int(value) => { [INFO] [stdout] 44 | | let value = value.int_lit.value.unwrap(); [INFO] [stdout] 45 | | self.text.push_str("\tmov rax, "); [INFO] [stdout] ... | [INFO] [stdout] 106 | | }; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 42 - let _ = match expr.var { [INFO] [stdout] 42 + match expr.var { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/generation.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 47 | self.text.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.text.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/generation.rs:72:36 [INFO] [stdout] | [INFO] [stdout] 72 | self.text.push_str(&value); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/generation.rs:73:17 [INFO] [stdout] | [INFO] [stdout] 73 | self.text.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.text.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/generation.rs:101:17 [INFO] [stdout] | [INFO] [stdout] 101 | self.text.push_str("\t"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.text.push('\t')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/generation.rs:102:36 [INFO] [stdout] | [INFO] [stdout] 102 | self.text.push_str(&bin_op); [INFO] [stdout] | ^^^^^^^ help: change this to: `bin_op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/generation.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | self.text.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.text.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/generation.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | return self.data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return self.data; [INFO] [stdout] 165 + self.data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/generation.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | self.data.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.data.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / if !fs::exists(build_directory).expect("could not determine if build directory exist") { [INFO] [stdout] 28 | | if fs::create_dir(build_directory).is_err(){ [INFO] [stdout] 29 | | fail_comp!("cant create build directory"); [INFO] [stdout] 30 | | } [INFO] [stdout] 31 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 27 ~ if !fs::exists(build_directory).expect("could not determine if build directory exist") [INFO] [stdout] 28 ~ && fs::create_dir(build_directory).is_err(){ [INFO] [stdout] 29 | fail_comp!("cant create build directory"); [INFO] [stdout] 30 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | / if !fs::exists(&assembly_directory).expect("could not determine if build directory exist"){ [INFO] [stdout] 36 | | if fs::create_dir(&assembly_directory).is_err() { [INFO] [stdout] 37 | | fail_comp!("cant create assembly direcrory"); [INFO] [stdout] 38 | | } [INFO] [stdout] 39 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 35 ~ if !fs::exists(&assembly_directory).expect("could not determine if build directory exist") [INFO] [stdout] 36 ~ && fs::create_dir(&assembly_directory).is_err() { [INFO] [stdout] 37 | fail_comp!("cant create assembly direcrory"); [INFO] [stdout] 38 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | / if !fs::exists(&object_directory).expect("could not determine if build directory exist"){ [INFO] [stdout] 60 | | if fs::create_dir(&object_directory).is_err() { [INFO] [stdout] 61 | | fail_comp!("cant create assembly direcrory"); [INFO] [stdout] 62 | | } [INFO] [stdout] 63 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 59 ~ if !fs::exists(&object_directory).expect("could not determine if build directory exist") [INFO] [stdout] 60 ~ && fs::create_dir(&object_directory).is_err() { [INFO] [stdout] 61 | fail_comp!("cant create assembly direcrory"); [INFO] [stdout] 62 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | let output_file_name; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `output_file_name` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 127 ~ [INFO] [stdout] 128 | [INFO] [stdout] 129 ~ let output_file_name = if args.len() >= 2 { [INFO] [stdout] 130 ~ "uwu" [INFO] [stdout] 131 | }else { [INFO] [stdout] 132 ~ &args[2] [INFO] [stdout] 133 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tokenizer.rs:34:15 [INFO] [stdout] | [INFO] [stdout] 34 | Token{type_: type_, value: None} [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `type_` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tokenizer.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 38 | Token{type_: type_, value: Some(value)} [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `type_` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parcer.rs:21:15 [INFO] [stdout] | [INFO] [stdout] 21 | Arena{size: size} [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/parcer.rs:133:1 [INFO] [stdout] | [INFO] [stdout] 133 | / #[deny(non_camel_case_types)] [INFO] [stdout] 134 | | [INFO] [stdout] | |_^ [INFO] [stdout] 135 | pub struct Parcer{ [INFO] [stdout] | ----------------- the attribute applies to this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokenizer::Token` [INFO] [stdout] --> src/generation.rs:1:42 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{parcer::node::{self, stmts}, tokenizer::Token, util::comp}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ops::Add` [INFO] [stdout] --> src/generation.rs:2:33 [INFO] [stdout] | [INFO] [stdout] 2 | use std::{collections::HashMap, ops::Add, process, str::FromStr}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `bin_expr` should have an upper camel case name [INFO] [stdout] --> src/generation.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | struct bin_expr{ [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper camel case: `BinExpr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/generation.rs:111:19 [INFO] [stdout] | [INFO] [stdout] 111 | ... Generator{root: root, index: 0, data: "".to_string(), data_vars: Vec::new(), text: "".to_string(), stack_size : 0, vars: Hash... [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `peek_ahead` is never used [INFO] [stdout] --> src/tokenizer.rs:169:8 [INFO] [stdout] | [INFO] [stdout] 47 | impl Tokenizer { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 169 | fn peek_ahead(&self, ahead: usize) -> Option{ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Arena` is never constructed [INFO] [stdout] --> src/parcer.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | struct Arena{ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/parcer.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl Arena { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 20 | pub fn new(size: usize) -> Arena{ [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `data_vars` is never read [INFO] [stdout] --> src/generation.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Generator{ [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | data_vars : Vec, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `peek_ahead` is never used [INFO] [stdout] --> src/generation.rs:184:8 [INFO] [stdout] | [INFO] [stdout] 24 | impl Generator { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 184 | fn peek_ahead(&self, ahead: usize) -> Option<&node::stmts>{ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokenizer.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | return tokens; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return tokens; [INFO] [stdout] 151 + tokens [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/tokenizer.rs:57:24 [INFO] [stdout] | [INFO] [stdout] 57 | let char = match self.pop(){ [INFO] [stdout] | ________________________^ [INFO] [stdout] 58 | | Some(value) => value, [INFO] [stdout] 59 | | _ => 0, [INFO] [stdout] 60 | | }; [INFO] [stdout] | |_____________^ help: replace it with: `self.pop().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/tokenizer.rs:122:25 [INFO] [stdout] | [INFO] [stdout] 122 | / let mut buffer = vec![]; [INFO] [stdout] 123 | | buffer.push(value); [INFO] [stdout] | |___________________________________________^ help: consider using the `vec![]` macro: `let buffer = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parcer.rs:193:16 [INFO] [stdout] | [INFO] [stdout] 193 | if !self.peek_ahead(1).is_some(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.peek_ahead(1).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parcer.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 217 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 217 - return None; [INFO] [stdout] 217 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/generation.rs:28:28 [INFO] [stdout] | [INFO] [stdout] 28 | self.text.push_str(®); [INFO] [stdout] | ^^^^ help: change this to: `reg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/generation.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | self.text.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.text.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/generation.rs:36:28 [INFO] [stdout] | [INFO] [stdout] 36 | self.text.push_str(®); [INFO] [stdout] | ^^^^ help: change this to: `reg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/generation.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | self.text.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.text.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/generation.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / let _ = match expr.var { [INFO] [stdout] 43 | | node::Expr_type::Int(value) => { [INFO] [stdout] 44 | | let value = value.int_lit.value.unwrap(); [INFO] [stdout] 45 | | self.text.push_str("\tmov rax, "); [INFO] [stdout] ... | [INFO] [stdout] 106 | | }; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 42 - let _ = match expr.var { [INFO] [stdout] 42 + match expr.var { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/generation.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 47 | self.text.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.text.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/generation.rs:72:36 [INFO] [stdout] | [INFO] [stdout] 72 | self.text.push_str(&value); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/generation.rs:73:17 [INFO] [stdout] | [INFO] [stdout] 73 | self.text.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.text.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/generation.rs:101:17 [INFO] [stdout] | [INFO] [stdout] 101 | self.text.push_str("\t"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.text.push('\t')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/generation.rs:102:36 [INFO] [stdout] | [INFO] [stdout] 102 | self.text.push_str(&bin_op); [INFO] [stdout] | ^^^^^^^ help: change this to: `bin_op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/generation.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | self.text.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.text.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/generation.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | return self.data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return self.data; [INFO] [stdout] 165 + self.data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/generation.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | self.data.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.data.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / if !fs::exists(build_directory).expect("could not determine if build directory exist") { [INFO] [stdout] 28 | | if fs::create_dir(build_directory).is_err(){ [INFO] [stdout] 29 | | fail_comp!("cant create build directory"); [INFO] [stdout] 30 | | } [INFO] [stdout] 31 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 27 ~ if !fs::exists(build_directory).expect("could not determine if build directory exist") [INFO] [stdout] 28 ~ && fs::create_dir(build_directory).is_err(){ [INFO] [stdout] 29 | fail_comp!("cant create build directory"); [INFO] [stdout] 30 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | / if !fs::exists(&assembly_directory).expect("could not determine if build directory exist"){ [INFO] [stdout] 36 | | if fs::create_dir(&assembly_directory).is_err() { [INFO] [stdout] 37 | | fail_comp!("cant create assembly direcrory"); [INFO] [stdout] 38 | | } [INFO] [stdout] 39 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 35 ~ if !fs::exists(&assembly_directory).expect("could not determine if build directory exist") [INFO] [stdout] 36 ~ && fs::create_dir(&assembly_directory).is_err() { [INFO] [stdout] 37 | fail_comp!("cant create assembly direcrory"); [INFO] [stdout] 38 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | / if !fs::exists(&object_directory).expect("could not determine if build directory exist"){ [INFO] [stdout] 60 | | if fs::create_dir(&object_directory).is_err() { [INFO] [stdout] 61 | | fail_comp!("cant create assembly direcrory"); [INFO] [stdout] 62 | | } [INFO] [stdout] 63 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 59 ~ if !fs::exists(&object_directory).expect("could not determine if build directory exist") [INFO] [stdout] 60 ~ && fs::create_dir(&object_directory).is_err() { [INFO] [stdout] 61 | fail_comp!("cant create assembly direcrory"); [INFO] [stdout] 62 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | let output_file_name; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `output_file_name` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 127 ~ [INFO] [stdout] 128 | [INFO] [stdout] 129 ~ let output_file_name = if args.len() >= 2 { [INFO] [stdout] 130 ~ "uwu" [INFO] [stdout] 131 | }else { [INFO] [stdout] 132 ~ &args[2] [INFO] [stdout] 133 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.88s [INFO] running `Command { std: "docker" "inspect" "95981ee1d251fdae1343d6d0b2c4fb76e8841cdfd9e94580cc470f03cd17f581", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95981ee1d251fdae1343d6d0b2c4fb76e8841cdfd9e94580cc470f03cd17f581", kill_on_drop: false }` [INFO] [stdout] 95981ee1d251fdae1343d6d0b2c4fb76e8841cdfd9e94580cc470f03cd17f581