[INFO] cloning repository https://github.com/JesterOrNot/RustAlgos [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JesterOrNot/RustAlgos" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJesterOrNot%2FRustAlgos", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJesterOrNot%2FRustAlgos'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 656f39dd7b3c4b6c776c7e16a647340e773b5b50 [INFO] linting JesterOrNot/RustAlgos against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJesterOrNot%2FRustAlgos" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/JesterOrNot/RustAlgos [INFO] finished tweaking git repo https://github.com/JesterOrNot/RustAlgos [INFO] tweaked toml for git repo https://github.com/JesterOrNot/RustAlgos written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/JesterOrNot/RustAlgos on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/JesterOrNot/RustAlgos already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 565bee68fa32b8b67a3bde00e90053e45d5a06f31677270ef7a066fc097ef190 [INFO] running `Command { std: "docker" "start" "-a" "565bee68fa32b8b67a3bde00e90053e45d5a06f31677270ef7a066fc097ef190", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "565bee68fa32b8b67a3bde00e90053e45d5a06f31677270ef7a066fc097ef190", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "565bee68fa32b8b67a3bde00e90053e45d5a06f31677270ef7a066fc097ef190", kill_on_drop: false }` [INFO] [stdout] 565bee68fa32b8b67a3bde00e90053e45d5a06f31677270ef7a066fc097ef190 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d3c7b909c489b9d9afbae68d46bb55fabf0eb8515c6f2cd5faf42a2bdbc26bf8 [INFO] running `Command { std: "docker" "start" "-a" "d3c7b909c489b9d9afbae68d46bb55fabf0eb8515c6f2cd5faf42a2bdbc26bf8", kill_on_drop: false }` [INFO] [stderr] Checking rust_algo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sorts.rs:15:19 [INFO] [stdout] | [INFO] [stdout] 15 | } else if !(mid - 1 > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(mid - 1 <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sorts.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return false; [INFO] [stdout] 21 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/test.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | assert_eq!(binary_search(&my_arr, 3), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6 - assert_eq!(binary_search(&my_arr, 3), true); [INFO] [stdout] 6 + assert!(binary_search(&my_arr, 3)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/test.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | assert_eq!(binary_search(&my_arr, 56), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 12 - assert_eq!(binary_search(&my_arr, 56), false); [INFO] [stdout] 12 + assert!(!binary_search(&my_arr, 56)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/test.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | assert_eq!(binary_search(&my_arr, -2), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 18 - assert_eq!(binary_search(&my_arr, -2), false) [INFO] [stdout] 18 + assert!(!binary_search(&my_arr, -2)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/test.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | assert_eq!(binary_search(&my_arr, -2000), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 24 - assert_eq!(binary_search(&my_arr, -2000), false) [INFO] [stdout] 24 + assert!(!binary_search(&my_arr, -2000)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/test.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | assert_eq!(binary_search(&my_arr, 2000000), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 30 - assert_eq!(binary_search(&my_arr, 2000000), false) [INFO] [stdout] 30 + assert!(!binary_search(&my_arr, 2000000)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/test.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | assert_eq!(binary_search(&my_arr, 220000000), true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 39 - assert_eq!(binary_search(&my_arr, 220000000), true) [INFO] [stdout] 39 + assert!(binary_search(&my_arr, 220000000)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sorts.rs:15:19 [INFO] [stdout] | [INFO] [stdout] 15 | } else if !(mid - 1 > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(mid - 1 <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sorts.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return false; [INFO] [stdout] 21 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> benches/bench.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | assert_eq!(binary_search(&my_arr, 3), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 12 - assert_eq!(binary_search(&my_arr, 3), true); [INFO] [stdout] 12 + assert!(binary_search(&my_arr, 3)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> benches/bench.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | assert_eq!(binary_search(&my_arr, 56), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 20 - assert_eq!(binary_search(&my_arr, 56), false); [INFO] [stdout] 20 + assert!(!binary_search(&my_arr, 56)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> benches/bench.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | assert_eq!(binary_search(&my_arr, -2), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 28 - assert_eq!(binary_search(&my_arr, -2), false) [INFO] [stdout] 28 + assert!(!binary_search(&my_arr, -2)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> benches/bench.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | assert_eq!(binary_search(&my_arr, -2000), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 36 - assert_eq!(binary_search(&my_arr, -2000), false) [INFO] [stdout] 36 + assert!(!binary_search(&my_arr, -2000)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> benches/bench.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | assert_eq!(binary_search(&my_arr, 2000000), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 44 - assert_eq!(binary_search(&my_arr, 2000000), false) [INFO] [stdout] 44 + assert!(!binary_search(&my_arr, 2000000)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> benches/bench.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | assert_eq!(binary_search(&my_arr, 220000000), true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 56 - assert_eq!(binary_search(&my_arr, 220000000), true) [INFO] [stdout] 56 + assert!(binary_search(&my_arr, 220000000)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.24s [INFO] running `Command { std: "docker" "inspect" "d3c7b909c489b9d9afbae68d46bb55fabf0eb8515c6f2cd5faf42a2bdbc26bf8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d3c7b909c489b9d9afbae68d46bb55fabf0eb8515c6f2cd5faf42a2bdbc26bf8", kill_on_drop: false }` [INFO] [stdout] d3c7b909c489b9d9afbae68d46bb55fabf0eb8515c6f2cd5faf42a2bdbc26bf8