[INFO] cloning repository https://github.com/JesperAxelsson/screen-ruler [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JesperAxelsson/screen-ruler" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJesperAxelsson%2Fscreen-ruler", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJesperAxelsson%2Fscreen-ruler'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c75aecb6c471e20f9e4d159d79e52f000df426d7 [INFO] linting JesperAxelsson/screen-ruler against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJesperAxelsson%2Fscreen-ruler" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/JesperAxelsson/screen-ruler [INFO] finished tweaking git repo https://github.com/JesperAxelsson/screen-ruler [INFO] tweaked toml for git repo https://github.com/JesperAxelsson/screen-ruler written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/JesperAxelsson/screen-ruler on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/JesperAxelsson/screen-ruler already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded edid-rs v0.1.0 [INFO] [stderr] Downloaded unicode-ident v1.0.5 [INFO] [stderr] Downloaded proc-macro2 v1.0.47 [INFO] [stderr] Downloaded cxxbridge-flags v1.0.81 [INFO] [stderr] Downloaded iana-time-zone-haiku v0.1.1 [INFO] [stderr] Downloaded scratch v1.0.2 [INFO] [stderr] Downloaded bumpalo v3.11.1 [INFO] [stderr] Downloaded termcolor v1.1.3 [INFO] [stderr] Downloaded anyhow v1.0.66 [INFO] [stderr] Downloaded cxxbridge-macro v1.0.81 [INFO] [stderr] Downloaded cc v1.0.76 [INFO] [stderr] Downloaded iana-time-zone v0.1.53 [INFO] [stderr] Downloaded once_cell v1.16.0 [INFO] [stderr] Downloaded quote v1.0.21 [INFO] [stderr] Downloaded link-cplusplus v1.0.7 [INFO] [stderr] Downloaded cxx v1.0.81 [INFO] [stderr] Downloaded chrono v0.4.22 [INFO] [stderr] Downloaded syn v1.0.103 [INFO] [stderr] Downloaded cxx-build v1.0.81 [INFO] [stderr] Downloaded libc v0.2.137 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 400a5c547d30bd87294238cfae2169713254f04c98c33a393de0a448c56102b7 [INFO] running `Command { std: "docker" "start" "-a" "400a5c547d30bd87294238cfae2169713254f04c98c33a393de0a448c56102b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "400a5c547d30bd87294238cfae2169713254f04c98c33a393de0a448c56102b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "400a5c547d30bd87294238cfae2169713254f04c98c33a393de0a448c56102b7", kill_on_drop: false }` [INFO] [stdout] 400a5c547d30bd87294238cfae2169713254f04c98c33a393de0a448c56102b7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3409dffc793f678650841cc30954a79bf2e2c53f24c10431f87113ec5390b3b4 [INFO] running `Command { std: "docker" "start" "-a" "3409dffc793f678650841cc30954a79bf2e2c53f24c10431f87113ec5390b3b4", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Compiling anyhow v1.0.66 [INFO] [stderr] Checking iana-time-zone v0.1.53 [INFO] [stderr] Checking edid-rs v0.1.0 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking chrono v0.4.22 [INFO] [stderr] Checking screen-ruler v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse_xrandr.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | / return Some(Screen { [INFO] [stdout] 29 | | number, [INFO] [stdout] 30 | | minimum, [INFO] [stdout] 31 | | current, [INFO] [stdout] 32 | | maximum, [INFO] [stdout] 33 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ Some(Screen { [INFO] [stdout] 29 + number, [INFO] [stdout] 30 + minimum, [INFO] [stdout] 31 + current, [INFO] [stdout] 32 + maximum, [INFO] [stdout] 33 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse_xrandr.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return Some((x, y)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return Some((x, y)); [INFO] [stdout] 44 + Some((x, y)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse_xrandr.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | / return Some(Port { [INFO] [stdout] 70 | | port, [INFO] [stdout] 71 | | connected, [INFO] [stdout] 72 | | primary: primary.is_some(), [INFO] [stdout] 73 | | resolution, [INFO] [stdout] 74 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 ~ Some(Port { [INFO] [stdout] 70 + port, [INFO] [stdout] 71 + connected, [INFO] [stdout] 72 + primary: primary.is_some(), [INFO] [stdout] 73 + resolution, [INFO] [stdout] 74 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse_xrandr.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return result; [INFO] [stdout] 89 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/parser.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | while let Some(c) = current_text.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for c in current_text.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/parser.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | while let Some(c) = current_text.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for c in current_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | return Some(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return Some(result); [INFO] [stdout] 92 + Some(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 88 | if result.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `result.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | return Some(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return Some(result); [INFO] [stdout] 106 + Some(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | return Some(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return Some(result); [INFO] [stdout] 120 + Some(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | return Some(token.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return Some(token.to_string()); [INFO] [stdout] 135 + Some(token.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | return min_res; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return min_res; [INFO] [stdout] 151 + min_res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | return Some(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 167 - return Some(result); [INFO] [stdout] 167 + Some(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 161 | if result.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `result.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/xrandr.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return String::from_utf8_lossy(&output.stdout).to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return String::from_utf8_lossy(&output.stdout).to_string(); [INFO] [stdout] 11 + String::from_utf8_lossy(&output.stdout).to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:70:38 [INFO] [stdout] | [INFO] [stdout] 70 | if port.connected && !port.resolution.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `port.resolution.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `port` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:44:16 [INFO] [stdout] | [INFO] [stdout] 43 | if port.is_some() && port.unwrap().port == "HDMI-0" && port.unwrap().connected { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 44 | if port.unwrap().resolution.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 39 | print_ports(&ports); [INFO] [stdout] | ^^^^^^ help: change this to: `ports` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:85:23 [INFO] [stdout] | [INFO] [stdout] 85 | fn print_ports(ports: &Vec) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 85 - fn print_ports(ports: &Vec) { [INFO] [stdout] 85 + fn print_ports(ports: &[Port]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/main.rs:87:56 [INFO] [stdout] | [INFO] [stdout] 87 | println!("Ports {}", dt.format("%Y-%m-%d %H:%M:%S").to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse_xrandr.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | / return Some(Screen { [INFO] [stdout] 29 | | number, [INFO] [stdout] 30 | | minimum, [INFO] [stdout] 31 | | current, [INFO] [stdout] 32 | | maximum, [INFO] [stdout] 33 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ Some(Screen { [INFO] [stdout] 29 + number, [INFO] [stdout] 30 + minimum, [INFO] [stdout] 31 + current, [INFO] [stdout] 32 + maximum, [INFO] [stdout] 33 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse_xrandr.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return Some((x, y)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return Some((x, y)); [INFO] [stdout] 44 + Some((x, y)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse_xrandr.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | / return Some(Port { [INFO] [stdout] 70 | | port, [INFO] [stdout] 71 | | connected, [INFO] [stdout] 72 | | primary: primary.is_some(), [INFO] [stdout] 73 | | resolution, [INFO] [stdout] 74 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 ~ Some(Port { [INFO] [stdout] 70 + port, [INFO] [stdout] 71 + connected, [INFO] [stdout] 72 + primary: primary.is_some(), [INFO] [stdout] 73 + resolution, [INFO] [stdout] 74 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse_xrandr.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return result; [INFO] [stdout] 89 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/parser.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | while let Some(c) = current_text.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for c in current_text.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/parser.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | while let Some(c) = current_text.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for c in current_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | return Some(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return Some(result); [INFO] [stdout] 92 + Some(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 88 | if result.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `result.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | return Some(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return Some(result); [INFO] [stdout] 106 + Some(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | return Some(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return Some(result); [INFO] [stdout] 120 + Some(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | return Some(token.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return Some(token.to_string()); [INFO] [stdout] 135 + Some(token.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | return min_res; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return min_res; [INFO] [stdout] 151 + min_res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | return Some(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 167 - return Some(result); [INFO] [stdout] 167 + Some(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 161 | if result.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `result.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/parser.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | assert_eq!(parser.eof(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 222 - assert_eq!(parser.eof(), true); [INFO] [stdout] 222 + assert!(parser.eof()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/parser.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | assert_eq!(parser.eof(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 229 - assert_eq!(parser.eof(), false); [INFO] [stdout] 229 + assert!(!parser.eof()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/xrandr.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return String::from_utf8_lossy(&output.stdout).to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return String::from_utf8_lossy(&output.stdout).to_string(); [INFO] [stdout] 11 + String::from_utf8_lossy(&output.stdout).to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:70:38 [INFO] [stdout] | [INFO] [stdout] 70 | if port.connected && !port.resolution.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `port.resolution.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `port` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:44:16 [INFO] [stdout] | [INFO] [stdout] 43 | if port.is_some() && port.unwrap().port == "HDMI-0" && port.unwrap().connected { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 44 | if port.unwrap().resolution.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 39 | print_ports(&ports); [INFO] [stdout] | ^^^^^^ help: change this to: `ports` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:85:23 [INFO] [stdout] | [INFO] [stdout] 85 | fn print_ports(ports: &Vec) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 85 - fn print_ports(ports: &Vec) { [INFO] [stdout] 85 + fn print_ports(ports: &[Port]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/main.rs:87:56 [INFO] [stdout] | [INFO] [stdout] 87 | println!("Ports {}", dt.format("%Y-%m-%d %H:%M:%S").to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.52s [INFO] running `Command { std: "docker" "inspect" "3409dffc793f678650841cc30954a79bf2e2c53f24c10431f87113ec5390b3b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3409dffc793f678650841cc30954a79bf2e2c53f24c10431f87113ec5390b3b4", kill_on_drop: false }` [INFO] [stdout] 3409dffc793f678650841cc30954a79bf2e2c53f24c10431f87113ec5390b3b4