[INFO] cloning repository https://github.com/Jens-Braun/pygs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Jens-Braun/pygs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJens-Braun%2Fpygs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJens-Braun%2Fpygs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b5c08d6582d03b34d1d1943a4d7f315969435f71 [INFO] linting Jens-Braun/pygs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJens-Braun%2Fpygs" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Jens-Braun/pygs [INFO] finished tweaking git repo https://github.com/Jens-Braun/pygs [INFO] tweaked toml for git repo https://github.com/Jens-Braun/pygs written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Jens-Braun/pygs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Jens-Braun/pygs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pyo3-macros v0.24.2 [INFO] [stderr] Downloaded pyo3-build-config v0.24.2 [INFO] [stderr] Downloaded pyo3-macros-backend v0.24.2 [INFO] [stderr] Downloaded peg-macros v0.8.5 [INFO] [stderr] Downloaded peg v0.8.5 [INFO] [stderr] Downloaded pyo3-log v0.12.4 [INFO] [stderr] Downloaded pyo3-ffi v0.24.2 [INFO] [stderr] Downloaded peg-runtime v0.8.5 [INFO] [stderr] Downloaded pyo3 v0.24.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8ea83eab091c08d12c9a9071c7f9104176c5bb0fb5c52720afc3b7cc666fe645 [INFO] running `Command { std: "docker" "start" "-a" "8ea83eab091c08d12c9a9071c7f9104176c5bb0fb5c52720afc3b7cc666fe645", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8ea83eab091c08d12c9a9071c7f9104176c5bb0fb5c52720afc3b7cc666fe645", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ea83eab091c08d12c9a9071c7f9104176c5bb0fb5c52720afc3b7cc666fe645", kill_on_drop: false }` [INFO] [stdout] 8ea83eab091c08d12c9a9071c7f9104176c5bb0fb5c52720afc3b7cc666fe645 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 960b75c4bc6d0c77c8fa16de38284089bf49f365aa33dfee861814037129f953 [INFO] running `Command { std: "docker" "start" "-a" "960b75c4bc6d0c77c8fa16de38284089bf49f365aa33dfee861814037129f953", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.13.2 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Checking cfg-if v1.0.1 [INFO] [stderr] Checking unindent v0.2.4 [INFO] [stderr] Compiling peg-runtime v0.8.5 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking self_cell v1.2.0 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking libloading v0.8.8 [INFO] [stderr] Compiling peg-macros v0.8.5 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Compiling pyo3-build-config v0.24.2 [INFO] [stderr] Checking peg v0.8.5 [INFO] [stderr] Compiling pyo3-ffi v0.24.2 [INFO] [stderr] Compiling pyo3-macros-backend v0.24.2 [INFO] [stderr] Compiling pyo3 v0.24.2 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Checking thiserror v2.0.12 [INFO] [stderr] Compiling pyo3-macros v0.24.2 [INFO] [stderr] Checking pyo3-log v0.12.4 [INFO] [stderr] Checking pygs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `AmplitudeType` [INFO] [stdout] --> src/blha/order_writer.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | use super::{AmplitudeType, Order}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AmplitudeType` [INFO] [stdout] --> src/blha/order_writer.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | use super::{AmplitudeType, Order}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `model::Particle` is more private than the item `model::Model::particles` [INFO] [stdout] --> src/model.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) particles: HashMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `model::Model::particles` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `model::Particle` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/model.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | struct Particle { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `nlo_coupling` is never read [INFO] [stdout] --> src/blha/mod.rs:69:16 [INFO] [stdout] | [INFO] [stdout] 66 | pub(crate) struct Order<'a> { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 69 | pub(crate) nlo_coupling: Option, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `info` is never read [INFO] [stdout] --> src/blha/mod.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 74 | struct BLHAInterface<'a> { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 75 | start: Symbol<'a, unsafe extern "C" fn(*const c_char, *mut i32)>, [INFO] [stdout] 76 | info: Symbol<'a, unsafe extern "C" fn(*const c_char, *const c_char, *mut c_char)>, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `pdg_id` and `name` are never read [INFO] [stdout] --> src/model.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 58 | struct Particle { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 59 | pdg_id: i64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 60 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Particle` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/blha/error.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / pub(crate) enum BLHAError { [INFO] [stdout] 5 | | #[error("Error while accessing {0}: {1}")] [INFO] [stdout] 6 | | IOError(String, #[source] std::io::Error), [INFO] [stdout] 7 | | #[error("OLP returned from function {0} with error code {1}")] [INFO] [stdout] ... | [INFO] [stdout] 14 | | LibraryError(#[from] libloading::Error), [INFO] [stdout] 15 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/blha/parser.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 38 | fn to_string(self) -> String { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `blha::parser::Value<'a>` [INFO] [stdout] --> src/blha/parser.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / fn to_string(self) -> String { [INFO] [stdout] 39 | | match self { [INFO] [stdout] 40 | | Self::Int(i) => i.to_string(), [INFO] [stdout] 41 | | Self::Float(x) => x.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `blha::parser::Value<'a>` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/blha/parser.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | / return match blha_contract::contract(&content) { [INFO] [stdout] 158 | | Ok(c) => c, [INFO] [stdout] 159 | | Err(e) => Err(BLHAError::ParseError( [INFO] [stdout] 160 | | path.file_name().unwrap().to_str().unwrap().to_owned(), [INFO] [stdout] 161 | | e, [INFO] [stdout] 162 | | )), [INFO] [stdout] 163 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 ~ match blha_contract::contract(&content) { [INFO] [stdout] 158 + Ok(c) => c, [INFO] [stdout] 159 + Err(e) => Err(BLHAError::ParseError( [INFO] [stdout] 160 + path.file_name().unwrap().to_str().unwrap().to_owned(), [INFO] [stdout] 161 + e, [INFO] [stdout] 162 + )), [INFO] [stdout] 163 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/blha/mod.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | return Ok(olp); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return Ok(olp); [INFO] [stdout] 126 + Ok(olp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/blha/mod.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 - return Ok(()); [INFO] [stdout] 138 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/blha/mod.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - return Ok(()); [INFO] [stdout] 159 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/blha/mod.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | return Ok(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 209 - return Ok(res); [INFO] [stdout] 209 + Ok(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/gosam.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / enum GoSamError { [INFO] [stdout] 20 | | #[error("Error while generating the process library: {0}")] [INFO] [stdout] 21 | | GenError(String), [INFO] [stdout] 22 | | #[error("Process has to be initialized before {0} is available")] [INFO] [stdout] ... | [INFO] [stdout] 27 | | BLHAError(#[from] BLHAError), [INFO] [stdout] 28 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `model::Particle` is more private than the item `model::Model::particles` [INFO] [stdout] --> src/model.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) particles: HashMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `model::Model::particles` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `model::Particle` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/model.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | struct Particle { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `nlo_coupling` is never read [INFO] [stdout] --> src/blha/mod.rs:69:16 [INFO] [stdout] | [INFO] [stdout] 66 | pub(crate) struct Order<'a> { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 69 | pub(crate) nlo_coupling: Option, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `info` is never read [INFO] [stdout] --> src/blha/mod.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 74 | struct BLHAInterface<'a> { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 75 | start: Symbol<'a, unsafe extern "C" fn(*const c_char, *mut i32)>, [INFO] [stdout] 76 | info: Symbol<'a, unsafe extern "C" fn(*const c_char, *const c_char, *mut c_char)>, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `pdg_id` and `name` are never read [INFO] [stdout] --> src/model.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 58 | struct Particle { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 59 | pdg_id: i64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 60 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Particle` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/blha/error.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / pub(crate) enum BLHAError { [INFO] [stdout] 5 | | #[error("Error while accessing {0}: {1}")] [INFO] [stdout] 6 | | IOError(String, #[source] std::io::Error), [INFO] [stdout] 7 | | #[error("OLP returned from function {0} with error code {1}")] [INFO] [stdout] ... | [INFO] [stdout] 14 | | LibraryError(#[from] libloading::Error), [INFO] [stdout] 15 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/gosam.rs:138:52 [INFO] [stdout] | [INFO] [stdout] 138 | let mut config = std::fs::File::create(&std::env::current_dir()?.join("gosam.in"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `std::env::current_dir()?.join("gosam.in")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/gosam.rs:150:12 [INFO] [stdout] | [INFO] [stdout] 150 | if !(res.status.code() == Some(0)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(res.status.code() != Some(0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/gosam.rs:183:28 [INFO] [stdout] | [INFO] [stdout] 183 | if std::fs::exists(&process_path.join("build/libgolem_olp.so"))? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `process_path.join("build/libgolem_olp.so")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/blha/parser.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 38 | fn to_string(self) -> String { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `blha::parser::Value<'a>` [INFO] [stdout] --> src/blha/parser.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / fn to_string(self) -> String { [INFO] [stdout] 39 | | match self { [INFO] [stdout] 40 | | Self::Int(i) => i.to_string(), [INFO] [stdout] 41 | | Self::Float(x) => x.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `blha::parser::Value<'a>` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:268:13 [INFO] [stdout] | [INFO] [stdout] 268 | return Ok(olp.set_parameter(¶meter, real, imag)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 268 - return Ok(olp.set_parameter(¶meter, real, imag)?); [INFO] [stdout] 268 + Ok(olp.set_parameter(¶meter, real, imag)?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:270:13 [INFO] [stdout] | [INFO] [stdout] 270 | return Err(GoSamError::UnintializedError("set_parameter".to_owned()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 - return Err(GoSamError::UnintializedError("set_parameter".to_owned()))?; [INFO] [stdout] 270 + Err(GoSamError::UnintializedError("set_parameter".to_owned()))? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:276:13 [INFO] [stdout] | [INFO] [stdout] 276 | return Ok(olp.print_parameters(&filename)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 276 - return Ok(olp.print_parameters(&filename)); [INFO] [stdout] 276 + Ok(olp.print_parameters(&filename)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:278:13 [INFO] [stdout] | [INFO] [stdout] 278 | return Err(GoSamError::UnintializedError("print_parameters".to_owned()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 278 - return Err(GoSamError::UnintializedError("print_parameters".to_owned()))?; [INFO] [stdout] 278 + Err(GoSamError::UnintializedError("print_parameters".to_owned()))? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gosam.rs:276:20 [INFO] [stdout] | [INFO] [stdout] 276 | return Ok(olp.print_parameters(&filename)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 276 ~ return { [INFO] [stdout] 277 + let _: () = olp.print_parameters(&filename); [INFO] [stdout] 278 + Ok(()) [INFO] [stdout] 279 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:290:13 [INFO] [stdout] | [INFO] [stdout] 290 | return Ok(py.allow_threads(|| -> Result<_, _> { olp.eval(id, &vecs, scale) })?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 290 - return Ok(py.allow_threads(|| -> Result<_, _> { olp.eval(id, &vecs, scale) })?); [INFO] [stdout] 290 + Ok(py.allow_threads(|| -> Result<_, _> { olp.eval(id, &vecs, scale) })?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:292:13 [INFO] [stdout] | [INFO] [stdout] 292 | return Err(GoSamError::UnintializedError("eval".to_owned()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 292 - return Err(GoSamError::UnintializedError("eval".to_owned()))?; [INFO] [stdout] 292 + Err(GoSamError::UnintializedError("eval".to_owned()))? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:327:9 [INFO] [stdout] | [INFO] [stdout] 327 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 327 - return result; [INFO] [stdout] 327 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:325:13 [INFO] [stdout] | [INFO] [stdout] 325 | return Ok((vecs, vals)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 325 - return Ok((vecs, vals)); [INFO] [stdout] 325 + Ok((vecs, vals)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/gosam.rs:338:10 [INFO] [stdout] | [INFO] [stdout] 338 | ) -> PyResult, Vec)>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:388:9 [INFO] [stdout] | [INFO] [stdout] 388 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 388 - return result; [INFO] [stdout] 388 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:383:13 [INFO] [stdout] | [INFO] [stdout] 383 | return Ok(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 383 - return Ok(result); [INFO] [stdout] 383 + Ok(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gosam.rs:377:17 [INFO] [stdout] | [INFO] [stdout] 377 | / if i % n_update == 0 { [INFO] [stdout] 378 | | if let Some(f) = update { [INFO] [stdout] 379 | | f(n_update)?; [INFO] [stdout] 380 | | } [INFO] [stdout] 381 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 377 ~ if i % n_update == 0 [INFO] [stdout] 378 ~ && let Some(f) = update { [INFO] [stdout] 379 | f(n_update)?; [INFO] [stdout] 380 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/blha/parser.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | / return match blha_contract::contract(&content) { [INFO] [stdout] 158 | | Ok(c) => c, [INFO] [stdout] 159 | | Err(e) => Err(BLHAError::ParseError( [INFO] [stdout] 160 | | path.file_name().unwrap().to_str().unwrap().to_owned(), [INFO] [stdout] 161 | | e, [INFO] [stdout] 162 | | )), [INFO] [stdout] 163 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 ~ match blha_contract::contract(&content) { [INFO] [stdout] 158 + Ok(c) => c, [INFO] [stdout] 159 + Err(e) => Err(BLHAError::ParseError( [INFO] [stdout] 160 + path.file_name().unwrap().to_str().unwrap().to_owned(), [INFO] [stdout] 161 + e, [INFO] [stdout] 162 + )), [INFO] [stdout] 163 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/blha/parser.rs:201:55 [INFO] [stdout] | [INFO] [stdout] 201 | let contract = super::blha_contract::contract(&content).unwrap().unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/model.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | return self.particles.get(&id).unwrap().mass; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return self.particles.get(&id).unwrap().mass; [INFO] [stdout] 14 + self.particles.get(&id).unwrap().mass [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/model.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return format!("{self:#?}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return format!("{self:#?}"); [INFO] [stdout] 49 + format!("{self:#?}") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/model.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return format!("{self:?}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return format!("{self:?}"); [INFO] [stdout] 53 + format!("{self:?}") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/blha/mod.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | return Ok(olp); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return Ok(olp); [INFO] [stdout] 126 + Ok(olp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rambo.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return (s, vecs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return (s, vecs); [INFO] [stdout] 96 + (s, vecs) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/blha/mod.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 - return Ok(()); [INFO] [stdout] 138 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/blha/mod.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - return Ok(()); [INFO] [stdout] 159 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `q` [INFO] [stdout] --> src/rambo.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 71 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 71 - for i in 0..n { [INFO] [stdout] 71 + for (i, ) in q.iter().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/blha/mod.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | return Ok(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 209 - return Ok(res); [INFO] [stdout] 209 + Ok(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/gosam.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / enum GoSamError { [INFO] [stdout] 20 | | #[error("Error while generating the process library: {0}")] [INFO] [stdout] 21 | | GenError(String), [INFO] [stdout] 22 | | #[error("Process has to be initialized before {0} is available")] [INFO] [stdout] ... | [INFO] [stdout] 27 | | BLHAError(#[from] BLHAError), [INFO] [stdout] 28 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rambo.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | return x; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return x; [INFO] [stdout] 123 + x [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | return self.f64(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return self.f64(); [INFO] [stdout] 13 + self.f64() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | return min + self.f64() * (max - min); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return min + self.f64() * (max - min); [INFO] [stdout] 18 + min + self.f64() * (max - min) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/gosam.rs:138:52 [INFO] [stdout] | [INFO] [stdout] 138 | let mut config = std::fs::File::create(&std::env::current_dir()?.join("gosam.in"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `std::env::current_dir()?.join("gosam.in")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/gosam.rs:150:12 [INFO] [stdout] | [INFO] [stdout] 150 | if !(res.status.code() == Some(0)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(res.status.code() != Some(0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/gosam.rs:183:28 [INFO] [stdout] | [INFO] [stdout] 183 | if std::fs::exists(&process_path.join("build/libgolem_olp.so"))? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `process_path.join("build/libgolem_olp.so")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:268:13 [INFO] [stdout] | [INFO] [stdout] 268 | return Ok(olp.set_parameter(¶meter, real, imag)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 268 - return Ok(olp.set_parameter(¶meter, real, imag)?); [INFO] [stdout] 268 + Ok(olp.set_parameter(¶meter, real, imag)?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:270:13 [INFO] [stdout] | [INFO] [stdout] 270 | return Err(GoSamError::UnintializedError("set_parameter".to_owned()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 - return Err(GoSamError::UnintializedError("set_parameter".to_owned()))?; [INFO] [stdout] 270 + Err(GoSamError::UnintializedError("set_parameter".to_owned()))? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:276:13 [INFO] [stdout] | [INFO] [stdout] 276 | return Ok(olp.print_parameters(&filename)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 276 - return Ok(olp.print_parameters(&filename)); [INFO] [stdout] 276 + Ok(olp.print_parameters(&filename)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:278:13 [INFO] [stdout] | [INFO] [stdout] 278 | return Err(GoSamError::UnintializedError("print_parameters".to_owned()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 278 - return Err(GoSamError::UnintializedError("print_parameters".to_owned()))?; [INFO] [stdout] 278 + Err(GoSamError::UnintializedError("print_parameters".to_owned()))? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gosam.rs:276:20 [INFO] [stdout] | [INFO] [stdout] 276 | return Ok(olp.print_parameters(&filename)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 276 ~ return { [INFO] [stdout] 277 + let _: () = olp.print_parameters(&filename); [INFO] [stdout] 278 + Ok(()) [INFO] [stdout] 279 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:290:13 [INFO] [stdout] | [INFO] [stdout] 290 | return Ok(py.allow_threads(|| -> Result<_, _> { olp.eval(id, &vecs, scale) })?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 290 - return Ok(py.allow_threads(|| -> Result<_, _> { olp.eval(id, &vecs, scale) })?); [INFO] [stdout] 290 + Ok(py.allow_threads(|| -> Result<_, _> { olp.eval(id, &vecs, scale) })?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:292:13 [INFO] [stdout] | [INFO] [stdout] 292 | return Err(GoSamError::UnintializedError("eval".to_owned()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 292 - return Err(GoSamError::UnintializedError("eval".to_owned()))?; [INFO] [stdout] 292 + Err(GoSamError::UnintializedError("eval".to_owned()))? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:327:9 [INFO] [stdout] | [INFO] [stdout] 327 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 327 - return result; [INFO] [stdout] 327 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:325:13 [INFO] [stdout] | [INFO] [stdout] 325 | return Ok((vecs, vals)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 325 - return Ok((vecs, vals)); [INFO] [stdout] 325 + Ok((vecs, vals)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/gosam.rs:338:10 [INFO] [stdout] | [INFO] [stdout] 338 | ) -> PyResult, Vec)>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:388:9 [INFO] [stdout] | [INFO] [stdout] 388 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 388 - return result; [INFO] [stdout] 388 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gosam.rs:383:13 [INFO] [stdout] | [INFO] [stdout] 383 | return Ok(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 383 - return Ok(result); [INFO] [stdout] 383 + Ok(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gosam.rs:377:17 [INFO] [stdout] | [INFO] [stdout] 377 | / if i % n_update == 0 { [INFO] [stdout] 378 | | if let Some(f) = update { [INFO] [stdout] 379 | | f(n_update)?; [INFO] [stdout] 380 | | } [INFO] [stdout] 381 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 377 ~ if i % n_update == 0 [INFO] [stdout] 378 ~ && let Some(f) = update { [INFO] [stdout] 379 | f(n_update)?; [INFO] [stdout] 380 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/model.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | return self.particles.get(&id).unwrap().mass; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return self.particles.get(&id).unwrap().mass; [INFO] [stdout] 14 + self.particles.get(&id).unwrap().mass [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/model.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return format!("{self:#?}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return format!("{self:#?}"); [INFO] [stdout] 49 + format!("{self:#?}") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/model.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return format!("{self:?}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return format!("{self:?}"); [INFO] [stdout] 53 + format!("{self:?}") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rambo.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return (s, vecs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return (s, vecs); [INFO] [stdout] 96 + (s, vecs) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `q` [INFO] [stdout] --> src/rambo.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 71 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 71 - for i in 0..n { [INFO] [stdout] 71 + for (i, ) in q.iter().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.62s [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rambo.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | return x; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return x; [INFO] [stdout] 123 + x [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | return self.f64(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return self.f64(); [INFO] [stdout] 13 + self.f64() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | return min + self.f64() * (max - min); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return min + self.f64() * (max - min); [INFO] [stdout] 18 + min + self.f64() * (max - min) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "960b75c4bc6d0c77c8fa16de38284089bf49f365aa33dfee861814037129f953", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "960b75c4bc6d0c77c8fa16de38284089bf49f365aa33dfee861814037129f953", kill_on_drop: false }` [INFO] [stdout] 960b75c4bc6d0c77c8fa16de38284089bf49f365aa33dfee861814037129f953