[INFO] cloning repository https://github.com/JenkinsJB/roids [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JenkinsJB/roids" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJenkinsJB%2Froids", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJenkinsJB%2Froids'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c82cd963f722f3d4c00aeb12b076498514b4e65b [INFO] linting JenkinsJB/roids against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJenkinsJB%2Froids" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/JenkinsJB/roids [INFO] finished tweaking git repo https://github.com/JenkinsJB/roids [INFO] tweaked toml for git repo https://github.com/JenkinsJB/roids written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/JenkinsJB/roids on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/JenkinsJB/roids already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded gif v0.14.0 [INFO] [stderr] Downloaded zune-jpeg v0.5.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1f78cc8f7ab4e151ad8c8db4b8f5a0611894156d4df9f4ee444fd4226e158d3b [INFO] running `Command { std: "docker" "start" "-a" "1f78cc8f7ab4e151ad8c8db4b8f5a0611894156d4df9f4ee444fd4226e158d3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1f78cc8f7ab4e151ad8c8db4b8f5a0611894156d4df9f4ee444fd4226e158d3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f78cc8f7ab4e151ad8c8db4b8f5a0611894156d4df9f4ee444fd4226e158d3b", kill_on_drop: false }` [INFO] [stdout] 1f78cc8f7ab4e151ad8c8db4b8f5a0611894156d4df9f4ee444fd4226e158d3b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5d4c576c40501383c9cdf35e1e0590d7516b5e112ea0323ec2b524a6c8242c45 [INFO] running `Command { std: "docker" "start" "-a" "5d4c576c40501383c9cdf35e1e0590d7516b5e112ea0323ec2b524a6c8242c45", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.110 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Compiling zerocopy v0.8.27 [INFO] [stderr] Compiling wayland-sys v0.31.7 [INFO] [stderr] Compiling cc v1.2.46 [INFO] [stderr] Compiling quick-xml v0.37.5 [INFO] [stderr] Compiling wayland-client v0.31.11 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling regex-syntax v0.8.8 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Compiling xml-rs v0.8.28 [INFO] [stderr] Compiling toml_parser v1.0.4 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking async-broadcast v0.5.1 [INFO] [stderr] Compiling toml_datetime v0.7.3 [INFO] [stderr] Compiling smithay-client-toolkit v0.18.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking accesskit v0.12.3 [INFO] [stderr] Compiling winit v0.29.15 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Compiling toml_edit v0.23.7 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking aligned v0.4.2 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking endi v1.1.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.20.0 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking accesskit_consumer v0.16.1 [INFO] [stderr] Compiling glutin v0.31.3 [INFO] [stderr] Checking async-lock v3.4.1 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking polling v2.8.0 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking rustix v0.37.28 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling glutin_egl_sys v0.6.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling glutin_glx_sys v0.5.0 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking async-once-cell v0.5.4 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking async-fs v2.2.0 [INFO] [stderr] Compiling glutin-winit v0.4.2 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking pxfm v0.1.25 [INFO] [stderr] Checking zune-jpeg v0.5.5 [INFO] [stderr] Checking gif v0.14.0 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking web-time v0.2.4 [INFO] [stderr] Compiling rfd v0.14.1 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking jiff v0.2.16 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking async-io v1.13.0 [INFO] [stderr] Checking async-io v2.6.0 [INFO] [stderr] Checking async-net v2.0.0 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zvariant_utils v2.1.0 [INFO] [stderr] Compiling zerocopy-derive v0.8.27 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling zvariant_utils v1.0.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling regex v1.12.2 [INFO] [stderr] Checking wayland-protocols v0.31.2 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Checking emath v0.28.1 [INFO] [stderr] Checking calloop v0.14.3 [INFO] [stderr] Checking ecolor v0.28.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking calloop v0.12.4 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Compiling zvariant_derive v3.15.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling zbus_macros v3.15.2 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking calloop-wayland-source v0.2.0 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Compiling zvariant_derive v4.2.0 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking calloop-wayland-source v0.4.1 [INFO] [stderr] Checking v_frame v0.3.9 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking av1-grain v0.2.5 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Compiling fax_derive v0.2.0 [INFO] [stderr] Checking av-scenechange v0.14.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking epaint v0.28.1 [INFO] [stderr] Compiling zbus_macros v4.4.0 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking fax v0.2.6 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.2.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking wayland-protocols-plasma v0.2.0 [INFO] [stderr] Checking tiff v0.10.3 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking moxcms v0.7.9 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking rav1e v0.8.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Checking egui v0.28.1 [INFO] [stderr] Checking env_filter v0.1.4 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking zvariant v3.15.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking zvariant v4.2.0 [INFO] [stderr] Checking webbrowser v1.0.6 [INFO] [stderr] Checking sctk-adwaita v0.8.3 [INFO] [stderr] Checking zbus_names v2.6.1 [INFO] [stderr] Checking wayland-protocols-misc v0.3.9 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking zbus v3.15.2 [INFO] [stderr] Checking egui_glow v0.28.1 [INFO] [stderr] Checking zbus_names v3.0.0 [INFO] [stderr] Checking zbus v4.4.0 [INFO] [stderr] Checking smithay-clipboard v0.7.3 [INFO] [stderr] Checking ravif v0.12.0 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking atspi-common v0.3.0 [INFO] [stderr] Checking ashpd v0.8.1 [INFO] [stderr] Checking atspi-proxies v0.3.0 [INFO] [stderr] Checking atspi-connection v0.3.0 [INFO] [stderr] Checking atspi v0.19.0 [INFO] [stderr] Checking accesskit_unix v0.6.2 [INFO] [stderr] Checking accesskit_winit v0.16.1 [INFO] [stderr] Checking egui-winit v0.28.1 [INFO] [stderr] Checking eframe v0.28.1 [INFO] [stderr] Checking roids v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `clear` is never used [INFO] [stdout] --> src/app.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 27 | impl History { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 78 | fn clear(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `distance` is never used [INFO] [stdout] --> src/models/annotation.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 38 | impl Point { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 53 | pub fn distance(&self, other: &Point) -> f64 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `remove_vertex` and `find_nearest_vertex` are never used [INFO] [stdout] --> src/models/annotation.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 103 | impl Annotation { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 120 | pub fn remove_vertex(&mut self, index: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 131 | pub fn find_nearest_vertex(&self, point: &Point) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `normalize_coordinates` is never used [INFO] [stdout] --> src/util/geometry.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn normalize_coordinates(pixel_x: f64, pixel_y: f64, width: u32, height: u32) -> Point { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `denormalize_coordinates` is never used [INFO] [stdout] --> src/util/geometry.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn denormalize_coordinates(point: &Point, width: u32, height: u32) -> (f64, f64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:561:13 [INFO] [stdout] | [INFO] [stdout] 561 | / if ctx.input(|i| i.modifiers.command && i.key_pressed(egui::Key::Z) && !i.modifiers.shift) { [INFO] [stdout] 562 | | if self.history.can_undo() { [INFO] [stdout] 563 | | if let Some(ref mut project) = self.project { [INFO] [stdout] 564 | | let current = project.annotations.clone(); [INFO] [stdout] ... | [INFO] [stdout] 572 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 561 ~ if ctx.input(|i| i.modifiers.command && i.key_pressed(egui::Key::Z) && !i.modifiers.shift) [INFO] [stdout] 562 ~ && self.history.can_undo() { [INFO] [stdout] 563 | if let Some(ref mut project) = self.project { [INFO] [stdout] ... [INFO] [stdout] 570 | } [INFO] [stdout] 571 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:575:13 [INFO] [stdout] | [INFO] [stdout] 575 | / if ctx.input(|i| { [INFO] [stdout] 576 | | (i.modifiers.command && i.modifiers.shift && i.key_pressed(egui::Key::Z)) || [INFO] [stdout] 577 | | (i.modifiers.command && i.key_pressed(egui::Key::Y)) [INFO] [stdout] 578 | | }) { [INFO] [stdout] ... | [INFO] [stdout] 589 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 578 ~ }) [INFO] [stdout] 579 ~ && self.history.can_redo() { [INFO] [stdout] 580 | if let Some(ref mut project) = self.project { [INFO] [stdout] ... [INFO] [stdout] 587 | } [INFO] [stdout] 588 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/ui/canvas.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | / pub fn show( [INFO] [stdout] 26 | | ui: &mut egui::Ui, [INFO] [stdout] 27 | | project: &Option, [INFO] [stdout] 28 | | current_tool: Tool, [INFO] [stdout] ... | [INFO] [stdout] 33 | | dragging_vertex: Option<(usize, usize)>, [INFO] [stdout] 34 | | ) -> CanvasAction { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/ui/canvas.rs:113:48 [INFO] [stdout] | [INFO] [stdout] 113 | ... if let Some(_) = annotation.find_vertex_within_threshold(&click_point, 0.02) { [INFO] [stdout] | -------^^^^^^^-------------------------------------------------------------- help: try: `if annotation.find_vertex_within_threshold(&click_point, 0.02).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `clear` is never used [INFO] [stdout] --> src/app.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 27 | impl History { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 78 | fn clear(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:561:13 [INFO] [stdout] | [INFO] [stdout] 561 | / if ctx.input(|i| i.modifiers.command && i.key_pressed(egui::Key::Z) && !i.modifiers.shift) { [INFO] [stdout] 562 | | if self.history.can_undo() { [INFO] [stdout] 563 | | if let Some(ref mut project) = self.project { [INFO] [stdout] 564 | | let current = project.annotations.clone(); [INFO] [stdout] ... | [INFO] [stdout] 572 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 561 ~ if ctx.input(|i| i.modifiers.command && i.key_pressed(egui::Key::Z) && !i.modifiers.shift) [INFO] [stdout] 562 ~ && self.history.can_undo() { [INFO] [stdout] 563 | if let Some(ref mut project) = self.project { [INFO] [stdout] ... [INFO] [stdout] 570 | } [INFO] [stdout] 571 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:575:13 [INFO] [stdout] | [INFO] [stdout] 575 | / if ctx.input(|i| { [INFO] [stdout] 576 | | (i.modifiers.command && i.modifiers.shift && i.key_pressed(egui::Key::Z)) || [INFO] [stdout] 577 | | (i.modifiers.command && i.key_pressed(egui::Key::Y)) [INFO] [stdout] 578 | | }) { [INFO] [stdout] ... | [INFO] [stdout] 589 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 578 ~ }) [INFO] [stdout] 579 ~ && self.history.can_redo() { [INFO] [stdout] 580 | if let Some(ref mut project) = self.project { [INFO] [stdout] ... [INFO] [stdout] 587 | } [INFO] [stdout] 588 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/ui/canvas.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | / pub fn show( [INFO] [stdout] 26 | | ui: &mut egui::Ui, [INFO] [stdout] 27 | | project: &Option, [INFO] [stdout] 28 | | current_tool: Tool, [INFO] [stdout] ... | [INFO] [stdout] 33 | | dragging_vertex: Option<(usize, usize)>, [INFO] [stdout] 34 | | ) -> CanvasAction { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/ui/canvas.rs:113:48 [INFO] [stdout] | [INFO] [stdout] 113 | ... if let Some(_) = annotation.find_vertex_within_threshold(&click_point, 0.02) { [INFO] [stdout] | -------^^^^^^^-------------------------------------------------------------- help: try: `if annotation.find_vertex_within_threshold(&click_point, 0.02).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 26s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: ashpd v0.8.1 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 5` [INFO] running `Command { std: "docker" "inspect" "5d4c576c40501383c9cdf35e1e0590d7516b5e112ea0323ec2b524a6c8242c45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5d4c576c40501383c9cdf35e1e0590d7516b5e112ea0323ec2b524a6c8242c45", kill_on_drop: false }` [INFO] [stdout] 5d4c576c40501383c9cdf35e1e0590d7516b5e112ea0323ec2b524a6c8242c45