[INFO] cloning repository https://github.com/JaydonXOneGitHub/SunflowerECS-Rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JaydonXOneGitHub/SunflowerECS-Rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJaydonXOneGitHub%2FSunflowerECS-Rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJaydonXOneGitHub%2FSunflowerECS-Rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e1769161f2cebbbe89cbc178ccb976aa73d9b07b [INFO] linting JaydonXOneGitHub/SunflowerECS-Rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJaydonXOneGitHub%2FSunflowerECS-Rust" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/JaydonXOneGitHub/SunflowerECS-Rust [INFO] finished tweaking git repo https://github.com/JaydonXOneGitHub/SunflowerECS-Rust [INFO] tweaked toml for git repo https://github.com/JaydonXOneGitHub/SunflowerECS-Rust written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/JaydonXOneGitHub/SunflowerECS-Rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/JaydonXOneGitHub/SunflowerECS-Rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded boxmut v1.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2c1052f7cd9de30de5811b3bd79efaead443cfc36756b0af1505d61f9ac2be4c [INFO] running `Command { std: "docker" "start" "-a" "2c1052f7cd9de30de5811b3bd79efaead443cfc36756b0af1505d61f9ac2be4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2c1052f7cd9de30de5811b3bd79efaead443cfc36756b0af1505d61f9ac2be4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c1052f7cd9de30de5811b3bd79efaead443cfc36756b0af1505d61f9ac2be4c", kill_on_drop: false }` [INFO] [stdout] 2c1052f7cd9de30de5811b3bd79efaead443cfc36756b0af1505d61f9ac2be4c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a786ee2a7e53fd058dcbc662413136afe88fe87c207ff1716096ee9600b1292e [INFO] running `Command { std: "docker" "start" "-a" "a786ee2a7e53fd058dcbc662413136afe88fe87c207ff1716096ee9600b1292e", kill_on_drop: false }` [INFO] [stderr] Checking boxmut v1.0.0 [INFO] [stderr] Checking sunflowerecs v2.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/scene.rs:35:17 [INFO] [stdout] | [INFO] [stdout] 35 | id: id, [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/scene.rs:35:17 [INFO] [stdout] | [INFO] [stdout] 35 | id: id, [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/behavioursystem.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | components: BoxMut>>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BehaviourSystem` [INFO] [stdout] --> src/behavioursystem.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> Self { [INFO] [stdout] 16 | | return Self { [INFO] [stdout] 17 | | components: BoxMut::new(Vec::new()), [INFO] [stdout] 18 | | }; [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for BehaviourSystem { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/behavioursystem.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | components: BoxMut>>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/behavioursystem.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | / return Self { [INFO] [stdout] 17 | | components: BoxMut::new(Vec::new()), [INFO] [stdout] 18 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 ~ Self { [INFO] [stdout] 17 + components: BoxMut::new(Vec::new()), [INFO] [stdout] 18 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/behavioursystem.rs:21:43 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn reserve(&mut self, size: usize) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BehaviourSystem` [INFO] [stdout] --> src/behavioursystem.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> Self { [INFO] [stdout] 16 | | return Self { [INFO] [stdout] 17 | | components: BoxMut::new(Vec::new()), [INFO] [stdout] 18 | | }; [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for BehaviourSystem { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/behavioursystem.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | / return Self { [INFO] [stdout] 17 | | components: BoxMut::new(Vec::new()), [INFO] [stdout] 18 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 ~ Self { [INFO] [stdout] 17 + components: BoxMut::new(Vec::new()), [INFO] [stdout] 18 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/behavioursystem.rs:21:43 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn reserve(&mut self, size: usize) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/behavioursystem.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return Option::Some(self); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return Option::Some(self); [INFO] [stdout] 33 + Option::Some(self) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/behavioursystem.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return Option::Some(self); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return Option::Some(self); [INFO] [stdout] 33 + Option::Some(self) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/behavioursystem.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return Option::Some(self); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Option::Some(self); [INFO] [stdout] 40 + Option::Some(self) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/behavioursystem.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return Option::Some(self); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Option::Some(self); [INFO] [stdout] 40 + Option::Some(self) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/behavioursystem.rs:43:88 [INFO] [stdout] | [INFO] [stdout] 43 | fn on_component_added_to_entity(&self, component: &Rc>>) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/behavioursystem.rs:43:88 [INFO] [stdout] | [INFO] [stdout] 43 | fn on_component_added_to_entity(&self, component: &Rc>>) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/behavioursystem.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | / if let Option::Some(borrowed) = component.get_mut() { [INFO] [stdout] 45 | | if let Option::Some(_) = borrowed.as_behaviour() { [INFO] [stdout] 46 | | if let Option::Some(components) = self.components.get_mut() { [INFO] [stdout] 47 | | components.push(component.clone()); [INFO] [stdout] ... | [INFO] [stdout] 50 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 44 ~ if let Option::Some(borrowed) = component.get_mut() [INFO] [stdout] 45 ~ && let Option::Some(_) = borrowed.as_behaviour() { [INFO] [stdout] 46 | if let Option::Some(components) = self.components.get_mut() { [INFO] [stdout] 47 | components.push(component.clone()); [INFO] [stdout] 48 | } [INFO] [stdout] 49 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/behavioursystem.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | / if let Option::Some(borrowed) = component.get_mut() { [INFO] [stdout] 45 | | if let Option::Some(_) = borrowed.as_behaviour() { [INFO] [stdout] 46 | | if let Option::Some(components) = self.components.get_mut() { [INFO] [stdout] 47 | | components.push(component.clone()); [INFO] [stdout] ... | [INFO] [stdout] 50 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 44 ~ if let Option::Some(borrowed) = component.get_mut() [INFO] [stdout] 45 ~ && let Option::Some(_) = borrowed.as_behaviour() { [INFO] [stdout] 46 | if let Option::Some(components) = self.components.get_mut() { [INFO] [stdout] 47 | components.push(component.clone()); [INFO] [stdout] 48 | } [INFO] [stdout] 49 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/behavioursystem.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 45 | if let Option::Some(_) = borrowed.as_behaviour() { [INFO] [stdout] | -------^^^^^^^^^^^^^^^-------------------------- help: try: `if borrowed.as_behaviour().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/behavioursystem.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | / if let Option::Some(_) = borrowed.as_behaviour() { [INFO] [stdout] 46 | | if let Option::Some(components) = self.components.get_mut() { [INFO] [stdout] 47 | | components.push(component.clone()); [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 45 ~ if let Option::Some(_) = borrowed.as_behaviour() [INFO] [stdout] 46 ~ && let Option::Some(components) = self.components.get_mut() { [INFO] [stdout] 47 | components.push(component.clone()); [INFO] [stdout] 48 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/behavioursystem.rs:53:92 [INFO] [stdout] | [INFO] [stdout] 53 | fn on_component_removed_from_entity(&self, component: &Rc>>) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/behavioursystem.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 45 | if let Option::Some(_) = borrowed.as_behaviour() { [INFO] [stdout] | -------^^^^^^^^^^^^^^^-------------------------- help: try: `if borrowed.as_behaviour().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/behavioursystem.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 56 | return !Rc::ptr_eq(c, &component); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return !Rc::ptr_eq(c, &component); [INFO] [stdout] 56 + !Rc::ptr_eq(c, &component) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/behavioursystem.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | / if let Option::Some(_) = borrowed.as_behaviour() { [INFO] [stdout] 46 | | if let Option::Some(components) = self.components.get_mut() { [INFO] [stdout] 47 | | components.push(component.clone()); [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 45 ~ if let Option::Some(_) = borrowed.as_behaviour() [INFO] [stdout] 46 ~ && let Option::Some(components) = self.components.get_mut() { [INFO] [stdout] 47 | components.push(component.clone()); [INFO] [stdout] 48 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/behavioursystem.rs:53:92 [INFO] [stdout] | [INFO] [stdout] 53 | fn on_component_removed_from_entity(&self, component: &Rc>>) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/behavioursystem.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 56 | return !Rc::ptr_eq(c, &component); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return !Rc::ptr_eq(c, &component); [INFO] [stdout] 56 + !Rc::ptr_eq(c, &component) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/behavioursystem.rs:56:39 [INFO] [stdout] | [INFO] [stdout] 56 | return !Rc::ptr_eq(c, &component); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `component` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/behavioursystem.rs:56:39 [INFO] [stdout] | [INFO] [stdout] 56 | return !Rc::ptr_eq(c, &component); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `component` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/behavioursystem.rs:63:19 [INFO] [stdout] | [INFO] [stdout] 63 | fn draw(&self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/behavioursystem.rs:63:19 [INFO] [stdout] | [INFO] [stdout] 63 | fn draw(&self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/behavioursystem.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 66 | / if let Option::Some(comp) = c.get_mut() { [INFO] [stdout] 67 | | if let Option::Some(bc) = comp.as_behaviour() { [INFO] [stdout] 68 | | bc.draw(); [INFO] [stdout] 69 | | } [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 66 ~ if let Option::Some(comp) = c.get_mut() [INFO] [stdout] 67 ~ && let Option::Some(bc) = comp.as_behaviour() { [INFO] [stdout] 68 | bc.draw(); [INFO] [stdout] 69 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/behavioursystem.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 66 | / if let Option::Some(comp) = c.get_mut() { [INFO] [stdout] 67 | | if let Option::Some(bc) = comp.as_behaviour() { [INFO] [stdout] 68 | | bc.draw(); [INFO] [stdout] 69 | | } [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 66 ~ if let Option::Some(comp) = c.get_mut() [INFO] [stdout] 67 ~ && let Option::Some(bc) = comp.as_behaviour() { [INFO] [stdout] 68 | bc.draw(); [INFO] [stdout] 69 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/behavioursystem.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 77 | fn update(&self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/behavioursystem.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 77 | fn update(&self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/behavioursystem.rs:80:17 [INFO] [stdout] | [INFO] [stdout] 80 | / if let Option::Some(comp) = c.get_mut() { [INFO] [stdout] 81 | | if let Option::Some(bc) = comp.as_behaviour() { [INFO] [stdout] 82 | | bc.update(); [INFO] [stdout] 83 | | } [INFO] [stdout] 84 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 80 ~ if let Option::Some(comp) = c.get_mut() [INFO] [stdout] 81 ~ && let Option::Some(bc) = comp.as_behaviour() { [INFO] [stdout] 82 | bc.update(); [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/behavioursystem.rs:80:17 [INFO] [stdout] | [INFO] [stdout] 80 | / if let Option::Some(comp) = c.get_mut() { [INFO] [stdout] 81 | | if let Option::Some(bc) = comp.as_behaviour() { [INFO] [stdout] 82 | | bc.update(); [INFO] [stdout] 83 | | } [INFO] [stdout] 84 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 80 ~ if let Option::Some(comp) = c.get_mut() [INFO] [stdout] 81 ~ && let Option::Some(bc) = comp.as_behaviour() { [INFO] [stdout] 82 | bc.update(); [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ComponentCollection` [INFO] [stdout] --> src/componentcollection.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | return Self { [INFO] [stdout] 14 | | components: Vec::new(), [INFO] [stdout] 15 | | entity: std::ptr::null_mut(), [INFO] [stdout] 16 | | }; [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for ComponentCollection { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/componentcollection.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | / return Self { [INFO] [stdout] 14 | | components: Vec::new(), [INFO] [stdout] 15 | | entity: std::ptr::null_mut(), [INFO] [stdout] 16 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 ~ Self { [INFO] [stdout] 14 + components: Vec::new(), [INFO] [stdout] 15 + entity: std::ptr::null_mut(), [INFO] [stdout] 16 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/componentcollection.rs:20:40 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn add(&mut self, component: T) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/componentcollection.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return self.components.pop(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return self.components.pop(); [INFO] [stdout] 25 + self.components.pop() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ComponentCollection` [INFO] [stdout] --> src/componentcollection.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | return Self { [INFO] [stdout] 14 | | components: Vec::new(), [INFO] [stdout] 15 | | entity: std::ptr::null_mut(), [INFO] [stdout] 16 | | }; [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for ComponentCollection { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/componentcollection.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | / return Self { [INFO] [stdout] 14 | | components: Vec::new(), [INFO] [stdout] 15 | | entity: std::ptr::null_mut(), [INFO] [stdout] 16 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 ~ Self { [INFO] [stdout] 14 + components: Vec::new(), [INFO] [stdout] 15 + entity: std::ptr::null_mut(), [INFO] [stdout] 16 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/componentcollection.rs:20:40 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn add(&mut self, component: T) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/componentcollection.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return self.components.pop(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return self.components.pop(); [INFO] [stdout] 25 + self.components.pop() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/componentcollection.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return self.components.get(index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return self.components.get(index); [INFO] [stdout] 29 + self.components.get(index) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/componentcollection.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return self.components.get(index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return self.components.get(index); [INFO] [stdout] 29 + self.components.get(index) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/componentcollection.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return self.components.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self.components.len(); [INFO] [stdout] 33 + self.components.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/componentcollection.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / if let Result::Ok(mut uncelled) = c.try_borrow_mut() { [INFO] [stdout] 42 | | if let Option::Some(bc) = uncelled.as_behaviour() { [INFO] [stdout] 43 | | callback(bc); [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 41 ~ if let Result::Ok(mut uncelled) = c.try_borrow_mut() [INFO] [stdout] 42 ~ && let Option::Some(bc) = uncelled.as_behaviour() { [INFO] [stdout] 43 | callback(bc); [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/componentcollection.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return self.components.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self.components.len(); [INFO] [stdout] 33 + self.components.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/componentcollection.rs:53:25 [INFO] [stdout] | [INFO] [stdout] 53 | fn update(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/componentcollection.rs:59:23 [INFO] [stdout] | [INFO] [stdout] 59 | fn draw(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/componentcollection.rs:65:50 [INFO] [stdout] | [INFO] [stdout] 65 | fn set_entity(&mut self, entity: *mut Entity) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/componentcollection.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / if let Result::Ok(mut uncelled) = c.try_borrow_mut() { [INFO] [stdout] 42 | | if let Option::Some(bc) = uncelled.as_behaviour() { [INFO] [stdout] 43 | | callback(bc); [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 41 ~ if let Result::Ok(mut uncelled) = c.try_borrow_mut() [INFO] [stdout] 42 ~ && let Option::Some(bc) = uncelled.as_behaviour() { [INFO] [stdout] 43 | callback(bc); [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/componentcollection.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | return unsafe { self.entity.as_mut() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return unsafe { self.entity.as_mut() }; [INFO] [stdout] 70 + unsafe { self.entity.as_mut() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/entity.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | return self.id; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return self.id; [INFO] [stdout] 18 + self.id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/entity.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | return self.scene.is_some() || self.entity_data.is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return self.scene.is_some() || self.entity_data.is_some(); [INFO] [stdout] 22 + self.scene.is_some() || self.entity_data.is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/entity.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | / return match &self.scene { [INFO] [stdout] 27 | | Option::Some(weak) => weak.upgrade(), [INFO] [stdout] 28 | | Option::None => Option::None, [INFO] [stdout] 29 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 ~ match &self.scene { [INFO] [stdout] 27 + Option::Some(weak) => weak.upgrade(), [INFO] [stdout] 28 + Option::None => Option::None, [INFO] [stdout] 29 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/entity.rs:32:30 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn destroy(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/entity.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | / if let Option::Some(scene_rc) = self.get_scene() { [INFO] [stdout] 34 | | if let Option::Some(scene) = scene_rc.get_mut() { [INFO] [stdout] 35 | | scene.destroy_entity(self); [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 33 ~ if let Option::Some(scene_rc) = self.get_scene() [INFO] [stdout] 34 ~ && let Option::Some(scene) = scene_rc.get_mut() { [INFO] [stdout] 35 | scene.destroy_entity(self); [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/entity.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | return Option::None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return Option::None; [INFO] [stdout] 76 + Option::None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/entity.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / if let Option::Some(scene_rc) = self.get_scene() { [INFO] [stdout] 48 | | if let Option::Some(scene) = scene_rc.get_ref() { [INFO] [stdout] 49 | | let type_id: &'static str = type_name::(); [INFO] [stdout] ... | [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 47 ~ if let Option::Some(scene_rc) = self.get_scene() [INFO] [stdout] 48 ~ && let Option::Some(scene) = scene_rc.get_ref() { [INFO] [stdout] 49 | let type_id: &'static str = type_name::(); [INFO] [stdout] ... [INFO] [stdout] 72 | } [INFO] [stdout] 73 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/entity.rs:62:25 [INFO] [stdout] | [INFO] [stdout] 62 | / if let Option::Some(borrowed) = dyncomponentrc.get_mut() { [INFO] [stdout] 63 | | if let Option::Some(bc) = borrowed.as_behaviour() { [INFO] [stdout] 64 | | bc.set_entity(e_ptr); [INFO] [stdout] 65 | | } [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 62 ~ if let Option::Some(borrowed) = dyncomponentrc.get_mut() [INFO] [stdout] 63 ~ && let Option::Some(bc) = borrowed.as_behaviour() { [INFO] [stdout] 64 | bc.set_entity(e_ptr); [INFO] [stdout] 65 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/componentcollection.rs:53:25 [INFO] [stdout] | [INFO] [stdout] 53 | fn update(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/entity.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | return Option::None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return Option::None; [INFO] [stdout] 104 + Option::None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/componentcollection.rs:59:23 [INFO] [stdout] | [INFO] [stdout] 59 | fn draw(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/entity.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | / if let Option::Some(scene_rc) = self.get_scene() { [INFO] [stdout] 85 | | if let Option::Some(scene) = scene_rc.get_mut() { [INFO] [stdout] 86 | | let type_id: &'static str = type_name::(); [INFO] [stdout] ... | [INFO] [stdout] 102 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 84 ~ if let Option::Some(scene_rc) = self.get_scene() [INFO] [stdout] 85 ~ && let Option::Some(scene) = scene_rc.get_mut() { [INFO] [stdout] 86 | let type_id: &'static str = type_name::(); [INFO] [stdout] ... [INFO] [stdout] 100 | } [INFO] [stdout] 101 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/componentcollection.rs:65:50 [INFO] [stdout] | [INFO] [stdout] 65 | fn set_entity(&mut self, entity: *mut Entity) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/componentcollection.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | return unsafe { self.entity.as_mut() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return unsafe { self.entity.as_mut() }; [INFO] [stdout] 70 + unsafe { self.entity.as_mut() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/entity.rs:88:17 [INFO] [stdout] | [INFO] [stdout] 88 | / if let Option::Some(data) = self.entity_data.as_mut() { [INFO] [stdout] 89 | | if let Option::Some(component) = data.components.remove(type_id) { [INFO] [stdout] 90 | | if let Option::Some(borrowed) = component.get_mut() { [INFO] [stdout] 91 | | if let Option::Some(bc) = borrowed.as_behaviour() { [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 88 ~ if let Option::Some(data) = self.entity_data.as_mut() [INFO] [stdout] 89 ~ && let Option::Some(component) = data.components.remove(type_id) { [INFO] [stdout] 90 | if let Option::Some(borrowed) = component.get_mut() { [INFO] [stdout] ... [INFO] [stdout] 98 | return Option::Some(()); [INFO] [stdout] 99 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/entity.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | / if let Option::Some(borrowed) = component.get_mut() { [INFO] [stdout] 91 | | if let Option::Some(bc) = borrowed.as_behaviour() { [INFO] [stdout] 92 | | bc.set_entity(std::ptr::null_mut()); [INFO] [stdout] 93 | | } [INFO] [stdout] 94 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 90 ~ if let Option::Some(borrowed) = component.get_mut() [INFO] [stdout] 91 ~ && let Option::Some(bc) = borrowed.as_behaviour() { [INFO] [stdout] 92 | bc.set_entity(std::ptr::null_mut()); [INFO] [stdout] 93 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/entity.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | return self.id; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return self.id; [INFO] [stdout] 18 + self.id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/entity.rs:107:35 [INFO] [stdout] | [INFO] [stdout] 107 | pub(crate) fn reset(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/entity.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | return self.scene.is_some() || self.entity_data.is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return self.scene.is_some() || self.entity_data.is_some(); [INFO] [stdout] 22 + self.scene.is_some() || self.entity_data.is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/entity.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | / return match &self.scene { [INFO] [stdout] 27 | | Option::Some(weak) => weak.upgrade(), [INFO] [stdout] 28 | | Option::None => Option::None, [INFO] [stdout] 29 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 ~ match &self.scene { [INFO] [stdout] 27 + Option::Some(weak) => weak.upgrade(), [INFO] [stdout] 28 + Option::None => Option::None, [INFO] [stdout] 29 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/entity.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | / return if let Option::Some(data) = self.entity_data.as_mut() { [INFO] [stdout] 120 | | if let Option::Some(rc) = data.components.get(type_id) { [INFO] [stdout] 121 | | if let Option::Some(borrow) = rc.get_mut() { [INFO] [stdout] 122 | | let any_ref: &mut dyn std::any::Any = borrow.as_mut() as &mut dyn std::any::Any; [INFO] [stdout] ... | [INFO] [stdout] 136 | | Result::Err("Can't get data!".into()) [INFO] [stdout] 137 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 119 ~ if let Option::Some(data) = self.entity_data.as_mut() { [INFO] [stdout] 120 + if let Option::Some(rc) = data.components.get(type_id) { [INFO] [stdout] 121 + if let Option::Some(borrow) = rc.get_mut() { [INFO] [stdout] 122 + let any_ref: &mut dyn std::any::Any = borrow.as_mut() as &mut dyn std::any::Any; [INFO] [stdout] 123 + [INFO] [stdout] 124 + if let Option::Some(t) = any_ref.downcast_mut::() { [INFO] [stdout] 125 + Result::Ok(f(t)) [INFO] [stdout] 126 + } else { [INFO] [stdout] 127 + Result::Err("Couldn't downcast!".into()) [INFO] [stdout] 128 + } [INFO] [stdout] 129 + } else { [INFO] [stdout] 130 + Result::Err("Couldn't borrow!".into()) [INFO] [stdout] 131 + } [INFO] [stdout] 132 + } else { [INFO] [stdout] 133 + Result::Err("Can't get the specified component!".into()) [INFO] [stdout] 134 + } [INFO] [stdout] 135 + } else { [INFO] [stdout] 136 + Result::Err("Can't get data!".into()) [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/entity.rs:32:30 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn destroy(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/entity.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | / if let Option::Some(scene_rc) = self.get_scene() { [INFO] [stdout] 34 | | if let Option::Some(scene) = scene_rc.get_mut() { [INFO] [stdout] 35 | | scene.destroy_entity(self); [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 33 ~ if let Option::Some(scene_rc) = self.get_scene() [INFO] [stdout] 34 ~ && let Option::Some(scene) = scene_rc.get_mut() { [INFO] [stdout] 35 | scene.destroy_entity(self); [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/entity.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | return Option::None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return Option::None; [INFO] [stdout] 76 + Option::None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EntityData` [INFO] [stdout] --> src/entitydata.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | return Self { [INFO] [stdout] 14 | | components: HashMap::new(), [INFO] [stdout] 15 | | }; [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for EntityData { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/entity.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / if let Option::Some(scene_rc) = self.get_scene() { [INFO] [stdout] 48 | | if let Option::Some(scene) = scene_rc.get_ref() { [INFO] [stdout] 49 | | let type_id: &'static str = type_name::(); [INFO] [stdout] ... | [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 47 ~ if let Option::Some(scene_rc) = self.get_scene() [INFO] [stdout] 48 ~ && let Option::Some(scene) = scene_rc.get_ref() { [INFO] [stdout] 49 | let type_id: &'static str = type_name::(); [INFO] [stdout] ... [INFO] [stdout] 72 | } [INFO] [stdout] 73 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/entitydata.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | / return Self { [INFO] [stdout] 14 | | components: HashMap::new(), [INFO] [stdout] 15 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 ~ Self { [INFO] [stdout] 14 + components: HashMap::new(), [INFO] [stdout] 15 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scene.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / return Rc::new(BoxMut::new(Self { [INFO] [stdout] 20 | | entity_objects: HashMap::new(), [INFO] [stdout] 21 | | systems: HashMap::new(), [INFO] [stdout] 22 | | id_count: 0, [INFO] [stdout] 23 | | })); [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ Rc::new(BoxMut::new(Self { [INFO] [stdout] 20 + entity_objects: HashMap::new(), [INFO] [stdout] 21 + systems: HashMap::new(), [INFO] [stdout] 22 + id_count: 0, [INFO] [stdout] 23 ~ })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/entity.rs:62:25 [INFO] [stdout] | [INFO] [stdout] 62 | / if let Option::Some(borrowed) = dyncomponentrc.get_mut() { [INFO] [stdout] 63 | | if let Option::Some(bc) = borrowed.as_behaviour() { [INFO] [stdout] 64 | | bc.set_entity(e_ptr); [INFO] [stdout] 65 | | } [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 62 ~ if let Option::Some(borrowed) = dyncomponentrc.get_mut() [INFO] [stdout] 63 ~ && let Option::Some(bc) = borrowed.as_behaviour() { [INFO] [stdout] 64 | bc.set_entity(e_ptr); [INFO] [stdout] 65 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scene.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return entity.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return entity.clone(); [INFO] [stdout] 45 + entity.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/entity.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | return Option::None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return Option::None; [INFO] [stdout] 104 + Option::None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:49:29 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn update(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/entity.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | / if let Option::Some(scene_rc) = self.get_scene() { [INFO] [stdout] 85 | | if let Option::Some(scene) = scene_rc.get_mut() { [INFO] [stdout] 86 | | let type_id: &'static str = type_name::(); [INFO] [stdout] ... | [INFO] [stdout] 102 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 84 ~ if let Option::Some(scene_rc) = self.get_scene() [INFO] [stdout] 85 ~ && let Option::Some(scene) = scene_rc.get_mut() { [INFO] [stdout] 86 | let type_id: &'static str = type_name::(); [INFO] [stdout] ... [INFO] [stdout] 100 | } [INFO] [stdout] 101 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/entity.rs:88:17 [INFO] [stdout] | [INFO] [stdout] 88 | / if let Option::Some(data) = self.entity_data.as_mut() { [INFO] [stdout] 89 | | if let Option::Some(component) = data.components.remove(type_id) { [INFO] [stdout] 90 | | if let Option::Some(borrowed) = component.get_mut() { [INFO] [stdout] 91 | | if let Option::Some(bc) = borrowed.as_behaviour() { [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 88 ~ if let Option::Some(data) = self.entity_data.as_mut() [INFO] [stdout] 89 ~ && let Option::Some(component) = data.components.remove(type_id) { [INFO] [stdout] 90 | if let Option::Some(borrowed) = component.get_mut() { [INFO] [stdout] ... [INFO] [stdout] 98 | return Option::Some(()); [INFO] [stdout] 99 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:58:27 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn draw(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:67:39 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn update_behaviour(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/scene.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | / if let Option::Some(bs) = self.systems.get_mut(btypeid) { [INFO] [stdout] 71 | | if let Option::Some(updatable) = bs.get_updatable() { [INFO] [stdout] 72 | | updatable.update(); [INFO] [stdout] 73 | | } [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 70 ~ if let Option::Some(bs) = self.systems.get_mut(btypeid) [INFO] [stdout] 71 ~ && let Option::Some(updatable) = bs.get_updatable() { [INFO] [stdout] 72 | updatable.update(); [INFO] [stdout] 73 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:78:37 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn draw_behaviour(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/scene.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | / if let Option::Some(bs) = self.systems.get_mut(btypeid) { [INFO] [stdout] 82 | | if let Option::Some(drawable) = bs.get_drawable() { [INFO] [stdout] 83 | | drawable.draw(); [INFO] [stdout] 84 | | } [INFO] [stdout] 85 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 81 ~ if let Option::Some(bs) = self.systems.get_mut(btypeid) [INFO] [stdout] 82 ~ && let Option::Some(drawable) = bs.get_drawable() { [INFO] [stdout] 83 | drawable.draw(); [INFO] [stdout] 84 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:91:6 [INFO] [stdout] | [INFO] [stdout] 91 | ) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:100:6 [INFO] [stdout] | [INFO] [stdout] 100 | ) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:106:59 [INFO] [stdout] | [INFO] [stdout] 106 | fn deinitialize_entity(&mut self, entity: &mut Entity) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:115:57 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn remove_entity(&mut self, entity: &mut Entity) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:126:58 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn destroy_entity(&mut self, entity: &mut Entity) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scene.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | return Option::Some(()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 - return Option::Some(()); [INFO] [stdout] 140 + Option::Some(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/entity.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | / if let Option::Some(borrowed) = component.get_mut() { [INFO] [stdout] 91 | | if let Option::Some(bc) = borrowed.as_behaviour() { [INFO] [stdout] 92 | | bc.set_entity(std::ptr::null_mut()); [INFO] [stdout] 93 | | } [INFO] [stdout] 94 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 90 ~ if let Option::Some(borrowed) = component.get_mut() [INFO] [stdout] 91 ~ && let Option::Some(bc) = borrowed.as_behaviour() { [INFO] [stdout] 92 | bc.set_entity(std::ptr::null_mut()); [INFO] [stdout] 93 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/entity.rs:107:35 [INFO] [stdout] | [INFO] [stdout] 107 | pub(crate) fn reset(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/entity.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | / return if let Option::Some(data) = self.entity_data.as_mut() { [INFO] [stdout] 120 | | if let Option::Some(rc) = data.components.get(type_id) { [INFO] [stdout] 121 | | if let Option::Some(borrow) = rc.get_mut() { [INFO] [stdout] 122 | | let any_ref: &mut dyn std::any::Any = borrow.as_mut() as &mut dyn std::any::Any; [INFO] [stdout] ... | [INFO] [stdout] 136 | | Result::Err("Can't get data!".into()) [INFO] [stdout] 137 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 119 ~ if let Option::Some(data) = self.entity_data.as_mut() { [INFO] [stdout] 120 + if let Option::Some(rc) = data.components.get(type_id) { [INFO] [stdout] 121 + if let Option::Some(borrow) = rc.get_mut() { [INFO] [stdout] 122 + let any_ref: &mut dyn std::any::Any = borrow.as_mut() as &mut dyn std::any::Any; [INFO] [stdout] 123 + [INFO] [stdout] 124 + if let Option::Some(t) = any_ref.downcast_mut::() { [INFO] [stdout] 125 + Result::Ok(f(t)) [INFO] [stdout] 126 + } else { [INFO] [stdout] 127 + Result::Err("Couldn't downcast!".into()) [INFO] [stdout] 128 + } [INFO] [stdout] 129 + } else { [INFO] [stdout] 130 + Result::Err("Couldn't borrow!".into()) [INFO] [stdout] 131 + } [INFO] [stdout] 132 + } else { [INFO] [stdout] 133 + Result::Err("Can't get the specified component!".into()) [INFO] [stdout] 134 + } [INFO] [stdout] 135 + } else { [INFO] [stdout] 136 + Result::Err("Can't get data!".into()) [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EntityData` [INFO] [stdout] --> src/entitydata.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | return Self { [INFO] [stdout] 14 | | components: HashMap::new(), [INFO] [stdout] 15 | | }; [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for EntityData { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/entitydata.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | / return Self { [INFO] [stdout] 14 | | components: HashMap::new(), [INFO] [stdout] 15 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 ~ Self { [INFO] [stdout] 14 + components: HashMap::new(), [INFO] [stdout] 15 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tbehaviourcomponent.rs:6:25 [INFO] [stdout] | [INFO] [stdout] 6 | fn update(&mut self) -> () {} [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scene.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / return Rc::new(BoxMut::new(Self { [INFO] [stdout] 20 | | entity_objects: HashMap::new(), [INFO] [stdout] 21 | | systems: HashMap::new(), [INFO] [stdout] 22 | | id_count: 0, [INFO] [stdout] 23 | | })); [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ Rc::new(BoxMut::new(Self { [INFO] [stdout] 20 + entity_objects: HashMap::new(), [INFO] [stdout] 21 + systems: HashMap::new(), [INFO] [stdout] 22 + id_count: 0, [INFO] [stdout] 23 ~ })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tbehaviourcomponent.rs:9:23 [INFO] [stdout] | [INFO] [stdout] 9 | fn draw(&mut self) -> () {} [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tbehaviourcomponent.rs:12:31 [INFO] [stdout] | [INFO] [stdout] 12 | fn on_destroyed(&mut self) -> () {} [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scene.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return entity.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return entity.clone(); [INFO] [stdout] 45 + entity.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tbehaviourcomponent.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return -1; [INFO] [stdout] 16 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tbehaviourcomponent.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return Option::None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return Option::None; [INFO] [stdout] 21 + Option::None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tbehaviourcomponent.rs:25:51 [INFO] [stdout] | [INFO] [stdout] 25 | fn set_entity(&mut self, _entity: *mut Entity) -> () {} [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:49:29 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn update(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tcomponent.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | return Option::None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return Option::None; [INFO] [stdout] 9 + Option::None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:58:27 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn draw(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tdrawsystem.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | return Option::Some(self); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return Option::Some(self); [INFO] [stdout] 8 + Option::Some(self) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tdrawsystem.rs:11:19 [INFO] [stdout] | [INFO] [stdout] 11 | fn draw(&self) -> () {} [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:67:39 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn update_behaviour(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/scene.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | / if let Option::Some(bs) = self.systems.get_mut(btypeid) { [INFO] [stdout] 71 | | if let Option::Some(updatable) = bs.get_updatable() { [INFO] [stdout] 72 | | updatable.update(); [INFO] [stdout] 73 | | } [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 70 ~ if let Option::Some(bs) = self.systems.get_mut(btypeid) [INFO] [stdout] 71 ~ && let Option::Some(updatable) = bs.get_updatable() { [INFO] [stdout] 72 | updatable.update(); [INFO] [stdout] 73 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/test.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | assert!(!coll.get_entity().is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `coll.get_entity().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/test.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 14 | fn iterate_scene() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:78:37 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn draw_behaviour(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/scene.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | / if let Option::Some(bs) = self.systems.get_mut(btypeid) { [INFO] [stdout] 82 | | if let Option::Some(drawable) = bs.get_drawable() { [INFO] [stdout] 83 | | drawable.draw(); [INFO] [stdout] 84 | | } [INFO] [stdout] 85 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 81 ~ if let Option::Some(bs) = self.systems.get_mut(btypeid) [INFO] [stdout] 82 ~ && let Option::Some(drawable) = bs.get_drawable() { [INFO] [stdout] 83 | drawable.draw(); [INFO] [stdout] 84 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:91:6 [INFO] [stdout] | [INFO] [stdout] 91 | ) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:100:6 [INFO] [stdout] | [INFO] [stdout] 100 | ) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:106:59 [INFO] [stdout] | [INFO] [stdout] 106 | fn deinitialize_entity(&mut self, entity: &mut Entity) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:115:57 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn remove_entity(&mut self, entity: &mut Entity) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tsystem.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | return Option::None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return Option::None; [INFO] [stdout] 13 + Option::None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tsystem.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return Option::None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return Option::None; [INFO] [stdout] 21 + Option::None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/scene.rs:126:58 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn destroy_entity(&mut self, entity: &mut Entity) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tsystem.rs:25:89 [INFO] [stdout] | [INFO] [stdout] 25 | fn on_component_added_to_entity(&self, _component: &Rc>>) -> () {} [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tsystem.rs:27:93 [INFO] [stdout] | [INFO] [stdout] 27 | fn on_component_removed_from_entity(&self, _component: &Rc>>) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scene.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | return Option::Some(()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 - return Option::Some(()); [INFO] [stdout] 140 + Option::Some(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tupdatesystem.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | return Option::None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return Option::None; [INFO] [stdout] 8 + Option::None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tupdatesystem.rs:11:21 [INFO] [stdout] | [INFO] [stdout] 11 | fn update(&self) -> () {} [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tbehaviourcomponent.rs:6:25 [INFO] [stdout] | [INFO] [stdout] 6 | fn update(&mut self) -> () {} [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tbehaviourcomponent.rs:9:23 [INFO] [stdout] | [INFO] [stdout] 9 | fn draw(&mut self) -> () {} [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tbehaviourcomponent.rs:12:31 [INFO] [stdout] | [INFO] [stdout] 12 | fn on_destroyed(&mut self) -> () {} [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tbehaviourcomponent.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return -1; [INFO] [stdout] 16 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tbehaviourcomponent.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return Option::None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return Option::None; [INFO] [stdout] 21 + Option::None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tbehaviourcomponent.rs:25:51 [INFO] [stdout] | [INFO] [stdout] 25 | fn set_entity(&mut self, _entity: *mut Entity) -> () {} [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tcomponent.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | return Option::None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return Option::None; [INFO] [stdout] 9 + Option::None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tdrawsystem.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | return Option::Some(self); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return Option::Some(self); [INFO] [stdout] 8 + Option::Some(self) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tdrawsystem.rs:11:19 [INFO] [stdout] | [INFO] [stdout] 11 | fn draw(&self) -> () {} [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tsystem.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | return Option::None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return Option::None; [INFO] [stdout] 13 + Option::None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tsystem.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return Option::None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return Option::None; [INFO] [stdout] 21 + Option::None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tsystem.rs:25:89 [INFO] [stdout] | [INFO] [stdout] 25 | fn on_component_added_to_entity(&self, _component: &Rc>>) -> () {} [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tsystem.rs:27:93 [INFO] [stdout] | [INFO] [stdout] 27 | fn on_component_removed_from_entity(&self, _component: &Rc>>) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tupdatesystem.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | return Option::None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return Option::None; [INFO] [stdout] 8 + Option::None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tupdatesystem.rs:11:21 [INFO] [stdout] | [INFO] [stdout] 11 | fn update(&self) -> () {} [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.25s [INFO] running `Command { std: "docker" "inspect" "a786ee2a7e53fd058dcbc662413136afe88fe87c207ff1716096ee9600b1292e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a786ee2a7e53fd058dcbc662413136afe88fe87c207ff1716096ee9600b1292e", kill_on_drop: false }` [INFO] [stdout] a786ee2a7e53fd058dcbc662413136afe88fe87c207ff1716096ee9600b1292e