[INFO] cloning repository https://github.com/Jax-Hax/First-Compiler [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Jax-Hax/First-Compiler" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJax-Hax%2FFirst-Compiler", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJax-Hax%2FFirst-Compiler'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a71be2cd0e9fb7ed51e7d4a4138888c34062b988 [INFO] linting Jax-Hax/First-Compiler against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJax-Hax%2FFirst-Compiler" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Jax-Hax/First-Compiler [INFO] finished tweaking git repo https://github.com/Jax-Hax/First-Compiler [INFO] tweaked toml for git repo https://github.com/Jax-Hax/First-Compiler written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Jax-Hax/First-Compiler on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Jax-Hax/First-Compiler already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 13c00fff561158fcb8e6cbaef774b12b31168d4ab7e51f8dfc57674d0dfd383d [INFO] running `Command { std: "docker" "start" "-a" "13c00fff561158fcb8e6cbaef774b12b31168d4ab7e51f8dfc57674d0dfd383d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "13c00fff561158fcb8e6cbaef774b12b31168d4ab7e51f8dfc57674d0dfd383d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "13c00fff561158fcb8e6cbaef774b12b31168d4ab7e51f8dfc57674d0dfd383d", kill_on_drop: false }` [INFO] [stdout] 13c00fff561158fcb8e6cbaef774b12b31168d4ab7e51f8dfc57674d0dfd383d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9253cd1c0c1bbb3f076689e56db33923f30daa98d2149a9af9117fdccd569bc9 [INFO] running `Command { std: "docker" "start" "-a" "9253cd1c0c1bbb3f076689e56db33923f30daa98d2149a9af9117fdccd569bc9", kill_on_drop: false }` [INFO] [stderr] Checking First-Compiler v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `expr_precendence` [INFO] [stdout] --> src/ast.rs:91:39 [INFO] [stdout] | [INFO] [stdout] 91 | fn parse_binary_op_rhs(&mut self, expr_precendence: i32, lhs: Node) -> Node { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_expr_precendence` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lhs` [INFO] [stdout] --> src/ast.rs:91:62 [INFO] [stdout] | [INFO] [stdout] 91 | fn parse_binary_op_rhs(&mut self, expr_precendence: i32, lhs: Node) -> Node { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_lhs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tok_precedence` [INFO] [stdout] --> src/ast.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | let tok_precedence = self.get_tok_precedence(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tok_precedence` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/ast.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | Val(f32), [INFO] [stdout] | --- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Node` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 154 - Val(f32), [INFO] [stdout] 154 + Val(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `args` are never read [INFO] [stdout] --> src/ast.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 165 | FunctionCall { [INFO] [stdout] | ------------ fields in this variant [INFO] [stdout] 166 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 167 | args: Vec>, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Node` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/ast.rs:173:14 [INFO] [stdout] | [INFO] [stdout] 173 | Variable(String), [INFO] [stdout] | -------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Node` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 173 - Variable(String), [INFO] [stdout] 173 + Variable(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Eof`, `UnaryExpr`, `BinaryExpr`, and `Function` are never constructed [INFO] [stdout] --> src/ast.rs:155:5 [INFO] [stdout] | [INFO] [stdout] 153 | pub enum Node { [INFO] [stdout] | ---- variants in this enum [INFO] [stdout] 154 | Val(f32), [INFO] [stdout] 155 | Eof, [INFO] [stdout] | ^^^ [INFO] [stdout] 156 | UnaryExpr { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 160 | BinaryExpr { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 169 | Function { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Node` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `args` are never read [INFO] [stdout] --> src/ast.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 177 | pub struct FunctionParams { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 178 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 179 | pub args: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FunctionParams` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr_precendence` [INFO] [stdout] --> src/ast.rs:91:39 [INFO] [stdout] | [INFO] [stdout] 91 | fn parse_binary_op_rhs(&mut self, expr_precendence: i32, lhs: Node) -> Node { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_expr_precendence` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lhs` [INFO] [stdout] --> src/ast.rs:91:62 [INFO] [stdout] | [INFO] [stdout] 91 | fn parse_binary_op_rhs(&mut self, expr_precendence: i32, lhs: Node) -> Node { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_lhs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tok_precedence` [INFO] [stdout] --> src/ast.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | let tok_precedence = self.get_tok_precedence(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tok_precedence` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AST` contains a capitalized acronym [INFO] [stdout] --> src/ast.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct AST { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ast` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `node` after checking its variant with `is_some` [INFO] [stdout] --> src/ast.rs:38:48 [INFO] [stdout] | [INFO] [stdout] 37 | if node.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = node` [INFO] [stdout] 38 | args.push(Box::new(node.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | / return Node::FunctionCall { [INFO] [stdout] 62 | | name: identifier, [INFO] [stdout] 63 | | args, [INFO] [stdout] 64 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ Node::FunctionCall { [INFO] [stdout] 62 + name: identifier, [INFO] [stdout] 63 + args, [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ast.rs:24:17 [INFO] [stdout] | [INFO] [stdout] 24 | / if char != '(' { [INFO] [stdout] 25 | | return Node::Variable(identifier); [INFO] [stdout] 26 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 23 ~ Token::Other(char) [INFO] [stdout] 24 ~ if char != '(' => { [INFO] [stdout] 25 | return Node::Variable(identifier); [INFO] [stdout] 26 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ast.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | / match self.cur_token { [INFO] [stdout] 23 | | Token::Other(char) => { [INFO] [stdout] 24 | | if char != '(' { [INFO] [stdout] 25 | | return Node::Variable(identifier); [INFO] [stdout] ... | [INFO] [stdout] 28 | | _ => {} [INFO] [stdout] 29 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 22 ~ if let Token::Other(char) = self.cur_token { [INFO] [stdout] 23 + if char != '(' { [INFO] [stdout] 24 + return Node::Variable(identifier); [INFO] [stdout] 25 + } [INFO] [stdout] 26 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ast.rs:34:17 [INFO] [stdout] | [INFO] [stdout] 34 | / if char != ')' { [INFO] [stdout] 35 | | loop { [INFO] [stdout] 36 | | let node = self.parse_expression(); [INFO] [stdout] 37 | | if node.is_some() { [INFO] [stdout] ... | [INFO] [stdout] 56 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 33 ~ Token::Other(char) [INFO] [stdout] 34 ~ if char != ')' => { [INFO] [stdout] 35 | loop { [INFO] [stdout] ... [INFO] [stdout] 55 | } [INFO] [stdout] 56 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ast.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / match self.cur_token { [INFO] [stdout] 33 | | Token::Other(char) => { [INFO] [stdout] 34 | | if char != ')' { [INFO] [stdout] 35 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 58 | | _ => {} [INFO] [stdout] 59 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 32 ~ if let Token::Other(char) = self.cur_token { [INFO] [stdout] 33 + if char != ')' { [INFO] [stdout] 34 + loop { [INFO] [stdout] 35 + let node = self.parse_expression(); [INFO] [stdout] 36 + if node.is_some() { [INFO] [stdout] 37 + args.push(Box::new(node.unwrap())); [INFO] [stdout] 38 + } else { [INFO] [stdout] 39 + return Node::Error("Failed to parse expression".to_string()); [INFO] [stdout] 40 + } [INFO] [stdout] 41 + match self.cur_token { [INFO] [stdout] 42 + Token::Other(char) => { [INFO] [stdout] 43 + if char == ')' { [INFO] [stdout] 44 + break; [INFO] [stdout] 45 + } else if char != ',' { [INFO] [stdout] 46 + return Node::Error( [INFO] [stdout] 47 + "Expected ')' or ',' in an argument list".to_string(), [INFO] [stdout] 48 + ); [INFO] [stdout] 49 + } [INFO] [stdout] 50 + } [INFO] [stdout] 51 + _ => {} [INFO] [stdout] 52 + } [INFO] [stdout] 53 + self.next_tok(); [INFO] [stdout] 54 + } [INFO] [stdout] 55 + } [INFO] [stdout] 56 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ast.rs:42:25 [INFO] [stdout] | [INFO] [stdout] 42 | / match self.cur_token { [INFO] [stdout] 43 | | Token::Other(char) => { [INFO] [stdout] 44 | | if char == ')' { [INFO] [stdout] 45 | | break; [INFO] [stdout] ... | [INFO] [stdout] 52 | | _ => {} [INFO] [stdout] 53 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 42 ~ if let Token::Other(char) = self.cur_token { [INFO] [stdout] 43 + if char == ')' { [INFO] [stdout] 44 + break; [INFO] [stdout] 45 + } else if char != ',' { [INFO] [stdout] 46 + return Node::Error( [INFO] [stdout] 47 + "Expected ')' or ',' in an argument list".to_string(), [INFO] [stdout] 48 + ); [INFO] [stdout] 49 + } [INFO] [stdout] 50 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | return node.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return node.unwrap(); [INFO] [stdout] 81 + node.unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ast.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | / if char != ')' { [INFO] [stdout] 75 | | return Node::Error("Expected ')' but got {char}".to_string()); [INFO] [stdout] 76 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 73 ~ Token::Other(char) [INFO] [stdout] 74 ~ if char != ')' => { [INFO] [stdout] 75 | return Node::Error("Expected ')' but got {char}".to_string()); [INFO] [stdout] 76 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ast.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | / match self.cur_token { [INFO] [stdout] 73 | | Token::Other(char) => { [INFO] [stdout] 74 | | if char != ')' { [INFO] [stdout] 75 | | return Node::Error("Expected ')' but got {char}".to_string()); [INFO] [stdout] ... | [INFO] [stdout] 78 | | _ => {} [INFO] [stdout] 79 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 ~ if let Token::Other(char) = self.cur_token { [INFO] [stdout] 73 + if char != ')' { [INFO] [stdout] 74 + return Node::Error("Expected ')' but got {char}".to_string()); [INFO] [stdout] 75 + } [INFO] [stdout] 76 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:89:7 [INFO] [stdout] | [INFO] [stdout] 89 | return Some(self.parse_binary_op_rhs(0,lhs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return Some(self.parse_binary_op_rhs(0,lhs)) [INFO] [stdout] 89 + Some(self.parse_binary_op_rhs(0,lhs)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ast.rs:85:7 [INFO] [stdout] | [INFO] [stdout] 85 | / match lhs { [INFO] [stdout] 86 | | Node::Error(_) => return None, [INFO] [stdout] 87 | | _ => {} [INFO] [stdout] 88 | | } [INFO] [stdout] | |_______^ help: try: `if let Node::Error(_) = lhs { return None }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/ast.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | Val(f32), [INFO] [stdout] | --- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Node` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 154 - Val(f32), [INFO] [stdout] 154 + Val(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `args` are never read [INFO] [stdout] --> src/ast.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 165 | FunctionCall { [INFO] [stdout] | ------------ fields in this variant [INFO] [stdout] 166 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 167 | args: Vec>, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Node` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `precendence` after checking its variant with `is_none` [INFO] [stdout] --> src/ast.rs:105:60 [INFO] [stdout] | [INFO] [stdout] 105 | if precendence.is_none() {return -1} else {return *precendence.unwrap()} [INFO] [stdout] | ------------------------ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `if let Some() = precendence` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/ast.rs:173:14 [INFO] [stdout] | [INFO] [stdout] 173 | Variable(String), [INFO] [stdout] | -------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Node` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 173 - Variable(String), [INFO] [stdout] 173 + Variable(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Eof`, `UnaryExpr`, `BinaryExpr`, and `Function` are never constructed [INFO] [stdout] --> src/ast.rs:155:5 [INFO] [stdout] | [INFO] [stdout] 153 | pub enum Node { [INFO] [stdout] | ---- variants in this enum [INFO] [stdout] 154 | Val(f32), [INFO] [stdout] 155 | Eof, [INFO] [stdout] | ^^^ [INFO] [stdout] 156 | UnaryExpr { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 160 | BinaryExpr { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 169 | Function { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Node` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `args` are never read [INFO] [stdout] --> src/ast.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 177 | pub struct FunctionParams { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 178 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 179 | pub args: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FunctionParams` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AST` contains a capitalized acronym [INFO] [stdout] --> src/ast.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct AST { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ast` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:167:15 [INFO] [stdout] | [INFO] [stdout] 167 | args: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `node` after checking its variant with `is_some` [INFO] [stdout] --> src/ast.rs:38:48 [INFO] [stdout] | [INFO] [stdout] 37 | if node.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = node` [INFO] [stdout] 38 | args.push(Box::new(node.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | / return Node::FunctionCall { [INFO] [stdout] 62 | | name: identifier, [INFO] [stdout] 63 | | args, [INFO] [stdout] 64 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ Node::FunctionCall { [INFO] [stdout] 62 + name: identifier, [INFO] [stdout] 63 + args, [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ast.rs:24:17 [INFO] [stdout] | [INFO] [stdout] 24 | / if char != '(' { [INFO] [stdout] 25 | | return Node::Variable(identifier); [INFO] [stdout] 26 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 23 ~ Token::Other(char) [INFO] [stdout] 24 ~ if char != '(' => { [INFO] [stdout] 25 | return Node::Variable(identifier); [INFO] [stdout] 26 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ast.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | / match self.cur_token { [INFO] [stdout] 23 | | Token::Other(char) => { [INFO] [stdout] 24 | | if char != '(' { [INFO] [stdout] 25 | | return Node::Variable(identifier); [INFO] [stdout] ... | [INFO] [stdout] 28 | | _ => {} [INFO] [stdout] 29 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 22 ~ if let Token::Other(char) = self.cur_token { [INFO] [stdout] 23 + if char != '(' { [INFO] [stdout] 24 + return Node::Variable(identifier); [INFO] [stdout] 25 + } [INFO] [stdout] 26 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ast.rs:34:17 [INFO] [stdout] | [INFO] [stdout] 34 | / if char != ')' { [INFO] [stdout] 35 | | loop { [INFO] [stdout] 36 | | let node = self.parse_expression(); [INFO] [stdout] 37 | | if node.is_some() { [INFO] [stdout] ... | [INFO] [stdout] 56 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 33 ~ Token::Other(char) [INFO] [stdout] 34 ~ if char != ')' => { [INFO] [stdout] 35 | loop { [INFO] [stdout] ... [INFO] [stdout] 55 | } [INFO] [stdout] 56 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ast.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / match self.cur_token { [INFO] [stdout] 33 | | Token::Other(char) => { [INFO] [stdout] 34 | | if char != ')' { [INFO] [stdout] 35 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 58 | | _ => {} [INFO] [stdout] 59 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 32 ~ if let Token::Other(char) = self.cur_token { [INFO] [stdout] 33 + if char != ')' { [INFO] [stdout] 34 + loop { [INFO] [stdout] 35 + let node = self.parse_expression(); [INFO] [stdout] 36 + if node.is_some() { [INFO] [stdout] 37 + args.push(Box::new(node.unwrap())); [INFO] [stdout] 38 + } else { [INFO] [stdout] 39 + return Node::Error("Failed to parse expression".to_string()); [INFO] [stdout] 40 + } [INFO] [stdout] 41 + match self.cur_token { [INFO] [stdout] 42 + Token::Other(char) => { [INFO] [stdout] 43 + if char == ')' { [INFO] [stdout] 44 + break; [INFO] [stdout] 45 + } else if char != ',' { [INFO] [stdout] 46 + return Node::Error( [INFO] [stdout] 47 + "Expected ')' or ',' in an argument list".to_string(), [INFO] [stdout] 48 + ); [INFO] [stdout] 49 + } [INFO] [stdout] 50 + } [INFO] [stdout] 51 + _ => {} [INFO] [stdout] 52 + } [INFO] [stdout] 53 + self.next_tok(); [INFO] [stdout] 54 + } [INFO] [stdout] 55 + } [INFO] [stdout] 56 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:52:43 [INFO] [stdout] | [INFO] [stdout] 52 | if !last_char.is_numeric() && !(last_char == '.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(last_char != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | return Token::Other(last_char) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return Token::Other(last_char) [INFO] [stdout] 71 + Token::Other(last_char) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ast.rs:42:25 [INFO] [stdout] | [INFO] [stdout] 42 | / match self.cur_token { [INFO] [stdout] 43 | | Token::Other(char) => { [INFO] [stdout] 44 | | if char == ')' { [INFO] [stdout] 45 | | break; [INFO] [stdout] ... | [INFO] [stdout] 52 | | _ => {} [INFO] [stdout] 53 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 42 ~ if let Token::Other(char) = self.cur_token { [INFO] [stdout] 43 + if char == ')' { [INFO] [stdout] 44 + break; [INFO] [stdout] 45 + } else if char != ',' { [INFO] [stdout] 46 + return Node::Error( [INFO] [stdout] 47 + "Expected ')' or ',' in an argument list".to_string(), [INFO] [stdout] 48 + ); [INFO] [stdout] 49 + } [INFO] [stdout] 50 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | return node.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return node.unwrap(); [INFO] [stdout] 81 + node.unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ast.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | / if char != ')' { [INFO] [stdout] 75 | | return Node::Error("Expected ')' but got {char}".to_string()); [INFO] [stdout] 76 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 73 ~ Token::Other(char) [INFO] [stdout] 74 ~ if char != ')' => { [INFO] [stdout] 75 | return Node::Error("Expected ')' but got {char}".to_string()); [INFO] [stdout] 76 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ast.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | / match self.cur_token { [INFO] [stdout] 73 | | Token::Other(char) => { [INFO] [stdout] 74 | | if char != ')' { [INFO] [stdout] 75 | | return Node::Error("Expected ')' but got {char}".to_string()); [INFO] [stdout] ... | [INFO] [stdout] 78 | | _ => {} [INFO] [stdout] 79 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 ~ if let Token::Other(char) = self.cur_token { [INFO] [stdout] 73 + if char != ')' { [INFO] [stdout] 74 + return Node::Error("Expected ')' but got {char}".to_string()); [INFO] [stdout] 75 + } [INFO] [stdout] 76 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:89:7 [INFO] [stdout] | [INFO] [stdout] 89 | return Some(self.parse_binary_op_rhs(0,lhs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return Some(self.parse_binary_op_rhs(0,lhs)) [INFO] [stdout] 89 + Some(self.parse_binary_op_rhs(0,lhs)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ast.rs:85:7 [INFO] [stdout] | [INFO] [stdout] 85 | / match lhs { [INFO] [stdout] 86 | | Node::Error(_) => return None, [INFO] [stdout] 87 | | _ => {} [INFO] [stdout] 88 | | } [INFO] [stdout] | |_______^ help: try: `if let Node::Error(_) = lhs { return None }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `precendence` after checking its variant with `is_none` [INFO] [stdout] --> src/ast.rs:105:60 [INFO] [stdout] | [INFO] [stdout] 105 | if precendence.is_none() {return -1} else {return *precendence.unwrap()} [INFO] [stdout] | ------------------------ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `if let Some() = precendence` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | for node in nodes { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 20 - for node in nodes { [INFO] [stdout] 20 + while let Some(node) = nodes { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 20 - for node in nodes { [INFO] [stdout] 20 + if let Some(node) = nodes { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:167:15 [INFO] [stdout] | [INFO] [stdout] 167 | args: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:52:43 [INFO] [stdout] | [INFO] [stdout] 52 | if !last_char.is_numeric() && !(last_char == '.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(last_char != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | return Token::Other(last_char) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return Token::Other(last_char) [INFO] [stdout] 71 + Token::Other(last_char) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | for node in nodes { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 20 - for node in nodes { [INFO] [stdout] 20 + while let Some(node) = nodes { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 20 - for node in nodes { [INFO] [stdout] 20 + if let Some(node) = nodes { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.14s [INFO] running `Command { std: "docker" "inspect" "9253cd1c0c1bbb3f076689e56db33923f30daa98d2149a9af9117fdccd569bc9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9253cd1c0c1bbb3f076689e56db33923f30daa98d2149a9af9117fdccd569bc9", kill_on_drop: false }` [INFO] [stdout] 9253cd1c0c1bbb3f076689e56db33923f30daa98d2149a9af9117fdccd569bc9