[INFO] cloning repository https://github.com/JasonXu314/glite [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JasonXu314/glite" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJasonXu314%2Fglite", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJasonXu314%2Fglite'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 79a7513e3c1ee50fbedf85717c9f4fc910a38b4a [INFO] linting JasonXu314/glite against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJasonXu314%2Fglite" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/JasonXu314/glite [INFO] finished tweaking git repo https://github.com/JasonXu314/glite [INFO] tweaked toml for git repo https://github.com/JasonXu314/glite written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/JasonXu314/glite on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/JasonXu314/glite already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded indexmap v1.9.1 [INFO] [stderr] Downloaded clap_lex v0.2.4 [INFO] [stderr] Downloaded colorful v0.2.1 [INFO] [stderr] Downloaded once_cell v1.13.0 [INFO] [stderr] Downloaded clap_derive v3.2.7 [INFO] [stderr] Downloaded os_str_bytes v6.1.0 [INFO] [stderr] Downloaded hashbrown v0.12.2 [INFO] [stderr] Downloaded aho-corasick v0.7.18 [INFO] [stderr] Downloaded clap v3.2.8 [INFO] [stderr] Downloaded regex v1.6.0 [INFO] [stderr] Downloaded regex-syntax v0.6.27 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7e0467ed815ed8849bebaa370856beb5f3b663c04174a5d7ba2e367df811e347 [INFO] running `Command { std: "docker" "start" "-a" "7e0467ed815ed8849bebaa370856beb5f3b663c04174a5d7ba2e367df811e347", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7e0467ed815ed8849bebaa370856beb5f3b663c04174a5d7ba2e367df811e347", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e0467ed815ed8849bebaa370856beb5f3b663c04174a5d7ba2e367df811e347", kill_on_drop: false }` [INFO] [stdout] 7e0467ed815ed8849bebaa370856beb5f3b663c04174a5d7ba2e367df811e347 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ef6d3e37a337c66029d14540889995a16cb66c903db60d38395e0c7b34216c8a [INFO] running `Command { std: "docker" "start" "-a" "ef6d3e37a337c66029d14540889995a16cb66c903db60d38395e0c7b34216c8a", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking hashbrown v0.12.2 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking os_str_bytes v6.1.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking colorful v0.2.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Compiling clap_derive v3.2.7 [INFO] [stderr] Checking clap v3.2.8 [INFO] [stderr] Checking glite v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/git.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Remote { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 13 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Remote` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/git.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Branch { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 19 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Branch` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `currBranch` after checking its variant with `is_some` [INFO] [stdout] --> src/git.rs:66:42 [INFO] [stdout] | [INFO] [stdout] 65 | if currBranch.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = currBranch` [INFO] [stdout] 66 | config.branches.push(currBranch.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `currBranch` after checking its variant with `is_some` [INFO] [stdout] --> src/git.rs:95:34 [INFO] [stdout] | [INFO] [stdout] 94 | if currBranch.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = currBranch` [INFO] [stdout] 95 | config.branches.push(currBranch.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | return config; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return config; [INFO] [stdout] 100 + config [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/git.rs:31:29 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn parse(configStr: &String) -> Config { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 31 - pub fn parse(configStr: &String) -> Config { [INFO] [stdout] 31 + pub fn parse(configStr: &str) -> Config { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | return Ok(Git { config }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - return Ok(Git { config }); [INFO] [stdout] 116 + Ok(Git { config }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:119:23 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn init(&self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/git.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Remote { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 13 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Remote` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/git.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Branch { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 19 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Branch` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:128:50 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn stageFiles(&self, paths: &Vec) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/git.rs:128:37 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn stageFiles(&self, paths: &Vec) -> () { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 128 ~ pub fn stageFiles(&self, paths: &[String]) -> () { [INFO] [stdout] 129 | let mut files: Vec = Vec::new(); [INFO] [stdout] ... [INFO] [stdout] 140 | } else { [INFO] [stdout] 141 ~ files = paths.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/git.rs:131:12 [INFO] [stdout] | [INFO] [stdout] 131 | if paths.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `paths.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `currBranch` after checking its variant with `is_some` [INFO] [stdout] --> src/git.rs:66:42 [INFO] [stdout] | [INFO] [stdout] 65 | if currBranch.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = currBranch` [INFO] [stdout] 66 | config.branches.push(currBranch.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `currBranch` after checking its variant with `is_some` [INFO] [stdout] --> src/git.rs:95:34 [INFO] [stdout] | [INFO] [stdout] 94 | if currBranch.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = currBranch` [INFO] [stdout] 95 | config.branches.push(currBranch.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | return config; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return config; [INFO] [stdout] 100 + config [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/git.rs:31:29 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn parse(configStr: &String) -> Config { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 31 - pub fn parse(configStr: &String) -> Config { [INFO] [stdout] 31 + pub fn parse(configStr: &str) -> Config { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:158:52 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn unstageFiles(&self, paths: &Vec) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:167:63 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn commit(&self, message: &Vec, ammend: &bool) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/git.rs:167:35 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn commit(&self, message: &Vec, ammend: &bool) -> () { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 167 - pub fn commit(&self, message: &Vec, ammend: &bool) -> () { [INFO] [stdout] 167 + pub fn commit(&self, message: &[String], ammend: &bool) -> () { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:184:63 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn link(&self, remote: &String, name: &Option) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | return Ok(Git { config }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - return Ok(Git { config }); [INFO] [stdout] 116 + Ok(Git { config }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/git.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 207 | if !self.getCurrentBranch().unwrap().remote.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.getCurrentBranch().unwrap().remote.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:200:52 [INFO] [stdout] | [INFO] [stdout] 200 | pub fn push(&self, remoteName: &Option) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:228:57 [INFO] [stdout] | [INFO] [stdout] 228 | pub fn branch(&self, name: &String, checkout: &bool) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:119:23 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn init(&self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:128:50 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn stageFiles(&self, paths: &Vec) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/git.rs:128:37 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn stageFiles(&self, paths: &Vec) -> () { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 128 ~ pub fn stageFiles(&self, paths: &[String]) -> () { [INFO] [stdout] 129 | let mut files: Vec = Vec::new(); [INFO] [stdout] ... [INFO] [stdout] 140 | } else { [INFO] [stdout] 141 ~ files = paths.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:247:42 [INFO] [stdout] | [INFO] [stdout] 247 | pub fn checkout(&self, name: &String) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/git.rs:131:12 [INFO] [stdout] | [INFO] [stdout] 131 | if paths.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `paths.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/git.rs:247:34 [INFO] [stdout] | [INFO] [stdout] 247 | pub fn checkout(&self, name: &String) -> () { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 247 ~ pub fn checkout(&self, name: &str) -> () { [INFO] [stdout] 248 ~ let result = exec(Command::new("git").arg("checkout").arg(name)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:256:23 [INFO] [stdout] | [INFO] [stdout] 256 | pub fn pull(&self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:158:52 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn unstageFiles(&self, paths: &Vec) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git.rs:272:9 [INFO] [stdout] | [INFO] [stdout] 272 | return Err(String::from("Could not find current branch")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 272 - return Err(String::from("Could not find current branch")); [INFO] [stdout] 272 + Err(String::from("Could not find current branch")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:167:63 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn commit(&self, message: &Vec, ammend: &bool) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git.rs:277:5 [INFO] [stdout] | [INFO] [stdout] 277 | return exec(Command::new("git").arg("branch").arg("--show-current")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - return exec(Command::new("git").arg("branch").arg("--show-current")); [INFO] [stdout] 277 + exec(Command::new("git").arg("branch").arg("--show-current")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/git.rs:167:35 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn commit(&self, message: &Vec, ammend: &bool) -> () { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 167 - pub fn commit(&self, message: &Vec, ammend: &bool) -> () { [INFO] [stdout] 167 + pub fn commit(&self, message: &[String], ammend: &bool) -> () { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git.rs:281:5 [INFO] [stdout] | [INFO] [stdout] 281 | / return Ok(exec(Command::new("git").arg("status").arg("--porcelain"))? [INFO] [stdout] 282 | | .lines() [INFO] [stdout] 283 | | .map(|line| line.trim()[2..].trim().to_string()) [INFO] [stdout] 284 | | .collect::>()); [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 281 ~ Ok(exec(Command::new("git").arg("status").arg("--porcelain"))? [INFO] [stdout] 282 + .lines() [INFO] [stdout] 283 + .map(|line| line.trim()[2..].trim().to_string()) [INFO] [stdout] 284 ~ .collect::>()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:184:63 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn link(&self, remote: &String, name: &Option) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:11:3 [INFO] [stdout] | [INFO] [stdout] 11 | / return Ok(match result.stdout.is_empty() { [INFO] [stdout] 12 | | true => String::from(""), [INFO] [stdout] 13 | | false => { [INFO] [stdout] 14 | | String::from_utf8_lossy(&result.stdout.split_last().unwrap().1).to_string() [INFO] [stdout] 15 | | } [INFO] [stdout] 16 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 ~ Ok(match result.stdout.is_empty() { [INFO] [stdout] 12 ~ true => String::from(""), [INFO] [stdout] 13 ~ false => { [INFO] [stdout] 14 ~ String::from_utf8_lossy(&result.stdout.split_last().unwrap().1).to_string() [INFO] [stdout] 15 ~ } [INFO] [stdout] 16 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/git.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 207 | if !self.getCurrentBranch().unwrap().remote.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.getCurrentBranch().unwrap().remote.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:18:3 [INFO] [stdout] | [INFO] [stdout] 18 | / return Err( [INFO] [stdout] 19 | | String::from_utf8_lossy(&result.stderr.split_last().unwrap().1).to_string(), [INFO] [stdout] 20 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 ~ Err( [INFO] [stdout] 19 ~ String::from_utf8_lossy(&result.stderr.split_last().unwrap().1).to_string(), [INFO] [stdout] 20 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:14:29 [INFO] [stdout] | [INFO] [stdout] 14 | String::from_utf8_lossy(&result.stdout.split_last().unwrap().1).to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `result.stdout.split_last().unwrap().1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:200:52 [INFO] [stdout] | [INFO] [stdout] 200 | pub fn push(&self, remoteName: &Option) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:228:57 [INFO] [stdout] | [INFO] [stdout] 228 | pub fn branch(&self, name: &String, checkout: &bool) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:19:28 [INFO] [stdout] | [INFO] [stdout] 19 | String::from_utf8_lossy(&result.stderr.split_last().unwrap().1).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `result.stderr.split_last().unwrap().1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:247:42 [INFO] [stdout] | [INFO] [stdout] 247 | pub fn checkout(&self, name: &String) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/git.rs:247:34 [INFO] [stdout] | [INFO] [stdout] 247 | pub fn checkout(&self, name: &String) -> () { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 247 ~ pub fn checkout(&self, name: &str) -> () { [INFO] [stdout] 248 ~ let result = exec(Command::new("git").arg("checkout").arg(name)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/git.rs:256:23 [INFO] [stdout] | [INFO] [stdout] 256 | pub fn pull(&self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git.rs:272:9 [INFO] [stdout] | [INFO] [stdout] 272 | return Err(String::from("Could not find current branch")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 272 - return Err(String::from("Could not find current branch")); [INFO] [stdout] 272 + Err(String::from("Could not find current branch")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git.rs:277:5 [INFO] [stdout] | [INFO] [stdout] 277 | return exec(Command::new("git").arg("branch").arg("--show-current")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - return exec(Command::new("git").arg("branch").arg("--show-current")); [INFO] [stdout] 277 + exec(Command::new("git").arg("branch").arg("--show-current")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git.rs:281:5 [INFO] [stdout] | [INFO] [stdout] 281 | / return Ok(exec(Command::new("git").arg("status").arg("--porcelain"))? [INFO] [stdout] 282 | | .lines() [INFO] [stdout] 283 | | .map(|line| line.trim()[2..].trim().to_string()) [INFO] [stdout] 284 | | .collect::>()); [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 281 ~ Ok(exec(Command::new("git").arg("status").arg("--porcelain"))? [INFO] [stdout] 282 + .lines() [INFO] [stdout] 283 + .map(|line| line.trim()[2..].trim().to_string()) [INFO] [stdout] 284 ~ .collect::>()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:11:3 [INFO] [stdout] | [INFO] [stdout] 11 | / return Ok(match result.stdout.is_empty() { [INFO] [stdout] 12 | | true => String::from(""), [INFO] [stdout] 13 | | false => { [INFO] [stdout] 14 | | String::from_utf8_lossy(&result.stdout.split_last().unwrap().1).to_string() [INFO] [stdout] 15 | | } [INFO] [stdout] 16 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 ~ Ok(match result.stdout.is_empty() { [INFO] [stdout] 12 ~ true => String::from(""), [INFO] [stdout] 13 ~ false => { [INFO] [stdout] 14 ~ String::from_utf8_lossy(&result.stdout.split_last().unwrap().1).to_string() [INFO] [stdout] 15 ~ } [INFO] [stdout] 16 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:18:3 [INFO] [stdout] | [INFO] [stdout] 18 | / return Err( [INFO] [stdout] 19 | | String::from_utf8_lossy(&result.stderr.split_last().unwrap().1).to_string(), [INFO] [stdout] 20 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 ~ Err( [INFO] [stdout] 19 ~ String::from_utf8_lossy(&result.stderr.split_last().unwrap().1).to_string(), [INFO] [stdout] 20 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:14:29 [INFO] [stdout] | [INFO] [stdout] 14 | String::from_utf8_lossy(&result.stdout.split_last().unwrap().1).to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `result.stdout.split_last().unwrap().1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:19:28 [INFO] [stdout] | [INFO] [stdout] 19 | String::from_utf8_lossy(&result.stderr.split_last().unwrap().1).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `result.stderr.split_last().unwrap().1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.05s [INFO] running `Command { std: "docker" "inspect" "ef6d3e37a337c66029d14540889995a16cb66c903db60d38395e0c7b34216c8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef6d3e37a337c66029d14540889995a16cb66c903db60d38395e0c7b34216c8a", kill_on_drop: false }` [INFO] [stdout] ef6d3e37a337c66029d14540889995a16cb66c903db60d38395e0c7b34216c8a