[INFO] cloning repository https://github.com/Jason5Lee/eight-puzzle-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Jason5Lee/eight-puzzle-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJason5Lee%2Feight-puzzle-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJason5Lee%2Feight-puzzle-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2000f14bed7f256bb7cdd7987f2e98fa8a66668c [INFO] linting Jason5Lee/eight-puzzle-rs/2000f14bed7f256bb7cdd7987f2e98fa8a66668c against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJason5Lee%2Feight-puzzle-rs" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Jason5Lee/eight-puzzle-rs [INFO] finished tweaking git repo https://github.com/Jason5Lee/eight-puzzle-rs [INFO] tweaked toml for git repo https://github.com/Jason5Lee/eight-puzzle-rs written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Jason5Lee/eight-puzzle-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 174 packages to latest compatible versions [INFO] [stderr] Adding env_logger v0.6.2 (available: v0.11.9) [INFO] [stderr] Adding permutator v0.3.3 (available: v0.4.3) [INFO] [stderr] Adding piston_window v0.98.0 (available: v0.146.0) [INFO] [stderr] Adding rand v0.6.5 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded piston-graphics_api_version v0.2.0 [INFO] [stderr] Downloaded pistoncore-window v0.43.0 [INFO] [stderr] Downloaded piston-viewport v1.0.2 [INFO] [stderr] Downloaded shader_version v0.6.0 [INFO] [stderr] Downloaded piston-float v1.0.1 [INFO] [stderr] Downloaded pistoncore-input v0.28.1 [INFO] [stderr] Downloaded glutin v0.19.0 [INFO] [stderr] Downloaded num v0.2.1 [INFO] [stderr] Downloaded find_folder v0.3.0 [INFO] [stderr] Downloaded env_logger v0.6.2 [INFO] [stderr] Downloaded gl_generator v0.9.0 [INFO] [stderr] Downloaded gfx_device_gl v0.15.5 [INFO] [stderr] Downloaded gfx_core v0.8.3 [INFO] [stderr] Downloaded gfx v0.17.1 [INFO] [stderr] Downloaded piston2d-graphics v0.32.0 [INFO] [stderr] Downloaded owning_ref v0.4.1 [INFO] [stderr] Downloaded permutator v0.3.3 [INFO] [stderr] Downloaded num-bigint v0.2.6 [INFO] [stderr] Downloaded cc v1.2.57 [INFO] [stderr] Downloaded smallvec v0.6.14 [INFO] [stderr] Downloaded ordered-float v1.1.1 [INFO] [stderr] Downloaded libloading v0.6.7 [INFO] [stderr] Downloaded winit v0.18.1 [INFO] [stderr] Downloaded gfx_gl v0.5.0 [INFO] [stderr] Downloaded pistoncore-event_loop v0.48.0 [INFO] [stderr] Downloaded piston-gfx_texture v0.36.0 [INFO] [stderr] Downloaded piston-texture v0.6.0 [INFO] [stderr] Downloaded piston2d-gfx_graphics v0.61.0 [INFO] [stderr] Downloaded eight-puzzle-core v1.0.0 [INFO] [stderr] Downloaded piston v0.48.0 [INFO] [stderr] Downloaded piston_window v0.98.0 [INFO] [stderr] Downloaded xdg v2.5.2 [INFO] [stderr] Downloaded pistoncore-glutin_window v0.61.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ed961c91ef3a5bc712ba165b5aecb7b8e741fe79900046c383489f3cec236307 [INFO] running `Command { std: "docker" "start" "-a" "ed961c91ef3a5bc712ba165b5aecb7b8e741fe79900046c383489f3cec236307", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ed961c91ef3a5bc712ba165b5aecb7b8e741fe79900046c383489f3cec236307", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed961c91ef3a5bc712ba165b5aecb7b8e741fe79900046c383489f3cec236307", kill_on_drop: false }` [INFO] [stdout] ed961c91ef3a5bc712ba165b5aecb7b8e741fe79900046c383489f3cec236307 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c5ae74e9cb6293bf36e8c217a91a0e0487b972467f0b2322fa8e2d34e8cc3bd7 [INFO] running `Command { std: "docker" "start" "-a" "c5ae74e9cb6293bf36e8c217a91a0e0487b972467f0b2322fa8e2d34e8cc3bd7", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling log v0.4.29 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Checking libloading v0.6.7 [INFO] [stderr] Checking stb_truetype v0.3.1 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Checking piston-float v1.0.1 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling wayland-scanner v0.21.13 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking dlib v0.4.2 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking wayland-sys v0.21.13 [INFO] [stderr] Compiling gl_generator v0.10.0 [INFO] [stderr] Checking piston-viewport v1.0.2 [INFO] [stderr] Compiling khronos_api v2.2.0 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Checking piston-graphics_api_version v0.2.0 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Checking xml-rs v0.8.28 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Checking piston-texture v0.6.0 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking shader_version v0.6.0 [INFO] [stderr] Checking vecmath v1.0.0 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking find_folder v0.3.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Checking line_drawing v0.7.0 [INFO] [stderr] Compiling glutin v0.19.0 [INFO] [stderr] Compiling gl v0.11.0 [INFO] [stderr] Compiling wayland-client v0.21.13 [INFO] [stderr] Compiling wayland-protocols v0.21.13 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking rusttype v0.8.3 [INFO] [stderr] Checking png v0.14.1 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Checking rusttype v0.7.9 [INFO] [stderr] Checking andrew v0.2.1 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking nix v0.14.1 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking piston2d-graphics v0.32.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking permutator v0.3.3 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking eight-puzzle-core v1.0.0 [INFO] [stderr] Checking eight-puzzle-core v1.0.0 (/opt/rustwide/workdir/eight-puzzle-core) [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> eight-puzzle-core/src/state.rs:113:35 [INFO] [stdout] | [INFO] [stdout] 113 | - arr.iter().take(i as usize).filter(|&&x| x < arr[i]).count() as u32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling derivative v1.0.4 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> eight-puzzle-core/src/state.rs:113:35 [INFO] [stdout] | [INFO] [stdout] 113 | - arr.iter().take(i as usize).filter(|&&x| x < arr[i]).count() as u32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking tiff v0.2.2 [INFO] [stderr] Checking wayland-commons v0.21.13 [INFO] [stderr] Checking image v0.21.3 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.5 [INFO] [stderr] Checking piston-gfx_texture v0.36.0 [INFO] [stderr] Checking pistoncore-input v0.28.1 [INFO] [stderr] Checking piston2d-gfx_graphics v0.61.0 [INFO] [stderr] Checking pistoncore-window v0.43.0 [INFO] [stderr] Checking pistoncore-event_loop v0.48.0 [INFO] [stderr] Checking piston v0.48.0 [INFO] [stderr] Checking smithay-client-toolkit v0.4.6 [INFO] [stderr] Checking winit v0.18.1 [INFO] [stderr] Checking pistoncore-glutin_window v0.61.0 [INFO] [stderr] Checking piston_window v0.98.0 [INFO] [stderr] Checking eight-puzzle v1.1.0 (/opt/rustwide/workdir/eight-puzzle) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Game` [INFO] [stdout] --> eight-puzzle/src/lib.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | / pub fn new() -> Game { [INFO] [stdout] 92 | | let mut window: PistonWindow = WindowSettings::new("Eight Puzzle", (640, 580)) [INFO] [stdout] 93 | | .build() [INFO] [stdout] 94 | | .unwrap_or_else(|e| panic!("Failed to build PistonWindow: {}", e)); [INFO] [stdout] ... | [INFO] [stdout] 121 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 90 + impl Default for Game { [INFO] [stdout] 91 + fn default() -> Self { [INFO] [stdout] 92 + Self::new() [INFO] [stdout] 93 + } [INFO] [stdout] 94 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `next` can be confused for the standard trait method `std::iter::Iterator::next` [INFO] [stdout] --> eight-puzzle/src/lib.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | / pub fn next(&mut self) -> Option<()> { [INFO] [stdout] 124 | | let Game { resource, status } = self; [INFO] [stdout] 125 | | debug!("{:?} status: {:?}.", Instant::now(), status); [INFO] [stdout] 126 | | resource [INFO] [stdout] ... | [INFO] [stdout] 137 | | .map(|new_status| *status = new_status) [INFO] [stdout] 138 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::iter::Iterator` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> eight-puzzle/src/lib.rs:208:5 [INFO] [stdout] | [INFO] [stdout] 208 | / fn draw_board( [INFO] [stdout] 209 | | glyphs: &mut Glyphs, [INFO] [stdout] 210 | | c: Context, [INFO] [stdout] 211 | | g: &mut G2d, [INFO] [stdout] ... | [INFO] [stdout] 216 | | font_size: types::FontSize, [INFO] [stdout] 217 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `arr` [INFO] [stdout] --> eight-puzzle/src/lib.rs:221:18 [INFO] [stdout] | [INFO] [stdout] 221 | for i in 0..9 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 221 - for i in 0..9 { [INFO] [stdout] 221 + for (i, ) in arr.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> eight-puzzle/src/lib.rs:287:44 [INFO] [stdout] | [INFO] [stdout] 287 | Game::draw_board(glyphs, c, g, &goal, 425.0, 225.0, 200.0, 50); [INFO] [stdout] | ^^^^^ help: change this to: `goal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Game` [INFO] [stdout] --> eight-puzzle/src/lib.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | / pub fn new() -> Game { [INFO] [stdout] 92 | | let mut window: PistonWindow = WindowSettings::new("Eight Puzzle", (640, 580)) [INFO] [stdout] 93 | | .build() [INFO] [stdout] 94 | | .unwrap_or_else(|e| panic!("Failed to build PistonWindow: {}", e)); [INFO] [stdout] ... | [INFO] [stdout] 121 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 90 + impl Default for Game { [INFO] [stdout] 91 + fn default() -> Self { [INFO] [stdout] 92 + Self::new() [INFO] [stdout] 93 + } [INFO] [stdout] 94 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `next` can be confused for the standard trait method `std::iter::Iterator::next` [INFO] [stdout] --> eight-puzzle/src/lib.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | / pub fn next(&mut self) -> Option<()> { [INFO] [stdout] 124 | | let Game { resource, status } = self; [INFO] [stdout] 125 | | debug!("{:?} status: {:?}.", Instant::now(), status); [INFO] [stdout] 126 | | resource [INFO] [stdout] ... | [INFO] [stdout] 137 | | .map(|new_status| *status = new_status) [INFO] [stdout] 138 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::iter::Iterator` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> eight-puzzle/src/lib.rs:208:5 [INFO] [stdout] | [INFO] [stdout] 208 | / fn draw_board( [INFO] [stdout] 209 | | glyphs: &mut Glyphs, [INFO] [stdout] 210 | | c: Context, [INFO] [stdout] 211 | | g: &mut G2d, [INFO] [stdout] ... | [INFO] [stdout] 216 | | font_size: types::FontSize, [INFO] [stdout] 217 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `arr` [INFO] [stdout] --> eight-puzzle/src/lib.rs:221:18 [INFO] [stdout] | [INFO] [stdout] 221 | for i in 0..9 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 221 - for i in 0..9 { [INFO] [stdout] 221 + for (i, ) in arr.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> eight-puzzle/src/lib.rs:287:44 [INFO] [stdout] | [INFO] [stdout] 287 | Game::draw_board(glyphs, c, g, &goal, 425.0, 225.0, 200.0, 50); [INFO] [stdout] | ^^^^^ help: change this to: `goal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 13s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: glutin v0.19.0, winit v0.18.1 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "c5ae74e9cb6293bf36e8c217a91a0e0487b972467f0b2322fa8e2d34e8cc3bd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5ae74e9cb6293bf36e8c217a91a0e0487b972467f0b2322fa8e2d34e8cc3bd7", kill_on_drop: false }` [INFO] [stdout] c5ae74e9cb6293bf36e8c217a91a0e0487b972467f0b2322fa8e2d34e8cc3bd7