[INFO] cloning repository https://github.com/JamesGuthrie/httpserve [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JamesGuthrie/httpserve" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJamesGuthrie%2Fhttpserve", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJamesGuthrie%2Fhttpserve'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 095c5d3f2e751e954db9359a01fd6288d66ed6e6 [INFO] linting JamesGuthrie/httpserve against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJamesGuthrie%2Fhttpserve" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/JamesGuthrie/httpserve [INFO] finished tweaking git repo https://github.com/JamesGuthrie/httpserve [INFO] tweaked toml for git repo https://github.com/JamesGuthrie/httpserve written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/JamesGuthrie/httpserve on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/JamesGuthrie/httpserve already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded parking_lot v0.11.1 [INFO] [stderr] Downloaded redox_syscall v0.2.9 [INFO] [stderr] Downloaded signal-hook-registry v1.4.0 [INFO] [stderr] Downloaded parking_lot_core v0.8.3 [INFO] [stderr] Downloaded hermit-abi v0.1.19 [INFO] [stderr] Downloaded strsim v0.8.0 [INFO] [stderr] Downloaded smallvec v1.6.1 [INFO] [stderr] Downloaded ansi_term v0.11.0 [INFO] [stderr] Downloaded time v0.1.44 [INFO] [stderr] Downloaded simplelog v0.10.0 [INFO] [stderr] Downloaded once_cell v1.8.0 [INFO] [stderr] Downloaded mio v0.7.13 [INFO] [stderr] Downloaded lock_api v0.4.4 [INFO] [stderr] Downloaded textwrap v0.11.0 [INFO] [stderr] Downloaded wasi v0.10.0+wasi-snapshot-preview1 [INFO] [stderr] Downloaded hyper v0.14.9 [INFO] [stderr] Downloaded instant v0.1.9 [INFO] [stderr] Downloaded clap v2.33.3 [INFO] [stderr] Downloaded tokio-macros v1.2.0 [INFO] [stderr] Downloaded syn v1.0.73 [INFO] [stderr] Downloaded tokio v1.7.1 [INFO] [stderr] Downloaded libc v0.2.97 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 86c82a571d8b30dede0ded6558e0d194c89c666abf2492257cd2f9b2d70c07a9 [INFO] running `Command { std: "docker" "start" "-a" "86c82a571d8b30dede0ded6558e0d194c89c666abf2492257cd2f9b2d70c07a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "86c82a571d8b30dede0ded6558e0d194c89c666abf2492257cd2f9b2d70c07a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86c82a571d8b30dede0ded6558e0d194c89c666abf2492257cd2f9b2d70c07a9", kill_on_drop: false }` [INFO] [stdout] 86c82a571d8b30dede0ded6558e0d194c89c666abf2492257cd2f9b2d70c07a9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cfcf927c2d87c47f537291cdadb76e15563cc4f1162a6a4496718f0faf1591d1 [INFO] running `Command { std: "docker" "start" "-a" "cfcf927c2d87c47f537291cdadb76e15563cc4f1162a6a4496718f0faf1591d1", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Checking pin-project-lite v0.2.6 [INFO] [stderr] Compiling futures-core v0.3.15 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Compiling futures-task v0.3.15 [INFO] [stderr] Compiling tokio v1.7.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling futures-util v0.3.15 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking tracing-core v0.1.18 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking http v0.2.4 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking futures-sink v0.3.15 [INFO] [stderr] Compiling httparse v1.4.1 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling futures-channel v0.3.15 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking tracing v0.1.26 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking slab v0.4.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking socket2 v0.4.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking httpdate v1.0.1 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking simplelog v0.10.0 [INFO] [stderr] Checking http-body v0.4.2 [INFO] [stderr] Compiling tokio-macros v1.2.0 [INFO] [stderr] Checking tokio-util v0.6.7 [INFO] [stderr] Checking h2 v0.3.3 [INFO] [stderr] Checking hyper v0.14.9 [INFO] [stderr] Checking httpserve v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | / return FileServer { [INFO] [stdout] 160 | | cache, [INFO] [stdout] 161 | | http_to_https_redirect, [INFO] [stdout] 162 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 ~ FileServer { [INFO] [stdout] 160 + cache, [INFO] [stdout] 161 + http_to_https_redirect, [INFO] [stdout] 162 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:134:15 [INFO] [stdout] | [INFO] [stdout] 134 | while to_visit.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!to_visit.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/main.rs:147:43 [INFO] [stdout] | [INFO] [stdout] 147 | ... .strip_prefix((*&dir).to_str().expect("Path not Unicode")) [INFO] [stdout] | ^^^^^^^ help: try: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] = note: `#[warn(clippy::deref_addrof)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | return Ok(response); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 199 - return Ok(response); [INFO] [stdout] 199 + Ok(response) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:182:21 [INFO] [stdout] | [INFO] [stdout] 182 | / return match maybe_body { [INFO] [stdout] 183 | | Some(body) => Response::builder() [INFO] [stdout] 184 | | .status(StatusCode::OK) [INFO] [stdout] 185 | | .body(Body::from(body.to_owned())) [INFO] [stdout] ... | [INFO] [stdout] 190 | | .expect("Unable to create `http::Response`"), [INFO] [stdout] 191 | | }; [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 182 ~ match maybe_body { [INFO] [stdout] 183 + Some(body) => Response::builder() [INFO] [stdout] 184 + .status(StatusCode::OK) [INFO] [stdout] 185 + .body(Body::from(body.to_owned())) [INFO] [stdout] 186 + .expect("Unable to create `http::Response`"), [INFO] [stdout] 187 + None => Response::builder() [INFO] [stdout] 188 + .status(StatusCode::NOT_FOUND) [INFO] [stdout] 189 + .body(Body::empty()) [INFO] [stdout] 190 + .expect("Unable to create `http::Response`"), [INFO] [stdout] 191 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:212:12 [INFO] [stdout] | [INFO] [stdout] 212 | if !fwd_proto.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `fwd_proto.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | / return Some( [INFO] [stdout] 242 | | Response::builder() [INFO] [stdout] 243 | | .status(StatusCode::MOVED_PERMANENTLY) [INFO] [stdout] 244 | | .header(LOCATION, https_request.to_string()) [INFO] [stdout] 245 | | .body(Body::empty()) [INFO] [stdout] 246 | | .expect("Unable to create https redirect"), [INFO] [stdout] 247 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 241 ~ Some( [INFO] [stdout] 242 + Response::builder() [INFO] [stdout] 243 + .status(StatusCode::MOVED_PERMANENTLY) [INFO] [stdout] 244 + .header(LOCATION, https_request.to_string()) [INFO] [stdout] 245 + .body(Body::empty()) [INFO] [stdout] 246 + .expect("Unable to create https redirect"), [INFO] [stdout] 247 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | / return FileServer { [INFO] [stdout] 160 | | cache, [INFO] [stdout] 161 | | http_to_https_redirect, [INFO] [stdout] 162 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 ~ FileServer { [INFO] [stdout] 160 + cache, [INFO] [stdout] 161 + http_to_https_redirect, [INFO] [stdout] 162 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:134:15 [INFO] [stdout] | [INFO] [stdout] 134 | while to_visit.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!to_visit.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/main.rs:147:43 [INFO] [stdout] | [INFO] [stdout] 147 | ... .strip_prefix((*&dir).to_str().expect("Path not Unicode")) [INFO] [stdout] | ^^^^^^^ help: try: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] = note: `#[warn(clippy::deref_addrof)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | return Ok(response); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 199 - return Ok(response); [INFO] [stdout] 199 + Ok(response) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:182:21 [INFO] [stdout] | [INFO] [stdout] 182 | / return match maybe_body { [INFO] [stdout] 183 | | Some(body) => Response::builder() [INFO] [stdout] 184 | | .status(StatusCode::OK) [INFO] [stdout] 185 | | .body(Body::from(body.to_owned())) [INFO] [stdout] ... | [INFO] [stdout] 190 | | .expect("Unable to create `http::Response`"), [INFO] [stdout] 191 | | }; [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 182 ~ match maybe_body { [INFO] [stdout] 183 + Some(body) => Response::builder() [INFO] [stdout] 184 + .status(StatusCode::OK) [INFO] [stdout] 185 + .body(Body::from(body.to_owned())) [INFO] [stdout] 186 + .expect("Unable to create `http::Response`"), [INFO] [stdout] 187 + None => Response::builder() [INFO] [stdout] 188 + .status(StatusCode::NOT_FOUND) [INFO] [stdout] 189 + .body(Body::empty()) [INFO] [stdout] 190 + .expect("Unable to create `http::Response`"), [INFO] [stdout] 191 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:212:12 [INFO] [stdout] | [INFO] [stdout] 212 | if !fwd_proto.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `fwd_proto.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | / return Some( [INFO] [stdout] 242 | | Response::builder() [INFO] [stdout] 243 | | .status(StatusCode::MOVED_PERMANENTLY) [INFO] [stdout] 244 | | .header(LOCATION, https_request.to_string()) [INFO] [stdout] 245 | | .body(Body::empty()) [INFO] [stdout] 246 | | .expect("Unable to create https redirect"), [INFO] [stdout] 247 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 241 ~ Some( [INFO] [stdout] 242 + Response::builder() [INFO] [stdout] 243 + .status(StatusCode::MOVED_PERMANENTLY) [INFO] [stdout] 244 + .header(LOCATION, https_request.to_string()) [INFO] [stdout] 245 + .body(Body::empty()) [INFO] [stdout] 246 + .expect("Unable to create https redirect"), [INFO] [stdout] 247 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.56s [INFO] running `Command { std: "docker" "inspect" "cfcf927c2d87c47f537291cdadb76e15563cc4f1162a6a4496718f0faf1591d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cfcf927c2d87c47f537291cdadb76e15563cc4f1162a6a4496718f0faf1591d1", kill_on_drop: false }` [INFO] [stdout] cfcf927c2d87c47f537291cdadb76e15563cc4f1162a6a4496718f0faf1591d1