[INFO] cloning repository https://github.com/JakRowan/roguelike
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JakRowan/roguelike" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJakRowan%2Froguelike", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJakRowan%2Froguelike'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 73cbedaf4822b98fa932a03d043acd2d99a65f8f
[INFO] linting JakRowan/roguelike against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJakRowan%2Froguelike" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/JakRowan/roguelike
[INFO] finished tweaking git repo https://github.com/JakRowan/roguelike
[INFO] tweaked toml for git repo https://github.com/JakRowan/roguelike written to /workspace/builds/worker-0-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/JakRowan/roguelike on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/JakRowan/roguelike already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded getrandom v0.1.13
[INFO] [stderr]   Downloaded wasi v0.7.0
[INFO] [stderr]   Downloaded cc v1.0.47
[INFO] [stderr]   Downloaded rand v0.7.2
[INFO] [stderr]   Downloaded libc v0.2.65
[INFO] [stderr]   Downloaded tcod v0.15.0
[INFO] [stderr]   Downloaded tcod-sys v5.0.1
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 10b09c23af9d69745d687e26577fa122aee00547a4397d447f29ee7ce6540abd
[INFO] running `Command { std: "docker" "start" "-a" "10b09c23af9d69745d687e26577fa122aee00547a4397d447f29ee7ce6540abd", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "10b09c23af9d69745d687e26577fa122aee00547a4397d447f29ee7ce6540abd", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "10b09c23af9d69745d687e26577fa122aee00547a4397d447f29ee7ce6540abd", kill_on_drop: false }`
[INFO] [stdout] 10b09c23af9d69745d687e26577fa122aee00547a4397d447f29ee7ce6540abd
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] ecdc87434b8983796036ce063c335149664f12a38b4ee128acc90c39fea34299
[INFO] running `Command { std: "docker" "start" "-a" "ecdc87434b8983796036ce063c335149664f12a38b4ee128acc90c39fea34299", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.65
[INFO] [stderr]    Compiling getrandom v0.1.13
[INFO] [stderr]    Compiling cc v1.0.47
[INFO] [stderr]    Compiling pkg-config v0.3.17
[INFO] [stderr]     Checking ppv-lite86 v0.2.6
[INFO] [stderr]     Checking bitflags v0.1.1
[INFO] [stderr]     Checking lazy_static v0.1.16
[INFO] [stderr]     Checking c2-chacha v0.2.3
[INFO] [stderr]    Compiling tcod-sys v5.0.1
[INFO] [stderr]     Checking rand_core v0.5.1
[INFO] [stderr]     Checking rand_chacha v0.2.1
[INFO] [stderr]     Checking rand v0.7.2
[INFO] [stderr]     Checking tcod v0.15.0
[INFO] [stderr]     Checking roguelike v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/graphics/mod.rs:32:66
[INFO] [stdout]    |
[INFO] [stdout] 32 | fn recompute_fov(game: &mut Game, fov_recompute: bool, entities: &Vec<Entity>) {
[INFO] [stdout]    |                                                                  ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 32 - fn recompute_fov(game: &mut Game, fov_recompute: bool, entities: &Vec<Entity>) {
[INFO] [stdout] 32 + fn recompute_fov(game: &mut Game, fov_recompute: bool, entities: &[Entity]) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/graphics/mod.rs:66:45
[INFO] [stdout]    |
[INFO] [stdout] 66 | fn draw_entities(game: &mut Game, entities: &Vec<Entity>) {
[INFO] [stdout]    |                                             ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 66 - fn draw_entities(game: &mut Game, entities: &Vec<Entity>) {
[INFO] [stdout] 66 + fn draw_entities(game: &mut Game, entities: &[Entity]) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]   --> src/graphics/mod.rs:71:5
[INFO] [stdout]    |
[INFO] [stdout] 71 |     to_draw.sort_by(|a, b| a.blocks.cmp(&b.blocks));
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_sort_by)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 71 -     to_draw.sort_by(|a, b| a.blocks.cmp(&b.blocks));
[INFO] [stdout] 71 +     to_draw.sort_by_key(|a| a.blocks);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `blit` doesn't need a mutable reference
[INFO] [stdout]   --> src/graphics/mod.rs:86:9
[INFO] [stdout]    |
[INFO] [stdout] 86 |         &mut game.tcod.hud,
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout] 86 -         &mut game.tcod.hud,
[INFO] [stdout] 86 +         &game.tcod.hud,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/graphics/mod.rs:95:43
[INFO] [stdout]    |
[INFO] [stdout] 95 |     fn draw_hp(game: &mut Game, entities: &Vec<Entity>) {
[INFO] [stdout]    |                                           ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 95 -     fn draw_hp(game: &mut Game, entities: &Vec<Entity>) {
[INFO] [stdout] 95 +     fn draw_hp(game: &mut Game, entities: &[Entity]) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> src/graphics/mod.rs:132:1
[INFO] [stdout]     |
[INFO] [stdout] 132 | / fn draw_bar(
[INFO] [stdout] 133 | |     hud: &mut Offscreen,
[INFO] [stdout] 134 | |     Point { x, y }: Point,
[INFO] [stdout] 135 | |     total_width: i32,
[INFO] [stdout] ...   |
[INFO] [stdout] 140 | |     back_color: Color,
[INFO] [stdout] 141 | | ) {
[INFO] [stdout]     | |_^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]     = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/graphics/mod.rs:158:9
[INFO] [stdout]     |
[INFO] [stdout] 158 |         &format!("{}: {}/{}", name, value, maximum),
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}: {}/{}", name, value, maximum)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/input/mod.rs:47:45
[INFO] [stdout]    |
[INFO] [stdout] 47 |         (Key { code: Escape, .. }, _, _) => return PlayerAction::Exit,
[INFO] [stdout]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 47 -         (Key { code: Escape, .. }, _, _) => return PlayerAction::Exit,
[INFO] [stdout] 47 +         (Key { code: Escape, .. }, _, _) => PlayerAction::Exit,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: module has the same name as its containing module
[INFO] [stdout]  --> src/map/mod.rs:2:1
[INFO] [stdout]   |
[INFO] [stdout] 2 | mod map;
[INFO] [stdout]   | ^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stdout]   = note: `#[warn(clippy::module_inception)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/map/map.rs:80:59
[INFO] [stdout]    |
[INFO] [stdout] 80 |     pub fn is_blocked_tile(&self, point: Point, entities: &Vec<Entity>) -> bool {
[INFO] [stdout]    |                                                           ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 80 -     pub fn is_blocked_tile(&self, point: Point, entities: &Vec<Entity>) -> bool {
[INFO] [stdout] 80 +     pub fn is_blocked_tile(&self, point: Point, entities: &[Entity]) -> bool {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/map/map.rs:94:9
[INFO] [stdout]    |
[INFO] [stdout] 94 |         !(self.tile_idx(x, y) < self.0.len())
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.tile_idx(x, y) >= self.0.len())`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Messages`
[INFO] [stdout]   --> src/messages/mod.rs:8:5
[INFO] [stdout]    |
[INFO] [stdout]  8 | /     pub fn new() -> Self {
[INFO] [stdout]  9 | |         Messages { messages: vec![] }
[INFO] [stdout] 10 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout]  7 + impl Default for Messages {
[INFO] [stdout]  8 +     fn default() -> Self {
[INFO] [stdout]  9 +         Self::new()
[INFO] [stdout] 10 +     }
[INFO] [stdout] 11 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]   --> src/systems/mod.rs:11:27
[INFO] [stdout]    |
[INFO] [stdout] 11 |         distance < 2.0 && player.fighter.map_or(false, |f| f.hp > 0)
[INFO] [stdout]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_map_or)]` on by default
[INFO] [stdout] help: use `is_some_and` instead
[INFO] [stdout]    |
[INFO] [stdout] 11 -         distance < 2.0 && player.fighter.map_or(false, |f| f.hp > 0)
[INFO] [stdout] 11 +         distance < 2.0 && player.fighter.is_some_and(|f| f.hp > 0)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/graphics/mod.rs:32:66
[INFO] [stdout]    |
[INFO] [stdout] 32 | fn recompute_fov(game: &mut Game, fov_recompute: bool, entities: &Vec<Entity>) {
[INFO] [stdout]    |                                                                  ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 32 - fn recompute_fov(game: &mut Game, fov_recompute: bool, entities: &Vec<Entity>) {
[INFO] [stdout] 32 + fn recompute_fov(game: &mut Game, fov_recompute: bool, entities: &[Entity]) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/graphics/mod.rs:66:45
[INFO] [stdout]    |
[INFO] [stdout] 66 | fn draw_entities(game: &mut Game, entities: &Vec<Entity>) {
[INFO] [stdout]    |                                             ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 66 - fn draw_entities(game: &mut Game, entities: &Vec<Entity>) {
[INFO] [stdout] 66 + fn draw_entities(game: &mut Game, entities: &[Entity]) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]   --> src/graphics/mod.rs:71:5
[INFO] [stdout]    |
[INFO] [stdout] 71 |     to_draw.sort_by(|a, b| a.blocks.cmp(&b.blocks));
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_sort_by)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 71 -     to_draw.sort_by(|a, b| a.blocks.cmp(&b.blocks));
[INFO] [stdout] 71 +     to_draw.sort_by_key(|a| a.blocks);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `blit` doesn't need a mutable reference
[INFO] [stdout]   --> src/graphics/mod.rs:86:9
[INFO] [stdout]    |
[INFO] [stdout] 86 |         &mut game.tcod.hud,
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout] 86 -         &mut game.tcod.hud,
[INFO] [stdout] 86 +         &game.tcod.hud,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/graphics/mod.rs:95:43
[INFO] [stdout]    |
[INFO] [stdout] 95 |     fn draw_hp(game: &mut Game, entities: &Vec<Entity>) {
[INFO] [stdout]    |                                           ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 95 -     fn draw_hp(game: &mut Game, entities: &Vec<Entity>) {
[INFO] [stdout] 95 +     fn draw_hp(game: &mut Game, entities: &[Entity]) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> src/graphics/mod.rs:132:1
[INFO] [stdout]     |
[INFO] [stdout] 132 | / fn draw_bar(
[INFO] [stdout] 133 | |     hud: &mut Offscreen,
[INFO] [stdout] 134 | |     Point { x, y }: Point,
[INFO] [stdout] 135 | |     total_width: i32,
[INFO] [stdout] ...   |
[INFO] [stdout] 140 | |     back_color: Color,
[INFO] [stdout] 141 | | ) {
[INFO] [stdout]     | |_^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]     = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/graphics/mod.rs:158:9
[INFO] [stdout]     |
[INFO] [stdout] 158 |         &format!("{}: {}/{}", name, value, maximum),
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}: {}/{}", name, value, maximum)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/input/mod.rs:47:45
[INFO] [stdout]    |
[INFO] [stdout] 47 |         (Key { code: Escape, .. }, _, _) => return PlayerAction::Exit,
[INFO] [stdout]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 47 -         (Key { code: Escape, .. }, _, _) => return PlayerAction::Exit,
[INFO] [stdout] 47 +         (Key { code: Escape, .. }, _, _) => PlayerAction::Exit,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: module has the same name as its containing module
[INFO] [stdout]  --> src/map/mod.rs:2:1
[INFO] [stdout]   |
[INFO] [stdout] 2 | mod map;
[INFO] [stdout]   | ^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stdout]   = note: `#[warn(clippy::module_inception)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/map/map.rs:80:59
[INFO] [stdout]    |
[INFO] [stdout] 80 |     pub fn is_blocked_tile(&self, point: Point, entities: &Vec<Entity>) -> bool {
[INFO] [stdout]    |                                                           ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 80 -     pub fn is_blocked_tile(&self, point: Point, entities: &Vec<Entity>) -> bool {
[INFO] [stdout] 80 +     pub fn is_blocked_tile(&self, point: Point, entities: &[Entity]) -> bool {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/map/map.rs:94:9
[INFO] [stdout]    |
[INFO] [stdout] 94 |         !(self.tile_idx(x, y) < self.0.len())
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.tile_idx(x, y) >= self.0.len())`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Messages`
[INFO] [stdout]   --> src/messages/mod.rs:8:5
[INFO] [stdout]    |
[INFO] [stdout]  8 | /     pub fn new() -> Self {
[INFO] [stdout]  9 | |         Messages { messages: vec![] }
[INFO] [stdout] 10 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout]  7 + impl Default for Messages {
[INFO] [stdout]  8 +     fn default() -> Self {
[INFO] [stdout]  9 +         Self::new()
[INFO] [stdout] 10 +     }
[INFO] [stdout] 11 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]   --> src/systems/mod.rs:11:27
[INFO] [stdout]    |
[INFO] [stdout] 11 |         distance < 2.0 && player.fighter.map_or(false, |f| f.hp > 0)
[INFO] [stdout]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_map_or)]` on by default
[INFO] [stdout] help: use `is_some_and` instead
[INFO] [stdout]    |
[INFO] [stdout] 11 -         distance < 2.0 && player.fighter.map_or(false, |f| f.hp > 0)
[INFO] [stdout] 11 +         distance < 2.0 && player.fighter.is_some_and(|f| f.hp > 0)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.67s
[INFO] running `Command { std: "docker" "inspect" "ecdc87434b8983796036ce063c335149664f12a38b4ee128acc90c39fea34299", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "ecdc87434b8983796036ce063c335149664f12a38b4ee128acc90c39fea34299", kill_on_drop: false }`
[INFO] [stdout] ecdc87434b8983796036ce063c335149664f12a38b4ee128acc90c39fea34299