[INFO] cloning repository https://github.com/JacksonGuy/craig [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JacksonGuy/craig" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJacksonGuy%2Fcraig", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJacksonGuy%2Fcraig'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6f65bad503fbaba5d7428d4f00fa1242685b11ab [INFO] linting JacksonGuy/craig/6f65bad503fbaba5d7428d4f00fa1242685b11ab against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJacksonGuy%2Fcraig" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/JacksonGuy/craig [INFO] finished tweaking git repo https://github.com/JacksonGuy/craig [INFO] tweaked toml for git repo https://github.com/JacksonGuy/craig written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/JacksonGuy/craig on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/JacksonGuy/craig already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded itoa v1.0.16 [INFO] [stderr] Downloaded rustls-pki-types v1.13.2 [INFO] [stderr] Downloaded darwin-libproc-sys v0.2.0 [INFO] [stderr] Downloaded signal-hook-registry v1.4.7 [INFO] [stderr] Downloaded derive_more v1.0.0 [INFO] [stderr] Downloaded ureq-proto v0.5.3 [INFO] [stderr] Downloaded cc v1.2.50 [INFO] [stderr] Downloaded ureq v3.1.4 [INFO] [stderr] Downloaded derive_more-impl v1.0.0 [INFO] [stderr] Downloaded serde_json v1.0.147 [INFO] [stderr] Downloaded platforms v3.7.0 [INFO] [stderr] Downloaded psutil v5.4.0 [INFO] [stderr] Downloaded ryu v1.0.21 [INFO] [stderr] Downloaded cookie_store v0.22.0 [INFO] [stderr] Downloaded zmij v0.1.7 [INFO] [stderr] Downloaded instability v0.3.10 [INFO] [stderr] Downloaded size v0.5.0 [INFO] [stderr] Downloaded memchr v2.3.4 [INFO] [stderr] Downloaded darwin-libproc v0.2.0 [INFO] [stderr] Downloaded unescape v0.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bd1b22077e6610220f319b39ca41474e72777ea587f85ffb4cd2c2420ddaafc0 [INFO] running `Command { std: "docker" "start" "-a" "bd1b22077e6610220f319b39ca41474e72777ea587f85ffb4cd2c2420ddaafc0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bd1b22077e6610220f319b39ca41474e72777ea587f85ffb4cd2c2420ddaafc0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd1b22077e6610220f319b39ca41474e72777ea587f85ffb4cd2c2420ddaafc0", kill_on_drop: false }` [INFO] [stdout] bd1b22077e6610220f319b39ca41474e72777ea587f85ffb4cd2c2420ddaafc0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f46cb76e64df2a6afa5ba2226b0bd17c732be78e03ae58609623a115989a0c8b [INFO] running `Command { std: "docker" "start" "-a" "f46cb76e64df2a6afa5ba2226b0bd17c732be78e03ae58609623a115989a0c8b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling find-msvc-tools v0.1.5 [INFO] [stderr] Compiling rustversion v1.0.22 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Checking itoa v1.0.16 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking allocator-api2 v0.2.21 [INFO] [stderr] Compiling cc v1.2.50 [INFO] [stderr] Compiling serde_json v1.0.147 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Compiling rustls v0.23.35 [INFO] [stderr] Compiling instability v0.3.10 [INFO] [stderr] Checking rustls-pki-types v1.13.2 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking ryu v1.0.21 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling litrs v1.0.0 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking zmij v0.1.7 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Compiling indoc v2.0.7 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking glob v0.3.3 [INFO] [stderr] Checking webpki-roots v1.0.4 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking platforms v3.7.0 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Checking unescape v0.1.0 [INFO] [stderr] Checking size v0.5.0 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking ureq-proto v0.5.3 [INFO] [stderr] Compiling document-features v0.2.12 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking psutil v5.4.0 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking ureq v3.1.4 [INFO] [stderr] Checking Craig v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/core/app.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BLUE` and `GREEN` [INFO] [stdout] --> src/core/app.rs:10:29 [INFO] [stdout] | [INFO] [stdout] 10 | palette::tailwind::{BLUE, GREEN, SLATE}, [INFO] [stdout] | ^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/core/server.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use serde::{Serialize, Deserialize}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/core/app.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BLUE` and `GREEN` [INFO] [stdout] --> src/core/app.rs:10:29 [INFO] [stdout] | [INFO] [stdout] 10 | palette::tailwind::{BLUE, GREEN, SLATE}, [INFO] [stdout] | ^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/core/server.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use serde::{Serialize, Deserialize}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPUData` [INFO] [stdout] --> src/core/cpu.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / pub fn new() -> Self { [INFO] [stdout] 11 | | Self { [INFO] [stdout] 12 | | collector: psutil::cpu::CpuPercentCollector::new().unwrap(), [INFO] [stdout] 13 | | cpu_count: psutil::cpu::cpu_count(), [INFO] [stdout] ... | [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 9 + impl Default for CPUData { [INFO] [stdout] 10 + fn default() -> Self { [INFO] [stdout] 11 + Self::new() [INFO] [stdout] 12 + } [INFO] [stdout] 13 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MemData` [INFO] [stdout] --> src/core/mem.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / pub fn new() -> Self { [INFO] [stdout] 8 | | Self {} [INFO] [stdout] 9 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 6 + impl Default for MemData { [INFO] [stdout] 7 + fn default() -> Self { [INFO] [stdout] 8 + Self::new() [INFO] [stdout] 9 + } [INFO] [stdout] 10 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `App` [INFO] [stdout] --> src/core/app.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | / pub fn new() -> Self { [INFO] [stdout] 64 | | Self { [INFO] [stdout] 65 | | cpu_data: CPUData::new(), [INFO] [stdout] 66 | | mem_data: MemData::new(), [INFO] [stdout] ... | [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 62 + impl Default for App { [INFO] [stdout] 63 + fn default() -> Self { [INFO] [stdout] 64 + Self::new() [INFO] [stdout] 65 + } [INFO] [stdout] 66 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/app.rs:82:55 [INFO] [stdout] | [INFO] [stdout] 82 | let state: ServerState = ServerState::new(&ip); [INFO] [stdout] | ^^^ help: change this to: `ip` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/app.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | / if event::poll(Duration::from_millis(16))? { [INFO] [stdout] 121 | | if let Event::Key(key) = event::read()? { [INFO] [stdout] 122 | | if key.kind == KeyEventKind::Press { [INFO] [stdout] 123 | | match key.code { [INFO] [stdout] ... | [INFO] [stdout] 131 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 120 ~ if event::poll(Duration::from_millis(16))? [INFO] [stdout] 121 ~ && let Event::Key(key) = event::read()? { [INFO] [stdout] 122 | if key.kind == KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 129 | } [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/app.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | / if let Event::Key(key) = event::read()? { [INFO] [stdout] 122 | | if key.kind == KeyEventKind::Press { [INFO] [stdout] 123 | | match key.code { [INFO] [stdout] 124 | | KeyCode::Char('q') => self.should_exit = true, [INFO] [stdout] ... | [INFO] [stdout] 130 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 121 ~ if let Event::Key(key) = event::read()? [INFO] [stdout] 122 ~ && key.kind == KeyEventKind::Press { [INFO] [stdout] 123 | match key.code { [INFO] [stdout] ... [INFO] [stdout] 128 | } [INFO] [stdout] 129 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/core/app.rs:187:21 [INFO] [stdout] | [INFO] [stdout] 187 | let index = match self.list_state.selected() { [INFO] [stdout] | _____________________^ [INFO] [stdout] 188 | | Some(i) => i, [INFO] [stdout] 189 | | None => 0, [INFO] [stdout] 190 | | }; [INFO] [stdout] | |_________^ help: replace it with: `self.list_state.selected().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `cpu_usage` [INFO] [stdout] --> src/core/app.rs:245:18 [INFO] [stdout] | [INFO] [stdout] 245 | for i in 0..cpu_usage.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 245 - for i in 0..cpu_usage.len() { [INFO] [stdout] 245 + for (i, ) in cpu_usage.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/core/app.rs:186:23 [INFO] [stdout] | [INFO] [stdout] 186 | fn server_details(&mut self) -> Paragraph { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 186 | fn server_details(&mut self) -> Paragraph<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/core/app.rs:216:20 [INFO] [stdout] | [INFO] [stdout] 216 | fn player_list(&mut self) -> List { [INFO] [stdout] | ^^^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 216 | fn player_list(&mut self) -> List<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/core/app.rs:240:18 [INFO] [stdout] | [INFO] [stdout] 240 | fn cpu_chart(&mut self) -> BarChart { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 240 | fn cpu_chart(&mut self) -> BarChart<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/core/app.rs:281:23 [INFO] [stdout] | [INFO] [stdout] 281 | fn horizontal_bar(&self, label: String, value: f32) -> Bar { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 281 | fn horizontal_bar(&self, label: String, value: f32) -> Bar<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPUData` [INFO] [stdout] --> src/core/cpu.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / pub fn new() -> Self { [INFO] [stdout] 11 | | Self { [INFO] [stdout] 12 | | collector: psutil::cpu::CpuPercentCollector::new().unwrap(), [INFO] [stdout] 13 | | cpu_count: psutil::cpu::cpu_count(), [INFO] [stdout] ... | [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 9 + impl Default for CPUData { [INFO] [stdout] 10 + fn default() -> Self { [INFO] [stdout] 11 + Self::new() [INFO] [stdout] 12 + } [INFO] [stdout] 13 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MemData` [INFO] [stdout] --> src/core/mem.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / pub fn new() -> Self { [INFO] [stdout] 8 | | Self {} [INFO] [stdout] 9 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 6 + impl Default for MemData { [INFO] [stdout] 7 + fn default() -> Self { [INFO] [stdout] 8 + Self::new() [INFO] [stdout] 9 + } [INFO] [stdout] 10 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `App` [INFO] [stdout] --> src/core/app.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | / pub fn new() -> Self { [INFO] [stdout] 64 | | Self { [INFO] [stdout] 65 | | cpu_data: CPUData::new(), [INFO] [stdout] 66 | | mem_data: MemData::new(), [INFO] [stdout] ... | [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 62 + impl Default for App { [INFO] [stdout] 63 + fn default() -> Self { [INFO] [stdout] 64 + Self::new() [INFO] [stdout] 65 + } [INFO] [stdout] 66 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/app.rs:82:55 [INFO] [stdout] | [INFO] [stdout] 82 | let state: ServerState = ServerState::new(&ip); [INFO] [stdout] | ^^^ help: change this to: `ip` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/app.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | / if event::poll(Duration::from_millis(16))? { [INFO] [stdout] 121 | | if let Event::Key(key) = event::read()? { [INFO] [stdout] 122 | | if key.kind == KeyEventKind::Press { [INFO] [stdout] 123 | | match key.code { [INFO] [stdout] ... | [INFO] [stdout] 131 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 120 ~ if event::poll(Duration::from_millis(16))? [INFO] [stdout] 121 ~ && let Event::Key(key) = event::read()? { [INFO] [stdout] 122 | if key.kind == KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 129 | } [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/app.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | / if let Event::Key(key) = event::read()? { [INFO] [stdout] 122 | | if key.kind == KeyEventKind::Press { [INFO] [stdout] 123 | | match key.code { [INFO] [stdout] 124 | | KeyCode::Char('q') => self.should_exit = true, [INFO] [stdout] ... | [INFO] [stdout] 130 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 121 ~ if let Event::Key(key) = event::read()? [INFO] [stdout] 122 ~ && key.kind == KeyEventKind::Press { [INFO] [stdout] 123 | match key.code { [INFO] [stdout] ... [INFO] [stdout] 128 | } [INFO] [stdout] 129 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/core/app.rs:187:21 [INFO] [stdout] | [INFO] [stdout] 187 | let index = match self.list_state.selected() { [INFO] [stdout] | _____________________^ [INFO] [stdout] 188 | | Some(i) => i, [INFO] [stdout] 189 | | None => 0, [INFO] [stdout] 190 | | }; [INFO] [stdout] | |_________^ help: replace it with: `self.list_state.selected().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `cpu_usage` [INFO] [stdout] --> src/core/app.rs:245:18 [INFO] [stdout] | [INFO] [stdout] 245 | for i in 0..cpu_usage.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 245 - for i in 0..cpu_usage.len() { [INFO] [stdout] 245 + for (i, ) in cpu_usage.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/core/app.rs:186:23 [INFO] [stdout] | [INFO] [stdout] 186 | fn server_details(&mut self) -> Paragraph { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 186 | fn server_details(&mut self) -> Paragraph<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/core/app.rs:216:20 [INFO] [stdout] | [INFO] [stdout] 216 | fn player_list(&mut self) -> List { [INFO] [stdout] | ^^^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 216 | fn player_list(&mut self) -> List<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/core/app.rs:240:18 [INFO] [stdout] | [INFO] [stdout] 240 | fn cpu_chart(&mut self) -> BarChart { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 240 | fn cpu_chart(&mut self) -> BarChart<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/core/app.rs:281:23 [INFO] [stdout] | [INFO] [stdout] 281 | fn horizontal_bar(&self, label: String, value: f32) -> Bar { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 281 | fn horizontal_bar(&self, label: String, value: f32) -> Bar<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.40s [INFO] running `Command { std: "docker" "inspect" "f46cb76e64df2a6afa5ba2226b0bd17c732be78e03ae58609623a115989a0c8b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f46cb76e64df2a6afa5ba2226b0bd17c732be78e03ae58609623a115989a0c8b", kill_on_drop: false }` [INFO] [stdout] f46cb76e64df2a6afa5ba2226b0bd17c732be78e03ae58609623a115989a0c8b