[INFO] cloning repository https://github.com/Jachdich/aster-cli [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Jachdich/aster-cli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJachdich%2Faster-cli", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJachdich%2Faster-cli'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5832905ef8c7b08ba7497207517848e1137c5fae [INFO] linting Jachdich/aster-cli against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJachdich%2Faster-cli" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Jachdich/aster-cli [INFO] finished tweaking git repo https://github.com/Jachdich/aster-cli [INFO] tweaked toml for git repo https://github.com/Jachdich/aster-cli written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Jachdich/aster-cli on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Jachdich/aster-cli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/Jachdich/dct-tiv` [INFO] [stderr] Updating git repository `https://github.com/Jachdich/fmtstring` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tokio-macros v2.3.0 [INFO] [stderr] Downloaded miniz_oxide v0.7.4 [INFO] [stderr] Downloaded bytes v1.6.0 [INFO] [stderr] Downloaded redox_syscall v0.5.2 [INFO] [stderr] Downloaded angular-units v0.2.4 [INFO] [stderr] Downloaded thiserror v1.0.61 [INFO] [stderr] Downloaded approx v0.3.2 [INFO] [stderr] Downloaded rgb v0.8.40 [INFO] [stderr] Downloaded termion v1.5.6 [INFO] [stderr] Downloaded futures-executor v0.3.30 [INFO] [stderr] Downloaded bytemuck v1.16.1 [INFO] [stderr] Downloaded flume v0.11.0 [INFO] [stderr] Downloaded serde v1.0.203 [INFO] [stderr] Downloaded prisma v0.1.1 [INFO] [stderr] Downloaded dbus v0.9.7 [INFO] [stderr] Downloaded serde_json v1.0.120 [INFO] [stderr] Downloaded security-framework v2.11.0 [INFO] [stderr] Downloaded quick-xml v0.31.0 [INFO] [stderr] Downloaded cc v1.0.104 [INFO] [stderr] Downloaded notify-rust v4.11.0 [INFO] [stderr] Downloaded chrono v0.4.39 [INFO] [stderr] Downloaded exr v1.72.0 [INFO] [stderr] Downloaded regex v1.10.5 [INFO] [stderr] Downloaded syn v2.0.68 [INFO] [stderr] Downloaded object v0.36.1 [INFO] [stderr] Downloaded openssl v0.10.64 [INFO] [stderr] Downloaded regex-syntax v0.8.4 [INFO] [stderr] Downloaded rustix v0.38.34 [INFO] [stderr] Downloaded gimli v0.29.0 [INFO] [stderr] Downloaded serde_derive v1.0.203 [INFO] [stderr] Downloaded openssl-sys v0.9.102 [INFO] [stderr] Downloaded schannel v0.1.23 [INFO] [stderr] Downloaded tempfile v3.10.1 [INFO] [stderr] Downloaded tokio-stream v0.1.15 [INFO] [stderr] Downloaded addr2line v0.22.0 [INFO] [stderr] Downloaded backtrace v0.3.73 [INFO] [stderr] Downloaded windows-core v0.56.0 [INFO] [stderr] Downloaded security-framework-sys v2.11.0 [INFO] [stderr] Downloaded futures-macro v0.3.30 [INFO] [stderr] Downloaded tokio-util v0.7.11 [INFO] [stderr] Downloaded regex-automata v0.4.7 [INFO] [stderr] Downloaded futures v0.3.30 [INFO] [stderr] Downloaded windows-version v0.1.1 [INFO] [stderr] Downloaded tauri-winrt-notification v0.2.1 [INFO] [stderr] Downloaded fastrand v2.1.0 [INFO] [stderr] Downloaded dirs v5.0.1 [INFO] [stderr] Downloaded tokio v1.38.0 [INFO] [stderr] Downloaded oklab v1.0.1 [INFO] [stderr] Downloaded thiserror-impl v1.0.61 [INFO] [stderr] Downloaded mac-notification-sys v0.6.1 [INFO] [stderr] Downloaded windows-implement v0.56.0 [INFO] [stderr] Downloaded windows-interface v0.56.0 [INFO] [stderr] Downloaded numtoa v0.1.0 [INFO] [stderr] Downloaded redox_termios v0.1.3 [INFO] [stderr] Downloaded termion v4.0.2 [INFO] [stderr] Downloaded libdbus-sys v0.2.5 [INFO] [stderr] Downloaded windows v0.56.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dae222043eb8d5c80755c0598a14322bd86e9db1a6bb7285a215e41813978c52 [INFO] running `Command { std: "docker" "start" "-a" "dae222043eb8d5c80755c0598a14322bd86e9db1a6bb7285a215e41813978c52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dae222043eb8d5c80755c0598a14322bd86e9db1a6bb7285a215e41813978c52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dae222043eb8d5c80755c0598a14322bd86e9db1a6bb7285a215e41813978c52", kill_on_drop: false }` [INFO] [stdout] dae222043eb8d5c80755c0598a14322bd86e9db1a6bb7285a215e41813978c52 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 19d587650051634616489e973863cd832489e57b1c664ee74a9ca5d3e79537d7 [INFO] running `Command { std: "docker" "start" "-a" "19d587650051634616489e973863cd832489e57b1c664ee74a9ca5d3e79537d7", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling cc v1.0.104 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking bytemuck v1.16.1 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling libdbus-sys v0.2.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking rgb v0.8.40 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking exr v1.72.0 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking oklab v1.0.1 [INFO] [stderr] Checking termion v1.5.6 [INFO] [stderr] Checking angular-units v0.2.4 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking prisma v0.1.1 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking fmtstring v0.1.0 (https://github.com/Jachdich/fmtstring#e6ea3af1) [INFO] [stderr] Checking dbus v0.9.7 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking chrono v0.4.39 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking termion v4.0.2 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Checking notify-rust v4.11.0 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking dct-tiv v0.1.0 (https://github.com/Jachdich/dct-tiv#a29effee) [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking cli v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/drawing.rs:282:12 [INFO] [stdout] | [INFO] [stdout] 282 | if list_height % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `list_height.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/events.rs:114:21 [INFO] [stdout] | [INFO] [stdout] 114 | / if *curr_server > 0 { [INFO] [stdout] 115 | | *curr_server -= 1; [INFO] [stdout] 116 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 113 ~ Event::Key(Key::Up) [INFO] [stdout] 114 ~ if *curr_server > 0 => { [INFO] [stdout] 115 | *curr_server -= 1; [INFO] [stdout] 116 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/events.rs:120:21 [INFO] [stdout] | [INFO] [stdout] 120 | / if *curr_server < self.servers.len() - 1 { [INFO] [stdout] 121 | | *curr_server += 1; [INFO] [stdout] 122 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 119 ~ Event::Key(Key::Down) [INFO] [stdout] 120 ~ if *curr_server < self.servers.len() - 1 => { [INFO] [stdout] 121 | *curr_server += 1; [INFO] [stdout] 122 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/events.rs:184:52 [INFO] [stdout] | [INFO] [stdout] 184 | if idx < net.channels.len() && !net.curr_channel.is_some_and(|c| c == idx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `net.curr_channel.is_none_or(|c| c != idx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `bytes` [INFO] [stdout] --> src/prompt.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | self.data.bytes().len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.data.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] = note: `#[warn(clippy::needless_as_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/server.rs:239:16 [INFO] [stdout] | [INFO] [stdout] 239 | if let Err(_) = res { [INFO] [stdout] | -------^^^^^^------ help: try: `if res.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/server.rs:307:23 [INFO] [stdout] | [INFO] [stdout] 307 | pub fn to_offline(&mut self, offline_reason: String) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/main.rs:221:32 [INFO] [stdout] | [INFO] [stdout] 221 | return Err(Error::new( [INFO] [stdout] | ________________________________^ [INFO] [stdout] 222 | | ErrorKind::Other, [INFO] [stdout] 223 | | format!( [INFO] [stdout] 224 | | "Unexpected result from the server: {}: {}", [INFO] [stdout] ... | [INFO] [stdout] 227 | | ), [INFO] [stdout] 228 | | )); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 221 ~ return Err(Error::other( [INFO] [stdout] 222 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:470:21 [INFO] [stdout] | [INFO] [stdout] 470 | cancel_tx.send(()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 470 | let _ = cancel_tx.send(()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/drawing.rs:282:12 [INFO] [stdout] | [INFO] [stdout] 282 | if list_height % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `list_height.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/events.rs:114:21 [INFO] [stdout] | [INFO] [stdout] 114 | / if *curr_server > 0 { [INFO] [stdout] 115 | | *curr_server -= 1; [INFO] [stdout] 116 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 113 ~ Event::Key(Key::Up) [INFO] [stdout] 114 ~ if *curr_server > 0 => { [INFO] [stdout] 115 | *curr_server -= 1; [INFO] [stdout] 116 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/events.rs:120:21 [INFO] [stdout] | [INFO] [stdout] 120 | / if *curr_server < self.servers.len() - 1 { [INFO] [stdout] 121 | | *curr_server += 1; [INFO] [stdout] 122 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 119 ~ Event::Key(Key::Down) [INFO] [stdout] 120 ~ if *curr_server < self.servers.len() - 1 => { [INFO] [stdout] 121 | *curr_server += 1; [INFO] [stdout] 122 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/events.rs:184:52 [INFO] [stdout] | [INFO] [stdout] 184 | if idx < net.channels.len() && !net.curr_channel.is_some_and(|c| c == idx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `net.curr_channel.is_none_or(|c| c != idx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `bytes` [INFO] [stdout] --> src/prompt.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | self.data.bytes().len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.data.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] = note: `#[warn(clippy::needless_as_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/server.rs:239:16 [INFO] [stdout] | [INFO] [stdout] 239 | if let Err(_) = res { [INFO] [stdout] | -------^^^^^^------ help: try: `if res.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/server.rs:307:23 [INFO] [stdout] | [INFO] [stdout] 307 | pub fn to_offline(&mut self, offline_reason: String) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/main.rs:221:32 [INFO] [stdout] | [INFO] [stdout] 221 | return Err(Error::new( [INFO] [stdout] | ________________________________^ [INFO] [stdout] 222 | | ErrorKind::Other, [INFO] [stdout] 223 | | format!( [INFO] [stdout] 224 | | "Unexpected result from the server: {}: {}", [INFO] [stdout] ... | [INFO] [stdout] 227 | | ), [INFO] [stdout] 228 | | )); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 221 ~ return Err(Error::other( [INFO] [stdout] 222 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:470:21 [INFO] [stdout] | [INFO] [stdout] 470 | cancel_tx.send(()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 470 | let _ = cancel_tx.send(()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 00s [INFO] running `Command { std: "docker" "inspect" "19d587650051634616489e973863cd832489e57b1c664ee74a9ca5d3e79537d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19d587650051634616489e973863cd832489e57b1c664ee74a9ca5d3e79537d7", kill_on_drop: false }` [INFO] [stdout] 19d587650051634616489e973863cd832489e57b1c664ee74a9ca5d3e79537d7